- 14 Oct, 2020 40 commits
-
-
Reda Tawfik authored
Bug: 1104132 Change-Id: I482cceb98f881be84f2e980dd3d9e62a7415978d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465852 Commit-Queue: Reda Tawfik <redatawfik@google.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#816977}
-
Peter Marshall authored
Re-baseline tests for updated devtools behavior. Feature CL: http://crrev.com/c/2443620 Disable CL: http://crrev.com/c/2454721 Bug: 1127827 Change-Id: I3190ae5b0b5498fae3f9a278f5c3d886ec08b647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454085Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#816976}
-
Monica Basta authored
This CL adds tests for all the profile picker main view functionalities. More tests will be added to cover the profile card menu. Bug: 1063856 Change-Id: I89c4e9dfadb38a9635fee10543a10bbedfd06eb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461231 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#816975}
-
Robbie Gibson authored
Now that there is an exernal and internal implementation of this method, it can be used to determine availability of text zoom. Bug: 1061119 Change-Id: Iac6a5ce396f6a153d42502da17f06661ce2052cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465848Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#816974}
-
Clemens Arbesser authored
The main reason for the UaFs was UiController synchronously destroying itself, which lead to UaFs in cases where code was executed after the call to DestroySelf returned. As a workaround, DestroySelf is now asynchronous and merely schedules a call to Shutdown, which will let the current callstack complete and unwind gracefully. Bug: 1134192 Change-Id: I4c42a608b08af0a9243ede2e8ca21808889abc2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461378Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#816973}
-
Peter Beverloo authored
Stop recording the number of sender IDs used for creating a GCM registration, as the data is no longer being used. Extend the LoadStatus one as it reflects our ability to load an on-disk database, failure within which would interfere with the entire system. Bug: 1117108, 1088805 Change-Id: I6f4a90adb637df47b0b7d24f442fd5eb5021bc99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461317 Auto-Submit: Peter Beverloo <peter@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#816972}
-
Anastasiia N authored
Bug: 1135980 Change-Id: Icc9ddf49dc0aa4f077a6312931f6aedd69823bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453990 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#816971}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1602633476-7a781163f6d564d4e8e8516c828c3e90624a360b.profdata to chrome-win64-master-1602644333-c5d02301d4a6428e8ec60219d0e73c3fd904c678.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8c9687c6171928b53177fcfbd4e82220b32985e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469285Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816970}
-
Tanmoy Mollik authored
If the user has only signed in without giving sync consent then toggling "Allow Chrome sign in" off should not show the sign out dialog. Instead it will sign the user out directly without deleting data saved on device Bug: 1136075 Change-Id: I7d8a75a9c2474759f67fbb0018fa68ad3fa16163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460729Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0150a791fcb7..19ee1c94588a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If53e584e8370695297e3d1168de90d6ec6215111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470498Reviewed-by:
-
Polina Bondarenko authored
This is a reland of 725f9a2e Original change's description: > arc: auto-login to MGS with blocked UI screen > > Add an auto-login to Managed Guest Session / public account to start ARC > snapshot creation. > Block auto-login flow even if specified by policy. > Wait for ArcDataSnapshotdManager successfully generates a key pair and > auto-login to MGS once it is ready. > > BUG=b:161221001 > TEST=components_unittests > TEST=browser_tests > > Change-Id: Ib7895f49f9295b3959226cde3e304c9c78614e93 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440872 > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Commit-Queue: Polina Bondarenko <pbond@chromium.org> > Auto-Submit: Polina Bondarenko <pbond@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816186} Bug: b:161221001 Change-Id: I8d435cd9a29e813a473defd695fc25676ec85ae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468118 Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#816967}
-
Renato Silva authored
A minor glitch in the UI was causing both user pods to be active at the same time showing authentication methods. This glitch was only present in real devices since OnSetTpmLockedState is only called when a TPM is available. This CL also fixes a very old bug in the public session pod. When not active, the public session pod shows an arrow that appears when the user hovers on it. When the pod is active, the same arrow is always visible. Clicking on the arrow without the pod being active violates an invariant in the code that requires the pod to be active. With this fix, the public session pod will first simulate a user tap on itself, if it isn't the current active pod. The first issue, coupled with the preexisting public session pod issue made logging in into a managed guest session impossible when there is a user pod in addition to the public session pod. Fixed: 1131704, 1127156, 1127161, 1133926 Change-Id: I0bd0d5d29b0b99c267f2f30283a598955379666a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443291 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#816966}
-
Renato Silva authored
Pressing 'Return' on the PIN input field will now trigger a SmartLock unlock attempt just like on the password field. Added tests to cover this case. Fixed: 1129458 Change-Id: I0ac5860f89f9723a7670aa390fc27e946aac8de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437387 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#816965}
-
Jamie Madill authored
The new oncall is sourced from the internal go/rotations tool. Bug: chromium:1138008 Bug: angleproject:4730 Change-Id: Ide6b3119f86ec65e1298fd64597e9a91fced03c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469716Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#816964}
-
Mohamed Adel authored
- Moves setIcon from notification_builder_base to notification_builder_mac as it is not shared between the builders. - Adds setImagePath in unnotification_builder_mac to set the path of the image that will be attached to the notification Bug: 1136930 Change-Id: I9f5acfac73fc6dd738c4326d865059506e332ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463828 Commit-Queue: Mohamed Adel <adelm@google.com> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#816963}
-
Miyoung Shin authored
This change exposes a Java method on WebContentsObserverProxy that allows it to observe render frame deletion and romoves a map entry in RemoteObjectInjector when renderFrameDeleted is called. Bug: 1105925 Change-Id: I2c155fc22b494efea40c212b2f4f6caac15b70e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462999Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#816962}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a4b5132faf7b..45f024b330f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC swapnilgupta@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: swapnilgupta@google.com Change-Id: I63992d3dfcda7a67864e5cb2d4974ed6a0b052ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470331Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816961}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/19ee1c94588a..1bf2339dc0f8 2020-10-14 hjd@google.com Merge "ui: Download trace in new tab" 2020-10-14 skyostil@chromium.org tracing: Don't try to observe events before connecting If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:170126760 Tbr: perfetto-bugs@google.com Change-Id: I4f5726cdf03777378ee48fe0d35b9e79a784bdfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470335Reviewed-by:
-
Bartek Nowierski authored
Bug: 1073933 Change-Id: I89e3262ac2c7b0900fad8b9dc46a4ea6957ae725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469354 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#816959}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/be423a5eb0e5..166d4461bb51 2020-10-14 aerotwist@chromium.org TypeScriptify ServiceDispatcher 2020-10-14 wolfi@chromium.org [TS] Port ResourcesPanel to TypeScript 2020-10-14 petermarshall@chromium.org timeline: Show JS even when we don't have a V8 invocation above it 2020-10-14 sigurds@chromium.org Introduce weakmap for node property 2020-10-14 changhaohan@chromium.org Fix generate-bridge-file script path 2020-10-14 tvanderlippe@chromium.org Only include legacy file into _module.js bundle if required 2020-10-14 yangguo@chromium.org [ts] type-check WorkSpaceSettingsTab.js 2020-10-14 patrick.brosset@microsoft.com Honour the showUAShadowDOM setting in the layout panel 2020-10-14 yangguo@chromium.org [ts] type-check PersistenceActions.js 2020-10-14 yangguo@chromium.org [ts] type-check PlatformFleSystem.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1127827,chromium:1131500,chromium:1135143,chromium:1136846 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I69b318a2cce5f97584c3d4f2eeb927af4435189e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470333Reviewed-by:
-
Denis Kuznetsov authored
Fix toggle buttons labeling in Welcome->Accessibility dialog, Mark Welcome video and Assistant Ready illustration as ARIA-hidden. Fixed: 1133742,1133737,1133792 Change-Id: Id43b1d45099ab6008bb47dc89da885a5138f2522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468099 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#816957}
-
Denis Kuznetsov authored
Bug: 1133794 Change-Id: If03341ba4fe022b2d24faa4ede1a733770243841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465853 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
-
Anastasiia N authored
Rename existing implementation and all the usages of HasDummyGaiaToken to HasDummyGaiaTokenSync. When all usages will be migrated to the async version, HasDummyGaiaTokenSync will be removed. Bug: 1135980 Change-Id: I1828a623f70dbb572898f3796a539d200b7a9428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452672 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c2553a315f5c..5c64374dd6cb 2020-10-13 afdx@google.com spirv-fuzz: Avoid creating blocks without parents (#3908) 2020-10-13 afdx@google.com spirv-fuzz: Do not allow creation of constants of block-decorated structs (#3903) 2020-10-13 afdx@google.com spirv-fuzz: Fixes related to irrelevant ids (#3901) 2020-10-13 afdx@google.com spirv-fuzz: Fix to transformation that adds a synonym via a loop (#3898) 2020-10-13 afdx@google.com spirv-fuzz: Fix to duplicate region with selection (#3896) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: I146998bc87626666247f0980833378693d11fd3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470027Reviewed-by:
-
Norge Vizcay authored
* Makes use of PasswordForm::affiliated_web_realm to fetch the android URI affiliated domain. * Introduces a new variable url_domain that is used as entry point for automatic password change scripts. Bug: 1136886 Change-Id: Ib394d9b6ad06e5d954f9322a98b7d72c81235a8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452652 Commit-Queue: Norge Vizcay <vizcay@google.com> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
-
Olivier Robin authored
Equivalent call on desktop https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/lifetime/browser_shutdown.cc;l=251 Bug: 1129656 Change-Id: I1d3fa02d942190f32400bc3032aa20fe31c4d338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421735Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#816952}
-
Xiaocheng Hu authored
The function has too many parameters. This patch refactors the parameters into a struct to ease code reading and maintenance. Bug: 1137633 Change-Id: I0123a0c8e5c98d538d6ac7e652ea0797dbf19b27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469360 Commit-Queue: Dominik Röttsches <drott@chromium.org> Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#816951}
-
Monica Basta authored
Bug: 1121215 Change-Id: Ib3d5fc7ce397c56c19dcfdec8261c5a65ab252a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461236Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#816950}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0150a791fcb7..19ee1c94588a 2020-10-14 primiano@google.com Merge "init: mkdir /data/misc/perfetto-configs" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I63b7d6b9c977da66c8cac1248e8a291b95057376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470257Reviewed-by:
-
Luciano Pacheco authored
This is the last batch of dependencies from Files app. Add the entries in the GRD file for files in this CL and for CL:2440331. Bug: 1133198, 1134497, 1023038 Change-Id: I6f8026679f411629d3334f2f85d054245d7afb86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470036Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#816948}
-
Alice Wang authored
This CL adds the metric SignedInWithAddedAccount for the web sign-in flow when a user added an account and signed in with the account. Bug: 1136776 Change-Id: Icb79b2a8cd187aa85e82928692575a351946b888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464266 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9580f3b4c530..39b5e771cd8e 2020-10-14 syoussefi@chromium.org Vulkan: Fix vector size issue with clearWithCommand 2020-10-14 syoussefi@chromium.org Vulkan: Regression test for content defined of AHB images 2020-10-14 syoussefi@chromium.org Vulkan: Don't break the render pass on scissored clears 2020-10-14 syoussefi@chromium.org Vulkan: Regression test for content defined of external images If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Ibce48308805c6c8b1da1cf2b598b33b9da7407d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469711Reviewed-by:
-
Olivier Robin authored
This CL switches the polling ShutdownCheck method to with a direct call to g_pingResultEvent->SignalShutdown(); when g_URLLoaderFactory is reset to nullptr. The polling approach does not work because the delayed task is not executed on shutdown. It is also not needed to poll for shutdown event as the only trigger is the reset of g_URLLoaderFactory value. Bug: 1129656 Change-Id: I70adbf30903cbd31dabf572ac5fd3bfc2c01c7a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424307Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#816945}
-
Victor Hugo Vianna Silva authored
The goal of this CL is to make it clearer in future CLs that DataTypeDebugInfoEmitter can be replaced by simpler code, probably a single function. No behavior is changed. Context: Currently, users of the DTDIE call GetMutable*Counters() to increase some members of its [Commit/Update]Counters, then call Emit*CountersUpdate(), which records UMA based on the deltas of some of these members since the last Emit*CountersUpdate() call. For the UpdateCounters, the emit method is always called "right after" altering the counters, i.e. each pair of calls happens inside a single method of ModelTypeWorker. For the CommitCounters those methods are called in different moments of the lifetime of CommitContributionImpl, but at least they are only used in that layer. The implication of the above is that: 1) Any member of [Commit/Update]Counters that's unused in DTDIE can be removed without behavior change. 2) Any call to DTDIE::GetMutable*Counters() that was used to modify members in (1) can also be removed without behavior change. 3) This DTDIE::EmitUpdateCounters() call [1] can be removed, since it's guaranteed to only emit the modifications caused by the GetMutableUpdateCounters() call 2 lines above, which is now removed due to (2). Note that this if check is important [2]. These removals are interesting because they leave only 1 call of each method of DTDIE in the code, making it easier to reason about the UMA recording. As a bonus, the CL inlines the UpdateCounters and CommitCounters structs inside DTDIE, since their files would soon be removed anyway. [1] https://source.chromium.org/chromium/chromium/src/+/189eb2b0b8589ee2decbfc18aae093397f760ba8:components/sync/engine_impl/model_type_worker.cc;l=379 [2] https://source.chromium.org/chromium/chromium/src/+/189eb2b0b8589ee2decbfc18aae093397f760ba8:components/sync/engine_impl/cycle/data_type_debug_info_emitter.cc;l=34 Bug: 1137896 Change-Id: I0f64d2f8d9e81f23e59cc69e3649f1a2ced2371d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470621 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#816944}
-
Mihai Sardarescu authored
The experiment console orders the buckets alphabetically, so all "Profile 1*" comes after "Profile 1" but before "Profile 2". This makes reading the histogram impossible. This CL attempts to re-label the buckets to ensure that the order in more logical "Profile 01", "Profile 02" .. It also relabels "Profile 100" to "Profile 99+" as it actually tracks all profiles above 99. Bug: None Change-Id: I11f9b95231c51bdb604f9f8366499bbec250c4c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467945Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Id6aa425dc72617875902282f593d70ea9eaf27df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469712Reviewed-by:
-
Leszek Swirski authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7bb48090..cc40f8a7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I592ec5d9fb4f96e51c8c47b30ba50ebf9784b31b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468837Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#816941}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5ae4ed8c588c..be423a5eb0e5 2020-10-14 sigurds@chromium.org Remove legacy accessors after https://crrev.com/c/2467936 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1135143 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I399a42c6cb5a0d0f164cad225fe5fabaa6c19d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470026Reviewed-by:
-
Makoto Shimazu authored
The feature has fully shipped. Let's start removing the flag and code around it. Bug: 824858 Change-Id: I29d9e0724d337ad53129e53d898ad2ef6c693c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470277Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816939}
-
Lei Zhang authored
Per third_party/README.chromium.template, the "Security Critical" entry should say "yes" if the code is shipped in releases. Given third_party/shell-encryption code generates static initializers, as seen in crrev.com/c/2430846, the code is definitely shipped. Presumably private_membership code is in the same situation. Bug: 1066937 Change-Id: Id5a64d0fba01ace9f21f35d75662face7087d358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469838Reviewed-by:
Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Amr Aboelkher <amraboelkher@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@chromium.org> Cr-Commit-Position: refs/heads/master@{#816938}
-
