- 13 Aug, 2020 40 commits
-
-
Ewann authored
Adding: - Edit folder - move folder Bug: 1093302 Change-Id: I76c82a14fdc6956d5412891a2ba7cc575100e653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349305 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#797623}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597275686-7da657e756f53f89a89030a34195741313ee681f.profdata to chrome-mac-master-1597298325-7a1b28e7d249f4f2f87ee413bc832fdaab0b39d9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: If40186f00a641f8d68031d52a98b77d8537f0bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353481Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797622}
-
David Roger authored
Bug: 1076880 Change-Id: Icbdb6c50e53321acd30288e0f14c9f788a46cbe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352230Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#797621}
-
arthursonzogni authored
Those 4 tests are consistently failing on Lollipop: org.chromium.chrome.browser.keyboard_accessory.ManualFillingUiCaptureTest #testCaptureKeyboardAccessoryV2WithPasswords #testCaptureKeyboardAccessoryV2WithPasswordsRTL #testCaptureKeyboardAccessoryWithPasswords #testCaptureKeyboardAccessoryWithPasswordsRTL TBR=fhorschig@chromium.org Bug: 1095672 Change-Id: I4017cc75b4dec74fe91ac7df4bb4ad0aab209c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352915Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#797620}
-
arthursonzogni authored
TBR=wenyufu@chromium.org Bug: 1115870 Change-Id: I7e054c247595b09f3fe83e9063065aff702a80ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352895Reviewed-by:
-
arthursonzogni authored
This test is flaky. In particular on the Marshmallow Tablet Tester: https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%20Tablet%20Tester/b8872140678652429312 TBR=adithyas@chromium.org Bug: 1115888 Change-Id: I933c0e369d93aa343576f03c3f76af8c0ddbc82b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352936Reviewed-by:
-
Antonio Sartori authored
Since the Content-Security-Policy directive `frame-ancestors` is now checked in the browser and no longer in blink, this code should be safe to remove. Bug: 1032139 Change-Id: I25faca527955b374578454ddaf9385e98898bb52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351837Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#797617}
-
Arthur Sonzogni authored
This reverts commit ffd982c9. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1115915 Caused several tests to fail. Original change's description: > Move URL to CriticalPersistedTabData > > This supports the effort of moving fields to UserData objects > so Tab doesn't become too big and unwieldy. > > Bug: 1112357 > Change-Id: I6c484d9586ca8ad7d1866fbbc9dac4735ecf1470 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337673 > Commit-Queue: David Maunder <davidjm@chromium.org> > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797555} TBR=nyquist@chromium.org,dtrainor@chromium.org,jinsukkim@chromium.org,davidjm@chromium.org Change-Id: I084d6dcb0cef11311a8d9d5f8bc26bffe6309339 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1112357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352813Reviewed-by:
-
Matthias Körber authored
Currently, "Apellido Materno" is matched as a middle name although it is actually the second last name. Change-Id: I16086145cc46e29370f313b01bae8bb6c3785203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351917Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#797615}
-
Nohemi Fernandez authored
This patch moves a generic function to the generic EarlGrey testing utilities, ChromeEarlGrey. Bug: 1103274 Change-Id: I2809712839d7cf1860408fa737a661c8e0fc34e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352930 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#797614}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/62f669be69c5..86c9a7134948 2020-08-13 szuend@chromium.org Revert "Remove the previewed class when pressing Escape in the .cls pane" 2020-08-13 mathias@chromium.org Format decoded X-Client-Data HTTP header values as code If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1103854,chromium:1114726 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I11a0e6597e281ad1834dc8fc4a5f578c6ae2f7a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353470Reviewed-by:
-
Anders Hartvoll Ruud authored
There is a desire to change how this works (again) [1], but since all browsers agree on the current behavior, we have to be careful with changes. Hence this CL adds a detailed use-counter. The behavior we want to change can be illustrated with the current example: <style> #outer { --x: foo; } #inner { --x: var(--unknown); } </style> <div id=outer> <div id=inner></div> <div> Current behavior: the computed value of --x on #inner behaves as 'unset', and hence becomes ' foo'. Desired behavior: the computed value of --x on #inner becomes the guaranteed-invalid value [2]. More generally, any property whose grammar "supports" the guaranteed- invalid value shall become guaranteed-invalid if it's invalid at computed-value time (IACVT) [3]. Properties which currently supports this are: unregistered custom properties, and registered custom properties with universal syntax. This CL avoids counting cases where the new behavior wouldn't make a difference: - If the property doesn't support <guaranteed-invalid> - If the property is non-inherited without an initial value - If the property would anyway inherit <guaranteed-invalid> [1] https://github.com/w3c/csswg-drafts/issues/5370 [2] https://drafts.csswg.org/css-variables/#guaranteed-invalid-value [3] https://drafts.csswg.org/css-variables/#invalid-at-computed-value-time Bug: 1110188 Change-Id: I1a230e03b59ee3490166e92e1e83586a681301a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352871 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#797612}
-
Hiroshige Hayashizaki authored
In order to unify script evaluation paths in ScriptController and WorkerOrWorkletScriptController, This CL moves - ReferrerScriptInfo construction, - V8CodeCache::GetCompileOptions(), - V8ScriptRunner::CompileScript(), - V8ScriptRunner::RunCompiledScript(), and - V8CodeCache::ProduceCache() calls from - ScriptController::ExecuteScriptAndReturnValue() and - WorkerOrWorkletScriptController::EvaluateAndReturnValue() to V8ScriptRunner::CompileAndRunScript(). The base URL and ScriptFetchOptions in WorkerOrWorkletScriptController are set so that the existing behavior is preserved. Behavior changes: No changes, except that: probe::ProduceCompilationCache() will be called from WorkerOrWorkletScriptController after this CL. This was only called from ScriptController before this CL. Bug: 1111134, 1114989, 1114994 Change-Id: I989c9a7c3e221f6f2c330849325111e9e209c85f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251439Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#797611}
-
Anastasiia N authored
Change-Id: Ibb33df94135add997de9238ded9772d320880b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346571Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#797610}
-
Julie Jeongeun Kim authored
This CL makes the list container handle the active descendant even though the container is not focused if it has the focused node. On the current code, the list container handles the active descendant only when it is focused. But, some web page could have a input node between a list container and list items and the focus is on the input node, not a container. So, this change checks if the focused node is a descendant of a list container and it handles the active descendant node. AX-Relnotes: n/a. Bug: 1052859 Change-Id: Ib408538d35512ea06174dcb8e3f6ef97b6781907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352293Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#797609}
-
Peter E Conn authored
Change-Id: Iac3857bf4dd252d8a97e35e3de21c03046d2e3d9 Bug: 832124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346652Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#797608}
-
Andreea Bacanu authored
This patch implements the following functionality: - Adding an entry to the cache - Restoring an entry from the cache - Evicting an entry by SessionID - Getting the time to live in the cache - Getting a pointer to an entry from a given SessionID - Evicting an entry after timeout Design doc: https://docs.google.com/document/d/1SF230MYWgroe4WikDMn82ETd3-HFRzylKtIk0HZRaOU/edit?usp=sharing BUG=1100946 Change-Id: Ic1f137c255a9695df080868d217cd3fec7d18690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322967 Commit-Queue: Andreea Bacanu <aebacanu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#797607}
-
Hajime Hoshi authored
SetFirstPaintAfterBackForwardCacheRestoreSwap is called once when OnRestoredFromBackForwardCache is called once, by registering the callback. When OnRestoredFromBackForwardCache was called twice very quickly, two SetFirstPaintAfterBackForwardCacheRestoreSwap might try to set the same end of the timing vector, which was wrong update. This CL fixes this issue by specifying an index at the callback closure, instead of always updating the end of the timing vector. Bug: 1099395 Change-Id: Ic56d2c600d5f08cd7a71e4c03ac84a82a6925115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346690 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#797606}
-
Julie Jeongeun Kim authored
This CL introduces mojom::PrintManagerHost interface to print.mojom and converts PrintHostMsg_DidGetPrintedPagesCount message to DidGetPrintedPagesCount() in mojom::PrintManagerHost. Since all PrintManagers inherited from printing::PrintManager are created with WebContents, it uses WebContentsFrameReceiverSet. printing::PrintManager inherits mojom::PrintManagerHost and implements DidGetPrintedPagesCount(). PrintRenderFrameHelper in renderer process is communicated with it through Mojo for GetPrintedPagesCount. Bug: 1008939 Change-Id: I57674c2e93f042ec3daf54357e2d20663340189a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326857Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#797605}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/338597ba8c41..af63c44964ad 2020-08-13 jleconte@google.com Chrome Perf Dashboard UI links to Monorail bugs are missing project id. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1101773 Tbr: sadrul@google.com Change-Id: I02e07e2218b6aa7a806dbf08bb9f0c4f6aa9082f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353852Reviewed-by:
-
Friedrich Horschig authored
If the password for an App is compromised, the password check now offers a change button to launch the app (provided the app package is locally available). If the app is not installed, a hint informs the user that they can change the password in the app. For regular websites, a CCT will navigate to the index page (or .well-known/change-password if that feature is active). Screenshot in the bug. Bug: 1115117, 1092444 Change-Id: I6debb91070de44af62ecd74ca97fb2e4744d6385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351782 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#797603}
-
Anders Hartvoll Ruud authored
Instead of storing a CSSPropertyValueSet, and then calling GetPropertyCSSValue on-demand, dig out all the CSSValues during construction of the StyleRuleScrollTimeline object. The reason for this is somewhat dull: if a unit test disables the CSSScrollTimeline runtime flag, and *then* tries to access some descriptor using GetPropertyCSSValue, we hit a DCHECK because the descriptor is (no longer) web-exposed. It would have been possible to avoid accessing the StyleRuleScroll- Timeline while the flag is disabled some other way (per test), but it's easier to just allow it in general. Added a bonus unit test for Copy(), since this CL changes how that works. Bug: 1074052 Change-Id: Id59cac2d1e81ea07f1d63a8e1bcdbc10ac55a122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351921Reviewed-by:
-
Yoichi Osato authored
Bug: 1007703 Change-Id: I39d64e4e5814b57dfa69b54fd0ab70e2edfbcd75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340410Reviewed-by:
Mark Seaborn <mseaborn@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#797601}
-
Clemens Arbesser authored
This is a reland of 81959047 There was a missing notification in our bottom bar coordinator, which led to the bottom sheet not resizing properly. No idea why this passed CQ last time, as the test should have failed every time. Original change's description: > [Autofill Assistant] Allow multiple chips in the header. > > This CL allows the header to support a full carousel. > > What it does: > - Move header chip logic into native. > - Use RecyclerView instead of hard-coded single chip view. > - Potentially fixes an issue where the status message does not stretch > across the whole available width. > - Chips in the header now support change animations. > > There is an issue caused by a layout resize when switching between PEEK > and non-PEEK mode. This is further discussed in the linked bug. The > workaround is to delay the layout resize until the sheet state has > settled. > > Bug: b/160856358 > Change-Id: Id7617ed41119b85fdaa00ebaff7e856984b74b0a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288567 > Commit-Queue: Clemens Arbesser <arbesser@google.com> > Reviewed-by: Mathias Carlen <mcarlen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796376} Bug: b/160856358 Change-Id: If3acb7cc6fabcbab7ce9bc82c0664c53110b5cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350419Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#797600}
-
Carlos Caballero authored
Renderers should not be sending any messages through an associated interface if the frame is in the bfcache. We can assume that if such a thing happens the renderer might have been compromised, so kill it. We can only do this reliably for associated interfaces as we can guarantee that after the SetPageLifecycleState ack arrives no more messages should due to the ordering guarantees. Gated with a feature parameter so that we can roll out slowly (and potentially catch renderer bugs). Bug: 1111720 Change-Id: Ib8f0cc967639a2808f4e195f91fce34a58c1d203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312821 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
-
Yuki Yamada authored
In ExecutionContext::NotifyContextDestroyed(), these two things are both happning: - Sensor::ContextDestroyed() is using SensorProxyImpl::sensor_remote_ - SensorProxyImpl::sensor_remote_'s HeapMojoRemote::Wrapper::ContextDestroyed() is closing the mojo connection This CL adds a check if is_bound() to SensorProxyImpl::RemoveConfiguration() since the order of the callbacks will become not unpredictable/deterministic in another CL: https://crrev.com/c/2352292 Bug: 1115411 Change-Id: I1896375f65c812165872990580843571c59e1c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352588Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
Jacques Newman authored
This CL adds the logic for grid-auto-*, bringing the values from style and using them to build ranges. * This change fixes an issue in ConvertGridTrackSizeList where the GridNG computed style was not updated correctly. * The GridPositionResolver has been updated to take only styles, removing the dependency on LayoutBox so it can be used for both legacy grid and GridNG. * As the GridPositionsResolver is 0-based for tracks, and as we intended to switch to start tracks at 0, this change does exactly that. This caused changes in the test expectations. Bug: 1045599 Change-Id: I505baa6a4737400068a1bd81a12492317aace712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321221Reviewed-by:
Ethan Jimenez <ethavar@microsoft.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#797597}
-
Bret Sepulveda authored
This reverts commit 2ea83bd2. Reason for revert: Multiple failing tests on Mac ASAN, see for example https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/64426 Original change's description: > [base] Fail test batches if they leak processes, under POSIX. > > Under Windows and Fuchsia the TestLauncher runs test batch processes in > their own jobs, allowing any leaked sub-processes leaked by tests to be > cleaned up. > > Under POSIX platforms each batch is run in its own process group, but the > group was only being kill()ed if the test batch failed or crashed. > > TestLauncher now proactively kill()s each test batch's process group. The > result of the call is also checked, and the test batch marked as failed > unless kill() reports that the process-group was already gone. > > Note that this will still miss processes launched into new process groups > by tests. > > Bug: 1094369 > Change-Id: If379d200953a823b2020766cda73f8cf27bfdb7f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346388 > Commit-Queue: Wez <wez@chromium.org> > Auto-Submit: Wez <wez@chromium.org> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797277} TBR=wez@chromium.org,tikuta@chromium.org Change-Id: I340068b6f84583af89fa7c75d43566acc2b61537 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1094369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352811Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#797596}
-
Yuchen Liu authored
Changing refresh rate may cause display mode switch. This will lead to black screen flicker on ATV devices. Bug: internal b/162380755 Test: Play YT Change-Id: Icd8d5286fcc27c1b42c53190d9f43b1f99c42957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353711 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#797595}
-
Minoru Chikamune authored
This CL introduces an empty blink::scheduler::AgentGroupSchedulerImpl so that we can land per-AgentSchedulingGroup task queues / runners based on this class. Tentatively, this CL creates an AgentGroupSchedulerImpl per page. This is because we need to initialize AgentGroupSchedulerImpl from the browser side later. [related design doc] https://docs.google.com/document/d/1y-vHkrD1z2RtyWYwT6rJkSLHClYNjDDpUbTtBU7l95A/edit#heading=h.csqx36qhymx0 Bug: 1105403 Change-Id: Ib563f77e4b24a8a72a408735dbc6af5aec26e47d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329950 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
In canary builds (and infrequent on Emulators or very new Android versions), the LifeCycleObserver does not trigger even if the observer is added properly. Although the failure reason is unclear, the fix is simple: forward the corresponding Fragment events through the already existing delegate interface. Bug: 1115124, 1092444 Change-Id: I2fa45d31eba7830fc2a73d6999a2864b6408eeed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352892 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#797593}
-
Rune Lillesveen authored
Trying to add DCHECKs to avoid StyleResolver::StyleForElement() and PseudoStyleForElement() caused a few unit tests to break. This CL advances the lifecycle to allow StyleForElement() to be called on a style-dirty tree in style_resolver_test.cc. Change-Id: Ice81c60cd704f6b718b2a781adf93bc069294446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352732Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#797592}
-
Yuki Shiino authored
Changes the execution context for reporting / measurements from the receiver object's execution context to the current context's execution context. Bug: 839389 Change-Id: Iab09ad3a27df7038d56b9661343dead1d41cb499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352949Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#797591}
-
Christian Dullweber authored
Change-Id: Ia4aa9b7760eba459877c4e10206d4c3eb20a9e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339995Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#797590}
-
Mike Dougherty authored
Links containing Javascript strings can’t be executed in the source frame with WKWebView APIs (pre-iOS14) so removing the option from the context menu is preferable. The user can still copy the javascript from the link. Fixed: 1109120 Change-Id: I7744871aeddbf461b9a1d4ea480c5d9bcd02beed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352639 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
-
Jiewei Qian authored
A generalized OS Settings approach for capturing navigations to SWA. This CL adds support to capture the following navigations, and navigate in a standalone SWA window. - Omnibox: Navigate; Open in new window - Anchor link in a tab, click and context menu - Anchor link in a different SWA, click and context menu - location.href = swa_url - window.open from a different SWA - window.open from the current SWA A followup CL will support capturing navigations in incognito browsers. Currently, these navigations will open SWA in the incognito profile. Bug: 1096345 Change-Id: I4223b8a7dd406229bca793127218d52b625ac0c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321912 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#797588}
-
Matthew Mourgos authored
This change updates the positioning and sizing of the notification app badge to better match the spec. Bug: 1080827 Change-Id: I9fcbde21694e6b054a71c4ef46aeb7b4d3282b61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351456Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#797587}
-
Karel Král authored
Refactor python code responsible for generating C++ function parameter tracing of mojo methods into a standalone module. Bug: 1103623 Change-Id: I39dff196c8227534a6141b0984559e2323ceaaec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346808 Commit-Queue: Karel Král <karelkral@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
chrome://media-appTrent Apted authored
Rethrowing MessagePipe exceptions only makes sense when a particular side of the pipe should _never_ throw an exception. Exceptions that propagate to the other side to be handled should not be re-thrown on the server side. Currently any trusted-context exception will trigger a crash report due to new handling for the `unhandledrejection` event that was added in r790636. Bug: b/163927591, b/158135844 Change-Id: I0d01058b2e34dbf2742ddd05ce54a45007863f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352582Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#797585}
-
Tsuyoshi Horo authored
This reverts commit 7be16f97. Reason for revert: Lack of policy::cookies_allowed, policy::cookies_store in NetworkTrafficAnnotation. Bug: 1115855 Original change's description: > Adding network fetcher for fetching images. > > Change-Id: If4d19d6ba2367f7770c4e77c8f885767171bebe3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350148 > Commit-Queue: Jonathan Freed <freedjm@chromium.org> > Reviewed-by: Dan H <harringtond@chromium.org> > Reviewed-by: Ian Wells <iwells@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797494} TBR=freedjm@chromium.org,iwells@chromium.org,harringtond@chromium.org Change-Id: I3fee310723f20f394e177d8a1b5d08c27687991e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353971Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#797584}
-
