- 07 Dec, 2017 40 commits
-
-
Mohamed Heikal authored
Calling Tab.loadUrl if mNativeTabAndroid is 0 would crash chrome. There has been a few crashes of the sort. This change would make chrome crash on the Java side rather than the native side so that the java stacktrace is visible in the crash. This is a temporary change and will be removed once we have more information or the bug is closed as WontFix. Bug: 662877 Change-Id: I0ad62c757d57c11bc405f6b22fad59f047aad527 Reviewed-on: https://chromium-review.googlesource.com/811987Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#522444}
-
Danyao Wang authored
This is step 3 to removing _lastRegisteredRequestURL from CRWWebController. Bug: 789993,792515 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib3ea5bb686a91e0d28cbb8ec7c1c860518c85090 Reviewed-on: https://chromium-review.googlesource.com/812407 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#522443}
-
Pete Williamson authored
Bug: 792290 Change-Id: I2321ae02cd36e54f372e22edd74db2253dbc6e9a Svelte is a term we use for android devices with <= 512MB memory. We used the OfflinePagesSvelte experiment originally to check if we should do background offlining on Svelte devices at all. We determined that we should, and eventually removed the flag in most places (but not here). This change removes the flag in the final place. There is a similarly named experimental flag for doing 'foreground' offlining on svelte devices - "OfflinePagesSvelteConcurrentLoading". We plan to enable it someday, but first we need to fix chromium so that we don't start an additional process. Chromium promises not to start more than two processes on android svelte devices. Change-Id: I2321ae02cd36e54f372e22edd74db2253dbc6e9a Reviewed-on: https://chromium-review.googlesource.com/813014Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#522442}
-
tzik authored
The DCHECK in WebTaskRunner::PostTask used to ensure that a same thread WTF::Function is posted to the original thread. However, after it is merged to base::OnceCallback, it wrongly rejects base::OnceCallback which may be passed through base::SingleThreadTaskRunner::PostTask. This CL removes the DCHECK to prevent the potential failure. The restriction itself is still checked by a callback wrapper made by WTF::Bind. Change-Id: I5b0cf0a6beb3b88a66a1ce89a8df466379cb9c74 Reviewed-on: https://chromium-review.googlesource.com/813574 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#522441}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/7b0be4ced5f3..bb6ecbad918e $ git log 7b0be4ced..bb6ecbad9 --date=short --no-merges --format='%ad %ae %s' 2017-12-07 dsinclair Fix nits from previous CL. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: If3c609caec836e5571d6b04f5aa14ad2992ee488 Reviewed-on: https://chromium-review.googlesource.com/814275 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522440}
-
Peter Beverloo authored
Bug: 711529 Change-Id: Id64a48214d682f5feba6f6a5f301b394e4a6ce42 Reviewed-on: https://chromium-review.googlesource.com/806274Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#522439}
-
W. James MacLean authored
At present, the implementation of destroyImpl() in guest_view_iframe.js calls handleCallback() in the *middle* of the function, meaning remaining items in the action queue may complete before destroyImpl() finishes updating the state, leading to subsequent commands being dropped if functions like create/attach encounter the non-updated state. This fixes a regression introduced in https://chromium-review.googlesource.com/c/chromium/src/+/528392. It's not obvious if it introduced any failures, but the original CL bypassed browser tests as extensions/renderer/BUILD.gn was missing the relevant files (restored in https://chromium-review.googlesource.com/c/chromium/src/+/812109). Bug: Change-Id: I83db799b73174d3e996677333e01192bf5321460 Reviewed-on: https://chromium-review.googlesource.com/812005Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#522438}
-
Alexey Kozyatinskiy authored
TBR=dgozman@chromium.org Bug: chromium:655701 Change-Id: I11b1d7d75cc1149cccb97fcb1852ae881c26fd90 Reviewed-on: https://chromium-review.googlesource.com/814277Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#522437}
-
Ian Vollick authored
Renames some functions that are no longer trivial and removes some now redundant calls to SetVisible. Bug: None Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3dda5dcb9a225077612050a368a154d95468f681 Reviewed-on: https://chromium-review.googlesource.com/809605 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#522436}
-
Dominic Battre authored
Executing the AnonymizerTool is an expensive operation and should not happen on the UI thread. This CL moves all existing calls on the UI thread to spearate worker TaskRunners. Bug: 787554 Change-Id: I3c096873f784cc2a9dd23f9dd538e2aebd075cd0 Reviewed-on: https://chromium-review.googlesource.com/787713 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Simon Que <sque@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#522435}
-
arthursonzogni authored
Before this patch, the navigation initiator/requestor was set too high in the stack to be reliable. There were pieces of code that were trying to guess what the initiator was (and it was wrong sometimes.) This CL wires this data from where is it available to where is is needed. We say that a request has no initiator when the navigation was not initiated from a document, but from the browser (omnibox, bookmarks, ...). Before this CL and without PlzNavigate, if there was no initiator, the initiator was set to request's url. Now, it doesn't. PlzNavigate and non-PlzNavigate initiators are now the same. It fixes a security issue with Cookies (issue 648608). A regression test is added Bug: 648608,625969 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_site_isolation Change-Id: Ic23f20590a7cf422e08eefe354ff4057f016a987 Reviewed-on: https://chromium-review.googlesource.com/730729Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#522434}
-
Charles Harrison authored
I've noticed that these can be a bit slow, but the async traces make analysis pretty confusing, due to the linked bug. Bug: 783327 Change-Id: I4d46d715d08ed176bec85b0672b24aab2e2b0022 Reviewed-on: https://chromium-review.googlesource.com/810927Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#522433}
-
Biao She authored
Bug: 792600 Change-Id: I5b49dc226ca27cea0b686d3b118956b18d8ddbd4 Reviewed-on: https://chromium-review.googlesource.com/811837Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#522432}
-
Balazs Engedy authored
EarlyInterfaceRequestsFromNewDocumentDispatchedAfterNavigationFinished in RenderFrameHostImplBrowserTest previously assumed that an interface request issued right away by the newly committed document will be necessarily dispatched before DidStopLoading. This is incorrect: tiny testing documents with no subresources to load might stop loading and send FrameHostMsg_DidStopLoading shortly after the load committed, so RenderFrameHostImpl::OnDidStopLoading might end up being invoked before RemderFrameHostImpl::GetInterface is. TBR=nasko@chromium.org Bug: 792863, 729021 Change-Id: I6a631e7e996480fcfd148a54faa8a977386d9e03 Reviewed-on: https://chromium-review.googlesource.com/814096Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#522431}
-
Sylvain Defresne authored
The GetDefaultFactory return a factory that can create instance as the default factory does. It can be used by factories when default is to not create the instance for test BrowserStates. Bug: none Change-Id: I02192ff82e16748eb8f7b69a4c482b3589527b5b Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/811085Reviewed-by:
Elodie Banel <lod@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#522430}
-
Anita Woodruff authored
- When run with --enable-blink-features=NotificationsWithMojo, notification-showing now goes through Mojo. - Tested manually that a notification with the expected origin and title displays when a non-persistent notification is shown. - All other notification data still needs to be hooked up. - Notification events are also not yet implemented, so this patch updates the virtual TestExpectations to skip these/expect timeouts. Bug: 595685 Change-Id: I3f74f0f434db1e639da1b753554e7c4776b58448 Reviewed-on: https://chromium-review.googlesource.com/788153 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#522429}
-
Marc Treib authored
With this, no checksum is required for config.js anymore, which fixes a race condition between serving the checksum and serving the contents themselves. It also lets us remove quite a lot of plumbing :) Bug: 792490, 791969 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I609ef274325bddb49bcbe6e90d58d35b7a385920 Reviewed-on: https://chromium-review.googlesource.com/811185 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#522428}
-
Juan Antonio Navarro Pérez authored
This reverts commit 57425308. Reason for revert: Speculative revert to fix issue 792868. Original change's description: > Add Chrome Policy Blacklist support for Network Service > > In this CL, we create a new implementation of NavigationThrottle, called > PolicyBlacklistNavigationThrottle in which we call into a > policy::URLBlacklistManager implementation during calls to WillStartRequest(). > If the requested URL is in the blocklist, we’d return CANCEL otherwise PROCEED. > > This CL also introduces a KeyedService for accessing the > policy::URLBlacklistManager. > > Bug: 756642 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_site_isolation > Change-Id: I2d9ca0982e78b03be191b67e61eea14764150e68 > Reviewed-on: https://chromium-review.googlesource.com/745326 > Commit-Queue: Doug Turner <dougt@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#522268} TBR=pastarmovj@chromium.org,nasko@chromium.org,jam@chromium.org,boliu@chromium.org,rockot@chromium.org,clamy@chromium.org,dougt@chromium.org,cjennyc28@gmail.com Change-Id: I09dad40ad0dffa4cf7accfc0cd2dbb722b1c651b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 756642, 792868 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/814394Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#522427}
-
Robert Sesek authored
- "ax_tree_error" - "ax_tree_update" - "bad_message_reason" - "font_key_name" - "input-event-filter-send-failure" - "mojo-message-error" - "ppapi_path" - "text-input-context-client" Bug: 598854 Change-Id: Ia5d033e828ffb4341d43085a906551bb1c354e62 Reviewed-on: https://chromium-review.googlesource.com/811896Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#522426}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/5031e5f8b77f..4f5e1d4ff3fa $ git log 5031e5f8b..4f5e1d4ff --date=short --no-merges --format='%ad %ae %s' 2017-12-06 bsalomon Remove SkImage deferred texture image data APIs. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: I57edb66fd167e6cc8f9cbefff986ae1b2b776528 Reviewed-on: https://chromium-review.googlesource.com/814054Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522425}
-
Marc Treib authored
Before this CL, LocalNTPTest.EmbeddedSearchAPIAfterDownload stored a test download file into the system's actual downloads folder, and left it there after the test ended. This CL instead sets up a temporary folder as the download folder. Bug: 592273 Change-Id: I27aa103b4c69b7c6a6bba755f74ee0bcb9fe2c84 Reviewed-on: https://chromium-review.googlesource.com/814115Reviewed-by:
-
Ilya Sherman authored
R=asvitkine@chromium.org Bug: none Change-Id: I392d54d332cd0ec4d43fa3afbfcc8317a1eac165 Reviewed-on: https://chromium-review.googlesource.com/812479 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Marc Treib authored
Bug: none Change-Id: Ibb7291bf3e17228d93f95a05b801289cba55a864 Reviewed-on: https://chromium-review.googlesource.com/814314Reviewed-by:
-
Ilya Sherman authored
R=asvitkine@chromium.org Bug: none Change-Id: I4b4cdbd7d75d243818ddb3f4884b22f43e86de7a Reviewed-on: https://chromium-review.googlesource.com/813281 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Ilya Sherman authored
R=asvitkine@chromium.org Bug: none Change-Id: If153053d1c7cfae0e51c669a53988f6541aa5ccb Reviewed-on: https://chromium-review.googlesource.com/813183 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e3c7cb9c..79bacdd9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I1683fcfd599045ef342b2c812bbc086ff1fa0802 Reviewed-on: https://chromium-review.googlesource.com/813994Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#522419}
-
Ilya Sherman authored
R=asvitkine@chromium.org Bug: none Change-Id: I4e256bef6d7cc6f3af24a5b1241d2279eaf82cad Reviewed-on: https://chromium-review.googlesource.com/813499 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Dave Tapuska authored
Reland https://chromium-review.googlesource.com/804357. This time ensure that we are using a MouseDown event instead of MouseMove event as MouseMove events can be sent from the UI synthetically and that causes the InputMsgWatcher to be in a different state sometimes. Devtools was not correctly handling input that is not generated by itself and invoking callbacks when the input wasn't actually processed. Add a modifier indicating content was injected using the debugger so that we can then query for that to determine if we should release the event. This is a stop gap solution until we can actually bind callbacks into the sending of events and devtools wouldn't need its own queues of callbacks. BUG=789869 TBR=pfeldman@chromium.org Change-Id: Id769fa9363debb196d787a73920f24e3a409c68f Reviewed-on: https://chromium-review.googlesource.com/811833 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#522417}
-
David Roger authored
When the Dice token exchange fails: - if this is a Sync signin, the tab is navigated to the NTP, to match the behavior of the success case - if this is a Sync signin or if Dice is fully enabled for this profile, display the signin error dialog. Bug: 789130 Change-Id: I4a5309a18301c4e3112db50296edd625682f0fd3 Reviewed-on: https://chromium-review.googlesource.com/810805 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#522416}
-
Marti Wong authored
This CL makes Bookmarks ignore the cached path (and starts at root node) when cached path of Bookmarks is a permanent node (Mobile Bookmarks, Bookmarks Bar or Other Bookmarks) and is empty. Egtest is modified accordingly. Bug: 571878 Change-Id: I68773b63e3f12a1ce1e1cf0842c2888dae92d568 Reviewed-on: https://chromium-review.googlesource.com/810185 Commit-Queue: Marti Wong <martiw@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#522415}
-
Martin Sramek authored
Testing under heavy load (on the order of thousands of resource loads writing into the cache and clearing it) did not produce crashes or other adverse effects. Therefore, we reenable the cache datatype for M65. With plenty of time to test on unstable channels of Chromium, and to perform additional heavy load tests, we should be able to re-ship with confidence in M65. Bug: 762417 Change-Id: I17bc1efb38fb9d3f5b7e91de2048420dbe75f6ac Reviewed-on: https://chromium-review.googlesource.com/809128Reviewed-by:
-
Yash Malik authored
Bug: Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I57add5c261f28762a3cec1be364c6be8572703ca Reviewed-on: https://chromium-review.googlesource.com/809606 Commit-Queue: Yash Malik <ymalik@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#522413}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/40f0b37d3b9a..5dcbbfd1533b $ git log 40f0b37d3..5dcbbfd15 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I59f17611592a6f8de076bd4c7c7846911e3eed42 Reviewed-on: https://chromium-review.googlesource.com/813874Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#522412}
-
Kush Sinha authored
Change-Id: Ie70563b27b64bc2c02b0a24ba79d1b35751c2177 Reviewed-on: https://chromium-review.googlesource.com/813918Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#522411}
-
Gauthier Ambard authored
When leaving the NTP, the progress bar of the toolbar was progressing backward before starting the loading. This CL fixes it. Bug: 792791 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I49cbe4073b3d33d1e2fe45e44c588403c44dea7a Reviewed-on: https://chromium-review.googlesource.com/813734Reviewed-by:
-
Becca Hughes authored
Fix overflow icon padding on the new media controls if the overflow icons are enabled. BUG=787445 Change-Id: I2f2ec5a56839ccada45feebcd10b18fcbb82a749 Reviewed-on: https://chromium-review.googlesource.com/813915Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#522409}
-
Morten Stenshorne authored
Let the flex/grid layout algorithm determine the size of tables that are flex/grid items. Don't let the intrinsic width of table columns affect the width of the item. Bug: 782948, 667785 Change-Id: Ifcea6af51ce5bf74377f93b5cd0437272a5c7ef0 Reviewed-on: https://chromium-review.googlesource.com/781859Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#522408}
-
Jérôme Lebel authored
When the sign-in promo view is hidden (by collapsing the "Other Devices" section), Chrome crashes, if the sign-in promo view has to be reloaded (with a new identity added by another app for example). If the section is collapse the sign-in promo should not be updated. The view will be updated later when the user will uncollapse the section. Bug: 776939 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie68ba68e40580b510a782b54ec744865311ed2bb Reviewed-on: https://chromium-review.googlesource.com/811464 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#522407}
-
Shanmuga Pandi M authored
Bug: 769629 Change-Id: I996148aba74d03db821bb5f948d2d60dd321c808 Reviewed-on: https://chromium-review.googlesource.com/813440Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#522406}
-
tzik authored
This CL changes the ownership of base::Clock and base::TickClock from injectee-owned to injecter-owned. Before this CL, these instances are owned by the owner of the injectee or one of the injectees themselves. That makes the ownership complex. After this CL, the clock instances are always un-owned by injectees. Instead, an injecter owned one is used on testing, and the shared instance is used on production path. Bug: 789079 Change-Id: I8af4709520e8c4484ecfe9c71aeb37fe629155d0 Reviewed-on: https://chromium-review.googlesource.com/792756Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#522405}
-
