- 25 Sep, 2020 40 commits
-
-
Gavin Williams authored
In guest mode print jobs did not appear in print management app. This prevented users being able to cancel in-progress jobs. Overriding GetBrowserContextToUse allows using an OTR profile so that jobs appear in the app. Added function BuildInstanceFor for creating PrintManagement service in tests. Bug: 1128690 Change-Id: I837afd57711505e7bf8ab93f9aa38ed16dc5d3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412222 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#810812}
-
Maria Kazinova authored
to AutofillAgent. This fixes a bug when no longer required suggestions are returned asynchronously and are propagated to AutofillAgent latest instead of actually requested suggestions. Bug: 1097015 Change-Id: I263bcf619b1a4898a68837890abe3e5a7a483f8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421460Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#810811}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I6c607fc6831ff6287e405190af6011264277795f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432272Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810810}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I3c58fa8f5e80eae0ce78a5693ca5d3addbd76aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432129Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#810809}
-
David Black authored
Aligning holding space strings with latest spec. Bug: 1128731 Change-Id: Ib99e74abea9898f600b6b752ac8c8018e8f85a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432364Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#810808}
-
Eric Orth authored
Followup to crrev.com/c/2429243. Chrome Java code for reading feature params is done is such a way that it sets its own defaults instead of the ones centrally defined with the feature params in chrome_features.cc Bug: 878582,1098039 Change-Id: Ifef32ee702334e5d422b30490c472b165f3b48cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431790 Auto-Submit: Eric Orth <ericorth@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#810807}
-
Yusuf Sengul authored
Bug: 1131353 Change-Id: I637327b094a6b4421ac5565edcfb9a44a7cfbb08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425749 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#810806}
-
Maxim Kolosovskiy authored
Bug: 1132230 Change-Id: Ief82359c2541d387cb2464c4ae7903075fb32275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432026 Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#810805}
-
Tina Wang authored
Previously we check if the accessibilityHint is set in accessibilityHint method, which blocks the EG test when printing out the UI hierarchy by calling self.accessibilityHint infinitely. Refactor it to customizedAccessibilityHint and expose it in TableViewInfoButtonCell resolve this and make the logic clear. Because for now only settings UI are using TableViewInfoButtonCell and the accessibilityHint for it is customized. This CL is followed by EG test for settings UI. Change-Id: Ic56eb1fdd235bca9da06d076b31ee8c9537c805f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431725Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#810804}
-
David Tseng authored
This change merges the enums chrome.automation.EventType and chrome.automation.GeneratedEventType into one enum. In the native C++ handlers, the two sources of these events is stringified and assumed to be camel-cased which is what automation expects in js. This change also shifts enforcement of the relationshipbetween automation and ax enums from a presubmit to a compilation time warning. At the warning site, a message is left for the change author to consider the change being made and actions to take. This applies to both ax events and ax generated events. Change-Id: I61152f66b2ccf00ba635b2c28caa71fc0caafe5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424854 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#810803}
-
Dominique Fauteux-Chapleau authored
This is a reland of 2e94ca8d that just disables the failing assertion on Mac until the root cause is figured out. Original change's description: > Add accessibility alert event when DeepScanningDialogViews changes > > This allows a screen reader to read the updated text of the dialog. > > Bug: 1131565 > Change-Id: I73a2df8067ffc96148ebf5d50a9412cf34b67feb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424841 > Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> > Reviewed-by: Roger Tawa <rogerta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810290} TBR=rogerta@chromium.org,dmazzoni@chromium.org Bug: 1131565 Change-Id: If8ba41e1490e9cfa0013fc4de145bbdebebc1c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431785Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#810802}
-
Mike Wittman authored
This reverts commit 74826cab. Reason for revert: testing whether this is responsible for rendering.mobile perf regression Original change's description: > [Sampling profiler] Move ENABLE_ARM_CFI_TABLE to profiler header > > ENABLE_ARM_CFI_TABLE is in service of the sampling profiler on Android, > and is unrelated to any debugging functionality, so move it to a > buildflag header under base/profiler. > > Also add the required includes to the files that use it. > > Bug: 1129939 > Change-Id: I884b2128fc2ab2f6f1bec2343c59134448328529 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421443 > Commit-Queue: Mike Wittman <wittman@chromium.org> > Commit-Queue: Lei Zhang <thestig@chromium.org> > Auto-Submit: Mike Wittman <wittman@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809167} TBR=thestig@chromium.org,wittman@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1130974, 1129939 Change-Id: I00050d0bf8cd7988d0ad8969f0b8a29e8accf669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432308Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#810801}
-
Francois Doray authored
TBR=achuith@chromium.org R=achuith@chromium.org Bug: 1132417 Change-Id: I5c1203d7e365efad46aec23fcccbedca14b9af26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432188Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#810800}
-
Mohsen Izadi authored
In a bunch of places, an event is created and then cloned using WebInputEvent::Clone() function without the original event being used anymore. The only purpose of cloning seems to be to create a unique_ptr of the event. Instead, the event can be created on the heap from the beginning to avoid unnecessary cloning. This CL also replaces some emplace_back's with push_back's per https://abseil.io/tips/112. Bug: 1079116 Change-Id: Ib0da3873cc81c4f259f581e4aea08d4a23dab521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429589Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#810799}
-
Daniel Hosseinian authored
PDFiumEngine is sent a request for a thumbnail from the client. If the page is available for rendering, the request is immediately scheduled. Otherwise, the request is scheduled when the page becomes available. Bug: 652400 Change-Id: I9377619a5f71dce5daa727630a9003f2dc9aac5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415588 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Kahmy Moon <kmoon@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#810798}
-
Xiaohan Wang authored
Now they are defined the same. Use `is_linux` everywhere to avoid confusion. Bug: 1132395 Change-Id: Ib6288cefb2b3447b7ead54632f31dd34d778dd6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431777Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#810797}
-
Nicolás Peña Moreno authored
In https://chromium-review.googlesource.com/c/chromium/src/+/2419125 while moving files there were some presubmit checks failing due to use of deprecated tracing APIs. This CL fixes this. Bug: 1038710 Change-Id: I50508b75f1ecc171cab43b9e2c1a7b915d0d8864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431447Reviewed-by:
Deep Roy <dproy@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#810796}
-
Daniel Cheng authored
Change-Id: I28260c2656d1494c9bfb690f8486eacbeb44a53a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296638 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
-
Francois Doray authored
[sheriff] Disable DumpAccessibilityEventsTest.AccessibilityEventsVisibilityHiddenChanged/* on Windows. TBR=dmazzoni@chromium.org Bug: 1084871 Change-Id: I0392f1244aaf5c52ff8c68246360740f8bb6223e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431407Reviewed-by:
-
Jacques Newman authored
This change brings the placement algorithm out of NGGridLayoutAlgorithm and into NGGridAutoPlacement. NGGridAutoPlacement exists only to encapsulate the placement logic, and has a short lifetime on the stack. NGGridAutoPlacement will resolve each GridItemData's position and will ensure track coverage for that position. Currently Auto Placement is implemented only for sparsely packed grids. Bug: 1045599 Change-Id: I5e1889ad5b4ea12cf3526736f71ffc512ae05bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404110 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#810793}
-
Sebastien Marchand authored
Bug: 1131199 Change-Id: I0f640950322650555c1c3b9724020531616bb776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431585Reviewed-by:
Tiancong Wang <tcwang@google.com> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#810792}
-
Prabir Pradhan authored
A stylus device can either report MouseEvents or TouchEvents. Styli used on built-in displays should report TouchEvents, whereas those used on external digitizers should report MouseEvents. This way, moving the stylus on an opaque digitizer will also result in mouse/hover movements. The zcr_stylus interface did not previously have a way to report stylus events that were MouseEvents. We add a zcr_pointer_stylus_v2 interface that extends the wl_pointer protocol so that the following additional details can be reported with MouseEvents: - tool change (mouse, touch, pen, eraser) - force change (pressure) - tool tilt change BUG=b:169094254 TEST=exo_unittests Change-Id: I0c4ac8412e1d5f7f01911ce3e0acbe6f8fbcad4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426981 Auto-Submit: Prabir Pradhan <prabirmsp@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> Cr-Commit-Position: refs/heads/master@{#810791}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d3ba0ee3a4e7..b6c8813f8281 2020-09-25 vidorteg@microsoft.com Locking property names in the styles box diagram 2020-09-25 joselea@microsoft.com Remove experiment for movable tabs 2020-09-25 cpinnamaneni@microsoft.com manifest icon title fix for long strings If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1075732,chromium:1131659 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I198e19d8a3c6514c84116c8e7db330fc67083cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432277Reviewed-by:
-
Keren Zhu authored
Temporarily turn off IPH in incognito as a concern was raised that the IPH backend ignores incognito and writes to the parent profile. See https://bugs.chromium.org/p/chromium/issues/detail?id=1128728#c30 Change-Id: Ide0f21b3cdacd50f7d1ce7462d203139b0bfba31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431731 Auto-Submit: Keren Zhu <kerenzhu@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#810789}
-
Sam Sebree authored
This change addresses an issue in which, when the context URL is not available, popups continue to be blocked despite disabling popup blocking. Bug: 1128530 Change-Id: Ie25127f44da29a88e479ad1eca14ea3a69221b8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425127Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#810788}
-
manukh authored
inline_autocomplet(ion|e_text)][_] were both used to refer to the suffix autocompletion of a match and the omnibox. Likewise, prefix_autocomplet(ion|e_text)[_] were both used to refer to the prefix autocompletion. This CL renames the 'e_text' instances to 'ion' as it's both shorter and the predominant usage. This is just a renaming change with no behaviour change. Bug: 1062446 Change-Id: I979b0fc9a383d319d0dcc62ba833b6ae266b32cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427203Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#810787}
-
Daniel Rubery authored
This CL extends metrics related to Safe Browsing referrer chains, all of which are expected to be useful for diagnosing a regression. Fixed: 1089429, 1089428, 1089427 Change-Id: I7ae3ceeea468faa0439b009fb9d7f6a9132b8afe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429465 Auto-Submit: Daniel Rubery <drubery@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#810786}
-
Eric Orth authored
This struct is designed for use outside the network stack and is used as part of the NetworkService mojo API. Bug: 1129993 Change-Id: I6990e3f65a6a8a5a4d10d2f2f182288c4a0fc697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427024 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Tom Anderson authored
This is needed since some distros do not have libwayland-client available. If systems don't have libwayland-client, they definitely won't have a wayland server either, so it doesn't make sense to statically link libwayland-client, which won't make wayland work and will only waste binary size. Instead, this CL dynamically loads libwayland-client if available. Also, this CL includes some misc fixes to fix the 'ninja all' build for Linux/ozone. R=msisov Bug: 1126894 Change-Id: Ice0fd0b113f5d804cd05089bfad54168d94c53e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416941 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#810784}
-
minch authored
Bug: 1131543 Change-Id: I20ce373294ea711389bcf7673e49eb94fbce07b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431555Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#810783}
-
Olga Sharonova authored
To be observed during experimentation with "OptimizedRealtimeThreadingMac" feature. Should be removed after the feature launched (or cancelled). Bug: 1112952, 1132225 Change-Id: Id8dad2f4de06f61cf3ac1c2e3ba470a5cf223b75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429273 Auto-Submit: Olga Sharonova <olka@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#810782}
-
chrome://omniboxmanukh authored
This CL includes version info (e.g. version, channel, OS, CL, etc) in the JSON download and copy exports. This was already included in batch exports. Bug: 891303, 987279 Change-Id: Ic1b04046320b366b56b7629edbe65892d4fc3c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432045Reviewed-by:
Orin Jaworski <orinj@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#810781}
-
Egor Pasko authored
This is often necessary on Android to read /proc/self/pagemap. Without prctl(PR_SET_DUMPABLE) opening this file fails in 94% of cases on Canary. This potentially leads to bias in reporting MappedAndResidentMemoryFootprint2. What happened since it last landed as http://crrev.com/809373 * Facepalm and negate the condition in PCHECK, prctl returns zero on success * Actually tested the change on a local non-rooted Pixel 2 device with a release official build with android_channel = canary Bug: 1070618 Change-Id: I99b1a4c8bf820fb22e50b49e72522f8ece1e251d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429763 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#810780}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3d9856b0..5eff1172 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5324a11530ae228015eb2dc466d1876738e69015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432046Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810779}
-
Mohamed Amir Yosef authored
Before this CL: When parsing the server response, the field signatures were captured from the processed form by aligning them with the server response. After this CL: Field signatures are read from the server response. Form signatures ,however, are still computed from the processed forms by aligning them with the server response. Bug: 1114655 Change-Id: Id905b8f05c5c0009f34e3147cefd81f79c27ae9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428925Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#810778}
-
Michael Ludwig authored
For some reason, the rebaseline script did not detect a different expected image for 2-comp.html on Mac10.14 for this CL: https://chromium-review.googlesource.com/c/chromium/src/+/2423314 Bug: skia:10205 Change-Id: I8ceb48dbd0a97d2a5ed1ebfacacbab9f7c458732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432744 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#810777}
-
Lei Zhang authored
- Use base::StrCat() to more efficiently concatenate strings. - Use the base::span version of base::Base64Encode(). - Get rid of the weird scoping in CopyImageToClipboard(). - Use base::MakeRefCounted() instead of the new keyword. Change-Id: Ia36fe209b48851000fa875f9e38366660081b8eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429973Reviewed-by:
Ricardo Quesada <ricardoq@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#810776}
-
Karandeep Bhatia authored
Node::GetExecutionContext can return null after the document has been shut down. Early return in SVGFEImageElement::FetchImageResource to prevent a null dereference. BUG=1125293 Change-Id: I130840104b61f072c3c2d3b4d067d6d0be0789c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411394 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#810775}
-
Collin Baker authored
This IPH is currently not in use. With the new FeaturePromoController system re-adding it will be much simpler if needed. Bug: 1106523 Change-Id: Iae709121eaf090aa9ea6e13949918f45854fd08f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432524Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#810774}
-
Francois Doray authored
TBR=battre@chromium.org Bug: 1076487 Change-Id: Ic2671b38d51dbd694f4603f2a1d779567084e854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432365Reviewed-by:
-
