- 17 Oct, 2017 40 commits
-
-
Boris Sazonov authored
This CL fixes a crash introduced by https://crrev.com/c/675684, which added a cache of the account list to AccountManagerFacade. Since the cache is updated asynchronously, the following situation could occur: 1. Account A is added to the account list. 2. AccountManagerFacade starts updating the cache asynchronously. 3. AccountsChangedReceiver notifies AccountTrackerService about the change to the account list. 4. AccountTrackerService gets account list from AccountManagerFacade. AccountManagerFacade returns the cached list (without the account A). 5. AccountTrackerService seeds the old account list and clears the mSystemAccountsChanged flag. 6. AccountManagerFacade finishes updating account list. 7. Now AccountTrackerService considers the account list to be up-to-date and never seeds account A. 8. Some code path tries to get account info for account A and crashes. This CL fixes the issue by adding an AccountsChangeObserver to AccountTrackerService that will invalidate seeding status whenever the cached account list in AccountManagerFacade changes. Bug: 768366 Change-Id: Ia1c8dcb6ac5b4033d6ed1ee204db50aaf8e02964 Reviewed-on: https://chromium-review.googlesource.com/721439 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#509449}
-
Alex Newcomer authored
Pagination grid animations should be constant regardless of whether they are partially completed. I created a new flavor of SlideAnimation for this, which ensures that the duration is dampened if the animation is partway complete. Also I added a new unit test for this new flavor of SlideAnimation. Bug: 771262 Change-Id: Ibb40799cb6d15b04e1e2f9f36ac224c3d28daf13 Reviewed-on: https://chromium-review.googlesource.com/699431 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#509448}
-
Vadym Doroshenko authored
On CL https://chromium-review.googlesource.com/c/chromium/src/+/705636 class AutofillClientIOS was split on 2 classes AutofillClientIOS (base class in components) and ChromeAutofillClientIOS (implementation in ios/chrome/browser). During this refactoring lookup for PersonalDataManager was incorrectly changed this CL returns status quo. Technical details why this change was incorrect: It was changed from PersonalDataManagerFactory::GetForBrowserState(browser_state->GetOriginalChromeBrowserState()) to PersonalDataManagerFactory::GetForBrowserState(browser_state). GetOriginalChromeBrowserState() means return main profile to Incognito profile. So after that change ChromeAutofillClientIOS tries to find PersonalDataManager for Incognito profile. But there is single PersonalDataManager which is bound to the main profile, so look-up GetForBrowserState returns nullptr, and as result in the first place when the code tries to call a method on PersonalDataManager it crashes. Bug: 774704 Change-Id: Iac47cdb71fe6dfb52e1bde7b3000c03c2167a300 Reviewed-on: https://chromium-review.googlesource.com/723423Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#509447}
-
Dave Tapuska authored
Some unit tests will require to check the ordering of method invocations sent to the renderer. Extend the list of dispatched events to be DispatchedMessages and store the relevant information in the new classes. This class will be used to convert the remaining Chrome IPC InputMsg tests to be mojo based. BUG=722928 Change-Id: I4c37c51f2d192e94a69a7050cf9dab87cadabcc7 Reviewed-on: https://chromium-review.googlesource.com/718481Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#509446}
-
Michael Thiessen authored
The wrong head pose was being used for the controller in webvr. This probably doesn't have any noticeable effects, but it's incorrect nonetheless. Bug: Change-Id: Id2c1cc17e0ee6202498cc66eeffc89fd1c8bd644 Reviewed-on: https://chromium-review.googlesource.com/723643Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#509445}
-
Marc Treib authored
This reverts commit f9b5f097. Reason for revert: crbug.com/774798 - let's keep the feature checks around for now. Original change's description: > Cleanup: Remove launched CaptureThumbnail feature checks > > CaptureThumbnailDependingOnTransitionType and CaptureThumbnailOnNavigatingAway > have been launched. This CL removes the feature checks. > > Bug: 765588 > Change-Id: I68906ef0533ede82dc3c47724603b9af78494969 > Reviewed-on: https://chromium-review.googlesource.com/684839 > Reviewed-by: Friedrich Horschig <fhorschig@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#508722} TBR=treib@chromium.org,fhorschig@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 765588 Change-Id: Iaab1b35b3fb00e817e3311e11fffa3a23553ef99 Reviewed-on: https://chromium-review.googlesource.com/723384Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#509444}
-
Martin Barbella authored
Though the component is somewhat reasonable for the documentation, scripts, and other general things, it doesn't make sense for the fuzzers themselves. This is causing issues with automatic component assignment, and could cause confusion during manual triage. Until we have a better solution, we should remove this. R=inferno@chromium.org,mmoroz@chromium.org Bug: 774741 Change-Id: Ia5474fd91e9fbc32d4306565f6058d6f519f26d7 Reviewed-on: https://chromium-review.googlesource.com/723644 Commit-Queue: Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#509443}
-
Ian Kilpatrick authored
This also changes NGLineBoxFragmentBuilder to return a NGLayoutResult, instead of just a NGLineBoxPhysicalFragment. The layout result isn't used yet, but will be soon \o/ Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Id8bde11d7b2a7f3364d575e076b485bf2219e669 Reviewed-on: https://chromium-review.googlesource.com/721685 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#509442}
-
Randy Smith authored
test. Bug: 721395 Change-Id: Iafc5c8ab00b70e87b3c27a5f30003c89004c138c Reviewed-on: https://chromium-review.googlesource.com/721141 Commit-Queue: Randy Smith <rdsmith@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#509441}
-
Nathan Bruer authored
If the filesystem is empty the root folder of a filesystem type project will always exist in the filesystem navigator. R=lushnikov,einbinder,pfeldman BUG=760316,704053 Change-Id: I7364829b247b712bd4b8aa59b490cbdeb514cea2 Reviewed-on: https://chromium-review.googlesource.com/716872Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Blaise Bruer <allada@chromium.org> Cr-Commit-Position: refs/heads/master@{#509440}
-
Ehsan Chiniforooshan authored
Instead of asking all agents to keep track of whether they are currently tracing or not and bail out of StopAndFlush if they are not tracing, the coordinator only sends StopAndFlush to an agent if the agent has successfully started tracing. BUG=774728 Change-Id: I79801d5c66a454ee3bb1ea4c6729039e81c61a82 Reviewed-on: https://chromium-review.googlesource.com/721967 Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#509439}
-
Lei Zhang authored
Also use base::ASCIIToUTF16() where appropriate instead of base: :UTF8ToUTF16(). Change-Id: Ia3f86d40bc5f22d1b80dc2fd59fdca8074fd1678 Reviewed-on: https://chromium-review.googlesource.com/706567Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#509438}
-
Evan Stade authored
- Remove Notification::tag_ (for web notification types, where this is relevant, the tag, if provided, is cooked into the ID) - Replace notifications based on ID (along with profile). For most notifications, this should be a no-op. For those that previously didn't specify tags, this may mean less notification spam as two notifications with the same ID will not be shown together. - Remove c/b/notifications/Notification and just use message_center::Notification. Bug: 763426 Change-Id: Id9ef84a40c51b28f27b951ca27e357c53408b998 Reviewed-on: https://chromium-review.googlesource.com/699797 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#509437}
-
Greg Kerr authored
This fixes the sandbox rules to access timezone information specifically on 10.13. Bug: 773532 Change-Id: I32dc858a9607b10aa7db4df464a627d02d89b683 Reviewed-on: https://chromium-review.googlesource.com/722203Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#509436}
-
Xianzhu Wang authored
Now we can always use DrawingRecorder. Bug: 657186 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I98d6cab01b87cba9c5d68dd72dcb54e0248da994 Reviewed-on: https://chromium-review.googlesource.com/721602 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Walter Korman <wkorman@chromium.org> Cr-Commit-Position: refs/heads/master@{#509435}
-
Jonathon Kereliuk authored
This reverts commit 4bd0cd56. Reason for revert: broke the windows build, also didn't merge with current master recent enough Original change's description: > [ChromeDriver] Key type actions for the actions API > > This CL contains the key type actions. Follow up CLs for tests and > pointer/pause actions > > spec: https://w3c.github.io/webdriver/webdriver-spec.html#actions > > Bug: chromedriver:1897 > Change-Id: I135df58d97a45494e51a5ac09dfce021f7d094d3 > Reviewed-on: https://chromium-review.googlesource.com/692599 > Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#508958} TBR=johnchen@chromium.org,kereliuk@chromium.org Change-Id: I277dd783cc2a9e3f66615fb42eacabd07dcce71f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromedriver:1897 Reviewed-on: https://chromium-review.googlesource.com/721259Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#509434}
-
Reilly Grant authored
These new tests (added in r508890) time out when run with the Network Service enabled. This does not appear to be a new issue as other tests from this suite were already marked as failing. TBR=yzshen@chromium.org Bug: 775104 Change-Id: Ic86e8407b94c09ec445f671894e9af6d1b8bf4f6 Reviewed-on: https://chromium-review.googlesource.com/721247Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#509433}
-
Victor Costan authored
gitiles supports svg, according to https://github.com/google/gitiles/blob/master/gitiles-servlet/src/main/resources/com/google/gitiles/mime-types.properties Bug: Change-Id: I87e54da98d434b0a932349b682f35e53a6d640a8 Reviewed-on: https://chromium-review.googlesource.com/722425Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#509432}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/90fffb31e2ec..f9068a5c08e5 $ git log 90fffb31e..f9068a5c0 --date=short --no-merges --format='%ad %ae %s' 2017-10-16 rharrison Convert XFA Doc Types to be more precise Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Idacd989697c0508f43449a9dbddf4568397a2a28 Reviewed-on: https://chromium-review.googlesource.com/723126 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#509431}
-
Hugo Holgersson authored
Bug: 774058 Change-Id: I05e14895d59609144b76264f04d081ee8657caeb Reviewed-on: https://chromium-review.googlesource.com/718936 Commit-Queue: Hugo Holgersson <hugoh@vewd.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#509430}
-
Daniel Bratell authored
This is preporatory patch to make content/browser able to do jumbo compiles, i.e. compilation with many cc files merged into one translation unit. For that to compile, names need to be a bit more unique than they are today. Bug: 746953 Change-Id: Ie7cb7445d3662d47372bde78df705aec7b130ed5 Reviewed-on: https://chromium-review.googlesource.com/721021 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#509429}
-
Peter Collingbourne authored
Start with a small number of test suites for now. The rest will need to wait until the patches from the associated bug land. Bug: 742655 Change-Id: I42d0fb8301c9f4f8e61a90b17d645d10be649c34 Reviewed-on: https://chromium-review.googlesource.com/722170Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#509428}
-
Jonathan Ross authored
This reverts commit 3bc3b8b6. Reason for revert: <INSERT REASONING HERE> Original change's description: > [vr] Measure text render speed in GTest > > This change also adds a new target for performance tests in VR > and a target for dependencies shared among vr test targets. > > Bug: 772551, 774636 > Change-Id: I7de0cd8a5fcba3e71358625c1f3ebfb9bab49fba > Reviewed-on: https://chromium-review.googlesource.com/703690 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#509419} TBR=vollick@chromium.org,sky@chromium.org,leilei@chromium.org,cjgrant@chromium.org,tiborg@chromium.org Change-Id: I024ea3fdb07bcf76fa1bdd50e235cc69dee00fa7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 772551, 774636 Reviewed-on: https://chromium-review.googlesource.com/723748Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#509427}
-
nednguyen authored
Since we switched to WPRGO (bit.ly/wpr-go-migration), the Python crypto bugs has become obsolete. Change-Id: Iafa90c549bbee8e6b60091b54b7bcfed149ce913 Reviewed-on: https://chromium-review.googlesource.com/723579Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#509426}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f424d357ecc4..6342128c3c81 $ git log f424d357e..6342128c3 --date=short --no-merges --format='%ad %ae %s' 2017-10-16 dnj [cipd] Add support for ppc64 and ppc64le. Created with: roll-dep src/third_party/depot_tools BUG=773857 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=phajdan.jr@chromium.org Change-Id: I7b4b1f01af1ce75bb9859d99c990e0410d5e3a18 Reviewed-on: https://chromium-review.googlesource.com/723135Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#509425}
-
Greg Kraynov authored
Added traceable states inder disabled-by-default category beacuse adds visual noise (needs proper grouping and labeling). Bug: 765660 Change-Id: I61fb9275d68103940c5feb6016ff572309475a37 Reviewed-on: https://chromium-review.googlesource.com/721123Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Grigoriy Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#509424}
-
Tom Sepez authored
Adds a missing #undef that is required now that jumbo re-introduced header guards on some of these files. Change-Id: Id17dd83a83236832fefd7cab266afaa1c850eaee Reviewed-on: https://chromium-review.googlesource.com/721731Reviewed-by:
Daniel Bratell <bratell@opera.com> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#509423}
-
Jean-François Geyelin authored
During the presentation animation of the Camera Scanner, the BVC (which is a superview of the infobars) scrolls up offscreen. This was triggering the DCHECK. Bug: None Change-Id: If2ca09c10ef26a281d3de52fd12a815a4c14ce0d Reviewed-on: https://chromium-review.googlesource.com/723620Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Jean-François Geyelin <jif@chromium.org> Cr-Commit-Position: refs/heads/master@{#509422}
-
Marti Wong authored
Exit selection mode after following actions: 1. Select single url -> More -> Copy URL 2. Select urls/folders -> More -> Move 3. Select single url/folder -> More -> Edit -> Edit title/url -> Done And stay in selection mode after following actions: 1. Select single url/folder -> More -> Edit -> Cancel 2. Select single url/folder -> More -> Edit -> Move 3. Select single url/folder -> More -> Edit -> Delete Egtests are modified accordingly to verify the above behavior. Bug: 774385 Change-Id: I92fbff7613b910982163367d099dc3dc5ba4a021 Reviewed-on: https://chromium-review.googlesource.com/721222 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#509421}
-
Mike Reed authored
but it is not always exported to chrome, so name it explictly in skia_library_config. Bug: skia:7176 Change-Id: I4bc926dfb7e6a9c30daafd85b09fe501802f22b4 Reviewed-on: https://chromium-review.googlesource.com/723501Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@chromium.org> Cr-Commit-Position: refs/heads/master@{#509420}
-
Tibor Goldschwendt authored
This change also adds a new target for performance tests in VR and a target for dependencies shared among vr test targets. Bug: 772551, 774636 Change-Id: I7de0cd8a5fcba3e71358625c1f3ebfb9bab49fba Reviewed-on: https://chromium-review.googlesource.com/703690 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#509419}
-
Gauthier Ambard authored
BbrSenderTest tests are failing on iOS due to a memory issue. Disabling them to have the tree green. Bug: 775492 Change-Id: I57b183702ac09f164d557c1da6a0102226ec9974 Reviewed-on: https://chromium-review.googlesource.com/723220 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#509418}
-
Tim Dresser authored
Previously, we incorrectly modified the trace ID of LatencyInfo objects which were being coalesced. This caused their async events to never terminate. Now we don't modify the trace ID during coalescing. Bug: 771165 Change-Id: I1e73b97579333b9be67886b4a93e53e8315d30cb Reviewed-on: https://chromium-review.googlesource.com/700406Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#509417}
-
Matt Menke authored
These files will eventually move into the network service, and makes everyone's lives easier not to have to ping a content/ owner to update them. Bug: None Change-Id: I8e2f2f8b9684962dcb3ad2da3414b12bdd79521d Reviewed-on: https://chromium-review.googlesource.com/690241Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#509416}
-
Yuzhu Shen authored
BUG=715673 Change-Id: I5d2439550c4253bc0cfc43b6b50585e26f4e45af Reviewed-on: https://chromium-review.googlesource.com/717066Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Jialiu Lin (Slow Oct 13-20, OOO Oct 21-29) <jialiul@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#509415}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1009ba6f. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/3350 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: alexander.shalamov@intel.com, mikhail.pozdnyakov@intel.com, rijubrata.bhaumik@intel.com, timvolodine@chromium.org: external/wpt/generic-sensor TBR=qyearsley@chromium.org No-Export: true Change-Id: I3a4fb8b59efed456c93000e5b516da52a8ba052f Reviewed-on: https://chromium-review.googlesource.com/723159 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#509414}
-
John Abd-El-Malek authored
This reverts commit 1cf9f36e. Reason for revert: this is causing build flake, i.e. see https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux%2Flinux_chromium_chromeos_rel_ng%2F530538%2F%2B%2Frecipes%2Fsteps%2Fcompile__with_patch_%2F0%2Fstdout The problem is that depending on "//third_party/WebKit/Source/platform/blob:generator doesn't generate the headers for url.mojom-blink.h Original change's description: > Reland "Reland "Split WebKit platform build file"" > > test_support of platform/loader and platform/network should > depends on //storage/public/interfaces:interfaces_blink__generator > because it indirectly includes generated mojo interface headers. > > This is the root cause of the original issue, and it seems > BUILD file splitting makes it happens more easily. > > This is a reland of 997ce7ad > Original change's description: > > Reland "Split WebKit platform build file" > > > > platform/network/BUILD.gn lacked mojo_bindings_blink dependency. > > This caused a race on compiling. > > > > This is a reland of 080c70a7 > > Original change's description: > > > Split WebKit platform build file > > > > > > A race condition was found in the build of //third_party/WebKit/Source/platform/loader. > > > To resolve it necessary to extract targets //third_party/WebKit/Source/platform/blob and //third_party/WebKit/Source/platform/network form //third_party/WebKit/Source/platform. And add correct dependencies where it is needed. > > > All of these done in this CL. > > > > > > Original author is apisarev@yandex-team.ru, and toyoshim@chromium.org takes over it > > > to submit since it needs quick rebase works to catch up HEAD. > > > > > > Bug: 754600 > > > Change-Id: I5f70348fac10f270df99b658608cf23685ed937e > > > Test: gn check out/Release && ninja -C out/Release > > > Reviewed-on: https://chromium-review.googlesource.com/612284 > > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > > > Reviewed-by: Daniel Bratell <bratell@opera.com> > > > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > > Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#508661} > > > > TBR=engedy@chromium.org > > > > Bug: 754600 > > Change-Id: I250e67581e61e1d36c32b01ccad3372b442c08bc > > Reviewed-on: https://chromium-review.googlesource.com/718243 > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#508993} > > TBR=engedy@chromium.org > > Bug: 754600 > Change-Id: Ia1231a3ee2213bb44474bd8ffeacf67b86002bfd > Reviewed-on: https://chromium-review.googlesource.com/720542 > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#509359} TBR=kinuko@chromium.org,toyoshim@chromium.org,engedy@chromium.org,bratell@opera.com,eae@chromium.org,apisarev@yandex-team.ru,dglazkov@chromium.org Change-Id: I4f00547b80b6ec33d3efb756460073149c12f2c7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 754600 Reviewed-on: https://chromium-review.googlesource.com/723739Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#509413}
-
Xiaocheng Hu authored
This patch adds a new text mismatch type, LayoutNG name mismatch, so that we can efficiently filter test failures due to reporting LayoutNG names instead of legacy layout names, e.g., LayoutNGBlockFlow instead of LayoutBlockFlow. Bug: Change-Id: Icebd7b8b3a608864d7fcad68e4a6c6584e2dd557 Reviewed-on: https://chromium-review.googlesource.com/722458Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#509412}
-
Miguel Casas-Sanchez authored
This CL adds a gfx::ColorSpace |color_space_| to DisplaySnapshot and teaches both IPC and Mojo how to serialize/deserialize it. drm_util.cc also gets a new method to create a gfx::ColorSpace out of edid_parser.{cc,h} functions, and uses it to fill in the said class. Bug: 771345 Change-Id: I6b7ea390e730a38b83272d772039d4a06e914af3 Reviewed-on: https://chromium-review.googlesource.com/709696Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#509411}
-
Pavel Feldman authored
Change-Id: Ife445be39e0c6be0cec0abfc154c700b275b7433 Reviewed-on: https://chromium-review.googlesource.com/721802Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#509410}
-