GitLab

When moving an NTP (very specific to the NTP URL) across
CTA instances, it would put the ref in AsyncTabParams, but
would not use it when creating the tab in the second window.

This was bad because it kept a reference to the incognito
tab forever (preventing the profile from being deleted and
the notification from going away).

This also changes the PendingIntent flag to allow the
notification to take an action as long as it is visible
(then if cleaning up the incognito tabs fails the first
time, the second click might succeed).

BUG=673582, 673489

Review-Url: https://codereview.chromium.org/2574143004
Cr-Commit-Position: refs/heads/master@{#438648}

BUG=673961
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2575673002
Cr-Commit-Position: refs/heads/master@{#438647}

This patch migrates a few more instances of icons onto UI.Icon:
- console's expand stack trace triangle
- styles sidebar pane's expand triangle for longhands
- blockedURL's "remove" button

BUG=669323
R=dgozman

Review-Url: https://codereview.chromium.org/2570783006
Cr-Commit-Position: refs/heads/master@{#438646}

Revert of Android: Switch to thread pool executor (patchset #7 id:120001 of https://codereview.chromium.org/2562643004/ )

Reason for revert:
BackgroundSyncLauncherTest#testNewLauncherDisablesNextOnline fails.

Original issue's description:
> Android: Switch to thread pool executor.
>
> Switches BackgroundSyncLauncher to the thread pool executor and add
> comments explaining why AsyncTask is necessary.
>
> BUG=601053
>
> Committed: https://crrev.com/ad3ee42510afda09e00cb73c694bfa4626980d1d
> Cr-Commit-Position: refs/heads/master@{#438573}

TBR=iclelland@chromium.org,mariakhomenko@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=601053

Review-Url: https://codereview.chromium.org/2580503002
Cr-Commit-Position: refs/heads/master@{#438645}

This is the first CL to remove multi-install from the codebase. With
this change, "--multi-install" is ignored on the command line and in
master preferences. All installs will henceforth be single-install. All
over-installs and updates will henceforth migrate an existing
multi-install back to single-install.

This CL also contains the following changes to mini_installer to report
state properly regardless of whether updates are being delivered via
Chrome's or the binaries' app guid:
- "-full" is added to both Chrome's "ap" value and, in case an existing
  multi-install Chrome is being updated, the binaries' "ap" value.
- Installer results are written both to Chrome's ClientState key and, as
  above, the binaries'.

Tangentially, this CL also cleans up some minor Chromium vs. Google
Chrome issues with the mini_installer and fixes function ordering
somewhat.

BUG=577816
R=gab@chromium.org

Review-Url: https://codereview.chromium.org/2507293005
Cr-Commit-Position: refs/heads/master@{#438644}

This is used whenever the watchdog service (daisydog) fails to start up
correctly.  We don't expect this to happen on real devices, so we want
to get a handle if it actually does (and how often).

BUG=673501

Review-Url: https://codereview.chromium.org/2571873002
Cr-Commit-Position: refs/heads/master@{#438643}

Would like to have this script replace the logic in recipes that
downloads the CTS zips, unzips it, and runs it via tradefed.

Review-Url: https://codereview.chromium.org/2551353004
Cr-Commit-Position: refs/heads/master@{#438642}

Some products do not register with WMI or Security Center. Add a
"best effort" attempt to enumerate these and add them to the
system profile, starting with IBM/Trusteer Rapport Endpoint Security.

BUG=615154
TEST=manual - see https://docs.google.com/document/d/1DNWXftKWmC76987dN8-d0v7mwPz40SrJzl6KxUNjwlY/edit

Review-Url: https://codereview.chromium.org/2578453002
Cr-Commit-Position: refs/heads/master@{#438641}

These classes were refactored to decouple them from BookmarkModel. Now
that the refactoring is complete, rename the classes and methods to remove
references to bookmarks.

BUG=630769

Review-Url: https://codereview.chromium.org/2569333003
Cr-Commit-Position: refs/heads/master@{#438640}

BUG=656807
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2570873003
Cr-Commit-Position: refs/heads/master@{#438639}

BUG=658929
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2576813002
Cr-Commit-Position: refs/heads/master@{#438638}

https://pdfium.googlesource.com/pdfium.git/+log/603f57b85c06..0d73909e89a5

$ git log 603f57b85..0d73909e8 --date=short --no-merges --format='%ad %ae %s'
2016-12-14 tsepez Remove CJBig2_List in favor of std::vector<std::unique_ptr<>>

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2572213002
Cr-Commit-Position: refs/heads/master@{#438637}

Revert of Disable all GPU tests on N5X bot temporarily. (patchset #1 id:1 of https://codereview.chromium.org/2562133002/ )

Reason for revert:
N5X problems might be fixed. Reverting to test that assumption.

Original issue's description:
> Disable all GPU tests on N5X bot temporarily.
>
> This bot config is having stability problems - disable all tests until
> the issue is resolved.
>
> BUG=672502
> NOTRY=true
> NOPRESUBMIT=true
> R=kbr@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
>
> Committed: https://crrev.com/9b5a07979aa2dcfd2698646be9b3c8a6ed6768dd
> Cr-Commit-Position: refs/heads/master@{#437676}

TBR=kbr@chromium.org,jmadill@chromium.org
NOTRY=true
NOPRESUBMIT=true
BUG=672502
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2577793002
Cr-Commit-Position: refs/heads/master@{#438636}

BUG=646698

Review-Url: https://codereview.chromium.org/2572133003
Cr-Commit-Position: refs/heads/master@{#438635}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/4c2a679b9012..6a5ce5c1dff4

$ git log 4c2a679b9..6a5ce5c1d --date=short --no-merges --format='%ad %ae %s'
2016-12-14 eyaich Revert of [Telemetry] Increase timeout after sending SIGTERM (patchset #2 id:20001 of https://codereview.chromium.org/2568033003/ )

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2574423002
Cr-Commit-Position: refs/heads/master@{#438634}

BUG=622440
R=dgozman

Review-Url: https://codereview.chromium.org/2571813003
Cr-Commit-Position: refs/heads/master@{#438633}

BUG=None

Review-Url: https://codereview.chromium.org/2571123002
Cr-Commit-Position: refs/heads/master@{#438632}

BUG=670817
TBR=kbr@chromium.org,jmadill@chromium.org
NOTRY=true
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2577803002
Cr-Commit-Position: refs/heads/master@{#438631}

Follow up to https://codereview.chromium.org/2551283002/

BUG=none
R=lushnikov

Review-Url: https://codereview.chromium.org/2566463003
Cr-Commit-Position: refs/heads/master@{#438630}

This is a code clean up CL, in which we remove the code for old UI of
desktop capture picker. As we found the new UI works well.

BUG=644811

Review-Url: https://codereview.chromium.org/2560333002
Cr-Commit-Position: refs/heads/master@{#438629}

BUG=670431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2562123002
Cr-Commit-Position: refs/heads/master@{#438628}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3ca06164..285b9f5a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2576803002
Cr-Commit-Position: refs/heads/master@{#438627}

BUG=673855

Review-Url: https://codereview.chromium.org/2529043003
Cr-Commit-Position: refs/heads/master@{#438626}

Avoid an "Unable to thaw renderers." LOG(FATAL) in
RendererFreezer if freezing the renderers also failed
earlier. This is a workaround for unexplained EBADF and
ENOENT errors seen when writing to cgroups.

BUG=chromium:661310
TEST=manual: log in and chmod freezer.state in
     /sys/fs/cgroup/freezer/chrome_renderers/to_be_frozen
     to 444; suspend and resume and check that chrome
     doesn't abort

Review-Url: https://codereview.chromium.org/2575933002
Cr-Commit-Position: refs/heads/master@{#438625}

BUG=555865

Review-Url: https://codereview.chromium.org/2436023002
Cr-Commit-Position: refs/heads/master@{#438624}

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/dom/.
There are too many references to change them all at once, so this CL is
part 4 of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2574773002
Cr-Commit-Position: refs/heads/master@{#438623}

WindowObserver::OnWindowVisibilityChanged() is called any time the
visibility of a descendant changes. This means if the visibility of a
child of a window shown on the shelf changes and the child's type is other
than none, then an entry is added to the shelf. I don't believe this would
happen for aura, but for mus the default type is TYPE_APP (unless
explicitly set).

BUG=none
TEST=covered by test
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2576023002
Cr-Commit-Position: refs/heads/master@{#438622}

This is a debugging feature that will be used on the official Win64 continuous builder to get a repro for some linker failures that we're observing. Having a link repro is the only way for us to report this kind of error to Microsoft in order for them to fix it (we haven't been able to reproduce this linker failure locally, but this hit us really often on the official builders).

BUG=669854
TBR=bengr@chromium.org

Review-Url: https://codereview.chromium.org/2570483004
Cr-Commit-Position: refs/heads/master@{#438621}

This change introduces SyncServiceBase as a base class of PSS and
consolidates engine initialization logic into it from PSS and SBHI.

This new class will enable us to siphon logic out of SBHI until it can
become SyncEngineProxy (no business logic). This change also begins
aligning SBHC with the SyncEngine interface, so it can eventually become
SyncEngineImpl.

BUG=669967

Review-Url: https://codereview.chromium.org/2559123002
Cr-Commit-Position: refs/heads/master@{#438620}

BUG=669096

Review-Url: https://codereview.chromium.org/2565343005
Cr-Commit-Position: refs/heads/master@{#438619}

BUG=674182
R=rohitrao@chromium.org

Review-Url: https://codereview.chromium.org/2565283010
Cr-Commit-Position: refs/heads/master@{#438618}

This change makes it possible to call createImageBitmap with
an OffscreenCanvas object as an argument.  It also takes care
of propagating the origin-clean flag.

BUG=672571
TBR=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2570613002
Cr-Commit-Position: refs/heads/master@{#438617}

Without this, the call to setStyle in Document::updateStyle would temporarily
mark the LayoutView as overflow: visible.  With root layer scrolling this causes
PaintLayerScrollableArea to remove the scrollbars.

This change has no effect on the document's final overflow style, which comes
from inheritHtmlAndBodyElementStyles (and is never "visible" regardless of RLS).

This relands r438533 which was reverted in r438537.

BUG=672335

Committed: https://crrev.com/0cc860d2c6075b9afb96f566a370f62972a758e0
Review-Url: https://codereview.chromium.org/2571893003
Cr-Original-Commit-Position: refs/heads/master@{#438533}
Cr-Commit-Position: refs/heads/master@{#438616}

Currently FetchHeaderList::sortAndCombine() only sorts the list and does not
combine values for the same key. This CL implements the missing part in the
function.

BUG=670439, 667376

Review-Url: https://codereview.chromium.org/2559273005
Cr-Commit-Position: refs/heads/master@{#438615}

The only button that shouldn't be draggable is the app list.
(arc deferred items were incorrectly marked non-draggable)
Remove the item delegate function to simplify shelf view code.

Add test support for trying to drag the app list button.
Update and expand the related unit test.

BUG=557406
TEST=Automated; no shelf dragging behavior changes.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2575613002
Cr-Commit-Position: refs/heads/master@{#438614}

https://skia.googlesource.com/skia.git/+log/7a1cc6766d07..e305cc1f2a44

$ git log 7a1cc6766..e305cc1f2 --date=short --no-merges --format='%ad %ae %s'
2016-12-14 robertphillips Partially defer GrSWMaskHelper
2016-12-14 scroggo Remove SkKTXImageEncoder
2016-12-14 fmalita SK_API-export SkCodec
2016-12-08 scroggo Add SkCodec::FrameInfo::fFullyReceived
2016-12-14 reed remove PLAIN_ENUM flag for SkClipOp
2016-12-14 reed add tests/bench for dynamicwstream

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2574323003
Cr-Commit-Position: refs/heads/master@{#438613}

BUG=664488
TEST=content_unittests,gpu is enabled in win/NVidia
R=kbr@chromium.org,kkinnunen@nvidia.com

Review-Url: https://codereview.chromium.org/2569413002
Cr-Commit-Position: refs/heads/master@{#438612}

Attempt #2. Previous one had missing SetRenderFrameHost call.

BUG=664683
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2572933002
Cr-Commit-Position: refs/heads/master@{#438611}

No intended behavior change.

BUG=

Review-Url: https://codereview.chromium.org/2569013003
Cr-Commit-Position: refs/heads/master@{#438610}

This is done by storing the source RenderViewHost and RenderProcessHost for each dragstart. Then, for other drag events (like dragover), if the target frame for that event is in the same RenderViewHost, but different RenderProcessHost, than the source, then the event is not fired.

Note that this patch will not affect behavior on Mac, and a subsequent CL will enforce the same thing for Mac.

BUG=666858

Review-Url: https://codereview.chromium.org/2568893002
Cr-Commit-Position: refs/heads/master@{#438609}