GitLab

Remove ContainerNode overload for NodeTraversal::nextSkippingChildren() as it
adds no benefit compared to the one taking a Node in argument.

The nextSkippingChildren() implementation does not involves visiting the
children (and thus calling firstChild() / lastChild()). Therefore, there is no
benefit to knowing that the argument is a ContainerNode (unlike for
NodeTraversal::next()).

This CL also does the same for ElementTraversal::nextSkippingChildren().

R=esprehn@chromium.org, adamk@chromium.org

Review URL: https://codereview.chromium.org/420603012

git-svn-id: svn://svn.chromium.org/blink/trunk@179055 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I need this to be able to remove blink_common_resources from Chromium.

BUG=338338
TEST=None
R=brettw@chromium.org,
TBR=abarth@chromium.org

Review URL: https://codereview.chromium.org/424503002

git-svn-id: svn://svn.chromium.org/blink/trunk@179053 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We are not yet able to use inspector agents when the top-level frame is
in another process. This patch prevents a crash in that scenario.

BUG=357747

Review URL: https://codereview.chromium.org/422943002

git-svn-id: svn://svn.chromium.org/blink/trunk@179052 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As a part of ScopedStyleTree removal (issue 392018),
remove all private members in ScopedStyleTree.

|m_cache| is no longer necessary as ScopedStyleResolver
lookup from an element no longer require ascending the
DOM tree up, thanks to <style scoped> removal.

Unfortunately |m_authorStyles| cannot be removed completely
- StyleResolver still has to clear ScopedStyleResolvers
which are associated with TreeScopes, and thus moved from
ScopedStyleTree to StyleResolver (and renamed
|m_scopedStyleResolvers| to match what it contains).

BUG=392018
TEST=no layout test failures

Review URL: https://codereview.chromium.org/418833002

git-svn-id: svn://svn.chromium.org/blink/trunk@179051 bbb929c8-8fbe-4397-9dbb-9b2b20218538

used during a single invalidation.

These makes makes its intended object data lifetime clearer and avoids possible bugs.

BUG=379908

Review URL: https://codereview.chromium.org/416243003

git-svn-id: svn://svn.chromium.org/blink/trunk@179050 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently hitting Ctrl-Shift-O on any typescript/python/C++ file in
DevTools will result in opened bookmarks tab (at least on linux).
Almost all the time, if user is editing code in Sources Panel and hitting
Ctrl-Shift-O, he expects outline dialog to be shown.

As we are not capable of supporting all the fancy file formats yet, the patch
suggests swallowing Ctrl-Shift-O for those content types that we do not support.

R=vsevik, apavlov, pfeldman

Review URL: https://codereview.chromium.org/422023002

git-svn-id: svn://svn.chromium.org/blink/trunk@179049 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Remove WebSettings::setDisallowFullscreenForNonMediaElements(bool) (https://codereview.chromium.org/416013002/)

Reason for revert:
We need this for the Android WebView

Original issue's description:
> Remove WebSettings::setDisallowFullscreenForNonMediaElements(bool)
> 
> It is never called from Chromium.
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178831

TBR=jochen@chromium.org,qinmin@chromium.org,philipj@opera.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/422923002

git-svn-id: svn://svn.chromium.org/blink/trunk@179048 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It was added as a part of this patch
https://codereview.chromium.org/13937017

It was reverted here
https://chromiumcodereview.appspot.com/23072015

Review URL: https://codereview.chromium.org/357663002

git-svn-id: svn://svn.chromium.org/blink/trunk@179047 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Initial -webkit-text-emphasis-color (correctly) uses
StyleColor::currentColor, like most of the other colors.

Also, initialTextEmphasisColor returns TextEmphasisFillFilled, which is not a Color.

Review URL: https://codereview.chromium.org/425763002

git-svn-id: svn://svn.chromium.org/blink/trunk@179046 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=395531

Review URL: https://codereview.chromium.org/376873004

git-svn-id: svn://svn.chromium.org/blink/trunk@179045 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Clarify comments for methods added in r178921 as per follow-up review comments.

R=pdr@chromium.org

Review URL: https://codereview.chromium.org/423823005

git-svn-id: svn://svn.chromium.org/blink/trunk@179044 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change makes CallbackPromiseAdapter bypass resolving/rejecting a promise
if ExecutionContext is gone and calls WebType::dispose() to clean up passed
WebType instance.


BUG=385906,386501
TEST=run_webkit_tests.py --debug --enable-leak-detection http/tests/serviceworker/chromium/resolve-after-window-close.html
TEST=run_webkit_tests.py --debug --enable-leak-detection push_messaging/push-messaging-resolve-after-detached.html
TEST=manual (run crash.html in the issue)

Review URL: https://codereview.chromium.org/396963002

git-svn-id: svn://svn.chromium.org/blink/trunk@179043 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Blink side changes to support NumCopies print preset option.
Copies in print preview dialog should be set to value set for
NumCopies in pdf source document.

BUG=169120

Review URL: https://codereview.chromium.org/379793002

git-svn-id: svn://svn.chromium.org/blink/trunk@179042 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Minor cleanup: some suggestions didn't make it in the final version of
https://codereview.chromium.org/412353003/

R=schenney@chromium.org

Review URL: https://codereview.chromium.org/428573003

git-svn-id: svn://svn.chromium.org/blink/trunk@179039 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=393516

Review URL: https://codereview.chromium.org/424723002

git-svn-id: svn://svn.chromium.org/blink/trunk@179038 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Hide RenderBox::isBox() / RenderText::isText() to catch useless type checks
at compile time.

R=pdr@chromium.org

Review URL: https://codereview.chromium.org/425503002

git-svn-id: svn://svn.chromium.org/blink/trunk@179037 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Fix incorrect number of matches and misleading highlighting in "Find on Page" results (https://codereview.chromium.org/422443004/)

Reason for revert:
This broke FindInPageControllerTest.LargePage on multiple bots (e.g. http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%282%29/builds/30423)

Filed a bug:
https://code.google.com/p/chromium/issues/detail?id=398017

Original issue's description:
> Fix incorrect number of matches and misleading highlighting in "Find on Page" results.
> 
> BUG= 397563
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179000

TBR=yosin@chromium.org,tkent@chromium.org,iceman@yandex-team.ru
NOTREECHECKS=true
NOTRY=true
BUG= 397563

Review URL: https://codereview.chromium.org/424803002

git-svn-id: svn://svn.chromium.org/blink/trunk@179036 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=267592
R=vsevik

Review URL: https://codereview.chromium.org/413213003

git-svn-id: svn://svn.chromium.org/blink/trunk@179035 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to Deprecate:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/1m47rW4w7dc/MOf_2kgb2wIJw

Review URL: https://codereview.chromium.org/422743002

git-svn-id: svn://svn.chromium.org/blink/trunk@179032 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=aandrey, pfeldman, vsevik
BUG=394384

Review URL: https://codereview.chromium.org/397303002

git-svn-id: svn://svn.chromium.org/blink/trunk@179031 bbb929c8-8fbe-4397-9dbb-9b2b20218538

HTML says:

 "The IDL attributes naturalWidth and naturalHeight must return the
  intrinsic width and height of the image, in CSS pixels, if the image is
  available, or else 0."

Change HTMLImageElement::natural{Width,Height} to request the intrinsic
size from ImageResource::imageSizeForRenderer by passing IntrinsicSize as
the third parameter. This makes the attributes return more appropriate
values for SVG-images in <img>.

BUG=396955

Review URL: https://codereview.chromium.org/422503002

git-svn-id: svn://svn.chromium.org/blink/trunk@179030 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This replaces the BlendModeType enumeration with the WebBlendMode for
FEBlend::m_mode. The former is moved to SVGFEBlendElement.
This enables FEBlend to use all of the blend modes available in
WebBlendMode, and leave any subset selection to the client of FEBlend
(which is SVGFEBlendElement).
The BlendModeType->string mapping is replaced by compositeOperatorName().

BUG=389594

Review URL: https://codereview.chromium.org/419253002

git-svn-id: svn://svn.chromium.org/blink/trunk@179029 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=340522

Review URL: https://codereview.chromium.org/415043003

git-svn-id: svn://svn.chromium.org/blink/trunk@179021 bbb929c8-8fbe-4397-9dbb-9b2b20218538

service_worker_unregister_and_done was outside of the .then chain, so it
would execute early and the test passes regardless of the assertions.

BUG=395928

Review URL: https://codereview.chromium.org/426563003

git-svn-id: svn://svn.chromium.org/blink/trunk@179020 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL introduces |SVGElement::parseAttributeNew|, a new
|SVGElement::parseAttribute| implementation based on property map.

Before this patch, |SVG(.*)Element::parseAttribute| used chained if stmts
to resolve SVGAnimatedProperty. This patch changes it to resolve using
property map.

This is to replace the existing |SVGElement::parseAttribute| implementation,
but as there are many callers, we would like to proceed this incrementally.
a) Introduce |SVGElement::parseAttributeNew|
b) Convert all overrides |SVGElement::parseAttribute| to
   a |parseAttributeNew| call.
c) Replace existing |parseAttribute| with |parseAttributeNew|, and remove all
   overrides simply calling |parseAttributeNew|

This patch is (a). This patch also converts |SVG{Graphics,Rect}Element::parseAttribute| to start with (b).

BUG=397902

Review URL: https://codereview.chromium.org/421863002

git-svn-id: svn://svn.chromium.org/blink/trunk@179019 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We have inconsistent style for multiple-line base class list.

A) 37 instances

class Foo
    : public BaseA
    , public BaseB
    , public BaseC {
    ...

B) 17 instances

class Foo :
    public BaseA,
    public BaseB,
    public BaseC {
    ....

The number of A is larger than the number of B, and A is consistent with the
initialization list style. This CL changes B to A.

BUG=

Review URL: https://codereview.chromium.org/423803002

git-svn-id: svn://svn.chromium.org/blink/trunk@179018 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL adds a set of live Resources to MemoryCache to emulate the current
lifetime management precisely in Oilpan.

Resource::m_resourceToRevalidate refers another Resource, and
Resource::m_proxyResource is a back pointer of m_resourceToRevlidate. According
to Resource::canDelete, both of them are strong references.

BUG=393516

Review URL: https://codereview.chromium.org/424633002

git-svn-id: svn://svn.chromium.org/blink/trunk@179016 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=340522

Review URL: https://codereview.chromium.org/323043002

git-svn-id: svn://svn.chromium.org/blink/trunk@179015 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=apavlov

Review URL: https://codereview.chromium.org/426563004

git-svn-id: svn://svn.chromium.org/blink/trunk@179014 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* selector is not required.

BUG=316092

Review URL: https://codereview.chromium.org/420193004

git-svn-id: svn://svn.chromium.org/blink/trunk@179013 bbb929c8-8fbe-4397-9dbb-9b2b20218538

CSSPresentationModel has been introduced in order to
- manage source mappings,
- store live locations,
- perform the rawLocationToUILocation conversions.

R=pfeldman, vsevik

Review URL: https://codereview.chromium.org/297923002

git-svn-id: svn://svn.chromium.org/blink/trunk@179012 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When SharedWorker script load has failed and the |WebSharedWorkerImpl|
was explicit told to terminate, the |WebSharedWorkerImpl| instance
was never deleted.

This CL fixes the issue by invoking "delete this" when a worker thread
instance does not exist in |stopWorkerThread()|.

TEST=fast/workers/worker-crash-with-invalid-location.html doesn't leak when --enable-leak-detection
BUG=364390

Review URL: https://codereview.chromium.org/424653002

git-svn-id: svn://svn.chromium.org/blink/trunk@179011 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As same as http://crrev.com/407073009 , this CL may increase the size of these classes by +16 or +8 bytes. +8 bytes for |m_wrapperOrTypeInfo| (type of uintptr_t) in ScriptWrappable. Another +8 bytes for vtbl.

BUG=235436

Review URL: https://codereview.chromium.org/412183003

git-svn-id: svn://svn.chromium.org/blink/trunk@179010 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This was probably originally FullscreenController.

Also fix a typo and simplify isActiveFullScreenElement.

Review URL: https://codereview.chromium.org/421693003

git-svn-id: svn://svn.chromium.org/blink/trunk@179009 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Make sure |this| is kept while offlineRender() by passing PassRefPtr<> to
  bind().

- Make sure |this| is kept until finishing notifyComplete() by
  createCrossThreadTask(), which uses bind() internally.

BUG=395941

Review URL: https://codereview.chromium.org/423783002

git-svn-id: svn://svn.chromium.org/blink/trunk@179008 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Hidden columns are supported by DataGrid now.

BUG=316092

Review URL: https://codereview.chromium.org/422543002

git-svn-id: svn://svn.chromium.org/blink/trunk@179007 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=tkent@chromium.org
BUG=

Review URL: https://codereview.chromium.org/421883002

git-svn-id: svn://svn.chromium.org/blink/trunk@179006 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Found by a prototype of -Wunused-local-typedef for clang.

BUG=none

Review URL: https://codereview.chromium.org/427473002

git-svn-id: svn://svn.chromium.org/blink/trunk@179005 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=hajimehoshi
NOTRY=true
BUG=364390

Review URL: https://codereview.chromium.org/427483002

git-svn-id: svn://svn.chromium.org/blink/trunk@179004 bbb929c8-8fbe-4397-9dbb-9b2b20218538

    
When executing editing commands, endingSelection is valid.
However, if undo some commands, endingSelection might be invalid and
FrameSelection might be updated by the invalid selection.
i.e. the selection might be owned by another document without any frames.
    
BUG=368978
TEST=Source/core/editing/FrameSelectionTest

Review URL: https://codereview.chromium.org/359593002

git-svn-id: svn://svn.chromium.org/blink/trunk@179003 bbb929c8-8fbe-4397-9dbb-9b2b20218538