- 06 Mar, 2020 40 commits
-
-
Fergal Daly authored
- record whether the main render frame host is being found and is equal to the one we just created (this seems impossible). - record whether the view-host's widget is already initialized. Either of these could cause us to return early from InitRenderFrame without calling SetRenderFrameCreated(true) (full details in the bug). This adds RenderViewHostImpl::GetMainFrameWithoutFallback to get access to the main RFH as seen by the RVH. The naming is not great. This also removed the URL capturing as Android Webview is more strict about PII and strips out strings from the minidump. Our crash key will be whitelisted in separate CL. Bug: 1006814 Change-Id: Ie65ee912533c54a63ad7398290b97a5395b21d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081730 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#747581}
-
Karan Bhatia authored
r744448 added logic to ensure allowAllRequests were always applied to srcdoc frames. That said, the added test is flaky. It seems the fetch can be aborted when the frame unloads causing flakiness. However, waiting for onload event before the fetch causes the request to arrive in the browser after the corresponding navigation commit, defeating the purpose of the test. Since there doesn't seem to be a reliable way to reproduce requests from a frame arriving before a navigation commit, simply delete the test. BUG=1056031 Change-Id: I23fc2fdfe5719a0f10bdce025cf3556840f0c3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088346Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#747580}
-
Zain Afzal authored
This Cl adds a delegate to the guest iframe which is used by the backlight app to call privileged WebUI functions. The only function on the delegate at the present moment is "openFeedbackDialog" which allows the backlight app to send a message to the parent webUI asking it to open the chromeos native feedback dialog. The delegate itself is nothing more then a wrapper over some message pipe calls but by defining the delegate in receiver.js we have a easy way to audit all of the privileged functionality we are exposing to the unprivileged guest iframe. This CL also adds the message pipe end point for opening a feedback dialog and the relevant bootstrap code used to initialize backlight with the WebUI delegate. The actual code which uses this delegate can be seen at cl/298246716 Bug: 996088 Change-Id: Ic2df6fa691cab0fbdaa6639de652e202733466da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082731 Commit-Queue: Zain Afzal <zafzal@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#747579}
-
Andrew Xu authored
The API which fetches the scrollable shelf information is generalized to provide the shelf information, including scrollable shelf and hotseat. Note that the old API getScrollableShelfInfoForState is kept for now. Otherwise, the tast test will fail. The old API will be removed in the following CL. Bug: 1056880 Change-Id: Ie6f3e74db6a1751a515732edb6f6bcae401b045d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079842Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#747578}
-
Hiroshige Hayashizaki authored
There were multiple `spec.src.json` for each project directories that have many things in common, e.g. lists of subresources, source contexts, etc. This CL introduces `common/security-features/tools/spec.src.json` that works as the default `spec.src.json`, and moves common things into the default `spec.src.json`. By doing this, we can ensure uniform test coverage across projects (e.g. the same set of subresource requests are covered in `referrer-policy` and `mixed-content` tests) more easily. To keep the generated tests the same, this CL adds exclusion rules named "... not yet tested". This CL doesn't affect test behavior nor generated results. Bug: 906850 Change-Id: Id06bc6e311a482f50531cd36e6da57b2e6df22ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049953 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#747577}
-
Raul Tambre authored
itervalues() no longer exists in Python 3. values() works on both. Traceback (most recent call last): File "../../headless/lib/browser/devtools_api/client_api_generator.py", line 525, in <module> InitializeDomainDependencies(json_api) File "../../headless/lib/browser/devtools_api/client_api_generator.py", line 425, in InitializeDomainDependencies GetDomainDepsFromRefs(domain['domain'], domain) File "../../headless/lib/browser/devtools_api/client_api_generator.py", line 413, in GetDomainDepsFromRefs for value in json.itervalues(): AttributeError: 'dict' object has no attribute 'itervalues' Bug: 941669 Change-Id: I24a888b95ead33b9a9abfdd84f08ac5fc10b4136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089862 Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:Johannes Henkel <johannes@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#747576}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/45affde3a9c5..5415e4d9aec4 git log 45affde3a9c5..5415e4d9aec4 --date=short --first-parent --format='%ad %ae %s' 2020-03-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4ea51a0a..70eb5f7c (747324:747482) Created with: gclient setdep -r src/third_party/webrtc@5415e4d9aec4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I442d92d18f4f7a2e4e9e7d7c0c071cee67f1415c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090647Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747575}
-
Maggie Cai authored
This reverts commit 5b257115. Reason for revert: This CL is likely the cause of the failure of build https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81830. Original change's description: > Roll src/third_party/perfetto da7fe17f810a..b583290a6d81 (1 commits) > > https://android.googlesource.com/platform/external/perfetto.git/+log/da7fe17f810a..b583290a6d81 > > git log da7fe17f810a..b583290a6d81 --date=short --first-parent --format='%ad %ae %s' > 2020-03-05 skyostil@google.com Merge "TrackEvent: Add TrackEvent::GetTraceTimeNs()" > > Created with: > gclient setdep -r src/third_party/perfetto@b583290a6d81 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/perfetto-chromium-autoroll > Please CC perfetto-bugs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Bug: None > Tbr: perfetto-bugs@google.com > Change-Id: I36c1e8f1b949e51434368b3f13b66a86ef48166a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089270 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#747228} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com Change-Id: Ib8fe9560dc126eb24e8ffc90d8e47b4ac34d5856 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090563Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#747574}
-
Oksana Zhuravlova authored
This change adds more tracing statements to the WebView startup code. Bug: 1019793 Test: trace output has new blocks Change-Id: Ic401ace0999f15456d62e69cc13bdabca05241b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083740Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#747573}
-
Maggie Cai authored
This reverts commit ecfd097c. Reason for revert: Revert this CL because a previous roll is likely to cause the build failure for https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81830. Original change's description: > Roll src/third_party/perfetto b583290a6d81..652ee37df0e7 (1 commits) > > https://android.googlesource.com/platform/external/perfetto.git/+log/b583290a6d81..652ee37df0e7 > > git log b583290a6d81..652ee37df0e7 --date=short --first-parent --format='%ad %ae %s' > 2020-03-05 ddrone@google.com Merge "Add more fields to ChromeLatencyInfo" > > Created with: > gclient setdep -r src/third_party/perfetto@652ee37df0e7 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/perfetto-chromium-autoroll > Please CC perfetto-bugs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Bug: None > Tbr: perfetto-bugs@google.com > Change-Id: I5a366cd53c3adb2bfe781e7d7bc192bb962b6689 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089575 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#747260} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com Change-Id: Ib3ae8e6fee33198df5d3a7b274cfae262b458ff0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089535Reviewed-by:
-
Maggie Cai authored
This reverts commit 2d444bf7. Reason for revert: Revert this CL because a previous roll is likely to cause the build failure for https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81830. Original change's description: > Roll src/third_party/perfetto 652ee37df0e7..7c0409aa3814 (2 commits) > > https://android.googlesource.com/platform/external/perfetto.git/+log/652ee37df0e7..7c0409aa3814 > > git log 652ee37df0e7..7c0409aa3814 --date=short --first-parent --format='%ad %ae %s' > 2020-03-05 ilkos@google.com Add anon RSS + swap to the java heap stats metric > 2020-03-05 hjd@google.com Merge "Add AndroidProcessMetadata to startup metrics" > > Created with: > gclient setdep -r src/third_party/perfetto@7c0409aa3814 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/perfetto-chromium-autoroll > Please CC perfetto-bugs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Bug: chromium:150675972 > Tbr: perfetto-bugs@google.com > Change-Id: I859d8150d98acafb058dd4c348920d39556dc8ac > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089584 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#747299} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com Change-Id: I8eb43cc90a4fa6cb19abd49b27965c0952027391 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:150675972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090564Reviewed-by:
-
Luciano Pacheco authored
Bug: 1035691 Change-Id: I5519ac9227cdfd1b57646c943936d338ad23dc5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090561 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#747570}
-
Maggie Cai authored
This reverts commit e73d07f9. Reason for revert: Revert this CL because a previous roll is likely to cause the build failure for https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81830. Original change's description: > Roll src/third_party/perfetto 7c0409aa3814..f365c53a18b1 (1 commits) > > https://android.googlesource.com/platform/external/perfetto.git/+log/7c0409aa3814..f365c53a18b1 > > git log 7c0409aa3814..f365c53a18b1 --date=short --first-parent --format='%ad %ae %s' > 2020-03-05 taylori@google.com Merge "perfetto-ui: Fix counter quantization" > > Created with: > gclient setdep -r src/third_party/perfetto@f365c53a18b1 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/perfetto-chromium-autoroll > Please CC perfetto-bugs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Bug: None > Tbr: perfetto-bugs@google.com > Change-Id: I9f1496de8f76cf68115b362d70f759719d2ea452 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090074 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#747341} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com Change-Id: I68933f50c422786b6a219c5cdf0468c895171012 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089448Reviewed-by:
-
Chris Cunningham authored
//services/viz/public/mojom:mojom_blink is multiply included when building blink_unittests. A) it's built into the blink_unittests executable B) it's built into the blink_platform component, which is a dep of blink_unittests This multiple inclusion lead to double definition errors[1] when I tried to add a new test[2] in blink_unittests. The test uses media/mojo/mojom/video_decode_perf_history.mojom-blink.h, generated by //media/mojo/mojom:mojom_blink. //media/mojo/mojom:mojom_blink is *already* a dep of blink_unittests via this chain through blink_platform (component) //third_party/blink/renderer/controller:blink_unittests //third_party/blink/renderer/controller:blink_unittests_sources //third_party/blink/renderer/platform:platform //third_party/blink/renderer/platform:blink_platform_public_deps //third_party/blink/public/mojom:mojom_platform_blink //media/mojo/mojom:mojom_blink //media/mojo/mojom:mojom_blink is *also* a dep of //services/viz/public/mojom:mojom_blink, which is built directly into blink_unittests as a source_set. //third_party/blink/renderer/controller:blink_unittests //third_party/blink/renderer/controller:blink_unittests_sources //third_party/blink/renderer/modules:unit_tests //services/viz/public/mojom:mojom_blink //media/mojo/mojom:mojom_blink This explains the error[1] FAILED: blink_unittests.exe ninja -t msvc ... lld-link: error: duplicate symbol: public: __thiscall media::mojom::blink::PredictionFeatures::PredictionFeatures(void) >defined at obj/media/mojo/mojom/mojom_blink/media_types.mojom-blink.obj >defined at blink_platform.dll Hence, this CL removes multiple inclusion by deleting rules that cause //services/viz/public/mojom:mojom_blink to be directly built into the blink_unittests executable. The blink_platform component is now the sole provider of //services/viz/public/mojom:mojom_blink to blink_unittests. This also required small export_* additions to the viz BUILD.gn to give the viz mojom symbols visibility outside the blink_platform component. Those changes were also made to gpu's BUILD.gn because blink_unittests had come to rely on the viz dependency to provide unexported gpu symbols. [1] https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8886718386427952624/+/steps/compile__with_patch_/0/stdout [2] https://chromium-review.googlesource.com/c/chromium/src/+/2088494 Change-Id: I1a7cd262f09a08c532479e44572f50360a6ebc40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088493Reviewed-by:Khushal <khushalsagar@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#747568}
-
Maggie Cai authored
This reverts commit e5632385. Reason for revert: Revert this CL because a previous roll is likely to cause the build failure for https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81830. Original change's description: > Roll src/third_party/perfetto f365c53a18b1..0c6dfdbceb9e (1 commits) > > https://android.googlesource.com/platform/external/perfetto.git/+log/f365c53a18b1..0c6dfdbceb9e > > git log f365c53a18b1..0c6dfdbceb9e --date=short --first-parent --format='%ad %ae %s' > 2020-03-05 ddrone@google.com Merge "Reusing one ProtoToArgsTable instance" > > Created with: > gclient setdep -r src/third_party/perfetto@0c6dfdbceb9e > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/perfetto-chromium-autoroll > Please CC perfetto-bugs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Bug: None > Tbr: perfetto-bugs@google.com > Change-Id: Ieff5c397bd14f619342cb0bc10669bd93a970b34 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090217 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#747382} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com Change-Id: Ia980fae75236c001d504f8cb7ed5582f236ef731 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091093Reviewed-by:
-
Maggie Cai authored
This reverts commit fc011bb6. Reason for revert: Revert this CL because a previous roll is likely to cause the build failure for https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/81830. Original change's description: > Roll src/third_party/perfetto 0c6dfdbceb9e..7e47609cf293 (1 commits) > > https://android.googlesource.com/platform/external/perfetto.git/+log/0c6dfdbceb9e..7e47609cf293 > > git log 0c6dfdbceb9e..7e47609cf293 --date=short --first-parent --format='%ad %ae %s' > 2020-03-05 pmuetschard@google.com Adds a LAST_NON_NULL window function to the trace processor. > > Created with: > gclient setdep -r src/third_party/perfetto@7e47609cf293 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/perfetto-chromium-autoroll > Please CC perfetto-bugs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Bug: None > Tbr: perfetto-bugs@google.com > Change-Id: I04128556754d1670bd6635b503b300ff5391631f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090228 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#747468} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com Change-Id: I0be90c7070bad2c73d195bb50b43173596363bae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089447Reviewed-by:
-
nancy authored
When the app doesn't exist in AppService, if the PauseApp is called, the app is added to AppService with the app type Unknown, then later when the app is added, the app type is changed to Web or Arc. In theory, the app type should not be changed, so add the app type checking when pause or unpause an app. BUG=1055937 Change-Id: Iafd4befb6f7369977a3693d84994f3453876af7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089445Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#747565}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I485710020f44f1135a2ffb659a21d3baec1ebad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089728Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747564}
-
Frank Tang authored
CherryPick fractional second bugs from ICU. https://chromium.googlesource.com/chromium/deps/icu.git/+log/9f4020916..0b6134378 Including the following changes 0b61343 Fix fractional second bug by Frank Tang · 16 minutes ago master 49ee7b1 Make it able to optionally disable thin_archive by Honglin Yu · 9 days ago f9a6fc2 Revert "Add flag for compiling into shared libraries." by Honglin Yu · 9 days ago eb405d8 Add flag for compiling into shared libraries. by Honglin Yu · 4 weeks ago BUG=chromium:1020393, v8:9284, v8:9612, v8:10273 Change-Id: I94692734fe29e783293ec7c98b69ccd8d879b804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090002Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#747563}
-
Karan Bhatia authored
This CL adds documentation for regex rules. BUG=974391 Change-Id: Iee864a94f101f67eaa16797233b61a0f6dd02794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021408 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Akihiro Ota authored
This change: 1. Disables the options button (next to the 'disable ChromeVox button') when signed out. 2. Disables certain menu items when signed out. 3. Disabled elements are styled visually and are populated with the aria-disabled property so their state is announced by ChromeVox. 4. Stores session state in the panel to make this change cleaner. 5. Marks the panel's annotations element as hidden so it's only accessible when visible. 6. Checks that UserAnnotationHandler.instance is defined before performing any logic inside its functions. There was a case where code in the panel triggered a call to UserAnnotationHandler when its instance was undefined. 7. Ensures that navigation via arrow keys skips disabled menus and items. Bug: 1020003 Change-Id: I2b4204970e474054e53bc8425e0e538a9c3de556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050789Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#747561}
-
Victor Fei authored
This is a simplified version of CL:2067329, which had to be abandoned because we were uncertain about the need for MaxTextOffsetCache. This change introduces a new method on ax_position.h called "AsValidPosition", which will return a new, valid position from a position that was made invalid due to tree changes. The motivation behind this change is to fix hang encountered in UIA when deleting text from an input at the end of a document. Previous merged CL:2021844 attempted to address this issue, however there were still outstanding cases where the hang still occurs. This CL attempts to better handle the hang, and removes the scoped hang workaound added in previous CL:2021844. The current caller of AXPositionInstance::AsValidPosition is only in UIA as the bug only appeared to be manifested in UIA/Windows Narrator. Another reason that we are not utilizing it in the public methods of AxPosition is because AsValidPosition calls MaxTextOffset which is computationally expensive and impacts existing AXPosition methods' performance; thus, we only limited AsValidPosition call to UIA in this CL. In the abandoned CL:2067329, of which this CL is based on, we attempted to utilize AsValidPosition in AxPosition methods, and implemented MaxTextOffsetCache to mitigate performance hit introduced by AsValidPosition. However, we were uncertain about the practicality of introducing such cache, and decided to abandon the change. (The discussion on MaxTextOffsetCache is in CL:2067329's comments.) Bug: 1046428 Change-Id: I4ef7a600c907be75bef0dc934f7ebc50ce18519d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085709 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#747560}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/61f8ad8b69f9..add000e1e5a5 git log 61f8ad8b69f9..add000e1e5a5 --date=short --first-parent --format='%ad %ae %s' 2020-03-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@add000e1e5a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5c9b9a40e609f7c217ebfd349781276f623fa2f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090649Reviewed-by:
-
Jia authored
Following discussions with our clients, we believe string type of id will be sufficient. Search tags will continue to be string16 for multi-language support. Bug: 1018613 Change-Id: Id45aac55d61aaf2885a2a752ddf56cbcea15cda7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090552Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
When <body> has more than one CSS class the helper wasn't working, the "class" attribute is a string with all the classes. This CL fixes it. Bug: 1059137 Change-Id: I7e0cc65eb25da80e1f611f51e2795f23123aa245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090560 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I133a4ee1440618a4218d06aa437325004a6cfc41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090101Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747556}
-
Yuichiro Hanada authored
It can happen that KeyboardUIController notifies the old bounds of the virtual keyboard if the call of ShowKeyboard() is followed by HideKeyboard*(). A tast integration test will be added for this case in a follow up CL. Bug: b/148483295 Change-Id: I3222852532f7c0bb685a75d0bb0888cbddc44a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089195Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#747555}
-
Brad Huang authored
Add a new routine, floating_point_accuracy. This routine executes millions of floating-point operations within a desired time period, the result must match expected result. Bug: b:146513388 Test: chromeos_unittests --gtest_filter=CrosHealthdServiceConnectionTest.* unit_tests --gtest_filter=DeviceCommandRunRoutineJobTest.* Change-Id: I9bcb7eaf938da3ecd6fecfab0f2cfe57ef3fbb23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045291 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Victor-Gabriel Savu <vsavu@google.com> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#747554}
-
Jeff Yoon authored
There are a lot of variants that are repeatedly defined. To minimize duplication in test_suites.pyl, and to keep it readable, I've extracted the definitions into a variants.pyl. All variants defined as a string will look for a reference in variants.pyl. Change-Id: I5bfc206ead0fd10c3d497d6557761c2795ba76f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090871 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#747553}
-
Toni Barzic authored
Shelf config change may cause hotseat state change, so we should update the hotseat state (which is done in ShelfLayoutManager::SetState) when the shelf config changes, otherwise, the hotseat state change may lag behind the shelf layout change. For example, layout may hide the opaque shelf background if config changes to non-in-app shelf, and animating background animation starts when the hotseat state changes. So, if the hotseat state change lags after the shelf layout change for long enough, we might see a flash of animating shelf background after the opaque shelf background has been hidden. This was noticed while implementing swipe to overview/home with VK shown (when swiping to go home, the animating shelf would occasionally pop up with a delay) - added a test for sequence of events in that case. (Note that this means that the hotseat state may get calculated before app list visibility on tablet mode change, so add back logic that moved hotseat in kShownHomeLauncher state if the home should be visible at that point in time). BUG=b:145704293 Change-Id: I4e6ce883eed8674159b03c25336fd82c9d20c50d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090757 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#747552}
-
dalyk authored
The phrase "Network Sign-in" will be included in the window title to indicate the purpose of these windows. The position of the phrase depends on the platform so that existing window title formatting patterns are preserved. Bug: 10161646 Change-Id: If49bb5fef304346488cb56cf11d5a043ccb473c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081333 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 07febed2. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: If053e9a9f8ddbca028783daa57f77ac8030b7586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089718Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747550}
-
Avi Drissman authored
BUG=1058951 Change-Id: Ic214033241655ac1653810fe78bfa92376c629fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089998Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#747549}
-
Darwin Huang authored
Add huangdarwin@ and dcheng@ to OWNERS and specify TEAM for triage/emails. As per `git log --oneline --author=huangdarwin@chromium.org ui/base/dragdrop`, huangdarwin@ has 10 CLs in ui/base/dragdrop. As per `git log --oneline --author=dcheng@chromium.org ui/base/dragdrop`, dcheng@ has 22 CLs in ui/base/dragdrop. Change-Id: I39bafac9a350a02e5edbddfa9786e5f4aabe5a6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088647Reviewed-by:
-
Peng Huang authored
The problem is because the original vulkan helper template methods pull types from arguments. So when a vulkan template method is called with VK_NULL_HANDLE like: VkQueueSubmit(device, count, subbmits, VK_NULL_HANDLE) The VK_NULL_HANDLE is defined as 0, so the template pulls the type int from VK_NULL_HANDLE, and then uses the int to call VkQueueSubmit function pointer. The compile can not cast an int to VKFence, so error is reported. This CL fixes the problem by pulling arg types from vulkan function type defined in vulkan header file instead of using arg type from where the template method is called. Bug: 1058616 Change-Id: Iec8ab990df7dd32985c0d840d49fbf81c710a09d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088832Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#747547}
-
Darwin Huang authored
Bug: 897289 Change-Id: I26335e58672e915a452dc6ae04dac6d712ccac6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090914 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#747546}
-
Mustafa Emre Acer authored
This CL changes the IDN lookalike logic to use the Safety Tip config proto to allowlist sites. We currently don't have an allowlist mechanism and there have been cases where it would be useful. The CL uses the |allowed_pattern| field in safety_tips.proto. This is shared with Safety Tips, so a pattern added to this field will cause a to not show a lookalike interstitial or a safety tip. The IDN lookalike logic operates on eTLD+1 only, so any pattern targeting the interstitial should only contain eTLD+1. Bug: 1056755 Change-Id: I65e856eb118b0d20dd366fc0d09a95def1a5ab1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082904Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#747545}
-
Wenyu Fu authored
Mockito does not work for some of the bots for unknown reason so that policy related tests in HomepageSettingsFragmentTest all failed. Changing HomepageTestRule and use AppRestrictionProvider to provide test policy settings; re-enabling those tests to strengthen our test coverage. Bug: 1049557 Change-Id: I93514c020498d9b26c53b2c3f76cf819bd0bba7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047353 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#747544}
-
Maggie Cai authored
This reverts commit 5d31525d. Reason for revert: This CL causes build failure for https://ci.chromium.org/p/chromium/builders/ci/Linux%20ASan%20LSan%20Tests%20%281%29/73445 and https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/17413 Original change's description: > Add more unit tests for url_lookup_service. > > Add tests for the StartLookup method. > > Bug: 1050859 > Change-Id: Idfc261cdd5fbc75d359cfa40b0be5621e57f8c0d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086812 > Reviewed-by: Daniel Rubery <drubery@chromium.org> > Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#747497} TBR=drubery@chromium.org,xinghuilu@chromium.org Change-Id: Iea165caa159779b08ffe42fa245b39bcf4fd6d89 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1050859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089440Reviewed-by:
-
Maggie Cai authored
This reverts commit e2ff113c. Reason for revert: This CL makes mac-builder-perf build flaky and continusly have compile error. Original change's description: > Roll src/third_party/swiftshader a095711c5d77..51b2800bb317 (1 commits) > > https://swiftshader.googlesource.com/SwiftShader.git/+log/a095711c5d77..51b2800bb317 > > git log a095711c5d77..51b2800bb317 --date=short --first-parent --format='%ad %ae %s' > 2020-03-05 capn@google.com Support launching PowerVR samples from Visual Studio using SwiftShader > > Created with: > gclient setdep -r src/third_party/swiftshader@51b2800bb317 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/swiftshader-chromium-autoroll > Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Bug: None > Tbr: swiftshader-team+autoroll@google.com > Change-Id: Ie79b6461aa9c2c778cdedb03e51f6d3d7bc8383f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090076 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#747352} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,swiftshader-team+autoroll@google.com Change-Id: Ic1b18034af1867e7bc26a075d2bb98f9320c8f41 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090991Reviewed-by:
-
