1. 11 Sep, 2014 40 commits
    • boliu's avatar
      Call MakeCurrent in in-process idle work · 1a908118
      boliu authored
      BUG=413044
      
      Review URL: https://codereview.chromium.org/556323004
      
      Cr-Commit-Position: refs/heads/master@{#294308}
      1a908118
    • calamity's avatar
      Reset the experimental app list to the start page on dismiss. · 8a838980
      calamity authored
      This CL fixes and issue where the experimental app list would not
      reset to the start page on Windows and Linux.
      
      BUG=412227
      
      Review URL: https://codereview.chromium.org/552743005
      
      Cr-Commit-Position: refs/heads/master@{#294307}
      8a838980
    • wensheng.he's avatar
      Add my email in src/authors file · dab4f93b
      wensheng.he authored
      Add my email in src/authors file
      
      R=kouhei@chromium.org
      BUG=
      
      Review URL: https://codereview.chromium.org/561663002
      
      Cr-Commit-Position: refs/heads/master@{#294306}
      dab4f93b
    • dpolukhin's avatar
      Minimal support for OOBE/login for chrome-athena · 04e5b809
      dpolukhin authored
      BUG=405859
      TEST=manual
      
      Review URL: https://codereview.chromium.org/542623002
      
      Cr-Commit-Position: refs/heads/master@{#294305}
      04e5b809
    • acolwell's avatar
      Fix Mojo's WebURLLoader so that it provides protocol version and headers. · e0857290
      acolwell authored
      media::BufferedResourceLoader needs HTTP protocol and header information
      in the HTTP responses so that it can properly detect live streams and
      whether Range: headers are supported. This patch provides the missing
      functionality needed by the media code.
      
      Review URL: https://codereview.chromium.org/566453002
      
      Cr-Commit-Position: refs/heads/master@{#294304}
      e0857290
    • dalecurtis's avatar
      Use AudioStreamMonitor to control power save blocking. · 484d29dc
      dalecurtis authored
      Prevents looping, soundless videos from preventing system sleep if they're
      in a background tab. We don't want soundless videos in the main tab to
      allow sleeping as they'll impact the muted video + captions use case.
      
      Reworks WebContentsImpl to track active media players and whether the
      attached WebContents is visible. When visible and there's an active video
      player, it will create a power save blocker. One blocker is shared for all
      active media players for simplicity.
      
      Reworks AudioStreamMonitor to handle the PowerSaveBlocker for audio
      such that one is only created when non-silent audio is present.
      
      To prevent splitting power blocking duties across chrome/ and content/,
      AudioStreamMonitor now lives in content/.  WebContents exposes a
      WasRecentlyAudible() method for the existing tab audio indicator.
      
      BUG=43667,367785
      TEST=manual.
      
      Review URL: https://codereview.chromium.org/478543003
      
      Cr-Commit-Position: refs/heads/master@{#294303}
      484d29dc
    • vsevik's avatar
      Make debug on start checkbox on service worker internals page easier to click. · e6492dbc
      vsevik authored
      This patch wraps the debug on start checkbox on service worker internals page into a label element
      to allow clicking on the text near the checkbox as well as the checkbox itself.
      R=horo
      
      Review URL: https://codereview.chromium.org/558353002
      
      Cr-Commit-Position: refs/heads/master@{#294302}
      e6492dbc
    • blink-deps-roller's avatar
      415a238c
    • hashimoto's avatar
      Move app.window section of _api_features.json and _permission_features.json... · ac7de19b
      hashimoto authored
      Move app.window section of _api_features.json and _permission_features.json from chrome/common/extensions/api to extensions/common/api
      
      BUG=387288
      
      Review URL: https://codereview.chromium.org/546683002
      
      Cr-Commit-Position: refs/heads/master@{#294300}
      ac7de19b
    • skia-deps-roller's avatar
      Skia roll d9ec549:97bf60f · f1fc37d3
      skia-deps-roller authored
      https://skia.googlesource.com/skia/+log/d9ec549071581d9d1dc2e5fac3163305ae935a39..97bf60ff7f3dd7d6e782b706ec94efb2b414b27e
      
      CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
      TBR=fmalita@google.com
      
      Review URL: https://codereview.chromium.org/566443002
      
      Cr-Commit-Position: refs/heads/master@{#294299}
      f1fc37d3
    • tonyg's avatar
      Remove the unmaintained performance monitor. · 7f48a174
      tonyg authored
      It's not launched nor are there plans to do so. The last commit
      was Dec, 2012 and there was a thread about removing it on chromium-dev in May.
      
      My immediate use-case is to quelch the periodic idle wakeups
      due to the performance monitor, but at this point, simply removing it seems
      preferable to digging in to fix the timer.
      
      BUG=411488,130212
      
      Review URL: https://codereview.chromium.org/547063003
      
      Cr-Commit-Position: refs/heads/master@{#294298}
      7f48a174
    • oshima's avatar
      V2 app support step2 : Use NativeAppWindow for Activity's window. · be9f1628
      oshima authored
       This CL removes redundant widget created by Activity, and use NativeAppWindow instead.
      
      Activity APIs needs to some cleanup and I'll look into it once hashimoto-san finished app_window transition.
      
      step3 will replace ChromeAppNativeWindowViews with athena's impl.
      
      BUG=410448
      
      Review URL: https://codereview.chromium.org/558243002
      
      Cr-Commit-Position: refs/heads/master@{#294297}
      be9f1628
    • tapted's avatar
      MacViews: Ensure the RootView is in place before the first call to ReorderNativeViews · f1d241a5
      tapted authored
      This gets 3 views_unittests passing:
       - ViewTargeterTest.HitTestCallsOnView,
       - ViewTest.CanProcessEventsWithinSubtree,
       - ViewTest.GetEventHandlerForRect.
      
      These were failing because the size of the RootView was being reset to
      the Widget size when first added. This happened because NativeWidgetMac
      was not ensuring the RootView was set up properly immediately after a
      call to Widget::Init() for all Widget types (i.e. those without a
      NonClientView).
      
      When there _is_ a NonClientView, Widget::Init() calls SetContentsView()
      which would eventually trickle down to
      NativeWidgetMac::ReorderNativeViews(), which is where NativeWidgetMac
      would set up the root view.
      
      BUG=378134
      
      Review URL: https://codereview.chromium.org/559873002
      
      Cr-Commit-Position: refs/heads/master@{#294296}
      f1d241a5
    • rtenneti's avatar
      Landing Recent QUIC Changes. · e970ae47
      rtenneti authored
      Simplify QuicUnackedPacketMap's RemovePreviousTransmissions by always
      removing all old transmissions.
      
      When truncated acks start arriving, they don't stop until least_unacked
      is raised, which takes an entire RTT, so this is the eventual effect of
      all those truncated acks.  Instead, remove all of them the first time.
      
      Merge internal change: 74881713
      https://codereview.chromium.org/556103002/
      
      Discard old packets from the QuicSentPacketManager which are only
      present for RTT purposes(typically acks) when the map exceeds 200 packets.
      
      Merge internal change: 74814618
      https://codereview.chromium.org/551223002/
      
      Fix a flaky QUIC end_to_end_test when the socket was suddenly unwritable
      and the connection closed, but CanWrite returned true.
      
      Merge internal change: 74798317
      https://codereview.chromium.org/550703003/
      
      Fix a crash bug in QuicUnackedPacketMap when truncated acks arrived.
      
      Merge internal change: 74792668
      https://codereview.chromium.org/554993002/
      
      Send an ack when it 20 packets have been received since the last ack was
      sent.
      
      This allows the peer to discard data from the SentPacketManager.
      
      Merge internal change: 74741188
      https://codereview.chromium.org/555653002/
      
      R=rch@chromium.org
      
      Review URL: https://codereview.chromium.org/561513003
      
      Cr-Commit-Position: refs/heads/master@{#294295}
      e970ae47
    • jshin's avatar
      Update the font preference for CJK · 7167ed15
      jshin authored
      Noto Sans CJK {Japanese,Korean,Simplified Chinese,Traditional Chinese}
      are renamed Noto Sans CJK {JP,KR,SC,TC} to make their names
      future-proof (to work around the length restriction on another
      platform).
      
      We want to minimize the potential confusion (on the
      part of developers) due to this name change
      by adding the fonts with new names in the trunk and Chrome OS 38 branch
      asap.
      
      This CL will be landed  along with the corresponding Chrome OS CL to
      actually update the font files and a Skia CL.
      
      Skia CL: https://codereview.chromium.org/554943002/
      CrOS CL: https://chromium-review.googlesource.com/217290
      
      BUG=412151
      TEST=Once the fonts are updated on Chrome OS, Noto Sans CJK {SC,JP,KR}
      fonts are used in {zh,ja,ko}.wikipedia.org. They can be checked with
      DOM Inspector.
      TEST=`data:text/html,<span style="font-family:sans-serif;"
      lang="ja">&#x4E00;</span>` uses 'Noto Sans CJK JP`.
      TEST=Same as above with lang={ko,zh-CN,zh-TW} and font="Noto Sans CJK
      {KR,SC,TC}" as indicated in the DOM Inspector.
      
      Review URL: https://codereview.chromium.org/551963003
      
      Cr-Commit-Position: refs/heads/master@{#294294}
      7167ed15
    • dcheng's avatar
      Remove implicit conversions from scoped_refptr to T* in c/b/chromeos/drive · 3626f120
      dcheng authored
      This patch was generated by running the rewrite_scoped_refptr clang tool
      on a ChromeOS build.
      
      BUG=110610
      
      Review URL: https://codereview.chromium.org/546303003
      
      Cr-Commit-Position: refs/heads/master@{#294293}
      3626f120
    • orglofch's avatar
      cc:: Add LatencyQuery logic back into OutputSurface. · 64579af2
      orglofch authored
      Flickering no longer evident on Note 3 Device.
      
      BUG=317928
      
      Review URL: https://codereview.chromium.org/560123002
      
      Cr-Commit-Position: refs/heads/master@{#294292}
      64579af2
    • raymes's avatar
      Always use the caller's context in PepperTryCatchV8 · 1630477a
      raymes authored
      This removes the DCHECK from PepperTryCatch which checks that the current
      context is equal to the plugin context. This assumption is not always true.
      In particular, if we call into the plugin directly from another frame (which
      is in the same origin) the current context will differ. The same is true for background scripts. This should be ok; we should always use the calling context so as to not leak v8 objects across contexts.
      
      BUG=412062
      
      Review URL: https://codereview.chromium.org/555583003
      
      Cr-Commit-Position: refs/heads/master@{#294291}
      1630477a
    • jamiewalch's avatar
      Scroll-bar browser test. · 7689f9b0
      jamiewalch authored
      This doesn't yet do the most interesting test--whether or not scroll-bars
      work correctly when connected to a host--but that should be simple to add
      once a ClientPlugin mock is implemented.
      
      Review URL: https://codereview.chromium.org/552923002
      
      Cr-Commit-Position: refs/heads/master@{#294290}
      7689f9b0
    • hjd's avatar
      Roll android_webview_glue to android_manifest · ab54e01c
      hjd authored
      Get the android_webview_glue DEPS entry back in sync with the
      aosp_manifest.xml.
      
      BUG=
      
      Review URL: https://codereview.chromium.org/560023003
      
      Cr-Commit-Position: refs/heads/master@{#294289}
      ab54e01c
    • raymes's avatar
      Hold a handle to the v8 context in PepperTryCatchVar. · 85d12eb7
      raymes authored
      It is safer to hold a handle to v8 context in PepperTryCatchVar than to try
      retrieving it again on destruction from the frame (through the plugin instance) which has
      a chance of being torn down.
      
      BUG=411445
      
      Review URL: https://codereview.chromium.org/562763005
      
      Cr-Commit-Position: refs/heads/master@{#294288}
      85d12eb7
    • alekseys's avatar
      Print Preview UI changes: · 4db543f3
      alekseys authored
      - show 'More options' section only if there are more than 6 sections
        avaialble
      - add ARIA labels for the color, copies, margins, layout and paper
        settings
      - group Paper size section with other collapsible sections
      - adjust Advanced options button size to fit the text
      
      BUG=397741
      
      Review URL: https://codereview.chromium.org/556363003
      
      Cr-Commit-Position: refs/heads/master@{#294287}
      4db543f3
    • nednguyen's avatar
      Improve debugging message to show the number of running browsers upon failures. · c1f585ef
      nednguyen authored
      BUG=412713
      
      Review URL: https://codereview.chromium.org/560823003
      
      Cr-Commit-Position: refs/heads/master@{#294286}
      c1f585ef
    • michaelpg's avatar
      Schedule sliding transition after height change · fdda1949
      michaelpg authored
      On the BrowserOptions page, sections that are supposed to hide with an upward sliding transition instead hide instantly.
      
      This is apparently because the style recalc that adds the CSS transition also sets the new section height (i.e., the first style recalc usually doesn't happen before the setTimeout is triggered in animatedSectionHeightChange_). To work around this, force a recalc before setting the new height.
      
      BUG=394053
      R=dbeam@chromium.org
      
      Review URL: https://codereview.chromium.org/393943003
      
      Cr-Commit-Position: refs/heads/master@{#294285}
      fdda1949
    • bengr's avatar
      Added owner to Net.{Original}ContentLength* histograms · 743386c3
      bengr authored
      These histograms are used to analyze the performance of the
      data reduction proxy.
      
      BUG=412461
      
      Review URL: https://codereview.chromium.org/553273002
      
      Cr-Commit-Position: refs/heads/master@{#294284}
      743386c3
    • jackhou's avatar
      [Ash] Copy alpha_shape when recreating layers. · 1d1fa23c
      jackhou authored
      Windows that have a shape applied via AppWindow.setShape lose
      their shape after being minimized. This is because minimizing
      invokes HidingWindowAnimationObserverBase::DetachAndRecreateLayers.
      
      BUG=408737
      
      Review URL: https://codereview.chromium.org/547283003
      
      Cr-Commit-Position: refs/heads/master@{#294283}
      1d1fa23c
    • wez's avatar
      Don't use SetShape() to round the Findbar views widget corners. · e41575ab
      wez authored
      Now that views widgets can be rendered with transparency there is no
      need to shape the widget for the visual effect, and the impact on hit-
      testing is negligible, so there's really no point shaping the widget.
      
      BUG=408728
      
      Review URL: https://codereview.chromium.org/547673003
      
      Cr-Commit-Position: refs/heads/master@{#294282}
      e41575ab
    • fsamuel's avatar
      BrowserPlugin: Interstitial Pages work · 9e3d9ad0
      fsamuel authored
      This CL fixes resize, focus and cursor issues for interstitial pages inside
      Browser Plugin.
      
      Interstitial page RenderViewHosts are not a part of the main page's WebContents. Thus, BrowserPluginGuest's (a WebContentsObserver) OnMessageReceived method will not catch IPCs coming from interstitials. However, guest interstitials have RenderWidgetHostViewGuests.
      
      By hanlding focus, resize, cursors and the like through RenderWidgetHostViewGuest, we ensure that interstitial pages get the same treatment inside a BrowserPlugin as RenderViewHosts that belong to the guest WebContents.
      
      BUG=273089
      
      Review URL: https://codereview.chromium.org/549323002
      
      Cr-Commit-Position: refs/heads/master@{#294281}
      9e3d9ad0
    • vmpstr's avatar
      Reland of: cc: Add occlusion checker as a fixed view of occlusion tracker. · cdcb5f74
      vmpstr authored
      This patch adds an occlusion checker to get the state of
      occlusion tracker for permanent checks. That is, occlusion
      checker does not have to be queried during a layer walk.
      
      BUG=410932
      R=danakj
      
      Committed: https://crrev.com/1af780529157c94a9e0f05bcf478543b85714f6b
      Cr-Commit-Position: refs/heads/master@{#294205}
      
      Review URL: https://codereview.chromium.org/547723002
      
      Cr-Commit-Position: refs/heads/master@{#294280}
      cdcb5f74
    • kmarshall's avatar
      Create dedicated class for handling wire message formatting and parsing. · ed1a1429
      kmarshall authored
      Add tests for new functionality.
      Surround single-line blocks with curly braces in CastSocket for consistency/safety.
      
      R=mfoltz@chromium.org
      BUG=
      
      Review URL: https://codereview.chromium.org/505453002
      
      Cr-Commit-Position: refs/heads/master@{#294279}
      ed1a1429
    • dcheng's avatar
      Remove implicit conversions from scoped_refptr to T* in chromeos/ · 5adf8d2e
      dcheng authored
      This patch was generated by running the rewrite_scoped_refptr clang tool
      on a ChromeOS build.
      
      BUG=110610
      
      Review URL: https://codereview.chromium.org/560903003
      
      Cr-Commit-Position: refs/heads/master@{#294278}
      5adf8d2e
    • sammc's avatar
      Make some fields non-nullable in serial.mojom and data_stream.mojom. · da421fab
      sammc authored
      This also removes some null checks for the now non-nullable fields.
      
      BUG=407683
      
      Review URL: https://codereview.chromium.org/562563002
      
      Cr-Commit-Position: refs/heads/master@{#294277}
      da421fab
    • sammc's avatar
      Make the ServiceProvider& arg to GetServiceProviderForFrame non-nullable. · afd3e88b
      sammc authored
      This call isn't meaningful with a null ServiceProvider&.
      
      BUG=407683
      
      Review URL: https://codereview.chromium.org/555373003
      
      Cr-Commit-Position: refs/heads/master@{#294276}
      afd3e88b
    • ccameron's avatar
      Workaround to prevent crashes when destroying CGL contexts · 282049cc
      ccameron authored
      Observation 1: It was discovered in crbug.com/410402 that deleting
      the GL textures bound to IOSurfaces before releasing the CGL context
      from the CAOpenGLLayer can result in crashes.
      
      Observation 2: It was discovered in crbug.com/411782 that not deleting
      the GL textures bounds to IOSurfaces before destroying the CGL context
      can result in crashes.
      
      As way speculative workaround for this, retain the CGL context when the
      texture is created (when it is known to be valid), and the post a task to
      - make that CGL context current
      - delete the GL texture
      - make no CGL context current
      - release the CGL context
      - release the IOSurface used by the GL texture
      
      The theory here is that by doing this in a posted task, having a fresh stack
      and having manually retained the CGL context when it was known-valid
      will work around the crash in Observation 1, and manually destroying the
      texture while its IOSurface is still retained and before the CGL context is
      destroyed will work around the crash in Observation 2.
      
      BUG=411782
      
      Review URL: https://codereview.chromium.org/558803002
      
      Cr-Commit-Position: refs/heads/master@{#294275}
      282049cc
    • ananta's avatar
      Ensure that mouse lock works correctly on Chrome ASH in Windows 8. · b306b1e6
      ananta authored
      The lock mouse operation invoked by plugins or pages hides the mouse cursor and ensures that the cursor stays within the bounds
      of the webpage. To ensure that the mouse stays within the bounds of the page, the SetCursorPos operation is executed by the host.
      In ASH, the SetCursorPos API is executed by the viewer process for historical reasons.
      
      As a result on Windows 8 there is a faint possibility that the user may move the mouse to the charms section of the OS, which causes the cursor to
      become visible.
      
      Fix for this is to track if the mouse changed from what was last set in the viewer process and restore it.
      
      The other change is in the RemoteWindowTreeHostWin class where the member ignore_mouse_moves_until_set_cursor_ack_ has been changed to a count
      from a bool flag. This is because the RemoteWindowTreeHostWin::MoveCursorToNative function can be called multiple times before the acks are received
      causing DCHECKs to fire on the ignore_mouse_moves_until_set_cursor_ack_ flag.
      
      BUG=398792
      
      Review URL: https://codereview.chromium.org/560633002
      
      Cr-Commit-Position: refs/heads/master@{#294274}
      b306b1e6
    • blink-deps-roller's avatar
      6226ba67
    • skia-deps-roller's avatar
      Skia roll cc0e311:d9ec549 · 262231d6
      skia-deps-roller authored
      https://skia.googlesource.com/skia/+log/cc0e3110bde60201882a2c512a5cdd73c838f351..d9ec549071581d9d1dc2e5fac3163305ae935a39
      
      CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
      TBR=fmalita@google.com
      
      Review URL: https://codereview.chromium.org/561833005
      
      Cr-Commit-Position: refs/heads/master@{#294272}
      262231d6
    • boliu's avatar
      Revert of Clean up WebMediaPlayerAndroid needs_establish_peer_ (patchset #7... · 515ae254
      boliu authored
      Revert of Clean up WebMediaPlayerAndroid needs_establish_peer_ (patchset #7 id:120001 of https://codereview.chromium.org/557593002/)
      
      Reason for revert:
      Suspected to break tough_video_cases. See crbug.com/412897 for details.
      
      BUG=412897
      
      Original issue's description:
      > Clean up WebMediaPlayerAndroid needs_establish_peer_
      >
      > needs_establish_peer_ has been used to skip actual estalishing a surface
      > texture peer based on many conditions. Not all places that modify
      > actually checks all these conditions so there are bound to be some bugs.
      >
      > This CL aims to tease out all these different conditions and put them in
      > a single function EstablishSurfaceTexturePeerIfNeeded. This function
      > should be called any time these conditions are changed. Makes for much
      > saner reading.
      >
      > BUG=412578
      >
      > Committed: https://crrev.com/701cb640efb326aa107b5b0c25dcf91766fe765f
      > Cr-Commit-Position: refs/heads/master@{#294068}
      
      TBR=qinmin@chromium.org,avayvod@chromium.org,ycheo@chromium.org
      NOTREECHECKS=true
      NOTRY=true
      BUG=412578
      
      Review URL: https://codereview.chromium.org/562803002
      
      Cr-Commit-Position: refs/heads/master@{#294271}
      515ae254
    • scottmg's avatar
      Revert of -fno-exceptions only on .cc files (patchset #1 id:1 of... · f004ba61
      scottmg authored
      Revert of -fno-exceptions only on .cc files (patchset #1 id:1 of https://codereview.chromium.org/560873003/)
      
      Reason for revert:
      Causes ASAN LSAN Linux bot to fail (not in the CQ/try set):
      
      [191/22134 | 8.047] CC obj/third_party/speex/libspeex/libspeex.filters.o
      FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/libc++abi/trunk/src/libc++abi.cxa_new_delete.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC -DCHROMIUM_BUILD -DCR_CLANG_REVISION=214024 -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DUSE_XI2_MT=2 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DUSE_UDEV -DENABLE_EGLIMAGE=1 -DADDRESS_SANITIZER -DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_LOAD_COMPLETION_HACKS=1 -DUSE_NSS=1 -DLEAK_SANITIZER -DWTF_USE_LEAK_SANITIZER=1 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -Igen '-I../../third_party/libc++abi/trunk/include' '-I../../third_party/libc++/trunk/include' -fstack-protector --param=ssp-buffer-size=4 -Werror -pthread -fno-strict-aliasing -Wno-unused-parameter -Wno-missing-field-initializers -pipe -fPIC -Wno-reserved-user-defined-literal -Xclang -load -Xclang /b/build/slave/Linux_ASan_LSan_Builder/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -B/b/build/slave/Linux_ASan_LSan_Builder/build/src/third_party/binutils/Linux_x64/Release/bin -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -fstrict-aliasing -nostdinc++ -std=c++11 -Wno-format -Wno-unused-result -m64 -march=x86-64 -fno-omit-frame-pointer -gline-tables-only -fsanitize=address -fsanitize=leak -O2 -fdata-sections -ffunction-sections -fno-slp-vectorize -funwind-tables -fno-exceptions -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -Wno-deprecated  -c ../../third_party/libc++abi/trunk/src/cxa_new_delete.cpp -o obj/third_party/libc++abi/trunk/src/libc++abi.cxa_new_delete.o
      ../../third_party/libc++abi/trunk/src/cxa_new_delete.cpp:50:13: error: cannot use 'throw' with exceptions disabled
                  throw std::bad_alloc();
                  ^
      ../../third_party/libc++abi/trunk/src/cxa_new_delete.cpp:77:5: error: cannot use 'try' with exceptions disabled
          try
          ^
      ../../third_party/libc++abi/trunk/src/cxa_new_delete.cpp:118:5: error: cannot use 'try' with exceptions disabled
          try
          ^
      3 errors generated.
      FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/libc++abi/trunk/src/libc++abi.cxa_aux_runtime.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC -DCHROMIUM_BUILD -DCR_CLANG_REVISION=214024 -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DUSE_XI2_MT=2 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DUSE_UDEV -DENABLE_EGLIMAGE=1 -DADDRESS_SANITIZER -DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_LOAD_COMPLETION_HACKS=1 -DUSE_NSS=1 -DLEAK_SANITIZER -DWTF_USE_LEAK_SANITIZER=1 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -Igen '-I../../third_party/libc++abi/trunk/include' '-I../../third_party/libc++/trunk/include' -fstack-protector --param=ssp-buffer-size=4 -Werror -pthread -fno-strict-aliasing -Wno-unused-parameter -Wno-missing-field-initializers -pipe -fPIC -Wno-reserved-user-defined-literal -Xclang -load -Xclang /b/build/slave/Linux_ASan_LSan_Builder/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -B/b/build/slave/Linux_ASan_LSan_Builder/build/src/third_party/binutils/Linux_x64/Release/bin -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -fstrict-aliasing -nostdinc++ -std=c++11 -Wno-format -Wno-unused-result -m64 -march=x86-64 -fno-omit-frame-pointer -gline-tables-only -fsanitize=address -fsanitize=leak -O2 -fdata-sections -ffunction-sections -fno-slp-vectorize -funwind-tables -fno-exceptions -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -Wno-deprecated  -c ../../third_party/libc++abi/trunk/src/cxa_aux_runtime.cpp -o obj/third_party/libc++abi/trunk/src/libc++abi.cxa_aux_runtime.o
      ../../third_party/libc++abi/trunk/src/cxa_aux_runtime.cpp:24:5: error: cannot use 'throw' with exceptions disabled
          throw std::bad_cast();
          ^
      ../../third_party/libc++abi/trunk/src/cxa_aux_runtime.cpp:29:5: error: cannot use 'throw' with exceptions disabled
          throw std::bad_typeid();
          ^
      2 errors generated.
      FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/libc++abi/trunk/src/libc++abi.cxa_personality.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC -DCHROMIUM_BUILD -DCR_CLANG_REVISION=214024 -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DUSE_XI2_MT=2 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DUSE_UDEV -DENABLE_EGLIMAGE=1 -DADDRESS_SANITIZER -DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_LOAD_COMPLETION_HACKS=1 -DUSE_NSS=1 -DLEAK_SANITIZER -DWTF_USE_LEAK_SANITIZER=1 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -Igen '-I../../third_party/libc++abi/trunk/include' '-I../../third_party/libc++/trunk/include' -fstack-protector --param=ssp-buffer-size=4 -Werror -pthread -fno-strict-aliasing -Wno-unused-parameter -Wno-missing-field-initializers -pipe -fPIC -Wno-reserved-user-defined-literal -Xclang -load -Xclang /b/build/slave/Linux_ASan_LSan_Builder/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -B/b/build/slave/Linux_ASan_LSan_Builder/build/src/third_party/binutils/Linux_x64/Release/bin -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -fstrict-aliasing -nostdinc++ -std=c++11 -Wno-format -Wno-unused-result -m64 -march=x86-64 -fno-omit-frame-pointer -gline-tables-only -fsanitize=address -fsanitize=leak -O2 -fdata-sections -ffunction-sections -fno-slp-vectorize -funwind-tables -fno-exceptions -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -Wno-deprecated  -c ../../third_party/libc++abi/trunk/src/cxa_personality.cpp -o obj/third_party/libc++abi/trunk/src/libc++abi.cxa_personality.o
      ../../third_party/libc++abi/trunk/src/cxa_personality.cpp:1269:21: error: cannot use 'throw' with exceptions disabled
                          throw;
                          ^
      ../../third_party/libc++abi/trunk/src/cxa_personality.cpp:1290:17: error: cannot use 'throw' with exceptions disabled
                      throw be;
                      ^
      ../../third_party/libc++abi/trunk/src/cxa_personality.cpp:1203:5: error: cannot use 'try' with exceptions disabled
          try
          ^
      3 errors generated.
      ninja: build stopped: subcommand failed.
      
      I'm not quite sure what the actual problem is, but revert for now.
      
      Original issue's description:
      > -fno-exceptions only on .cc files
      >
      > R=thakis@chromium.org
      > BUG=335824
      >
      > Committed: https://crrev.com/fad91907037b2616fe446bfbb880f8c19418de43
      > Cr-Commit-Position: refs/heads/master@{#294266}
      
      TBR=thakis@chromium.org
      NOTREECHECKS=true
      NOTRY=true
      BUG=335824
      
      Review URL: https://codereview.chromium.org/564493003
      
      Cr-Commit-Position: refs/heads/master@{#294270}
      f004ba61
    • mostynb's avatar
      remove lambda expression in quic · b9081554
      mostynb authored
      Followup to CL 478153003 which added a lambda expression even
      though we haven't officially switched to c++11 yet.
      
      Review URL: https://codereview.chromium.org/565443002
      
      Cr-Commit-Position: refs/heads/master@{#294269}
      b9081554