GitLab

TBR=zerny@chromium.org

Review URL: https://codereview.chromium.org/462903003

Cr-Commit-Position: refs/heads/master@{#288962}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288962 0039d316-1c4b-4281-b951-d872f2087c98

BUG=308347

Review URL: https://codereview.chromium.org/464683002

Cr-Commit-Position: refs/heads/master@{#288961}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288961 0039d316-1c4b-4281-b951-d872f2087c98

This was removed by r288412 but daisy chooses an incorrect
scale factor if missing.

BUG=402518
R=oshima@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/465783002

Cr-Commit-Position: refs/heads/master@{#288959}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288959 0039d316-1c4b-4281-b951-d872f2087c98

To remove chrome/ dependency from AutocompleteResult

BUG=388504
TEST=components_unittest --gtest_filter="ShouldHideTopVerbatimTest.*"

Review URL: https://codereview.chromium.org/450663002

Cr-Commit-Position: refs/heads/master@{#288958}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288958 0039d316-1c4b-4281-b951-d872f2087c98

This is just a skeleton of the extension and doesn't have any functionality.

Can't use the existing hotword_helper since this has a hard dependency
on a shared module (which doesn't yet exist).

BUG=397019

Review URL: https://codereview.chromium.org/423083002

Cr-Commit-Position: refs/heads/master@{#288956}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288956 0039d316-1c4b-4281-b951-d872f2087c98

R=wtc@chromium.org,rsleevi@chromium.org,mmenke@chromium.org

BUG=398967

Review URL: https://codereview.chromium.org/446623004

Cr-Commit-Position: refs/heads/master@{#288955}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288955 0039d316-1c4b-4281-b951-d872f2087c98

The datatype logic may be operating unders assumptions that break when
the type is stopped from under it, possibly triggering crashes.

BUG=402595

Review URL: https://codereview.chromium.org/462863002

Cr-Commit-Position: refs/heads/master@{#288954}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288954 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334407

Review URL: https://codereview.chromium.org/461773002

Cr-Commit-Position: refs/heads/master@{#288953}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288953 0039d316-1c4b-4281-b951-d872f2087c98

BUG=350234
R=sky@chromium.org

Review URL: https://codereview.chromium.org/455393002

Cr-Commit-Position: refs/heads/master@{#288952}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288952 0039d316-1c4b-4281-b951-d872f2087c98

Sync: Add a SyncTypePreferenceProvider interface to specify sync types to enable. The PSS evaluates these.
For now, this is used by the SupervisedUserService to specify data types that must always be enabled.

BUG=395105

Review URL: https://codereview.chromium.org/428143002

Cr-Commit-Position: refs/heads/master@{#288951}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288951 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402118

Review URL: https://codereview.chromium.org/453203002

Cr-Commit-Position: refs/heads/master@{#288950}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288950 0039d316-1c4b-4281-b951-d872f2087c98

The thread watcher appears to be kicking on when we're trying to
remove a handle. Not sure why. This converts some DCHECKs to CHECKs
and fixes handling of the deadline. I suspect none of this will help,
but it's worth a shot.

BUG=399769
TEST=none
R=darin@chromium.org

Review URL: https://codereview.chromium.org/454433003

Cr-Commit-Position: refs/heads/master@{#288949}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288949 0039d316-1c4b-4281-b951-d872f2087c98

Add UMA to track how many users open the app info dialog.

BUG=395501

Review URL: https://codereview.chromium.org/424943002

Cr-Commit-Position: refs/heads/master@{#288948}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288948 0039d316-1c4b-4281-b951-d872f2087c98

Revert of [DevTools] Make DevTools clients talk directly to DevToolsAgentHost instead of using DevToolsManage… (https://codereview.chromium.org/449043002/)

Reason for revert:
https://code.google.com/p/chromium/issues/detail?id=402835

Original issue's description:
> [DevTools] Make DevTools clients talk directly to DevToolsAgentHost instead of using DevToolsManager.
> 
> Previously, client used methods on DevToolsManager passing |this| to most of them.
> Instead, it should hold a scoped_refptr to inspected DevToolsAgentHost and talk
> to it directly. This creates a single clean entry point for the client, and allows
> in the future to handle browser-wide protocol messages and debug multiple hosts at once.
> 
> BUG=401073
> TBR=kalman@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288452

TBR=jam@chromium.org,kalman@chromium.org,dgozman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=401073

Review URL: https://codereview.chromium.org/467653002

Cr-Commit-Position: refs/heads/master@{#288946}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288946 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#288945}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288945 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/6b143b080820c34c9c0f80e5c682939e9ee3879d..ea13afff6e46d8a969611cdd56c996bfb05a27c1

One test, virtual/gpu/fast/canvas/canvas-createImageBitmap-colorClamping.html , has been marked as NeedsManualRebaseline with Blink r180027.

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_layout_rel
TBR=bsalomon@google.com
NOTRY=True
BUG=

Review URL: https://codereview.chromium.org/466533002

Cr-Commit-Position: refs/heads/master@{#288944}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288944 0039d316-1c4b-4281-b951-d872f2087c98

ScopedClassSwizzler from ui/test is wanted for new tests where it can't
currently be accessed. It also re-implements a concept in
chrome/common/mac/objc_method_swizzle.*

This change adds base::mac::ScopedObjCClassSwizzler, merges concepts
from objc_method_swizzle, and adjusts chrome_browser_application_mac.mm
to use the new swizzler.

The test from objc_method_swizzle is adapted and extended for the scoped
swizzler.

BUG=378134
TEST=base_unittests

Review URL: https://codereview.chromium.org/345243007

Cr-Commit-Position: refs/heads/master@{#288943}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288943 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#288941}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288941 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401296

Includes fix for nameless struct handling.

Review URL: https://codereview.chromium.org/451013004

Cr-Commit-Position: refs/heads/master@{#288940}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288940 0039d316-1c4b-4281-b951-d872f2087c98

Due to not updating the version number, the list of events 
listened for by the component extension was not being 
updated. Therefore, profiles who had been using hotwording
for a while now were still listening for events on tab 
events and therefore opening the hotword helper on any 
all tab events.

By updating the version number, it will overwrite the events 
list and the helper should now only wake up upon messages 
directed to it from our specified locations.

I've jumped from 1 to 2 because in reality, that's about 
where we should be based on the number of changes since 
version 1.0.

BUG=400579,378844
TEST=
1) Run chrome with an old version such as 36.
2) In the Preferences file (<profile name>/Preferences) in the section named "dnhpdliibojhegemfjheidglijccjfmc", there should be a list named "events" which should look like: "events": [ "hotwordPrivate.onEnabledChanged", "tabs.onActivated", "tabs.onUpdated" ],
3) Now run the new version in the same profile directory.
4) In the same file and section as step 2, the "events" list should look like: "events": [ ]

Review URL: https://codereview.chromium.org/457863002

Cr-Commit-Position: refs/heads/master@{#288939}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288939 0039d316-1c4b-4281-b951-d872f2087c98

This test is disabled due to regression but it has been fixed in crbug.com/288321. So this patch re-enables the test.

BUG=400892
TEST=browser_test passes
TBR=fukino@chromium.org

Review URL: https://codereview.chromium.org/455783003

Cr-Commit-Position: refs/heads/master@{#288938}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288938 0039d316-1c4b-4281-b951-d872f2087c98

This was done using the scripts in tools/metrics/histograms.

NOTRY=true

Review URL: https://codereview.chromium.org/444863002

Cr-Commit-Position: refs/heads/master@{#288937}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288937 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374038
TEST=local tests on Nexus 7. Nexus 5 and Galaxy Note 3
R=tommi@chromium.org

Review URL: https://codereview.chromium.org/458183002

Cr-Commit-Position: refs/heads/master@{#288936}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288936 0039d316-1c4b-4281-b951-d872f2087c98

UX feedback is that users generally look at the keyboard when starting to
type passwords and thus miss the prompt. The UI will now show until the user
types 5 characters instead of being dismissed after they type anything.

BUG=318977

Review URL: https://codereview.chromium.org/447873004

Cr-Commit-Position: refs/heads/master@{#288935}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288935 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402196
TEST=manually

Review URL: https://codereview.chromium.org/461833002

Cr-Commit-Position: refs/heads/master@{#288934}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288934 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#288933}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288933 0039d316-1c4b-4281-b951-d872f2087c98

See https://codereview.chromium.org/452933006/
for the actual changes.

TBR=tomfinegan@chromium.org
BUG=http://code.google.com/p/chromium/issues/detail?id=392112

Review URL: https://codereview.chromium.org/460173002

Cr-Commit-Position: refs/heads/master@{#288932}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288932 0039d316-1c4b-4281-b951-d872f2087c98

BUG=398767

Review URL: https://codereview.chromium.org/423373003

Cr-Commit-Position: refs/heads/master@{#288931}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288931 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/464873002

Cr-Commit-Position: refs/heads/master@{#288929}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288929 0039d316-1c4b-4281-b951-d872f2087c98

Revert of ServiceWorker: Prevent worker script with incorrect MIME type to be registered. (https://codereview.chromium.org/446323002/)

Reason for revert:
Suspected for breakage on Mac waterfall bots (10.6/10.7)

test ServiceWorkerBrowserTest.ImportsBustMemcache failing since

http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%281%29/builds/54624
http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%281%29/builds/25141

Times out. errors like

[ RUN      ] ServiceWorkerBrowserTest.ImportsBustMemcache
[16435:263:0812/001516:2160051331590:INFO:CONSOLE(13)] "initial unregistration done", source: http://127.0.0.1:58683/service_worker/imports_bust_memcache.html (13)
BrowserTestBase signal handler received SIGTERM. Backtrace:
0   content_browsertests                0x6249bcaa base::debug::StackTrace::StackTrace() + 26
..
11  AppKit                              0x96eeddd6 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 156
12  AppKit                              0x96eb01f3 -[NSApplication run] + 821
..
19  content_browsertests                0x6228bf46 content::TitleWatcher::WaitAndGetTitle() + 118
20  content_browsertests                0x61ed5252 content::ServiceWorkerBrowserTest_ImportsBustMemcache_Test::RunTestOnMainThread() + 530
[649/649] ServiceWorkerBrowserTest.ImportsBustMemcache (TIMED OUT)

Original issue's description:
> ServiceWorker: Prevent worker script with incorrect MIME type to be registered.
> 
> Fix for spec update: https://github.com/slightlyoff/ServiceWorker/issues/380.
> A valid worker script MIME type should be one of below:
> application/x-javascript
> text/javascript
> application/javascript
> 
> BUG=400604
> TEST=https://codereview.chromium.org/448063002/
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288922

TBR=falken@chromium.org,michaeln@chromium.org,thestig@chromium.org,xiang.long@intel.com
NOTREECHECKS=true
NOTRY=true
BUG=400604

Review URL: https://codereview.chromium.org/459383002

Cr-Commit-Position: refs/heads/master@{#288927}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288927 0039d316-1c4b-4281-b951-d872f2087c98

Modify error message because previous message is less information.

BUG=399333

TEST=manually

Review URL: https://codereview.chromium.org/455273002

Cr-Commit-Position: refs/heads/master@{#288923}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288923 0039d316-1c4b-4281-b951-d872f2087c98

Fix for spec update: https://github.com/slightlyoff/ServiceWorker/issues/380.
A valid worker script MIME type should be one of below:
application/x-javascript
text/javascript
application/javascript

BUG=400604
TEST=https://codereview.chromium.org/448063002/

Review URL: https://codereview.chromium.org/446323002

Cr-Commit-Position: refs/heads/master@{#288922}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288922 0039d316-1c4b-4281-b951-d872f2087c98

    It uses TrackStartError to summarize all the track error. This is inconsistent
    with the spec. In this Cl, I add the name of the constraint which cause the ConstraintNotSatisfiedError

R=tommi@chromium.org, yzshen@chromium.org, creis@chromium.org, miu@chromium.org
BUG=397057

Review URL: https://codereview.chromium.org/391703002

Cr-Commit-Position: refs/heads/master@{#288921}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288921 0039d316-1c4b-4281-b951-d872f2087c98

    
Flip the flag to enable VAVEA by default.

Also update the CastStreamingApiTest to not require VP8, as we may be using
H264 as well, but just assert on non-empty string for the codec. Do the
same for the audio codec while we are here.


TEST=encoding scenarios
BUG=378962,398322

Review URL: https://codereview.chromium.org/374553002

Cr-Commit-Position: refs/heads/master@{#288920}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288920 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Added multi-finger gestures to touch_exploration_controller (https://codereview.chromium.org/429633002/)

Reason for revert:
tree-closer ui_unittests failing on Linux Chromium OS ASan LSan Tests (3)
test TouchExplorationTest.AllFingerPermutations
failing since
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29/builds/2708

I don't think the failing test itself is generating output, but
there are some LOG(INFO)s that have been snuck through
with the VLOG(0) trick which might help diagnose.

Original issue's description:
> Added multi-finger gestures to touch_exploration_controller
> 
> Two fingers: up is go to top, down is read from here, left is browser back, right is browser forward.
> Three fingers: up and down map to page up/down.
> Four fingers: up is home page, down is refresh.
> 
> Three/four finger left/right mappings to be added to the CL soon!
> 
> NOTRY=true (failing android dbg tests - this is not related to Android)
> BUG=387304
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288857

TBR=dmazzoni@chromium.org,aboxhall@chromium.org,mfomitchev@chromium.org,lisayin@chromium.org,evy@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=387304

Review URL: https://codereview.chromium.org/466653002

Cr-Commit-Position: refs/heads/master@{#288914}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288914 0039d316-1c4b-4281-b951-d872f2087c98

Revert of base: Introduce an explicit call for reducing emulated discardable memory usage. (https://codereview.chromium.org/448173002/)

Reason for revert:
tree-closer content_browsertests failing on Linux Chromium OS ASan LSan Tests (1)
test RenderThreadImplBrowserTest.EmulatedDiscardableMemoryDiscardedWhenWidgetsHidden
failing since
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/2501

Error: LeakSanitizer: detected memory leaks (Various Indirect leaks).
..
SUMMARY: AddressSanitizer: 19178 byte(s) leaked in 34 allocation(s).

Original issue's description:
> base: Introduce an explicit call for reducing emulated discardable memory usage.
>     
> This removes the use of memory pressure signals from discardable memory
> system and instead introduces an explicit call for reducing emulated
> discardable memory that the renderer can call when all widgets are hidden
> until we have a better mechanism in place.
>     
> BUG=398087
> TEST=base_unittests,content_browsertests
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288793

TBR=jochen@chromium.org,mark@chromium.org,reveman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=398087

Review URL: https://codereview.chromium.org/458343003

Cr-Commit-Position: refs/heads/master@{#288913}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288913 0039d316-1c4b-4281-b951-d872f2087c98

In theory, 127 outstanding frames should be ok, but due to a bug in our code,
we can run into problem if we see a jump in frames larger than 64. This
CL will work around that problem by restricting the max outstanding frames to
60. In a later CL, we'll change this to a larger number once the actual bug
has been found and fixed.

BUG=402693
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/455053003

Cr-Commit-Position: refs/heads/master@{#288904}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288904 0039d316-1c4b-4281-b951-d872f2087c98

for UPPER and LOWER varieties.

No behavior change, just less console spew.

BUG=402311

Review URL: https://codereview.chromium.org/460143003

Cr-Commit-Position: refs/heads/master@{#288902}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288902 0039d316-1c4b-4281-b951-d872f2087c98

A better fix to not missing any callbacks during Java initialization is setting
the SurfaceView visibility to VISIBLE only after libraries has loaded. This
change removes the delayedRunnable setup and adds an assert to make sure we dont
have a valid surface before native load.

BUG=401581

Review URL: https://codereview.chromium.org/462783002

Cr-Commit-Position: refs/heads/master@{#288901}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288901 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/460843002

Cr-Commit-Position: refs/heads/master@{#288900}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288900 0039d316-1c4b-4281-b951-d872f2087c98