GitLab

According to specs hr tag should have xml role as separator.

BUG=384723

Review URL: https://codereview.chromium.org/610973002

Cr-Commit-Position: refs/heads/master@{#297185}

In order for CrOS Core services to speak Mojo, the mojo_shell will need to be able to accept incoming connections from externally-managed processes.

POR is to have the shell listen on a unix domain socket and convert incoming connections to a proper Mojo MessagePipe and then wire it to an InterfaceImpl<ExternalApplicationRegistrar>, which will make the appropriate calls on ApplicationManager.

BUG=418289
TEST=mojo_external_application_tests
STATUS=Fixed

Review URL: https://codereview.chromium.org/522443003

Cr-Commit-Position: refs/heads/master@{#297184}

On Debug ChromeOS bot, this takes 5 minutes.

BUG=414808
TBR=sky

Review URL: https://codereview.chromium.org/612673002

Cr-Commit-Position: refs/heads/master@{#297183}

Adding this handler will make authoring tests which exercise cross-site navigations much easier. This is harder in the current codebase, because testserver runs on a random port each time it is ran which requires boilerplate code in each test that needs it. Instead of computing the real URL in C++ code, just navigate using "/cross-site/hostname/path/and/more" and the server will redirect to the new host.
This requires browser tests to map all hosts to localhost, which is done by adding 'host_resolver()->AddRule("*", "127.0.0.1");' to the beginning of the test.

BUG=418236

Review URL: https://codereview.chromium.org/612533002

Cr-Commit-Position: refs/heads/master@{#297182}

This patch removes low quality mode for low resolution tiles. It also
cleansup some logic with tile versions, since there's only one now.

As a follow-up we can see if we should move the tile version stuff
onto tile directly, although I kind of prefer having a separate class
just for managing what mode we're drawing.

BUG=417876
R=enne, reveman, danakj

Review URL: https://codereview.chromium.org/603683006

Cr-Commit-Position: refs/heads/master@{#297181}

BUG=392145
TBR=benm

Review URL: https://codereview.chromium.org/459953002

Cr-Commit-Position: refs/heads/master@{#297180}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/c13bc57..c06d9a7

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/612883002

Cr-Commit-Position: refs/heads/master@{#297179}

Quick Report reports they have fixed the issue and the dll now works
correctly with chromium.

BUG=382561

Review URL: https://codereview.chromium.org/617453002

Cr-Commit-Position: refs/heads/master@{#297178}

One (1!) line fix to remove Valgrind issue. Original review https://codereview.chromium.org/543753002/

Keeps the fetcher functionality as ImageFetcherImpl in chrome/browser/search/suggestions.

BUG=387751
TBR=blundell
TEST=ImageManagerTest,ImageFetcherBrowserTest

Review URL: https://codereview.chromium.org/607183002

Cr-Commit-Position: refs/heads/master@{#297177}

Fix issue with method with empty response.
Fix issue with local variable shadowing user parameters.

R=ppi@chromium.org

Review URL: https://codereview.chromium.org/607933002

Cr-Commit-Position: refs/heads/master@{#297176}

Mojom targets containing files referencing imported entities need to
depend on targets containing the imported .mojom files. This patch fixes
existing omissions.

BUG=417289

Review URL: https://codereview.chromium.org/611023002

Cr-Commit-Position: refs/heads/master@{#297175}

BUG=418258
TBR=pfeldman

Review URL: https://codereview.chromium.org/615533002

Cr-Commit-Position: refs/heads/master@{#297174}

This gets Put() closer to the cache spec.

Downstream of: https://codereview.chromium.org/606843002/

BUG=392621

Review URL: https://codereview.chromium.org/608593003

Cr-Commit-Position: refs/heads/master@{#297173}

BUG=418369
TBR=zelidrag@chromium.org

Review URL: https://codereview.chromium.org/607413004

Cr-Commit-Position: refs/heads/master@{#297172}

BUG=418572
TBR=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/607333003

Cr-Commit-Position: refs/heads/master@{#297171}

Revert of Rebaseline for findbugs for Android. (patchset #1 id:1 of https://codereview.chromium.org/611013002/)

Reason for revert:
This has created issues in other bots:
https://chromegw.corp.google.com/i/chromium.linux/builders/Android%20Builder%20(dbg)/builds/66548/steps/findbugs/logs/stdio

Looks like a different configuration is used on different bots, yielding a different output. Reverting for now.

Original issue's description:
> Rebaseline for findbugs for Android.
>
> BUG=418549
> NOTRY=true
>
> Committed: https://crrev.com/26fb9711a189ed3c49ae90873981e074c38534b0
> Cr-Commit-Position: refs/heads/master@{#297165}

TBR=yfriedman@chromium.org,ppi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=418549

Review URL: https://codereview.chromium.org/613653005

Cr-Commit-Position: refs/heads/master@{#297170}

BUG=None
TBR=tommi

Review URL: https://codereview.chromium.org/613613003

Cr-Commit-Position: refs/heads/master@{#297169}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/b5fae93..c13bc57

This roll includes SkDevice::drawPosText API changes for GatherPixelRefDevice and VectorPlatformDeviceEmf, needed after https://codereview.chromium.org/605533002.

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/607853003

Cr-Commit-Position: refs/heads/master@{#297168}

On the Blink side:
The clamping method used by computeScaleAndScrollForBlockRect now
uses a new method PinchViewport::clampDocumentOffsetAtScale to clamp
the requested viewport offset taking into account the inner and outer
viewports.

Also added an overload of applyViewportDeltas, called in virtual
viewport mode only, that applies the inner and outer deltas along
page scale in one shot. This makes the viewport layers a special case
again in that their scroll offsets are set through this call, rather
than the standard 'did_scroll' callback of most layers. This is needed
since the scroll offsets may be invalid until the page scale is
applied so this is handled in one method to prevent unintended
clamping.

On the Compositor side:
Calls the appropriate applyViewportDeltas based on which pinch mode
we're running in. The page scale animation now prefers to scroll the
inner viewport first, scrolling the outer only when the inner has
reached its scroll extent.

Blink-side: https://codereview.chromium.org/584833003

BUG=364106

Review URL: https://codereview.chromium.org/585063002

Cr-Commit-Position: refs/heads/master@{#297167}

Note: will land on Monday; need to watch bots so that they execute the
test right.

TBR=vrk@chromium.org
BUG=418034

Review URL: https://codereview.chromium.org/599103006

Cr-Commit-Position: refs/heads/master@{#297166}

BUG=418549
NOTRY=true

Review URL: https://codereview.chromium.org/611013002

Cr-Commit-Position: refs/heads/master@{#297165}

The Put callback functions took an absurd number of paramters.  This
CL simplifies by putting them in a context struct.  This is needed by
a downstream CL that needs to add another member to the struct.

Upstream of: https://codereview.chromium.org/608593003

BUG=392621

Review URL: https://codereview.chromium.org/606843002

Cr-Commit-Position: refs/heads/master@{#297164}

Allow component IME extensions use app.window and add 'ime' boolean in CreateWindowOptions for app window

To create an IME window, an IME must be whitelisted, must have app.window.ime permission and must use set 'ime' and 'frame' this way:
chrome.app.window.create(url, {
  'ime': true,
  'frame': 'none
}, function() {})
Note only whitelisted component IME extensions can use this boolean parameter. See doc here: https://docs.google.com/a/google.com/document/d/1JQHpLu_RjN8C1Yi0i_eApS5SZtPoMDqvlq06YOwXCFU/edit

BUG=401984

Review URL: https://codereview.chromium.org/503383002

Cr-Commit-Position: refs/heads/master@{#297163}

Cr-Commit-Position: refs/heads/master@{#297162}

No functional change in this bug, but it paves the way to doing real work
with the PasswordStore by separating the IPC-handling bits from the
PasswordManagerClient implementation so that we can easily subclass
PasswordStoreConsumer in a way that keeps all the credential functionality
well-contained in a single object for clarity.

BUG=400674

Review URL: https://codereview.chromium.org/615483002

Cr-Commit-Position: refs/heads/master@{#297161}

BUG=216422
TEST=manual.

Review URL: https://codereview.chromium.org/613653004

Cr-Commit-Position: refs/heads/master@{#297160}

BUG=371692

Review URL: https://codereview.chromium.org/614673002

Cr-Commit-Position: refs/heads/master@{#297159}

Blink WebString::fromUTF8 are marginally faster than UTF8ToUTF16 on
pure ASCII input because they have a fast path for this case. Implement
the same thing for base::UTF8ToUTF16

DoIsStringASCII is now a port of charactersAreAllASCII from Blink.

BUG=391492
R=brettw@chromium.org, torne@chromium.org

Review URL: https://codereview.chromium.org/543043002

Cr-Commit-Position: refs/heads/master@{#297158}

and having it rely entirely on Finch.
BUG=417851
R=rkaplow, cbentzel

Review URL: https://codereview.chromium.org/606003003

Cr-Commit-Position: refs/heads/master@{#297157}

Removed all other manual test files in the ../webrtc/manual folder. They
too have moved to GitHub but are not used that often hence no redirect
pages are necessary.

The ../webrtc/manual folder now resides here:
https://github.com/GoogleChrome/webrtc/tree/master/samples/web/content/manual-test

BUG=NONE
NOTRY=TRUE

Review URL: https://codereview.chromium.org/609733002

Cr-Commit-Position: refs/heads/master@{#297156}

This patch allows to fetch thumbnails via metadata cache for provided file
systems.

TEST=Tested manually.
BUG=407954

Review URL: https://codereview.chromium.org/609263002

Cr-Commit-Position: refs/heads/master@{#297155}

BUG=398049

Review URL: https://codereview.chromium.org/577923002

Cr-Commit-Position: refs/heads/master@{#297154}

Will fix this test once the chromium side changes for this
issue will be merged 169574.

BUG=169574

Review URL: https://codereview.chromium.org/612563004

Cr-Commit-Position: refs/heads/master@{#297153}

R=isherman@chromium.org
BUG=

Review URL: https://codereview.chromium.org/611523002

Cr-Commit-Position: refs/heads/master@{#297152}

BUG=418275
TEST=manually tested

Review URL: https://codereview.chromium.org/611953002

Cr-Commit-Position: refs/heads/master@{#297151}

Revert of Revert of Add nullptr support to scoped_ptr. (patchset #1 id:1 of https://codereview.chromium.org/604423005/)

Reason for revert:
multiple compilation errors

Original issue's description:
> Revert of Add nullptr support to scoped_ptr. (patchset #8 id:200001 of https://codereview.chromium.org/599313003/)
>
> Reason for revert:
> This patch seems to break ScopedPtrWithArray ASAN test.
>
> https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20(1)/builds/2348/steps/base_unittests
>
> Original issue's description:
> > Add nullptr support to scoped_ptr.
> >
> > This adds support to use nullptr to construct, assign, or return a
> > scoped_ptr<T> and scoped_ptr<T[]>. Support for this requires the use
> > of a move-only constructor.
> >
> > The changes are:
> >
> > - Add a constructor that takes decltype(nullptr) as a parameter. This
> > allows behaviour such as scoped_ptr<T>(nullptr), but also allows a
> > function with return type scoped_ptr<T> to "return nullptr;" instead
> > of "return scoped_ptr<T>();".
> >
> > - Add an operator=(decltype(nullptr)) that resets the scoped_ptr to
> > empty and deletes anything it held.
> >
> > - Add/Modify a constructor to take a scoped_ptr<U,E>&& parameter for
> > constructing a scoped_ptr from another using move-only semantics. This
> > piece is critical for allowing the function returning nullptr to be
> > assigned to some other scoped_ptr at the callsite. In particular, take
> > the following code:
> >   scoped_ptr<T> Function() { return nullptr; }
> >   scoped_ptr<T> var = Function();
> > In this case the constructor which takes a nullptr allows Function() to
> > be written, but not to be used. The move-only constructor allows the
> > assignment from Function() to var. See "C++11 feature proposal:
> > Move-only constructors" on chromium-dev for more explanation why.
> >
> > The scoped_ptr<T> class already had a constructor which took
> > scoped_ptr<U,E> as an argument, so this was changed to be
> > scoped_ptr<U,E>&& instead. The scoped_ptr<T[]> class had no such
> > constructor, so a scoped_ptr&& constructor was added. These match
> > the constructors found on the unique_ptr class.
> >
> > - Remove the RValue type and the contructor that constructs a
> > scoped_ptr from an RValue. Change Pass() to return a scoped_ptr&&
> > instead of a scoped_ptr::RValue, to avoid the type conversion and
> > remove some complexity. This is done with a new emulation macro that
> > still provides Pass() and makes the type go down the MoveOnlyType
> > path in base::Callback code.
> >
> > This adds base_unittests to demonstrate and use these changes.
> >
> > The use of Pass() remains unchanged until std::move() is written
> > or allowed. At that time std::move() could be used instead of Pass.
> >
> > R=brettw@chromium.org, jamesr@chromium.org
> >
> > Committed: https://crrev.com/2299e91d3508f8d5d18ef990cf6024ea4371250a
> > Cr-Commit-Position: refs/heads/master@{#297072}
> >
> > Committed: https://crrev.com/a9527ce329c38d945e46773f1592a4939cf62b99
> > Cr-Commit-Position: refs/heads/master@{#297116}
>
> TBR=brettw@chromium.org,jamesr@chromium.org,thakis@chromium.org,dcheng@chromium.org,danakj@chromium.org
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/300249a2f5d9f0b8b86553712ac7ccb55d6afc1c
> Cr-Commit-Position: refs/heads/master@{#297149}

TBR=brettw@chromium.org,jamesr@chromium.org,thakis@chromium.org,dcheng@chromium.org,danakj@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/611973002

Cr-Commit-Position: refs/heads/master@{#297150}

Revert of Add nullptr support to scoped_ptr. (patchset #8 id:200001 of https://codereview.chromium.org/599313003/)

Reason for revert:
This patch seems to break ScopedPtrWithArray ASAN test.

https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20(1)/builds/2348/steps/base_unittests

Original issue's description:
> Add nullptr support to scoped_ptr.
>
> This adds support to use nullptr to construct, assign, or return a
> scoped_ptr<T> and scoped_ptr<T[]>. Support for this requires the use
> of a move-only constructor.
>
> The changes are:
>
> - Add a constructor that takes decltype(nullptr) as a parameter. This
> allows behaviour such as scoped_ptr<T>(nullptr), but also allows a
> function with return type scoped_ptr<T> to "return nullptr;" instead
> of "return scoped_ptr<T>();".
>
> - Add an operator=(decltype(nullptr)) that resets the scoped_ptr to
> empty and deletes anything it held.
>
> - Add/Modify a constructor to take a scoped_ptr<U,E>&& parameter for
> constructing a scoped_ptr from another using move-only semantics. This
> piece is critical for allowing the function returning nullptr to be
> assigned to some other scoped_ptr at the callsite. In particular, take
> the following code:
>   scoped_ptr<T> Function() { return nullptr; }
>   scoped_ptr<T> var = Function();
> In this case the constructor which takes a nullptr allows Function() to
> be written, but not to be used. The move-only constructor allows the
> assignment from Function() to var. See "C++11 feature proposal:
> Move-only constructors" on chromium-dev for more explanation why.
>
> The scoped_ptr<T> class already had a constructor which took
> scoped_ptr<U,E> as an argument, so this was changed to be
> scoped_ptr<U,E>&& instead. The scoped_ptr<T[]> class had no such
> constructor, so a scoped_ptr&& constructor was added. These match
> the constructors found on the unique_ptr class.
>
> - Remove the RValue type and the contructor that constructs a
> scoped_ptr from an RValue. Change Pass() to return a scoped_ptr&&
> instead of a scoped_ptr::RValue, to avoid the type conversion and
> remove some complexity. This is done with a new emulation macro that
> still provides Pass() and makes the type go down the MoveOnlyType
> path in base::Callback code.
>
> This adds base_unittests to demonstrate and use these changes.
>
> The use of Pass() remains unchanged until std::move() is written
> or allowed. At that time std::move() could be used instead of Pass.
>
> R=brettw@chromium.org, jamesr@chromium.org
>
> Committed: https://crrev.com/2299e91d3508f8d5d18ef990cf6024ea4371250a
> Cr-Commit-Position: refs/heads/master@{#297072}
>
> Committed: https://crrev.com/a9527ce329c38d945e46773f1592a4939cf62b99
> Cr-Commit-Position: refs/heads/master@{#297116}

TBR=brettw@chromium.org,jamesr@chromium.org,thakis@chromium.org,dcheng@chromium.org,danakj@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/604423005

Cr-Commit-Position: refs/heads/master@{#297149}

Added a unittest for ChromePermissionMessageProvider that ensures
permission messages currently coalesce and form as expected. Some of the
tests are purposely for broken functionality, just to ensure this
functionality exists (and will later be fixed). The tests will be
modified once the new model changes this permission behaviour.

BUG=398257

Review URL: https://codereview.chromium.org/594003002

Cr-Commit-Position: refs/heads/master@{#297148}

For adding web animations with animation timing on compositor.

BUG=417909

Review URL: https://codereview.chromium.org/598853003

Cr-Commit-Position: refs/heads/master@{#297147}

Cr-Commit-Position: refs/heads/master@{#297146}