- 29 Nov, 2019 40 commits
-
-
Stepan Khapugin authored
This reverts commit f1623afd. Change-Id: I3ce313b7492c18b0fdb257165e4ff258dcf3b1f7 Bug: 1026579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942687Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#720154}
-
Noel Gordon authored
More CSS to style directory tree for files-ng. This is the last of the CSS patches needed. Again rules like: .tree-row > .file-row > blah ... are specific to files-ng. The .file-row is needed to effect the design and the specific rules related to it avoid peppering the CSS code with a #directory-tree[files-ng] prefix. There are cases where rules should only be applied to normal files app: they generally being with #directory-tree:not([files-ng]) blah ... And finally, the residual #directory-tree rules (files-ng, or not) are shared by both implementations. Bug: 992819 Change-Id: I7698a23d4c423ccbb27b74bc655fb36d1b93a9ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942750 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#720153}
-
Kinuko Yasuda authored
At least we need to test this code more. (May revert back before branch cut) Bug: 939317 Change-Id: I15d0ad2089501bdadf32e51b36fde248e11f2580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943075 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#720152}
-
Kuo Jen Wei authored
Bug: b/141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' and validate all function of CCA on HALv1/v3 device works correctly. Change-Id: Ib7c71fba143b809f612f5148070755cdf1eca131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933860Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#720151}
-
Andreas Haas authored
There still seem to be issues when ArrayBufferContents::Data() returns nullptr for now, see https://crbug.com/1028766. That's why I undo that change which allows nullptr for now and try to fix it after the branch cut. R=haraken@chromium.org Bug: chromium:1008840, chromium:1027937 Change-Id: I6c541e56ef13d2506c32add301dd92e0475f41c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942695Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#720150}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5e2a454edcf7..6d86347795cf Created with: gclient setdep -r src-internal@6d86347795cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I2e18b33fa2d7fc03e8a5cf7c80d398deeb5648e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944054Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720149}
-
Koji Ishii authored
Following r719562 and r719898 to remove the duplicated logic for |NodeForHitTest| in |NGPaintFragment|, this patch moves the rest of this logic in |NGPhysicalFragment| to |LayoutObject| so that it can be shared with |NGFragmentItem|. There should be no behavior changes. Bug: 982194 Change-Id: Iae467845281a9d4fcf479b9b85bb2770132f6f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942591 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#720148}
-
Malay Keshav authored
The test harness crashes for nexus 5 because of the capture size. TBR=ynovikov@chromium.org BUG=chromium:1029389 Change-Id: Ia64d9f12f761ca0d16e055a3cb77a578a7d94c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943547Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#720147}
-
Mikel Astiz authored
This affects: Sync.*AssociationTime Sync.*ConfigureFailure Both groups are rarely consumed these days and have competing metrics that are more interesting (although not identical). Bug: 995514 Change-Id: I44f7b1e18db9eebe1d8172a2b2f2ce2fa75e3ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937370Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#720146}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bc82fb14aab4..c96187a919eb git log bc82fb14aab4..c96187a919eb --date=short --first-parent --format='%ad %ae %s' 2019-11-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader d6e903bdc9ef..fb7ca1d5aca5 (13 commits) Created with: gclient setdep -r src/third_party/angle@c96187a919eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None Tbr: cwallez@google.com Change-Id: I59a363871bd6ed3b1fa3eee593c356f6b4b9e780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944051Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720145}
-
Hiroki Nakagawa authored
TL;DR: This CL makes service_worker_client_utils::GetClients() take blink::mojom::ServiceWorkerHost::GetClientsCallback as a callback instead of base::OnceCallback<void(std::unique_ptr<ServiceWorkerClientPtrs>)>. > Details - In the original code, GetClients() uses std::unique_ptr<ServiceWorkerClientPtrs> as a container to collect client information. ServiceWorkerClientsPtrs is an alias of std::vector<blink::mojom::ServiceWorkerClientInfoPtr>> so this is expanded to std::unique_ptr<std::vector<blink::mojom::ServiceWorkerClientInfoPtr>>> std::vector behaves like a smart pointer, so it's not necessary to wrap std::vector with std::unique_ptr, that is, GetClients() can directly uses std::vector<blink::mojom::ServiceWorkerClientInfoPtr>> as the container type. - In the original code, GetClients() takes base::OnceCallback<void(std::unique_ptr<ServiceWorkerClientPtrs>)> as a callback type. As mentioned above, this can be simplified to base::OnceCallback<void(std::vector<blink::mojom::ServiceWorkerClientInfoPtr>>)> This is equal to blink::mojom::ServiceWorkerHost::GetClientsCallback Change-Id: Ie50965a5d44919207d2829c1642449e300ecc9ea Bug: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943717 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#720144}
-
Hiroki Nakagawa authored
This is a part of the effort to split ServiceWorkerProviderHost into ServiceWorkerHost and ServiceWorkerContainerHost. This CL finally makes ServiceWorkerContainerHost inherit blink::mojom::ServiceWorkerContainerHost instead of ServiceWorkerProviderHost. This is mostly mechanical change, and doesn't change behavior. Design doc: https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing Bug: 931087 Change-Id: Ib59a7ae7398e19459c87d0ebf2a79f21f659307a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943630Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 452 453 454 455 457 461 462 4 lines were removed and 18 lines were deflaked by consecutive results since 440. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Iae8ec83b3bec1a5e383c8dbfca55c781cb06b663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943067Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#720142}
-
Hans Wennborg authored
TBR=ehmaldonado Bug: 1018293 Change-Id: Id6ccd9427ccc9444f2f411eab98ce76a8c98e34e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943131Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#720141}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/310ba9ca..2b0e60d5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ieec59af38bc6179eca26e8f04785cf641e1880ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942999Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720140}
-
Yoshifumi Inoue authored
This patch changes |NGFragmentItem::GetWritingMode()| to work other than text because it is independent from text and value of CSS property. Note: This patch fixes 17 web_test crashes. Bug: 982194 Change-Id: I9f5fdaddb12f3d88b50a1f6c87b026b505ce8ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943497 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b97d4ceb42b4..bcfcc04c53f0 git log b97d4ceb42b4..bcfcc04c53f0 --date=short --first-parent --format='%ad %ae %s' 2019-11-29 fancl@chromium.org Fix displaying wrong job when switching between jobs 2019-11-29 abennetts@google.com Add warning that viewing old results2 docs will fail in M80 and above. 2019-11-29 fancl@chromium.org Fix the generated version string when using docker deploy 2019-11-28 abennetts@google.com Give the 'npm' binary dependency a distinct local path to the 'node' dependency. Created with: gclient setdep -r src/third_party/catapult@bcfcc04c53f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029412,chromium:1021137,chromium:1029242 Tbr: rmhasan@google.com Change-Id: Iab5f70a04796f7aa10bb4b7daa8de894e56c6e3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943672Reviewed-by:
-
Dominic Battre authored
This fixes the flakiness of the test caused by an asynchronous process. It also adds a helper function to components/prefs to wait for a specific pref value to be set. Fixed: 1028765 Change-Id: I23636d9a19c6db1db4fe01257f13a162007ad5c2 Bug: 1028765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939488Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#720137}
-
Takashi Sakamoto authored
Bug: 1029434 Change-Id: Ibf672d2e5ee078e8825371912e4b1fdc82c5a868 Tbr: csharp Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942752Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#720136}
-
Hans Wennborg authored
since we no longer do the chrome.dll / chrome_child.dll split. Bug: none Change-Id: I641f5be99a20eb18be2adfc490bc4b5a0be7442e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942694Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#720135}
-
Yuta Kasai authored
This patch adds tentative wpt test. Currently FetchEvent WorkerTiming is a tentative feature. In chromium, this feature hasn't implemented completely yet, so some tests will be failed. Explainer : https://github.com/wanderview/fetchevent-worker-timing/blob/master/explainer.md Bug: 900700 Change-Id: I7a43989d8833ddd65c93106de67c4ebe6bd9ed52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915644 Commit-Queue: Yuta Kasai <yutakasai@google.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#720134}
-
Abhijeet Kandalkar authored
This CL has goal to use IsA<SVGPolygonElement>(element) in place of IsSVGPolygonElement(element) Bug: 891908 Change-Id: I7a04d9cf58093e1b244670d1e4dc6466849b60b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936615 Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |NGFragmentItemsBuilder::AssociateNextForSameLayoutObject()| not to hit DCHECK about the first item in |NGFragmentItems| for list marker. This is follow-up of the CL[1] introduced wrong DCHECK(). [1] http://crrev.com/c/1930370 [FragmentItem] Introduce next for same layout object cache in NGFragmentItem Bug: 982194 Change-Id: Ic37559dafb795c34529f72fef2c8dff95814094e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943651 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1c5463726c3e..f9cad2f75cd2 git log 1c5463726c3e..f9cad2f75cd2 --date=short --first-parent --format='%ad %ae %s' 2019-11-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 43fc40ae..c8e3617e (252 commits) 2019-11-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 fc3ec57ddf27..bc82fb14aab4 (9 commits) Created with: gclient setdep -r src/third_party/skia@f9cad2f75cd2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None,chromium:None Tbr: bungeman@google.com Change-Id: Ib5541158588622f43ef38de6ec1721c0d9bbbc51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944009Reviewed-by:
-
Yutaka Hirano authored
Intent-to-Deprecate-and-Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Z1XdYf6SjDU Bug: 1013087 Change-Id: I34be2e59d6fa44834333e368dbd06a5e2cf1b876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942187Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#720130}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I75d2c3abf8b721d876dc921f1ecb97839eb6e936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943032Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#720129}
-
Takashi Sakamoto authored
Bug: 1029417 Change-Id: I678b4de72cdebdd3cfd43685085ed0c34a1f24fe Tbr: csharp Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943073Reviewed-by:
-
Yuki Shiino authored
In order to avoid circular #include, use forward decls for the implementation classes of IDL dictionaries. This patch adds a lot of #include "dict.h" due to the change. The main change is only in bindings/scripts/v8_types.py Change-Id: I4a3175a9532a46035eca63e856bcb1c2c3bb8bef Tbr: mkwst@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942887 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Makoto Shimazu authored
This has already been implemented but the comment is left. TBR=falken@chromium.org Bug: 999049 Change-Id: I7359619e74b1d23f48fbc3e21f7f21c293a63457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942889Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eb7cd5902b87..5e2a454edcf7 Created with: gclient setdep -r src-internal@5e2a454edcf7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Ic27f441f72ace4a8cae8b6a4d45c0844adbf202f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944007Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4f14c4f2bdf6..1c5463726c3e git log 4f14c4f2bdf6..1c5463726c3e --date=short --first-parent --format='%ad %ae %s' 2019-11-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader d6e903bdc9ef..fb7ca1d5aca5 (13 commits) Created with: gclient setdep -r src/third_party/skia@1c5463726c3e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None Tbr: bungeman@google.com Change-Id: I66602aa0b854eb19ec35cfd4b8e28f76c2b12a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943994Reviewed-by:
-
Alexey Baskakov authored
All async WebAppIconManager read icon methods must return void. A call site should check if an app has appropriate icon via corresponding Has*Icon methods. These changes are required for integration with AppService. This code is disabled by default behind kDesktopPWAsWithoutExtensions base feature. Bug: 1029221 Change-Id: Iad46ea383f062d0b3787e11d20b5f89a08eb61f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943650Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#720123}
-
Alexandre Courbot authored
V4L2Queue logs are useful, but they omitted one important piece of information: which queue triggered the log. Add a few macros to ease the process and make V4L2Queue use them. While at it, fix a small formatting mistake when using VPLOGF in this class. Bug: None Test: Build Chromium for Kukui. Change-Id: I3ec6b7e00c1912ddeaae2a66571052957772d884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939998 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#720122}
-
Alex Danilo authored
Dragging files using mouse positions the drag image origin at the location of the mouse, i.e. the image extends to the right and down. In the case whem the drag is initiated from touch, the drag image is obscured. Check for touch initiated drag and position the image above the touch position. Bug: 755703 Change-Id: I313f245bacb4c0e649cae5597653bcdad4fd1130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943071Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#720121}
-
Noel Gordon authored
Our tree.css comes from the cr.ui.tree source and modified to the taste of files app. Add mode tastiness in form of files-ng. Again, rules like .tree-row > .file-row > blah ... are specific to files-ng (there is an echo in this room). Bug: 992819 Change-Id: I5da539e81005cbb412004461dc5f6ef00a4f5251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942589Reviewed-by:
-
Austin Tankiang authored
Use <cr-dialog>'s default for buttons, flex-end. This is done to be consistent with other dialogs. Tbr: fukino-san Bug: 1026127 Change-Id: I872d535f51d1d2caa1225399dfdf6c9eaed837b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943709 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has goal to use To<SVGPatternElement> and DynamicTo<SVGPatternElement> as new downcast helper Bug: 891908 Change-Id: Ibcc937ce3e849c5132d7e412246eb32268e16f87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936614Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<SVGSVGElement> and DynamicTo<SVGSVGElement> as new downcast helper 2. Use IsA<SVGSVGElement>(element) in place of IsSVGSVGElement(element) Bug: 891908 Change-Id: I2f47d7b1e92f77a7f1584b98ceabae942cfb8552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936619Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has goal to use IsA<SVGPolylineElement>(element) in place of IsSVGPolylineElement(element) Bug: 891908 Change-Id: Icf9966502255b06ee97ea085374054d3498d4b05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936616Reviewed-by:
-
Anqing Zhao authored
Considering the logic of generating request list has been extracted to report_request_queue_generator, we needn't keep two sets of test cases with same converage. The ones in report_generator_unittest.cc should be removed. Bug: 1010213 Change-Id: I183b39de1152a5090e56e34811fb370757306565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940113Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Anqing Zhao <anqing@google.com> Cr-Commit-Position: refs/heads/master@{#720115}
-
