GitLab

It doesn't look like this code is used and besides  AutofillExternalDelegate::has_shown_popup_for_current_edit_ looks like same variable.

Review-Url: https://codereview.chromium.org/2040933002
Cr-Commit-Position: refs/heads/master@{#398018}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4f6e084e..dbae8a5c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2044453002
Cr-Commit-Position: refs/heads/master@{#398017}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/f6720c26fcd4..f58ecb6416a4

$ git log f6720c26f..f58ecb641 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2041753003
Cr-Commit-Position: refs/heads/master@{#398016}

BUG=617063

Review-Url: https://codereview.chromium.org/2035683003
Cr-Commit-Position: refs/heads/master@{#398015}

Keeps the V8 wrappers alive as long as there're event listeners or pending
promises and such.

BUG=616761
TEST=manual, see repro steps in the bug

Review-Url: https://codereview.chromium.org/2038573002
Cr-Commit-Position: refs/heads/master@{#398014}

This cl replaces traceWrappers method with getHeader. The motivation for the
original traceWrappers method was only to get HeapObjectHeader anyway, and this
refactoring simplifies current code and makes further enhancements (such as
incremental tracing :) easier.

LOG=no
BUG=468240

Review-Url: https://codereview.chromium.org/2045453002
Cr-Commit-Position: refs/heads/master@{#398013}

https://chromium.googlesource.com/chromium/src/+/4095e6cfa

BUG=603137
TBR=drott@chromium.org

Review URL: https://codereview.chromium.org/2046513002 .

Cr-Commit-Position: refs/heads/master@{#398012}

This CL adds the tracking of the following per-user-lens metrics in report.py:
- Cumulative cost of requests
- Cumulative cost of preloaded requests

This provides extra insight over just having the number of such requests.

Review-Url: https://codereview.chromium.org/2039853003
Cr-Commit-Position: refs/heads/master@{#398011}

Make CSSProperty store a Member<const CSSValue>, instead of a
Member<CSSValue>. This is pre-work for making CSSValueLists store const
CSSValues.

BUG=526586

Review-Url: https://codereview.chromium.org/2037973002
Cr-Commit-Position: refs/heads/master@{#398010}

Usrsctp is used in WebRTC to handle packets in the data channel.

BUG=

Review-Url: https://codereview.chromium.org/2039483003
Cr-Commit-Position: refs/heads/master@{#398009}

This CL fixes RenderViewImplTest.OnNavigationHttpPost when PlzNavigate is
enabled by having RenderFrameImpl::NavigateInternal chose to use LoadDataURL
instead of WebLocalFrame::load in the same cases as what the current
architecture is doing.

It also ensures that the WebURLLoader will not replace the ResourceResponse it
receives with one provided by the browser when loading a data url. In this
case, the browser has no response to provide. so we should use the one
generated by the HandleDataURL task.

BUG=475027

Review-Url: https://codereview.chromium.org/2037733002
Cr-Commit-Position: refs/heads/master@{#398008}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b32933fb..4f6e084e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2039203002
Cr-Commit-Position: refs/heads/master@{#398007}

Following up on https://codereview.chromium.org/2020053002, we have
line numbers in a variety of cases today, but we're only dumping them
into the reports when a script file generated the error. This patch
ensures that line/column data is appended whenever it's available.

BUG=615862

Review-Url: https://codereview.chromium.org/2032793004
Cr-Commit-Position: refs/heads/master@{#398006}

The spec allows a form control element to have multiple <label> elements,
but we only supported one in accessibility code. Fix it by switching to
using the LabelableElement interface rather than some redundant code that
kept track of label elements in TreeScope, which allows us to get rid of
that now-unused code.

BUG=573494

Review-Url: https://codereview.chromium.org/1939303002
Cr-Commit-Position: refs/heads/master@{#398005}

Addressing Behdad's review comment.

Reland after revert in 3d9eeeef, test expectation can
be rebaselined. Landing TBR, since previously LGTM'ed
in https://codereview.chromium.org/2026433002

BUG=603137
TBR=behdad

Review-Url: https://codereview.chromium.org/2040923002
Cr-Commit-Position: refs/heads/master@{#398004}

Store a reference of ScriptWrappableVisitor also in V8PerIsolateData so it can
be accessed from blink code easily (for example when oilpan will want to trace
ScriptWrappableVisitor's marking deque :)

LOG=no
BUG=468240

Review-Url: https://codereview.chromium.org/2033583007
Cr-Commit-Position: refs/heads/master@{#398003}

Change ImmutableStylePropertySet to store const CSSValue instead of just
CSSValue. This is pre-work for making CSSProperty store const CSSValues.

BUG=526586

Review-Url: https://codereview.chromium.org/2032613007
Cr-Commit-Position: refs/heads/master@{#398002}

Although we already have all own property names to judge if the serializing
array is dense or sparse, getting non indexed ones again for dense arrays
improves performance of serialization of large scale dense arrays.
(For small size arrays and sparse arrays, this CL does not change the performance.)

This CL improves a micro-benchmark score of PerformanceTests/Bindings/serialize-array.html
from 430ms to 260ms on my local machine.
https://chromeperf.appspot.com/report?sid=96d5e4ae4e5a4085541ab88e8672b8836d57d223b759a3d5406a06c0b1a65420

BUG=148757

Review-Url: https://codereview.chromium.org/2037583002
Cr-Commit-Position: refs/heads/master@{#398001}

R=
BUG=

Review-Url: https://codereview.chromium.org/2039713002
Cr-Commit-Position: refs/heads/master@{#398000}

Mention the alternate HeapLinkedHashSet<> if WeakMember<>s are
attempted used with HeapListHashSet<>; for non-trivial reasons,
we only support weakness with the former.

R=
BUG=614112

Review-Url: https://codereview.chromium.org/2034423002
Cr-Commit-Position: refs/heads/master@{#397999}

BUG=602572

Review-Url: https://codereview.chromium.org/1923943003
Cr-Commit-Position: refs/heads/master@{#397998}

This CL creates a UserSatisfiedLens for page load time (PLT) and
refactors report.py to use this new lens. The motivation is to avoid
having to duplicate code tracking metrics for PLT and other user
satisfied events.

This change is not backwards compatible as it changes the names of some
of the keys in report generation.

Review-Url: https://codereview.chromium.org/2032013002
Cr-Commit-Position: refs/heads/master@{#397997}

It's hard to mechanically replace specializations of OwnedPtrDeleter<T>
to std::unique_ptr equivalents. Therefore, they are converted to
std::unique_ptr manually.

The specializations in HarfBuzzFace.h are only used from
HarfBuzzFace.cpp, so the new deleters are added in .cpp file. New
typedefs are created so people can always use std::unique_ptr with a
correct deleter.

BUG=617504

Review-Url: https://codereview.chromium.org/2043613002
Cr-Commit-Position: refs/heads/master@{#397996}

BUG=chromium:474921

Review-Url: https://codereview.chromium.org/2031063002
Cr-Commit-Position: refs/heads/master@{#397995}

GetWindowBoundsInScreen() should never be used to determine
the surface origin as it takes ancestor transforms into
account. Surface origin should be relative to widget window
bounds as they are not affected by transforms.

BUG=549781
TEST=exo_unittests
TBR=dcastagna@chromium.org

Review-Url: https://codereview.chromium.org/2045433002
Cr-Commit-Position: refs/heads/master@{#397994}

This patch makes |Node#removeChild()| and |Node#remove()| faster when
there are active Range objects in document by using DOM tree version as
offset validity instead of invalid offset value on node removal, which is
done by |Range::nodeChildrenChanged()| via
|Document::updateRangesAfterChildrenChanged()|.

This patch is similar to http://crrev.com/2034023003, which makes appendChild
and insertBefore faster.

On my Linux box, "remove-child-with-ranges.html" (with 1000 |Range| objects)
results are:

w/patch:
avg 0.96 runs/s, median 1.00 runs/s, min 0.80 runs/s, max 1.03 runs/s

w/o patch:
avg 0.69 runs/s, median 0.71 runs/s, min 0.56 runs/s, max 0.76 runs/s

BUG=n/a
TEST=PerformanceTests/Mutation/remove-child-with-ranges.html

Review-Url: https://codereview.chromium.org/2039113003
Cr-Commit-Position: refs/heads/master@{#397993}

Spec: https://drafts.css-houdini.org/css-typed-om/#computed-stylepropertymap-objects

Uses a  partial IDL interface to attach a getComputedStyleMap method to
window.

Implements the getAll and getProperties.
Moved has() up into the base class from InlineStylePropertyMap.

Not implemented: iteration

BUG=545318

Review-Url: https://codereview.chromium.org/1849653003
Cr-Commit-Position: refs/heads/master@{#397992}

Review-Url: https://codereview.chromium.org/2041773002
Cr-Commit-Position: refs/heads/master@{#397991}

Backgrounded-tab suspending was introduced at crrev/1914143002, where
only the timer task queue was suspended. We knew this was not enough and
we need to suspend more task queues to prevent the return of purged
cache.

This CL adds the feature to suspend these task queues besides timer task
queues when backgrounded-tab suspending starts:

  * default_loading_tq
  * frame_loading_tq

The above task queues might call V8 functions, which means any purged cache
can be reverted.

This CL doesn't suspend "default_tq" (which we can't suspend since this
conveys critial tasks) and "idle_tq" (which I think is not harmful for
purged caches), "control_(after_wakeup_)tq" (which is only for internal
scheduler housekeeping tasks) and "compositor_tq" (which is not used when
the renderer is backgrounded).

BUG=607077
TEST=n/a

Review-Url: https://codereview.chromium.org/2017763003
Cr-Commit-Position: refs/heads/master@{#397990}

BUG=617200

Review-Url: https://codereview.chromium.org/2040833002
Cr-Commit-Position: refs/heads/master@{#397989}

Renamed |m_canResume| to |m_parkingRequested| while doing so,
its (inverted) meaning seems clearer imho in this context.

R=
BUG=

Review-Url: https://codereview.chromium.org/2039793002
Cr-Commit-Position: refs/heads/master@{#397988}

This patch makes |Node#appendChild()| and |Node#insertBefore()| faster when
there are active Range objects in document.

Before this path, we iterate over all active |Range| objects to make there
cached offset invalid for each |appendChild()| and |insertBefore()|.

From this patch, we use both DOM tree version and invalid value of
|m_offsetInContainer| as invalid offset marker to avoid iterating over
all active |Range| objects. This makes execution of speed of |appendChild()| and
|insertBefore()| independent from number of active |Range| objects.

On my Linux box, "append-child-with-ranges.html" (with 100 |Range| objects)
results are:

w/patch:
avg 13.4ms, median 14 ms, min 10ms, max 21ms

w/o patch:
avg 42.1ms, median 42ms, min 38ms, max 49ms

Note: This patch is inspired by esphren@'s comments regarding to crbug/613658
and based on kouhei@'s great idea and strong push.

BUG=n/a
TEST=PerformanceTests/Mutation/append-child-with-ranges.html

Review-Url: https://codereview.chromium.org/2034023003
Cr-Commit-Position: refs/heads/master@{#397987}

Prior to https://codereview.chromium.org/2007103003 StringBuilder had an
optimization that would share the StringImpl when calling append() with
a String the first time. This meant that doing element.textContent on
an Element with a single Text node child wouldn't need to string copy.

The optimization also helps the parser, removing a string copy when
flushing text in the HTML parser (flushPendingText) when there's a
single text that was appended, and the text is a reasonable length
(<= 65536 bytes).

This optimization further helps any code that would potentially append
an AtomicString to a StringBuilder and then do toAtomicString()
or toString() by ensuring we return the same AtomicString again
avoiding a bunch of work, and allowing the atomic string optimization
to propagate to the result.

This patch restores the StringBuilder optimization by adding a
StringImpl* member to StringView and allowing toString() and
toAtomicString() to return that member when the offset is zero and the
length is the same as the input string.

This patch also collapses the m_is8Bit flag into the m_impl by just
reusing the field to know if the StringView is 8bit. We now store the
shared empty 8bit or 16bit strings in the impl field for views created
from sources that are not backed by StringImpl. Doing this keeps the
StringView class to be only 2 ptrs and an unsigned wide.

I also further simplified the code by using the union members directly
and by adding a void* bytes() getter to StringImpl which removed the
branch on is8Bit for the common case of constructing a StringView from
a String or StringImpl with no offset, and the full length.

BUG=615174

Review-Url: https://codereview.chromium.org/2033293002
Cr-Commit-Position: refs/heads/master@{#397986}

Made ElementStyleResources store const CSSSVGDocumentValues in
m_pendingSVGDocuments, meaning that addPendingSVGDocument() can take a
const CSSSVGDocumentValue* instead of a regular pointer. This was
required so that FilterOperationResolver::createFilterOperations() can
use the non-const call to CSSValueList::item().

This also involved making CSSSVGDocumentValue::load() a const method and
marking CSSSVGDocumentValue's cache-related members as mutable.

BUG=526586

Review-Url: https://codereview.chromium.org/2038443003
Cr-Commit-Position: refs/heads/master@{#397985}

This patch attributes the cost of the following functions to individual frames:
- FrameView::updateStyleAndLayoutIfNeededRecursiveInternal
- PageAnimator::serviceScriptedAnimations
- V8ScriptRunner::callFunction

The above attribution is built on a new helper class ScopedFrameBlamer, a
wrapper of a LocalFrame's frame blame context, for automatically calling the
blame context's Enter() and Leave() functions when we enter/exit a scope.

Design doc: https://docs.google.com/document/d/15BB-suCb9j-nFt55yCFJBJCGzLg2qUm3WaSOPb8APtI/edit?usp=sharing

BUG=546021

Review-Url: https://codereview.chromium.org/2028523002
Cr-Commit-Position: refs/heads/master@{#397984}

This makes the micro benchmarks (PerformanceTests/Events/) slightly faster.

BUG=531990,617113

Review-Url: https://codereview.chromium.org/2034413002
Cr-Commit-Position: refs/heads/master@{#397983}

There were a few test steps running only on the Win8 Aura
bot, which was the original GN bot. This CL makes sure
they run on the main Windows x86 and x64 bots now that
they are also using GN.

This CL also takes win8_chromium_ng out of the CQ since
it's now redundant.

R=brucedawson@chromium.org, msw@chromium.org
BUG=605318

Review-Url: https://codereview.chromium.org/2032613004
Cr-Commit-Position: refs/heads/master@{#397982}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b94ab6fc..b32933fb

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2035353002
Cr-Commit-Position: refs/heads/master@{#397981}

BUG=604282

Review-Url: https://codereview.chromium.org/2039713004
Cr-Commit-Position: refs/heads/master@{#397980}

Reduced the callers to the non-const version of CSSValueList::item().
All non-trivial callsites were changed to use the const version of the
item() method. This is pre-work to remove the non-const version
altogether.

Remaining callsites either require CSSValueList::append() to take a
const pointer (which would require CSSValueList to actually store
Member<const CSSValue>s), or require some other cascading const change.

NOTE: This patch also involved making CSSFontFaceSrcValue::fetch() a
const method, and making the cached member m_fetched mutable.

BUG=526586

Review-Url: https://codereview.chromium.org/2036943002
Cr-Commit-Position: refs/heads/master@{#397979}