GitLab

This reverts commit 0d2550b1.

Reason for revert: Fixed NetworkContextConfigurationFilePacBrowserTest

Original change's description:
> Revert "Get NetworkChangeNotifier working on ChromeOS with network service."
>
> This reverts commit 7b0677dd.
>
> Reason for revert: findit says this broke something. I'll revert and see if it's right tomorrow.
>
> Original change's description:
> > Get NetworkChangeNotifier working on ChromeOS with network service.
> >
> > The current NetworkChangeNotifierChromeOS implementation won't work
> > with the network service enabled because it listens for network changes
> > from Shill, which only supports a single client. The browser process
> > has other dependencies on Shill, so it has to be the client for the time
> > being, meaning the network service can't directly listen for network
> > changes and has to be notified of them from the browser process.
> >
> > This CL splits the NetworkChangeNotifierChromeOS into two parts;
> > the first will live in the browser process and listen to Shill, while
> > the second is the actual NetworkChangeNotifierChromeOS implementation
> > which will have an instance in both the browser and network processes.
> > Since NetworkChangeNotifierChromeOS can't actually listen for network
> > changes itself, it just gets notified of changes from part 1 via a new
> > method in NetworkChangeManager. When the thing listening to Shill sees
> > a network change, it notifies its local NetworkChangeNotifierChromeOS
> > instance, and calls the new NetworkChangeManager method, the
> > implementation of which then notifies the network service's
> > NetworkChangeNotifierChromeOS instance.
> >
> > Bug: 882610
> > Cq-Include-Trybots: luci.chromium.try:linux_mojo
> > Change-Id: Ib220575fbe42f026b1e5cb90d3bb6be9d0345414
> > Reviewed-on: https://chromium-review.googlesource.com/c/1274445
> > Reviewed-by: Paul Jensen <pauljensen@chromium.org>
> > Reviewed-by: Will Harris <wfh@chromium.org>
> > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#606665}
>
> TBR=stevenjb@chromium.org,jam@chromium.org,pauljensen@chromium.org,wfh@chromium.org,rmcelrath@chromium.org
>
> Change-Id: I1fa2bcabe73082e02e59f7c613d08aec4ac94e57
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 882610
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Reviewed-on: https://chromium-review.googlesource.com/c/1328701
> Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606745}

TBR=stevenjb@chromium.org,jam@chromium.org,pauljensen@chromium.org,wfh@chromium.org,rmcelrath@chromium.org

Change-Id: Ied0722203a1fa29aa3420bb84c70dee15d47fbb6
Bug: 882610
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/c/1329897Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607351}

Previously it uses strip_k_prefix = False in update script but
strip_k_prefix = True in the presubmit checker. This CL fixes
this bug.

Change-Id: Ibd710b55c1f21ee944840a7dec2996cd20ef87a2
Reviewed-on: https://chromium-review.googlesource.com/c/1331634
Commit-Queue: Luna Lu <loonybear@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607350}

This feature is guarded by --chromium_flag_http2_varint_decode_64_bits.

Before this change, HpackVarintDecoder only decoded integers up to 2^28
+ 2^prefix_length - 2, where prefix_length is between 3 and 7.  Trying
to decode larger integers resulted in an error.  After this change,
HpackVarintDecoder decodes any integer that can be represented on 64
bits (unsigned).  Any input that HpackVarintDecoder decoded before this
change is still decoded.

Decoded integers are used to address entries in the static and dynamic
tables, to specify string lengths, and to update the size limit of the
dynamic table, both in HTTP/2 and in QUIC.  For all of these values
there is already a limit in place that is much lower than 2^28
(otherwise a malicious client could waste hundreds of megabytes of
server memory; and if there is no such limit in place, then we already
have a problem), so making the decoder decode larger values should not
change behavior at higher levels.

To merge this feature, this change also adds an HTTP/2 platform API for
flags,  maintaining parity with SPDY and QUIC (and keeping the
separation between SPDY and HTTP/2 for ease of merging to Chromium).
This change then uses this platform API in the related files referencing
the feature flag and adds a presubmit check.

This change borrows heavily from the pre-existing SPDY and QUIC platform
API for flags.

This CL lands server changes 216463549 and 221087569 by bnc, and
218390247 by diannahu.

BUG=488484

Change-Id: Ie0788f117aba9c6d41fc31148e28c9b49e122602
Reviewed-on: https://chromium-review.googlesource.com/c/1310613Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Dianna Hu <diannahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607349}

Ctrl+Shift+K to toggle. Exists behind --enable-viz-hit-test-debug flag.
Debug quads are drawn around every hit-test region (in HitTestAggregator), cycling through cyan,
green, and magenta depending on depth. Quads will tinted if kHitTestAsk flag is set.

LayerTreeDebugState is used to store hit-test debug information, which is then added as a
HitTestRegionFlags.

Example: https://screenshot.googleplex.com/rO5xGuTYdHf

R=riajiang@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I13efbb7f6d520f85c2b00711bb708a7f9338baea
Reviewed-on: https://chromium-review.googlesource.com/c/1240508Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Ria Jiang <riajiang@chromium.org>
Commit-Queue: Alexander Shah <zandershah@google.com>
Cr-Commit-Position: refs/heads/master@{#607348}

As part of this change, also update the IndexedDBKey
constructors to support std::move().

Bug: 902498
Bug: 717812
Change-Id: Ifd94d01a525850c6293fbfaf28624d3614a419a6
Reviewed-on: https://chromium-review.googlesource.com/c/1321164
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607347}

R=cmasso@chromium.org

Change-Id: I8c49b9e68258ae2b9a21b1f17b4fbc9717180be8
Reviewed-on: https://chromium-review.googlesource.com/c/1332251Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607346}

This CL adds logging for the following histograms at tab switcher open
time:
  - Tabs.Tasks.TabCreated.Count.FromManuallyCreated
  - Tabs.Tasks.TabCreated.Count.FromTargetBlank
  - Tabs.Tasks.TabCreated.Count.FromExternalApp
  - Tabs.Tasks.TabCreated.Count.FromOthers

  - Tabs.Tasks.TabCreated.Percent.FromManuallyCreated
  - Tabs.Tasks.TabCreated.Percent.FromTargetBlank
  - Tabs.Tasks.TabCreated.Percent.FromExternalApp
  - Tabs.Tasks.TabCreated.Percent.FromOthers

Bug: 890502
Change-Id: I2fa8d8e20596c43057f172a65683ba1b1860a63c
Reviewed-on: https://chromium-review.googlesource.com/c/1313550
Commit-Queue: Mei Liang <meiliang@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607345}

With servicification, NQE (Network Quality Estimator) prefs manager
can be used on a single thread. This CL makes NQE prefs manager
a single threaded class by combining methods that were previously
executed over separate threads.

Change-Id: Ic332bfeecc77f7d3401cd63ce1126f954fbbefc8
Bug: 878844
TBR: ryansturm@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1331178
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607344}

Race condition is caused by RenderProcessHost::Shutdown recreating the
sync IPC channel and asynchronously causing SyncContext::OnChannelOpened
to be called on the IO thread.

In the interim the RPH has been deleted, causing the WaitableEvent that
was passed to the SyncContext to be destroyed before it is used.

Because we never intend to use the WaitableEvent to signal shutdown in
WebView, it's simplest to just pass null for the shutdown_event,
indicating that the caller never intends to signal shutdown.

Bug: 904043,865062
Change-Id: I69a51adc78a0f1c0d6f84fbb7206fc9d58e69ed2
Reviewed-on: https://chromium-review.googlesource.com/c/1329670
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607343}

This function needs to match the actual sizing we use. But, since
this is the cross-axis size, we use fit-content:
https://drafts.csswg.org/css-flexbox/#algo-cross-item

See LayoutBox::SizesLogicalWidthToFitContent and LayoutBox::ComputeLogicalWidthUsing
for where we do that fit-content sizing; this code makes us
match the ComputeLogicalWidthUsing calculation.

This bug is currently somewhat hard to trigger because it requires
a combination of all of:
- flex-wrap: wrap
- flex-direction: column
- More than one flex line
- Not using align-items: flex-start or align-content: flex-start
- No explicit width on the flex item
- The max-content width needs to be larger than the width of flexbox

The reason this does not matter in other cases is because we only use
this function to set FlexLine::cross_axis_extent, which we overwrite in
AlignFlexLines if we only have one line. And if we do have more than
one line, we only use this value for aligning items and lines, so
it only matters if we don't use flex-start alignment.

This bug will be much easier to trigger once bug 599828 is fixed (there
are at least two real-world sites that are affected by this once
that bug is fixed)

Bug: 876749
Change-Id: I673026bedfaf0e4c4a25830ef686b200ec8f54a1
Reviewed-on: https://chromium-review.googlesource.com/c/1327746
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607342}

Revert two CL's that added support for loading *.svgz resources
via the file scheme in the network service due to increased
memory use.

Original change's description:
> Chrome supports loading gzipped SVG files from the file scheme
> which was unsupported with the network service implementation.
>
> Note: The non-network service implementation of *.svgz loading
> is currently broken on Linux, but works on Windows and macOS.
> This change works on both platforms.
>
> Bug: 857117
> Change-Id: Id90deba4761ea67d4ac7bef681051ea9326e113b
> Reviewed-on: https://chromium-review.googlesource.com/c/1268960
> Commit-Queue: Chris Mumford <cmumford@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605136}

Also reverted a second CL containing a speculative fix:
> Fix memory performance regression in file:///*.svgz filter.
>
> A speculative fix for a 7%-19.2% regression of memory use. This
> change releases the ZLib buffers used for Gzip inflation - releasing
> the memory as soon as it is no longer needed instead of waiting for
> the URLResponseBodyConsumer instance to be deleted.
>
> This change also fixes an incorrect reset of |zlib_wrapper_|, which
> was calling release() instead of reset(), when zlib would fail to
> initialize. This was likely a latent bug and not the cause of
> the regression.
>
> Bug: 901891
> Change-Id: I52687f5614b7a76c52f4b9d5317deb33a299e4cb
> Reviewed-on: https://chromium-review.googlesource.com/c/1317922
> Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> Commit-Queue: Chris Mumford <cmumford@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#607124}

TBRing mmenke@ - main reviewer of initial CL.

Note: These two CL's reverted cleanly with no conflicts.

TBR=mmenke@chromium.org

Bug: 901891
Change-Id: I700b994797c4c2ac10ffef74f5c449cb5dfc0da8
Reviewed-on: https://chromium-review.googlesource.com/c/1331610Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607341}

Adds support for using render tests for VR UI through
VR's ability to dump the frame buffer to disk.

We can't use the standard approach of passing
RenderTestRule a View to render since most of the VR UI
is rendered natively using Skia. Instead, we refactor
RenderTestRule slightly to support taking either a
View or a Bitmap, then pass it the Bitmap of the
frame buffer dump.

Bug: 904012

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Icebfff58cea4ac8ab29fb4dbadc715d729729eda
Reviewed-on: https://chromium-review.googlesource.com/c/1241471Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607340}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/59d560e4e67d..b6521150ae99


Created with:
  gclient setdep -r src-internal@b6521150ae99

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I4f3f17a9a9cb5ad469904c3bfd8b2ac8a95bfeba
Reviewed-on: https://chromium-review.googlesource.com/c/1331576Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607339}

Non CRWNativeContent NTP pages do not load instantly, and instead
load similarly to web view page loads.  Add logic to wait for the
webState to finish loading and the NTP animation to complete.

Bug: 783192
Change-Id: If3d47e7467c2831697ae8baf9fd8f6755aa535af
Reviewed-on: https://chromium-review.googlesource.com/c/1324229Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607338}

Add local files as one of the options in the sources dropdown. When it
is selected, a file picker dialog is opened via MediaRouterViewsUI. After
selecting a file, the user can select a sink to start casting.

The dialog has a functionality to close itself on blur, which will be
disabled while a file picker is open, and when the file is opened in a
new tab, to prevent the dialog from closing at those moments.

Bug: 842787
Change-Id: I3e9ebf0b1958c026f418111feb792a9d94fce533
Reviewed-on: https://chromium-review.googlesource.com/c/1299657
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607337}

In our previous CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1066630
We make an element containing block and enable its stacking context when
this element has transform animation with forwards or both fill-mode.
This change is breaking the stacking context behavior where inbox
depends on.

This CL keeps the containing block behavior but reverts the stacking
context. Unit tests are updated.

Bug: 899759
Change-Id: I1f519c3383df9a89bcd0c2ec9f15e1c9b8ca1dc0
Reviewed-on: https://chromium-review.googlesource.com/c/1330282Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607336}

This allows P2PQuicTransportConfig to be constructed on the main
thread and passed to the WebRTC worker thread where the
P2PQuicTransport is constructed.

This reduces the amount of boilerplate code needed to construct the
object in a cross-threaded manner as more parameters are added to
the config.

Bug: 874296
Change-Id: I3ae2f09b1c53e7b12f804c2c526d3dad29b323ff
Reviewed-on: https://chromium-review.googlesource.com/c/1330845
Commit-Queue: Steve Anton <steveanton@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607335}

https://chromium.googlesource.com/catapult.git/+log/d1eeca86af6e..0cf6ee7f1acb


git log d1eeca86af6e..0cf6ee7f1acb --date=short --no-merges --format='%ad %ae %s'
2018-11-12 sergiyb@chromium.org Remove ensure_logs_on_timeout flag


Created with:
  gclient setdep -r src/third_party/catapult@0cf6ee7f1acb

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:899721
TBR=sullivan@chromium.org

Change-Id: I0871d6194c30a3642d746b76f00855628a45c000
Reviewed-on: https://chromium-review.googlesource.com/c/1331580Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607334}

The folder name becomes invisible because parent view's layer is set not
drawn [1]. This CL sets folder header view's own layer to fix the issue.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1302413

Bug: 902920
Change-Id: Ib32d3c55d8e044693f81e8bfae7547b989c1c80d
Reviewed-on: https://chromium-review.googlesource.com/c/1330762Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607333}

When starting Chrome under the Winlogon desktop, run the gpu process
in an alternate desktop instead of the winlogon desktop since the
low integrity gpu process does not have access to the winlogon
desktop. This fix allows the GCPW to run chrome on the Windows logon
screen.

Bug: 898754
Change-Id: I8a1b6d3056377b5012fa3916289da02b86b70468
Reviewed-on: https://chromium-review.googlesource.com/c/1312307Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Tien Mai <tienmai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607332}

Image models are not 1:1 with content settings. This CL replaces
per-tab storage from TSCS to a new per-WebContents container,
ContentSettingImageModelState, which contains information that
is 1:1 with image models.

This allows us to remove custom logic for image models that aren't
backed by a single content setting.

The new behavior works like this:
 1. Per-tab state is stored in ContentSettingImageModelState
 2. ShouldRunAnimation / SetAnimationHasRun updates the state
 3. State is additionally updated when an image is hidden

(3) entails a bunch of changes to UpdateFromWebContents, namely,
making it return a boolean for whether the update triggered visibility.

The benefit of this CL is that all of the logic to control animation of
image models come from ContentSettingImageModel.

This CL has no intended user-facing behavior change.

Bug: 900645
Change-Id: I99c36a8184a0e04e6356e58fbc93a5aed3f03127
Reviewed-on: https://chromium-review.googlesource.com/c/1310674Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607331}

When using vulkan, there is no per-frame Present() call to the window's
scenic session. We need to make sure to call present after a size update
to commit the new size.

Bug: 861853
Test: run_content_shell --ozone-platform=scenic --disable-gpu --enable-vulkan
Change-Id: I7d2788ae6ff641908a10a02d837bea223af6a1ca
Reviewed-on: https://chromium-review.googlesource.com/c/1330291
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607330}

The feature has long since been stable (since M64) and doesn't seem
to be a need for this flag.

BUG=788936

Change-Id: I666390b869289c328acb4a2daa5bf4154e1702c0
Reviewed-on: https://chromium-review.googlesource.com/c/1324143Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607329}

Currently, the render process sends the statistics of
only the anchor elements that are in the viewport to
the browser. This CL changes it to also include the
anchor elements whose target URL is one digit different
from the document URL.

Note that there is still a limit of 40 on the count of anchor
elements that are sent from the render to the browser process.

Change-Id: I4083e3605095a44700cc2178615713ede6e0dde2
Bug: 850624
TBR: ryansturm@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1329848
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607328}

Previously we were incorrectly attempting to use the "host" portion of
the URI, rather than treating the whole "content" as the app-Id.

Bug: 893229
Change-Id: I5c95a828a28834449292b1cfec70a9974f3efef4
Reviewed-on: https://chromium-review.googlesource.com/c/1331169
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607327}

This CL:
https://chromium.googlesource.com/chromium/src/+/e9d6060f509e6a7b3a4f0bd944b1303a783f4a94
fixed an issue where suggestions were triggered on URL de-focus,
but it broke zero suggest because we trigger zero suggest on
focus before the animation completes.

To address this, this introduces a tri-state of allowed
suggestion visibility.  When focusing, we can request suggestions
but they won't be shown until the animation is complete.

When de-focusing, we disallow any suggestions being shown.

BUG=904367

Change-Id: I0a1b166158bc08bcc1f8d94b4fe15c6f4e663b02
Reviewed-on: https://chromium-review.googlesource.com/c/1331574Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607326}

As of 10.14, the API that SendGlobalKeyEventsAndWait() uses to post global
events causes a user prompt to appear, which is an obvious non-starter in test
scenarios, so disable that test for now, and add a DCHECK in
SendGlobalKeyEventsAndWait() to ensure that it is not called on 10.14.

Bug: 892177,904403
Change-Id: Ida0429d7e9914942f354690ecb657803240756ae
Reviewed-on: https://chromium-review.googlesource.com/c/1331135Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607325}

Bug: 632514
Change-Id: Ie05f723119aca8611fd46ff3466d5b292004e104
Reviewed-on: https://chromium-review.googlesource.com/c/1329863
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607324}

https://android.googlesource.com/platform/external/perfetto.git/+log/d608c792b594..ff9427fb8a90


git log d608c792b594..ff9427fb8a90 --date=short --no-merges --format='%ad %ae %s'
2018-11-12 lalitm@google.com Merge "trace_processor: prevent window table from allowing zero duration tables"
2018-11-12 hjd@google.com Merge "perfetto-ui: Avoid setting window_dur to 0ns"


Created with:
  gclient setdep -r src/third_party/perfetto@ff9427fb8a90

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: If4c516056c567dd08800de39982f9df1aea3a2b2
Reviewed-on: https://chromium-review.googlesource.com/c/1331608Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607323}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Id11e90f4422b220f4c9a8806249fd9d526ddd48c
Reviewed-on: https://chromium-review.googlesource.com/c/1331572
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607322}

When enabling printing, we re-attach the layout objects, and so we
need to update the various layout object variables before accessing them.

R=ikilpatrick@chromium.org

Change-Id: I770621242d5c29762081a25b2699ffb46320597c
Reviewed-on: https://chromium-review.googlesource.com/c/1331607
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607321}

This way telemetry only includes the time from ash, not the initial hop
from browser to ash.

BUG=759163
TEST=none

Change-Id: I65f514d6bee3346a7b828b431300e5cf3277d521
Reviewed-on: https://chromium-review.googlesource.com/c/1327416Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607320}

This reverts commit f6b72e6c.

Reason for revert: Still causing https://crbug.com/903402

Original change's description:
> Reland: Marks the document object as busy while it is still loading
> 
> Changes in the reland compared to the original patch:
> Switched to using GetRoot instead of Root() which might prevent the use of an uninitialized root object.
> 
> Original description:
> Screen readers want to have a reliable way to know whether a document is still loading so as to ignore events coming from it.
> The current change can be made irrespective to whether we will mark the document as loaded when HTML parsing has started or when the "interactive" readyState has been entered.
> 
> R=​dmazzoni@chromium.org, aleventhal@chromium.org
> 
> Bug: 897177, 903402
> Change-Id: I681883999918ffdd32fc11d2f691b659c7e91149
> Reviewed-on: https://chromium-review.googlesource.com/c/1327745
> Commit-Queue: Nektarios Paisios <nektar@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#607017}

TBR=dmazzoni@chromium.org,nektar@chromium.org,aleventhal@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 897177, 903402
Change-Id: I18b4bae20db26dc26934abb08e97df0b8a151465
Reviewed-on: https://chromium-review.googlesource.com/c/1331145Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607319}

Bug: b:118193766
Test: Manual

Change-Id: Ia0cd58e42761b35b9f7281344266505074d59936
Reviewed-on: https://chromium-review.googlesource.com/c/1321956
Commit-Queue: Yilei Li <yileili@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607318}

The Play Store page contains many WebP images (lossy for movie covers and lossless for Google-created vector art), which is an image rendering category that is currently not well covered.

Bug: 878390
Change-Id: I7298c3e077497e40506a1f6528318a80e5df0221
Reviewed-on: https://chromium-review.googlesource.com/c/1309115
Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607317}

Instead of skipping to the new load-progress value as it arrives,
interpolate to it. This results in a smoother animation as the
load-progress callbacks can be fairly sparse (and jump from 20% to 80%
for instance).

Drives animations off of the same timer that is used for the throbbing
state. This will hopefully address a performance regression as the
throbbing timer, progress fade-out animation and favicon fade-in
animation were all scheduling separate high-frequency repainting of the
tab icon.

Bug: chromium:903827, chromium:903147, chromium:902475, chromium:901751

progress

Change-Id: Iad2a24d94206d5871a5cacc5e56d072161407940
Reviewed-on: https://chromium-review.googlesource.com/c/1330345
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607316}

https://chromium.googlesource.com/angle/angle.git/+log/48f63f90f6f3..03d1a5ed6cc8


git log 48f63f90f6f3..03d1a5ed6cc8 --date=short --no-merges --format='%ad %ae %s'
2018-11-12 jmadill@chromium.org Vulkan: Use global buffer barriers.


Created with:
  gclient setdep -r src/third_party/angle@03d1a5ed6cc8

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I58fdbdc51db4c3b24e0b8554d699607cba25de57
Reviewed-on: https://chromium-review.googlesource.com/c/1331570Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607315}

This is necessary in order to be able to call FIDL interfaces from the
GPU thread.

Bug: 861853
Test: run_content_shell --ozone-platform=scenic --disable-gpu --enable-vulkan

Change-Id: I1f7b0f2957a810745a83ce1cf36327467e6ea448

Reviewed-on: https://chromium-review.googlesource.com/c/1330290
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607314}

TBR=martiniss@chromium.org

Bug: 790286,790294,790309
Change-Id: I507b1c98aa2aca9e723db051cc59c0b51ebfb5ad
Reviewed-on: https://chromium-review.googlesource.com/c/1331614Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607313}

Plan-B is deprecated, but some non-trivial work is needed to update to
Unified Plan. Specifying Plan-B explicitly will keep things working
when WebRTC changes the default to Unified Plan.

Bug: 903012
Change-Id: I3afc86c87f79af068f93af384cc20229293be5c5
Reviewed-on: https://chromium-review.googlesource.com/c/1327546Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607312}