- 14 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bab55653bc83..1c834ea5451c git log bab55653bc83..1c834ea5451c --date=short --no-merges --format='%ad %ae %s' 2019-10-14 vapier@chromium.org build_dlc: read/write files as bytes 2019-10-14 vapier@chromium.org paygen_payload_lib: fix bytes/string handling in RunGeneratorCmd 2019-10-14 vapier@chromium.org paygen: download_cache: fix bytes & string handling Created with: gclient setdep -r src/third_party/chromite@1c834ea5451c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic6d6c2d7105794450437bb15006513bfdd76f55b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858960Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705513}
-
Jan Krcal authored
This CL extends two flags, animated-avatar-button and enable-history-favicons-google-server-query till M79. Bug: 967317 Change-Id: Ieb4c9b96bfd000a88e63490694b438d7c0cfcad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859614 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#705512}
-
Marc Treib authored
Since this is a histogram enum, the entries are commented out but left around, for historical purposes and to reduce the chances of reuse. Bug: 1012648, 1007293 Change-Id: Ic931270a50908e4977e2ca2fd7f6851fab3dcfed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852253 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#705511}
-
Julie Jeongeun Kim authored
This CL converts ProxyLookupClient from proxy_lookup_client.mojom to new Mojo types using PendingRemote, Receiver, and Remote. Bug: 955171 Change-Id: I1765ac683cc567bb2a5d7d31dc3b983ec2a18741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852527Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#705510}
-
Noel Gordon authored
The CSS switches on attribute {volume,root}-type-icon, but in practice there is no real system need for the distinction. Bug: 992819 Change-Id: Ieca58e2ce1e4bc211c2aea342b73e9f8f467549a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859415Reviewed-by:Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#705509}
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert last uses of base::Bind/base::Callback in components/prefs to the recommended methods/types. Bug: 1007719 Change-Id: I50ed50f2a419ef4b7afcc65756e8a4a0c08a8933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844784 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#705508}
-
Niels Möller authored
Bug: webrtc:8504,842613 Change-Id: I56f348087fdd5acb37c90cfe649d72890d985ba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857327Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Niels Möller <nisse@chromium.org> Cr-Commit-Position: refs/heads/master@{#705507}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/74897164..a2a523eb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I46d738030f0223aa83a9fb38e2942b068f1a91f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858573Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705506}
-
Kuo Jen Wei authored
Bug: None Test: Verify the switch device button is not shown on both photo/video intent reviewing page. Change-Id: I1575f4775690f12b4d28405f51226c877bab96a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859318 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#705505}
-
Marian Fechete authored
This CL splits the current AutofillAction into UseAddressAction and UseCreditCardAction. Also splitting the unit tests. Also fixing a small issue in client memory when checking has_selected_address for an address key that exists but the contents are a nullptr. Pending a next CL: refactor the fallback and required fields to share the logic. Right now after the split, the code will be temporarily duplicated. Bug: b/141362833 Change-Id: I34fae5e1234695e679e571ea0e888c2b0e6230bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855960 Commit-Queue: Marian Fechete <marianfe@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#705504}
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert all uses of base::Bind/base::Callback in services/video_capture to the recommended methods/types. Bug: 1007831 Change-Id: I51a9f07a0d3e88a07968739325a86440ce22f07b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837811 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#705503}
-
Andreas Haas authored
This CL removes another use of WTF::ArrayBuffer that is unrelated with JavaScript ArrayBuffers. We want to replace all uses of WTF::ArrayBuffer which are unrelated to JavaScript ArrayBuffers to be able to refactor the memory management of ArrayBuffer backing stores. Even though the original code used ArrayBuffer::CreateOrNull, the callers of CopyImageData did not handle the "Null" case. Therefore I just replaced the WTF::ArrayBuffer with WTF::Vector. R=jbroman@chromium.org, haraken@chromium.org Bug: chromium:1008840 Change-Id: I03980eb402f943159465f13a5ea8b784c83f79ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844956 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#705502}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/dd6f66826702..0ec6fc5eab5d git log dd6f66826702..0ec6fc5eab5d --date=short --no-merges --format='%ad %ae %s' 2019-10-14 machenbach@chromium.org Fix supporting OAuth in /add_point API Created with: gclient setdep -r src/third_party/catapult@0ec6fc5eab5d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: None Change-Id: I24f66ac48d653b004296b0920fcb16755d4f45ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858923Reviewed-by:
-
Christian Dullweber authored
We use these metrics to measure usage of major privacy features and to detect and debug performance regressions. Change-Id: Ida2b318a6adeb6f195fb79e443381f4ac3e4d2dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856159Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#705500}
-
Robbie Gibson authored
Before, the Voice Control name for these cells would be all the text in the cell: - URL cell: Both the title (bookmark name, website name, etc.) and the url itself. - Image cell/account cell: Both the title and detail text. This is confusing and contributes to name clutter on the Voice Control "Show Names" screen. Just the title is a much better name. Bug: 1004319 Change-Id: I179747b0162a1a1cf8102df786167d9846836592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856162 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#705499}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dbb94e26f650..1eefb86e4912 git log dbb94e26f650..1eefb86e4912 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 treehugger-gerrit@google.com Merge "processor: Simplify InternedData tracking and support generations" Created with: gclient setdep -r src/third_party/perfetto@1eefb86e4912 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I51e5c036d67446867eee0df3dcc3f4c4e3b92167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858925Reviewed-by:
-
Huanzhong Huang authored
Cookie controls UI should be hidden when (the original) third-party cookie blocking is policy-managed or turned on. Bug: 1012684, 967668 Change-Id: I2657454ed4c71f221708247e197c0de57b3db3fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849681Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#705497}
-
Juan Antonio Navarro Pérez authored
This reverts commit 7ccedbae. Reason for revert: IndexedDBExecution* tests Original change's description: > [PM] Notify content::LockObserver of active IndexedDB connections. > > With this CL, content::LockObserver is notified when the number of > IndexedDB connections (active or pending) in a frame switches between > zero and non-zero. The information is plumbed to the Performance Manager > which uses it to avoid freezing pages with IndexedDB connections. This > is because freezing a page with active IndexedDB connections can > prevent other pages from performing IndexedDB operations. In the > future, we would like to get more granular information about when it is > really problematic to freeze a frame because of its current usage of > IndexedDB, but this is a good first step to allow shipping page > freezing without breaking usage of IndexedDB. > > More details at > https://docs.google.com/document/d/1CUE1pfS5pGhJt6X0EKwv2sQYP5PcdzyGZKKtdBYzEOw/edit?usp=sharing > > Bug: 980533 > Change-Id: Ifbb0d0ea66ab4b6f522ffa4824af7a2fea16ccaf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848794 > Commit-Queue: François Doray <fdoray@chromium.org> > Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705396} TBR=kinuko@chromium.org,dmurph@chromium.org,fdoray@chromium.org,siggi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 980533 Bug: 1014015 Change-Id: I7e1bbb450617dcd80e11b10e05d46634183065e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856969Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#705496}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/eba98c4eb781..2276e59788ea git log eba98c4eb781..2276e59788ea --date=short --no-merges --format='%ad %ae %s' 2019-10-11 alanbaker@google.com Validate that selections are structured (#2962) 2019-10-11 afdx@google.com spirv-fuzz: Rework id descriptors (#2959) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@2276e59788ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,jmadill@google.com Bug: None Change-Id: I4982ef466e970f4b61b9e3d842eeb28dec14d8c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858920Reviewed-by:
-
Richard Knoll authored
The ClickToCall icon in the omnibox is attached to the IntentPickerBubbleView on ChromeOS. We need to check that the bubble is actually intended for ClickToCall though and only do that for ClickToCall and not other sharing features. Bug: 1013112 Change-Id: Id6d8b84f5e69189748b620b64cacc34453876501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852247Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#705494}
-
Ricky Liang authored
On Chrome OS we have a 3 seconds timeout for UI shutdown. If Chrome fails to stop itself in 3 seconds when the ui.conf job requests it, a fail safe mechanims would kill the Chrome processes with SIGABRT. If we happen to be in the middle of updating the camera info through Mojo IPC, the 3 seconds Mojo IPC timeout would cause ui.conf to kill Chrome with SIGABRT. Bug: 940623 Change-Id: I96e75b9af1dc2060a305a8835a2352683414d6b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858024Reviewed-by:
-
Richard Knoll authored
Follow-up CL with some cleanup after crrev.com/c/1789149. Bug: None Change-Id: I0301aba1e20df1fdc8681e8008e86e37ac703517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852425Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#705492}
-
David Roger authored
TBR=updowndota Bug: 1013824 Change-Id: Ibbeb425fe2511f0dadaa93bb4dd3cbfde476877b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857130Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#705491}
-
Thomas Tangl authored
Bug: 995720 Change-Id: Ie4dd2cfe80494c54281f9174a797efdf39dcd136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857119Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/91eb1bdd8b07..bab55653bc83 git log 91eb1bdd8b07..bab55653bc83 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 vapier@chromium.org vm: minor fixes for python 3 Created with: gclient setdep -r src/third_party/chromite@bab55653bc83 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ie14ca8c9018fc197181e8950e2ee18e6d1b9c891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858922Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I0e0d7b9f4745c2f7efa510fcffa15293ec62ee16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858921Reviewed-by:
-
Balazs Engedy authored
TemplateURLService::GetDefaultSearchProvider() will return nullptr when the `DefaultSearchProviderEnabled` policy is set to `false`. SearchGeolocationDisclosureTabHelper::MaybeShowDisclosureForValidUrl() can, however, assume that the return value of GetDefaultSearchProvider() will be non-null, because the former method will only ever be called if a DSE is enabled. Document this in the code in the form of a DCHECK. Bug: 1011910 Change-Id: Ie8763e9b0e6e030347eb956125aeea7e25e17458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855819 Auto-Submit: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#705487}
-
Raphael Kubo da Costa authored
There have been some concerns regarding the precision of readouts from the Ambient Light Sensor. To decrease the entropy, we are rounding off the illuminance value to the nearest 50 Lux to mitigate the known attack vectors as summarized in [1]. [1] https://github.com/w3c/ambient-light/issues/13#issuecomment-302393458 This CL is based on https://chromium-review.googlesource.com/c/chromium/src/+/1695412 by Rijubrata Bhaumik and myself. Bug: 642731, 606766 Change-Id: I85449bdb835e8486b080fc269938b6c96f000c2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834346Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Christian Dullweber authored
Replace illustrations for third-party cookie blocking UI. Remove margin to ensure illustrations span the full width of the dialog. Bug: 967668 Change-Id: Ic2d6d3728e5f0f99f64c516b3f3eadbe974ca6ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850153 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#705485}
-
Fredrik Söderquist authored
Tbr: schenney@chromium.org Bug: 1013736 Change-Id: I360252f5459be10231bf1edf291f45dc46c9f705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857325Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#705484}
-
Henrique Ferreiro authored
Convert all users of the content_capture::mojom::TraitsTestService, gfx::mojom::ImageTraitsTestService, gfx::mojom::RangeTraitsTestService, gfx::mojom::TraitsTestService, gpu::mojom::TraitsTestService, media::mojom::TraitsTestService, sandbox::mac::mojom::TraitsTestService, skia::mojom::TraitsTestService, ui::mojom::IMEStructTraitsTest and ui::mojom::TraitsTestService interfaces. Bug: 955171 Change-Id: I8b324acc51cbd9647ee34beead76f1616ed3965b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841132Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#705483}
-
Anatoliy Potapchuk authored
Since customer kiosks are being deprecated, the only use of kiosks is enterprise, who owns all the bugs related to them. Adding ChromeOS Enterprise TL as an owner. Change-Id: I24ce28317798bd2525438d25d6a90a510598f0e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855743 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#705482}
-
Kalpak Tapas authored
This is a preparatory change for adding accessibility support for PDF annotations. Currently, text, links and images within a PDF page are supported in an accessibility context. These are passed as separate parameters in Set/GetAccessibilityPageInfo methods exposed through the Pepper API. When annotation support comes in, the number of parameters would increase to 6 making those function calls unwieldy and requiring additional extensions to the templated DispatchResourceCall function. This change groups links and images into a new *PageObjects struct which will also be the home for the upcoming representation of PDF annotations. Bug: 1008775 Change-Id: Icee1b9b17290614265be8c65c5b594d3a99fe767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831957Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Kalpak Tapas <katapas@microsoft.com> Cr-Commit-Position: refs/heads/master@{#705481}
-
Luciano Pacheco authored
When the user is resizing the app using the splitter, and the tree has has overflow-y content, a scroll bar appears. That is annoying. Fix by hiding directory scroll bars while the splitter is active. Similar to what was done for directory tree on CL:1851789 Bug: 992821 Change-Id: Ic11d88a943af4a756496e6f18b78910249c87be0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858026 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#705480}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/19a311d0aef7..c34e434df0d7 git log 19a311d0aef7..c34e434df0d7 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 67486ec24551..fede5cb664d9 (12 commits) 2019-10-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 92809357..e034419f (981 commits) Created with: gclient setdep -r src/third_party/skia@c34e434df0d7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: chromium:None,chromium:None Change-Id: Ia697e5bad6db4a74f7994a404fe5c1da5f1a18db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859064Reviewed-by:
-
Christoph Schwering authored
Added a new class AutofillTickClock analogous to AutofillClock. Added a new class TestAutofillTickClock analogous to TestAutofillClock. Replaced usage of base::Time::Now() with AutofillClock::Now(). Replaced usage of base::TimeTicks::Now with AutofillTickClock::NowTicks(). The only exception are autofill_test_utils.h's functions NextYear() etc., which refer to the actual date (e.g., for a test credit card entry). Migration to TaskEnvironment::MOCK_TIME is non-trivial because it doesn't support setting time to an absolute value but only fast-forwarding by some delta. Bug: 1009364 Change-Id: Iabb693b6eb8a6ebe9fa5ef2bb493a90ae8918422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850434Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1550399cc0a1..dd6f66826702 git log 1550399cc0a1..dd6f66826702 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 dberris@chromium.org Revert "Dashboard - Force test metadata to update sheriff on upload" Created with: gclient setdep -r src/third_party/catapult@dd6f66826702 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=crouleau@chromium.org Bug: chromium:1006252,chromium:1013984 Change-Id: I0b7e3253b625b0f9715c3dfcedd31606323ff4a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859063Reviewed-by:
-
Timothy Loh authored
The OnWindowActivated observer method does not guarantee that the |gained_active| argument is non-null, so GuestOsEngagementMetrics should not assume this. This is causing tast tests to fail when the PluginVm feature is enabled, as the matcher used, IsPluginVmWindow(), doesn't null-check the window. ARC is unaffected as IsArcAppWindow() does a null-check. Bug: 990252 Change-Id: I4673e1c9fbbc8142057481d51567be0e5677656d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859417Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#705476}
-
Koji Ishii authored
The discussion at crbug.com/1013040 clarified that the line initial style of |NGInlineBreakToken| is nullptr for [class C breaks]. In that case, it is still fine to compute the line initial style from the containing block. This patch updates the comment and add DCHECK. [class C breaks]: https://www.w3.org/TR/css-break-3/#end-block Bug: 1013040 Change-Id: Ie000ab7c259f91d445a4dca1b510559c5146722f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855548 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#705475}
-
Kuo Jen Wei authored
Fix by correcting the orientation before square cut. Bug: b/141670036 Test: Take photo in square mode with different orientation, verify the orientation of result file is correct. Change-Id: I7350d0846c438e8f6f4af5482ccef3b03df4ee23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857801Reviewed-by:
-
