- 14 Mar, 2011 40 commits
-
-
levin@chromium.org authored
* platform/chromium/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81073 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rniwa@webkit.org authored
Mac pixel rebaselines for r81053. * platform/mac/editing/selection/drag-select-1-expected.checksum: * platform/mac/editing/selection/drag-select-1-expected.png: * platform/mac/editing/selection/fake-drag-expected.checksum: * platform/mac/editing/selection/fake-drag-expected.png: * platform/mac/fast/text/atsui-rtl-override-selection-expected.checksum: * platform/mac/fast/text/atsui-rtl-override-selection-expected.png: * platform/mac/svg/custom/mouse-move-on-svg-container-expected.checksum: * platform/mac/svg/custom/mouse-move-on-svg-container-expected.png: * platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum: * platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png: * platform/mac/svg/custom/mouse-move-on-svg-root-expected.checksum: * platform/mac/svg/custom/mouse-move-on-svg-root-expected.png: * platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum: * platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.png: git-svn-id: svn://svn.chromium.org/blink/trunk@81072 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
ggaren@apple.com authored
Reviewed by Oliver Hunt. Removed more cases of DeprecatedPtr (exception, SmallStrings) https://bugs.webkit.org/show_bug.cgi?id=56332 * runtime/Identifier.cpp: (JSC::Identifier::add): (JSC::Identifier::addSlowCase): Use a variable instead of a hard-coded constant, to make this code less brittle. * runtime/JSGlobalData.h: Use HeapRoot instead of DeprecatedPtr because this reference is owned and managed directly by the heap. * runtime/JSString.cpp: (JSC::JSString::substringFromRope): * runtime/JSString.h: (JSC::jsSingleCharacterString): (JSC::jsSingleCharacterSubstring): (JSC::jsString): (JSC::jsStringWithFinalizer): (JSC::jsSubstring): (JSC::jsOwnedString): Use a variable instead of a hard-coded constant, to make this code less brittle. * runtime/SmallStrings.cpp: (JSC::SmallStringsStorage::rep): (JSC::SmallStringsStorage::SmallStringsStorage): (JSC::SmallStrings::SmallStrings): (JSC::SmallStrings::markChildren): (JSC::SmallStrings::clear): (JSC::SmallStrings::count): Use a variable instead of a hard-coded constant, to make this code less brittle. * runtime/SmallStrings.h: (JSC::SmallStrings::singleCharacterString): Use HeapRoot instead of DeprecatedPtr because these references are owned and managed directly by the heap. Stop using FixedArray because we only want a very limited set of classes to be able to use HeapRoot. (Replaced with manual ASSERTs.) * runtime/WriteBarrier.h: (JSC::operator==): (JSC::WriteBarrier::WriteBarrier): (JSC::HeapRoot::HeapRoot): (JSC::HeapRoot::operator=): Added HeapRoot, which is allowed to set without write barrier because we assume all HeapRoots are scanned during all GC passes. git-svn-id: svn://svn.chromium.org/blink/trunk@81071 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
levin@chromium.org authored
* platform/chromium-win/editing/selection/drag-select-1-expected.checksum: * platform/chromium-win/editing/selection/drag-select-1-expected.png: * platform/chromium-win/editing/selection/drag-select-1-expected.txt: * platform/chromium-win/editing/selection/fake-drag-expected.txt: * platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.checksum: * platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.png: * platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.txt: * platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum: * platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.png: * platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: * platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.checksum: * platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.png: * platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.txt: * platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum: * platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.png: * platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81070 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] Compilation fails with --3d-canvas https://bugs.webkit.org/show_bug.cgi?id=55964 * WebCore.pro: * platform/graphics/qt/Extensions3DQt.cpp: git-svn-id: svn://svn.chromium.org/blink/trunk@81069 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
aroben@apple.com authored
Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to analyze Reviewed by David Kilzer and Joe Pecoraro. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: (#url-prompt): Made this a bit taller to make room for the list of builds. (#recent-builds-loading-indicator): (#recent-builds-list): Added styles for the build list and loading indicator. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: (LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading it. This will unescape it. (LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt. (LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt. (LeaksViewer._displayURLPrompt): Start loading the recent leaky builds. (LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the prompt UI. (LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is now also used when a recent build is clicked. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added. (RecentBuildsLoader): Store the callback. (RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified builder. Find the revision number, leak count, and results URL for each one. Pass the resulting info to our callback. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: (range): Added this helper function to return an array containing the integers [0, n). * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added RecentBuildsLoader.js and added text to the prompt UI to show the recent builds. git-svn-id: svn://svn.chromium.org/blink/trunk@81068 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rniwa@webkit.org authored
git-svn-id: svn://svn.chromium.org/blink/trunk@81067 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rniwa@webkit.org authored
GTK rebaselines or r81053. * platform/gtk/editing/selection/drag-select-1-expected.txt: * platform/gtk/editing/selection/fake-drag-expected.txt: * platform/gtk/editing/selection/inline-closest-leaf-child-expected.txt: * platform/gtk/svg/custom/mouse-move-on-svg-container-expected.txt: * platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: * platform/gtk/svg/custom/mouse-move-on-svg-root-expected.txt: * platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81066 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
bweinstein@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=56331 <rdar://problem/9126635> Reviewed by Adam Roben and Gavin Barraclough. Source/JavaScriptCore: Give StringConcatenate the ability to deal with const UChar*'s as a String type to append. * wtf/text/StringConcatenate.h: Source/WebCore: Move PathWalker from an inline class in WebKit2 to its own class in WebCore, so it can be used from both WebCore and WebKit2. Implement FileSystemWin::listDirectory using PathWalker to populate the Vector of paths matching the passed in pattern. * WebCore.vcproj/WebCore.vcproj: * platform/win/FileSystemWin.cpp: (WebCore::listDirectory): Call through to PathWalker. * platform/win/PathWalker.cpp: Added. (WebCore::PathWalker::PathWalker): Moved from WebKit2. Added a second argument for the pattern to pass to the Windows File APIs. (WebCore::PathWalker::~PathWalker): Moved from WebKit2. (WebCore::PathWalker::isValid): Ditto. (WebCore::PathWalker::data): Ditto. (WebCore::PathWalker::step): Ditto. * platform/win/PathWalker.h: Added. Source/WebKit2: Move PathWalker down into WebCore, and call the PathWalker in WebCore (that now has a second argument, the pattern to take). * UIProcess/Plugins/win/PluginInfoStoreWin.cpp: (WebKit::PluginInfoStore::pluginPathsInDirectory): git-svn-id: svn://svn.chromium.org/blink/trunk@81065 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
levin@chromium.org authored
For r81053, we have editing/selection/drag-select-1.html, editing/selection/fake-drag.html, svg/custom/mouse-move-on-svg-container-standalone.svg, svg/custom/mouse-move-on-svg-container.xhtml, svg/custom/mouse-move-on-svg-root-standalone.svg, svg/custom/mouse-move-on-svg-root.xhtml For r81049, we have fast/table/overflowHidden.html, fast/table/relative-position-containment.html, fast/table/relative-position-offsets.html, fast/table/relative-position-stacking.html * platform/chromium-linux/editing/selection/drag-select-1-expected.checksum: * platform/chromium-linux/editing/selection/drag-select-1-expected.png: * platform/chromium-linux/editing/selection/drag-select-1-expected.txt: Added. * platform/chromium-linux/editing/selection/fake-drag-expected.txt: Added. * platform/chromium-linux/fast/table/relative-position-containment-expected.checksum: Added. * platform/chromium-linux/fast/table/relative-position-containment-expected.png: Added. * platform/chromium-linux/fast/table/relative-position-offsets-expected.checksum: Added. * platform/chromium-linux/fast/table/relative-position-offsets-expected.png: Added. * platform/chromium-linux/fast/table/relative-position-stacking-expected.checksum: Added. * platform/chromium-linux/fast/table/relative-position-stacking-expected.png: Added. * platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.checksum: * platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.png: * platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.txt: Added. * platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum: * platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.png: * platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Added. * platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.checksum: * platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.png: * platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.txt: Added. * platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum: * platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.png: * platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Added. * platform/chromium-win/fast/table/overflowHidden-expected.txt: * platform/chromium-win/fast/table/relative-position-containment-expected.checksum: Added. * platform/chromium-win/fast/table/relative-position-containment-expected.png: Added. * platform/chromium-win/fast/table/relative-position-containment-expected.txt: Added. * platform/chromium-win/fast/table/relative-position-offsets-expected.checksum: Added. * platform/chromium-win/fast/table/relative-position-offsets-expected.png: Added. * platform/chromium-win/fast/table/relative-position-offsets-expected.txt: Added. * platform/chromium-win/fast/table/relative-position-stacking-expected.checksum: Added. * platform/chromium-win/fast/table/relative-position-stacking-expected.png: Added. * platform/chromium-win/fast/table/relative-position-stacking-expected.txt: Added. * platform/chromium/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81064 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rniwa@webkit.org authored
Removed redundant baselines from Windows port so that rebaselines done in r81059 take effect. * platform/win/svg/custom/mouse-move-on-svg-container-expected.txt: Removed. * platform/win/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Removed. * platform/win/svg/custom/mouse-move-on-svg-root-expected.txt: Removed. * platform/win/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Removed. git-svn-id: svn://svn.chromium.org/blink/trunk@81063 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
luiz@webkit.org authored
* platform/mac/fast/html/details-add-summary-1-and-click-expected.txt: Added. * platform/mac/fast/html/details-add-summary-1-expected.txt: Added. * platform/mac/fast/html/details-add-summary-10-and-click-expected.txt: Added. * platform/mac/fast/html/details-add-summary-10-expected.txt: Added. * platform/mac/fast/html/details-add-summary-2-and-click-expected.txt: Added. * platform/mac/fast/html/details-add-summary-2-expected.txt: Added. * platform/mac/fast/html/details-add-summary-3-and-click-expected.txt: Added. * platform/mac/fast/html/details-add-summary-3-expected.txt: Added. * platform/mac/fast/html/details-add-summary-4-and-click-expected.txt: Added. * platform/mac/fast/html/details-add-summary-4-expected.txt: Added. * platform/mac/fast/html/details-add-summary-5-and-click-expected.txt: Added. * platform/mac/fast/html/details-add-summary-5-expected.txt: Added. * platform/mac/fast/html/details-add-summary-6-and-click-expected.txt: Added. * platform/mac/fast/html/details-add-summary-6-expected.txt: Added. * platform/mac/fast/html/details-add-summary-7-and-click-expected.txt: Added. * platform/mac/fast/html/details-add-summary-7-expected.txt: Added. * platform/mac/fast/html/details-add-summary-8-and-click-expected.txt: Added. * platform/mac/fast/html/details-add-summary-8-expected.txt: Added. * platform/mac/fast/html/details-add-summary-9-and-click-expected.txt: Added. * platform/mac/fast/html/details-add-summary-9-expected.txt: Added. * platform/mac/fast/html/details-no-summary1-expected.txt: Added. * platform/mac/fast/html/details-no-summary2-expected.txt: Added. * platform/mac/fast/html/details-no-summary3-expected.txt: Added. * platform/mac/fast/html/details-no-summary4-expected.txt: Added. * platform/mac/fast/html/details-open-javascript-expected.txt: Added. * platform/mac/fast/html/details-open1-expected.txt: Added. * platform/mac/fast/html/details-open2-expected.txt: Added. * platform/mac/fast/html/details-open3-expected.txt: Added. * platform/mac/fast/html/details-open4-expected.txt: Added. * platform/mac/fast/html/details-open5-expected.txt: Added. * platform/mac/fast/html/details-open6-expected.txt: Added. * platform/mac/fast/html/details-position-expected.txt: Added. * platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt: Added. * platform/mac/fast/html/details-remove-summary-1-expected.txt: Added. * platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt: Added. * platform/mac/fast/html/details-remove-summary-2-expected.txt: Added. * platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt: Added. * platform/mac/fast/html/details-remove-summary-3-expected.txt: Added. * platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt: Added. * platform/mac/fast/html/details-remove-summary-4-expected.txt: Added. * platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt: Added. * platform/mac/fast/html/details-remove-summary-5-expected.txt: Added. * platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt: Added. * platform/mac/fast/html/details-remove-summary-6-expected.txt: Added. * platform/mac/fast/html/details-writing-mode-expected.txt: Added. * platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81062 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rniwa@webkit.org authored
Qt rebaselines for r81053. * platform/qt/editing/selection/drag-select-1-expected.txt: * platform/qt/svg/custom/mouse-move-on-svg-container-expected.txt: * platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: * platform/qt/svg/custom/mouse-move-on-svg-root-expected.txt: * platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81061 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
beidson@apple.com authored
Try to fix the EFL build-bustage that their EWS bot did not see, but their core-builder did. (sigh) * ewk/ewk_history.cpp: (ewk_history_item_icon_surface_get): (ewk_history_item_icon_object_add): git-svn-id: svn://svn.chromium.org/blink/trunk@81060 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rniwa@webkit.org authored
Mac rebaselines for r81053. * platform/mac/fast/text/atsui-rtl-override-selection-expected.txt: * platform/mac/svg/custom/mouse-move-on-svg-container-expected.txt: * platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: * platform/mac/svg/custom/mouse-move-on-svg-root-expected.txt: * platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81059 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
beidson@apple.com authored
Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()" Reviewed by Anders Carlsson. ../WebCore: Remove HistoryItem::icon(): * history/HistoryItem.cpp: * history/HistoryItem.h: * WebCore.exp.in: * loader/icon/IconDatabaseBase.h: (WebCore::IconDatabaseBase::defaultIcon): ../WebKit/efl: * ewk/ewk_history.cpp: (ewk_history_item_icon_surface_get): Use IconDatabase directly. ../WebKit/mac: * History/WebHistoryItem.mm: (-[WebHistoryItem icon]): This far-future FIXME is now irrelevant. ../WebKit/qt: * Api/qwebhistory.cpp: (QWebHistoryItem::icon): Use IconDatabase directly. git-svn-id: svn://svn.chromium.org/blink/trunk@81058 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aestes@apple.com authored
Reviewed by Darin Adler. Timer-based events should inherit the user gesture state of their originating event in certain cases. https://bugs.webkit.org/show_bug.cgi?id=55104 * fast/events/popup-blocking-timers-expected.txt: Added. * fast/events/popup-blocking-timers.html: Added. 2011-03-14 Andy Estes <aestes@apple.com> Reviewed by Darin Adler. Timer-based events should inherit the user gesture state of their originating event in certain cases. https://bugs.webkit.org/show_bug.cgi?id=55104 If a timer is installed by a gesture-originated event and will fire within one second, the timer-initiated event should behave as if it were also initiated by a user gesture. Multi-shot timers should only get this behavior on their first execution. Nested timers should not get this behavior. This makes us compatible with Gecko when handling popups and file chooser dialogs created from timer events. Test: fast/events/popup-blocking-timers.html * page/DOMTimer.cpp: (WebCore::timeoutId): Create a helper function so that m_timeoutId can be initialized in the data member initialization list. (WebCore::shouldForwardUserGesture): Ditto, but for m_shouldForwardUserGesture. (WebCore::DOMTimer::DOMTimer): Move initialization of data members from the ctor body to the data member initialization list. Also rename the argument 'timeout' to 'interval'. (WebCore::DOMTimer::fired): Create a UserGestureIndicator and set its state based on the value of m_shouldForwardUserGesture. (WebCore::DOMTimer::adjustMinimumTimerInterval): m_originalTimeout was renamed to m_originalInterval. * page/DOMTimer.h: Add m_shouldForwardUserGesture and rename m_originalTimeout to m_originalInterval. git-svn-id: svn://svn.chromium.org/blink/trunk@81057 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
leviw@chromium.org authored
Reviewed by Ryosuke Niwa. Deleting content directly following a button inserts an unnecessary placeholder https://bugs.webkit.org/show_bug.cgi?id=56053 Test to ensure unnecessary placeholders aren't inserted after buttons when delete is pressed. * editing/deleting/delete-inserts-br-after-button-expected.txt: Added. * editing/deleting/delete-inserts-br-after-button.html: Added. 2011-03-09 Levi Weintraub <leviw@chromium.org> Reviewed by Ryosuke Niwa. Deleting content directly following a button inserts an unnecessary placeholder https://bugs.webkit.org/show_bug.cgi?id=56053 Fixing a use of Node's enclosingBlockFlowElement with enclosingBlock htmlediting's enclosingBlock, as enclosingBlockFlowElement would return inline-block elements despite DeleteSelectionCommand treating them as blockflow. Test: editing/deleting/delete-inserts-br-after-button.html * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): git-svn-id: svn://svn.chromium.org/blink/trunk@81056 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
hyatt@apple.com authored
Reviewed by Dan Bernstein. REGRESSION: <a><img align=top></a> Clickable area too large Make sure to clamp hit testing of quirky inline flow boxes the same way we already clamped painting. Source/WebCore: * rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::nodeAtPoint): LayoutTests: * fast/inline/inline-position-top-align-expected.txt: Added. * fast/inline/inline-position-top-align.html: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@81055 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
cmarrin@apple.com authored
Reviewed by Adam Roben. REGRESSION (r75138-r75503): Animations on Apple HTML5 Gallery demo are wrong https://bugs.webkit.org/show_bug.cgi?id=52845 The lastCommitTime() value in CACFLayerTreeHost was returning as the time the render previous to this one happened. That often made it seem like animations started more in the past than they did, breaking many animations. The startAnimations() call actually fires from a CACF callback after all the WebKit content has been rendered. So sending currentTime as the start time to the animations is close enough for proper synchronization. * platform/graphics/ca/win/CACFLayerTreeHost.cpp: (WebCore::CACFLayerTreeHost::notifyAnimationsStarted): git-svn-id: svn://svn.chromium.org/blink/trunk@81054 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
rniwa@webkit.org authored
Reviewed by Tony Chang. Selection uses first mousemove's localRect instead of that of mousedown https://bugs.webkit.org/show_bug.cgi?id=56213 Fixed the bug by adding an extra call to updateSelectionForMouseDrag in handleMouseDraggedEvent using the mouse coordinates of the mousedown event that started the drag. Test: editing/selection/drag-select-rapidly.html * page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDraggedEvent): 2011-03-11 Ryosuke Niwa <rniwa@webkit.org> Reviewed by Tony Chang. Selection uses first mousemove's localRect instead of that of mousedown https://bugs.webkit.org/show_bug.cgi?id=56213 Added a test to ensure the selection start is computed using the mouse coordinates passed down to the corresponding mousedown event instead of that of the first mousemove event. The test is co-authored by Evan Martin. * editing/selection/anchor-focus2-expected.txt: Editing delegate changes. * editing/selection/anchor-focus3-expected.txt: Ditto. * editing/selection/drag-select-rapidly-expected.txt: Added. * editing/selection/drag-select-rapidly.html: Added. * platform/mac/editing/selection/drag-select-1-expected.txt: Selects the correct range of text. * platform/mac/editing/selection/fake-drag-expected.txt: Ditto. * platform/mac/editing/selection/inline-closest-leaf-child-expected.txt: Ditto. git-svn-id: svn://svn.chromium.org/blink/trunk@81053 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
levin@chromium.org authored
except for the typical minor font differences. * platform/chromium-linux/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum: Added. * platform/chromium-linux/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Added. * platform/chromium-linux/css2.1/t1008-c44-ln-box-02-d-ag-expected.txt: Added. * platform/chromium/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81052 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
http://webkit.org/b/56304mrowe@apple.com authored
Reviewed by Oliver Hunt. Source/JavaScriptCore: * API/JSClassRef.cpp: (OpaqueJSClass::OpaqueJSClass): Don't leak any existing entry for the given name if the class definition contains duplicates. This also removes what look to be leaks of the StringImpl instances that are used as keys: the HashMap key type is a RefPtr which retains / releases the instances at the appropriate time, so explicitly calling ref is not necessary. Tools: * DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::staticFunctions): Remove duplicate entries. git-svn-id: svn://svn.chromium.org/blink/trunk@81051 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mrowe@apple.com authored
Reviewed by Timothy Hatcher. * Configurations/Base.xcconfig: Disable the generation of debugging symbols when building the Debug configuration on Leopard. This should cut the size of the object files that the linker needs to process by over 85%. This will hopefully allow them to fit in to the 32-bit address space of the Leopard linker. git-svn-id: svn://svn.chromium.org/blink/trunk@81050 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
hyatt@apple.com authored
Reviewed by Beth Dakin. Add support for relative positioning to table cells. Back out the code that hacked around the lack of support for offsetLeft, and add new tests to demonstrate that relative positioning works. Source/WebCore: * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): * rendering/RenderObject.cpp: (WebCore::RenderObject::offsetParent): * rendering/RenderObject.h: (WebCore::RenderObject::isRelPositioned): * rendering/RenderTableCell.h: * rendering/style/RenderStyle.h: * rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): * rendering/style/StyleRareNonInheritedData.h: LayoutTests: * fast/table/relative-position-containment.html: Added. * fast/table/relative-position-offsets.html: Added. * fast/table/relative-position-stacking.html: Added. * platform/mac/fast/table/overflowHidden-expected.txt: * platform/mac/fast/table/relative-position-containment-expected.checksum: Added. * platform/mac/fast/table/relative-position-containment-expected.png: Added. * platform/mac/fast/table/relative-position-containment-expected.txt: Added. * platform/mac/fast/table/relative-position-offsets-expected.checksum: Added. * platform/mac/fast/table/relative-position-offsets-expected.png: Added. * platform/mac/fast/table/relative-position-offsets-expected.txt: Added. * platform/mac/fast/table/relative-position-stacking-expected.checksum: Added. * platform/mac/fast/table/relative-position-stacking-expected.png: Added. * platform/mac/fast/table/relative-position-stacking-expected.txt: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@81049 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
https://bugs.webkit.org/show_bug.cgi?id=56230hyatt@apple.com authored
layer, since first layouts and printing mess up otherwise. Reviewed by Beth Dakin. * page/FrameView.cpp: (WebCore::FrameView::layout): git-svn-id: svn://svn.chromium.org/blink/trunk@81048 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
levin@chromium.org authored
+ Add more tests that belong there. + Sort the tests that are there. + Add PASS to the lines that are there since these tests are known to pass and a passing result for them shouldn't cause a test run to go orange. * platform/chromium/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81047 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
alice.liu@apple.com authored
Reviewed by Dan Bernstein. * DumpRenderTree/mac/PerlSupport/Makefile: Add whitespace when joining "-arch" with the architectures passed in as arguments. git-svn-id: svn://svn.chromium.org/blink/trunk@81046 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
hyatt@apple.com authored
Clean up full repainting of layers during layout and at other times. Platforms that did not do an invalidation on size changes were incorrectly relying on the DoFullRepaint case of RenderLayer::updateLayerPositions to invalidate for them. However this code is now wrong, since it assumed that the outermost layer was a RenderView that encompassed all of the child layers. This is no longer the case since the overflow changes that tightened up visual overflow and limited that overflow only to content that the layer painted. Reviewed by Simon Fraser. Eliminate the DoFullRepaint flag and actually make no repainting of any kind happen from the layer code if FrameView's m_doFullRepaint boolean is set. This will flush out any ports that aren't just invalidating the world on their own in response to view resizes or fixed layout size changes and force them to fix things to be consistent with the other ports. Make the two dynamic calls to updateLayerPositions still do a full repaint by setting the repaint flag on the layer. I'm suspicious as to the correctness of the repainting in both of these cases (both before and after this patch), but the behavior should be the same. No new tests, since this is untestable on ports that invalidate on a resize. * page/FrameView.cpp: (WebCore::FrameView::layout): * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::styleDidChange): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::removeOnlyThisLayer): * rendering/RenderLayer.h: git-svn-id: svn://svn.chromium.org/blink/trunk@81045 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
levin@chromium.org authored
Also, added yet more tests to the linux debug crash sweeping through the layout tests. * platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-1-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-1-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-10-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-10-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-2-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-2-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-3-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-3-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-4-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-4-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-5-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-5-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-6-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-6-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-7-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-7-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-8-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-8-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-add-summary-9-expected.checksum: Added. * platform/chromium-linux/fast/html/details-add-summary-9-expected.png: Added. * platform/chromium-linux/fast/html/details-no-summary1-expected.checksum: Added. * platform/chromium-linux/fast/html/details-no-summary1-expected.png: Added. * platform/chromium-linux/fast/html/details-no-summary2-expected.checksum: Added. * platform/chromium-linux/fast/html/details-no-summary2-expected.png: Added. * platform/chromium-linux/fast/html/details-no-summary3-expected.checksum: Added. * platform/chromium-linux/fast/html/details-no-summary3-expected.png: Added. * platform/chromium-linux/fast/html/details-no-summary4-expected.checksum: Added. * platform/chromium-linux/fast/html/details-no-summary4-expected.png: Added. * platform/chromium-linux/fast/html/details-open-javascript-expected.checksum: Added. * platform/chromium-linux/fast/html/details-open-javascript-expected.png: Added. * platform/chromium-linux/fast/html/details-open1-expected.checksum: Added. * platform/chromium-linux/fast/html/details-open1-expected.png: Added. * platform/chromium-linux/fast/html/details-open2-expected.checksum: Added. * platform/chromium-linux/fast/html/details-open2-expected.png: Added. * platform/chromium-linux/fast/html/details-open3-expected.checksum: Added. * platform/chromium-linux/fast/html/details-open3-expected.png: Added. * platform/chromium-linux/fast/html/details-open4-expected.checksum: Added. * platform/chromium-linux/fast/html/details-open4-expected.png: Added. * platform/chromium-linux/fast/html/details-open5-expected.checksum: Added. * platform/chromium-linux/fast/html/details-open5-expected.png: Added. * platform/chromium-linux/fast/html/details-open6-expected.checksum: Added. * platform/chromium-linux/fast/html/details-open6-expected.png: Added. * platform/chromium-linux/fast/html/details-position-expected.checksum: Added. * platform/chromium-linux/fast/html/details-position-expected.png: Added. * platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-remove-summary-1-expected.checksum: Added. * platform/chromium-linux/fast/html/details-remove-summary-1-expected.png: Added. * platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-remove-summary-2-expected.checksum: Added. * platform/chromium-linux/fast/html/details-remove-summary-2-expected.png: Added. * platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-remove-summary-3-expected.checksum: Added. * platform/chromium-linux/fast/html/details-remove-summary-3-expected.png: Added. * platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-remove-summary-4-expected.checksum: Added. * platform/chromium-linux/fast/html/details-remove-summary-4-expected.png: Added. * platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-remove-summary-5-expected.checksum: Added. * platform/chromium-linux/fast/html/details-remove-summary-5-expected.png: Added. * platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.checksum: Added. * platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.png: Added. * platform/chromium-linux/fast/html/details-remove-summary-6-expected.checksum: Added. * platform/chromium-linux/fast/html/details-remove-summary-6-expected.png: Added. * platform/chromium-linux/fast/html/details-writing-mode-expected.checksum: Added. * platform/chromium-linux/fast/html/details-writing-mode-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-1-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-1-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-1-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-10-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-10-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-10-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-2-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-2-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-2-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-3-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-3-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-3-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-4-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-4-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-4-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-5-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-5-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-5-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-6-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-6-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-6-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-7-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-7-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-7-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-8-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-8-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-8-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-add-summary-9-expected.checksum: Added. * platform/chromium-mac/fast/html/details-add-summary-9-expected.png: Added. * platform/chromium-mac/fast/html/details-add-summary-9-expected.txt: Added. * platform/chromium-mac/fast/html/details-no-summary1-expected.checksum: Added. * platform/chromium-mac/fast/html/details-no-summary1-expected.png: Added. * platform/chromium-mac/fast/html/details-no-summary1-expected.txt: Added. * platform/chromium-mac/fast/html/details-no-summary2-expected.checksum: Added. * platform/chromium-mac/fast/html/details-no-summary2-expected.png: Added. * platform/chromium-mac/fast/html/details-no-summary2-expected.txt: Added. * platform/chromium-mac/fast/html/details-no-summary3-expected.checksum: Added. * platform/chromium-mac/fast/html/details-no-summary3-expected.png: Added. * platform/chromium-mac/fast/html/details-no-summary3-expected.txt: Added. * platform/chromium-mac/fast/html/details-no-summary4-expected.checksum: Added. * platform/chromium-mac/fast/html/details-no-summary4-expected.png: Added. * platform/chromium-mac/fast/html/details-no-summary4-expected.txt: Added. * platform/chromium-mac/fast/html/details-open-javascript-expected.checksum: Added. * platform/chromium-mac/fast/html/details-open-javascript-expected.png: Added. * platform/chromium-mac/fast/html/details-open-javascript-expected.txt: Added. * platform/chromium-mac/fast/html/details-open1-expected.checksum: Added. * platform/chromium-mac/fast/html/details-open1-expected.png: Added. * platform/chromium-mac/fast/html/details-open1-expected.txt: Added. * platform/chromium-mac/fast/html/details-open2-expected.checksum: Added. * platform/chromium-mac/fast/html/details-open2-expected.png: Added. * platform/chromium-mac/fast/html/details-open2-expected.txt: Added. * platform/chromium-mac/fast/html/details-open3-expected.checksum: Added. * platform/chromium-mac/fast/html/details-open3-expected.png: Added. * platform/chromium-mac/fast/html/details-open3-expected.txt: Added. * platform/chromium-mac/fast/html/details-open4-expected.checksum: Added. * platform/chromium-mac/fast/html/details-open4-expected.png: Added. * platform/chromium-mac/fast/html/details-open4-expected.txt: Added. * platform/chromium-mac/fast/html/details-open5-expected.checksum: Added. * platform/chromium-mac/fast/html/details-open5-expected.png: Added. * platform/chromium-mac/fast/html/details-open5-expected.txt: Added. * platform/chromium-mac/fast/html/details-open6-expected.checksum: Added. * platform/chromium-mac/fast/html/details-open6-expected.png: Added. * platform/chromium-mac/fast/html/details-open6-expected.txt: Added. * platform/chromium-mac/fast/html/details-position-expected.checksum: Added. * platform/chromium-mac/fast/html/details-position-expected.png: Added. * platform/chromium-mac/fast/html/details-position-expected.txt: Added. * platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-remove-summary-1-expected.checksum: Added. * platform/chromium-mac/fast/html/details-remove-summary-1-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-1-expected.txt: Added. * platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-remove-summary-2-expected.checksum: Added. * platform/chromium-mac/fast/html/details-remove-summary-2-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-2-expected.txt: Added. * platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-remove-summary-3-expected.checksum: Added. * platform/chromium-mac/fast/html/details-remove-summary-3-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-3-expected.txt: Added. * platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-remove-summary-4-expected.checksum: Added. * platform/chromium-mac/fast/html/details-remove-summary-4-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-4-expected.txt: Added. * platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-remove-summary-5-expected.checksum: Added. * platform/chromium-mac/fast/html/details-remove-summary-5-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-5-expected.txt: Added. * platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.checksum: Added. * platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.txt: Added. * platform/chromium-mac/fast/html/details-remove-summary-6-expected.checksum: Added. * platform/chromium-mac/fast/html/details-remove-summary-6-expected.png: Added. * platform/chromium-mac/fast/html/details-remove-summary-6-expected.txt: Added. * platform/chromium-mac/fast/html/details-writing-mode-expected.checksum: Added. * platform/chromium-mac/fast/html/details-writing-mode-expected.png: Added. * platform/chromium-mac/fast/html/details-writing-mode-expected.txt: Added. * platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-1-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-1-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-1-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-10-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-10-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-10-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-2-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-2-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-2-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-3-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-3-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-3-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-4-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-4-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-4-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-5-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-5-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-5-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-6-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-6-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-6-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-7-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-7-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-7-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-8-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-8-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-8-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-add-summary-9-expected.checksum: Added. * platform/chromium-win/fast/html/details-add-summary-9-expected.png: Added. * platform/chromium-win/fast/html/details-add-summary-9-expected.txt: Added. * platform/chromium-win/fast/html/details-no-summary1-expected.checksum: Added. * platform/chromium-win/fast/html/details-no-summary1-expected.png: Added. * platform/chromium-win/fast/html/details-no-summary1-expected.txt: Added. * platform/chromium-win/fast/html/details-no-summary2-expected.checksum: Added. * platform/chromium-win/fast/html/details-no-summary2-expected.png: Added. * platform/chromium-win/fast/html/details-no-summary2-expected.txt: Added. * platform/chromium-win/fast/html/details-no-summary3-expected.checksum: Added. * platform/chromium-win/fast/html/details-no-summary3-expected.png: Added. * platform/chromium-win/fast/html/details-no-summary3-expected.txt: Added. * platform/chromium-win/fast/html/details-no-summary4-expected.checksum: Added. * platform/chromium-win/fast/html/details-no-summary4-expected.png: Added. * platform/chromium-win/fast/html/details-no-summary4-expected.txt: Added. * platform/chromium-win/fast/html/details-open-javascript-expected.checksum: Added. * platform/chromium-win/fast/html/details-open-javascript-expected.png: Added. * platform/chromium-win/fast/html/details-open-javascript-expected.txt: Added. * platform/chromium-win/fast/html/details-open1-expected.checksum: Added. * platform/chromium-win/fast/html/details-open1-expected.png: Added. * platform/chromium-win/fast/html/details-open1-expected.txt: Added. * platform/chromium-win/fast/html/details-open2-expected.checksum: Added. * platform/chromium-win/fast/html/details-open2-expected.png: Added. * platform/chromium-win/fast/html/details-open2-expected.txt: Added. * platform/chromium-win/fast/html/details-open3-expected.checksum: Added. * platform/chromium-win/fast/html/details-open3-expected.png: Added. * platform/chromium-win/fast/html/details-open3-expected.txt: Added. * platform/chromium-win/fast/html/details-open4-expected.checksum: Added. * platform/chromium-win/fast/html/details-open4-expected.png: Added. * platform/chromium-win/fast/html/details-open4-expected.txt: Added. * platform/chromium-win/fast/html/details-open5-expected.checksum: Added. * platform/chromium-win/fast/html/details-open5-expected.png: Added. * platform/chromium-win/fast/html/details-open5-expected.txt: Added. * platform/chromium-win/fast/html/details-open6-expected.checksum: Added. * platform/chromium-win/fast/html/details-open6-expected.png: Added. * platform/chromium-win/fast/html/details-open6-expected.txt: Added. * platform/chromium-win/fast/html/details-position-expected.checksum: Added. * platform/chromium-win/fast/html/details-position-expected.png: Added. * platform/chromium-win/fast/html/details-position-expected.txt: Added. * platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-remove-summary-1-expected.checksum: Added. * platform/chromium-win/fast/html/details-remove-summary-1-expected.png: Added. * platform/chromium-win/fast/html/details-remove-summary-1-expected.txt: Added. * platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-remove-summary-2-expected.checksum: Added. * platform/chromium-win/fast/html/details-remove-summary-2-expected.png: Added. * platform/chromium-win/fast/html/details-remove-summary-2-expected.txt: Added. * platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-remove-summary-3-expected.checksum: Added. * platform/chromium-win/fast/html/details-remove-summary-3-expected.png: Added. * platform/chromium-win/fast/html/details-remove-summary-3-expected.txt: Added. * platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-remove-summary-4-expected.checksum: Added. * platform/chromium-win/fast/html/details-remove-summary-4-expected.png: Added. * platform/chromium-win/fast/html/details-remove-summary-4-expected.txt: Added. * platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-remove-summary-5-expected.checksum: Added. * platform/chromium-win/fast/html/details-remove-summary-5-expected.png: Added. * platform/chromium-win/fast/html/details-remove-summary-5-expected.txt: Added. * platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.checksum: Added. * platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.png: Added. * platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.txt: Added. * platform/chromium-win/fast/html/details-remove-summary-6-expected.checksum: Added. * platform/chromium-win/fast/html/details-remove-summary-6-expected.png: Added. * platform/chromium-win/fast/html/details-remove-summary-6-expected.txt: Added. * platform/chromium-win/fast/html/details-writing-mode-expected.checksum: Added. * platform/chromium-win/fast/html/details-writing-mode-expected.png: Added. * platform/chromium-win/fast/html/details-writing-mode-expected.txt: Added. * platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: * platform/chromium/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81044 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
oliver@apple.com authored
git-svn-id: svn://svn.chromium.org/blink/trunk@81043 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dbates@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=55438 Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add when landing changeset 81041 <http://trac.webkit.org/changeset/81041>. * Scripts/build-webkit: git-svn-id: svn://svn.chromium.org/blink/trunk@81042 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
dbates@webkit.org authored
Reviewed by David Kilzer. Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject() https://bugs.webkit.org/show_bug.cgi?id=55438 Separate out the EFL- and WinCE-specific logic from the port-independent logic in webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the CMake arguments for feature defines. * Scripts/build-webkit: - Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments. - Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit(). - Sorted forward declarations. - Initialize $makeArgs with the empty string so as to simplify its use in string operations; Modified call sites as needed. * Scripts/webkitdirs.pm: - Added cleanCMakeGeneratedProject() to clean a CMake build. - Added buildCMakeGeneratedProject() to build using generated build system. - Added buildCMakeProjectOrExit() which is a facade for building a CMake project. - Added generateBuildSystemFromCMakeProject() to generate the build system from a CMake project. - Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit(). git-svn-id: svn://svn.chromium.org/blink/trunk@81041 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
oliver@apple.com authored
Reviewed by Gavin Barraclough. Ensure all values are correctly tagged in the registerfile https://bugs.webkit.org/show_bug.cgi?id=56214 This patch makes sure that all JSCell pointers written to the registerfile are correctly tagged as JSCells, and replaces raw int usage with the immediate representation. For performance, register pressure, and general saneness reasons I've added abstractions for reading and writing the tag and payload of integer registers directly for the JSVALUE64 encoding. * interpreter/Register.h: (JSC::Register::withInt): (JSC::Register::withCallee): (JSC::Register::operator=): (JSC::Register::i): (JSC::Register::activation): (JSC::Register::function): (JSC::Register::propertyNameIterator): (JSC::Register::scopeChain): * jit/JIT.h: * jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCall): * jit/JITCall32_64.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase): * jit/JITInlineMethods.h: (JSC::JIT::emitPutToCallFrameHeader): (JSC::JIT::emitPutCellToCallFrameHeader): (JSC::JIT::emitPutIntToCallFrameHeader): * jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTINativeCall): (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_next_pname): (JSC::JIT::emit_op_load_varargs): (JSC::JIT::emitSlow_op_load_varargs): * jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTINativeCall): (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_next_pname): * jit/JSInterfaceJIT.h: (JSC::JSInterfaceJIT::intPayloadFor): (JSC::JSInterfaceJIT::intTagFor): * jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::returnJSValue): (JSC::SpecializedThunkJIT::returnDouble): (JSC::SpecializedThunkJIT::returnInt32): (JSC::SpecializedThunkJIT::returnJSCell): 2011-03-11 Oliver Hunt <oliver@apple.com> Reviewed by Gavin Barraclough. Ensure all values are correctly tagged in the registerfile https://bugs.webkit.org/show_bug.cgi?id=56214 Make sure everything builds still. * bridge/c/c_class.cpp: * bridge/c/c_runtime.cpp: * bridge/jni/JavaMethod.cpp: * plugins/PluginViewNone.cpp: git-svn-id: svn://svn.chromium.org/blink/trunk@81040 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
luiz@webkit.org authored
* html/HTMLDetailsElement.cpp: (WebCore::HTMLDetailsElement::defaultEventHandler): * rendering/RenderDetailsMarker.cpp: (WebCore::createDownArrowPath): (WebCore::createUpArrowPath): (WebCore::createLeftArrowPath): (WebCore::createRightArrowPath): git-svn-id: svn://svn.chromium.org/blink/trunk@81039 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jer.noble@apple.com authored
Reviewed by Eric Carlson. FullScreen: Handle entering full screen security restrictions https://bugs.webkit.org/show_bug.cgi?id=56264 * fullscreen/full-screen-css.html: Use runWithKeyDown. * fullscreen/full-screen-remove-ancestor.html: Ditto. * fullscreen/full-screen-remove.html: Ditto. * fullscreen/full-screen-request.html: Ditto. * fullscreen/full-screen-twice.html: Ditto. * fullscreen/full-screen-test.js: * fullscreen/full-screen-iframe-allowed-expected.txt: Added. * fullscreen/full-screen-iframe-allowed.html: Added. * fullscreen/full-screen-iframe-not-allowed-expected.txt: Added. * fullscreen/full-screen-iframe-not-allowed.html: Added. (runWithKeyDown): Added. Wraps the command in a keyDown/keyPress listener. * platform/mac-wk2/Skipped: Added new tests to skipped list. * platform/qt-wk2/Skipped: Ditto. 2011-03-13 Jer Noble <jer.noble@apple.com> FullScreen: Handle entering full screen security restrictions https://bugs.webkit.org/show_bug.cgi?id=56264 Tests: fullscreen/full-screen-iframe-allowed.html fullscreen/full-screen-iframe-not-allowed.html Disable full screen documents in the following conditions: 1) requesting element is in an iframe which does not have a webkitallowfullscreen attribute. 2) page is not processing a user gesture. * dom/Document.cpp: (WebCore::Document::fullScreenIsAllowedForElement): Added. Checks to see if elements contained in IFRAMES are allowed to enter full screen. (WebCore::Document::webkitRequestFullScreenForElement): Checks if page is currently processing a user gesture. * dom/Document.h: * html/HTMLAttributeNames.in: Added webkitallowfullscreenAttr. * html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::allowFullScreen): Added. * html/HTMLFrameElementBase.h: git-svn-id: svn://svn.chromium.org/blink/trunk@81038 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
levin@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=56303 Patch by Anton D'Auria <adauria@apple.com> on 2011-03-14 Reviewed by David Levin. Initialized m_syncCloseDatabase to false in the StorageAreaSync constructor. * storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::StorageAreaSync): git-svn-id: svn://svn.chromium.org/blink/trunk@81037 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
steveblock@google.com authored
Reviewed by Oliver Hunt. JavaMethod.cpp does not compile with V8 https://bugs.webkit.org/show_bug.cgi?id=56306 Moved the ScopeChain.h include to JavaStringJSC. No new tests, build fix only. * bridge/jni/JavaMethod.cpp: * bridge/jni/jsc/JavaStringJSC.h git-svn-id: svn://svn.chromium.org/blink/trunk@81036 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
luiz@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=51071 Reviewed by Dave Hyatt. Source/WebCore: Tests: fast/html/details-add-summary-1-and-click.html fast/html/details-add-summary-1.html fast/html/details-add-summary-10-and-click.html fast/html/details-add-summary-10.html fast/html/details-add-summary-2-and-click.html fast/html/details-add-summary-2.html fast/html/details-add-summary-3-and-click.html fast/html/details-add-summary-3.html fast/html/details-add-summary-4-and-click.html fast/html/details-add-summary-4.html fast/html/details-add-summary-5-and-click.html fast/html/details-add-summary-5.html fast/html/details-add-summary-6-and-click.html fast/html/details-add-summary-6.html fast/html/details-add-summary-7-and-click.html fast/html/details-add-summary-7.html fast/html/details-add-summary-8-and-click.html fast/html/details-add-summary-8.html fast/html/details-add-summary-9-and-click.html fast/html/details-add-summary-9.html fast/html/details-mouse-click.html fast/html/details-no-summary1.html fast/html/details-no-summary2.html fast/html/details-no-summary3.html fast/html/details-no-summary4.html fast/html/details-open-javascript.html fast/html/details-open1.html fast/html/details-open2.html fast/html/details-open3.html fast/html/details-open4.html fast/html/details-open5.html fast/html/details-open6.html fast/html/details-position.html fast/html/details-remove-summary-1-and-click.html fast/html/details-remove-summary-1.html fast/html/details-remove-summary-2-and-click.html fast/html/details-remove-summary-2.html fast/html/details-remove-summary-3-and-click.html fast/html/details-remove-summary-3.html fast/html/details-remove-summary-4-and-click.html fast/html/details-remove-summary-4.html fast/html/details-remove-summary-5-and-click.html fast/html/details-remove-summary-5.html fast/html/details-remove-summary-6-and-click.html fast/html/details-remove-summary-6.html fast/html/details-writing-mode.html http://www.w3.org/TR/html5/interactive-elements.html#the-details-element The main <summary> element is the first <summary> element of a <details> element. All other childs of the <details> element are rendered only if the attribute 'open' is set. Click event toggles the 'open' attribute. * html/HTMLDetailsElement.cpp: (WebCore::HTMLDetailsElement::HTMLDetailsElement): (WebCore::HTMLDetailsElement::findMainSummary): (WebCore::HTMLDetailsElement::childrenChanged): (WebCore::HTMLDetailsElement::finishParsingChildren): (WebCore::HTMLDetailsElement::parseMappedAttribute): (WebCore::HTMLDetailsElement::childShouldCreateRenderer): (WebCore::HTMLDetailsElement::defaultEventHandler): * html/HTMLDetailsElement.h: (WebCore::HTMLDetailsElement::mainSummary): Method createRenderer added to class HTMLSummaryElement. * html/HTMLSummaryElement.cpp: (WebCore::HTMLSummaryElement::createRenderer): * html/HTMLSummaryElement.h: The first <summary> element is positioned at the top of its <details> parent. The area occupied by this main <summary> element is the interactive area of the <details> element. If the <details> tag has no <summary> child an OwnedSummaryRenderer is created and added to the corresponding RenderDetails object. * rendering/RenderDetails.cpp: (WebCore::RenderDetails::RenderDetails): (WebCore::RenderDetails::destroy): (WebCore::RenderDetails::summaryBlock): (WebCore::RenderDetails::contentBlock): (WebCore::RenderDetails::addChild): (WebCore::RenderDetails::removeChild): (WebCore::RenderDetails::setMarkerStyle): (WebCore::RenderDetails::styleDidChange): (WebCore::RenderDetails::getRenderPosition): (WebCore::RenderDetails::markerDestroyed): (WebCore::RenderDetails::summaryDestroyed): (WebCore::RenderDetails::moveSummaryToContents): (WebCore::RenderDetails::createSummaryStyle): (WebCore::RenderDetails::replaceMainSummary): (WebCore::RenderDetails::createDefaultSummary): (WebCore::RenderDetails::checkMainSummary): (WebCore::RenderDetails::layout): (WebCore::RenderDetails::isOpen): (WebCore::RenderDetails::getParentOfFirstLineBox): (WebCore::RenderDetails::firstNonMarkerChild): (WebCore::RenderDetails::updateMarkerLocation): * rendering/RenderDetails.h: (WebCore::RenderDetails::interactiveArea): (WebCore::RenderDetails::removeLeftoverAnonymousBlock): (WebCore::RenderDetails::createsAnonymousWrapper): (WebCore::RenderDetails::requiresForcedStyleRecalcPropagation): A marker is added to the main <summary> element to indicate the current value of the 'open' attribute of the <details> element. * rendering/RenderDetailsMarker.cpp: (WebCore::RenderDetailsMarker::RenderDetailsMarker): (WebCore::RenderDetailsMarker::destroy): (WebCore::RenderDetailsMarker::lineHeight): (WebCore::RenderDetailsMarker::baselinePosition): (WebCore::RenderDetailsMarker::computePreferredLogicalWidths): (WebCore::RenderDetailsMarker::layout): (WebCore::RenderDetailsMarker::getRelativeMarkerRect): (WebCore::RenderDetailsMarker::isOpen): (WebCore::createPath): (WebCore::createDownArrowPath): (WebCore::createUpArrowPath): (WebCore::createLeftArrowPath): (WebCore::createRightArrowPath): (WebCore::RenderDetailsMarker::orientation): (WebCore::RenderDetailsMarker::getCanonicalPath): (WebCore::RenderDetailsMarker::getPath): (WebCore::RenderDetailsMarker::paint): * rendering/RenderDetailsMarker.h: (WebCore::toRenderDetailsMarker): * rendering/RenderSummary.cpp: (WebCore::RenderSummary::RenderSummary): (WebCore::RenderSummary::destroy): (WebCore::RenderSummary::parentDetails): (WebCore::RenderSummary::styleDidChange): * rendering/RenderSummary.h: * rendering/RenderTreeAsText.cpp: (WebCore::RenderTreeAsText::writeRenderObject): LayoutTests: * fast/html/details-add-summary-1-and-click.html: Added. * fast/html/details-add-summary-1.html: Added. * fast/html/details-add-summary-10-and-click.html: Added. * fast/html/details-add-summary-10.html: Added. * fast/html/details-add-summary-2-and-click.html: Added. * fast/html/details-add-summary-2.html: Added. * fast/html/details-add-summary-3-and-click.html: Added. * fast/html/details-add-summary-3.html: Added. * fast/html/details-add-summary-4-and-click.html: Added. * fast/html/details-add-summary-4.html: Added. * fast/html/details-add-summary-5-and-click.html: Added. * fast/html/details-add-summary-5.html: Added. * fast/html/details-add-summary-6-and-click.html: Added. * fast/html/details-add-summary-6.html: Added. * fast/html/details-add-summary-7-and-click.html: Added. * fast/html/details-add-summary-7.html: Added. * fast/html/details-add-summary-8-and-click.html: Added. * fast/html/details-add-summary-8.html: Added. * fast/html/details-add-summary-9-and-click.html: Added. * fast/html/details-add-summary-9.html: Added. * fast/html/details-mouse-click-expected.txt: Added. * fast/html/details-mouse-click.html: Added. * fast/html/details-no-summary1.html: Added. * fast/html/details-no-summary2.html: Added. * fast/html/details-no-summary3.html: Added. * fast/html/details-no-summary4.html: Added. * fast/html/details-open-javascript.html: Added. * fast/html/details-open1.html: Added. * fast/html/details-open2.html: Added. * fast/html/details-open3.html: Added. * fast/html/details-open4.html: Added. * fast/html/details-open5.html: Added. * fast/html/details-open6.html: Added. * fast/html/details-position.html: Added. * fast/html/details-remove-summary-1-and-click.html: Added. * fast/html/details-remove-summary-1.html: Added. * fast/html/details-remove-summary-2-and-click.html: Added. * fast/html/details-remove-summary-2.html: Added. * fast/html/details-remove-summary-3-and-click.html: Added. * fast/html/details-remove-summary-3.html: Added. * fast/html/details-remove-summary-4-and-click.html: Added. * fast/html/details-remove-summary-4.html: Added. * fast/html/details-remove-summary-5-and-click.html: Added. * fast/html/details-remove-summary-5.html: Added. * fast/html/details-remove-summary-6-and-click.html: Added. * fast/html/details-remove-summary-6.html: Added. * fast/html/details-writing-mode.html: Added. * platform/qt/fast/html/details-add-summary-1-and-click-expected.txt: Added. * platform/qt/fast/html/details-add-summary-1-expected.txt: Added. * platform/qt/fast/html/details-add-summary-10-and-click-expected.txt: Added. * platform/qt/fast/html/details-add-summary-10-expected.txt: Added. * platform/qt/fast/html/details-add-summary-2-and-click-expected.txt: Added. * platform/qt/fast/html/details-add-summary-2-expected.txt: Added. * platform/qt/fast/html/details-add-summary-3-and-click-expected.txt: Added. * platform/qt/fast/html/details-add-summary-3-expected.txt: Added. * platform/qt/fast/html/details-add-summary-4-and-click-expected.txt: Added. * platform/qt/fast/html/details-add-summary-4-expected.txt: Added. * platform/qt/fast/html/details-add-summary-5-and-click-expected.txt: Added. * platform/qt/fast/html/details-add-summary-5-expected.txt: Added. * platform/qt/fast/html/details-add-summary-6-and-click-expected.txt: Added. * platform/qt/fast/html/details-add-summary-6-expected.txt: Added. * platform/qt/fast/html/details-add-summary-7-and-click-expected.txt: Added. * platform/qt/fast/html/details-add-summary-7-expected.txt: Added. * platform/qt/fast/html/details-add-summary-8-and-click-expected.txt: Added. * platform/qt/fast/html/details-add-summary-8-expected.txt: Added. * platform/qt/fast/html/details-add-summary-9-and-click-expected.txt: Added. * platform/qt/fast/html/details-add-summary-9-expected.txt: Added. * platform/qt/fast/html/details-no-summary1-expected.txt: Added. * platform/qt/fast/html/details-no-summary2-expected.txt: Added. * platform/qt/fast/html/details-no-summary3-expected.txt: Added. * platform/qt/fast/html/details-no-summary4-expected.txt: Added. * platform/qt/fast/html/details-open-javascript-expected.txt: Added. * platform/qt/fast/html/details-open1-expected.txt: Added. * platform/qt/fast/html/details-open2-expected.txt: Added. * platform/qt/fast/html/details-open3-expected.txt: Added. * platform/qt/fast/html/details-open4-expected.txt: Added. * platform/qt/fast/html/details-open5-expected.txt: Added. * platform/qt/fast/html/details-open6-expected.txt: Added. * platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt: Added. * platform/qt/fast/html/details-remove-summary-1-expected.txt: Added. * platform/qt/fast/html/details-remove-summary-2-and-click-expected.txt: Added. * platform/qt/fast/html/details-remove-summary-2-expected.txt: Added. * platform/qt/fast/html/details-remove-summary-3-and-click-expected.txt: Added. * platform/qt/fast/html/details-remove-summary-3-expected.txt: Added. * platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt: Added. * platform/qt/fast/html/details-remove-summary-4-expected.txt: Added. * platform/qt/fast/html/details-remove-summary-5-and-click-expected.txt: Added. * platform/qt/fast/html/details-remove-summary-5-expected.txt: Added. * platform/qt/fast/html/details-remove-summary-6-and-click-expected.txt: Added. * platform/qt/fast/html/details-remove-summary-6-expected.txt: Added. * platform/qt/fast/html/details-writing-mode-expected.txt: Added. * platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81035 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
beidson@apple.com authored
Clean up IconDatabaseBase header. Reviewed by Sam Weinig. -Get rid of the "PlatformString.h" include and replace it with a forward declaration. -Group methods by which are used in WebCore directly and which are used in WebKit ports. This'll make it easier to use in external frameworks (like WebKit2). * loader/icon/IconDatabase.h: * loader/icon/IconDatabaseBase.h: (WebCore::IconDatabaseBase::retainIconForPageURL): (WebCore::IconDatabaseBase::releaseIconForPageURL): (WebCore::IconDatabaseBase::iconForPageURL): (WebCore::IconDatabaseBase::setIconURLForPageURL): (WebCore::IconDatabaseBase::setIconDataForIconURL): (WebCore::IconDatabaseBase::iconDataKnownForIconURL): (WebCore::IconDatabaseBase::loadDecisionForIconURL): (WebCore::IconDatabaseBase::importIconURLForPageURL): (WebCore::IconDatabaseBase::importIconDataForIconURL): (WebCore::IconDatabaseBase::open): git-svn-id: svn://svn.chromium.org/blink/trunk@81034 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
