- 07 May, 2020 40 commits
-
-
Gauthier Ambard authored
The test was failing because the screen of the phone is too small to display the action now that the "Downloads" entry is displayed. Fix it be scrolling the menu. Fixed: 1079185 Change-Id: I787bfeb9fdbcc183a247241d9f4cbe04489dd852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187490 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#766372}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3c5adb7b5fa0..3141e6914c82 git log 3c5adb7b5fa0..3141e6914c82 --date=short --first-parent --format='%ad %ae %s' 2020-05-07 pfaffe@chromium.org Return an error in evaluateVariables when formatters are unavailable 2020-05-07 pfaffe@chromium.org Fix tests after vector->set change Created with: gclient setdep -r src/third_party/devtools-frontend/src@3141e6914c82 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1020120 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I54c23117bd94580d6949d00214951b1451581394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187521Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#766371}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I689239a284337c2c8c4a4d25ab15a754cbb05362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187519Reviewed-by:
-
Sami Kyostila authored
This patch adds a build override for telling V8 to use the Perfetto client library built by Chromium instead of trying to build an independent copy. The feature flag (use_perfetto_client_library) is defaulted to false in V8 and overridden here when Chromium is also using Perfetto's client library[1]. Corresponding V8 change: https://chromium-review.googlesource.com/c/v8/v8/+/2182637 Bug: b/155075662 [1] https://docs.google.com/document/d/1f7tt4cb-JcA5bQFR1oXk60ncJPpkL02_Hi_Bc6MfTQk/ Change-Id: Iabdeec5fe957934dc0e3bb0364c5272a818415ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2184572 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#766369}
-
Peter Kasting authored
Include this directly in relevant test files. This lets us convert the HAS_OUT_OF_PROC_TEST_RUNNER checks in this file and view_event_test_base.h into #errors, and force people to not even include this file in files that can't use it. Bug: none Change-Id: I66e5ecc80f4c28ab79572b9112a952553a19ca5a Tbr: sky Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187192 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#766368}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d2b486219495..c8590c18bd0c git log d2b486219495..c8590c18bd0c --date=short --first-parent --format='%ad %ae %s' 2020-05-06 jaebaek@google.com Preserve debug info for wrap-opkill (#3331) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@c8590c18bd0c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: I4a9ab17e670355c1ee6de1e527463a48a33b5b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187363Reviewed-by:
-
Maks Orlovich authored
This involves some test updates; of particular note is that iframe-no-accept-ch.php helper didn't use to test what it thought it did since it was in the wrong directory. Change-Id: I70dc9055487b69946548ecc8b2fafb270a508438 Bug: 1078353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140918Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#766366}
-
Yann Dago authored
BYPASS_POLICY_COMPATIBILITY_CHECK=<Typo in policy name> Bug: 1078951 Change-Id: I703e03354ea215564bd90c8934808de2c5959ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186117 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#766365}
-
Roman Sorokin authored
Fit better with ChromeOS signin (also ownership-wise) Bug: none Change-Id: Iff29a93628b1d84f3a96630202b1d13cb3cfb6cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2182642Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#766364}
-
Benoit Lize authored
DNS resolution failures can be transient, especially with DoH, as they would include regular HTTP failures as well. Since the resolver turns all resolution failure errors into net::ERR_NAME_NOT_RESOLVED, it is useful for SimpleURLLoader to be able to retry requests. Bug: 1078350 Change-Id: Ic474fed0af4eb36c0d066e5e3be9c1deabde1eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181281 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#766363}
-
Mario Sanchez Prada authored
This CL moves this message out of frame_messages.h and adds a new method in blink::mojom::LocalFrame, implemented by blink::LocalFrame, to request the renderer to continue with the focus sequence for a given frame, handling both same-process and cross-proces scenarios. This CL also removes methods WebView::AdvanceFocusAcrossFrames() and WebView::SetInitialFocus(), since that functionality is no longer needed from outside of Blink and tests can be adapted. Bug: 1047318 Change-Id: Ic83f36862931d6eb03d278cb9ae1d101a205ac2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172691 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#766362}
-
Peter Kasting authored
This is a step towards doing full IWYU of browser_test.h, which will have other benefits. Completely mechanical and already R+ed as part of r765923. Tbr: sky Bug: none Change-Id: Icb7ab728098a6cf29c0920da4b524e96a7c024c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186411 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/28ae7c5809b2..3c5adb7b5fa0 git log 28ae7c5809b2..3c5adb7b5fa0 --date=short --first-parent --format='%ad %ae %s' 2020-05-07 sigurds@chromium.org Prepare protocol for argument renaming Created with: gclient setdep -r src/third_party/devtools-frontend/src@3c5adb7b5fa0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1027752,chromium:1051163 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I08f39b93f1d1f6d0946c05c59ccc88d61e89cc5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187513Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/459d7cc439a1..964c8df4b958 Created with: gclient setdep -r src-internal@964c8df4b958 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sinhak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sinhak@google.com Change-Id: I5b613ef91a7968b9837905d197b0076db773e901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187369Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#766359}
-
Bartek Nowierski authored
There is a difference between dereferencing a pointer (operator-> and operator*) and reading/casting it (get() and operator T*/U*). The latter must not crash on nullptr, whereas the former can. The underlying implementations may treat those situations differently. Furthermore, while reading/casting feel like a good moment to check if the pointer wasn't freed (because the caller may have an intention to dereference it soon), operators ==/!= don't need that hence the implementation may choose to go through a separate, possibly faster path. Bug: 1073933 Change-Id: If14af14c5b5fd046d9d0bf1d19903b67cbbf73c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166236 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#766358}
-
Clemens Arbesser authored
Bug: b/145043394 Change-Id: I0eb1f559853a2e548ea9e6fca6422e25a05b9ba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162809 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#766357}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6a91312c..ca0732e1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I03420a93c3c49ba3d5594bdc148f4ab4e9b262d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187010Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#766356}
-
Karandeep Bhatia authored
This CL adds support for specifying a base::Feature dependency for an extension feature. This can be useful to add a kill switch for extension API features during launches. Also, add a feature flag for the Declarative Net Request API. BUG=696822, 1077573 Doc=https://docs.google.com/document/d/1bGHFfpDb5oCfrMihUqWKYUmInWi4N2veW-YjyRq-FGo/edit?usp=sharing (Internal only) Change-Id: I61d05df383a962bda400989c47b03bd1ad7d1cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176987Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#766355}
-
Morten Stenshorne authored
Remove no-longer-needed first-for-node things added recently, mainly as part of CL:2111158. Inline nodes no longer need to specify this. On the physical fragment side, only *box* fragments need to specify whether they're first-for-node, so move stuff down there. Bug: 1043787 Change-Id: I0177f3bf7b3a4fe2ee160504368490283aaab079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167272 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#766354}
-
Peter E Conn authored
This CL adds the DisclosureNotificationResponseService, an IntentService that dismisses the notification and records that the disclosure has been accepted. Bug: 1068106 Change-Id: I41d8edf20e6225d550cb09376930f9a59275edbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2179007 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#766353}
-
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile and HasOffTheRecordProfile without argument is getting deprecated. Use cases of this call that ONLY refer to incognito or guest mode can use [Get/Has]PrimaryOTRProfile() instead. All calls to this function in chrome/browser/ui which are clearly only happening for incognito or guest browser are updated. This CL does not make any behavioral changes. Bug: 1060940 Change-Id: I39fcb02d986dbd973c3a49922bc24b774981e3d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187372 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Guido Urdaneta authored
Check that the value for this property is not null before trying to use its value. Bug: 1031921 Change-Id: I164ad850775df07fa5b993d7db51e671fc5bfa36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185491 Auto-Submit: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#766351}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 1079135 Change-Id: I5c880c3645c938d87fe5c1a0db4f04bec6c1c6ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186878 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#766350}
-
Yoshifumi Inoue authored
This patch changes "5190926.html" to utilize |selection_test()| and renames to "insert_list_with_underline.html" for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: I41ebbf60f50fa84a23526995624fc0db198506b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186618 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ba415029243a..8dd25597363a git log ba415029243a..8dd25597363a --date=short --first-parent --format='%ad %ae %s' 2020-05-07 dberris@chromium.org Pinpoint: Fix URL when displaying errors 2020-05-07 dberris@chromium.org Dashboard: Defer work to the background Created with: gclient setdep -r src/third_party/catapult@8dd25597363a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1079166 Tbr: wenbinzhang@google.com Change-Id: I66ec62528e13fdbe7d1a4f0f318cc586bfdc7769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187364Reviewed-by:
-
Denis Kuznetsov authored
Also updated offline-gaia screen so that is correctly handles subsequent loads with different parameters. Bug: 1073095 Change-Id: Ia75246be91197ac4bb7804f52bae44c48c839e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183932 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#766347}
-
Makoto Shimazu authored
We are going to resume this project. Let's extend the expiry date for the experiment. Bug: 824858 Change-Id: I14a0b20af553f6f1cbc3c0d90d2de6bbb98aa802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186787Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#766346}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/88d04cb51acf..e3d1de7c5281 git log 88d04cb51acf..e3d1de7c5281 --date=short --first-parent --format='%ad %ae %s' 2020-05-07 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-05-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 daed369cfdb6..101da7573691 (16 commits) 2020-05-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 3e771a1c..207cebd2 (418 commits) 2020-05-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader baa10d7b1dee..08afdde7726c (4 commits) 2020-05-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/dawn 0abddd21c9ad..e8bf706d161d (6 commits) Created with: gclient setdep -r src/third_party/skia@e3d1de7c5281 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bsalomon@google.com Change-Id: I6a5f30e55d4aef112c6234e0c0272e774e73a54c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186540Reviewed-by:
-
dpapad authored
Specifically: - CookieDataSummaryItem was partially incorrect, and also resided in a UI element, instead of residing in local_data_browser_proxy.js, where the data it describes actually comes from. - LocalDataItem was entirely incorrect - Deleted CookieDataSummaryItem, and fixed LocalDataItem to be the correct one (matching what actually is passed back from C++) These were discovered in the process of adding JS type checking for all_sites_test.js Bug: 1000989 Change-Id: I2e39b447f8de1cc5fb60cbf02af23839f25bd211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185576 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#766344}
-
chromium-autoroll authored
fuchsia/third_party/aemu/linux-amd64/+log/u-v5J.....MeLYn... Created with: gclient setdep -r src/third_party/aemu-linux-x64@MeLYn... If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: chonggu@google.com Change-Id: Id7793cb82a687138ae5e5c5f18544508862827db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187362Reviewed-by:
-
Tiancong Wang authored
In crrev.com/c/2173581, we increased the amount to make sure all the Chrome OS CQ builders can pass. However after we remove the workaround in the wrapper, Chrome builders start to fail, so we need to increase the token yet again, because at this point it's hard to tell which file causes the problem. BUG=chromium:1079053 TBR=thakis@chromium.org TEST=None Change-Id: Ie8a5b577fa930a2df287fa36c501f7ce5b6debee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186356 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Auto-Submit: Tiancong Wang <tcwang@google.com> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#766342}
-
Kent Tamura authored
When an OPTION element is added to an OPTGROUP element, HTMLOptGroupElement::ChildrenChanged() is responsible to notify it to the OPTGROUP's owner SELECT element. The function checks existence of the owner SELECT first, but it failed because of the wrong implementation of HTMLOptGroupElement::OwnerSelectElement(). This CL fixes OwnerSelectElement(). Bug: 1077556 Change-Id: If1bd4dbd022954c6caa55a8e44d3a31e2994b55b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186786 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "5142012-1.html" to utilize |selection_test()| and renames to "unlink_with_div.html" for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: I43838e8541fa06c4abebbe7771ac4ffe759dcfad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186835 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#766340}
-
Alice Wang authored
This CL replaces SigninTestUtil by AccountManagerTestRule to mock the signin environment in HistoryActivityScrollingTest. The latter is simpler and less flaky. Bug: 1078342 Change-Id: I4343369b9423fb8ad71e835f10388dd17d250e12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2184910 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#766339}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8789cfc7a5bc..459d7cc439a1 Created with: gclient setdep -r src-internal@459d7cc439a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC noel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: noel@google.com Change-Id: I48ea9b29a9b63897a651db8a4280ce51fdfd4ddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186542Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#766338}
-
Clemens Arbesser authored
For now, this is simply a smoke test that opens the edit dialog for a server card and verifies that this does not break the client. b/155624806 tracks progress for adding a more elaborate test, this CL is merely to get the effort started. Bug: b/155624806 Bug: b/153498495 Change-Id: I02cdef5115d011748410b72de38913c2cb262ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2179883Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#766337}
-
Sujie Zhu authored
We update GetCreditCardObfuscatedNumber to GetCreditCardIdentifierString which uses CardIdentifierStringForAutofillDisplay() and is only used in iOS settings page. The GetCreditCardIdentifierString will return 'Nickname - ****2345' if nickname is enabled and available; otherwise, fall back to current pattern 'IssuerNetwork - ****2345'. Note that we have verified that long nicknames will be auto-wrapped into multiple lines. And we won't update the 'Edit Credit Card' page, we still display full card number for local card, network+last four for server card. Here is the local test video (googlers only): https://drive.google.com/file/d/1maQqdy0XTj_pd1O_JTKsLRJ2BJhoY2a7/view?usp=sharing Bug: 1059087 Change-Id: I68e56dc7d94c04fedb9087bcd199aa79e396c141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2184747 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#766336}
-
Eugene But authored
Make all variables in crw_web_controller_unittest.mm follow C++ Style Guide inside C++ code. Bug: None Change-Id: Ic5a1d3978ab63edb2f52904369e7eb56f64072b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2184742 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/101da7573691..e7d27705e160 git log 101da7573691..e7d27705e160 --date=short --first-parent --format='%ad %ae %s' 2020-05-07 jiajie.hu@intel.com Fix corruption when changing the base level of a framebuffer texture attachment Created with: gclient setdep -r src/third_party/angle@e7d27705e160 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: Ic18130d47043c874c26d77e0bb332c248497ac4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186545Reviewed-by:
-
Frank Liberato authored
player. This CL moves the id into the shared log record, so that all cloned logs share the same id. Without this, cloned logs will create a new player in chrome://media-internals . MediaLog: :Clone() should produce a log that refers to the original Change-Id: I1f7fd6a269f9d00de24489fa4d4ccd8c794faa13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185805 Commit-Queue: Frank Liberato <liberato@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Auto-Submit: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#766333}
-
