GitLab

The CSSWG resolved about it in the last meeting:
https://github.com/w3c/csswg-drafts/issues/2746

BUG=843329
TEST=external/wpt/css/css-contain/contain-size-012.html

Change-Id: Ibb037f9ab1b95bed03e46fdbeb0e68520ff741b4
Reviewed-on: https://chromium-review.googlesource.com/1100824Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#567289}

The test tries to symbolize Chromium Framework independently, so the outer executable's
rpath isn't on the stack. The Framework does have an rpath in component builds, but
it is currently os.path.join(5 * ['..']), which relative to
out/Release/Chromium.app/Contents/Versions/69.0.3456.0/Chromium Framework.framework/Versions/A
gets us to out/Release/Chromium.app/Contents.  That doesn't seem useful for anything
(from what I can tell, it's always been this way since at least the gn switch),
so use 7 * ['..'] instead to get to the build dir.

This possibly fixes a regression from the ancient https://codereview.chromium.org/2700013002

Bug: 850055
Change-Id: I9e65a7fa76620539b2492fd6096b70533a523a74
Reviewed-on: https://chromium-review.googlesource.com/1101064
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567288}

TimeTicks are less confusing than double (which can be variously seconds
and milliseconds).

Change-Id: I70badbc63c8f8a1c8226f50b5ccb7d70d8209314
Reviewed-on: https://chromium-review.googlesource.com/1099370Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567287}

LocalDataContainer is owned by a unique_ptr in CookiesTreeModel but
it is created from the outside and passed as a raw pointer.
Fix this by directly creating it as a unique_ptr.

Change-Id: I11dadcd91359f2b07f8d021fa3daa62dde80711f
Reviewed-on: https://chromium-review.googlesource.com/1100832
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567286}

TBR=rdevlin.cronin@chromium.org

Bug: 851655
Change-Id: Ie13d383c007d206aa120e2993fe4f93e4ee6e407
Reviewed-on: https://chromium-review.googlesource.com/1100901
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567285}

Adds --manual-symbol-offsets, --manual-libname and --manual-objdir to
the orderfile generator, allowing custom profiling. For example, with
this one can easily collect profile information manual, process it with
phased_orderfile.py, and then use the resulting symbol lists to produce
a properly patched orderfile that is suitable for performance comparison
against the production orderfile.

Bug: 758566
Change-Id: I0e41319dfcd537cd7f076e0236dc96b853dd7a4f
Reviewed-on: https://chromium-review.googlesource.com/1095274Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567284}

Tests that can be expressed as LayoutTests (preferreably Web Platform
Tests) rather than browser tests should. Browser tests are slow to run
and a maintenance burden.

The WebRtcRtpBrowserTests are mainly testing behaviors of adding and
removing tracks/streams and asserting that the expected outcomes.

- The essentials of these tests are already covered in
  external/wpt/webrtc/ which we are actively maintaining and updating in
  preparation for Unified Plan and RTCRtpTransceiver support. Almost all
  of it is overlapping.
- The WebRtcRtpBrowserTests were not written to test behaviors, but
  functions. Each test is asserting a lot of unrelated behaviors.
- When running with Unified Plan/RTCRtpTransceiver (WIP CL:
  https://chromium-review.googlesource.com/c/chromium/src/+/1025771)
  these tests start failing. I started updating these tests but the
  failures were due to Plan B assumptions (problems in the tests, not in
  the implementation).
- Debugging this part of the code is slow and cumbersome.
- I won't miss any of these tests.

Conclusion: Nuke it.

Bug: 773472, 777617
Change-Id: I099992f1783914d4fb1d5c2d952ff977ec4cc513
Reviewed-on: https://chromium-review.googlesource.com/1100891Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567283}

https://skia.googlesource.com/skia.git/+log/f018b7d607a0..8760e2f42857


git log f018b7d607a0..8760e2f42857 --date=short --no-merges --format='%ad %ae %s'
2018-06-14 jvanverth@google.com Add outline concave shadow support


Created with:
  gclient setdep -r src/third_party/skia@8760e2f42857

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=csmartdalton@chromium.org

Change-Id: I71a1f925f875fe77e05837d9b96eb0c6f6b00d79
Reviewed-on: https://chromium-review.googlesource.com/1100917Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567282}

Added LoadingErrorPage flag to NavigationContext to mark
LoadHTMLString: navigations which feed Error page to
WKWebView. These navigations will be ignored in
WKWebViewNavigationDelegate callbacks.

GoBackFromErrorPage and testGoBackFromErrorPage tests were
updated to cover this test case.

Bug: 725241
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1a38685d96997328c4be2a250dcedb5837e76d77
Reviewed-on: https://chromium-review.googlesource.com/1093515Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567281}

A result looks crowded with a tab switch button. The spec asks that
we use the two line format if the tab switch button is present.

This CL also expands the button to 32px, per spec.

Bug: 780835
Change-Id: I372cb24646bdd448497f0bcf456d383a04a8a55b
Reviewed-on: https://chromium-review.googlesource.com/1087754
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567280}

Bug: 810833
Change-Id: Ia001570d879a714c0002c2270ff8273bf046f508
Reviewed-on: https://chromium-review.googlesource.com/1097228Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567279}

This CL fixes an issue where if GPU process initialization fails and
then GPU process crashes we end up incrementing the wrong UMA histogram
and recent crash count. This happens because when the GPU process
initialization fails we do a GPU mode fallback, eg. disable hardware
aceleration or SwiftShader, which modifies values in
GpuDataManagerImplPrivate. When the GPU process crashes, it checks the
values in GpuDataManagerImplPrivate that were already changed.

For example, if hardware acceleration was tried and GPU process
initialization fails then hardware acceleration will be disabled from
GpuProcessHost::DidFailInitialize(). When the GPU process crashes,
GpuProcessHost::RecordProcessCrash() will increment the SwiftShader UMA
and recent crash count instead of hardware accelerated UMA and crash
count.

Add GpuMode which tracks this information and have GpuProcessHost store
this on initialization. This way the same UMA histograms are incremented
on launch and crash. Also make sure after DidFailInitialize() that
RecordProcessCrash() doesn't also trigger GPU mode fallback.  Move the
fallback logic into GpuDataManagerImplPrivate::GpuModeFallback() to
ensure it's the same for all cases.

Change Chrome OS to also LOG(FATAL) if GPU process crashes too many
times or fails to initialize. Chrome OS always crashed in this case, it
would just crash later in GpuProcessTransportFactory. Also increase max
crashes for Chrome OS from 3 to 6 to match Android.

Bug: 852063
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I6870d0d877cdc2766d54428f90517c34cbd54343
Reviewed-on: https://chromium-review.googlesource.com/1099721
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567278}

Move ShowSigninScreenForTest from SigninScreenHandler to GaiaView, which
is the gaia/login-specific interface.

Bug: 851012
Change-Id: If01d1052341b670ca30ffece6bbbc00e981bc61a
Reviewed-on: https://chromium-review.googlesource.com/1093376Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567277}

Bug: 852016
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I99082e8eee6f4bb001bc2e7c396088475a772217
Reviewed-on: https://chromium-review.googlesource.com/1100339
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567276}

Previously, there was a race condition. The ondemand update could be
requested before the component was registered.

Bug: 851666
Change-Id: I5d2162a87748f93bdf902f78c8cbe63292d65201
Reviewed-on: https://chromium-review.googlesource.com/1097705
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567275}

The current logic in library_loader_hooks.cc for when to fork and
prefetch the native library has gotten complicated. This CL simplifies
it to current best practice: The prefetching is always done, restricted
to the ordered code if --orderfile-memory-optimization is set.

Bug: 758566
Change-Id: I86ecfff37b18eb7bda1edadfa5399db97b8be53e
Reviewed-on: https://chromium-review.googlesource.com/1095256Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567274}

Before this CL the test was constructing URLLoaderInterceptor too late -
after the RenderFrameHostImpl under test has already been created.  This
CL moves the creation of URLLoaderInterceptor (wrapped in
RequestInterceptor) slightly earlier.  After this CL the test passes
with and without NetworkService.

Bug: 846341
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I47fe27b55c341cdf87292a8aede8462921a9cbab
Reviewed-on: https://chromium-review.googlesource.com/1099971
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567273}

Remove PageSchedulerImpl::CreateFrameSchedulerImpl in favour of
FrameSchedulerImpl::Create and
PageSchedulerImpl::RegisterFrameSchedulerImpl.
This will allow to create subclasses of FrameSchedulerImpl in tests.

R=alexclarke@chromium.org

Change-Id: I401596bcae945a0039a8737cf795c13a19dd35e2
Reviewed-on: https://chromium-review.googlesource.com/1099071
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567272}

Bug: 852427
Change-Id: I6a397b8fa5e3d3013e69d7e55e50679dc27c875e
Reviewed-on: https://chromium-review.googlesource.com/1099178Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567271}

Adding some missing manifest and permission features that
ChromeVox needs on chromecast.

Bug: b/73383411
Test: None
Change-Id: I2d85e18fcec6dceb02dccec551838ebca418aaab
Reviewed-on: https://chromium-review.googlesource.com/1093272Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567270}

This is a follow-up from
https://chromium-review.googlesource.com/c/chromium/src/+/1089633

This CL adds a helper function which wraps UCKeyTranslate along with
some param conversions needed to call into it in a new helper function.
I've also updated all of the callsites which used UCKeyTranslate
directly to use the new helper function.

During the original CR, there was a suggestion to put the helper
method in ui/base/cocoa.  I've kept it in ui/events as referring
to ui/base from within ui/events was problematic.  Also ui/base
seemed like the wrong place given that this helper does work with
low level key event data and not higher level constructs.

BUG=832811

Change-Id: Iba6c78c846637afd74eb0256ac7e65dc3508d97a
Reviewed-on: https://chromium-review.googlesource.com/1097976
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567269}

In libaom CMake configuration:
-Wenum-conversion and -Wparentheses-equality are enabled by default
in clang and not explicitly disabled.
-Wunused-function is from CMake defaults and no longer disabled.
-Wsign-compare is explicitly enabled.

The symbol "_vpx_scaled_2d" is no longer present, so the bug that
required "-fno-common" should be resolved.

Bug: 783519
Change-Id: I099b89c3b418fb2cd50bc19af167deaf71f12a6c
Reviewed-on: https://chromium-review.googlesource.com/1100370Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#567268}

TBR=dsinclair@chromium.org

Bug: 808152
Change-Id: I006300209602701c98a5ce35e9d504c1347d8915
Reviewed-on: https://chromium-review.googlesource.com/1101059Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567267}

- Add explanatory text to each one
- Make the manual test path accessible to color blind testers
- Bring headers up to date
- Create a consistent style for :focus-visible and :focus:not(:focus-visible) for easier understanding of test results

Bug: 817199
Change-Id: I97191d5c8395576a42c923a025d05d2d61e79552
Reviewed-on: https://chromium-review.googlesource.com/1093697
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567266}

TBR=pkotwicz

Bug: 852648
Change-Id: I2799a73ecec82d9ceef99f0280655096ed2d3bdd
Reviewed-on: https://chromium-review.googlesource.com/1100890Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567265}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d791a8f5..4b7910b8

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I9087463c2cf16263098c3eba993719eb62086453
Reviewed-on: https://chromium-review.googlesource.com/1100741Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567264}

Bug: 841735
Change-Id: I86007d80dd719cd00c4b224d9f88479daa1bb422
Reviewed-on: https://chromium-review.googlesource.com/1101019Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567263}

Change-Id: Ideafaf71a790c28f88a7f514c3d0d4384bcd9f21
Reviewed-on: https://chromium-review.googlesource.com/1099608
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567262}

All annotation tests are activated for windows FYI bot,
win-annotator-rel.

Bug: 844014
Change-Id: I1b9762be6dcf759a74f4b7602b0ceae6b2873126
TBR: georgesak@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1100829
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567261}

The Device Service needs to clean up parts of its internal state as part
of browser shutdown. However, it also needs to run on the UI thread,
and embedded services that run on the UI thread are not guaranteed to
be destroyed as part of browser shutdown (tasks to destroy these
services are posted from the IO thread by
ServiceManagerConnectionImpl::ShutDownOnIOThread, but the UI thread is
typically shut down before these posted tasks are run).

To solve this issue we discussed adding plumbing wherein embedded
services could inform //content that they wanted to be notified when
shutdown was occurring on the main thread. However, on investigation
this plumbing would be painful to implement: it is only
EmbeddedInstanceManager that has direct information of these service
instances, and that object lives far away from //content's
ServiceManagerContext, the object that knows when shutdown is occurring
on the main thread.

This CL takes an alternative approach of having the Device Service
implementation observe the destruction of its MessageLoop. I have
verified that the observation is triggered on shutdown of Chrome.

Bug: 794105
Change-Id: I3b383871679d42f544812be4bcb13c872cf276ff
Reviewed-on: https://chromium-review.googlesource.com/1099245
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567260}

Tests for counting features are removed from the blink side because
there are browser side testing them, please see:
chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Tests for frame fetch context is removed, but there's still test
coverage in
chromium/src/chrome/browser/client_hints/client_hints_browsertest.cc

Tests for blink side use counter dropping ntp activities is no longer
needed as blink side use counter is being removed.

TBR: nhiroki@chromium.org
Bug: 849695, 790957
Change-Id: I32b0d01b768c7043fb01f2329cc089049126ed2b
Reviewed-on: https://chromium-review.googlesource.com/1087045
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567259}

Don't call into |fling_controller_| if it's destroyed.

Bug: 852264
Change-Id: I71081588f0b7e5bf882c28231e3d6b20026e4611
Reviewed-on: https://chromium-review.googlesource.com/1099145Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567258}

In case of range request, if server send unexpectedly
extra data, ignore it.

BUG=825829

Steps to reproduce:
1) Clear browser cache.
2) Open PDF:
http://www.major-landrover.ru/upload/attachments/f/9/f96aab07dab04ae89c8a509ec1ef2b31.pdf#page=55
3) Wait until document finish loading

Expected:
 The loading of document is finished
Actual:
 Some times the loading of document is never finished.

Change-Id: I46fc8001bea5701e1e93d26d1ea6527d4736ff05
Reviewed-on: https://chromium-review.googlesource.com/1094634Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Art Snake <art-snake@yandex-team.ru>
Cr-Commit-Position: refs/heads/master@{#567257}

Drive-by: minor lint/include fixes.

Bug: 852423
Change-Id: I7ae9b3d0bb74caaee133600eb9a88c93ff74d2ea
Reviewed-on: https://chromium-review.googlesource.com/1099166Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567256}

This fixes a bug that was introduced with 13ef1e88
While the first patch properly distinguished between the two when processing
local changes it failed doing so when processing remote changes (either
incremental or initial sync changes).

The issue surfaced when a preference got moved between regular and priority
sync preferences. In that scenario, sync has values for that pref in each
flavour and one can overwrite the other.

Bug: 849523, 840332
Change-Id: Ib458c5863bc036dbb2a735ccacd52c6df2c118bb
Reviewed-on: https://chromium-review.googlesource.com/1099381Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567255}

Bug: 843511
Change-Id: I946798560e0ba54d22123d86c90507e0d9c9c7da
Reviewed-on: https://chromium-review.googlesource.com/1099430Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567254}

There are several places where we query the keyboard bounds by
grabbing the keyboard container window and calling |bounds|. However,
it's unclear whether they mean the bounds relative to parent or bounds
relative to the screen, since both are currently the same for the
keyboard container.

This patch changes several callers to use |GetBoundsInScreen| since
they actually want the screen bounds. Note we don't change any behaviour
since currently keyboard container |bounds| == |GetBoundsInScreen|, but
this will change in future when we get rid of keyboard container.

Bug: 849980
Change-Id: I7211073a7697f168824c127319dfc40e6888195a
Reviewed-on: https://chromium-review.googlesource.com/1098417
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567253}

It passes on other versions, so keep running the test there.

Follow-up to https://chromium-review.googlesource.com/c/1099715/ and
https://chromium-review.googlesource.com/1098621

Bug: 852536
Change-Id: I42ffe80b4876ccc95be5f45d431d6c441fe11e73
Reviewed-on: https://chromium-review.googlesource.com/1100902Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567252}

TBR=charliea@chromium.org
NOTRY=true

Bug: 848900
Change-Id: I8fa3a3cad3515ec16ba19f558875be13910c902b
Reviewed-on: https://chromium-review.googlesource.com/1100960Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567251}

Its semantics were a bit weird: It got set on initial sign-in (i.e. not
during a Chrome restart), and cleared again once we updated the auth
error state: Either to an error, if we failed to get an access token or
got an error from the sync server, or to "no error", if we successfully
connected to the sync server.
It had only a single call site, which only used it to suppress auth
errors while waiting_for_auth was true. However, according to the
above, that's an impossible state: Sync can not be in an auth error
state *before* being signed in, and the waiting_for_auth bit is cleared
when actually entering an auth error state.

Bug: 839834
Change-Id: Iefbf54a93ede54aabb2a244b3e429b5591bb9934
Reviewed-on: https://chromium-review.googlesource.com/1099162Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567250}