GitLab

This is an optimization to make it so that we don't have to send
the whole results.json file down since the JSONResultsGenerator
needs this to figure out which tests it can strip. The only code
left that uses this is the Android fork of this code, which needs
to go away. So, I'm not OK with keeping this special-cased code
in the generic test results server just for that.

Deleting the code means that the requests will get the full
results.json file instead of the one with the results and times
stripped out.

TBR because this is causing 500s on the live server and that
push can't be rolled back without breaking other things.

TBR=szager@chromium.org

Review URL: https://codereview.chromium.org/463683002

git-svn-id: svn://svn.chromium.org/blink/trunk@180005 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There was a regression bug filed (bug 377445) shortly
after the original commit, however the author chose
not to revert, but rather instead attempt a fix.

The later of those fixes was marked not lgtm' by another
reviewer.

I'm rolling out the whole mess to unblock shipping M37.

R=eae
BUG=377445

Review URL: https://codereview.chromium.org/459153002

git-svn-id: svn://svn.chromium.org/blink/trunk@180004 bbb929c8-8fbe-4397-9dbb-9b2b20218538

deprecated_master would be referenced before assignment when
uploaded with the chromium.linux style master name.

TBR since I had to push this already to fix the broken push
and rolling back wasn't an option.

TBR=szager@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/462883002

git-svn-id: svn://svn.chromium.org/blink/trunk@180003 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When using overtype mode in content editable content we usually replace the
caret by a block cursor that covers the next character to be replaced.
However at the end of lines we should show the 'normal' blinking caret. In
those cases we were incorrectly adding a selection block till the end of the
container of the editable content.

That's because we were using a complicated (and wrong) way to detect the end
of lines based on modifying the internal selection used by the overtype
mode. We now use the proper tools to detect the end of line detection which
also supports bidi text.

BUG=385003

Review URL: https://codereview.chromium.org/437843002

git-svn-id: svn://svn.chromium.org/blink/trunk@180002 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Code to set the flag was removed as part of debugging crbug.com/378444
but this causes ports to report as "in use" for some time after the
test server stops, meaning that re-running layout tests with only a
short delay may fail.

Restore setting the flag, but scoped to non-Windows systems.

BUG=378444
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/464543003

git-svn-id: svn://svn.chromium.org/blink/trunk@180001 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/459083002

git-svn-id: svn://svn.chromium.org/blink/trunk@180000 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We did not have any test coverage on :host-context and targeted style
recalc. Added a few tests.

R=chrishtr@chromium.org,esprehn@chromium.org

Review URL: https://codereview.chromium.org/458943002

git-svn-id: svn://svn.chromium.org/blink/trunk@179999 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reason for revert:
Caused 10-50% performance regressions on svg, see http://crbug.com/402133.

Original issue's description:
> [SVG2] Make transform, gradientTransform and patternTransform presentation attributes.
>
> Spec:
> http://www.w3.org/TR/css3-transforms/#svg-transform
> http://www.w3.org/TR/css3-transforms/#svg-syntax
> http://www.w3.org/TR/css3-transforms/#svg-gradient-transform-pattern-transform
>
> BUG=369942
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179702

TBR=dschulze@chromium.org,ed@opera.com
NOTREECHECKS=true
BUG=369942

Review URL: https://codereview.chromium.org/459053002

git-svn-id: svn://svn.chromium.org/blink/trunk@179998 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Move remaining ui.js functionality into existing classes and elements.

BUG=400393
NOTRY=true

Review URL: https://codereview.chromium.org/459983002

git-svn-id: svn://svn.chromium.org/blink/trunk@179993 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In PageAnimator, it's possible frame tree has been mutated by
Javascript. To avoid this, we iterator through documents collection
instead, and check whether they are still present in their frames.

This was part of CL 214953004, which got reverted in 335103004 when it
caused crbug.com/383946. So I am adding back the reverted CL in parts.
This part should be only related to crbug.com/359028.

BUG=359028

Review URL: https://codereview.chromium.org/463493004

git-svn-id: svn://svn.chromium.org/blink/trunk@179992 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When we stopped storing the mediaType as a string on m_medium on StyleResolver, 
we started calling FrameView::mediaType() every time that the mediaType as required.
In the related bug's test case, mediaType() was being called a lot, 
in order to compare it to "print" to see which default style sheet should be used.
Since mediaType() calls also call InspectorInstrumentation::applyEmulatedMedia(), 
they have a certain overhead, that impacted the benchmark's results.

I've changed it so that the mediaType() call and the comparison to "print"
would be done once, and the result cached.

BUG=394275

Review URL: https://codereview.chromium.org/405953002

git-svn-id: svn://svn.chromium.org/blink/trunk@179991 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL makes RenderLayer::hasVisibleContent ASSERT that the state it reads
isn't dirty. This CL also fixes a couple callers that were reading the state
while it was dirty.

R=skobes@chromium.org

Review URL: https://codereview.chromium.org/453113002

git-svn-id: svn://svn.chromium.org/blink/trunk@179990 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit 25a48eab31ad4f0a54bcaea1ead2b0cc4dec74d2 [1]
with the exception of the changes in RenderFlowThread which have
additional changes on top of them and do not cleanly revert.

This is a speculative rollout, see crbug.com/402059.

[1] https://src.chromium.org/viewvc/blink?view=rev&revision=179521

BUG=402059
TBR=leviw
NOTRY=true

Review URL: https://codereview.chromium.org/463633002

git-svn-id: svn://svn.chromium.org/blink/trunk@179989 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I've switched from using requestAnimationFrame to setTimeout because:

1. requestAnimationFrame will cause timeouts if the tab is in the background while the tests are running
2. setTimeout is less verbose, since we can just pass the function name itself (requestAnimationFrame calls the function with a parameter, which would break the "done" function, so we have to wrap it in an anonymous function)

BUG=40038
R=ojan@chromium.org,esprehn@chromium.org

Review URL: https://codereview.chromium.org/462453002

git-svn-id: svn://svn.chromium.org/blink/trunk@179988 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=179974

BUG=402493
TBR=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/465623003

git-svn-id: svn://svn.chromium.org/blink/trunk@179987 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove the above #ifdef, unused now that crrev.com/288436 has landed.

BUG=281516

Review URL: https://codereview.chromium.org/461693002

git-svn-id: svn://svn.chromium.org/blink/trunk@179986 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/456413003

git-svn-id: svn://svn.chromium.org/blink/trunk@179985 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=376194
TBR=yurys

Review URL: https://codereview.chromium.org/464543002

git-svn-id: svn://svn.chromium.org/blink/trunk@179982 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=None
TEST=blink_tests
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/454353002

git-svn-id: svn://svn.chromium.org/blink/trunk@179981 bbb929c8-8fbe-4397-9dbb-9b2b20218538

And call the new functions: SetUpBlinkTestEnvironment() and
TearDownBlinkTestEnvironment().

BUG=None
TEST=webkit_unit_tests
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/461443002

git-svn-id: svn://svn.chromium.org/blink/trunk@179977 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We had an explicit list of these folks for modules,
but given that these individuals are charged with
Blink's long-term stewardship, it makes sense that
they should be able to review all changes across
Blink's source.

This also makes this list publicly documented
which we had failed to do so in the past.

R=abarth@chromium.org, dglazkov@chromium.org

Review URL: https://codereview.chromium.org/441083002

git-svn-id: svn://svn.chromium.org/blink/trunk@179975 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Skia's SkMatrixConvolutionImageFilter expects its "bias" parameter
to be in pixel component scale (ie., 0 = none, 255 = full), whereas
FEConvolveMatrix uses normalized scale. Scale by 255 to please Skia.

BUG=402493

Review URL: https://codereview.chromium.org/465503002

git-svn-id: svn://svn.chromium.org/blink/trunk@179974 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Follow-up to
  https://codereview.chromium.org/425953002/
addressing some late comments.

BUG=397909

Review URL: https://codereview.chromium.org/462613004

git-svn-id: svn://svn.chromium.org/blink/trunk@179971 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/451993003

git-svn-id: svn://svn.chromium.org/blink/trunk@179970 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Calling writePixels on a canvas using DisplayList2DCanvas was ignoring the call (canvas.pixels == null)
To make this work, we need to fallback to a raster canvas to be able to directly access the canvas' pixels.

To be more consistent, the method willReadback has be renamed to willAccessPixels.

Fixes the following layout-tests with --enable-display-list-2d-canvas:
  fast/canvas/canvas-imageSmoothingEnabled.html [ Failure ]
  fast/canvas/canvas-putImageData.html [ Failure ]
  fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgb565.html [ Failure ]
  fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba4444.html [ Failure ]
  fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba5551.html [ Failure ]
  fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html [ Failure ]
  fast/canvas/canvas-imageSmoothingEnabled-patterns.html [ ImageOnlyFailure ]

BUG=401624

Review URL: https://codereview.chromium.org/455863002

git-svn-id: svn://svn.chromium.org/blink/trunk@179969 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Adding a inline helper function in SkiaUtils.h to hide the cast of WebCore Windrule to SkPath::FillType

Review URL: https://codereview.chromium.org/453233002

git-svn-id: svn://svn.chromium.org/blink/trunk@179968 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=jbroman

Review URL: https://codereview.chromium.org/459843002

git-svn-id: svn://svn.chromium.org/blink/trunk@179966 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Revert of DevTools: Introduce module initializers (https://codereview.chromium.org/458753003/)

Reason for revert:
Un-reverting at request of patch author.

Original issue's description:
> Revert of DevTools: Introduce module initializers (https://codereview.chromium.org/451713002/)
> 
> Reason for revert:
> Breaks android_aosp bot and prevents Blink roll.
> 
> http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/4536/steps/compile/logs/stdio
> 
> make: *** No rule to make target `out/target/product/generic/obj/GYP/shared_intermediates/resources/inspector/documentation/DocumentationView.js', needed by `out/target/product/generic/obj/GYP/shared_intermediates/devtools/devtools_resources.grd'.  Stop.
> 
> 
> Original issue's description:
> > DevTools: Introduce module initializers
> > 
> > For all lazy-loaded modules and workers, _module.js files are introduced, which
> > importScript() all scripts for a particular module.
> > 
> > This allows to:
> > - get rid of importScript() calls intertwined with meaningful code,
> > - simplify module loading, since Runtime does not need to read the
> >   module descriptor to determine the resource names.
> > 
> > This approach is similar to how we implement
> > the CSS loading in inspector.css.
> > 
> > R=pfeldman, vsevik
> > BUG=391566
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179948
> 
> TBR=pfeldman@chromium.org,vsevik@chromium.org,lushnikov@chromium.org,eustas@chromium.org,apavlov@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=391566
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179963

TBR=pfeldman@chromium.org,vsevik@chromium.org,lushnikov@chromium.org,eustas@chromium.org,apavlov@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=391566

Review URL: https://codereview.chromium.org/459833002

git-svn-id: svn://svn.chromium.org/blink/trunk@179965 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=398787

Review URL: https://codereview.chromium.org/462603002

git-svn-id: svn://svn.chromium.org/blink/trunk@179964 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reason for revert:
Breaks android_aosp bot and prevents Blink roll.

http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/4536/steps/compile/logs/stdio

make: *** No rule to make target `out/target/product/generic/obj/GYP/shared_intermediates/resources/inspector/documentation/DocumentationView.js', needed by `out/target/product/generic/obj/GYP/shared_intermediates/devtools/devtools_resources.grd'.  Stop.


Original issue's description:
> DevTools: Introduce module initializers
> 
> For all lazy-loaded modules and workers, _module.js files are introduced, which
> importScript() all scripts for a particular module.
> 
> This allows to:
> - get rid of importScript() calls intertwined with meaningful code,
> - simplify module loading, since Runtime does not need to read the
>   module descriptor to determine the resource names.
> 
> This approach is similar to how we implement
> the CSS loading in inspector.css.
> 
> R=pfeldman, vsevik
> BUG=391566
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179948

TBR=pfeldman@chromium.org,vsevik@chromium.org,lushnikov@chromium.org,eustas@chromium.org,apavlov@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=391566

Review URL: https://codereview.chromium.org/458753003

git-svn-id: svn://svn.chromium.org/blink/trunk@179963 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=402431

Review URL: https://codereview.chromium.org/458963002

git-svn-id: svn://svn.chromium.org/blink/trunk@179962 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Drive-by: fix highlighting in CPU profiles.

BUG=

Review URL: https://codereview.chromium.org/460543002

git-svn-id: svn://svn.chromium.org/blink/trunk@179961 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL is a split from https://codereview.chromium.org/457483002/.
This CL supports private scripts in partial interfaces.

Assume that XPartial-1 and XPartial-2 are partial interfaces of X.
Then we have XPartial-1.js, XPartial-2.js and X.js.
When a DOM attribute/method in any of the JS files is requested
at the first time, all of the JS files are compiled at the same time.

This is redundant because when a DOM attribute/method in XPartial-1.js
is requested, we just need to compile XPartial-1.js and X.js.
I'll address the issue in a follow-up CL.

BUG=341031
TEST=fast/dom/private-script-unittest.html

Review URL: https://codereview.chromium.org/454773002

git-svn-id: svn://svn.chromium.org/blink/trunk@179960 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes unnecessary blink:: prefixes.
Also it merges *namspace blink{}* blocks.

BUG=

Review URL: https://codereview.chromium.org/462613002

git-svn-id: svn://svn.chromium.org/blink/trunk@179959 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=235436

Review URL: https://codereview.chromium.org/460673002

git-svn-id: svn://svn.chromium.org/blink/trunk@179958 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=396086

Review URL: https://codereview.chromium.org/456363002

git-svn-id: svn://svn.chromium.org/blink/trunk@179957 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=363976

Review URL: https://codereview.chromium.org/431273005

git-svn-id: svn://svn.chromium.org/blink/trunk@179956 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When a private script throws an exception, what the private script binding does is:

- if the exception is the one supported in private scripts,
the private script binding clones the exception in the user's script and throws it.

- if the exception is the one not (yet) supported in private scripts,
the private script binding dies.

Since these operations are done explicitly, we should use ReThrow()
instead of relying on V8TryCatchRethrowScope. (V8TryCatchRethrowScope is not
a proper mechanism for doing this because V8TryCatchRethrowScope is intended
to be used to rethrow an exception the way it is without doing any conversion.)

BUG=341031

Review URL: https://codereview.chromium.org/461593002

git-svn-id: svn://svn.chromium.org/blink/trunk@179955 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/462653002

git-svn-id: svn://svn.chromium.org/blink/trunk@179954 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This uses the "date" given in the http://auto-sheriff.appspot.com/data page to
show how recent the failure information is.

I intend to add some styling when the data is more than 5 minutes old, but I'm
pretty new to Polymer and want to make sure this is on track first.

BUG=399712
NOTRY=true

Review URL: https://codereview.chromium.org/453543002

git-svn-id: svn://svn.chromium.org/blink/trunk@179953 bbb929c8-8fbe-4397-9dbb-9b2b20218538