GitLab

std::max and std::min requires algorithm header.

BUG=

Review URL: https://codereview.chromium.org/117903005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243146 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243145 0039d316-1c4b-4281-b951-d872f2087c98

We can now do this since we have stdint.h everywhere.

Leave the 64-bit types for now since they require more investigation.

Delete schar, since it's unused in Chromium.

R=brettw@chromium.org
BUG=138542

Review URL: https://codereview.chromium.org/117323010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243143 0039d316-1c4b-4281-b951-d872f2087c98

BUG=318865
TEST=unittests included
NOTRY=True

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240226

Review URL: https://codereview.chromium.org/106523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243140 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243139 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=164495:164505&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/125093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243138 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org, groby@chromium.org
BUG=none
TEST=smaller diff in next CL

Review URL: https://codereview.chromium.org/98693017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243137 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243136 0039d316-1c4b-4281-b951-d872f2087c98

R=reed@google.com

Review URL: https://codereview.chromium.org/110353006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243135 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=danakj@chromium.org

Review URL: https://codereview.chromium.org/102253009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243131 0039d316-1c4b-4281-b951-d872f2087c98

BUG=271439

Review URL: https://codereview.chromium.org/105893004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243129 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331798
TBR=navabi@chromium.org

Review URL: https://codereview.chromium.org/122223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243127 0039d316-1c4b-4281-b951-d872f2087c98

When capturing a perf profile on Android, disable hiding of kernel
pointer addresses to ensure we can symbolize kernel functions in the
resulting profile.

NOTRY=true

Review URL: https://codereview.chromium.org/125243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243126 0039d316-1c4b-4281-b951-d872f2087c98

The test harness flakiness was fixed with 115473002 and 114563002.  Turning these back on

BUG=326769
NOTRY=true

Review URL: https://codereview.chromium.org/106053009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243124 0039d316-1c4b-4281-b951-d872f2087c98

RST-ifying new landing page. Adding needed CSS. Renaming the original
index.html to sitemap.html.

R=binji@chromium.org

Review URL: https://codereview.chromium.org/113133015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243123 0039d316-1c4b-4281-b951-d872f2087c98

Add a new version of RenderViewImpl::didStartLoading() that takes a boolean
indicating whether the navigation is to the same document or a different
document. blink will call this new version in a later patch.

BUG=50298

Review URL: https://codereview.chromium.org/102563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243122 0039d316-1c4b-4281-b951-d872f2087c98

BUG=316496
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/105473007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243119 0039d316-1c4b-4281-b951-d872f2087c98

BUG=318879
R=ben@chromium.org

Review URL: https://codereview.chromium.org/98353008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243118 0039d316-1c4b-4281-b951-d872f2087c98

Replacing auto-generated left-nav with a manual left-nav for now.

R=binji@chromium.org

Review URL: https://codereview.chromium.org/123773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243114 0039d316-1c4b-4281-b951-d872f2087c98

- moves the implementation of CandidateView as a separate cc file.
- CandidateView is now a button to reduce the click handling.
- introduces canceling drag logic over CandidateViews
- CandidateWindowView is now a BubbleDelegateView
- HidableArea is removed. It's not used anymore.
- removes complex GridLayout logic and use BoxLayout.

BUG=325813
R=komatsu@chromium.org
TEST=unit_tests pass, manually check

Review URL: https://codereview.chromium.org/121163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243106 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243104 0039d316-1c4b-4281-b951-d872f2087c98

PpapiHostMsg_ChannelCreated is used for two purposes:
  * Notifying the browser that a browser<->plugin channel has been created, and
  * Notifying that browser that a renderer<->plugin channel has been created.

In this case renderer<->plugin channel is for NaCl-based plugins, and is
special because it does some inspection of message contents and passes on the
message to the untrusted side of the plugin.

I've changed this because I think it makes the code easier to read, and I'm
adding an additional renderer<->plugin channel anyway.

BUG=
TBR=mseaborn,jschuh

Review URL: https://codereview.chromium.org/98183012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243101 0039d316-1c4b-4281-b951-d872f2087c98

This API follows the design at
https://docs.google.com/a/google.com/document/d/1rlwmFhf7VCX8mfrBok8wqXNgvr_ERhL2k6Fqha-pgIo/edit?disco=AAAAAHos8Y8#


It defines new objects for the consumption of media video tracks based on the private VideoSource/VideoDestination classes.

BUG=330851

Review URL: https://codereview.chromium.org/107083004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243099 0039d316-1c4b-4281-b951-d872f2087c98

Remove the speculative resource prefetching code. This was experimental code added 1.5 years ago and not used for the last year.

BUG=164207,304341
R=cbentzel@chromium.org

Review URL: https://codereview.chromium.org/117933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243098 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243097 0039d316-1c4b-4281-b951-d872f2087c98

R=reed@google.com

Review URL: https://codereview.chromium.org/124503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243096 0039d316-1c4b-4281-b951-d872f2087c98

Remove calls of PrerenderTracker::TryCancel in ChromeResourceDispatcherHostDelegate::HandleExternalProtocol. This short-circuited cancelling the prerendering on the IO thread. Instead, I moved cancelling the prerender on the UI thread since that calls ends up going to the UI thread right after.

BUG=304341
R=tburkard@chromium.org

Review URL: https://codereview.chromium.org/124393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243095 0039d316-1c4b-4281-b951-d872f2087c98

Remove calls of PrerenderTracker::TryCancel on UI thread and instead have them call PrerenderContents::Destroy directly.

This is part of the work on removing calls to ResourceRequestInfo::GetAssociatedRenderView. The last callers to that method are using it to cancel prerenders if they haven't been used yet, so the checking/cancelling needs to all move to the UI thread.

BUG=304341
R=tburkard@chromium.org

Review URL: https://codereview.chromium.org/109983006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243094 0039d316-1c4b-4281-b951-d872f2087c98

Originally PrerenderHelper was per RenderView. In r239860 I switched it to be per RenderFrame. Before PrerenderHelper was guaranteed to get the IPC telling it that it's prerendering before any navigation. After the change, the RenderFrame could be navigated by its parent frame before it gets the IPC that it's prerendering. This change ensures that there are no races by having a child frame check with its parent frame if it's pre-rendering at construction.

We haven't yet turned on RenderFrame per frame, but this is something could happen once we do.

BUG=304341
R=tburkard@chromium.org

Review URL: https://codereview.chromium.org/120263006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243093 0039d316-1c4b-4281-b951-d872f2087c98

Uninitialized read was fixed in r241862 and merged in r243089.

> Suppress uninitialized read in net::NetworkChangeNotifierWin::NetworkChangeNotifierWin due to incorrect initialization order
> 
> BUG=329590
> TBR=pauljensen@chromium.org
> 
> Review URL: https://codereview.chromium.org/118503002

TBR=bruening@google.com

Review URL: https://codereview.chromium.org/121603003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243092 0039d316-1c4b-4281-b951-d872f2087c98

The breakage appears to be introduced by this CL.
https://codereview.chromium.org/120773007

TEST=ninja -C out/Debug blink_tests
BUG=331719
NOTRY=true

Review URL: https://codereview.chromium.org/124863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243091 0039d316-1c4b-4281-b951-d872f2087c98

After migrating fullPaths/URLs to Entries in the gallery, it was assumed that the 'entries' and 'selectedEntries' arrays contain a common subset of Entries by meaning of same references for the same images.

However, when opening from the shelf, the selected image's Entry reference is not contained in the 'entries' array. Therefore, we have to lookup by urls instead of references. In general, we should never compare Entries by references.

TEST=Tested manually on the download shelf.
BUG=331735

Review URL: https://codereview.chromium.org/124923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243090 0039d316-1c4b-4281-b951-d872f2087c98

on a 32-bit-only system.

The server infrastructure should not deliver 64-bit-only updates to
32-bit-only systems, but this depends on the new -32bit tag suffix support
already being on the system prior to the attempted delivery of a 64-bit-only
update. The update installer will now sanity-check this, and if the system
will not be capable of running the updated version, it will exit before
attempting to install it. Additionally, it will set the -32bit tag suffix so
that during a subsequent update check, the server should deliver the proper
32-bit-only update (likely the final 32-bit version), or no update at all.

This also serves as a failsafe against breaking users on 32-bit-only systems
if the server-side -32bit tag suffix detection isn't working properly.

BUG=18323,303280
R=thakis@chromium.org, thakis

Review URL: https://codereview.chromium.org/124813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243088 0039d316-1c4b-4281-b951-d872f2087c98

And the fact that the user can leave fullscreen by pressing ESC but this
can be prevented by the developer by cancelling the event and requesting
a special permission.

BUG=320487

Review URL: https://codereview.chromium.org/116083008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243087 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243086 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=164488:164494&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/117903004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243085 0039d316-1c4b-4281-b951-d872f2087c98

These tests have been disabled on 2013-12-23 for being flaky.
http://crrev.com/242448 re-enabled one of the tests accidentally, and
it has been green ever since. Also, I failed to reproduce the symptoms
on ToT.

BUG=chromium:330454
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/123833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243083 0039d316-1c4b-4281-b951-d872f2087c98

R=dominikg@chromium.org,tonyg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/123593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243082 0039d316-1c4b-4281-b951-d872f2087c98

- Add ServiceWorkerHostMsg_WorkerStarted and ServiceWorkerHostMsg_WorkerStopped
  that are sent from embedded worker to the browser process
- Add ServiceWorkerContextMsg_FetchEvent for messages from embedded worker
  to the browser process

FetchEvent/FetchRequest code is a bit rough as it's meant to be
a placeholder.  I can remove the part from this CL if it doesn't
look reay yet.

The new code uses new IPC class (ServiceWorkerContextMsg) for dispatching
messages specifically sent to the embedded workers's worker context,
which may feel a bit noisy. (Alternative suggestions welcome)

BUG=313530
R=alecflett@chromium.org, jochen@chromium.org, tsepez@chromium.org

Review URL: https://codereview.chromium.org/118103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243081 0039d316-1c4b-4281-b951-d872f2087c98

Make it possible to use the Android screen recording profiler with
multiple connected devices. Only the screen on the device that is
actually running the telemetry test will get recorded.

BUG=331435
TEST=tools/perf/run_benchmark smoothness.key_mobile_sites \
--page-filter=linus --browser=android-content-shell \
--profiler=android-screen-recorder
NOTRY=true

Review URL: https://codereview.chromium.org/119323008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243080 0039d316-1c4b-4281-b951-d872f2087c98