GitLab

This prevents a crash when Chrome shuts down immediately and 
AppShimHostManager is destructed before InitOnFileThread is run.
Note this means AppShimHostManager can stay around longer than
BrowserProcessPlatformPart during initialization.

BUG=242941

Review URL: https://chromiumcodereview.appspot.com/20065004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221580 0039d316-1c4b-4281-b951-d872f2087c98

Originally, PreviewPanel is not used from any code.
This CL lets the FileManager class and the FileSelectorHandler class use the PreviewPanel class to control the visibility of preview panel.

BUG=284215
TEST=manually
R=yoshiki@chromium.org

Review URL: https://codereview.chromium.org/23464030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221579 0039d316-1c4b-4281-b951-d872f2087c98

As of version 2.7 Jinja2 depends on the MarkupSafe module.
http://jinja.pocoo.org/docs/intro/#markupsafe-dependency

We are already using Jinja2 v2.6 as a template engine for code generation
in Blink, and we'd like to upgrade it to v2.7.1, for various improvements.
MarkupSafe used to be part of Jinja2, but as of v2.7 has been factored into
a separate module, thus we need to add it separately.

For reference, MarkupSafe (and Jinja2) are also included as third-party libraries in Google App Engine.
https://developers.google.com/appengine/docs/python/tools/libraries27

Blocking:
Issue 23506004: Update Jinja2 (Python template library) to 2.7.1 + add OWNERS
https://codereview.chromium.org/23506004/

Source:
https://pypi.python.org/packages/source/M/MarkupSafe/MarkupSafe-0.18.tar.gz
MD5: f8d252fd05371e51dec2fe9a36890687
SHA-512:
0438ddf0fdab465c40d9afba8c14ad346be0868df654c11130d05e329992d456
a9bc278551970cbd09244a29c77213885d0c363c951b0cfd4d9aa95b248ecff5

Review URL: https://chromiumcodereview.appspot.com/23445019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221578 0039d316-1c4b-4281-b951-d872f2087c98

When logging an Action which refers to an incognito URL to the database
using the normal (non-testing) policy, clear the URL fields entirely.
Do not even leave an indication that an incognito URL had been present,
as was done previously.

This change was requested as part of the privacy review for the
extension watchdog.

BUG=244841

Review URL: https://chromiumcodereview.appspot.com/23432006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221577 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122863

Review URL: https://chromiumcodereview.appspot.com/23415002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221576 0039d316-1c4b-4281-b951-d872f2087c98

Allow individual web contents modal dialog users to specify that dialogs
should be closed when encountering interstitial webui (e.g. due to
SSL warnings).

Future CLs will enable use of this functionality for most dialogs. 

BUG=240575

Review URL: https://chromiumcodereview.appspot.com/23981002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221575 0039d316-1c4b-4281-b951-d872f2087c98

Matroska's specification of Opus has been standardized here:
http://wiki.xiph.org/MatroskaOpus. This CL adds support for the
new Matroska elements related to Opus and enables Opus playback
in WebM files through Media Source API. It also adds support for
end trimming.

This is a first CL in a sequence of CLs that will attempt to add
various features towards fully functional working of Opus in WebM
(both media source and video tag).

BUG=

Review URL: https://chromiumcodereview.appspot.com/23014009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221574 0039d316-1c4b-4281-b951-d872f2087c98

Constrained windows would get drawn partially outside the browser
window, obscuring some of the contents. This CL limits their size so
everything is in view. This mimics the behavior of the old style
dialogs.

This CL also changes the size request to use the current preferred size
of the view, instead of reusing the existing size. Some dialogs (like
the print preview) changes their size preferences when the browser
window size changes, so the old size might not be optimal any more.

Additionally, added a GetMinimumSize to the bubble frame view, as
previously GetPreferredSize would get used, effectively undoing the
additional restrictions placed based on Window sizes.

BUG=272760,274236,276150

Review URL: https://chromiumcodereview.appspot.com/22903022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221573 0039d316-1c4b-4281-b951-d872f2087c98

BUG=268937
TEST=OAuth2TokenServiceTest.SameScopesRequestedForDifferentClients
TBR=tim (for chrome/browser/sync)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221303

Review URL: https://chromiumcodereview.appspot.com/22581003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221572 0039d316-1c4b-4281-b951-d872f2087c98

BUG=286185
TBR=mef@chromium.org

Review URL: https://codereview.chromium.org/23874017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221571 0039d316-1c4b-4281-b951-d872f2087c98

Reading from procfs returns at most a page-sized amount of data. If the process has a larger-than-page-sized /proc/self/maps, we cannot guarantee that the virtual memory table hasn't changed while reading the entire contents from procfs.

In addition, ReadProcMaps() now stops reading as soon as it finds a gate VMA entry to workaround a scenario where the kernel would return duplicate entries (it turns out ThreadSanitizer v2 was very good at triggering said scenario).

BUG=258451

Review URL: https://chromiumcodereview.appspot.com/18661009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221570 0039d316-1c4b-4281-b951-d872f2087c98

This folder was created specifically to ensure infrastructure
team had visibility and veto before changes go live that can
negatively affect stability of production systems.

yfriedman and bulach were added because they are general android
owners and to ensure that minor changes do not get blocked.

> [android] Add frankf and craigdh to build/android/buildbot/OWNERS.
> 
> BUG=None
> TEST=None
> NOTRY=True
> 
> Review URL: https://chromiumcodereview.appspot.com/23129027

TBR=craigdh@chromium.org

Review URL: https://codereview.chromium.org/23567017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221567 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221565 0039d316-1c4b-4281-b951-d872f2087c98

Add an async signal safe version of SANDBOX_DIE().

BUG=277240
R=markus@chromium.org

Review URL: https://codereview.chromium.org/23461032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221558 0039d316-1c4b-4281-b951-d872f2087c98

Wires up Blink WebSettings introduced in
https://codereview.chromium.org/22909031 and then updated in
https://codereview.chromium.org/23691017

These quirks are to maintain compatibility with Android apps built on
the Android SDK prior to and including version 18. Presumably, this
can be removed any time after 2015.

BUG=277369,282130

Review URL: https://chromiumcodereview.appspot.com/23572016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221557 0039d316-1c4b-4281-b951-d872f2087c98

There's a line in screen_container.css that hardcodes a width of 1100px for body:not(.oobe-display) #inner-container 
(which applies to the account picker). Setting the right class to the outer container fixes this.

TBR=estade@chromium.org
BUG=257033

Review URL: https://chromiumcodereview.appspot.com/23774004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221556 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221555 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157170:157328&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/23453039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221554 0039d316-1c4b-4281-b951-d872f2087c98

R=jam@chromium.org

Review URL: https://codereview.chromium.org/23467011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221553 0039d316-1c4b-4281-b951-d872f2087c98

- EME API works on Chrome build.
- CanPlayType() is suppressed (returns "") by default.
- User can choose to override the CanPlayType() suppression with a flag
  "--override-encrypted-media-canplaytype".
- For Android "video/mp4" is supported, while "video/webm" isn't.

BUG=163552
TEST=Tested all scenarios listed above.
R=ddorwin@chromium.org

Review URL: https://codereview.chromium.org/23975003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221548 0039d316-1c4b-4281-b951-d872f2087c98

Also moves the count in to the Action class so the count is accessible.

BUG=255728

Review URL: https://chromiumcodereview.appspot.com/23449016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221546 0039d316-1c4b-4281-b951-d872f2087c98

mac-release/sizes/ChromiumFramework/ChromiumFramework: http://build.chromium.org/f/chromium/perf/mac-release/sizes/report.html?history=500&rev=221506&graph=ChromiumFramework

BUG=none
NOTRY=true
TBR=rmcilroy@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23514040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221545 0039d316-1c4b-4281-b951-d872f2087c98

> Pepper: Move FileRef to the "new" resource proxy.
> 
> This change moves the FileRef implementation from the previous one in the "old"
> resource model (ppb_file_ref_impl.cc) to the "new" resource model
> (pepper_file_ref_host.cc), and from the renderer to the browser.
> 
> As many as possible of the supporting changes were split off to other changes
> to minimize the size of this change. Unfortunately, a lot of changes for
> URLLoader had to be rolled into this change.
> 
> The data structures for CreateInfo have changed, and all users of FileRef have
> to be moved over, which is what causes this change to be so large.
> 
> TBR=dmichael@chromium.org, jschuh@chromium.org, yzshen@chromium.org
> BUG=225441
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216744
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218305
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219911
> 
> Review URL: https://codereview.chromium.org/21966004

TBR=teravest@chromium.org

Review URL: https://codereview.chromium.org/23647008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221544 0039d316-1c4b-4281-b951-d872f2087c98

This replaces the deprecated "fill_parent" with "match_parent", and
"dip" with the preferred "dp".

Review URL: https://chromiumcodereview.appspot.com/23648004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221542 0039d316-1c4b-4281-b951-d872f2087c98

This allows datatype SyncableServices to request a fresh copy of the data
that was previously only passed over in batch form during
MergeDataAndStartSyncing. Since it can be slow, it should be used
sparingly.

Though currently unused, Sessions will soon need this behavior to deal with
cases where (e.g) the local session is deleted by a foreign client, thereby
corrupting TabNodePool tracking and requiring a full re-association.

TBR=zea@chromium.org
^Many function signature touchups under browser/

BUG=98892

Review URL: https://codereview.chromium.org/23129007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221540 0039d316-1c4b-4281-b951-d872f2087c98

SIGSYS is a reserved signal on Linux for the seccomp-bpf sandbox.
If a previous handler for SIGSYS exists, log an error.

BUG=178166
R=markus@chromium.org

Review URL: https://codereview.chromium.org/23960006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221539 0039d316-1c4b-4281-b951-d872f2087c98

[telemetry] Make default flags passed to WebPageRelay overridable via --extra-wpr-args by placing them earlier on the command line.

Review URL: https://chromiumcodereview.appspot.com/23523017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221538 0039d316-1c4b-4281-b951-d872f2087c98

BUG=281244

Review URL: https://chromiumcodereview.appspot.com/23875002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221536 0039d316-1c4b-4281-b951-d872f2087c98

See bug for details.

BUG=285389

Review URL: https://chromiumcodereview.appspot.com/23706006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221535 0039d316-1c4b-4281-b951-d872f2087c98

BUG=284835

Review URL: https://chromiumcodereview.appspot.com/23653015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221534 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221533 0039d316-1c4b-4281-b951-d872f2087c98

The blink roll was causing ContentShell to crash on startup, and thus
causing tons of tests to fail. Reverting until a real fix lands in
blink.

This reverts commit 292464e4.

BUG=285973
R=aboxhall@chromium.org

Review URL: https://codereview.chromium.org/24010002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221532 0039d316-1c4b-4281-b951-d872f2087c98

This adds test coverage for the bug fixed by http://crrev.com/218391.

BUG=275810

Review URL: https://chromiumcodereview.appspot.com/23702023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221531 0039d316-1c4b-4281-b951-d872f2087c98

BUG=280562

Review URL: https://chromiumcodereview.appspot.com/23926004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221530 0039d316-1c4b-4281-b951-d872f2087c98

BUG=285339,285364

Review URL: https://chromiumcodereview.appspot.com/23874013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221529 0039d316-1c4b-4281-b951-d872f2087c98

BUG=285995
R=mnaganov@chromium.org

Review URL: https://codereview.chromium.org/23890006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221528 0039d316-1c4b-4281-b951-d872f2087c98

Add Error Console UI for install warnings to the chrome:extensions page (hidden behind the error console switch).

Snazzy Images: http://imgur.com/a/7QnMo#0 (updated 9/3)

BUG=21734

Review URL: https://chromiumcodereview.appspot.com/22938005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221527 0039d316-1c4b-4281-b951-d872f2087c98

Looks like this doesn't have to be a window property.
Changed to use a plain global flag.

BUG=272460
R=jamescook@chromium.org

Review URL: https://codereview.chromium.org/23625007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221526 0039d316-1c4b-4281-b951-d872f2087c98

Pexe files with the cache-control:no-store header should not be cached.
Add a field to the PnaclCacheInfo struct, plumb the value all the way
from the plugin to the browser, and treat it basically the same way we
currently treat incognito translations (since we currently don't have an
off-the-record cache for those).
R=jvoung@chromium.org
BUG=none, noticed this was missing when doing cleanup

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221275
Reverted due to iterator use-after-erase in patchset 4. fixed in 5. No idea why it passed the CQ so cleanly but blew up the buildbots so completely.

Review URL: https://chromiumcodereview.appspot.com/23458015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221525 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes the following bugs in the cellular APN setting UI.:

  1. The first time the user brings up the custom APN UI, the APN input field
     contents were being set to "undefined". Fixed this.
  2. After setting a custom APN, if the user ever reverted to the default APN,
     and if the default APN did not contain a username/password field, the
     username and password fields of the Cellular.APN property were being set
     to "undefined" and this was getting stored in the profile.
  3. The JS now caches the APN fields set by the user so that the user can now
     switch back and forth between the default and the selected APNs. Before,
     trying to select the user APN via the drop-down menu resulted in the wrong
     APN to be set.

BUG=282711
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/23629010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221524 0039d316-1c4b-4281-b951-d872f2087c98