GitLab

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/5965b73..bb4a1cf

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/1067853004

Cr-Commit-Position: refs/heads/master@{#324100}

This allows to have multiple Disabled group, e.g. Disabled/Disabled_control, and thus eases experimentation.

TBR=sky@chromium.org
BUG=465815

Review URL: https://codereview.chromium.org/1062243002

Cr-Commit-Position: refs/heads/master@{#324099}

In the past eglSwapBuffers used to return early, before the swap actually happened and descheduling in the driver. This resulted in the scheduler beginning the next frame early and hitting the page flip deadline in time more often.

Freon returns swap ack when page flip actually happened, but with the side effect of scheduling shifted forward, resulting in more missed vblanks and reduced performance.

This change restores original performance on freon.

BUG=465599

Review URL: https://codereview.chromium.org/1059503003

Cr-Commit-Position: refs/heads/master@{#324098}

http://crrev.com/1047223004 added experimental icon NTP support and
changed default "white-space: nowrap" to "white-space: pre-wrap", then
make current Material Design select the old one. This is broke 3rd-party
NTPs that don't have the same setting. This CL changes the defaults back,
and adds a new "ntl" to signal intent of having multiline titles. Also
updated single-iframe NTP to match.

BUG=474164

Review URL: https://codereview.chromium.org/1061163003

Cr-Commit-Position: refs/heads/master@{#324097}

BUG=

Review URL: https://codereview.chromium.org/1067003002

Cr-Commit-Position: refs/heads/master@{#324096}

Also ported gcd_client_unittests to use mock_xhr as a proof of concept,
but left original test as a supplement to xhr_unittests.

BUG=471928

Review URL: https://codereview.chromium.org/1055313002

Cr-Commit-Position: refs/heads/master@{#324095}

Move the implementation of doing power related actions from device_utils to battery_utils.

BUG=472763

Review URL: https://codereview.chromium.org/1067853003

Cr-Commit-Position: refs/heads/master@{#324094}

Adds a new junit_binary template for gyp which makes it easy to
make new Junit test suites by setting a lot of the options and
necessary dependencies for you.

Also, adds a new java_binary.gypi file which uses the
create_java_binary_script.py similiar to how the java_binary
GN template works when main_class is specified. This lets
GYP and GN work similiar when building a junit binary, so
our test runner can run them the same way.

Finally, because of the slightly different way were now running
the junit binary, the java classpath contains all of the jars
instead of just the test jar (before we were running
java -jar test_jar.jar which set the classpath to just be
test_jar.jar). Therefore, we can simplify things and just look
in the classpath for the paths to the Robolectric dependencies
when running Robolectric junit tests.

BUG=

Review URL: https://codereview.chromium.org/1057783002

Cr-Commit-Position: refs/heads/master@{#324093}

This test was invalid on modern glibc:
asprintf errors EOVERFLOW without attempting an allocation
when the size is at least INT_MAX - 32. INT_MAX - 33 is the
largest size that can attempt to trigger allocation failure,
and will not necessarily accomplish that on some systems.

Create a library that is specified to wrap malloc trivially,
to accomplish the goal of the test without external dependencies
or inconsistently implemented behavior.

BUG=428211

Review URL: https://codereview.chromium.org/1064793002

Cr-Commit-Position: refs/heads/master@{#324092}

BUG=

Review URL: https://codereview.chromium.org/1069033002

Cr-Commit-Position: refs/heads/master@{#324091}

BUG=467260

Review URL: https://codereview.chromium.org/1053423002

Cr-Commit-Position: refs/heads/master@{#324090}

BUG=424436,467287

Review URL: https://codereview.chromium.org/1068603002

Cr-Commit-Position: refs/heads/master@{#324089}

Revert of Reland Track memory consumption of SP on top 7 sites. (patchset #1 id:1 of https://codereview.chromium.org/1052843002/)

Reason for revert:
I think the original CL meant to make changes to memory.py, not run-perf-test.cfg. We shouldn't be submitting changes to run-perf-test.cfg, this file is used by the perf-try bots to pass try job parameters.

Original issue's description:
> Track memory consumption of SP on top 7 sites.
>
> Tests:
> android: https://codereview.chromium.org/1023783006/
> linux & mac: https://codereview.chromium.org/1013723006/
> win: https://codereview.chromium.org/1038773002/
>
> All above pass the "Running With Patch" step.
>
> BUG=None
>
> Committed: https://crrev.com/82b8e167143a5f0d4dd4515c6d0e14a64f654083
> Cr-Commit-Position: refs/heads/master@{#323680}

TBR=pdr@chromium.org,sullivan@chromium.org,prasadv@chromium.org,pan.deng@intel.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/1062253002

Cr-Commit-Position: refs/heads/master@{#324088}

BUG=474654

Review URL: https://codereview.chromium.org/1067903003

Cr-Commit-Position: refs/heads/master@{#324087}

This is a step towards unifying the various ways to "notify"
MemoryPressureListeners.

This also provides "GetCurrentPressureLevel" to a more general-purpose
place so we'll be able to use it on other platforms.
(Especially Windows, so we can use it in renderer_frame_manager).

See:
https://docs.google.com/a/chromium.org/document/d/1z3SR3JfKOwVaZxrsfHLOrPjo4-IVtnijaX86LKYPEQs/edit#
for more on the rationale and design, and
https://codereview.chromium.org/1045433002/
for what this might look like for ChromeOS's memory
monitor.

BUG=463546

Review URL: https://codereview.chromium.org/1048983006

Cr-Commit-Position: refs/heads/master@{#324086}

This CL adds methods to extract the content of a log in an external module
and import it to upload in the main application.

BUG=474625

Review URL: https://codereview.chromium.org/1030503003

Cr-Commit-Position: refs/heads/master@{#324085}

Now that Blink handles animated gifs, this code is not needed.

BUG=467197

Review URL: https://codereview.chromium.org/1061203002

Cr-Commit-Position: refs/heads/master@{#324084}

Previously, onPrefsChanged was a no op. This CL implements functionality for notifying listeners on the event when a pref has changed.

In the process:
- pull out shared logic into a prefs util namespace.
- simplify the whitelisting logic so there is only one GetWhitelistedPrefs method and not a CrOS-specific one.

BUG=468093

Review URL: https://codereview.chromium.org/1061613002

Cr-Commit-Position: refs/heads/master@{#324083}

BUG=267773

Review URL: https://codereview.chromium.org/1046343002

Cr-Commit-Position: refs/heads/master@{#324082}

Key releases enqueue a task on KeyboardEvdev that dispatches the release
ui::Event as well as cancels any scheduled repeats for that key. The
release itself is enqueued from the dedicated evdev thread and so can be
expected to arrive in a timely manner.

Unfotunately, due to the way base::Timer works, this is not robust when
the UI thread is very busy. The base::Timer object posts a delayed task,
and upon running checks to see if enough real time has passed (see
Timer::RunScheduledTask). If so, it runs the timer callback immediately.
This is fine, except that base::Timer also reuses scheduled tasks from
previous calls to Start() if they are still in the future (see
Timer::Reset). This can mean the timeout callback runs from a task that
was scheduled before the current timer was started.

The net effect of this is that the timer task may run first even if
(initial timer start + delay) > (key release task timestamp). The message
loop queue itself would have run the tasks in the correct order.

So, if we simply use PostDelayedTask() ourselves, there's no cleverness
in base::Timer to worry about and the tasks run in the needed order.

BUG=473446
TEST=Press Ctrl-W to close a tab with lots of activity (multiple copies
  of gmail loading, etc). Only one tab closes. Also tested with
  simulated jank (1s delay in tab closure).

Review URL: https://codereview.chromium.org/1052273006

Cr-Commit-Position: refs/heads/master@{#324081}

This uses a PaintRecorder to get at the canvas() for painting, instead
of grabbing it directly off PaintContext. This will allow PaintContext
to be backed by a DisplayItemList instead of a Canvas.

R=sadrul, sky
BUG=466426

Review URL: https://codereview.chromium.org/1064763002

Cr-Commit-Position: refs/heads/master@{#324080}

(Continuing from original cl https://codereview.chromium.org/1055893003 .)

Change IsMaximized() to return false if the window is in the dock, and
a unit test to make sure this is always the case. It turns out
-isZoomed can sometimes return YES for a docked window, which
sometimes results in the window becoming undocked on the next restart.
Please read the long entry in the bug report for a complete explanation
of how the change fixes the problem.

BUG=452976

Review URL: https://codereview.chromium.org/1062053002

Cr-Commit-Position: refs/heads/master@{#324079}

Remove various minor android_webview_build references now that we no
longer support that build configuration.

BUG=440793

Review URL: https://codereview.chromium.org/1048863002

Cr-Commit-Position: refs/heads/master@{#324078}

This CL brings the BackgroundSyncRegistration options up-to-date with the spec: https://github.com/slightlyoff/BackgroundSync/pull/74

TODO in followup CLs:
* Rename 'name' to 'tag': http://crrev.com/1068863003.
* Give periodic and one-shot tags their own namespaces in the map so that they don't conflict.

BUG=474573

Review URL: https://codereview.chromium.org/1068863002

Cr-Commit-Position: refs/heads/master@{#324077}

Add some tests for disabling/enabling/uninstalling extensions from the
chrome://extensions page. Since we don't have any, these will help us determine
if we break anything during the transition to observing events from the
developerPrivate API.

BUG=461039

Review URL: https://codereview.chromium.org/1063863004

Cr-Commit-Position: refs/heads/master@{#324076}

Added new histograms to break down Current bypasses (i.e. "Chrome-Proxy: block-once") by audio/video content types, as well as "content-type: application/octet-stream".

BUG=473763

Review URL: https://codereview.chromium.org/1048303004

Cr-Commit-Position: refs/heads/master@{#324075}

This adds font-lock regexps to match the three different embedded
variable syntaxes. I added faces for these constructs, and reorganized
variables so they're now all part of a group for custom.

BUG=none

Review URL: https://codereview.chromium.org/1057993003

Cr-Commit-Position: refs/heads/master@{#324074}

As per original implementation, our intention was to have fixed width for file in cache file.
For loading from registry we can load file name of any length.

BUG=472938
R=cpu

Review URL: https://codereview.chromium.org/1063893002

Cr-Commit-Position: refs/heads/master@{#324073}

Devices with some versions of the MediaTek MT8135 GPU driver do not
return values when an occlusion query is performed, which causes a
hard CHECK to get hit in GLES2Implementation::GetQueryObjectuivEXT.

This adds an entry to the GPU bug list for this device (which identifies
as PowerVR Rogue Han), preventing occlusion queries from being used on
affected devices and driver versions.

BUG=474413
TEST=OcclusionQuery.Occlusion

Review URL: https://codereview.chromium.org/1064773002

Cr-Commit-Position: refs/heads/master@{#324072}

The PaintContext will not be backed by a Canvas in the future, so do
not grab the canvas from it directly. Instead use a PaintRecorder.

R=oshima
BUG=466426

Review URL: https://codereview.chromium.org/1062003003

Cr-Commit-Position: refs/heads/master@{#324071}

Revert of Revert of Revert of Revert of Revert of Enable ServiceWorkerPerfTest (service_worker.service_worker) (patchset #1 id:1 of https://codereview.chromium.org/1055533003/)

Reason for revert:
This is still failing on Android1.

crbug.com/474658

Original issue's description:
> Revert of Revert of Revert of Revert of Enable ServiceWorkerPerfTest (service_worker.service_worker) (patchset #1 id:1 of https://codereview.chromium.org/1000273003/)
>
> Reason for revert:
> screenrecord is installed on Android One trybots.
> https://code.google.com/p/chromium/issues/detail?id=469841#c8
>
> Original issue's description:
> > Revert of Revert of Revert of Enable ServiceWorkerPerfTest (service_worker.service_worker) (patchset #1 id:1 of https://codereview.chromium.org/1027743004/)
> >
> > Reason for revert:
> > Failing on Android One perf bot which doesn't have "screenrecord".
> >
> > http://crbug.com/469841
> >
> > Original issue's description:
> > > Revert of Revert of Enable ServiceWorkerPerfTest (service_worker.service_worker) (patchset #1 id:1 of https://codereview.chromium.org/959793002/)
> > >
> > > Reason for revert:
> > > avconv is available on Nexus 10.
> > > https://code.google.com/p/chromium/issues/detail?id=433943#c37
> > >
> > > Original issue's description:
> > > > Revert of Enable ServiceWorkerPerfTest (service_worker.service_worker) (patchset #1 id:1 of https://codereview.chromium.org/954663002/)
> > > >
> > > > Reason for revert:
> > > > Failing on Nexus 10.
> > > >
> > > > Original issue's description:
> > > > > Enable ServiceWorkerPerfTest (service_worker.service_worker)
> > > > >
> > > > > I think https://codereview.chromium.org/884573004/ fixed the ServiceWorker test flakiness.
> > > > >
> > > > > BUG=433943
> > > > > TEST=./tools/perf/run_benchmark --browser-executable=~/chromium/src/out/Debug/chrome --also-run-disabled-tests service_worker.service_worker
> > > > >
> > > > > Committed: https://crrev.com/adaa44fc1275085c09fff18d8f2dfbddd88bc186
> > > > > Cr-Commit-Position: refs/heads/master@{#317807}
> > > >
> > > > TBR=falken@chromium.org,nednguyen@google.com,sullivan@chromium.org,horo@chromium.org
> > > > NOPRESUBMIT=true
> > > > NOTREECHECKS=true
> > > > NOTRY=true
> > > > BUG=433943
> > > >
> > > > Committed: https://crrev.com/6aa34fa4e41d77e92d86f3f0c5f80fab9bdda749
> > > > Cr-Commit-Position: refs/heads/master@{#318066}
> > >
> > > TBR=falken@chromium.org,nednguyen@google.com,sullivan@chromium.org,simonhatch@chromium.org
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=433943
> > >
> > > Committed: https://crrev.com/e3f37ac21edb64dcf805007a382aff9405642948
> > > Cr-Commit-Position: refs/heads/master@{#321759}
> >
> > TBR=falken@chromium.org,nednguyen@google.com,sullivan@chromium.org,simonhatch@chromium.org
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=433943
> >
> > Committed: https://crrev.com/7e894073084371a6c8c31827a0f0c9cdb37d4ed6
> > Cr-Commit-Position: refs/heads/master@{#321897}
>
> TBR=falken@chromium.org,nednguyen@google.com,sullivan@chromium.org,simonhatch@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=433943
>
> Committed: https://crrev.com/19bdfcf548e5d04bfa1357d4df742664d9d5dfa9
> Cr-Commit-Position: refs/heads/master@{#323261}

TBR=falken@chromium.org,nednguyen@google.com,sullivan@chromium.org,simonhatch@chromium.org,horo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=433943

Review URL: https://codereview.chromium.org/1064073002

Cr-Commit-Position: refs/heads/master@{#324070}

This makes the naming convention uniform with the other Media Router icons.

BUG=464222

Review URL: https://codereview.chromium.org/1053323003

Cr-Commit-Position: refs/heads/master@{#324069}

- Update some remaining tests to check both legacy and new system
- Add some missing coalescing rules in the new system

BUG=398257

Review URL: https://codereview.chromium.org/1042793003

Cr-Commit-Position: refs/heads/master@{#324068}

Updating App Remoting build files to include an OAuth2 client ID and manifest key which we will set in the manifest at build time.  This removes the need to run any scripts before uploading to the webstore.

Chromoting updates will be handled in a subsequent change (TODO added).

Also made a few changes to handle the new prod_testing environment.

BUG=

Review URL: https://codereview.chromium.org/1062963002

Cr-Commit-Position: refs/heads/master@{#324067}

This CL also sorts the "access token details by account" section of the
page by request time.

BUG=405038

Review URL: https://codereview.chromium.org/1058513002

Cr-Commit-Position: refs/heads/master@{#324066}

TBR=robertphillips@chromium.org
BUG=skia:3532

Review URL: https://codereview.chromium.org/1064943002

Cr-Commit-Position: refs/heads/master@{#324065}

This extracts logic that handles loading, initializing and handling
requests from web store widget out of SuggestAppsDialog.
What's left in SuggestAppsDialog is logic for showing/hiding the dialog
modal to file manager, and handling results from the widget.

The goal is to eventually remove the newly created class out of
ui/file_manager so it can be used to show Web Store widget for purposes
not related to file manager.

BUG=439448

Review URL: https://codereview.chromium.org/1068653002

Cr-Commit-Position: refs/heads/master@{#324064}

Properly handle the case of an "object" (one deliberately left undefined in the
idl/json), and fix an off-by-one error in the comment wrapping.
Add tests for each.

BUG=469920

Review URL: https://codereview.chromium.org/1062573004

Cr-Commit-Position: refs/heads/master@{#324063}

This is one of 3 changes that are required to complete conditionally running
benchmarks on CQ. The other two are adding post_upload_hooks to telemetry presubmit
and passing build_properties to run-bisect-perf-regression on buildbot.

BUG=462581

Review URL: https://codereview.chromium.org/1045553003

Cr-Commit-Position: refs/heads/master@{#324062}

This change should be a no-op as it keeps the DEPS'd revision
the same.  Rather than DEPSing it two sub-repos it simply
includes the since top level repo.

Once this change is in we can switch to using a github mirror
rather than an SVN mirror. Once that its done we can look
at rollin the DEPSs forward.

Also, include a temporary exclusion in checklicenses.py
to cover some .py files in the jsoncpp source that do
not contain a license.

BUG=472809

Review URL: https://codereview.chromium.org/1054753002

Cr-Commit-Position: refs/heads/master@{#324061}