- 11 Jul, 2018 14 commits
-
-
Wez authored
Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: If5cf7d3dcda8dc411c6c90de31885dca683354d8 Reviewed-on: https://chromium-review.googlesource.com/1130656Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#574006}
-
Scott Chen authored
By not including the entire svg sets from iron-icons/ the resulting md_extensions/vulcanized.html file size reduced from 232.8 kB to 144.4 kB. As a side clean-up thing, the "store" icon is removed from the icons.html since it's no longer used. Bug: 855205 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ia19bd8b61425cbff0e3d70cc08a1201856fe0276 Reviewed-on: https://chromium-review.googlesource.com/1123164 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#574005}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d07c1948..1fb73122 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0489d7d416f3a55471063690969953f95b517c1f Reviewed-on: https://chromium-review.googlesource.com/1132252Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574004}
-
chaopeng authored
There are 3 changes make in hover-during-scroll.html: 1. update tests to use testharness.js 2. call rAFs before start input 3. use promise_test and gpuBenchmarking events This should fix the hover-during-scroll.html flaky on virtual/threaded test suites. Bug: 841567 Change-Id: Idc46e81a3974e97478a871dc976af3acf7493269 Reviewed-on: https://chromium-review.googlesource.com/1130013Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#574003}
-
Rintaro Kuroiwa authored
- Add a clone method on DecryptConfig. - This is required for later patches for decoders and CodecPictures to copy and own DecryptConfigs. Bug: 820192 Change-Id: I5ae0826e86781d876af09509a9168e8a8e5be8a6 Reviewed-on: https://chromium-review.googlesource.com/1123767Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Rintaro Kuroiwa <rkuroiwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#574002}
-
chrome://flags#enable-web-authentication-touch-idMartin Kreichgauer authored
This turns the existing WebAuthenticationTouchId feature into a chrome://flags flag. Bug: 678128 Change-Id: I8741f1d66409bdf636645c79cfb2145d679cb8d9 Reviewed-on: https://chromium-review.googlesource.com/1130699Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#574001}
-
Emily Hanley authored
Bug: 757933 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: Ifde7ff385e21fe71a6f19476109e5a53bc3e64c8 Reviewed-on: https://chromium-review.googlesource.com/1131222Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#574000}
-
Peter Mayo authored
These tests seem to be often missed once disabled, but they show up as unexpected passes. Bug: 626703 Change-Id: Ife2ea06ab41a5a6665b27101d98bebdb9978d1ab Reviewed-on: https://chromium-review.googlesource.com/1131820Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#573999}
-
Robbie McElrath authored
This migrates ForceSigninVerifier from using net::NetworkChangeNotifier to content::NetworkConnectionTracker, which works with the network service enabled. Bug: 859136 Change-Id: I59bda75125f09664c5611fbebed89beb175ecc71 Reviewed-on: https://chromium-review.googlesource.com/1123695Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#573998}
-
Hiroshige Hayashizaki authored
In order to assert |WorkerGlobalScope::url_| is non-empty when referenced (which will be needed when Issue 861564 is applied for module workers), this CL removes cases where |url_| can be empty in unit tests. Bug: 861564 Change-Id: I983f334ab866495a13a15e42805998359748b907 Reviewed-on: https://chromium-review.googlesource.com/1128518 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#573997}
-
Sergey Ulanov authored
* Add RunnerImpl for servicing Runner FIDL requests. * Add ComponentController class for managing the lifetime of connected Runner clients, and servicing ViewProvider::CreateView() calls. * Add "runner" package, deployment scripts, etc. * Modify ScopedServiceBinding to support multiple clients. Bug: 856416 Change-Id: I1b3fd00e868f5eed6842f711986a13c0296a4c07 Reviewed-on: https://chromium-review.googlesource.com/1114377Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#573996}
-
Wez authored
Bug: 844016 Change-Id: Ia1d3238506ff95c565a2bcf309d94da7b527e490 Reviewed-on: https://chromium-review.googlesource.com/1132519 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#573995}
-
Peter Kasting authored
Bug: none Change-Id: I759a442c973f85bd0363e1342d0e4ecfb9cf0fdc Reviewed-on: https://chromium-review.googlesource.com/1132486Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#573994}
-
Findit authored
This reverts commit 764f213c. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 573986 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzc2NGYyMTNjZGY2NWI2YWVhMTBmMmZkMjA4Yzg2NjEyZjk2MzkzMGEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Builder%20%28dbg%29%2832%29/84783 Sample Failed Step: compile Original change's description: > Implemented headless compositor protocol tests for basic rAF, GIF and CSS animations. > > Browser flags that are required for BeginFrameControl are now set only > for compositor specific tests thus preventing virtual time flakyness. > > Change-Id: I79c1326fab0b4e90e35b12bdf31c665cdeeb0ec2 > Reviewed-on: https://chromium-review.googlesource.com/1132467 > Commit-Queue: Peter Kvitek <kvitekp@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#573986} Change-Id: I880408504b16822e278140a6f668220a6077455e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1131964 Cr-Commit-Position: refs/heads/master@{#573993}
-
- 10 Jul, 2018 26 commits
-
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5571a97fd12b..8049055c4260 git log 5571a97fd12b..8049055c4260 --date=short --no-merges --format='%ad %ae %s' 2018-07-10 michaschwab@google.com Create Canvas Controller Created with: gclient setdep -r src/third_party/perfetto@8049055c4260 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:111101128 TBR=perfetto-bugs@google.com Change-Id: Ic4688114220b89684c9e9b73bc2355cac7d2099b Reviewed-on: https://chromium-review.googlesource.com/1132434 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573992}
-
Joshua Bell authored
* Move tests from http/tests/locks to external/wpt/web-locks * Name with '.tentative' infix since this is still just a proposal * Name most tests with '.https' infix since feature is [SecureContext] (and remove redirect-to-secure-host logic in tests) * Consolidate window/worker interfaces test with '.any.js' variant * Update paths to service worker helpers Bug: 857265 Change-Id: Iaf254c5d53ff5b6bb65de4516df85307ad3a6519 Reviewed-on: https://chromium-review.googlesource.com/1118764 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#573991}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f9d85d8779cf..0664f1210277 git log f9d85d8779cf..0664f1210277 --date=short --no-merges --format='%ad %ae %s' 2018-07-10 dgarrett@google.com chrome_committer: Remove committer email argument. Created with: gclient setdep -r src/third_party/chromite@0664f1210277 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Icbba1b121627de66e41ead1d98732a2255280b54 Reviewed-on: https://chromium-review.googlesource.com/1131962Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573990}
-
tzik authored
This CL replaces base::Timer with its subclasses. As base::Timer changes its behavior subject to its construction time flags, that makes hard to see the actual timer behavior, especially it's unclear when a timer is injected from other components. Also, that OnceCallback support of base::Timer is hard to implement on the dynamically determined invocation pattern. Bug: 850247 Change-Id: If83f289ad4c284f21d297b813d7ad25e68a2dd5b Reviewed-on: https://chromium-review.googlesource.com/1130561Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#573989}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/416cbeab1d93..144107d3ca6d git log 416cbeab1d93..144107d3ca6d --date=short --no-merges --format='%ad %ae %s' 2018-07-10 hnakashima@chromium.org Create API for adding content marks and setting their params. Created with: gclient setdep -r src/third_party/pdfium@144107d3ca6d The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I4f5b910fe1cebaddc6aaabcb61dd0ac768204d8d Reviewed-on: https://chromium-review.googlesource.com/1132355Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573988}
-
Scott Violet authored
BUG=none TEST=comment only change Change-Id: Ie6f5d38f4d582f0f0bf580e9f73f3b0d96e18ce7 Reviewed-on: https://chromium-review.googlesource.com/1132463 Commit-Queue: Scott Violet <sky@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#573987}
-
Peter Kvitek authored
Browser flags that are required for BeginFrameControl are now set only for compositor specific tests thus preventing virtual time flakyness. Change-Id: I79c1326fab0b4e90e35b12bdf31c665cdeeb0ec2 Reviewed-on: https://chromium-review.googlesource.com/1132467 Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#573986}
-
Raymond Toy authored
If the AudioParam is constant over a rendering quantum, we're allowed to set the parameter value array to have a length one to indicate that the audio param is constant. Make this so if the audio param is truly constant. Bug: 814796 Test: audioworklet-audioparam-size.https.html Change-Id: Ib6e5805dbeb418ad3c202c9c79adc87bc93dad4a Reviewed-on: https://chromium-review.googlesource.com/1097977Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#573985}
-
Kenichi Ishibashi authored
It seems we don't use this flag. Change-Id: If9dbdb7d9a733f4a8698b06b7afae7aef439873a Reviewed-on: https://chromium-review.googlesource.com/1131017Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#573984}
-
Hiroki Nakagawa authored
This is a reland CL for: https://chromium-review.googlesource.com/c/chromium/src/+/1124209 The original CL was reverted because of the random crashes in the WebGL 2.0 conformance tests: https://chromium-review.googlesource.com/c/chromium/src/+/1127420 This was caused by an Oilpan's GC bug happening only on the debug build. That was already fixed by keishi@chromium.org: https://chromium-review.googlesource.com/c/chromium/src/+/1131154 Therefore, this CL changes nothing from the original CL. ===== Original CL description ===== <Overview> This CL introduces FetchSettingsClientObject in BaseFetchContext and replaces some functions of BaseFetchContext with that. This makes the scope of responsibilities of BaseFetchContext clearer. Also, this is a preparation for separating ResourceFetcher for main resource request and subresource requests for workers and worklets. The main resource request needs a snapshot of the fetch client settings object of the parent execution context, while the subresource requests need up-to-date values of the fetch client settings object of the worker / worklet execution context. This change enables a subsequent CL easily to inject the fetch client settings object from externals of WorkerFetchContext. <Technical details> - This CL introduces FetchSettingsClientObject interface and FetchSettingsClientObjectImpl. Also, this makes FetchSettingsClientObjectSnapshot inherit the interface so that BaseFetchContext doesn't have to take care of an actual implementation. - FrameFetchContext has the FrozenState concept that is used for keeping states even after the frame is detached. Similarly, this CL makes FrameFetchContext creates a new instance of FetchSettingsClientObjectSnapshot on frame detach, and replace the current |fetch_client_settings_object_| with that. Bug: 845285 Change-Id: I74b43722002bb07197d718d3f266bbe384636b66 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR: kouhei@chromium.org, kinuko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1127202Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#573983}
-
Dirk Pranke authored
TBR: oysteine@chromium.org, primiano@chromium.org Bug: 862414 Change-Id: I931b169a0ee99acefb1ce666e8bb5457731b5555 Reviewed-on: https://chromium-review.googlesource.com/1132429Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#573982}
-
Parastoo Geranmayeh authored
UKM is logged for the fields whose types are rationalized because they shared the same server type predictions. For now it includes two field types: Address lines, and state/country. Tests Added. New UKM collection review: go/1121206-ukm-review. Bug: 857601, 850552 Change-Id: Ibcddf4ea3fb0a72cd59df7d1434b97c5e7c32f44 Reviewed-on: https://chromium-review.googlesource.com/1121206Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#573981}
-
Robert Flack authored
When starting transitions we check if they are interpolable, and don't start a TransitionInterpolation if not. When retargeting, the start keyframe from the previously active interpolation may cause an incompatible interpolation so we must take this into account. Bug: 853698 Change-Id: Iaeeba35c64c659818c68d30e8f999e704b382926 Reviewed-on: https://chromium-review.googlesource.com/1126519 Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#573980}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3b1c86144cc8..1230eb961dc4 git log 3b1c86144cc8..1230eb961dc4 --date=short --no-merges --format='%ad %ae %s' 2018-07-10 simonhatch@chromium.org Dashboard - Use msBestFitFormat for dashboard stats. 2018-07-10 eakuefner@chromium.org [TBMv2] Make timeInMsAutoFormat available in Python Created with: gclient setdep -r src/third_party/catapult@1230eb961dc4 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:861837,chromium:861837 TBR=sullivan@chromium.org Change-Id: Id236f43859df3e36ff64c6501bf1b3b539a4ba9c Reviewed-on: https://chromium-review.googlesource.com/1131963Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573979}
-
Tessa Nijssen authored
The following changes were made: - Menu coordinates stored in gfx::Rect object - Menu's y-coordinate initialization moved - Store monitor bounds as variable - Store initial location bounds as variable - Move menu height check - Re-order menu position conditionals - Replace monitor width check with IsEmpty() check - Moved offset check - Added unit tests Menu Coordinates Stored in gfx::Rect Object Within the function CalculateMenuBounds(), menu coordinates were stored as a gfx::Size (which stores a width and a height) and two integers, x and y. At the end of the function, the Size object and the integers representing the coordinates were used to create a gfx::Rect object which was then returned. The gfx::Rect class consists of two integers, x and y, and a gfx::Size object. By creating a gfx::Rect early in CalculateMenuBounds(), all the coordinate information is encapsulated in the Rect object. This also abstracts away some of the arithmetic done to calculate the menu's right and bottom coordinates. Then, at the end of the method, the created Rect object can be returned. Y-Coordinate Initialization Moved The menu's y-coordinate is now moved to be under the comment that explains the initialization of the menu's coordinates. Store Monitor Bounds as Variable I created a variable that's a const reference to state_.monitor_bounds. This way, the shorter, simpler variable can be used which is more readable. Store Initial Location Bounds as Variable I created a variable that's a const reference to state_.initial_bounds. This way, the shorter, simpler variable can be used which is more readable. Move Menu Height Check The check that the menu height is not greater than the monitor height was moved to be next to the check that the menu width is not greater than the monitor width. These checks are very similar in nature and therefore it makes sense for them to be near each other. Re-Order Menu Position Conditionals The previous ordering of menu position conditionals was hard to read and understand. The new ordering moves the cases where the menu position has been previously set to the front so that they're easier to find. It then re-organizes some of the conditionals in the case that the menu position is still best fit so that they check for positives instead of negatives (i.e. check that the menu fits in a certain position rather than checking if it doesn't). Repetitive checks were also removed (e.g. menu doesn't fit below initial bounds and its position is above initial bounds and menu position is above initial bounds). Replace Monitor Width Check with IsEmpty() Check The method Rect::IsEmpty() includes the case in which the width is 0. Rather than checking if the monitor's width is 0, check that the monitor Rect is not IsEmpty() which is cleaner and easier to read. The check was also moved to its own conditional which returns early if the monitor is empty. This way, the check doesn't have to be repeatedly made in other conditionals. Moved Offsetting Offsetting was moved to the end of the function so that it's not undone and redone repeatedly. Added Unit Tests Unit tests were added that test that the menu bounds are calculated properly depending on where the menu best fits, what the menu anchor is, and whether the menu is a context menu and should be offset. Change-Id: I34c29dbf22fe2956761c99f8e1702ff43816413c Reviewed-on: https://chromium-review.googlesource.com/1114073 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#573978}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eb4bb04d120f..bc787be40f68 Created with: gclient setdep -r src-internal@bc787be40f68 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If4d866ed8c8e5c17b79d5ba5c012945302da8bbb Reviewed-on: https://chromium-review.googlesource.com/1132354Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573977}
-
Brandon Jones authored
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5dfaa8182e83eb20c459ab9363ee7de41a627a43 Bug: 696637 Reviewed-on: https://chromium-review.googlesource.com/1125341 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#573976}
-
Daniel Rubery authored
For safe browsing protection (e.g. PhishGuard, download protection) that uses referrer chain, we'd like to skip navigations initiated by reload. This is because these navigations are marked as BROWSER_INITIATED, they would break current attribution logic. Bug: 862290 Change-Id: Ia7d43df441ce47ceb09c8458942ad933ccc9a2ad Reviewed-on: https://chromium-review.googlesource.com/1132077 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#573975}
-
Peter Kvitek authored
This reverts commit 401e3a6e. Reason for revert: breaks VirtualTimeErrorLoop browser tests. Original change's description: > Added headless protocol browser test harness flags > > Change-Id: I4d0a224d4a256a96a6b8fdfa798f0b9a14c02ee1 > Reviewed-on: https://chromium-review.googlesource.com/1129472 > Commit-Queue: Peter Kvitek <kvitekp@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#573388} TBR=pfeldman@chromium.org,kvitekp@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ia4562c937961e24debdad2dfbb57386cf3c8cea2 Reviewed-on: https://chromium-review.googlesource.com/1132304Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#573974}
-
Danyao Wang authored
This fixes NavigationTestCase/testRestoreHistoryToNTPAndNavigateForward. Bug: 807428 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib49522b7740fae867e2b7e3c6e03abf3aefb50e6 Reviewed-on: https://chromium-review.googlesource.com/1127466 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#573973}
-
Mustafa Emre Acer authored
Bug: 843361 Change-Id: I824aa69e64565bb6f05204df3b2ad65a86889c91 Reviewed-on: https://chromium-review.googlesource.com/1132454 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#573972}
-
Jialiu Lin authored
Previously, we don't distinguish verdicts that are triggered by saved password or sync password. As a result, if use have a saved password that is a prefix of a sync password, then PhishGuard will only trigger saved password ping. This CL changes the way we cache verdicts. Previously for password reuse verdicts, there're two levels of keys: (1) primary URL, (2) cache expression. Now, we add another key: (1) primary URL, (2) reused password type, (3)cache expression. In addition, minor refactoring due to : (a) base::DictionaryValue::Iterator, DictionaryValue::GetInteger(...) DictionaryValue::GetString(...) are deprecated. (b) GetDictionaryWithoutPathExpansion(...) is deprecated. (c) base::Bind(...) is deprecated. Bug: 770725 Change-Id: Icb3ed840a4bbe54683e0fa0aff79ab2cd6bb5bfb Reviewed-on: https://chromium-review.googlesource.com/1119251 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#573971}
-
Wez authored
Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I7b1f08d8ef5a04c6d4dce6f2a63a678d074ab3a0 Reviewed-on: https://chromium-review.googlesource.com/1132377Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#573970}
-
Emily Stark authored
These keys have been blacklisted in https://chromium-review.googlesource.com/1103224. We can use dynamic interstitials to trigger the special MITM interstitial for them. This interstitial can be seen at chrome://interstitials/mitm-software-ssl. It informs the user that there is misconfigured software and that they should contact their network administrator. Bug: 844069 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I21a5257f48e88347792e9e5c9ed0d45cfa7f4ee2 Reviewed-on: https://chromium-review.googlesource.com/1132379Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#573969}
-
dpapad authored
In Polymer 2 the following pattern throws a runtime error: <template is="dom-if" no-search$="[[foo]]>...</template> This CL introduces a backward compatible solution such that the no-search mechanism works both in Polymer 1 and Polymer 2. Some cleanups can be done once migration has completed. Bug: 859689 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I0732a8c6cd48b94ad3d81cc017fe59688fe3df13 Reviewed-on: https://chromium-review.googlesource.com/1123711Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#573968}
-
Kent Tamura authored
runtime_call_stats.h is used in 3,700+ compilation units, and this CL reduces its pre-processed size by 1.09MB. - In order to remove trace_event.h include, move some part of RuntimeCallStatsScopedTracer constructor to AddBeginTraceEventIfEnabled(). This change didn't regress Speedometer locally. - trace_event.h provided base::size() indirectly for many files. We need to update them to include base/stl_util.h. Bug: 242216 Change-Id: I283bde2c0f2f78b95ce88885054cea1086579d74 Reviewed-on: https://chromium-review.googlesource.com/1130962 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#573967}
-