GitLab

Prevent the "Send" animation from starting right after navigating from
an NTP using the omnibox. Depending on when navigation completes, this
would either cut off the animation, show it entirely, or not show it at
all. Subsequently focusing the omnibox would not show the "Send"
animation.

Before: https://drive.google.com/open?id=1dKBDF2fmAPIVazi_wGUO_C9MosWwF8Uu
After: https://drive.google.com/open?id=1Y9Rp6mn4aI15LxEeMGfBGMHqdg3l-ps9

Bug: 1005014
Change-Id: I5812763780426a86acd605a0afaf08113d805c86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818606
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700909}

As a follow-up to https://crrev.com/c/1827244, remove the exception to allow
ui/gfx/codec use in DataTransfer, as there are no longer any uses of
gfx::PNGCodec in the renderer clipboard.

Change-Id: Ic5ee757b24c0c881e8c978255096b1daf0c1f4ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827651Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700908}

We support custom scrollbar buttons in reversed direction (e.g. the
backward scroll button at the bottom of a vertical scrollbar with
-webkit-scrollbar-button:decrement:end). Count it to see if we can
remove it to reduce complexity of custom scrollbars.

Bug: 1009063
Change-Id: If54d8c0deaae44cc9e40a21c55dfbe0e6c3b48a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830217
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700907}

Change link from https://developer.chrome.com/optionsV2 to
https://developer.chrome.com/options

To reproduce locally, start up the docserver using:

python chrome/common/extensions/docs/server2/preview.py

then navigate to the getting started page

Bug: 968489
Change-Id: I114d503290abe7ad564d3d13d1c57ebcab058c46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827511Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Auto-Submit: Kelvin Jiang <kelvinjiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700906}

This reverts commit 5072afda.

Reason for revert: Breaks long press animation

Original change's description:
> Remove AssistantState::VISIBLE
> 
> Remove the VISIBLE state and use AssistantVisibility instead.
> Also remove obsolete handling for AGSA animations.
> 
> Bug: b/140823590
> Test: Run existing tests
> Change-Id: Id64c5e536dfe6d3e10c9b003c135e76c96a9fee1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802819
> Commit-Queue: Yue Li <updowndota@chromium.org>
> Reviewed-by: Sam McNally <sammc@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Tao Wu <wutao@chromium.org>
> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#696936}

TBR=xiyuan@chromium.org,sammc@chromium.org,xiaohuic@chromium.org,updowndota@chromium.org,wutao@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b/140823590
Change-Id: I4e5114bc64f459b0854433405027df3490d4b8a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829492Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700905}

This reverts commit 19397af3.

Reason for revert: Fixed tests

Original change's description:
> Revert "Add metadata at beginning of trace for discard buffer mode"
>
> This reverts commit 1d2c953e.
>
> Reason for revert:
> This is somewhat speculative, but ever since this change was introduced, bot "Builder Linux Tests (dbg)(1)" has been failing on every run. The CL for the failing test talks about Perfetto and tracing, so this CL seems like a likely culprit.
>
> [12707:12707:0924/154115.904192:FATAL:privacy_filtering_check.cc(48)]  Unexpected field in TracePacket proto. IDs from root to child : 8
> #0 0x7f66c614a14f base::debug::CollectStackTrace()
> #1 0x7f66c5e7cecd base::debug::StackTrace::StackTrace()
> #2 0x7f66c5e7ce88 base::debug::StackTrace::StackTrace()
> #3 0x7f66c5ece649 logging::LogMessage::~LogMessage()
> #4 0x5651bc1aac57 tracing::(anonymous namespace)::VerifyProtoRecursive()
> #5 0x5651bc1aa9da tracing::(anonymous namespace)::VerifyProto()
> #6 0x5651bc1aa7d2 tracing::PrivacyFilteringCheck::CheckProtoForUnexpectedFields()
> #7 0x5651bbb57f38 content::ProtoBackgroundTracingTest_ProtoTraceReceived_Test::RunTestOnMainThread()
> #8 0x5651bd505564 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
>
>
>
> Original change's description:
> > Add metadata at beginning of trace for discard buffer mode
> >
> > Trace metadata is almost always discarded in discard buffer mode of
> > perfetto tracing. For this case, add metadata at beginning of the trace.
> > Handles cases when generators are added while tracing.
> >
> > Change-Id: I911794fba1e7b460ca1a7a3a54599a8c05678d75
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812248
> > Commit-Queue: ssid <ssid@chromium.org>
> > Reviewed-by: Eric Seckler <eseckler@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#699493}
>
> TBR=oysteine@chromium.org,ssid@chromium.org,eseckler@chromium.org
>
> Change-Id: I98fdb75be1a0582ab1a196c66dd74213aeced90b
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823861
> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#699689}

TBR=finnur@chromium.org,oysteine@chromium.org,ssid@chromium.org,eseckler@chromium.org

Change-Id: I7be7f143caca44862d9eff298389b79fff2b70fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825539Reviewed-by: ssid <ssid@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700904}

Change-Id: I4bd4701f88cf0c266e136b641501800bc98be1c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829477
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700903}

- Moved UseCounterPageLoadMetricsObserver to components.
- Integrated WebView with page load metricts.
- Added integration test for UseCounter metrics.

Bug: 995880,994453
Change-Id: Ib5e6b1cb9baff249b711b46c6b1558d4041aee46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823981
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700902}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b1db4712..a90c7a97

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Idd9260bec68a34f5c7172deae2b2646b81e53436
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829505Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#700901}

By storing mojo::Remote<Blob>s rather than UUIDs we don't have to block
resolving the sync Register IPC on resolving the UUID, so this lets us
unblock the renderer faster. Actually resolving the Blob to a UUID (and
eventually BlobDataHandle) is now done only when the URL is actually
loaded. Even that we might be able to get rid of by rewriting
BlobURLLoader on top of the mojo Blob interface, but that's an improvement
for another time.

This makes the Mojo URL.createObjectURL code ~25% faster (or at least did
when I was working on this CL more than a year ago).

Bug: 849737
Change-Id: I9581b4fce1ec7b3d8c3a1ba635c6185906e49ac2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1112740
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700900}

This simplifies the implementation.

Merge-With: eureka-internal/318940
Change-Id: I9fda9de4432e67ad4d4ad82823ed57654aca8328
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829764
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700899}

https://skia.googlesource.com/skia.git/+log/3787f51c65c3..dca6b5fe9a32

git log 3787f51c65c3..dca6b5fe9a32 --date=short --no-merges --format='%ad %ae %s'
2019-09-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-27 bsalomon@google.com Remove vestiges of 32 float texture format support
2019-09-27 jvanverth@google.com Add gpu programmatic frame capture routines
2019-09-27 fmalita@chromium.org [skottie] Minimize top layer size
2019-09-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-27 reed@google.com Revert "add explicit src and dst colorspaces to filterColor4f"
2019-09-27 nifong@google.com Make move-assets obey SKIA_INFRA_ROOT
2019-09-27 benjaminwagner@google.com Switch to device_type dimension for iOS devices
2019-09-27 egdaniel@google.com Don't execute OpsTask which will have no effect on their target.
2019-09-27 mtklein@google.com add alternate gather() impl.
2019-09-27 reed@google.com add explicit src and dst colorspaces to filterColor4f
2019-09-27 fmalita@chromium.org [skottie] Fix skottie_tool anim null check logic
2019-09-27 herb@google.com Introduce SkIota a wrapper that adds an index
2019-09-27 bsalomon@google.com Use SW backend as ref for AsyncReadPixels unit test.
2019-09-27 brianosman@google.com Interpreter: Lots of minor cleanup/refactoring

Created with:
  gclient setdep -r src/third_party/skia@dca6b5fe9a32

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=bungeman@google.com

Bug: None
Change-Id: Ieaf010645fb149897eeedc97a47f99860ad0cd91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830198Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#700898}

Convert the implementation and all users of the
cloud_print::mojom::CloudPrint interface.

Bug: 955171
Change-Id: I7644ec5d0902cbf00c7b04a6c15a45eeff5e57e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816546Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Cr-Commit-Position: refs/heads/master@{#700897}

These are instances where we don't actually need to remove an element from its
tracking document's IntersectionObserverController, because it wasn't being
tracked anyway.

BUG=1007334,1006957

Change-Id: Ia14165402e2a3774a180d0215145d3d46338942c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828358
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700896}

This CL applies pending_receiver to CreateCdm function
in CdmFactory interface. Additionally, this CL converts
mojo::StrongBindingSet to mojo::UniqueReceiverSet.

Bug: 955171
Change-Id: I4bc983708e394800c3a31d3d6a598a39381fa3b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826755Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#700895}

We want to have a more semantically correct long term SecurityLevel for
conditions where we want to show the warning (but not Dangerous)
security indicator.

This is a mechanical change to use a new enum value and replacing
references to WARNING in comments.

This also migrates metrics to use the new enum by updating Autofill and
Security metrics to use WARNING in their suffixes instead.

TBR=parastoog@google.com

Change-Id: Ia86eef12cc231c6d7eac3b93b778a7f32f8d4571
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815544
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700894}

BUG=None

Change-Id: I694f9560b119171d2fd51cde9cd84fab61f2e910
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813398Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700893}

Adds the option for GPU pixel tests to define a grace period, during
which failures will not be surfaced on the waterfall bots. This is to
help prevent newly added tests from turning the bots red due to a
bunch of untriaged images showing up after a test is first added. The
grace period gives the test author a bit of time to triage any new
images before the test starts failing.

Bug: 1008467
Change-Id: I14c219f86ababe96db4d95f18a4f7ff9bf5b469f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829465
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700892}

This change updates CardNameFixFlow to follow the same pattern as
CardUnmaskPrompt and the next CL will add the iOS part.
https://chromium-review.googlesource.com/c/chromium/src/+/1757210

Also adds tests for CardNameFixFlowControllerImpl as the delegate
was previously untested.

Bug: 993849
Change-Id: I79de0c7128882bc8ba73b3dac2a2bcb93c3e572a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817208
Commit-Queue: Alfonso Garza <alfonsogarza@google.com>
Auto-Submit: Alfonso Garza <alfonsogarza@google.com>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700891}

Each function in histogram_macros.cc calls Shell::Get() and then checks
if the return value is null, despite the following code:

// static
Shell* Shell::Get() {
  CHECK(instance_);
  return instance_;
}

Change-Id: I8086a50839322322b23ebbe7f246ca0d9ae897c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829765Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700890}

This is a reland of f8ead841

The build break for win-jumbo-rel is fixed in patch 2.

Original change's description:
> Add drop shadow support for popups on Windows.
>
> This CL adds drop shadow support for popups on Windows when
> the FormControlsRefresh feature is enabled.
>
> In order to add the drop shadow, the Window used for popups (TYPE_MENU)
> is decorated with the WS_THICKFRAME style. Since WS_THICKFRAME also
> provides a frame, the remove_standard_frame flag is set as we are interested
> in keeping just the drop shadow.
>
> Since drop shadow is not supported on Windows versions without DWM composition,
> then the drop shadow is replaced by a thin-line border by using the
> WS_BORDER style.
>
> Bug: 1000898
> Change-Id: I04588d8d1703cb98f4b7a239f9cf46d742324a1c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786247
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Mason Freed <masonfreed@chromium.org>
> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#695655}

Bug: 1000898, 1008725
Change-Id: I9393f9cb8d2e998d4f5e66d2e77290238bbda16d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829877Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Ionel Popescu <iopopesc@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#700889}

The shelf size can change, and the hotseat will jump if the bounds are
only calculated in reference to the shelf.

To fix this vertical jumping when going from in-app -> home, calculate the
hotseat y position in reference to the bottom of the display.

Bug: 1008455
Change-Id: Idd24dc17b0c53126be42d2638508e728f35f683d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828074
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700888}

https://dawn.googlesource.com/dawn.git/+log/86ac0b93c9af..f622a4475002

git log 86ac0b93c9af..f622a4475002 --date=short --no-merges --format='%ad %ae %s'
2019-09-27 beaufort.francois@gmail.com Fix support for optional const char*

Created with:
  gclient setdep -r src/third_party/dawn@f622a4475002

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
TBR=cwallez@google.com

Bug: None
Change-Id: I0c61a996e68df6f94b3b43142bdaaa589a7accd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829922Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#700887}

This CL is converting the process-internals WebUI to work without
WebUI bindings being granted to its process. It requires adding a
new method to RenderFrameHost and its Mojo interface to the renderer
process to enable JS bindings for Mojo.

Change-Id: Idd9b89cc68b341891d1622a019a93103642ce91d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814688
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700886}

Previously the icon did not set highlight ink drop animation correctly
that it did not go through Button::SetHighlighted(bool). It is needed
because the status chip container is a button observer which observes
button highlight state changes, and then update its own highlight status.
This is only triggered by SetHighlighted().

Add (before and after) screenshots in bug comment 28

Bug: 932818
Change-Id: I2e6c2e9a6b7302652761aa548dd777995c01436a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827750Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700885}

https://chromium.googlesource.com/catapult.git/+log/15152b52a721..ed74a5890e50

git log 15152b52a721..ed74a5890e50 --date=short --no-merges --format='%ad %ae %s'
2019-09-27 eirage@chromium.org Disable testScrollDistanceFastTouch due to flaky

Created with:
  gclient setdep -r src/third_party/catapult@ed74a5890e50

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC oysteine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=oysteine@google.com

Bug: chromium:1006789
Change-Id: I7f522ae77bc4542274d2774523a8cc176c86b120
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829285Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#700884}

With this CL, we store the render_process_id and render_frame_id
(if any) associated with each LockManager::Lock in LockManager.

This is a prerequisite to build a Web Lock observer interface, through
which code outside of //content can know which frames hold lock and
avoid freezing them.

Bug: 980533
Change-Id: Ifb298f8739cf5d2ab5b982088403328fd7376a7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757288
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700883}

Add a unittest ensuring that ProfilePolicyConnector sets up proxying of
primary user policies to the device-wide policy service.

Bug: 982936
Test: new unit_test
Change-Id: I3e19b9fa946f553d5e1df9cf9f131256545570d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807303
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700882}

Modify the timing histogram description to include the different ways
that the user can exit the Add Supervision dialog without completing
enrollment which triggers a record for this timing metric.

Bug: 1004882
Change-Id: I606ba1ec0f090e7c5f34d0c25b63383177dcafa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829986Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700881}

NOTRY=true
Work around win_optional_gpu_tests_rel failures.
https://bugs.chromium.org/p/chromium/issues/detail?id=1008966

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d033cf11..b1db4712

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I5ed16384c4b9a8dfbc26cf928ed8f113c047919f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829318Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#700880}

When selecting a profile from the Profiles menu, it may be necessary
to load that profile. ExtensionAppShimHandler currently goes through
the hoops to do that in OnShimProcessConnected->OnProfileLoaded->
OnExtensionEnabled. Generalize that path into a LoadProfileAndApp
function that will make callback with a Profile* and Extension*.

Use the LoadProfileAndApp in both OnShimProcessConnected and
OnShimSelectedProfile.

When in multi-profile mode, no longer specify a valid Profile to
the AppShimHost. Clean up the places where the AppShimHost's profile
path was used, to avoid using the profile path.

Change the app shim to specify its full path (instead of a relative
path), and remove the GetFullProfilePath and ProfileExistsForPath
delegate functions.

And add some tests for all of this.

Bug: 982024
Change-Id: Icb1e7c688cea67758d9d0236856c8f6b612c1cd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825926
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700879}

Noticed by inspection of the code which was obviously wrong.
Added a test for this.

Bug: 794320
Change-Id: Idca62abb1e9ec8719235528b213f9ca5f7e82e0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829760
Auto-Submit: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700878}

In https://chromium-review.googlesource.com/c/chromium/src/+/1794305,
I deleted the in-process NetworkService path, assuming that the
NetworkServiceTest interface would work with an in-process
NetworkService, and that we weren't running in that configuration
anyways. I was wrong on both counts.

This CL brings back the old behavior, adding a comment that it's not
threadsafe, since it's running code on the IO thread, which should
be run on the NetworkService's thread.

Bug: 1007610
Change-Id: I5ccb029d0c3590d42fa22a35be019eea767ffc8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825565
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700877}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/30058d417f4c..4400cb93e9b9


Created with:
  gclient setdep -r src-internal@4400cb93e9b9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I0a42d0cc696da06d76da52000b2fccbd9c13aef6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830009Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#700876}

When onscreen keyboard is shown, it moves the app list view so the app
list UI covers the whole screen. We should respect those bounds, and not
let app list view change to kHalf (note that transition from peeking to
half state happens concurrent with onscreen keyboard being shown, so
there is potential for race conditions) state override those bounds.

Note that app list view will update its bounds to match the target state
when the onscreen keyboard gets hidden.

BUG=1008656

Change-Id: Ied685cdd320f38da07278129e6bb895a725d1276
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828085
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700875}

Change-Id: Icece2940964599751f897d5334af42ab2def55a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830063Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700874}

https://quiche.googlesource.com/quiche.git/+log/f0fe2069005c..d85976f86ec3

$ git log f0fe20690..d85976f86 --date=short --no-merges --format='%ad %ae %s'
2019-09-27 fayang gfe-relnote: Use latched_session instead of session() in QuicFdWrapper::Readv testvalue. Protected by FLAGS_gfe2_reloadable_flag_quic_add_upper_limit_of_buffered_control_frames3 which replaces FLAGS_gfe2_reloadable_flag_quic_add_upper_limit_of_buffered_control_frames2.
2019-09-26 dschinazi Fix flaky QuartcPeerTest.BandwidthAllocationWithoutEnoughAvailable
2019-09-26 renjietang Comments on some disabled v99 tests.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

flip flags


R=rch@chromium.org

Change-Id: I924629327bc28fe49825a6b6e0bb69cb3eb2baac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830060
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700873}

Also SETTINGS frame setting identifiers are updated to log string literal, and RST_STREAM frame now logs offset.

Change-Id: Id6c147ceedd6232e1969d50cbd6feafb0bf058e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829545
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700872}

This patch emits ExtraInfo events for service worker main and
subresource requests by setting the render_frame_id of all
network::ResourceRequests made by service workers from -2 to a routing
id for DevTools which is already sent from the browser process to the
renderer process when creating a service worker. Setting the
render_frame_id allows us to identify which service worker a request
came from in the browser process through NetworkServiceClient.

Bug: 991471
Change-Id: I8031644c10cba177917e5b6bc25e4ada088d95cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746204
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700871}

Using wpt-import in Chromium ec4125c8.
With Chromium commits locally applied on WPT:
03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/"
f005f65d "Parse CSP frame-ancestors on responses by service worker."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org:
  external/wpt/resources
raphael.kubo.da.costa@intel.com, rijubrata.bhaumik@intel.com, timvolodine@chromium.org:
  external/wpt/generic-sensor

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I0a9fc6bc83821390930caaad21b37b179abdd528
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829322Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#700870}