1. 23 Oct, 2019 1 commit
    • Evan Stade's avatar
      Re-land "Remove NOTIFICATION_PROFILE_ADDED from UserCloudPolicyManagerChromeOS" · 1b02f435
      Evan Stade authored
      This re-lands commit 00722f1e.
      
      The change was reverted for causing unit test failures under asan.
      The fix for those failures was committed as e9179a4f.
      Thus, this change is identical to the original.
      
      Original change's description:
      > Remove NOTIFICATION_PROFILE_ADDED from UserCloudPolicyManagerChromeOS
      >
      > Use ProfileManagerObserver::OnProfileAdded instead.
      >
      > Also worth noting that this removes an obsolete superclass from
      > UserCloudPolicyManagerChromeOS, i.e. KeyedService. Both KeyedService
      > and ConfigurationPolicyProvider have a "virtual void Shutdown()"
      > so this removes that collision (not that it was doing any harm).
      >
      > Bug: 268984,171406
      > Change-Id: Ia0b3dd4dd34a0f62e84dd057928d61c5677231d5
      > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854525
      > Commit-Queue: Evan Stade <estade@chromium.org>
      > Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#707909}
      
      TBR=antrim@chromium.org
      
      Change-Id: I9c7342b0cdf9b8d1555c27ab41ff1015633dbbf2
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874717Reviewed-by: default avatarEvan Stade <estade@chromium.org>
      Commit-Queue: Evan Stade <estade@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#708427}
      1b02f435
  2. 22 Oct, 2019 39 commits