- 26 Jun, 2018 40 commits
-
-
edchin authored
Since iOS 9, table views automatically shorten their width and center content on large iPads so that the content is more readable in larger screens. The cell separator is following the shortened width on recent tabs in tab grid. This CL makes the separator fit the whole table. Screenshot: https://drive.google.com/open?id=12CFWGsy9KQ7vPZINT-mBZkJzhHVy_PXL Bug: 855115 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iaa56257c56c511a0cb315e579737396c7e5e3c78 Reviewed-on: https://chromium-review.googlesource.com/1115473Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570514}
-
Ehsan Karamad authored
Reasons for adding the bool memeber to Document class: * Feature policy is set and maintained the same throughout the lifetime of a document * To get feature state using Frame::IsFeatureEnabled is a bit costly as it involves checking all the origins mentioned for the policy. * Vertical scroll policy is checked quite frequently (e.g. for all wheels and touch starts) * Removes a few lines of code (more readable) Bug: none Change-Id: I7095801689aa90acc2f429643804e002cffbdc25 Reviewed-on: https://chromium-review.googlesource.com/1108342 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:Ian Clelland <iclelland@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#570513}
-
Eric Stevenson authored
Without it the --cloud option is broken. Change-Id: I86c4a6c1975904e3d1944cb4daf50c6cbd833cd5 Reviewed-on: https://chromium-review.googlesource.com/1115502Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#570512}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/75ee53784b5e..0a6dbeffbc61 git log 75ee53784b5e..0a6dbeffbc61 --date=short --no-merges --format='%ad %ae %s' 2018-06-26 tsepez@chromium.org Add some more consts to unowned pointers. 2018-06-26 tsepez@chromium.org Use pdfium::span in CPDF_CID2UnicodeMap. 2018-06-26 hnakashima@chromium.org Fix Integer-overflow in CFX_RTFBreak::AppendChar_Tab 2018-06-26 art-snake@yandex-team.ru Simplify CPDF_Parser::RebuildCrossRef. 2018-06-26 art-snake@yandex-team.ru Unify CPDF_Document loading methods. 2018-06-26 art-snake@yandex-team.ru Add test which verify, that "Info" from linearized doc is correctly saved. 2018-06-26 art-snake@yandex-team.ru Implement CPDF_ObjStream. 2018-06-26 hnakashima@chromium.org Write pixel .evt test for dynamic_list_box_allow_multiple_selection. 2018-06-26 tsepez@chromium.org Make CPDF_Document::m_pRootDict an UnownedPtr<>. 2018-06-26 vmiklos@collabora.co.uk Add FPDFTextObj_GetFontSize() API 2018-06-26 tsepez@chromium.org Use ObservedPtr for CJS_Field::m_pJSField Created with: gclient setdep -r src/third_party/pdfium@0a6dbeffbc61 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:844367,chromium:856354 TBR=dsinclair@chromium.org Change-Id: I53417b981430471c1a1fbb026c96004f86483522 Reviewed-on: https://chromium-review.googlesource.com/1115405Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570511}
-
Eric Karl authored
Provides an Android Choreographer based ExternalBeginFrameSource implementation. Allows the Viz process to produce frames in the same manner as previously done in the Browser process. Removes the IPC-based ExternalBeginFrameSource from CompositorImpl. Bug: 811967 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ibf65969e2a6ddd0a9892aac99aea329ae99b94a5 Reviewed-on: https://chromium-review.googlesource.com/1109198Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#570510}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4c50badb2927..83a57e01cd02 git log 4c50badb2927..83a57e01cd02 --date=short --no-merges --format='%ad %ae %s' 2018-06-26 vadimsh@chromium.org [cipd] Bump cipd and vpython 550cea2b9a -> aacec5af4d. Created with: gclient setdep -r src/third_party/depot_tools@83a57e01cd02 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:801423 TBR=agable@chromium.org Change-Id: I19e4e9e67519ac0217a06c3305e230a26028f1e0 Reviewed-on: https://chromium-review.googlesource.com/1115404Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570509}
-
Minh X. Nguyen authored
The new extension updater doesn't implement the updater correctly when install_immediately is set. By default, it creates a CRX installer with install_immediately set to false regardless of the user's intention. This change will fix this behavior. Bug: 722942 Change-Id: Idca645878587208cde1ed9f23ec8f0facf379868 Reviewed-on: https://chromium-review.googlesource.com/1107042Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Minh Nguyen <mxnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#570508}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fe288eb687b8..fb8e7ef84262 git log fe288eb687b8..fb8e7ef84262 --date=short --no-merges --format='%ad %ae %s' 2018-06-26 danilchap@webrtc.org Implement PayloadUnion as variant instead of pair of optionals 2018-06-26 nisse@webrtc.org Delete unused copy constructors for VCMEncodedFrame and VCMFrameBuffer. Created with: gclient setdep -r src/third_party/webrtc@fb8e7ef84262 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I44cbad51d661c4cd0219ea5daa9bc8462bb085ba Reviewed-on: https://chromium-review.googlesource.com/1115398Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570507}
-
Maks Orlovich authored
The way the upload was setup was making the SimpleURLLoader grumpy, so do it by the book. It's actually very easy to do that, contrary to my original thinking. Bug: 855159 Change-Id: Ie4522bfeb541ed955577cf3120ce4f0d12576285 Reviewed-on: https://chromium-review.googlesource.com/1110701 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#570506}
-
tzik authored
This CL removes an unexpected usage of abseil, which is not yet available in Chromium code. Change-Id: I2ee4f09be9139db522978cbe8e6c9b2fa78e02c5 Reviewed-on: https://chromium-review.googlesource.com/1114571Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#570505}
-
Jun Choi authored
In order to implement virtual CTAP2 security key, we need to be able to serialize response data for MakeCredential GetAssertion, and GetInfo request. Add logic for serializing GetInfo response. Bug: 829413 Change-Id: Iaeff50b8352be01f2ebb71d597cdfb66fab9407c Reviewed-on: https://chromium-review.googlesource.com/1109265 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#570504}
-
Anna Malova authored
Bug: 800316 Change-Id: Ibc4c89a8032f0ef343aee4477d96c92203de0a2a Reviewed-on: https://chromium-review.googlesource.com/1113929Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#570503}
-
John Chen authored
We use openbox window manager inside Xvfb, making it possible to maximize windows. Re-enable testwindowMaximize test. Change-Id: Ie69778905ca5d4a643f9217058dafd24cde0de8b Reviewed-on: https://chromium-review.googlesource.com/1115434Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#570502}
-
kristipark authored
Bug: 854009 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ic8bbe3273b351ec202a8f5ae49fffda88b1006e0 Reviewed-on: https://chromium-review.googlesource.com/1114207 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#570501}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/29cb3db927ce..a481ed6f083d git log 29cb3db927ce..a481ed6f083d --date=short --no-merges --format='%ad %ae %s' 2018-06-26 dgarrett@google.com cros tryjob: Add --git-cache-dir for local builds. Created with: gclient setdep -r src/third_party/chromite@a481ed6f083d The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=chrome-os-gardeners@chromium.org Change-Id: Ic9cb4a266111d76005715cee30747cad5cecb3a7 Reviewed-on: https://chromium-review.googlesource.com/1115258Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570500}
-
PhistucK authored
Synthetic properties (like "Return value") do not have a meaningful property path, so the option to copy it is useless, so is the option to add it to watch. Internal properties (like "[[PromiseValue]]" and so on) are also synthetic (in terms of not being accessible from JavaScript), so now they are marked as such. Bug: none Change-Id: I381098e478f0217a835b9d8b5ca5f3ba1304da3c Reviewed-on: https://chromium-review.googlesource.com/1084093Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: PhistucK <phistuck@gmail.com> Cr-Commit-Position: refs/heads/master@{#570499}
-
danakj authored
This removes the blink::WebCanvas and blink::PaintCanvas aliases for cc::PaintCanvas, using the type directly everywhere instead. Also some bonus un-indirection of cc::PaintFlags through blink::PaintFlags though the alias remains for now. TBR=haraken Bug: 838693 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib07545bf6d6d1173e62792143e9d44ed1ab74619 Reviewed-on: https://chromium-review.googlesource.com/1112671 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570498}
-
Xi Cheng authored
This is a cleanup CL following crrev.com/c/1114213. Bug: 851163 Change-Id: I1e694737f26a3fa5e35ef7afe486e3866b3b86db Reviewed-on: https://chromium-review.googlesource.com/1115283Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#570497}
-
Stephen Martinis authored
This centralizes the script so that we keep track of which test suites are using the isolated script interface. It also makes the test suite conform fully to the isolated script interface, specifically the filter interface. Bug: 533481 Change-Id: If1a6c394ad7a00b4767565977674f9106ce6cb93 Reviewed-on: https://chromium-review.googlesource.com/1100160Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#570496}
-
David Benjamin authored
RE2::PartialMatch and friends don't take the regex as a string. They take it as an RE2 object, which has an implicit conversion from string. Instead, keep the compiled RE2 objects around. This brings the cost of running FlashDownloadInterceptionTest.DownloadUrlVariations 1000 times in a loop from 5.7s to 200ms. Bug: none Change-Id: I83b81219a4f84ac810a2bfca40e4267579a05db9 Reviewed-on: https://chromium-review.googlesource.com/1115369Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#570495}
-
Kyle Horimoto authored
This CL adds two pieces of missing functionality: (1) It invokes the "pending host request change" event when appropriate. (2) It keeps track of the number of times that AttemptToSetMultiDeviceHostOnBackend() is called. These test functions will be used in a follow-up CL. Bug: 824568 Change-Id: I7620d0b691d9f2d7af4aafbb1096fcde8dc61899 Reviewed-on: https://chromium-review.googlesource.com/1114294Reviewed-by:Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#570494}
-
Dale Curtis authored
FFmpeg both specifies a multi-packet discard and marks packets for complete discard. When we overwrite the discard padding value for complete discard, we lose information about furture packets which may need bits discarded from them. This resulted in us discarding 2048 out of 2112 frames instead of the full 2112 when playing an AAC file encoded by Apple. All of our existing tests use a 1024 frame padding instead of Apple's much larger padding, so this patch brings in a new test case. As noted in the test though, the hash isn't quite 100% correct, since we don't discard post-decode silence. This isn't a huge deal since plain src= tags can't splice streams and MSE requires an explicit append window for correctness. BUG=668999 TEST=new unittest. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6dad531ab986c3deb7e855dddad3011b98e6d9b6 Reviewed-on: https://chromium-review.googlesource.com/1114289 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#570493}
-
Sigurdur Asgeirsson authored
By propagating the unique ID of the navigation handle and the url of the navigation, it's now possible to distinguish whether notifications pertain to the current navigation or an earlier one. If data relating to the notification is to be persisted, it's now also possible to persist it against the correct (original) origin the event pertains to. Bug: 854598 Change-Id: I1b8687bd1153890edc995adbebac9b6ceb78acfe Reviewed-on: https://chromium-review.googlesource.com/1108361 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#570492}
-
Rayan Kanso authored
Move the Response creation logic from DataManager to the relevant files. Some code cleanup along the way, such as - scoped_refptr getters - formatting of conditionals - using library implementations for IsOK Change-Id: I4f75335702cf8cb90c724b3c209526c1c6f87105 Reviewed-on: https://chromium-review.googlesource.com/1112928 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#570491}
-
Alexei Filippov authored
Change-Id: I46e4a6123a11879def0482d9edc301c5adc12f38 Reviewed-on: https://chromium-review.googlesource.com/1115341Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#570490}
-
Ryan Sturm authored
Moving the "blacklist" strings in previews about:flags to a "blocklist" string. Bug: 842346 Change-Id: Ib4dd84e1ee63b6cd7d5c3d9cdd6d5b704d06cf90 Reviewed-on: https://chromium-review.googlesource.com/1115420Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#570489}
-
David Tseng authored
Bug: 854873 Change-Id: I511f782149470ce771c9f66802613e3bfbb7a4d8 Reviewed-on: https://chromium-review.googlesource.com/1115425Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#570488}
-
Ryan Hansberry authored
This information is needed by Smart Lock to send to the host when trying to sign in. Bug: 844759, 824568 Change-Id: Ieb1afce0ebe1dcdcbc014b55fa05871449fe71b9 Reviewed-on: https://chromium-review.googlesource.com/1112873Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#570487}
-
Nico Weber authored
See comment 1 on the bug. Bug: 855610 Change-Id: I2e3ad59300cabc4ed2c74b671415bb2a6551997b Reviewed-on: https://chromium-review.googlesource.com/1114267Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#570486}
-
Roger McFarlane authored
Flaky test: PersonalDataManagerTest .GetProfileSuggestions_NoSubsetsCheckingIfTooManyProfiles This CL removes an errant expectation. The test validates that when there are more then 15 suggestions, autofill skips the expensive "dedupe" operation to merge suggestions. There was an extra expectation that the first suggestion has a particular value, but the ordering of the suggestion isn't actually set/controlled by the test. Out of the 16 suggestions, fifteen have the same value but one has a different value, so this test was failing roughly once every 16 runs. Bug: 856726 Change-Id: Ib17bd91d232598886e1050622b3ca8c10e856f35 Reviewed-on: https://chromium-review.googlesource.com/1115462 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#570485}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a1b1806c9eea..33319d66254b git log a1b1806c9eea..33319d66254b --date=short --no-merges --format='%ad %ae %s' 2018-06-26 nednguyen@google.com Roll tsproxy to the latest commit 2018-06-26 simonhatch@chromium.org Dashboard - Add info on regression size when starting pinpoint job. 2018-06-26 dtu@chromium.org [pinpoint] Retry taskqueue.add() on taskqueue.TransientError. Created with: gclient setdep -r src/third_party/catapult@33319d66254b The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I604934392eb514d85bf28fa29f5931fa04239467 Reviewed-on: https://chromium-review.googlesource.com/1115400Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570484}
-
John Abd-El-Malek authored
Don't run ChromeResourceDispatcherHostDelegateBrowserTest.NavigationDataProcessed with network service. The code path it's testing isn't used with network service. Bug: 778814 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ib06d13e3c62beb59094cdb691dfb5f55ade38e04 Reviewed-on: https://chromium-review.googlesource.com/1115355Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#570483}
-
Clark DuVall authored
As suggested by mmenke@ on https://chromium-review.googlesource.com/c/chromium/src/+/1100105, moved cookie settings syncing logic to ProfileNetworkContextService. This also syncs settings even when network service isn't enabled, which will allow us to unify the logic for OnCanGetCookies and OnCanSetCookie from ChromeNetworkDelegate and NetworkServiceNetworkDelegate as described in crbug.com/789636#c8. Bug: 789644 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ia503145887a5ba877713a2b019791bc56f79ae8a Reviewed-on: https://chromium-review.googlesource.com/1112726Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#570482}
-
Victor Costan authored
Bug: 855465 Change-Id: I5c87955168ede7f73ab551c364066bde5909fb21 Reviewed-on: https://chromium-review.googlesource.com/1111858Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#570481}
-
Stefan Zager authored
BUG=823365 R=skobes@chromium.org,pdr@chromium.org Change-Id: Ieb215516ff8db7452a12347af1c30c94f7b5e683 Reviewed-on: https://chromium-review.googlesource.com/1114338Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#570480}
-
Torne (Richard Coles) authored
A number of WebView applications in the wild use reflection to call the proxy change broadcast receiver directly as a hack to allow them to set an application-local proxy setting. The reflection code used searches for ProxyChangeListener by name, so fails with proguard obfuscation enabled for the monochrome APK. Mark the relevant classes/methods as @UsedByReflection to ensure they don't get renamed, because while it's not good that applications do this, there is no supported API to achieve the same thing either, and it appears to be a commonly repeated piece of code. Bug: 851995 Change-Id: I6174181491f57fd71fece91c98ae8b96f36b425f Reviewed-on: https://chromium-review.googlesource.com/1112564Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#570479}
-
Fady Samuel authored
In a subsequent patch, the decision whether to ship a RenderFrameMetadata to the browser process depends on on the scroll position relative to the edge of the root layer. This complexity doesn't really belong in cc::RenderFrameMetadata itself but rather its consumer. This CL moves the code of whether to ship a RenderFrameMetadata out of the struct itself. Bug: 672962 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I59b001088d3d83df7bd0dc9fe569e439af3fdeb9 Reviewed-on: https://chromium-review.googlesource.com/1115348Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#570478}
-
Lukasz Anforowicz authored
HungPagesTableModel::InitForWebContents is not called when Chrome is not the currently active window (e.g. when another application like Finder on Mac is active). This means that HungPagesTableModel::hang_monitor_restarter_ may be uninitialized when the renderer wakes up leading to a crash when HungPagesTableModel::RestartHangMonitorTimeout is called. Bug: 855369 Change-Id: Iaf2ccf3385e51bdca62d33915afcf162d99663fc Reviewed-on: https://chromium-review.googlesource.com/1112315 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#570477}
-
Lu Chen authored
Use mojom to send metrics of anchor elements from the renderer process to the browser process. In future CLs, the features on the browser side will be aggregated. Features from both renderer and browser will be analyzed and used to take some actions accordingly. Bug: 850624 Change-Id: Iaf36b64c5668db6ccf6b61c6ff7ffe40367f436b Reviewed-on: https://chromium-review.googlesource.com/1105402Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Lu Chen <chelu@chromium.org> Cr-Commit-Position: refs/heads/master@{#570476}
-
Xiaohan Wang authored
- Update KeySystemSupportImpl to check kDisableAcceleratedVideoDecode and kMojoVideoDecoder. - Update KeySystemSupportImpl to call ContentBrowserClient to query hardware secure decryption capabilities. - Add ContentBrowserClient::GetHardwareSecureDecryptionCaps(). - Implement ChromeContentBrowserClient::GetHardwareSecureDecryptionCaps(). - Add GetWidevineHardwareCaps() to check Widevine-specific caps on Windows. - Rename kEnableHardwareSecureCodecsForTesting to kOverrideHardwareSecureCodecsForTesting to better reflect that fact that real platform hardware secure codecs check will be skipped. Bug: 848532 Test: Added unit test. Change-Id: Ia931fc945e5eb2fd406793cf87e334f3f9e00256 Reviewed-on: https://chromium-review.googlesource.com/1106960Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#570475}
-