- 01 Aug, 2019 40 commits
-
-
Nigel Tao authored
BUG=826982 BUG=989789 Change-Id: I49bd3793bf9fcfc89726fd2f7df690421996e0fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728411Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#683064}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1c2ae9342875..2880bd346d5c Created with: gclient setdep -r src-internal@2880bd346d5c The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Id20c203af9a0b72680c2fecc1899b351f50ca0e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730609Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683063}
-
Kenichi Ishibashi authored
This reverts commit 7bfff78e. We are going to remove legacy on-the-main-thread script fetch soon. Bug: 967272 Change-Id: Ic191ce2a77deb153c7b4c6f1a90fb8cbd2ce8c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730652Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#683062}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 75be86d0. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ibbe90a49d72b4376a3e5a50da99a300805a3bb7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729401Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683061}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLBRElement> and DynamicTo<HTMLBRElement> as new downcast helper. 2. Use IsA<HTMLBRElement>(element) in place of IsHTMLBRElement(element) Bug: 891908 Change-Id: I8f9a3b2854ad4539ec571512ce97ac9a81552652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728129Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#683060}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/78b685d68f34..588b4604c876 git log 78b685d68f34..588b4604c876 --date=short --no-merges --format='%ad %ae %s' 2019-08-01 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@588b4604c876 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I296ce247e6d7ae19b98bbe416fe26bf2e642f0ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730509Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683059}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/471a922d82ca..f3157c496d4b git log 471a922d82ca..f3157c496d4b --date=short --no-merges --format='%ad %ae %s' 2019-08-01 simonhatch@chromium.org Pinpoint - Record job timings Created with: gclient setdep -r src/third_party/catapult@f3157c496d4b The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:987371 Change-Id: Ib832aa6444600e26a21eff93e397304e89183f76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730179Reviewed-by:
-
tby authored
The RecurrenceRanker isn't threadsafe, so we should formalize this. This CL adds a sequence DCHECK to all public methods (and a couple of private callbacks, for clarity). Bug: 921444 Change-Id: Ib52f8e33be82de147efd23e67c424083ff980184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729991Reviewed-by:
Charles . <charleszhao@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#683057}
-
Paul Dyson authored
Move to a helper file some functions and constants that will be needed for inference. Bug: 899123 Change-Id: I5e4984fafd084abb2a3ae8ca02e42290d5f52479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727851Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
-
Alan Cutter authored
There is no Extension specific code in PendingBookmarkAppManager anymore, this code and its tests can be generalised as BMO/Extension agnostic web app code. This also renames BookmarkAppInstallationTask to PendingAppInstallTask. Bug: 916381 Change-Id: Id6972624100d1da1d326e099ad86c20b86a482e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725426 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#683055}
-
Kyle Milka authored
Make it so either a tile can be selected or the switch can be toggled on. Bug: 937570 Change-Id: I2b4b75670d49419eeaa235f567282146e817a37a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726818 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#683054}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I6fe0d6e37e34a483082da5a7950c21a60178a10a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730550Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683053}
-
Patrick Monette authored
Third-party DLL blocking is still not enabled those metrics are still needed to monitor the feature. Bug: 975735 Change-Id: I7a6fa9166a4314ba301f3213a90bb4186d8dfcc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721354Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#683052}
-
Patrick Monette authored
The metrics that it's recording are no longer needed and would expire soon anyways. Bug: 975034, 975126, 975551 Change-Id: Icec43cbaed375a0206db64c107bd6931fc6dc5ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715634Reviewed-by:
-
Raymes Khoury authored
Currently we allow any URLs to be handlers for calls to registerProtocolHandler as long as they are same origin accessible. However: 1) This has led to bugs (see below) 2) It doesn't make much sense for handlers to be data:, blob: URLs etc 3) The spec gives freedom to implementers to add additional checks like this https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers 4) The guidance on https://developer.mozilla.org/en-US/docs/Web/API/Navigator/registerProtocolHandler states that "The handler's URL must use one of "http" or "https" as its scheme." (even though this isn't mandated in the spec) 5) Firefox restricts handlers to https. This CL requires http/https or chrome-extension URL handlers. Chrome status entry: https://chromestatus.com/feature/5066079862784000 Note: This CL was originally landed without support for chrome-extension URLs. The updated CL includes support and a test for this case. Bug: 971917,952974 Change-Id: I89d47e7daf45b9e7c36a25c629494531ef660d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728369 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#683050}
-
tby authored
We have an on-device model ranking commonly used URLs in the CrOS launcher, which stores these URLs in the model itself. This CL observes the history service and deletes URLs from the model that are removed by the user. Bug: 931149 Change-Id: If9e9654a00ae804807319a3dc5dc91b599698c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725032 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#683049}
-
Kalon Hinds authored
This patch adds current line number and file line number range to the GoToLine dialog in the Sources tool. This allows vision impaired people to know their location in a file via ctrl+g. The UI affordance is similar to the experience in VSCode. Before: https://i.imgur.com/D3thzu4.png After: https://i.imgur.com/SHttcdD.gif Bug: 963183 Change-Id: I72fbc64b7e916438dfb1f3db883cc34f2a7e00b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660789 Commit-Queue: Kalon Hinds <kahinds@microsoft.com> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#683048}
-
Kevin Marshall authored
Allows the Agent to control some runtime aspects of Cast applications, like enabling touch input. * Adds unit test and integration tests to verify Frame interactions and publishing logic. * Adds the new Cast unit test suite to the trybots. Bug: 953796,953958 Change-Id: I58c2f8eb95cfc7441e27fd85393dd05cce0f35de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672109Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#683047}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ea9798c5eb96..fd643a4782c9 git log ea9798c5eb96..fd643a4782c9 --date=short --no-merges --format='%ad %ae %s' 2019-07-31 pacaro@google.com Build core audio for older windows versions 2019-07-31 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1bdd7918..d488661c (682806:682945) Created with: gclient setdep -r src/third_party/webrtc@fd643a4782c9 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None Change-Id: Ib4080c3b5779d8786ad015ad9107ee1ffadc981a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729206Reviewed-by:
-
Gayane Petrosyan authored
Custom color picker with following features: - keyboard navigation - preselect - updates color picker colors according to the generated theme - maintains the selected color while the dialog is open, even when other tiles are selected, but resets after dialog is closed. screencast: https://screencast.googleplex.com/cast/NjM3NTk3NTc5MTA5OTkwNHwxNjY5MDE1Mi1kYg Bug: 988066 Change-Id: I4d1b6a1ecb0e4daf81806327f3b613a704a1df96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723019 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
-
Mohamed Amir Yosef authored
Before this patch: The permanent Bookmark Mobile folder is created only during initial Sync on the server. After this patch: The permanent Bookmark Mobile folder is also created for existing users as well upon GetUpdatesRequest. This is more aligned with the implementation of the real Sync server. Change-Id: I7e4c6bb348528b23a46c0fc0751bf8173cbcc716 Bug: 989440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728581 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#683044}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/acd8dbea94f7..8f8354a9a3c6 git log acd8dbea94f7..8f8354a9a3c6 --date=short --no-merges --format='%ad %ae %s' 2019-08-01 bsalomon@google.com Reland "Remove GrCaps::SupportedRead::fSwizzle and supporting code" 2019-07-31 benjaminwagner@google.com Revert "Remove GrCaps::SupportedRead::fSwizzle and supporting code" 2019-07-31 benjaminwagner@google.com Reland "Add LUM8 case to GrGLCaps::getYUVAColorTypeFromBackendFormat" Created with: gclient setdep -r src/third_party/skia@8f8354a9a3c6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: I6dd456055554d93bea8a2ce9408398bd26bd5bcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728348Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/033c7fb180fb..6d82d95f2dd0 git log 033c7fb180fb..6d82d95f2dd0 --date=short --no-merges --format='%ad %ae %s' 2019-07-31 thestig@chromium.org Initialize CPDF_CMap members in the header. 2019-07-31 tsepez@chromium.org Remove CPDF_ModuleMgr. 2019-07-31 tsepez@chromium.org Break direct dependence between fpdfsdk and fxcodec. 2019-07-31 tsepez@chromium.org Remove unused header from cpdfxfa_context.cpp. 2019-07-31 thestig@chromium.org Fix a rendering bug with unwanted lines. 2019-07-31 thestig@chromium.org Add a pixel test for a rendering bug. Created with: gclient setdep -r src/third_party/pdfium@6d82d95f2dd0 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I694ffee9084abf2bd1ba68a3166c2c4fcb5b0c85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730047Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/16a3e45749cb..1c2ae9342875 Created with: gclient setdep -r src-internal@1c2ae9342875 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None,chromium:None Change-Id: I92ee7439632a84f8abfcddfc55412abdb49c5d9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730274Reviewed-by:
-
Hongchan Choi authored
This CL introduces new reporting methods to the InspectorHelperMixin class, and makes WebAudio graph objects (BaseAudioContext, AudioListener, AudioNode, AudioParam) extend from it. The subclass (all the graph objects) needs to implement these reporting methods (ReportDidCreate() and ReportWillBeDestroyed()) from InspectorHelperMixin, and the reported data will eventually reach to the AudioGraphTracer. For easier review: - foo_node.{h/cc} only implements ReportDidCreate() and ReportWillBeDestroyed() - The reporting logic is in audio_graph_tracer.{h/cc} but its reporting functions are empty and it will be filled in follow-up CLs. Bug: 970898 Change-Id: I2a554786afa6ce54c9d4ea6f11f98b6bd702b368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724499Reviewed-by:Raymond Toy <rtoy@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#683040}
-
Hector Carmona authored
Also remove 'nux' namespace, 'welcome' is more appropriate now that we don't have multiple versions. Bug: 951195 Change-Id: I28d79aa017018461252db3563b01cf4a025a56f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715328 Auto-Submit: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#683039}
-
Ahmed Mehfooz authored
Change-Id: I0bc257f9ede24d5c7d4b2ca30263567a17f7e45b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728727Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#683038}
-
Varun Khaneja authored
It is crucial to know that Safe Browsing updates are being parsed and applied successfully. R=nikunjb Bug: 969952, 974961, 975008, 975056 Change-Id: I09f9496828c62ef7ee9c8572f1f30781d250c044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721038Reviewed-by:
-
Alexey Baskakov authored
We will get rid of chrome/browser/extensions/bookmark_app_extension_util.cc completely. That's the last bookmark_app* prefixed file in extensions/. We could inline these utils into finalizer but they are used in ntp/ (chrome://apps) TBR=calamity@chromium.org Bug: 901226 Change-Id: If978196d1f9e45cddd7d637603210fab02556eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728530Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#683036}
-
Jonathan Ross authored
A crash has been introduced in media/alpha-video-playback.html when running with SkiaRenderer and SwiftShader. This change updates the flag expectations to skip the test. Until the root cause can be fixed. TBR=backer@chromium.org Test=skia_renderer_swiftshader_blink_web_tests media/alpha-video-playback.html Bug: 988120 Change-Id: I60d8eee0ab5c253ffe2900ac2effdfbebb090abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730272Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#683035}
-
tby authored
Change-Id: Iccf1395b0fa95bccb6b4ceef8ea8ff0adf06ae70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729580Reviewed-by:
-
Raymes Khoury authored
This reverts commit 17ec7e69. This whitelist is no longer needed. We want to open up this API for public use. Original change's description: > Whitelist usage of management.installReplacementWebApp > > This whitelists management.installReplacementWebApp to specific > extensions as restrictions to ensure apps are related aren't yet > implemented on the Webstore. > > For tests we need to generate manifest.json files based on the URL of > the related app. Hence we can't check in a static crx/extension. This > means that we need to provide a private key when generating the crx to > ensure that the extension ID stays the same across test runs. > > Bug: 968407 > Change-Id: Ieceadeaf59011b7209fece3de06e89f2bea4b9e3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635118 > Commit-Queue: Raymes Khoury <raymes@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Ben Wells <benwells@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665044} TBR=raymes@chromium.org,benwells@chromium.org,rdevlin.cronin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 989799 Change-Id: I7662316011114dc2b5d50fc9a8ad1124b8749582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727869Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Auto-Submit: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#683033}
-
Alexey Baskakov authored
ExternalInstallOptions is tightly coupled with PendingAppManager: Many options like start_url are not used in InstallManager. This was super confusing. InstallManager and WebAppInstallTask should not work with ExternalInstallOptions and ExternalInstallSource. This CL changes InstallWebAppWithOptions method in InstallManager, WebAppInstallManager and WebAppInstallTask to work with WebappInstallSource and new InstallManager::InstallParams struct. Drive by: this method is renamed to InstallWebAppWithParams. Note that: 1) InstallParams is a strict subset of ExternalInstallOptions. 2) ExternalInstallSource is a strict subset of WebappInstallSource. 3) WebappInstallSource is our universal install source (full information). _All_ InstallManager methods take it as explicit argument. Bug: 901226 Change-Id: I6777ead452127dd4f131bcbe1501cbbf25568aee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727097Reviewed-by:
-
Andrew Xu authored
This CL is the forth part of code to implement the arrow button in the overflow bubble view. See more details from the below doc link: https://docs.google.com/document/d/1dO4H_4T6ttWFc75nCNi2Uh18k-3_M8-eOHcfMTcNwd0/edit?usp=sharing Bug: 918024 Change-Id: I2ee940845c61a52e1250487c8dce1e942759adb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703268 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Mitsuru Oshima (Slow - traveling) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#683031}
-
Kyle Milka authored
When a collection id is received in SetCustomBackgroundInfo send a request for the next image in the collection. Save the data for the returned image and the resume token in the custom background pref. Bug: 850317 Change-Id: Ia6a4a89fd2b3491a61bc652440d7cb19926e1144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721841 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#683030}
-
John Kleinschmidt authored
Under certain circumstances, such as aborting an animation and then reassigning a unique_ptr to a new CallbackLayerAnimationObserver (eg InkDropRipple::SnapToState(InkDropState ink_drop_state), the logic to detect deletion in CallbackLayerAnimationObserver ends up causing a heap-use-after-free because CallbackLayerAnimationObserver::CheckAllSequencesCompleted() overwrites the destroyed_ pointer that CallbackLayerAnimationObserver::SetActive() set. In order to fix this issue, use of the destroyed_ pointer was replaced with local WeakPtrs in order to detect deletion. Change-Id: I051657fae929eb4d7200f965561e9d9fb21b44f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714626Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Jeremy Apthorp <jeremya@chromium.org> Cr-Commit-Position: refs/heads/master@{#683029}
-
Antonio Gomes authored
The remaining class in content/renderer/media/stream pass around instances of PeerConnectionDependencyFactory objects through their ctors, but do not effectively use them. This CL cleans this up, as a preparation step to Onion soupping them all at once. BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ie2a7b7855b94caf8da4a633109c867b9b3d1515b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729573 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
François Degros authored
Changed VolumeManager's methods mountArchive() and unmount() to make them return a Promise instead of taking completion callbacks. Change-Id: I9debd4c7edc8256f24f539f81bac088c44edd09a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727653Reviewed-by:
François Degros <fdegros@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#683027}
-
Miyoung Shin authored
This CL renames *_struct_traits.* to *_mojom_traits.* in //gpu. *_struct_traits.* => *_mojom_traits.* Bug: 806965 Change-Id: I7c31344d154b3d7390a8c9f92997cfb8fb868657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728413 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#683026}
-
Ilia Samsonov authored
Deleting the directory not recursively returns false. Bug: 936248 Change-Id: Ic899633b8fa786303edd6a587c140c2d8af08fcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730100Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#683025}
-
