- 23 Oct, 2018 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7cc69c43..a50f4057 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie4bbeb083976053c97611a6e3a2682333191cf58 Reviewed-on: https://chromium-review.googlesource.com/c/1296055Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601876}
-
Hajime Hoshi authored
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 786332 Change-Id: I91647355e2e9d955fcf62020fca175182f35e467 Reviewed-on: https://chromium-review.googlesource.com/c/1293258Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#601875}
-
Alexey Baskakov authored
It is not used for now. Bug: 875698 Change-Id: I2de44ec120deccebb36a2f031843122963bd13f4 Reviewed-on: https://chromium-review.googlesource.com/c/1295759Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#601874}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/102fbc903296..59681844cbb6 Created with: gclient setdep -r src-internal@59681844cbb6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If4a3367659801055791b476812624f9d1cef3a55 Reviewed-on: https://chromium-review.googlesource.com/c/1295737Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601873}
-
Dominic Mazzoni authored
Using AXTableInfo to dynamically compute some table properties was a good idea, but the interface to it was too complicated, it required clients to understand how AXTableInfo is computed on-demand. Instead, create a high-level API to retrieve table info on AXNode that makes use of AXTableInfo behind the scenes. That simplifies all of the code in content/browser/accessibility and chrome/renderer/extensions that previously needed to know how AXTableInfo worked. Bug: 832289 Change-Id: Ie57ef9652ac471498f4c0766e9550fd8b8165794 Reviewed-on: https://chromium-review.googlesource.com/c/1145769 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#601872}
-
Lei Zhang authored
It is not a general purpose substitute for the default std::string constructor. Do the same for base::EmptyString16() and base::string16(). Change-Id: I49016d1a97f40818e9387d4cd16e859e19d6eed3 Reviewed-on: https://chromium-review.googlesource.com/c/1295181Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#601871}
-
Roger McFarlane authored
This CL removes a FormData -> timeticks map that was tracking the timestamp at which a given form instance was loaded/parsed. This is superfluous with the timestamp tracking provided by FormStructure. This memory used by this map was sufficiently large to show up in the heap profiler analyses as a top potential memory leak. Bug: 885390 Change-Id: If44d18d54e26a745d678c5a8b5387cc2fb5dbbf0 Reviewed-on: https://chromium-review.googlesource.com/c/1286438 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#601870}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I1dd74a4212ecb0d3cb4e7386507b179a9ef2a4ce Reviewed-on: https://chromium-review.googlesource.com/c/1295739Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601869}
-
Morten Stenshorne authored
Before creating the constraint space for child layout, we need to calculate the line-left offset for the child. This requires us to calculate the inline margins. If there are no auto inline margins and no special alignment involved, we have everything we need, and can defer fully resolving the margins until right after child layout (when we actually do know the inline size of the child). Only create a temporary constraint space for margin resolution if we need to calculate the inline size of the fragment before layout to calculate the line-left offset. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: If84e4d6360c537a8c3a662c2617bef9dece7a644 Reviewed-on: https://chromium-review.googlesource.com/c/1286425Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#601868}
-
Clark DuVall authored
DRP currently handles this by modifying the proxy list to only have a specific proxy in the ProxyDelegate if the request is for a warmup URL. This change implements equivalent functionality when using the network service by creating a new NetworkContext with only the relevant proxy set in the custom proxy config, and using that context when making the warmup request. Bug: 721403 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I10e2ae5a7493526c24ac35c6db9a4d33dbbc6c8c Reviewed-on: https://chromium-review.googlesource.com/c/1289165 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#601867}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5a2069501490..19603b9e7b20 git log 5a2069501490..19603b9e7b20 --date=short --no-merges --format='%ad %ae %s' 2018-10-23 jiajia.qin@intel.com ES31: Allow function call, unary, ternary operators in SSBO Created with: gclient setdep -r src/third_party/angle@19603b9e7b20 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I8b92d7713d6088f42ea3e0539136510805137473 Reviewed-on: https://chromium-review.googlesource.com/c/1295734Reviewed-by:
-
tzik authored
Change-Id: I70abcd04649b4f91cba16ff364a61378e6ac0f0f Reviewed-on: https://chromium-review.googlesource.com/c/1291189Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#601865}
-
Timothy Gu authored
This reverts commit 17f4e7d2. Reason for revert: Still breaks ASAN Original change's description: > Reland "bindings: Implement timers with V8Function" > > This is a reland of 254369a5. It addresses bug > 888025 by adding ASAN test expectations, as the relevant V8 feature does not > yet support running on ASAN builds. > > Original change's description: > > bindings: Implement timers with V8Function > > > > This fixes bug 866610 by using the IDL infrastructure to properly enter > > the v8::Context before calling the registered callback. > > > > Also ensure eager finalization of ScheduledAction in DOMTimer to > > prevent a memory leak. Added two more effective DCHECKs to confirm. > > > > Bug: 866610 > > Change-Id: I37d7bd05f035fe31856cfe68bae51aa0632cd3b1 > > Reviewed-on: https://chromium-review.googlesource.com/1220486 > > Reviewed-by: Nate Chapin <japhet@chromium.org> > > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > > Commit-Queue: Timothy Gu <timothygu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#593108} > > TBR=japhet@chromium.org > > Bug: 866610, 888025 > Change-Id: Iee5c1d6917ad7770383e06a425f96000835a663a > Reviewed-on: https://chromium-review.googlesource.com/c/1239624 > Reviewed-by: Nate Chapin <japhet@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Commit-Queue: Timothy Gu <timothygu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601830} TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org,japhet@chromium.org,timothygu@chromium.org Change-Id: Ie4f45dfcc1adcc2ac3469eab99dba813723288f4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 866610, 888025 Reviewed-on: https://chromium-review.googlesource.com/c/1296057 Commit-Queue: Timothy Gu <timothygu@chromium.org> Reviewed-by:
-
Mikel Astiz authored
Regular USS datatypes (bridges) don't need to care about encryption, because the processor and worker take care and the original model doesn't need to be encrypted. PASSWORDS on pseudo-USS are special because we need that the "directory" copy (the one in SyncableServiceBasedBridge) is stored encrypted on disk too, similarly to how the legacy Directory does it. In certain cases like when setting up a custom passphrase, the encryption key changes and the processor&worker react to that by recommitting all entities with the new encryption requirements. For pseudo-USS PASSWORDS, it should also reencrypt the local "directory". In order to do this: 1. A new method is introduced in ModelTypeSyncBridge, for the bridge to realize there's an ongoing reencryption. 2. SyncableServiceBasedBridge takes care of using the cryptographer (available for PASSWORDS only) to reencrypt all data. Implementation-wise, the simplest way to achieve that is to modify the bridge such that in_memory_store_ keeps more information, namely the whole sync_pb::PersistedEntityData proto. Bug: 870624 Change-Id: I1e0d7c972580377618c05b9d1f79c6d72f58022f Reviewed-on: https://chromium-review.googlesource.com/c/1288629 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#601863}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6ebedd5fda10..102fbc903296 Created with: gclient setdep -r src-internal@102fbc903296 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2aa576567fb06f39355d476814244e8eefd82ae7 Reviewed-on: https://chromium-review.googlesource.com/c/1295735Reviewed-by:
-
Chih-Yu Huang authored
This reverts commit e90cd145. In gpu_video_decoder, |available_pictures_| tracks the number of picture buffers which are not sent to display. In DimissPictureBuffer(), we should not decrease the value if the buffer also at display. |available_pictures_| is only used at CanReadWithoutStalling() method, and no one will call this method from GpuVideoDecoder, so we calculate the value instead of tracking the value to reduce the code complexity. BUG=755887 BUG=890629 BUG=892514 TEST=Play some videos at Youtube and check Chrome doesn't crash TEST=pass video_YouTubeHTML5, video_ChromeVidResChangeHWDecode, video_VideoDecodeMemoryUsage, video_VideoSeek autotest Original change's description: > v4l2_SVDA, Vaapi_VDA: Support VP9 show_existing_frame feature. > > For VP9 video, when the flag "show_existing_frame" is set, the decoder > should output the specified reference picture which is decoded > previously. Originally V4L2 slice VDA and Vaapi VDA didn't handle this > situation that the reference picture is sent to client but not > returned back. > This CL supports this feature at these two VDA. If the reference picture > is sent to client side, then VDA just sends it directly. > > BUG=755887 > TEST=./video_decode_accelerator_unittest --ozone-platform=gbm > --test_video_data=vp90_2_10_show_existing_frame2.vp9.ivf:352:288:16:16:35:150:12 > on Kevin and Eve device. > TEST=Run AppRTC on Scarlet successfully > TEST=Pass media:media_unittests Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3db1f5b650a5dec67bf46d439a6eeb4a2f3d995a Reviewed-on: https://chromium-review.googlesource.com/c/1258787 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#601861}
-
Samuel Huang authored
Change-Id: I568155e20696e3b0b8e743a20eae5126c31ae4c9 Reviewed-on: https://chromium-review.googlesource.com/c/1293768Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#601860}
-
Mitsuru Oshima authored
* Change ShieldWidget's layer to NOW_DRAWN because it's always transparent. * Remove layer on image_view/title_view * Create an layer for unsnappable lable on demand. Bug: 897870 Test: no functional change. Updated the unit test. Change-Id: I23093ade07bc943ad16572d2704b78b13883c3bd Reviewed-on: https://chromium-review.googlesource.com/c/1295335 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#601859}
-
Hidehiko Abe authored
In ArcOemCryptoBridger and ArcMidisBridge, Mojo connection error was not handled, so it caused a crash. This CL handles the errors. BUG=None TEST=Ran on DUT. Change-Id: Ib6fa54109ac4da03cf9d6e6386d038c92e22357b Reviewed-on: https://chromium-review.googlesource.com/c/1286098Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#601858}
-
Luciano Pacheco authored
Fix CSS selector for <track-info-panel> element, CSS uses a different syntax for Polymer :host pseudo-element with attributes selector. I used code search for all ":host" entries and only this file is using the incorrect syntax. There is no change in behaviour, only styles have changed. Test: Checked manually/visually Audio Player. Bug: 896056 Change-Id: Id93eb2460a8370dfc1e2488e335bdfac3c4067e7 Reviewed-on: https://chromium-review.googlesource.com/c/1295629 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#601857}
-
Krishna Govind authored
R=abdulsyed@chromium.org Change-Id: I6fb4cf641a2de788eae53b8cf5c877608ff3605d Reviewed-on: https://chromium-review.googlesource.com/c/1296052Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#601856}
-
Alexey Baskakov authored
Expose Registry as read-only collection. Users can write: for (auto& kv : registrar->registry()) { const WebApp* web_app = kv.second.get(); ... } Add IsEmpty and UnregisterAll methods. Bug: 891172 Change-Id: I17ad8a5b569eeffb614adeec5575dc6804ce5251 Reviewed-on: https://chromium-review.googlesource.com/c/1295611 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by: -
Heng-Ruey Hsu authored
This is reland of 10f4b936. It addressed the issue in capture_unittests. Original change's description: > Since blob stream needs higher resolution, it causes higher cpu loading > to require higher resolution and resize to smaller resolution. > In hangout app, we don't need blob stream. Enabling blob stream when > needed can save a lot of cpu usage. > > BUG=b:114676133 > TEST=manually test in apprtc and CCA. make sure picture taking still > works in CCA. > > Change-Id: I9144461bc76627903d0b3b359ce9cf962ff3628c > Reviewed-on: https://chromium-review.googlesource.com/c/1261242 > Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> > Reviewed-by: Ricky Liang <jcliang@chromium.org> > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601492} TBR=xhwang@chromium.org,rsesek@chromium.org,jcliang@chromium.org BUG=b:114676133 TEST=run capture_unittests. Change-Id: I977a4eade8d7f7ddc6188c4ce4a659d675e89d5f Reviewed-on: https://chromium-review.googlesource.com/c/1295753Reviewed-by:
Heng-ruey Hsu <henryhsu@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#601854}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7e40bdd94cb1..6ebedd5fda10 Created with: gclient setdep -r src-internal@6ebedd5fda10 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I349983a5dbcc2f8c522486a6f7582c4d7969f610 Reviewed-on: https://chromium-review.googlesource.com/c/1295733Reviewed-by:
-
Dominic Mazzoni authored
See bug for more context; the Espeak extension provides a lower-quality speech engine that supports many more languages, enabling us to support virtually all world languages out-of-the-box on Chrome OS without requiring a separate download. This new engine must be in a separate component extension due to having a different license. This patch puts the extension load behind a flag, --enable-experimental-accessibility-features, because it needs some more polish before we launch it to all users. Bug: 862710 TBR=michaelpg@chromium.org Change-Id: Ia4d010fa5ff217928a3a66d17543bd4990d24c10 Reviewed-on: https://chromium-review.googlesource.com/c/1247038 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#601852}
-
Yuichiro Hanada authored
After crrev.com/c/1291350, OnKeyboardEnabledChanged is called with false when Android IME is used. This CL is a workaround for it. For longer term solution, please see the linked bug. Bug: 897655 Test: Gboard shows up in tablet mode. Change-Id: I1047716212f1a4ec782b108fe02cdbef29aa2c6d Reviewed-on: https://chromium-review.googlesource.com/c/1293106 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#601851}
-
Hajime Hoshi authored
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 786332 Change-Id: I7df2d7a4d0154d8b563c4d0e350a78c97067093b Reviewed-on: https://chromium-review.googlesource.com/c/1293107Reviewed-by:
-
Hajime Hoshi authored
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 786332 Change-Id: Ib271cb86d37c55cc1ad50e24003c8df675976d08 Reviewed-on: https://chromium-review.googlesource.com/c/1293429Reviewed-by:
-
Dominic Mazzoni authored
A TTS engine extension can advertise the set of voices it provides either using the extension manifest, or by calling chrome.ttsEngine.updateVoices to provide a dynamic list. Previously we cached the set of dynamic voices provided by updateVoices in a map in TtsEngineExtensionObserver. That works fine if a TTS extension has a chance to run. However, on profile load, installed extensions don't typically run. That means that when a web page queries the set of installed voices, it gets the list of voices from the manifest, not the dynamic list of voices. This is only fixed once the extension spins up, typically when speech starts. Instead, when an extension calls chrome.ttsEngine.updateVoices, cache the voices in the extension preferences, so that when a profile loads it always gets the most up-to-date list of voices. Partially covered by the existing TtsApiTest.UpdateVoicesApi test, and adds a new 2-part test to cover the caching in particular. (This supercedes: http://crrev.com/c/1247023) Bug: 889591 Change-Id: I79d8e576114951869af66e682920672924f247a7 Reviewed-on: https://chromium-review.googlesource.com/c/1263035 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#601848}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ff1aeb953faf..e023ae7c5540 git log ff1aeb953faf..e023ae7c5540 --date=short --no-merges --format='%ad %ae %s' 2018-10-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 f38cb6d39af1..5a2069501490 (1 commits) Created with: gclient setdep -r src/third_party/skia@e023ae7c5540 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=brianosman@chromium.org Change-Id: I69365a4ea72e80af6639f35bfa292fde7d1e50e5 Reviewed-on: https://chromium-review.googlesource.com/c/1295731Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9dd320d2..7cc69c43 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0614b31e392c385c5a3cabde69a097e2ba792e6e Reviewed-on: https://chromium-review.googlesource.com/c/1295871Reviewed-by:
-
Tatsuhisa Yamaguchi authored
The managed device icon in the system tray should only be shown while in the public session mode, unlike the "managed" indicator shown in the unified system tray bubble. Bug: 895718 Test: manually tested with public session on an enrolled device Change-Id: Ic86be2a42e5d3a0be89cf5eb6c80aab14bec0f32 Reviewed-on: https://chromium-review.googlesource.com/c/1288093 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#601845}
-
sangwoo.ko authored
Replace old API with new API. This CL is a refactor and has no intended behavior change. In the process, Introduce BrowserWindow::OnTabDetached() When closing a tab with old API, expected order of calls are.. 1. Browser::TabDetached 2. BrowserView::TabDetached -> this resets contents_web_view_. 3. Browser::ActiveTabChanged() -> This will call BrowserWindow(BrowserView)::OnActiveTabChange() : Set new contents to contents_web_view_ But, if we use the new observer API it would be 1. Browser::OnTabStripModelChanged() * handles things Browser::TabDetached() used to do. * handles things Browser::ActiveTabChanged() used to 2. BrowserView::OnTabStripModelChanged() * handles BrowserView:TabDetachedAt() used to do. As a result, contents_web_view_ is cleared out with null contents. Repro step and the result would be, 1. Open browser 2. Create new tab 3. Close active tab. -> Then new active tab's contents won't be visible. Therefore, Introduce BrowserWindow::OnTabDetached() and let the Browser control the flow. Change-Id: I88c08f05d365f83146602197374299d4b4fdb14c Reviewed-on: https://chromium-review.googlesource.com/c/1205975 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:Scott Violet <sky@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#601844}
-
Stuart Langley authored
This CL updates file_table_unittest & file_list_selection_model_unittest to be autogenerated from dependencies. Required fixing VolumeManager, where a method was only defined in FilteredVolumeManager and not in the interface. Populate the base class with a method that always logs an error to keep the closure compiler happy. Bug: 860355 Change-Id: I90192479d7faf4368a140460400357dae0f2da4c Reviewed-on: https://chromium-review.googlesource.com/c/1295429Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#601843}
-
Dmitry Gozman authored
This patch moves all logic related to constructing DocumentLoader to it's constructor. It also removes the methods which we only need when creating a DocumentLoader. Bug: 855189 Change-Id: I32521ab453b78c80e3f8266d07eb5a1268df0786 Reviewed-on: https://chromium-review.googlesource.com/c/1274836 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#601842}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3b789e264a44..7e40bdd94cb1 Created with: gclient setdep -r src-internal@7e40bdd94cb1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I29f0cffd656a1aaf9dae8f6092b19ad30f49bbbd Reviewed-on: https://chromium-review.googlesource.com/c/1295730Reviewed-by:
-
Tetsui Ohkubo authored
Notification inline reply did not support notification update after its creation properly. TEST=NotificationViewMD.TestInlineReplyRemovedByUpdate BUG=894638 Change-Id: Ib03b92ea580fa45d5c4fc58de0bca2a1c7399e50 Reviewed-on: https://chromium-review.googlesource.com/c/1290234 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#601840}
-
Peter Kasting authored
This also removes a bunch of other #includes from bookmark_utils_desktop.cc (when I got suspicious that it wasn't using them all) and removes the word "material" from a constant (and inlines it). Bug: none Change-Id: Ibc1736a2b198210b0d29f2eecd779e401ab4a0e3 TBR: sky Reviewed-on: https://chromium-review.googlesource.com/c/1295299Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Ifc5264d3916f9c30f1be09e3fe6110b7660b1faf Reviewed-on: https://chromium-review.googlesource.com/c/1295770Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#601838}
-
Christopher Lam authored
This CL alters the System App installation pipeline in order to allow the full PWA setup experience to succeed for System Apps (mostly adding exceptions for chrome:// URLs), allowing System Apps to be installed with a scope. It also adds a browser test which installs a System PWA end to end. Bug: 836128 Change-Id: Ida32fa45484661d32a9607b44e06f28f272d4cc3 Reviewed-on: https://chromium-review.googlesource.com/c/1272636 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#601837}
-
