- 20 Oct, 2020 15 commits
-
-
Clark DuVall authored
This patch has a few fixes needed before enabling isolated splits in canary: - Make module_installer load classes from the application context ClassLoader instead of using Class.forName, since that may be using the base ClassLoader and not have the chrome split classes - Fix some of the bundle smoke tests since the DFMs are merged into the chrome DFM. - Fix the chrome resources package (org.chromium.chrome.R) clashing with the base module's resources when the APK package name matches. - Ignore chime services which are not defined in the base module, since they will not be used with isolated splits. Bug: 1126301 Change-Id: Ib149894636863408c5fd37054eacb48c214b5b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472707Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#818724}
-
Maggie Chen authored
If the overlays are the only damages in the frame, we will get a zero root damage rect with the new way of calculating damage rect |use_overlay_damage_list_|, which is enabled by default. The old code of |use_overlay_damage_list_| == false is still working. It will be cleaned up once the new code is stable. Bug:1117235 Change-Id: Ibbede44056973a5ba9e052292673bbf0bcb4a50a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434905 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#818723}
-
minch authored
Bug: 1133748 Change-Id: I33c8d0d97e20ba86943332d41a9ee68ae1fbf4be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481463Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#818722}
-
minch authored
Bug: 1131543 Change-Id: I196eb050b6b6a91dba4da76ee9915a2011f1b57e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480802 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
-
Chait Pinnamaneni authored
Original PR https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2403841 Explainer for this feature is https://docs.google.com/document/d/14qJ1rZyMtnIa8hPJc1V8DJRxk4lVI3hlWYGvBDICog0/edit?ts=5f7c13ce Bug:1137050 Change-Id: I6b1dda29537e05c415b2f6479c03dee989281a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485849 Commit-Queue: Chait Pinnamaneni <cpinnamaneni@microsoft.com> Reviewed-by:
Kalon Hinds <kahinds@microsoft.com> Cr-Commit-Position: refs/heads/master@{#818720}
-
Esmael El-Moslimany authored
"z-index: 1" was introduced to render the icons over the ripple when the ripple could be opaque. The opaque ripple feature has since been removed. Bug: 1140234 Change-Id: Icb1d8fbe9a40f89fe7a6593f22283671ecdbcbab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486386 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#818719}
-
Lan Wei authored
http/tests/devtools/network/network-filter-service-worker.js fails on Linux Tests, https://ci.chromium.org/p/chromium/builders/ci/ Linux%20Tests%20%28dbg%29%281%29/92362, disable it for now until it is fixed. TBR=tvanderlippe@chromium.org NOTRY=True Bug: 1140281 Change-Id: Iaa1cdd9b6ff12fa3911dcbec647aa57a17d8ee65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486117Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#818718}
-
David authored
Currently we don't record this for JS crash reports. chrome://media-app wants to record the uptime of the browser process to help track down potential race conditions. We think this can be useful in general for JS errors. Doc: http://go/backlight-better-crash-report#heading=h.1fkxhdmqpt47 Note: we have Process uptime & Process type fields in chrome crashes and I believe we plan to add this in for JS crashes in crbug/1121816. Change-Id: Ide154b49d2f9791cb044885054a5ff929f720618 Bug: b/169635499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463094 Commit-Queue: David Lei <dlei@google.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Auto-Submit: David Lei <dlei@google.com> Cr-Commit-Position: refs/heads/master@{#818717}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7411aeba4d3b..e6f794f1dc5d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3a4fe97cd8b8d1b97a5a3c085a601467bc8327cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485623Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818716}
-
Mario Bianucci authored
Each of the 6 test cases in this test take a minimum of 200ms due to the waitForAnimationEndTimeBased call. This was resulting in flakiness due to being too close to the default timeout for web tests. Fix the flakiness by separating them into two separate tests. Leaving these tests disabled as there appears to be a different underlying issues causing failures on Mac. Bug: 1038354 Change-Id: I9fbf07f1e5a76e770bb1c028615fa36bbb6123fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477478 Commit-Queue: Mario Bianucci <mabian@microsoft.com> Reviewed-by:
Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#818715}
-
Patrick Monette authored
Bug: 971272 Change-Id: I72255f8f388281977045954b1b80a28240e27b33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435580 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#818714}
-
Frank Tang authored
In the landing process of ICU68 we found these need to be changed since ICU68 no longer define TRUE and FALSE for UBool to avoid C++20 problem. Bug: 1138555 Change-Id: I64fd98c99864aa86b07280537a780105cb0eabbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473522Reviewed-by:
Frank Tang <ftang@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Guillaume Jenkins <gujen@google.com> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#818713}
-
Eugene But authored
Append persisted breadcrumbs to Syntheric Crash report. After this CL Synthetic Crash reports will be uploaded only if Breadcrumbs feature is enabled as without Breadcrumbs these reports are not useful. Bug: 1103752 Change-Id: Ia4489b86f07ea7f77e012abb8c0124d7347c2871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410302 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#818712}
-
chinsenj authored
Currently if a user taps on a window cycle list item it only moves the focus ring to that item. Based on UX feedback, this interaction should be changed such that when a user releases their finger the selection is confirmed. This CL implements that feedback. Test: manual + modified existing test Bug: 1136625 Change-Id: I64736f3f98fe0b21efc1211d0e64749a42cde40b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468918 Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#818711}
-
Alexey Baskakov authored
This CL introduces no behavior changes. Now WebAppRegistrar::GetAppIds() uses foreach GetApps(). In follow up CLs: - rename AllApps() to GetAppsIncludingStubs() (urgent) - migrate more cases to use GetApps() instead of AllApps() (not urgent) Implementation details: AllApps() and GetApps() use protected method FilterApps(filter). In general, FilterApps() allows to iterate over various subsets from AllApps(). Internally, Iter::FilterAndSkipApps() filters out unwanted entries. Bug: 891172 Change-Id: I9a136f9b4f77e77eac28e13d9281453015145925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1295131Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#818710}
-
- 19 Oct, 2020 25 commits
-
-
tby authored
We're still using all metrics for the local search service and auto screen brightness, which are nearing expiry. This extends them all to 2021-06-30. Bug: 1139968, 1139969, 1139970, 1139971, 1139972, 1139973, 1139974, 1139975, 1139976, 1139977, 1139978, 1139979, 1139980, 1139981, 1139991 Change-Id: Iae29437854b38d99e450c48ea6b8f8d783c58d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485994Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#818709}
-
Dongjun Kim authored
OnPaymentAppInvoked() is not invoked immediately after invokePaymentApp(). This patch renamed from ServiceWorkerPaymentApp::OnPaymentAppInvoked() to ServiceWorkerPaymentApp::OnPaymentAppResponse(). Bug: 1132405 Change-Id: I7f6ba3bf40061e23a7c8c48264137023e4a4ba12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483948Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: DongJun Kim <djmix.kim@samsung.com> Cr-Commit-Position: refs/heads/master@{#818708}
-
Tommy Li authored
Currently, on-focus logic (like select-all, unelide) is distributed between LocationBarView and OmniboxViewViews. Having it exist in LocationBarView is undesirable for two reasons: 1. All of the calls call into omnibox_view_->FooBar(), so the parent class is containing logic that wholly should belong in the child view. 2. The logic cannot be unit tested within OmniboxViewViewsTest unit test. This forces us to put it in a browser test, which is slower and flakier. This CL moves this logic into the child OmniboxViewViews class. This CL also moves the browser test into the unit test. Bug: 1138113, 45260, 751031 Change-Id: Ib5d15ae849f6cd42b27f08dbfbca2c8c7d3367d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485561 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#818707}
-
Stephen Martinis authored
This CL adds a simple version of the find_bad_builds.py script. It finds builds which may contain a given CL which was landed and then reverted. Future CLs add more features to this script. See https://crrev.com/c/2464165 for a fuller description. Bug: 1137072 Change-Id: I3b4469b74d2be69af7655c20082900bbe0b5377f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469226 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#818706}
-
Scott Violet authored
BUG=1140143 TEST=none Change-Id: If89a59ce8992c13ef269b24dbe0a1458c72718fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485842Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#818705}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1dd069208c86..5d9297643221 2020-10-19 thestig@chromium.org Do not process CMYK images in CompositePalBitmapLine(). 2020-10-19 thestig@chromium.org Remove FXRC_CMYK_OUTPUT. 2020-10-19 thestig@chromium.org Remove CMYK support from CFX_SkiaDeviceDriver. 2020-10-19 thestig@chromium.org Simplify CFX_Renderer. 2020-10-19 thestig@chromium.org Remove CMYK output support from CFX_Renderer. 2020-10-19 thestig@chromium.org Tidy CFX_Renderer. 2020-10-19 nigi@chromium.org Change Arial font's charset value to CHARSET_FLAG_ANSI for testing. 2020-10-19 nigi@chromium.org Use macro definitions for charsets in CFX_FolderFontInfoTest. 2020-10-19 nigi@chromium.org Fix |pitch_family| values in CFX_FolderFontInfoTest. 2020-10-19 thestig@chromium.org Declare 1 variable per line in CFX_ScanlineCompositor. 2020-10-19 thestig@chromium.org Get rid of dead CYMK output code in CPSPrinterDriver and CFX_PSRenderer. 2020-10-19 thestig@chromium.org Use std::make_unique() in more Windows-only fxge code. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1017562 Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ic2bff448d3fcb5b42d516be37243c368137a8358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486278Reviewed-by:
-
Ahmed Mehfooz authored
Crash happens when a click is generated with the search+space key combo in chrome vox on the settings button of a notification. Bug: 1137023 Change-Id: I716efb465ed0697029781ee0b450c46529addbd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483767Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#818703}
-
Nancy Wang authored
During the system shut down phase, GetToplevelWindow could cause the system crash because the top window might be destroyed, so use the local variable tab_window_to_browser_window_ to get the browser window for the tab to resolve the OnWindowVisibilityChanged crash issue. BUG=1136373 Change-Id: I60981eb9720a6489544d81fe16a25f01226553dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485371Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#818702}
-
Devlin authored
This reverts commit 98fbece2. Reason for revert: Looks like this CL causes AXTreeSerializerTest.DuplicateIdsReturnsErrorAndFlushes to fail on TSAN. Original change's description: > Increase reporting of accessibility errors (Round 2) > > Make [de]serialization errors fatal for any kind of build used to > debug Chromium errors. This also restores the fail fast behavior in > ADDRESS_SANITIZER, which was removed in CL:2468238, because it > was mistakenly believed the address sanitizer builds had DCHECks on. > > AX-RelNotes: n/a > Bug: None > Change-Id: I664ab8af7c667b932bbe650c732706d71db9a583 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480142 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Daniel Libby <dlibby@microsoft.com> > Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> > Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818639} TBR=sadrul@chromium.org,dmazzoni@chromium.org,aleventhal@chromium.org,dlibby@microsoft.com,dlibby@chromium.org Change-Id: Icfc7c6055a401d22df25ba06b6b266943b15da62 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486448Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#818701}
-
Nancy Wang authored
When the window is destroyed, the window pointer in activation_permissions_ is not erased, which might cause crash when activation_permissions_ is deleted during the system shut down phase. Add AppServiceAppWindowCrostiniTracker::OnWindowDestroying to erase the window from activation_permissions_ when the window is destroyed. BUG=1136392 Change-Id: I5a542e06fe63d84a8bf257533f428cd16bf5e044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483709Reviewed-by:
-
Patrick Monette authored
Change-Id: I16f15a67650354cb2124aeb8bc68128826733c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443397 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
-
Hai Bi authored
Allows clients to flush the buffer for metrics data on-demand, e.g. just before program termination. bug: b/159458935 Test: Added unit test Change-Id: I6bd287eb99fba4c153a96a22881efc4353264664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478202 Commit-Queue: Hai Bi <bihai@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#818698}
-
David Maunder authored
This is currently being performed using the sequenced task runner. Tab metadata files will continue to be executed on the serial task runner. Bug: 1132874 Change-Id: Ief6b54814416d5b123f7eb45f11f6ae9bc777d39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435147 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#818697}
-
Sean Topping authored
Bug: local 169779668 Test: tryjobs Change-Id: I7978e19241c1041c9a91533e6098684f7a4c9f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486075Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Sandeep Vijayasekar <sandv@google.com> Cr-Commit-Position: refs/heads/master@{#818696}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f4f1d8a352ca..5b99b448b3db 2020-10-19 bclayton@google.com Fix uninitialized use of TIntermediate::resource (#2424) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: If679aafe95c402ae4df59d5c44055413b3b7be69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486441Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, Chromium developers could call RenderFrameHost::IsCurrent() to check whether the frame is about to be deleted without understanding that IsCurrent() can return false temporarily, e.g., when in bfcache. This patch adds comments to RenderFrameHost::IsCurrent() and WebContents::FromRenderFrameHost() that explain how IsCurrent() should be called before FromRenderFrameHost(). After this patch, it should be more clear to Chromium developers that IsCurrent() should be used to check whether FromRenderFrameHost() can be called. Change-Id: I7bba60ca7e73e3ff5c4320ffe8f3ee1be00393be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461590 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#818694}
-
Ahmed Mehfooz authored
The animation_metrics_reporter_ in UnifiedSystemTrayController was being destroyed before the animation_. This could cause a crash when the tray is destroyed during an animation. Bug: 1137498 Change-Id: I1248e362947941f739a6d73fc67645d372e8af0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485141Reviewed-by:
-
Etienne Bergeron authored
This CL is fixing a shutdown hangs caused by a condition variable wait(...). The code is scheduling a background task that will never be executed which is causing a deadlock. see: https://bugs.chromium.org/p/chromium/issues/detail?id=1086185#c24 Bug: 1086185 Change-Id: Ie401cd284d6af29f6c8c5da8ed085c72a81a0487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485635Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#818692}
-
Donn Denman authored
Disables a set of tests that are failing on M87 on Android. We plan to land on Master, merge into M87, revert on Master (since it has been addressed on Master). BUG=1137967 Change-Id: I6f38149b21df33d1354394322b7bad9ff492dad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481629 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#818691}
-
wutao authored
The about flag has limitation to set up params for features. Remove the ambient mode flag otherwise will be conflict with finch experiment. Bug: b/171088716 Test: Manual Change-Id: I7d5a3aeaf299011f808db85ee4a400c899963304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481787Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#818690}
-
Andrew Xu authored
ClipboardHistoryItemView::SelectionFlag indicates both children visibility and the view responding to user actions (such as clicking on the menu item or pressing ENTER key). It damages code readability. To solve this problem, this CL does the following things: (1) Remove SelectionFlags. Use PseudoFocus to infer children visibility. (2) An enum class called PseudoFocus is introduced to specify the view responding to user actions. This CL should not introduce any visual difference. Bug: 1134422 Change-Id: I57541d081575a5f66606961281b717f1b253f9b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483586Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818689}
-
Ian Prest authored
This is a reland of 78b97c89 Also updated the tsan_suppressions.cc file with the updated names of the globals that were moved. Original change's description: > Move Skia SkFontLCDConfig globals to Chromium > > This change eliminates the usage of the deprecated SkFontLCDConfig, > which stores font-related monitor properties in some global variables. > Chromium is the only client of this deprecated API, and the Skia team > has wanted to remove it for some time. > > Unfortunately, the use is fairly widespread within Chromium: > 1. The globals are set directly in a handful of places via calls to > SkFontLCDConfig functions. > 2. The globals are used (indirectly) whenever an SkSurfaceProps is > initialized with the kLegacyFontHost_InitType flag, and also when > an SkCanvas or SkSurface are created without specifying the props. > > The correct long-term plan would be to retrieve the values from the > Display (ideally per-monitor values) and pass them along as needed. > But given the extensive usage, the only reasonable short-term approach > is to lift the globals out of Skia and bring them "in-house" into > Chromium. > > To that end: > -- Undefines SK_LEGACY_SURFACE_PROPS. > -- New globals and APIs in /skia/ext/legacy_display_globals.* > -- Replaced "SkSurfaceProps(kLegacyFontHost_InitType)" with calls to > new API: skia::LegacyDisplayGlobals::GetSkSurfaceProps() > -- Found places where SkCanvas and SkSurface were created and props > weren't already specified; passing the LegacyDisplayGlobals in most > cases, but `nullptr` (or empty SkSurfaceProps) if it was clear > without doing much analysis that no text was being drawn. > > This gets us closer to the end-goal by allowing Skia to fully remove > the deprecated APIs, and also surfacing a lot of places where the use > of the globals was hidden by indirect usage. > > Change-Id: I8fffaee4933c03ee828d2ffab858f53d92c59f4d > Bug: 1126992, skia:3934 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378763 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Ben Wagner <bungeman@chromium.org> > Reviewed-by: Michael Spang <spang@chromium.org> > Commit-Queue: Ian Prest <iapres@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#818197} TBR=sky@chromium.org Bug: 1126992, 328826, skia:3934 Change-Id: I8911a67cb8a9d4079b993feaff29ff8abd02dd94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486073Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Ian Prest <iapres@microsoft.com> Cr-Commit-Position: refs/heads/master@{#818688}
-
Lukasz Anforowicz authored
To consume win32-specific cmdline parameters (e.g. -imsvc, /FI or /Yu) clang needs to be invoked with `--driver-mode=cl`. This CL ensures that the driver-mode cmdline switch is appended not only when running a rewriter tool on Windows, but also when run_tool.py or generate_compdb.py are invoked with an explicit --target_os=win cmdline argument. Manual tests: 1. Manually run unit tests for tools/clang/pylib/clang/compile_db.py: $ pushd tools/clang/pylib/clang/ $ python compile_db_test.py 2. Manually tried running the rewriter on linux, when targeting win: $ cat out/rewrite-win/args.gn clang_use_chrome_plugins = false target_os = "win" $ tools/clang/scripts/run_tool.py --tool rewrite_raw_ptr_fields \ --generate-compdb --target_os=win -p out/rewrite-win \ content/browser/renderer_host/render_process_host_impl.cc \ >~/scratch/rewriter.out 3. Manually tried running generate_compdb.py: $ tools/clang/scripts/generate_compdb.py -p out/rewrite gn_all \ -o ~/scratch/compdb Bug: 1069567 Change-Id: I54fcee164d7bb05119c8267b43e0d872bc2f436b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481745 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#818687}
-
Esmael El-Moslimany authored
The recipe task module is mostly the same as the shopping task module. This CL is mostly a copy of the shopping task module. Removing the duplication will be addressed in a follow-up. Renamed the UI string IDs. No change to the strings. Screenshot: https://screenshot.googleplex.com/7pbxJMPP2QgAgkM Bug: 1138011 Change-Id: Ib709c1dd35a7f05058570ba4c1bf1bc7dddb7d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469401 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ib3e39d1f1ae411a63d1bb8f75c9a714ba5eb60b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486276Reviewed-by:
-
