GitLab

This CL uses correct warning icon for sign-in general error and adds
render tests for the sign-in general error view.

Bug: 1120308
Change-Id: Ie25b8be7fca803ea49dfbc855dac41bc2bd89f8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379751Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803163}

Bug: b:154865204
Change-Id: I0edd7de777ecdcade982e9dadb30449d0c4b5b77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385875Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#803162}

https://chromium.googlesource.com/angle/angle.git/+log/6ec0b23923e9..7b5439987f75

2020-08-31 jmadill@chromium.org Remove Vulkan repos from export targets ignore list.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: cwallez@google.com
Change-Id: Ie5f8754241736c00e24cb3d542a67f17c7d96ee4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385679Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803161}

- Add the thumb strip coordinator to the browser coordinator.
- Add a reference to the thumb strip pan handler inside the BVC so that
the BVC can add the tab strip and the toolbar as animatees of the view
revealing vertical pan handler.
- Implement the view revealing animatee protocol: when revealing the
view, the tab strip should be translated down to be hidden behind
the toolbar.
- Set the BVC's background colour to clear and remove the fake status
bar so that the thumb strip can be visible from behind those.
- Add a pan gesture recognizer to the toolbar and tab strip, the first
set of entry points to the thumb strip.
- Set the tab strip to be below the toolbar in the view hierarchy so that
it can slide behind the toolbar during thumb strip transitions.

Bug: 1094335
Change-Id: Ic749236f70f5c3a589ae70e5b6a9442e85acf517
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315029
Commit-Queue: Roberto Moura <mouraroberto@google.com>
Auto-Submit: Roberto Moura <mouraroberto@google.com>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803160}

When these were implemented [1] the polarity was reversed: secure
origins are counted as insecure, and vice-versa. This CL fixes that
swap. Since there isn't much that can easily be done with the
existing data on chromestatus.com, there will be a spike/swap
that happens in the data when this lands. Since the alternative is
just to leave this "broken" forever, I think it'll be better to
start collecting the correct data from now on.

[1] https://codereview.chromium.org/1166473002/diff/40001/Source/core/html/forms/FileInputType.cpp

Fixed: 994940
Change-Id: I06a7844abd7e54147d855e0b9046fe86870fa5d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380251
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803159}

This CL adds |mProfileSupplier| local variable that is observed for
profile changes. |mProfileSupplier| is used to pass profile param to
IdentityServicesProvider.

By this CL;
- |mProfileSupplier| notifies the class when the current profile is
changed.
- When current profile changes, setProfile function is triggered and
mIdentityManager is updated with the new profile.
- Introducing |getSyncAccountInfo| function that uses current profile
(i.e., off-the-record or regular) and returns account information. This
function returns null for OTR profiles.
- Passing current profile to tracker instead of using always regular
profile to fix unsafe usage of profile.
- Adding |testIdentityDiscWithSwitchToIncognito| to test identity disc
disappear when switching to incognito NTP from sign-in state.

Bug: 1041781, 1075562, 1048632
Change-Id: Icd443c03033b5a20c1ba0b680f57c05dfc21222d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307253
Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803158}

https://skia.googlesource.com/skia.git/+log/ffd61ca01246..4c2928bb0d5f

2020-08-31 mtklein@google.com deserialize drawPoints() mode safely
2020-08-31 bsalomon@google.com Revert "Experiment to see if ANGLE ES2 vs ES3 perf is related to GLSL ver"
2020-08-31 johnstiles@google.com Refactor inlineCall() to take a FunctionCall and SymbolTable as input.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: michaelludwig@google.com
Change-Id: I93c4847beed9cc2fc51e12b2a48c28192f9a9c68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385683Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803157}

This patch batches all the tests in BottomSheetControllerTest.
Consequently, some new methods to reset the sheet's state were added
to the test support classes and BlankCTATabInitialState was updated to
support any subclass of ChromeActivity.

Bug: 1122163
Change-Id: I3fbb73431eff206010d93d8c5e26e4942b84adb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377664Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803156}

This CL adds the following metrics for the profile picker:
- ProfilePicker.AskOnStartup
- ProfilePicker.AskOnStartupChanged
- ProfilePicker.NewProfileCreateShortcut
- ProfilePicker.NewProfileTheme
- ProfilePicker.Shown
- ProfilePicker.UserAction

Fixed: 1123001
Change-Id: Idf26a17b77e748b90358f07305b2968e79bcc379
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379918
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803155}

Fix use-after-move (potential) bugs found by the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: I7308e0fe69cf248829d11125456b3f43d2b7ae01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382074Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803154}

Disables an unittest that tests OOM allocation behaviors when
USE_PARTITION_ALLOC_AS_MALLOC because PartitionAlloc-based
malloc() does not return nullptr and crash instead.

Bug: 998048
Change-Id: I8173667512c9041fb68a4cb441ddf11766f2dbdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374925Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803153}

The boolean BlockThirdPartyCookies preference was replaced by
CookieControlsMode enum. Existing settings were migrated since M83.

Fix handling of CookieControlsMode::kIncognitoOnly state, which is
the new default, where 3p cookies are allowed in regular mode
but blocked in incognito mode. Previously the extension api would
not report the state correctly in incognito mode unless it is explicitly
set to block or allow.

Bug: 1104836
Change-Id: Idad018d7a23aca913888fe6a66eb0502e26525a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367095
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803152}

Do not invalidate children all the way up to the unignored ancestor,
only invalidate a single node included in tree, either |this| or the
first ancestor included in the tree.

This is a precursor to fixing terrible performance loading large chat
rooms on chat.google.com, but it does not yet fix the issue nor
the related perf_tests. In order to fix that, it will be necessary
to include more nodes in the tree as well.

Bug: 1107988
Change-Id: I8a1f267a243ff1eda3d186e4c872eac75b40d792
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383293
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803151}

This is a reland of e0309342

Original change's description:
> Policy WebUI: 'Reload Policies' button reloads google update policies
>
> Bug: 1119703
> Change-Id: Ib91b37dc1da4f06782caea7b67ecc6d0c8c87b2d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367673
> Commit-Queue: Yann Dago <ydago@chromium.org>
> Reviewed-by: Owen Min <zmin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#802644}

Bug: 1119703
Change-Id: I0542a481dc512b1c214e050084114cf313c10baf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382216Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Yann Dago <ydago@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803150}

Some of the tests were not working with the new illustrated empty
states. An interface needed to be added to access the feature status
in Chrome app as opposed to the test app.

Change-Id: I1f7bf0e3d8e3e17cdbfca8948377e5086ae78059
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378714
Commit-Queue: sebsg <sebsg@chromium.org>
Auto-Submit: sebsg <sebsg@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803149}

In CL:2350026, I tried to be clever and eliminate the unused
FidoDiscoveryFactory argument from SetPINHandler. However, its base
FidoRequestHandlerBase ctor expects a pointer to the discovery factory
and is run before initialization of the SetPINHandler data members, and
so we now pass it the address of an uninitialized member.  Instead,
inject the FidoDiscoveryFactory from the outside, like before.

Bug: 1122892
Change-Id: I8ea881c57c9dc2b3c33c1bda2f0512459f3a7c47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384133Reviewed-by: Adam Langley <agl@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#803148}

Fixed: 1123225
Change-Id: Ied7432e2dfede4f126da879ce139e7cc9e883ca1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384910
Auto-Submit: dpapad <dpapad@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803147}

This patch adds `third_party/hyphenation-patterns` from:
https://android.googlesource.com/platform/external/hyphenation-patterns/

Please see README.chromium. Exceprts below:

Description:
Hyphenation patterns for automatic hyphenation from Android. The data is
originated from TeX hyphenation patterns project at http://www.hyphenation.org,
modified by Android engineers. See src/README.android.

Local Modifications:
* The script `build_hyb.sh` is added to generate binary data files
  for the minikin library. Also the `hyb` directory contains the
  binary data files generated by the script.
* The `LICENSE` file was generated by concatenating `NOTICE` or
  `LICENSE` files in each locale directory.
* Removed `src/OWNERS`.

Bug: 1093555
Change-Id: Ie155442c902811b33f32708e53c3a7e92877979b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254498Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803146}

This change makes the audio device picker invisible when the
MediaSessionInfo object reports that changing audio devices is not
possible.

The MediaNotificationContainerImplView will notify the device picker UI
when the support for device switching changes.

The MediaNotificationService will provide the device picker UI with
the support boolean when the UI is constructed.

Bug: 1120620
Change-Id: I09a35135569a79800fbe5ade0c36a5f37f6bee70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368051
Commit-Queue: Noah Rose Ledesma <noahrose@google.com>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803145}

Currently, ChromeOS defines the OS_LINUX directive as well as
OS_CHROMEOS.  We're working to separate these two, so we're
making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS
explicit.

This is changes for /google_apis/gcm

This CL was uploaded by git cl split.

R=dimich@chromium.org

Bug: 1110266
Change-Id: I2403e075be078395a691fdf6ea1f04e33dc76fa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370299Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Sean McAllister <smcallis@google.com>
Cr-Commit-Position: refs/heads/master@{#803144}

This reverts commit 20aca0dd.

Reason for revert: The issue has been resoved in crrev.com/c/2384070

Original change's description:
> Revert "Chrome OS: Use layer animation browser window frame activation animation."
> 
> This reverts commit 3a2299e5.
> 
> Reason for revert: Suspected breaking https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/38374 and https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/20193
> 
> Original change's description:
> > Chrome OS: Use layer animation browser window frame activation animation.
> > 
> > This is a revised version of original attempt crrev.comc/c/2166804.
> > Instead of creating a new layers, this clone and animate the window's layer,
> > but makes sure that the animating layer is at the bottom of other layers
> > within the window.
> > 
> > * It adds a invisible view with a layer
> >   at the bottom of the non_client_view (no frame w/o this, so we can exclude such case).
> > * Adds the animating layer as a child of this view, with
> >   "SetMasksToBounds(false)" so that it will not be clipped during animation.
> > * Once animation is done, this animating, old layer will be removed.
> > 
> > Bug: 1073685
> > Test: covered by unittests.
> > Change-Id: Ib5ae6a218d200394c54932e5b559217fcc7f89e1
> > Fixed: 2
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375686
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#802386}
> 
> TBR=sky@chromium.org,oshima@chromium.org
> 
> Change-Id: I10600b9bc69818257f66fb5c1ae86f7fd1119c75
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1073685
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381217
> Reviewed-by: Melissa Zhang <melzhang@chromium.org>
> Commit-Queue: Melissa Zhang <melzhang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#802539}

TBR=sky@chromium.org,oshima@chromium.org,melzhang@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1073685
Change-Id: I38725fa15f79576db154db91f7ca384578f545b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385815Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803143}

This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/2353461
implementing suggestions on struct member types.

Bug: chromium:1116430
Change-Id: I27d89e5c22b0bb258112fa68a82f97da9e87777b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375168
Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803142}

Fix use-after-move (potential) bugs found by the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: I7c78266d7455037d4262d6c272fed1dfcd89df8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382833Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803141}

Fix use-after-move (potential) bugs found by the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: I4ea0a82440442e986e82a41206a0904223d2a858
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382816Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803140}

https://android.googlesource.com/platform/external/perfetto.git/+log/79257bae3c9a..19157ee4a2fd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I79dc15535412b5924bab29d9802097d1da4b57fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385241Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803139}

It's flaky as far as flakiness dashboard history goes.
Recently introduced in https://chromium-review.googlesource.com/c/chromium/src/+/2348294
assigning as such.

TBR=dmblack@google.com, xiyuan@chromium.org

Bug: 1123542
Change-Id: I8195565f33e6637401a77326513f551c17ca4661
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385755Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803138}

Change:
* break down parseAndValidateDetailsOrDisconnectFromClient into
business logic (parsing details) and UI logic (updating UI with
details).
* move the client-disconnection logic out of
parseAndValidateDetailsOrDisconnectFromClient.

Bug: 1102522

Change-Id: I3636884ba883d38eb75e3584b3205b2c13d26abd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382406
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803137}

Currently, ChromeOS defines the OS_LINUX directive as well as
OS_CHROMEOS.  We're working to separate these two, so we're
making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS
explicit.

This is changes for /components/cookie_config

This CL was uploaded by git cl split.

R=blundell@chromium.org

Bug: 1110266
Change-Id: I61908a6d547eb9efefc9cc4e07e7f95188f3c1df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371286Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Sean McAllister <smcallis@google.com>
Cr-Commit-Position: refs/heads/master@{#803136}

importMinidumpsCrashKeys may return null. The code was not
handling that.

BUG=1123207
TEST=none

Change-Id: Ibf775a9b053d8c051beb741e43daebc0d3c68fe5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382876Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803135}

Fix use-after-move (potential) bugs found by the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: I9b268c698d8be0a349867f31d78868fd5e25644c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383018
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803134}

Nits and misc cleanup as a follow-up to landing Perfect Negotiation
and "onsignalingstatechange" patches, some of which were pointed out in
earlier code reviews but weren't fixed to avoid excessive rebasing.

Changes include:
- Now that RTCPeerConnectionHandler::OnSignalingChange only does thing
  related to the tracker, it is renamed TrackSignalingChange, and it is
  called after TrackSessionDescriptionCallback to be consistent with the
  order prior to my patches.
- Readability: use of auto, for-each and std::move.
- Remove TODOs and introduce a DCHECK.

TBR=hta@chromium.org

Bug: chromium:1122561
Change-Id: Ie888441e07ad2e5f18a7d72bfacb674a356e1305
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385356
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803133}

Currently, ChromeOS defines the OS_LINUX directive as well as
OS_CHROMEOS.  We're working to separate these two, so we're
making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS
explicit.

This is changes for /chrome/browser/metrics/process_memory_metrics_emitter_unittest.cc

This CL was uploaded by git cl split.

R=siggi@chromium.org

Bug: 1110266
Change-Id: I9014a8e3003f5dba8151c2599d550441a401d7a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371255Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Sean McAllister <smcallis@google.com>
Cr-Commit-Position: refs/heads/master@{#803132}

https://skia.googlesource.com/skia.git/+log/c23eeb8c78ec..ffd61ca01246

2020-08-31 bsalomon@google.com Simpler SkYUVAPixmapInfo construction

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: michaelludwig@google.com
Change-Id: I44d8b1ce12eb81def266833d8a3757dc3a2728dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384861Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803131}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/be19a45481cf..4191c5c973ed

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC gab@google.com,kolos@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: gab@google.com,kolos@google.com
Change-Id: Ifc5e459ee9379a1f83e36e741af46c8c274e5f06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384862Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803130}

Fix use-after-move (potential) bugs found by the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: Ie1df128b9c677f4b86ea138cb8087cd68285dbbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383012Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803129}

increases the maximum precision of the graphs drawn to 3
since we can have values like jitter or roundtrip time which are
measured in seconds but can have millisecond values

BUG=chromium:678292

Change-Id: Ibcde153a518d65d1beae2cfb137f39da602b131c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382837Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Commit-Queue: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803128}

Recent regressions.
conformance/reading/read-pixels-pack-alignment.html
conformance/rendering/clear-after-copyTexImage2D.html
conformance/rendering/gl-viewport-test.html
conformance/rendering/multisample-corruption.html
conformance/textures/misc/tex-image-canvas-corruption.html

TBR=bsheedy

Bug: swiftshader:154, 1123524
Change-Id: I0cb48304919cfe96065d1bfdecaa22fe5680babf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385595Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803127}

The CSSWG resolved in https://github.com/w3c/csswg-drafts/issues/4568
that properties like 'text-indent' that don't apply to ::marker, should
not be able to affect the ::marker via inheritance when set to an
ancestor.

Therefore, this patch sets 'text-indent: 0 !important' in UA origin.

Bug: 1031667

TEST=external/wpt/css/css-pseudo/marker-content-023.html
TEST=external/wpt/css/css-pseudo/marker-default-styles.html
TEST=http/tests/devtools/elements/styles-2/pseudo-elements.js

Change-Id: I4dd9e8afd448bd5fe237c084d3c0215e91560dd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382750Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#803126}

Currently, ChromeOS defines the OS_LINUX directive as well as
OS_CHROMEOS.  We're working to separate these two, so we're
making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS
explicit.

This is changes for /chrome/updater

This CL was uploaded by git cl split.

R=sorin@chromium.org

Bug: 1110266
Change-Id: Ic96765ed15e30fdc5c6c84804c75f4290dcefc8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370289Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Sean McAllister <smcallis@google.com>
Cr-Commit-Position: refs/heads/master@{#803125}

Fix use-after-move (potential) bugs found by the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: I1aa8dc85cdb849382d1dc6ece9b03d0c435cf4ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382852Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803124}