- 09 Nov, 2020 40 commits
-
-
Danila Kuzmin authored
When the weak PIN is allowed, we don't need to show the warning message to user. But when the policy is unset we still show it. Bug: b/168498866 Change-Id: I56571851ca43144b2e05f31978814d0b9c384b64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490040Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Cr-Commit-Position: refs/heads/master@{#825325}
-
Matt Jones authored
Bug: 1070281 Change-Id: I19100a2ab284f430ce50247bb62e85352fb8343f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521283 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#825324}
-
Wojciech Dzierżanowski authored
Follow up on https://chromium-review.googlesource.com/c/chromium/src/+/2470525 by moving the remaining fullscreen tests to PictureInPictureContentBrowserTest. The focus is on the video element state transitions rather than the PiP UI. This also improves testing stability: Even though these tests are not marked as flaky, they do fail from time to time when run locally. Last but not least, fullscreen as implemented in Content Shell is less obtrusive than Chrome's full-fledged fullscreen when running tests, so this improves the developer's experience. Bug: 1138168 Change-Id: I51adf3541f8a8ab74ac0f7259e29efaa024b14ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511252 Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#825323}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9290b6b5. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I1311638bdd29b180595a3493d199a0065cfc639f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526201Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825322}
-
Jan Wilken Dörrie authored
This change adds a PasswordGenerationType parameter to PasswordManagerClient::GeneratePassword(). This allows to track the type of the generation more precisely and fixes a bug in metrics recording where automatic generation was logged as manual instead when existing credentials were present. TBR=dcheng Bug: 846694, 918846 Change-Id: I06a065926a1f4dc94fd72b3b96199c799587a9b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520998 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#825321}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0e30faf062f7..9eff30af501c 2020-11-09 lalitm@google.com Merge "Handle erroneous cases in Frame lifecycle phases" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib3912dbb84822c043ce9090d17ce10f3323c634c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526374Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825320}
-
Denis Kuznetsov authored
This CL removes supervised users-specific Authenticator and UserFlow classes, to simplify further work on refining LoginDisplayHost APIs. TBR=treib@chromium.org Bug: 866790 Change-Id: I151e2d273ba57fac989b1fcd87923d30f9851cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517440Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e42e853638c4..f2eb30ce3c37 2020-11-09 karntino.c.areros@gmail.com Prevent auto-adding 'px' within CSS calc() 2020-11-09 changhaohan@chromium.org Refactor CSSAngle for more modularity 2020-11-09 jacktfranklin@chromium.org Change component custom events to kebab case 2020-11-09 aerotwist@chromium.org [unit test] Import more of front_end/sources 2020-11-09 sigurds@chromium.org Remove enclosingNodeOrSelfWithNodeName from Node's prototype 2020-11-09 alexrudenko@chromium.org Add align-items: center icon 2020-11-09 sigurds@chromium.org Expose COEP info for dedicated workers in frame tree 2020-11-09 sigurds@chromium.org Display description in console.table if preview is not available. 2020-11-09 szuend@chromium.org Convert MarkdownIssueDescription.js to TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1051466,chromium:1057090,chromium:1126178,chromium:1139945,chromium:1145972 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9815fd5b03e658909f378868737f25cd1793d15b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526366Reviewed-by:
-
Nohemi Fernandez authored
This patch gives us the ability to switch between infobar titles, either with "Sign in as [fullname]" or "Sign in to Chrome", depending on final UX decisions. Bug: 1145592 Change-Id: Ifba41e4aa025ec51d80e76ec79015ace375be103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526061 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#825317}
-
Ilya Nikolaevskiy authored
This CL makes all the relevant tracks/capturers to return a feedback callback upon connection to the source or starting the capture. The call chain results in VideoCaptureImpl method being plumbed to the client as a callback. This is the first step for removing VideoFrameFeedback from the media::VideoFrame. Follow-up CLs will introduce the callbacks to mirroring service (which is a second user of feedback mechanism) and would remove VideoFrameFeedback member from media::VideoFrame. Bug: chromium:1134073 Change-Id: I61dfc8449e69ad53f3fc6610d8cfbf4cdb6e4441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489644 Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/heads/master@{#825316}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I135b5c7b7d8852cf66364762987840d69adc7d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526480Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#825315}
-
Denis Kuznetsov authored
Bug: 1144159 Change-Id: Iaaf65a1b3b228155344aaeb316f1682591496730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519973 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Renato Silva <rrsilva@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#825314}
-
Alexander Lapshenkov authored
Use explicit scope qualification in alias declaration. Error example: -c ../../ui/accessibility/platform/inspect/tree_formatter.cc -o obj/ui/accessibility/platform/platform/tree_formatter.o In file included from ../../ui/accessibility/platform/inspect/tree_formatter.cc:5: ../../ui/accessibility/platform/inspect/tree_formatter.h:26:40: error: declaration of ‘using AXTreeSelector = struct ui::AXTreeSelector’ [-fpermissive] using AXTreeSelector = AXTreeSelector; Bug: 819294 Change-Id: Ic604b34def922d5f6e9f5181cb2052433282c6fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524535Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#825313}
-
Viktor Semeniuk authored
This CL introduces Hash Affiliation Fetcher, that makes a request to Google endpoint to get the affiliations and groups for requested facets. Instead of sending facet URLs in a plain text it uses SHA-256 to compute a hash and eventually sends just a 16-bit short hash prefix represented by uint64_t. Bug: 1108279 Change-Id: I3a4b64c10bdd998dcf7081eec92d70b2431baef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440502 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#825312}
-
Christoph Schwering authored
This CL replaces the usage of the form's name (<form>'s name or id attribute) and Autofill::unique_name() in the refill logic with unique form renderer IDs, if the feature AutofillRefillWithRendererIds. Bug: 896689, 1114787 Change-Id: Ib21b838f9dc5f31ac30087e347d7e1b0171aff58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235600 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#825311}
-
arthursonzogni authored
They were differing for the 'ftps' scheme. This was handled by blink/, but not for url/. Chrome never supported the 'ftps', so I chose to remove it on one side instead of adding it on the other. There is a new fuzzer checking an origin stays SameOrigin with itself after a round trip inside blink: third_party/blink/renderer/platform/weborigin/security_origin_fuzzer.cc Bug: 888079 Change-Id: Idf8813e03449461c4d22d4f5ede662cb58ef185f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509754 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#825310}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/22679f90..b01fdf67 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I367a8892515e1e7eeb5772590ed9e4fd2e5f2a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525843Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825309}
-
Polina Bondarenko authored
BUG=none TEST=none Change-Id: I9d883019c615bb2319e9f7f1dc5d8e5e1dae8bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526063Reviewed-by:
Oleksandr Peletskyi <peletskyi@chromium.org> Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#825308}
-
Eric Willigers authored
We implement a BlobReaderClient to receive the shared blob and store it as a file. Files are stored in a WebShare directory under CrosDisksClient GetArchiveMountPoint(). File shares larger than 50MB (kMaxSharedFileBytes) are rejected. Bug: 1110119, 1132202 Change-Id: Ia5eb134b1286ee73f3a95146c63156412cbf8c85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522276 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#825307}
-
Nico Weber authored
Ran `./tools/clang/scripts/upload_revision.py 118c3f3cf268002d1356253bac3cf5300f054d43`. Bug: 1146453 Change-Id: I6c80be9ea8318a5da291eaa6c9ccf8b281e1b0e6 Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chromium/try:linux-chromeos-dbg Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:mac-arm64-rel,mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:win-asan,win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,mac-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521253Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#825306}
-
Henrik Boström authored
This wires up the use of SampleBufferTransformer inside the capturer behind flags that are disabled by default. With this CL we only convert to NV12 (we never rescale). Note that NV12 -> NV12 triggers a fast-path that returns the input camera pixel buffer, so this does not cause a copy. Flags added: - InCaptureConvertToNv12: Configures the transformer optimally. This means pixel transfer when you have a pixel buffer, libyuv when you have an MJPEG sample buffer. - kInCaptureConvertToNv12WithPixelTransfer: Transform using pixel transfer. Used for testing, will not be shipped. - kInCaptureConvertToNv12WithLibyuv: Transform using libyuv. Used for testing, will not be shipped. There is currently an issue obtaining the color space of CVPixelBufferPool-created pixel buffers. Until this is resolved, we hardcode the color space to kColorSpaceRec709Apple which avoids color space parsing in all processes. Bug: chromium:1132299 Change-Id: I733ceebb50db0a337c542434ac9f146ba120732a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518978 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#825305}
-
Henrik Boström authored
This is a reland of be3eeb5b On "Mac ASan 64 Tests (1)", the assertion that the second pixel buffer's address will be identical to the first one does not hold. This assertion was unnecessary anyway, so it is removed. With this re-land, the IOSurface recycling uses EXPECT_EQ with IOSurfaceGetID() instead. Original change's description: > [macOS] PixelBufferPool: Test retaining IOSurface, not CVPixelBuffer. > > Pixel buffers originating from a CVPixelBufferPool are recycled when > no longer in use, previously only tested by releasing the last pixel > buffer reference and not touching the IOSurface. > > This CL tests what happens when we are retaining not references to the > pixel buffer, but references to a pixel buffer's IOSurface or > incrementing its use count. > > Outcome: > - Retaining references (base::ScopedCFTypeRef<IOSurfaceRef>) to an > IOSurface does NOT prevent recycling. > - Retaining use count (IOSurfaceIncrementUseCount) to an IOSurface DOES > prevent recycling. > > This behavior is now documented in pixel_buffer_pool_mac.h. > > Bug: chromium:1132299 > Change-Id: Ibdcd3752a4467bc495eba4b543ecd73da1b2f41f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520829 > Commit-Queue: Markus Handell <handellm@google.com> > Reviewed-by: Markus Handell <handellm@google.com> > Cr-Commit-Position: refs/heads/master@{#824814} TBR=handellm@google.com Bug: chromium:1132299 Change-Id: Ibe924d3f3ffaaca69262e9cd436c60d05e3ea2b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521623 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#825304}
-
Yifan Luo authored
`sanitize` as a DOMString to Fragment API need to go through Trusted Types. Bug: 1116418 Change-Id: Icf73ff9f7a8f115d0f9f6e32ae9673c7475691e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506046 Commit-Queue: Yifan Luo <lyf@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
-
Thiemo Nagel authored
I'm not working on this codebase anymore. Bug: none Change-Id: I8b677a6fe89cf0b53307fb787a3470d8408a3025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526101Reviewed-by:
-
Koji Ishii authored
This reverts commit 2493e000. Reason for revert: Hit test regression at crbug.com/1146797 Original change's description: > Avoid falling back to legacy if |CanTraversePhysicalFragments| > > When painting and hit-testing NG fragments, > |NGBoxFragmentPainter| falls back to |LayoutObject| at the BFC > boundary, because we already have a logic in |LayoutObject| > to switch painters for NG and legacy. > > This patch changes to do so only when |!CanTraverse|, because > |LayoutObject| cannot handle block fragmented NG objects. > > This patch eliminates |CurrentFragment| from > |LayoutNGBlockFlowMixin::Paint| by making sure it is not block > fragmented. > > Also changes |HitTestChildBoxFragment| so that it can handle > atomically-painted objects in NG code path. Due to the change > in |FragmentRequiresLegacyFallback|, such objects go to NG > code path without going through |LayoutObject|. > > Bug: 1061423, 829028 > Change-Id: Ife31d6dcd209668a489243b1158112dac44fc273 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515429 > Commit-Queue: Koji Ishii <kojii@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824316} TBR=yosin@chromium.org,tkent@chromium.org,kojii@chromium.org,mstensho@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1146797, 1146935, 829028, 1061423 Change-Id: Id228899a56bbcdd118a860e8e73ecb18a9b0d96b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525882 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#825301}
-
dpapad authored
This is done so that it is easier to view the contents of the dialog when the window is too short, or when the user has zoomed in. Fixed: 1066188 Change-Id: Ic3c1f4b8700b82e58fe4915e781cb65078cbdd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523051Reviewed-by:
-
Fredrik Söderqvist authored
SVGAnimateElement currently holds on to the computed animation value, and one of the animation elements in a sandwich is appointed the "result element". This value management is unnecessarily complex, since the lifecycle of the value is roughly create->compute->apply, and after having applied the value we no longer need it because a new one will be created on the next animation update. Clearing the value does not require actually having the value itself. Instead introduce a SMILAnimationValue structure which essentially wraps all possible animation value types. This structure is setup by CreateAnimationValue() (previously ResetAnimatedType()) and then subsequently passed to ApplyAnimation() (CalculateAnimatedValue()) and ApplyResultsToTarget(). ClearAnimatedType() is renamed to ClearAnimationValue() and CalculateAnimatedValue() is renamed to CalculateAnimationValue(). For SVGAnimateMotionElement this means we can compute the resulting transform and then apply it as the final step - i.e we don't need to compute it in-place. This should allow simplifying the application logic for motion paths in the future. Bug: 1017723 Change-Id: I205e83a8c471bbe8becb0bc4a686086d811eb482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523183 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#825299}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ed0b4d1e07fb..e42e853638c4 2020-11-09 sigurds@chromium.org [ts] Fix bug in data-grid/DataGrid.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I932c1ad498715d065d6b6d8e30aa664bea61adef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525762Reviewed-by:
-
Alan Cutter authored
This was failing compile with: ../../chrome/browser/chromeos/policy/system_proxy_manager_browsertest.cc:438:23: error: comparison of integers of different signs: 'int' and 'std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>>::size_type' (aka 'unsigned long') [-Werror,-Wsign-compare] for (int i = 0; i < auth_schemes.size(); ++i) { ~ ^ ~~~~~~~~~~~~~~~~~~~ and: ../../third_party/googletest/src/googletest/include/gtest/gtest.h:1544:11: error: comparison of integers of different signs: 'const unsigned long' and 'const int' [-Werror,-Wsign-compare] if (lhs == rhs) { ~~~ ^ ~~~ ../../third_party/googletest/src/googletest/include/gtest/gtest.h:1571:12: note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned long, int>' requested here return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs); ^ ../../chrome/browser/chromeos/policy/system_proxy_manager_browsertest.cc:436:5: note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<unsigned long, int, nullptr>' requested here ASSERT_EQ(auth_schemes.size(), ^ Change-Id: Iae6fab7566a7a36efd5b41f4c76c696de4a29e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525386 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#825297}
-
Sergey Poromov authored
When confidential content appears in the capture area and screen capture is being paused, a black frame should be sent to override the last sent capture frame. Bug: 1134566 Change-Id: I20c2859cefcc0166ae86b08cde02e5b1b8835dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521737Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Id0b45ea7578a2babe5fce156ce72028a2b6cd66d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525760Reviewed-by:
-
Tanmoy Mollik authored
Batch tests in BookmarkBridgeTest to reduce the overall running time of chrome_public_test_apk Bug: 1145843 Change-Id: Ib0f4490ea6c9bfee965ecc67eed02d29d16e149f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523327Reviewed-by:
-
Luciano Pacheco authored
Convert `var` to let/const as pointed by presumit. Convert an anonymous function to arrow function to avoid the `.bind(this)`. No change in behavior. Test: Manually tested the audio player (just in case). Change-Id: I73be16d039476b9fe9a087798f596a521b1bdabc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525884 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#825293}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d4439824c554..46f5f4386f7c 2020-11-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 52d33a46 to 61aafe63 (506 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: Ie892633aa908905b6e9b6ad09cbdb963e8ab7788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525824Reviewed-by:
-
Ewann authored
This CL fixes the Settings navigationBar background color. Bug: 922511 Change-Id: I9a59e152720c9208fbf6df709afaf66cc6f540d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523207 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#825291}
-
Christian Dullweber authored
The test fails when changing between winter/summer time due to days being longer/shorter than 24h. RevertTimeInDays assumes that every day has 24h. To fix the issue the test always runs on a fixed timestamp. Bug: 1144634 Change-Id: I55f94df979c61a3e965885eb577bc05d41612725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523032Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#825290}
-
Antonio Sartori authored
The policy container is a container for security policies that applies to a document and that we are prototyping in chrome. The implementation requires to track document policies both in Blink and in the browser. Previously, we were using a somewhat confusing naming convention, which was not coherent with the rest of chromium. This CL renames: - content::PolicyContainer => content::PolicyContainerHost - blink::mojom::PolicyContainerClient => blink::mojom::PolicyContainer - blink::mojom::PolicyContainerData => blink::mojom::PolicyContainerDocumentPolicies - blink::WebPolicyContainerClient => blink::WebPolicyContainer So that: - a RenderFrameHost owns a content::PolicyContainerHost - the corresponding LocalFrame owns a blink::PolicyContainer - content::PolicyContainerHost implements the blink::mojom::PolicyContainerHost interface - the blink::PolicyContainer holds a remote for the blink::mojom::PolicyContainerHost interface - a blink::PolicyContainer holds some blink::mojom::PolicyContainerDocumentPolicies Hopefully this makes the code easier to follow and better adheres to current chromium naming conventions. Bug: 1130587 Change-Id: Ic27955a854cb645cef19cd67dfd45e6a33571706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517467Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#825289}
-
Jesse McKenna authored
This change fixes an uninitialized pointer in the FloatingMenuButton class that triggers MemorySanitizer errors on bots. Currently, if FloatingMenuButton is initialized via its default constructor, its member `VectorIcon* icon_` is uninitialized. This causes errors when the value of icon_ is checked in SetVectorIcon(). Bug: 772945 Bug: 938501 Bug: 1130078 Bug: 1146255 Change-Id: I21f9596f496d6fd5090bd2e307dc648117be07ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523477 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#825288}
-
Alice Wang authored
This CL replaces the generic accessibility strings with more specific ones in the web sign-in bottom sheet. Bug: 1112696 Change-Id: I1dff9637b8df04a0f0f8c03940d21099196c3078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502431Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#825287}
-
Viktor Semeniuk authored
This CL adds a condition to avoid prefetching a change password URL for requested facet, if Affiliation Service already stores data for this facet from previous prefetch. The change affects WellKnownChangePasswordNavigationThrottle and saves time that would be spent on unnecessary prefetch. Bug: 1108279 Change-Id: Idcab44f3a6a277298c97a0fdde6c6f6e88f40cec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443655 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
-
