- 28 Sep, 2015 40 commits
-
-
brettw authored
Previously the Builder did not schedule file loads for configs of configs. This meant that if a BUILD file contained only configs referenced by other configs (rather than configs referenced by targets, or targets referenced by other targets), it would never be loaded. The result will be a failed run with an undefined object. BUG=536844 Review URL: https://codereview.chromium.org/1373903002 Cr-Commit-Position: refs/heads/master@{#351089}
-
jdduke authored
Not all smoothness benchmarks perform gesture scrolling, for which cases no 'first_gesture_scroll_update_latency' values are produced. This lack of value(s) is treated by the dashboard as a failure, which in turn prevents aggregate metric computation for the corresponding page set. BUG=534549 Review URL: https://codereview.chromium.org/1367953003 Cr-Commit-Position: refs/heads/master@{#351088}
-
kojii authored
imported csswg-test@8d5a07ec9aaac52e62f63ca65d944f50c67597d0 imported web-platform-tests@317575aca590f56748df7c0222302bba17c37fd4 css-writing-modes-3 - Several tests updated. html/browsers/history/the-location-interface - 1 file requires support file in the same directory (crbug.com/490940) html/semantics/embedded-content/media-elements - 2 files require running .py on the server. html/semantics/forms/constraints - Several FAILs turned to PASS, expected.txt updated. mediacapture-streams - 1 test added, failure expected added. subresource-integrity - 1 test updated. webstorage - Several tests updated. TBR=dpranke@chromium.org,jsbell@chromium.org,tkent@chromium.org,hayato@chromium.org,kochi@chromium.org BUG=490511, 492664, 490940 Review URL: https://codereview.chromium.org/1372043002 Cr-Commit-Position: refs/heads/master@{#351087}
-
nednguyen authored
fall in the ranges of interaction records Review URL: https://codereview.chromium.org/1357423008 Cr-Commit-Position: refs/heads/master@{#351086}
-
jbudorick authored
BUG=285037,341244 Review URL: https://codereview.chromium.org/1376483002 Cr-Commit-Position: refs/heads/master@{#351085}
-
tedchoc authored
I think with the ability to change toolbar heights at runtime, the fullscreen manager becomes required to ensure correct positioning. This just changes Tab to say it doesn't support hiding if the flag is set to true. BUG=535697 Review URL: https://codereview.chromium.org/1367313002 Cr-Commit-Position: refs/heads/master@{#351084}
-
robertshield authored
in official builds. Expect the first tab to be the signin page during browser tests run for an official build. BUG=536730 TEST=browser_Tests.exe --gtest_filter=*StartupBrowserCreatorTriggeredResetTest* TBR=msw Review URL: https://codereview.chromium.org/1369323002 Cr-Commit-Position: refs/heads/master@{#351083}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/f1b7a1d..209c162 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=robertphillips@google.com Commits in this roll: 209c162 halcanary@google.com SkBlockMemoryStream: correct test in getMemoryBase(). Review URL: https://codereview.chromium.org/1370133003 Cr-Commit-Position: refs/heads/master@{#351082}
-
yzshen authored
BUG=None Review URL: https://codereview.chromium.org/1369933003 Cr-Commit-Position: refs/heads/master@{#351081}
-
oshima authored
Chrome for ChromeOS currently places the window at 200x200 with 1366x768 size by default. This puts the parts of UI outside of Xvfb window, where the mouse cursor cannot be moved into. Default size is 1280x1024 and I'm using the 1280x800 that is one of resolution actually used on the device. BUG=None Review URL: https://codereview.chromium.org/1360233005 Cr-Commit-Position: refs/heads/master@{#351080}
-
l.gombos authored
HAVE_SIGNAL_H, HAVE_TM_GMTOFF, HAVE_TM_ZONE and HAVE_TIMEGM macros are no longer used; so remove them. HAVE_SYS_TIME_H has been only used in DateMath.cpp, but in other parts of blink we use !OS(WIN) to guard including <sys/time.h>, so lets do the same in DateMath.cpp as well. Review URL: https://codereview.chromium.org/1369133002 Cr-Commit-Position: refs/heads/master@{#351079}
-
tobiasjs authored
$ git log 9e9c3563a..b0383cd49 --date=short --format='%ad %ae %s' 2015-09-28 primiano Add GPU fingerprint information to breakpad microdumps. Add chromium changes required for roll. BUG=536769 Review URL: https://codereview.chromium.org/1371093002 Cr-Commit-Position: refs/heads/master@{#351078}
-
dglazkov authored
To determine if RenderFrame represents a main frame (top of the frame tree), there's a typical check done today in code: render_frame->GetWebFrame()->parent() To make this check more easily understood, we add the titular function. In addition: * Reversed existing RenderFrameImpl::is_subframe to align with the newly added function. * Removed obsolete comment in ContentRendererClient. * Tweaked ChromeContentRendererClient to use the new function. BUG= R=creis@chromium.org Review URL: https://codereview.chromium.org/1360123006 Cr-Commit-Position: refs/heads/master@{#351077}
-
bshe authored
BUG=536783 Review URL: https://codereview.chromium.org/1371113002 Cr-Commit-Position: refs/heads/master@{#351076}
-
plundblad authored
Chromevox classic and next background scripts have been compiled togetehr for a long while, so no need to ship that script anymore. BUG=None Review URL: https://codereview.chromium.org/1371913004 Cr-Commit-Position: refs/heads/master@{#351075}
-
pasko authored
BUG=none Review URL: https://codereview.chromium.org/1369703002 Cr-Commit-Position: refs/heads/master@{#351074}
-
sadrul authored
. Change WebViewClient::TopLevelNavigate() to TopLevelNavigateRequest() to better reflect that the client can intercept the request and do things other than doing a navigation. . Introduce WebViewClient::TopLevelNavigationStarted(url) to notify the client when navigation starts. Update the omnibox from this callback. BUG=526268 Review URL: https://codereview.chromium.org/1350223005 Cr-Commit-Position: refs/heads/master@{#351073}
-
pneubeck authored
This compile flag enables correct timeout handling in libusb. Without it, timeouts of e.g. interrupt transfers are ignored in most cases. BUG=535950 Review URL: https://codereview.chromium.org/1368773005 Cr-Commit-Position: refs/heads/master@{#351072}
-
zhaoqin authored
TBR=jww@chromium.org BUG=536803 NOTRY=true Review URL: https://codereview.chromium.org/1376493003 Cr-Commit-Position: refs/heads/master@{#351071}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/17e3806..f1b7a1d CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=robertphillips@google.com Commits in this roll: f1b7a1d bsalomon@google.com Make skpaint->grpaint flow work for composing draws (verts and atlas) 67c6513 reed@google.com EdgeClip demo to show scan-converter clipping behavior Review URL: https://codereview.chromium.org/1376493002 Cr-Commit-Position: refs/heads/master@{#351070}
-
melandory authored
Some methods of the SavePasswordInfobarDelegate can be reused in other password manager related delegates in the future, e.g. delegate for the update password infobar. So this patch introduces the base class for the password manager infobar's delegates. BUG=359315, 532876 Review URL: https://codereview.chromium.org/1313363004 Cr-Commit-Position: refs/heads/master@{#351069}
-
lalitm authored
With the duplication removal for multiple permission requests on its way, this class was duplicating a lot of code. Simplifying things here makes the code more maintainable as well as introducing duplication removal easier. BUG=(none) Review URL: https://codereview.chromium.org/1365993003 Cr-Commit-Position: refs/heads/master@{#351068}
-
droger authored
This allows sharing the resources on iOS. TBR=dbeam Review URL: https://codereview.chromium.org/1361923005 Cr-Commit-Position: refs/heads/master@{#351067}
-
pneubeck authored
Review URL: https://codereview.chromium.org/1371103002 Cr-Commit-Position: refs/heads/master@{#351066}
-
mtomasz authored
Actions should be provided for selection, as it's common for users to select more than one file and perform some operation them. Eg. pinning 10 selected files. NOPRESUBMIT=true TBR=isherman@chromium.org TEST=unit_tests: *FileSystemProvider*Action* BUG=None Review URL: https://codereview.chromium.org/1239043002 Cr-Commit-Position: refs/heads/master@{#351065}
-
plundblad authored
- Add better descritions for braille related messages. - Move non-translatable messages out of chromevox_strings.grd. - Remove duplicates in chromevox_strings.grd. - Move cvox.Msgs out into the global namespace, and simplify by having functions directly on the object instead of having an instance at cvox.ChromeVox.msgs. - Move spoken_messages.js closer to where it si used in chromevox classic, removing a small amoutn of dead code. BUG=None Review URL: https://codereview.chromium.org/1362223003 Cr-Commit-Position: refs/heads/master@{#351064}
-
mostynb authored
This should avoid possible build flakiness. Found using this proposed ninja patch: https://github.com/martine/ninja/pull/1031 BUG=536641 Review URL: https://codereview.chromium.org/1371073002 Cr-Commit-Position: refs/heads/master@{#351063}
-
bnc authored
SpdyHeaderBlock is currently a map<string, string>. This change replaces the typedef with a class that * behaves like a linked_hash_map<StringPiece, StringPiece>, that is, preserves insertion order, * and also manages memory containing the header names and values, resulting in much fewer allocations. String construction and destruction showed up in the CPU profile under heavy loads, and this class addresses this performance issue. This CL includes server change 100829267 by rjshade (for net/spdy/hpack/hpack_{en,de}coder_test.cc), which changed SpdyHeaderBlock to a linked_hash_map, thus preserving order. That change was not merged separately because Chromium's linked_hash_map implementation does not support copy. This CL also includes server changed 103293205 by birenroy, which introduces SpdyHeaderBlock class managing large chunks of memory. This CL also updates a large number of unittests and a small amount of production code to account for header order being preserved. BUG=443287 Review URL: https://codereview.chromium.org/1357953002 Cr-Commit-Position: refs/heads/master@{#351062}
-
petrcermak authored
This patch adds a new static method to MemoryPressureListener which can be used to simulate memory pressure notifications: MemoryPressureListener::SimulatePressureNotification(level); This patch is a part of the plan to implement a DevTools API for suppressing and simulating memory pressure signals in Chrome. The main use case for this feature is to enforce consistent conditions across memory measurements. See https://goo.gl/cZFdH3 for more details. BUG=516776 Review URL: https://codereview.chromium.org/1370713002 Cr-Commit-Position: refs/heads/master@{#351061}
-
yosin authored
This patch utilizes |VisibleSelectionTemplate| template class in |VisibleSelectionTest| class as replacement of |VisibleSelection::InDOMTree| and |VisibleSelection::InComposedTree| for a preparation of full version of |VisibleSelectionTemplate|. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1363873004 BUG=513568 TEST=n/a; no behavior changes Review URL: https://codereview.chromium.org/1370993002 Cr-Commit-Position: refs/heads/master@{#351060}
-
sataya.m authored
Lookout for the scrollbarModes when force style change occurs and reset the needs Horizontal & vertical Scrollbar values based on scrollbarModes, as during force style change StyleResolver::styleForDocument returns documentStyle with no overflow values, due to which we are destorying the scrollbars that was already present. TESTED= scrollbars/custom-scrollbar-changing-style.html now passes with root layer scrolling BUG=522389 Review URL: https://codereview.chromium.org/1308173005 Cr-Commit-Position: refs/heads/master@{#351059}
-
sdefresne authored
version_info components provides helper function to access the value of the PRODUCT_VERSION and IS_OFFICIAL_BUILD macros so use them instead of the macro directly. This remove a dependency on a generated header file that should be private to the version_info component. BUG=None Review URL: https://codereview.chromium.org/1373793002 Cr-Commit-Position: refs/heads/master@{#351058}
-
phoglund authored
Revert of Re-enabling 720p WebRTC video quality test. (patchset #2 id:20001 of https://codereview.chromium.org/1367453002/ ) Reason for revert: Still too slow for one of our win7 bots. Original issue's description: > Re-enabling 720p WebRTC video quality test. > > Closing the local streams seems to solve the buffer thrashing that's > going on while gathering frames; this should stop the test from > timing out on Windows. > > BUG=532918,webrtc:4986 > > Committed: https://crrev.com/5743af3d0c098fa86f587269519e226ecce185e4 > Cr-Commit-Position: refs/heads/master@{#351034} TBR=perkj@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=532918,webrtc:4986 Review URL: https://codereview.chromium.org/1372923002 Cr-Commit-Position: refs/heads/master@{#351057}
-
rego authored
We were passing too many arguments to LayoutGrid::offsetAndBreadthForPositionedChild(). It seems simpler to move some code there from LayoutGrid::layoutPositionedObjects(). Review URL: https://codereview.chromium.org/1362683003 Cr-Commit-Position: refs/heads/master@{#351056}
-
liberato authored
Moves a misplaced modulo so that hours can become nonzero when constructing the time and duration strings for HTMLMediaElement. Also added a unit test for it. This is the post-merge version of https://codereview.chromium.org/1360203002/ BUG=535046 Review URL: https://codereview.chromium.org/1369763002 Cr-Commit-Position: refs/heads/master@{#351055}
-
kjellander authored
Before the recent changes in how Android tests are run, tests with runtimes around 22 minutes were executing fine. Somewhere in the range of 310ea938..6323fa9e (349094:350405) this has changed, which breaks some WebRTC tests that run on a single device (no sharding). See https://codereview.webrtc.org/1355083002/ for details. Increasing the timeout fixes this for now, but ideally it would be configurable instead (future improvement). BUG=535973 Review URL: https://codereview.chromium.org/1364953003 Cr-Commit-Position: refs/heads/master@{#351054}
-
shiva.jm authored
These api will be used to normalize the header values in Fetch and XHR module. Background information: This is splitted from [1], and will be used by [1] and [2]. [1] https://codereview.chromium.org/1288263003/ [2] https://codereview.chromium.org/1342443004/ BUG=455099 Review URL: https://codereview.chromium.org/1364993003 Cr-Commit-Position: refs/heads/master@{#351053}
-
alexclarke authored
Under some circumstances, the scheduler temporarily blocks expensive tasks to improve responsiveness to user input. We don't want to delay navigations and the signal this patch adds prevents any scheduler imposed delay. Also we rename the OnPageLoad to OnNavigate for consistency. BUG=497761, 510398 Review URL: https://codereview.chromium.org/1368643002 Cr-Commit-Position: refs/heads/master@{#351052}
-
tkent authored
This CL has no behavior changes. BUG= Review URL: https://codereview.chromium.org/1373773002 Cr-Commit-Position: refs/heads/master@{#351051}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/76d03033..40d68714 Please follow these instructions for assigning/CC'ing issues: https://code.google.com/p/v8-wiki/wiki/TriagingIssues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1374603002 Cr-Commit-Position: refs/heads/master@{#351050}
-