- 26 Nov, 2019 40 commits
-
-
Jaeyong Bae authored
FrameSelection::ComputeAbsoluteBounds() is a generic API that computes the geometries of the selection anchor and focus. This function is called at every frame update, and can be a source of page slowness on large pages, since it computes the selection bounds from scratch every time it's called. To avoid duplicate computation and improve page performance, we can cache the results of ComputeAbsoluteBounds() in FrameSelection. The design document link: https://docs.google.com/document/d/1jtQpbJw9046lXJYMosIHOm0KLiQZMAeTooYgRGu_LrM/edit?ts=5dd4d6e8# Bug: 671593 Change-Id: If4153ae4f79856d29ccc35bd0012fb8b7fe5e11a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894666Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Cr-Commit-Position: refs/heads/master@{#719045}
-
Yoshifumi Inoue authored
This patch markes http/tests/devtools/a11y-axe-core/changes/changes-a11y-test.js as slow test. Tbr: yosin@chromium.org Bug: 1028478 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Id9c1ff58de958c63eba76365b9ce792e80bc7ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935637Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719044}
-
Francois Beaufort authored
This CL makes sure a NullPointerException is not fired when reading a record that is not handled yet by Web NFC. Bug: 520391 Change-Id: I3325816db121cd03829d9d414ae67343d716a37f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932787Reviewed-by:
Leon Han <leon.han@intel.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#719043}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ad2608d39418..1f0fda29b7e8 git log ad2608d39418..1f0fda29b7e8 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 dberris@chromium.org Pinpoint: Use polymer-bundler when deploying Created with: gclient setdep -r src/third_party/catapult@1f0fda29b7e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:986772 Tbr: skyostil@google.com Change-Id: I5abeb5668fcc2bf4ab96f47c5f0b8f8cb10fa0a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936092Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719042}
-
Yoshifumi Inoue authored
This patch markes jssourcemap-navigator-overlapping-sources.js as slow test. Tbr: yosin@chromium.org Bug: 1028479 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic3175af6df33225094f1de90ae4744a4fdd927fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935974Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLTableSectionElement> and DynamicTo<HTMLTableSectionElement> as new downcast helper 2. Use IsA<HTMLTableSectionElement>(element) in place of IsHTMLTableSectionElement(element) Bug: 891908 Change-Id: I9713c7fdfdbbb57f0b8919efa8cd03b333710fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928343Reviewed-by:Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#719040}
-
Timothy Loh authored
This CL updates the Plugin VM installer so that ChromeVox users can get updates to the labels (title, message, download progress and time left). Bug: 1021414 Change-Id: I4e80b95ceb232bb68327ee296da07054a2464aea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935295Reviewed-by:
Chris Hall <chrishall@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#719039}
-
Austin Tankiang authored
It's disabled in the toolbar [1] so disable it in quickview too. [1]: https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/js/task_controller.js?l=342&rcl=f5ab855ceb5c1237e29ff96f687357a0017d373a Bug: 983969 Change-Id: I334ddc578a7d95f640455f30d4ab46242bab132b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935776 Commit-Queue: Austin Tankiang <austinct@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#719038}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f50b090b72d4..a207daa8b57f Created with: gclient setdep -r src-internal@a207daa8b57f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None,chromium:None Tbr: jbudorick@google.com Change-Id: Ie631d2a1ed44ccab52b4e476e982d49fcae54c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935864Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719037}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: If3ba6d86527b39f405db74f0ddeea0862deb0c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928344Reviewed-by:
-
Hiroki Nakagawa authored
This is a part of the effort to split ServiceWorkerProviderHost into ServiceWorkerHost and ServiceWorkerContainerHost. This CL moves |create_time_|, |frame_id_|, and relevant functions from ServiceWorkerContainerHost to ServiceWorkerProviderHost. For |render_process_id_|, it's kept as |worker_process_id_| in ServiceWorkerProviderHost, while ServiceWorkerContainerHost also has |process_id_| after this CL. This is because it should be natural that ServiceWorkerProviderHost (to be renamed to ServiceWorkerHost) has the identifier of the process where a service worker execution context lives. For example, this is used when handling mojo connection requests for Web API (e.g., CreateQuicTransportConnector()). Design doc: https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing Bug: 931087 Change-Id: I86b2ff93ecc44e001018d101a456bb938cff7dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935274Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#719035}
-
Yoshifumi Inoue authored
This patch markes external/wpt/css/cssom/idlharness.html as slow test. Tbr: yosin@chromium.org Bug: 1028482 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I4a16f628b3b3e9d3f70dc97300f822ba624c4aa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935579Reviewed-by:
-
Luciano Pacheco authored
Bug: 1028465 Fixed: 1028465 Change-Id: I1f6e4b60666ee130b6c02e25ed79e9c65da3bd62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935971 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change implements a C++14 version of C++17's std::as_const and makes use of it in a few //base classes. Bug: 752720 Change-Id: Ie3e525dc719e3cf579650ce50b018da82ad80c43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932438Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#719032}
-
Yoshifumi Inoue authored
This reverts commit edc475ed. Reason for revert: Causes compilation failure: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8895755054118235408/+/steps/compile/0/stdout ../../clank/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolderForQ.java:26: error: method does not override or implement a method from a supertype @Override ^ Original change's description: > Upstreaming ContentCapture > > Related downstream change: > https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/2172237 > > Binary-Size: all added code was from downstream, the size increase is expected. > Bug: 951275 > Change-Id: Ibf56135e2a7d2f437f167dc0cdb7761bce447e86 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922603 > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Tao Bai <michaelbai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718894} TBR=michaelbai@chromium.org,dtrainor@chromium.org,torne@chromium.org,changwan@chromium.org Change-Id: Id904c28aa48d561ccea36942da1f507982a698dd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 951275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935578Reviewed-by:
-
Dominic Mazzoni authored
In http://crrev.com/c/1873964, I introduced a change that auto-focuses links when they get accessibility focus. This accidentally triggered re-focusing when you scroll the page, making it impossible to scroll because it keeps scrolling the focused node back into view. The fix is simple, just don't try to focus the link again if it's already focused. Bug: 1021918, 657157 Change-Id: If9d2a3a5e58cf4344d3b61f2e6c59da3bbad1257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917325Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#719030}
-
Yoshifumi Inoue authored
This patch markes http/tests/devtools/sources/debugger/navigator-view.js as flaky test. Bug: 1028482 Tbr: einbinder@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I03ccd69f5e61ac8cd08a48efcef9c8fc86313f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935777Reviewed-by:
-
Maggie Cai authored
This cl removes the user input in progress logic for qrcode_generator_icon_view and send_tab_to_self_icon_view, because now this is handled in the Update() superclass. BUG=1004031 Change-Id: Ie8082f742ccecd97996029965d5d9a57c5db1b8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935575 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#719028}
-
David Black authored
This CL adds the following histograms to track engagement of proactive suggestion cards: - Assistant.ProactiveSuggestions.CardClick - Assistant.ProactiveSuggestions.CardClick.ByCategory - Assistant.ProactiveSuggestions.CardClick.ByIndex - Assistant.ProactiveSuggestions.CardClick.ByVeId Proactive suggestions cards are hosted in an embedded WebContents. In order to log these metrics, a new deep link needed to be created to carry metadata necessary for metric logging while still navigating to the correct URL as a result of the click action. The schema for the new deep link is a follows: googleassistant://proactive-suggestions ?action=cardClick &category={int} &index={int} &veId={int} This CL also fixes a bug in which controller which were both AssistantControllerObservers and AssistantViewDelegateObservers received duplicate OnDeepLinkReceived events. This needed to be corrected to avoid double counting histograms but also fixes a previously unknown issue in which many deep links were in fact being processed twice. Bug: b:144875278 Change-Id: I0c531fdd6cd38254de536c0589c2f6c488f180ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929711 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#719027}
-
Jiewei Qian authored
Deprecate FailedUnknownReason and add new error codes for different subsystems. Add FailedShuttingDown to indicate this kind of interruption. Bug: 1021813 Change-Id: Iabeccca99c1132229341a6c4412dbd8ef34130c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915651 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#719026}
-
Yoshifumi Inoue authored
This patch markes external/wpt/cookies/http-state/path-tests.htm as slow test. Bug: 1028488 No-Presubmit: true No-Tree-Checks: true No-Try: true Tbr: yosin@chromium.org Change-Id: I56e99d2a237ef4038a9ec32b971eba1aae54f5e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935577Reviewed-by:
-
Bettina authored
Bold the domains in the saved password warning dialog so it will be easier for users to see which domains they should change their passwords on. https://screenshot.googleplex.com/KHvTjqhus1M.png Bug: 1015671 Change-Id: I4fd83873847b8d2ae9098b2d20f770963d315b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929922 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#719024}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5d28dbab..52e6614e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6330a8aaec97b28725d702abbaeda1f216afac10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935449Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719023}
-
Abhijeet Kandalkar authored
This CL has goal to use To<HTMLCanvasElement> and DynamicTo<HTMLCanvasElement> as new downcast helper Bug: 891908 Change-Id: I94523c3544b068f54284ef9426d0c59892a206ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930763Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#719022}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/dde2188cbe9d..ad2608d39418 git log dde2188cbe9d..ad2608d39418 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 abennetts@google.com Tweaks to docker docs and config. Created with: gclient setdep -r src/third_party/catapult@ad2608d39418 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: skyostil@google.com Change-Id: Ia00c9676f426fd00ac9454f5ad781ad9f16e99d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935857Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has goal to use To<HTMLBRElement> as new downcast helper Bug: 891908 Change-Id: Id23a072816c168c77285f635b7928fcc76c0609c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930762Reviewed-by:
-
Yoshifumi Inoue authored
This reverts commit 507f4ee8. Reason for revert: Start failing following tests on Win7 Test bot after this patch (build 80323): * All/DumpAccessibilityTreeTest.AccessibilityANameCalc/uia * All/DumpAccessibilityTreeTest.AccessibilityAriaTreeDiscontinuous/uia * All/DumpAccessibilityTreeTest.AccessibilityButtonNameCalc/uia https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/80323 Original change's description: > Do not return InlineTextBox nodes from UIA GetEnclosingElement > > In AXPlatformNodeTextRangeProviderWin, nodes with role kInlineTextBox > should never be exposed to UIA. This CL introduces a simple fix. > > In GetEnclosingElement(), if the enclosing node is an inline text box, > we simply return its parent. I also updated a unit test for this case. > > Bug: 928948 > Change-Id: I31a31566461c3091bed36ebad626c4f51afc55a3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931753 > Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> > Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#718920} TBR=kschmi@microsoft.com,ethavar@microsoft.com,benjamin.beaudry@microsoft.com Change-Id: Ibf9e61c9fed0d01c7ceb2afdb74b6aae4e8a4c10 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 928948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936070Reviewed-by:
-
Dan Beam authored
Even without focusing or hovering a match, the X to remove should show. Fixed: 1028372 Change-Id: I72fbfb4129fd2e1f50fe4ebbbf93d175e0491bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935622 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#719018}
-
Hiroshi Ichikawa authored
Change-Id: Id1bed24f06e21d4bf7a61d139d528122810a3e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928389Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#719017}
-
byoungkwon ko authored
When new TerminationStatus are added, compile error should be occurred. So we should delete 'default' at switch statements. Bug: 1020020 Change-Id: I7728ea68cdf4e4d5844c8fb314bae6ec37bfa36d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932143Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Cr-Commit-Position: refs/heads/master@{#719016}
-
Carlos IL authored
This CL changes the console message printed when a mixed subresource is autoupgraded to HTTPS to point to the Chromium blog post detailing mixed content plans as opposed to the md doc in the repository. Change-Id: I6958fca31381c1d49fe40adb1d98340e7bb63fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934520 Auto-Submit: Carlos IL <carlosil@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#719015}
-
Christopher Lam authored
This CL plumbs the Chrome OS semantic colors into cr-toggles in OS Settings by adding a shared style module to Settings on Chrome OS which is active only on OS Settings and not Browser Settings. To test, go to chrome://os-settings and type $$('html')[0].style.setProperty('--cros-default-button-color', 'red') into DevTools which should change the color of all toggles on the page. Bug: 1018654 Change-Id: I7d680a9bb5c188c44639e59748f96845c83e67d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925834Reviewed-by:
-
Fergus Dall authored
Bug: 1018093 Change-Id: Iab1f83f417e540827d7b0b00b5e2ff60904a9eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928458 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#719013}
-
Dan Beam authored
The autocomplete system internally trims starting spaces (which we did not know). Because we send this input in the response and check that it matches, left-padded input was failing (looking like it was a fast-typing user waiting for a response). Fixed: 1024724 Change-Id: If47b8f187146776b4f42341d8dfd697e64ec6c43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935177 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
-
Maggie Cai authored
Remove the return value of Update() in PageActionIconView. Currently there is only one use case for the Update() return value and it is for a very particular icon. Remove the general return value to simply the code. BUG=1004031 Change-Id: Ia2e44892249247cbd2381745e720c6803271db80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935570 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/80271e61d1fa..f50b090b72d4 Created with: gclient setdep -r src-internal@f50b090b72d4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None,chromium:b/144121590 Tbr: jbudorick@google.com Change-Id: I1985691b6440f54f8a86758cbe2a49a13f240f4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936028Reviewed-by:
-
Hajime Hoshi authored
This CL adds a missed reason 'session restored' for more precise metrics. When a user restored the session, any reasons are not recorded in BackForwardCacheMetrics. This CL catches this case. Bug: 1004676 Change-Id: I703563fe0a862ce7b64c9abd68526c45b112a069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903184 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719009}
-
Jay Harris authored
This will allow file handler registration to also be stored in prefs. Bug: 1028448 Change-Id: Iaef3854d32efeb6b1af7527b9c61d379c8472138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935292Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#719008}
-
Gyuyoung Kim authored
This CL converts InterfaceProviderPtr|Request to the new Mojo types. Major changes are as below, - Convert mojom::InterfaceProviderPtr to mojo::PendingRemote|Remote<mojom::InterfaceProvider> - Convert mojo::InterfaceProviderRequest to mojo::PendingReceiver<mojom::InterfaceProvider> - Convert mojo::Binding to mojo::Receiver - Convert mojom::InterfaceProviderPtrInfo to mojo::PendingRemote<mojom::InterfaceProvider> Bug: 955171, 978694 Change-Id: I94b956bb60e20810a84f7714e23c4da836bfd8c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928429Reviewed-by:Wei Li <weili@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#719007}
-
Maggie Cai authored
This CL hides the page action icons by default when typing starts in the omnibox. Most icons already have the logic to hide the icon however this need to be done for every icon. This change ensures all the new icons have this behaviour by default unless overridden by developer intentionally. BUG=1004031 Change-Id: I6ddc6d80813d635c52fbfcb4eb4acbb599c2ccfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933852Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#719006}
-
