- 22 Aug, 2018 40 commits
-
-
Reilly Grant authored
This class has been updated to use network::SimpleURLLoader and so no longer needs to run on the IO thread in order to access a URLRequestContextGetter. It is now incorrect to run on the IO thread because as long as the device service is hosted in the browser process it is using a SharedURLLoaderFactory that can only be accessed from the UI thread. Bug: 875283 Change-Id: I68181566aeb50dc460a32acc6afc58a9054f46a6 Reviewed-on: https://chromium-review.googlesource.com/1183969Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#585063}
-
Tien-Ren Chen authored
This CL adds a few layout tests for canvas with overflowing object-fit. Blink is expected to scale the contents properly and clip the overflow to to the content box. Composited version of the test doesn't work currently, but will be fixed by BGPT. There is a video counterpart in media/video-object-fit.html, which also will be fixed by BGPT. Also did minor code cleanup and updated comment that most code path don't use transform nodes for object-fit. No behavior change is expected. BUG=400829,866647 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iaa9bf18fc23b7b2309e5f46dea145eaa33a8e0f6 Reviewed-on: https://chromium-review.googlesource.com/1179278Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#585062}
-
Dave Tapuska authored
Since we want to indicate the user gesture to postMessage to a dedicated worker it is cleaner to adjust the worker APIs to take a BlinkTransferableMessage. This change is intended to have no behavioral change. BUG=861735 Change-Id: I825d886877ae0931ce979c6b28930f754349dd9f Reviewed-on: https://chromium-review.googlesource.com/1183288 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#585061}
-
Dominik Röttsches authored
Preparation for issue 874059 in which the DevToolsProtocolTest harness is needed for verifying font selection, after discussion in https://chromium-review.googlesource.com/c/chromium/src/+/1174540 Address banned and deprecated function warnings in the process: Using a OnceClosure for closing the specific RunLoop to replace QuitCurrent() and remove usage of RunMessageLoop(), mark NotificationMatcher as RepeatingCallback. Bug: 874059 Change-Id: Id63a73e4ca7d2cb3bef888eac91bb3cc7cf8fb1a Reviewed-on: https://chromium-review.googlesource.com/1183239Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#585060}
-
Vadym Doroshenko authored
In order to save gaia password hash, Password Manager should detect success of form submission. For achieving this PasswordFormManager has to be created for such forms. This CL implements 1.Creating PasswordFormManager for such forms 2.PasswordFormManager doesn't fetch credentials for these forms which prevents filling. Bug: 876283 Change-Id: Icbe539d1f99777ca343d5168e41b637b3e74aa8f Reviewed-on: https://chromium-review.googlesource.com/1184919Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#585059}
-
Ryan Sleevi authored
The set of additional trust anchors (read: Enterprise-configured trust) presently is passed as a parameter to the CertVerifier::Verify() call, except it is logically part of the system configuration. As it does not vary between calls, move it to the CertVerifier::Config and update the PolicyCertVerifier to pass this as part of the config. Bug: 848277, 862043 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ibeb084cf05411a1055f0fcfc5e6e987a96eb03e9 Reviewed-on: https://chromium-review.googlesource.com/1167472 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#585058}
-
Matt Menke authored
This CL moves all of the logic over to the UI thread, to keep things relatively simple and minimize thread hops, since that's where core network service objects live. It also fixes a pre-existing bug in the PPAPI UDP code, where read errors that occur when there's no pending read are converted into 0-byte read successes. Bug: 848078 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Id6d23c26c1ac085211dfcfe23502a307fc29a284 Reviewed-on: https://chromium-review.googlesource.com/1171568 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#585057}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4d95f1eb9beb..efbcb31cb67e git log 4d95f1eb9beb..efbcb31cb67e --date=short --no-merges --format='%ad %ae %s' 2018-08-22 qingsi@webrtc.org Revert "Remove the flag PORTALLOCATOR_ENABLE_ANY_ADDRESS_PORTS." 2018-08-22 buildbot@webrtc.org Roll chromium_revision 3e0dea7b..ab3ab1ba (584728:584945) 2018-08-22 qingsi@google.com Revert "Use also the related address in redundancy detection for candidates from" 2018-08-22 qingsi@webrtc.org Revert "Update packetsLost and jitter stats any time a packet is received." 2018-08-21 koloskova@webrtc.org Adds utility function for PCC. 2018-08-21 koloskova@webrtc.org Adds monitor interval class for PCC. 2018-08-21 aluo@chromium.org Reland "Default runner to junit4" 2018-08-21 andersc@webrtc.org Add missing ifdefs to header files for SW video codecs. 2018-08-21 ilnik@webrtc.org Revert "Move FakeCodec to separate target and behave like real encoder." 2018-08-21 koloskova@webrtc.org Adds Rtt tracker for PCC. 2018-08-21 devicentepena@webrtc.org AEC3: adding a config option for applying a more conservative initial phase. Created with: gclient setdep -r src/third_party/webrtc@efbcb31cb67e The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:868610,chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7fa8327a149cb62e4f71ab5e23bd64d8b6192d6b Reviewed-on: https://chromium-review.googlesource.com/1184764Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585056}
-
Maciej Pawlowski authored
When a tracked pref is cleared, it will no longer be present in the DictionaryValue that represents the pref store contents, but FilterUpdate() and FilterSerializeData() will still be called. Make the code handle nullptr Values safely. Bug: 867337 Change-Id: I1840c3f60bd815145a0f765adf5907a35bca1c87 Reviewed-on: https://chromium-review.googlesource.com/1150034Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#585055}
-
Lei Zhang authored
- Reduce number of parameters to DoComposite{Document,Page}ToPdf(). - Move ConvertContentInfoMap() into an anonymous namespace and remove unused parameter. - Change GenerateFrameGuid() so callers only pass a single parameter. Change-Id: I22d94f988ba64ba72a1fa9bea7190cf2b812b336 Reviewed-on: https://chromium-review.googlesource.com/1183022 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#585054}
-
Boris Sazonov authored
This CL changes ChromeUnifiedConsentClient to use kMetricsReportingEnabled pref to check whether UMA reporting is enabled, as IsMetricsAndCrashReportingEnabled always returns false on non-official builds, forcing unified consent to be off. Bug: 814728 Change-Id: Ie39ca8d23cdc1fbb757a5ec74c719092c758a1d6 Reviewed-on: https://chromium-review.googlesource.com/1183679Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#585053}
-
Clark DuVall authored
We need to notify download progress even if report_raw_headers is not set. Bug: 875298 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I1074a50ca60cdbbb00cd265d83487abe55160732 Reviewed-on: https://chromium-review.googlesource.com/1184038Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#585052}
-
Joel Einbinder authored
This roll contains fixes for TypeScript syntax highlighting Change-Id: Ibe60b3378fca642c259e95686f3659b765d0edf9 Reviewed-on: https://chromium-review.googlesource.com/1182680Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#585051}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ec5364ee5d5a..2916d264903a Created with: gclient setdep -r src-internal@2916d264903a The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:b/112808120 TBR=mmoss@chromium.org Change-Id: I4e095ada11fb9a277d44d6688466176f2271cf9f Reviewed-on: https://chromium-review.googlesource.com/1184421Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585050}
-
Helen Li authored
This is a reland of d184f073 The CL was speculatively reverted for an unrelated bug (876563) TBR=mmenke@chromium.org Original change's description: > Add NetLog events for cookie blocking by NetworkDelegate > > Cookies setting and getting can be blocked by a NetworkDelegate. > This CL adds NetLog events so they can aid in the investigation of cookies bugs. > > Bug: 875849 > Change-Id: Ia2a09b443fb1ebfe8ce9dde1617920264f6f24a7 > Reviewed-on: https://chromium-review.googlesource.com/1181244 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Helen Li <xunjieli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584809} Bug: 875849 Change-Id: I19e285f078599084d53c9e68a8082ef43d86e067 Reviewed-on: https://chromium-review.googlesource.com/1185102Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#585049}
-
Keishi Hattori authored
Removes SafePointScope and code related to copying the stack. Change-Id: Iabf5c7a892d680d1b16a0987bbc3cfc2ce3bc984 Reviewed-on: https://chromium-review.googlesource.com/1184596 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#585048}
-
Jun Mukai authored
As described in the bug, ui::GestureRecognizer shouldn't be a singleton since Mash and browser process should refer to different instances. ui::GestureRecognizer is now a property of aura::Env. views::Widget now also has GetGestureRecognizer() to support MacViews since no aura::Env exists in Mac. chrome/browser/ui/aura/accessibility changes are necessary since this singleton object owns an aura::Window internally (AutomationManagerAura owns AxTreeSourceAura which owns AxRootObjWrapper which owns |alert_window_|) and deletion of a Window now refers to its Env through CleanupGestureState(). The change on AutomationManagerAura makes sure that this instance does not outlive aura::Env to prevent such references to deleted Env object implicitly. Bug: 872365 Test: trybots Change-Id: Ia617482d5aa6fd5482df4dd8af0039395c5bc3fb Reviewed-on: https://chromium-review.googlesource.com/1171838Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#585047}
-
Helen Li authored
TBR=morlovich@chromium.org Change-Id: I2952774687ead64152d7a1a8fd3d6a7fc5a5b639 Reviewed-on: https://chromium-review.googlesource.com/1183639 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#585046}
-
Ben Wagner authored
These should have been removed in https://codereview.chromium.org/1847173002 e9b78323 when dwrite_font_platform_win_unittest.cc was deleted, but they were overlooked. Change-Id: I6a9531e831cbda26cb61ab74e3487b3dd21a049e Reviewed-on: https://chromium-review.googlesource.com/1183993Reviewed-by:
Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#585045}
-
Vasilii Sukhanov authored
TBR=tedchoc@chromium.org Bug: 874039 Change-Id: I183677ed1399b8dcd6b94b87e9ae88851fa4441c Reviewed-on: https://chromium-review.googlesource.com/1181423 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#585044}
-
Anna Offenwanger authored
Somehow an _ got removed that shouldn't have been. Bug: 876478 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8f0368cfbc2b2f0e1180ecf9ab2f126d2c418394 Reviewed-on: https://chromium-review.googlesource.com/1183846Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Cr-Commit-Position: refs/heads/master@{#585043}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/465d65ba9903..a4238afbd1d0 git log 465d65ba9903..a4238afbd1d0 --date=short --no-merges --format='%ad %ae %s' 2018-08-21 primiano@google.com UI: fix deploy script 2018-08-21 primiano@google.com Merge "UI: Rearchitect controllers and improve tracks performance" 2018-08-21 primiano@google.com TraceProcessor: improve error handling in presence of null columns Created with: gclient setdep -r src/third_party/perfetto@a4238afbd1d0 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Id509660d3b58ac2af980a5746fad285197a1ad5e Reviewed-on: https://chromium-review.googlesource.com/1184762Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585042}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/85f5e7ccd1af..29361ca11fa3 git log 85f5e7ccd1af..29361ca11fa3 --date=short --no-merges --format='%ad %ae %s' 2018-08-22 cwallez@chromium.org Add standalone dawn gclient config 2018-08-21 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@29361ca11fa3 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:875245 TBR=agable@chromium.org Change-Id: I03a614427f950472893d317d70dd2c59944750e4 Reviewed-on: https://chromium-review.googlesource.com/1184763Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585041}
-
Ramin Halavati authored
Braille IME preferences are not actual preferences and are never written/modified from an incognito window. So they are removed from incognito persistent whitelist. Bug: 861722 Change-Id: Id8ac77909c0927eebfdf6e0a2e9e5afce528c5d9 Reviewed-on: https://chromium-review.googlesource.com/1180891Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#585040}
-
Victor Costan authored
The function populates an AppCacheInfo instance passed by pointer, and is always called with a default-initialized instance. This CL makes the function return an AppCacheInfo instead, and relies on NVRO to avoid degrading runtime performance. Change-Id: I62b6f2a71409634d3264c84954744c9d265e3c8c Reviewed-on: https://chromium-review.googlesource.com/1184506 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#585039}
-
Xianzhu Wang authored
We had output the clip before SPv175 with ClipRecorder but not for SPv175. We also lost the early return on empty clip_rect in crrev.com/569459. See https://chromium-review.googlesource.com/c/chromium/src/+/1110496/6/third_party/blink/renderer/core/paint/file_upload_control_painter.cc for the old code. Now enable ControlClip for LayoutFileUploadControl to emit the clip. Bug: 875460 Change-Id: I0f4141eeb0e8d62ccdf9aa4df368f65e207df7d3 Reviewed-on: https://chromium-review.googlesource.com/1183783 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#585038}
-
Orin Jaworski authored
The increase from 5 to 18 entries significantly reduced entity image flicker, but the problem was not eliminated completely until the underlying cause of cache overwrite was addressed. With image prefetch logic fixed, the cache size can be reduced to a tighter bound. 5 is still not enough, but 12 is sufficient (see comment). Bug: 866580 Change-Id: Ifc3f7d84ee59eea277756d5f32d302cc7f5949cc Reviewed-on: https://chromium-review.googlesource.com/1182610Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#585037}
-
chrome://discardsChris Hamilton authored
This removes a spurious bit of debugging code that made it through review. TBR=fdoray@chromium.org Change-Id: Ie1567dc92d1a6b97d443d7f63b1fb8f557e18533 Reviewed-on: https://chromium-review.googlesource.com/1184105Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#585036}
-
Alexei Filippov authored
OOPHP needs address, allocator type, and context fileds. BUG=803276 Change-Id: Id2c93825921f768d7a10d779a2ac25c19c2b004b Reviewed-on: https://chromium-review.googlesource.com/1183860Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#585035}
-
liberato@chromium.org authored
Previously, MCVD would flush immediately when draining the codec, or eliding a drain. This causes a lot of flushes during scrubbing, for example, when the next seek would happen before the next decode. Now, MCVD will defer the flush even if it elides the drain, so that many flushes can be elided too. This requires some care, since the codec is entirely unaware that we've elided an eos and deferred a flush; it might produce output from previously submitted inputs. MCVD will now ignore these. Bug: 869365 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If0490de8754abcb18c8ed60e26215e0a7df9e607 Reviewed-on: https://chromium-review.googlesource.com/1183881Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#585034}
-
Peter Beverloo authored
There is a low rate of errors where notification clicks cannot be processed due to internal reasons, such as not being able to find it in the appropriate database or database read errors. In those cases we can't give the developer the means to handle the event, and the notification sticks around until the user closes it. Per this CL, we'll automatically close notifications when the click could not be processed. The eventual goal is for such clicks to be very rare, so fixes will happen in other parts of the code as well. Bug: 872336 Change-Id: I3f184b6d1a36deb42d9f5c95be5dc15aa285bb66 Reviewed-on: https://chromium-review.googlesource.com/1183674Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#585033}
-
Mythri Alle authored
Pass in 0 as the size of code cache, so disk_cache backend picks a default value based on some heuristics. The size of code cache would be the same as the size of http_cache. We can tune it once we have some initial results. We also need to add support for embedder to override this default value and that is tracked in this bug: crbug.com/867552 Bug: chromium:812168 Change-Id: Iab8d98764e3e306cb006377e5b8adaf2c727b689 Reviewed-on: https://chromium-review.googlesource.com/1161922 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#585032}
-
Ramin Halavati authored
First run, Enrollment, and OOB preferences are removed from the persistent storage list for incognito mode. Since these preferences are not written from incognito mode, this change should not have any behavioral effect. Bug: 861722 Change-Id: Iafe1ff19e7954ca2c420ee26708ba6f963a7fdb1 Reviewed-on: https://chromium-review.googlesource.com/1180217Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#585031}
-
Sujie Zhu authored
If IssueOAuthToken() is not called after StartUploading(), the GetUploadData() will always be empty which makes that unittest (which checks fields are not included in the upload data) meaningless. So we add IssueOAuthToken() and check the upload data is not empty before we check the fields. Change-Id: I30f776f52e86e74a08018dbc4db4f20925af871a Reviewed-on: https://chromium-review.googlesource.com/1175211 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#585030}
-
Ben Pastene authored
It's not doing well. https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-kitkat-arm-rel?limit=200 Fortunately, the M bot is ok: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-marshmallow-arm64-rel?limit=200 NOTRY=true Bug: 876539 Change-Id: Icb9770bf0df60fe28ad92dfabeb0c5c8f14f30af Reviewed-on: https://chromium-review.googlesource.com/1185229 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#585029}
-
Aaron Leventhal authored
Accessibility must consider any kind of non-visible overflow as programatically scrollable, so that the bounds of scrolled objects in these containers correct for the scroll offsets. This fixes a scrolling issue where screen readers were not scrolling to the content they were reading, as they were getting incorrect bounds. The content in question was using hidden overflow, which can be programatically scrolled. Bug: 646117 Change-Id: Ie083d7544b0e6dd2bdb7c5b8c1d41fc7c2377daf Reviewed-on: https://chromium-review.googlesource.com/1178321 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#585028}
-
Olivier Robin authored
This method can be used to configure the TestWebClient to inject scripts needed for tests. Also migrate other test methods in web::test Bug: 823285 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie8a69a02defd2dd071b42b3c6654a7f25009af82 Reviewed-on: https://chromium-review.googlesource.com/1136301Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#585027}
-
Kuo-Hsin Yang authored
NOTRY=true Bug: chromium:876636 Change-Id: I516f4f2920b7fa99c1cab1b0ab4dcef0053f0564 Reviewed-on: https://chromium-review.googlesource.com/1184740 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#585026}
-
Joe Mason authored
R=wfh Bug: 830892 Change-Id: I0a4b25b2ba04b65a80e2c03e9151b5ef55912432 Reviewed-on: https://chromium-review.googlesource.com/1171737 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#585025}
-
Joe Mason authored
Launch chrome_cleaner unit tests without using job objects on win7 to make sure SpawnSandboxTarget works. Bug: 871924 Change-Id: Ie9b80894851cc2f7420a79e4fe3fffaf8e849a4a Reviewed-on: https://chromium-review.googlesource.com/1171659 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Penny MacNeil <pennymac@chromium.org> Cr-Commit-Position: refs/heads/master@{#585024}
-