- 18 Jan, 2021 40 commits
-
-
Camillo Bruni authored
Previously the repro command was only show when the test failed. Change-Id: Ib7c065fb177b19d0b30083ba38daf0bb4856f8d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635145Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#844524}
-
Christoph Schwering authored
This CL adds set operations to DenseSet for the union and difference and for subset and disjointness of two DenseSets. The set's size parameter (formerly kEnd, now kMaxValue) is now implicit and defaults to the T::kMaxValue (which according to the chromium-style is the highest value in the enum. Bug: 1007974 Change-Id: Ia8fd96481bf28d361a7736032ea4d65b3dbbab83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630706 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#844523}
-
Viktor Semeniuk authored
Since CompromisedCredentials hold parent_key to PasswordForm, they will be removed automatically due to Cascade implementation of delete. Bug: 1167109, 1137775 Change-Id: I6df183012ecbafd1867d290a062decf6e850b040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626442 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#844522}
-
Nohemi Fernandez authored
The new promo will only be shown on the Settings page with |kMobileIdentityConsistency| enabled. This patch does not update interactions with promo dismissals. Bug: 1151289 Change-Id: I5ca5701415023cca5e20cfbef6427ff16dca8888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565574 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#844521}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/16b9bbbd..a36b28c1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iddd593a7b609739819742de6a7355537003cd7b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632852Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844520}
-
Findit authored
This reverts commit b399fb2c. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 844516 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2IzOTlmYjJjYjc2Zjg2YTc4YTYxYWI4ZGRiYWQ3M2ZhYWVhNGQyZmIM Sample Failed Build: https://ci.chromium.org/b/8857758622958410288 Sample Failed Step: compile Original change's description: > Remove eugenebut from ios/web owners > > Bug: None > Change-Id: I5c8684a3f17f2f147bb04a41ab84ba503aa56ae0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633193 > Auto-Submit: Eugene But <eugenebut@chromium.org> > Commit-Queue: Ali Juma <ajuma@chromium.org> > Reviewed-by: Ali Juma <ajuma@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844516} Change-Id: I8039a97b105dce9af8b85d8c2402a0001c2aa1b0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635681 Cr-Commit-Position: refs/heads/master@{#844519}
-
Aya ElAttar authored
- Changed notification helper to observe the clipboard, and close the bubble if the clipboard got changed. - Refactored Bubble & Button classes to base and derived classed, so it'd be easier to support warning mode later. - Moved some of the needed bubble constants to a separate file. Bug: 1167228 Change-Id: I103ef1c95e1036ba28d3c449ed801688d12d2868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632673Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#844518}
-
Matthias Körber authored
This change moves field name parsing logic out of the FormStructure class into a separate util file. Also, this change uses StringPieces for the processing and removes side effects from the functions written in the util file. Change-Id: I62b2349f59e271721df23ba1145fc9e23e095cf2 Bug: 1007974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622395 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#844517}
-
Eugene But authored
Bug: None Change-Id: I5c8684a3f17f2f147bb04a41ab84ba503aa56ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633193 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#844516}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bc30234f61ef..b06ebb493f2c 2021-01-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2021-01-18 sigurds@chromium.org Extract issue text icon to svg file 2021-01-18 janscheffler@chromium.org [Recorder] Close opened targets If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1098185,chromium:1161512 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I01c0bc7f8a82ef35aff41d04547d1b296deb168a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635939Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844515}
-
Sami Kyostila authored
TBR=mythria@chromium.org Bug: 1167686 Change-Id: I50cc010f3e5f7babd2db5328ec8c4435e47646a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632961Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#844514}
-
Al Muthanna Athamina authored
This CL was created automatically with tools/perf/update_wpr script R=johnchen@chromium.org Bug: chromium:1158374 Change-Id: I710407f0ab9385beae0836e83efca4849f939162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595383 Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Tamer Tas <tmrts@google.com> Auto-Submit: Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/heads/master@{#844513}
-
Robbie Gibson authored
This CL adds three new tests: 1. Tests that swiping down twice transitions the thumb strip to the revealed state. This means the toolbar is no longer visible and the web content is hidden behind a hider view with the current location text. 2. Tests that scrolling in the web content causes the thumb strip to open and close. 3. Tests that scrolling on the NTP causes the thumb strip to open and close. Bug: 1094335 Change-Id: I038fc784bd5c596de67b40ff547516b5d24a9cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627524Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#844512}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610948968-73b5b51cc98aa3edcd70782870e3aaa675f980cb.profdata to chrome-win32-master-1610959165-8386a0e84f434425b7043e7053c588f46a3ee84d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I37fd41da630cf4f78d4418ad9ca27e3ee1d05c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635772Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844511}
-
Sami Kyostila authored
Chrome is about to switch to the TRACE_EVENT macro implementation provided by Perfetto. The new implementation requires trace event statements to be terminated by semicolons, so this patch modifies the codebase to add semicolons where they were previously left out. No functional changes. TBR=olka@chromium.org Bug: 1006541 Change-Id: If614c8e30a439956f7986af1d822683c70716247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627525Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#844510}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bd2954a9c499..68f15c734d5c 2021-01-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 2ef9c5ff to 55486659 (469 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Ib31629bc11e9f491d8894175888dae40cf467810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635770Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844509}
-
Matthias Körber authored
Change-Id: I638a03fe56d68c184c954239c7d6d07f2c542828 Bug: 1007974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626428 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#844508}
-
Dominik Röttsches authored
Instead of keeping a local copy, move OTS to an external checkout. This allows easier tracking of changes and easier rolling of OTS into Chromium. Keep OTS at e5d1029ad9a16e1209b2fe7a2f8901aa42a9698c in this CL, which points to [1] which is equivalent to the copy of the source code that we used before. Roll OTS to tip of tree in a forthcoming commit. [1] https://chromium.googlesource.com/external/github.com/khaledhosny/ots/+log/refs/heads/chromiumOTSbeforeDEPS Bug: 1158389 Change-Id: If8fe76792b171cf0df1366b820db6d6291baf36b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589853 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#844507}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610926940-236c747d5ac0deeb141d61adc07a8e2f2f5cae68.profdata to chrome-win64-master-1610959165-ca87807bfba7d6db298cc69229704c835aeb25f8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1078bb938dd6eb17040223061eff1b81ffe145e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635771Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844506}
-
Oriol Brufau authored
The change from bug 1002937 made this code trigger a CHECK failure in CreateMarkupAlgorithm::CreateMarkup. It's fine now since it had to be reverted because of bug 1161370, but adding test coverage will be useful to avoid the problem when relanding the patch. Bug: 1155665 Change-Id: I6f39eb7c29bc607fa41d662fedd48c63611d8377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632613Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#844505}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ia0e7c8544a92ef19b7ad8f48037587469504698e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635763Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844504}
-
Takashi Toyoshima authored
In the current production code, `client_` is always set immediately after the MIDIDispatcher construction, and there is no timing to run SessionStarted without a valid `client_` on the same thread. This SECURITY_CHECK just makes the code robust against attacks via mojo injections and code changes in the future. Bug: 1161806 Change-Id: Ic8a5f6e0dc70e6bb4c7cccb4d69d63fc12382c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631811 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#844503}
-
Oriol Brufau authored
The change from bug 1002937 made this code trigger a null-deref in TextIteratorAlgorithm::TextIteratorAlgorithm, or a DCHECK failure in CompositeEditCommand::MoveParagraphs. It's fine now since it had to be reverted because of bug 1161370, but adding test coverage will be useful to avoid the problem when relanding the patch. Bug: 1155687 Change-Id: I8d509653ae998288ba4889f3d99014501f4e7b18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632954Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#844502}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5e5cb23c7e2a..bc30234f61ef 2021-01-18 jacktfranklin@chromium.org Migrate run_lint_check_css to JS script 2021-01-18 wolfi@chromium.org Use CSS grid for ReportView component 2021-01-18 patrick.brosset@microsoft.com Adding component docs for MarkdowView and MarkdownImage 2021-01-18 janscheffler@chromium.org [JSDOC2TS]: Migrate developer_resources 2021-01-18 jacktfranklin@chromium.org Add the DataGrid to the Protocol Monitor If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1125968,chromium:1154783,chromium:1158760,chromium:1165710,chromium:1166108,chromium:1166572 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8d56ae77c99c2f62c0f9cd9ab351ed51ef272761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635769Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844501}
-
Alex Rudenko authored
Bug: chromium:1166710 Change-Id: Iad71b892a9b249427d13aea20df0864cf3733865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632959Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#844500}
-
Sean Harrison authored
Add is_int check before getting the default cookie policy to only grab the value when it exists and fix a badVariantAccess. Bug: 1167622 Change-Id: I0733a1c61233aa702cc40698b9d06c2878222ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631501Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#844499}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I403566703f6eefb139daef2e2489864c5eb93f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635765Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844498}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I89035609036e000f489f87a84ce6468c38263256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635764Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844497}
-
Sara Kato authored
Bug: 1159562 Test: build Change-Id: I5cd5b56c5ef11899bdac3122ed1525a24bbf6fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615725Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#844496}
-
Jan Wilken Dörrie authored
This change adds missing APIs from https://wg21.link/string.view.ops and https://wg21.link/string.view.find to base::StringPiece. In particular: * Use traits_type::copy for copy, add CHECK for OOB * Add missing default argument to substr() * Add missing compare() overloads * Add missing find() overloads * Add missing rfind() overloads * Add missing find_first_of() overloads * Add missing find_last_of() overloads * Add missing find_first_not_of() overloads * Add missing find_last_not_of() overloads * Take StringPieces by value instead of const-ref in these APIs Bug: 1049498 Change-Id: I6392dd9e713265fda25721d6f2d1a8f3db133b76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632597Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#844495}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 89-4374.0-1610361443-benchmark-89.0.4389.4-r1 to 89-4374.0-1610361443-benchmark-89.0.4389.5-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If616a8170876c7d2a6ade3820cccb1a1e5908c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635934Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844494}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 89-4380.0-1610362181-benchmark-89.0.4389.4-r1 to 89-4380.0-1610362181-benchmark-89.0.4389.5-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ibb56f77c38f5f4ffd85b8dfa3820f5d05bf617da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635933Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844493}
-
Viktor Semeniuk authored
This change updates local compromised credentials related to the login when login is updated remotely. Bug: 1167109 Change-Id: I6d5f89aad0624a6156332333850680caf4bd0329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632747 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#844492}
-
Benoit Lize authored
The test is failing on a *lot* of Android bots. Bug: 1167663 Tbr: rsleevi Change-Id: I7cd7d323a44f52ecc11063d787cb371f7e2029b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632957Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#844491}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/04772515a8b6..5c20f1ec9ca9 2021-01-18 cwallez@chromium.org Add the SubresourceTrackingPerf perf test. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: sarahmashay@google.com Change-Id: I78bb66667e5115cee264b0eeb468e1b461caa1da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635758Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844490}
-
Harald Alvestrand authored
This is the minimum change to prevent the use of RTP datachannels in Chrome, designed to be easily rolled back if needed. Feature link in Chrome dashboard: https://chromestatus.com/feature/6485681910054912 Bug: webrtc:6625 Change-Id: I19c78f703c8e322d8fa21c120c255942cd2bbd3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632953Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#844489}
-
Colin Blundell authored
This CL moves the scopes string used for safe browsing access token fetches into safe_browsing_token_fetcher.h so that the WebLayer implementation can reuse it rather than duplicating it. Bug: 1080748 Change-Id: I14a028857fe30c70d59454287748704673461f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627310 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#844488}
-
Hiroki Nakagawa authored
By adding a new browser test, this CL clarifies the current behavior that clients in the prerendering state are exposed via Clients#matchAll() on service workers. This behavior can be changed based on future discussions. Change-Id: I6be9d2e3db91a5b411a5debbe4098a83597f4f86 Bug: 1166470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626861Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#844487}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 89-4342.0-1607345364-benchmark-89.0.4351.0-r1 to 89-4380.0-1610362181-benchmark-89.0.4387.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I9cd15c5ed9ee1d80ba1f29918d438a20f7dd1609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635793Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844486}
-
Friedrich Horschig authored
This CL does not affect any behavior. By adding traces, debugging events of jankiness becomes simpler and it allows to figure out which steps that rely on cached data slow down once the caching is reduced. Bug: None Change-Id: I2771e85038fd215067bb2a9aa6a2750e80e842c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633266Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#844485}
-