- 21 Aug, 2020 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bedb605c8272..ea7fbfb9665b 2020-08-20 deadbeef@webrtc.org Implement network monitor for iOS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie315cf1d77b624d612a09d463d345f9cbf888d78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368539Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800436}
-
Wei-Yin Chen (陳威尹) authored
This reverts commit a1325695. Reason for revert: Android ASAN bot compilation failure. crbug.com/1120202 Original change's description: > Reland "Add -noverify to build commands to improve runtime (local builds only)" > > This reverts commit 17e2a917. > > Reason for revert: Ensure buildtools.py is a no-op on bots. > > Original change's description: > > Revert "Add -noverify to build commands to improve runtime (local builds only)" > > > > This reverts commit 132e1deb. > > > > Reason for revert: Android ASAN bot compilation failures: https://ci.chromium.org/p/chromium/builders/ci/Android%20ASAN%20%28dbg%29/26489 > > > > Original change's description: > > > Add -noverify to build commands to improve runtime (local builds only) > > > > > > The flag is guarded by treat_warnings_as_errors=false so that it > > > will apply only to local developer builds. > > > > > > Results from //tools/android/build_speed/benchmark.py base_java_sig: > > > With change: > > > base_java_sig: 68.0s avg (68.8s, 67.2s) > > > base_java_sig: 68.4s avg (68.6s, 68.2s) > > > > > > Without change: > > > base_java_sig: 69.4s avg (69.3s, 69.5s) > > > base_java_sig: 69.7s avg (69.7s, 69.7s) > > > > > > time out/Debug/bin/run_base_junit_tests: > > > With Change: > > > real 0m22.741s > > > real 0m23.543s > > > > > > Without change: > > > real 0m23.176s > > > real 0m24.328s > > > > > > Bug: 1117222 > > > Change-Id: I4bfd742165468bf9538e6fa0dc8f35daa9e0f23f > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313299 > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > > > Reviewed-by: Peter Wen <wnwen@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#799285} > > > > TBR=wnwen@chromium.org,agrieve@chromium.org > > > > Change-Id: I82f411e5dab89c361a30c33e9103bd8561f19765 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1117222 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362493 > > Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> > > Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#799471} > > Bug: 1117222 > Change-Id: Ib43bfe72869def7da43b237360df0e155149a963 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363975 > Reviewed-by: Peter Wen <wnwen@chromium.org> > Commit-Queue: Peter Wen <wnwen@chromium.org> > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800233} TBR=wnwen@chromium.org,agrieve@chromium.org Change-Id: I0d617bcfc7a311bfae743445fccaaab26364511e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1117222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368541Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#800435}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: Ia9e729229f4f9943a068fcfcb014487f44d1ad6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367524Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800434}
-
Christopher Lam authored
This CL changes RulesRegistry::DeserializeAndAddRules() to bail out if the extension has been unloaded. This may have been the cause of some crashes where a ContentAction was being created for an unloaded extension. Bug: 1010336, 1115969 Change-Id: Ibbd01c1b5b0a8f4cc3c2668fbb4b804189ba0b20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345939 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#800433}
-
Maggie Cai authored
This reverts commit cb9cdc66. Reason for revert: This CL is likely the cause of build failure for Builder Linux Tests (dbg)(1) since https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/91043. Revert to see if that fix the build Original change's description: > Give blink::CueTimeline a timer for precisely handling cue events > > Cue-related events (enter, exit, cuechange) are fired up to 250ms late, > and there is a similar latency in their display which is quite > noticeable. > > The underlying problem is that we only update cues alongside the > `timeupdate` event, which is fixed at 4 Hz. > > My solution is to add a separate timer to CueTimeline > (`CueTimeline::cue_event_timer_`) which is given a timeout for the > next cue event based on the current playback position and rate. This > allows for significantly more precise cue timing accuracy without a > significant performance penalty. > > Additionally, several web tests were written with the expectation that > the 'time marches on' algorithm is run before video playback begins > (ie, upon loading text track cues). This behavior is not in accordance > with the spec (as outlined in crbug/1050767), so this CL fixes those > expectations and adds a new test to prevent regressing. > > Bug: 576310, 1050767 > Change-Id: I675f5f030a68ba9cee10e12b3e79a9b174048193 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008079 > Commit-Queue: Will Cassella <cassew@google.com> > Reviewed-by: Fredrik Söderquist <fs@opera.com> > Cr-Commit-Position: refs/heads/master@{#800148} TBR=fs@opera.com,alancutter@chromium.org,mlamouri@chromium.org,cassew@google.com Change-Id: I0563b173344cef976c16b4f2851b45762a67843f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 576310 Bug: 1050767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368614Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#800432}
-
Renato Silva authored
Add a few strings that will be used for the lock screen settings. TBR=rsorokin@google.com Bug: 663982 Change-Id: I746480842436213efb40197e3efbcdb110c38dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367979Reviewed-by:
Renato Silva <rrsilva@google.com> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#800431}
-
Donn Denman authored
Moves the logic for whether to send the base page URL to Google servers from the C++ delegate into the Java policy class. This allows better control for Related Searches, but has no logic change. BUG=1062737 Change-Id: I8c563557eb97f736fe5cdb820dcd77d9b924f10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366302 Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#800430}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ab4e4feb01ac..e8dc820fbc1e 2020-08-21 enga@chromium.org Skip TextureSubresourceTest.MipmapLevelsTest on Vulkan w/ validation 2020-08-20 bryan.bernhart@intel.com D3D12: check if resource manager exists before releasing If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1117595 Tbr: cwallez@google.com Change-Id: If855398d377cdb4361f4f5fcd62a7d10e7f20b64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368477Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800429}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597946202-cb1005c445d83fc8c9db9d03ba0a749f78675139.profdata to chrome-mac-master-1597967068-f4dc3a01dd1d9ac3893254a5c720534a30d259cc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I782f0c9637beb97d771e42c26331a226355e4300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368280Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800428}
-
Regan Hsu authored
* Move code that was in CellularSetupDialogUI to CellularSetupImpl so that both OsSettingsUI and CellularSetupDialogUI can use it. * Bind OsSettingsUI to mojo interface. * Add cellular setup localized strings to internet section so they will be displayed in the shared UI. Bug: 1093185 Change-Id: I044e8af8f1cee07a1dda1d7ee0ada38e2c3fe6d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349389Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800427}
-
Elly Fong-Jones authored
This method has no overrides and always returns true. This change removes it, removes the only call to it, and simplifies code around that call site as a result. Bug: None Change-Id: I2c5b13552923f11615e5b2e629fc2da70fb26eb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367650 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#800426}
-
Mike Reed authored
See https://skia-review.googlesource.com/c/skia/+/312248 Change-Id: I49dec4ff0e6f19329e300eb6e94b209790229985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367441Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#800425}
-
Pranav Batra authored
Add Linux support for PPD resolution options. Test: ./printing_unittests Change-Id: I15d2245567e37938633c72daa2edc66cfa6f4b22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360472 Commit-Queue: Pranav Batra <batrapranav@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#800424}
-
chinsenj authored
Currently a user can only cycle the window cycle list using alt+tab or alt+shift+tab. Also, the user can only confirm their selection by releasing the alt key. This CL improves the interactivity of window cycler by introducing the following changes. Pressing the left and right arrows now move the selection while the window cycler is open. Pressing enter or space now confirms the selection. WindowCycleControllerTest.KeysConfirmSelection Test: WindowCycleControllerTest.LeftRightCycle, Bug: 1067327 Change-Id: I03682c5545bf82415b9e71a4814bf5c1b0c196bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358586 Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#800423}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/56d9df4fa53f..77419b0f04e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I216e344fa665ab514a8993a559b6ef10fd0f1efb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367972Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800422}
-
James Hawkins authored
Bug: 1045266 Test: NetworkComponentsNetworkPropertyListMojoTest* Change-Id: I14e9be994b77445a4106b156fcce3e48421c340b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368494 Auto-Submit: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#800421}
-
Sunny Sachanandani authored
This reverts commit 9d22b694. Reason for revert: Broke non-overlay video playback: crbug.com/1119666 Original change's description: > Use shared images with DX11 video decoder > > This change enables support for SkiaRenderer. In a future change, > GLRenderer will also be supported. > > Change-Id: I760013fdd163dcec3e3fe5d888541f07849749c7 > Bug: 1011555 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250890 > Auto-Submit: Bryan Bernhart <bryan.bernhart@intel.com> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794763} TBR=sunnyps@chromium.org,liberato@chromium.org,bryan.bernhart@intel.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1011555, 1119666, 1120094 Change-Id: Ie5fb291ea7093d3d695433181583302a36ecd88d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368240Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#800420}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/bbb2038a3f14..bb85de36d277 2020-08-21 dpranke@google.com Fix visibility on //xfa:xfa_warnings. 2020-08-20 tsepez@chromium.org Fix initialziation of XFA fuzzers against CPPGC heap. 2020-08-20 tsepez@chromium.org Make CFWL_Message and its subclasses stack-only types. 2020-08-20 tsepez@chromium.org Rename class CFX_FontSourceEnum_File to CFGAS_FontSourceEnumFile. 2020-08-20 thestig@chromium.org Reduce nesting in RelocateTableRowCells(). 2020-08-20 tsepez@chromium.org Garbage collect the FWL layer objects. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1119533 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I63b2fa2c3e5d834eb308ad1f92b8e7cf96a90eb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368278Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800419}
-
Ian Kilpatrick authored
Additionally simplify the logic with SetMinimumSizeIfAuto. There should be no behaviour change. Change-Id: I9baf6d3737fc2d0de5531b7f02a53f425d3ccb94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365313 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#800418}
-
Yuki Yamada authored
This reverts commit 351529d8. Reason for revert: This CL was intended to be reverted before M86 branch cutoff Original change's description: > Reland "Reland "Change HeapObserverList to HeapObserverSet"" > > This is a reland of 944fde32. > It was reverted because WebSocketChannelImpl::ProcessSendQueue() > accessed an unbound HeapMojoRemote, which was guaranteed to be bound > without this CL. > The issue was fixed in another CL: https://crrev.com/c/2362042 > > Original change's description: > > Reland "Change HeapObserverList to HeapObserverSet" > > > > This is a reland of f29d2ae1 > > > > ExecutionContext::NotifyContextDestroyed() has relied on the > > deterministic iteration order of ObserverList, so landing the original > > CL caused a problem. It is fixed in another CL: > > https://crrev.com/c/2352588 > > > > Original change's description: > > > Change HeapObserverList to HeapObserverSet > > > > > > The previous CL for HeapObserverList https://crrev.com/c/2060348 > > > addressed two things: changing HeapObserverList to HeapObserverSet and > > > allowing removal while iteration, and was reverted for performance > > > reasons. This CL only does the former and avoids performance > > > implications of the latter. > > > > > > This CL is for migration of NewLinkedHashSet. > > > See: https://crrev.com/c/2134039 > > > > > > Bug: 1100257 > > > Change-Id: I2426d14d77a68f200bf1398b16638e1605dd4ff1 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319087 > > > Commit-Queue: Yuki Yamada <yukiy@chromium.org> > > > Reviewed-by: Keishi Hattori <keishi@chromium.org> > > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#797115} > > > > Bug: 1100257, 1115411 > > Change-Id: Id8e1b9a4141777de89bbc471f6ac8c6508a0adff > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352292 > > Commit-Queue: Yuki Yamada <yukiy@chromium.org> > > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > > Reviewed-by: Keishi Hattori <keishi@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#798576} > > Bug: 1100257 > Bug: 1115411 > Change-Id: I796232c723d4295599832672c9eeedc8e979e757 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359657 > Commit-Queue: Yuki Yamada <yukiy@chromium.org> > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800048} TBR=haraken@chromium.org,keishi@chromium.org,yukiy@chromium.org,bartekn@chromium.org Change-Id: I7070e33c597991a997d5cf81be59b7bbe64d3b46 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1100257 Bug: 1115411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367255Reviewed-by:
Yuki Yamada <yukiy@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Yamada <yukiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#800417}
-
Kent Tamura authored
This is a reland of f1a2ccf7 This CL has no differences from the original CL. The original CL caused some memory regressions in system_health.memory_mobile, and had memory improvement in some stories. We decided not to fix the regressions. Original change's description: > Enable LayoutNG for BUTTON elements and INPUT buttons by default > > Bug: 1040826 > Change-Id: I0a2f9db962e74a44758293e0711009617e6a42d3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354119 > Commit-Queue: Kent Tamura <tkent@chromium.org> > Commit-Queue: Koji Ishii <kojii@chromium.org> > Auto-Submit: Kent Tamura <tkent@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797991} Bug: 1040826, 1078327 Change-Id: I6cfa6183571fe6c6816be09d8ef0c7110c5c45cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368612 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#800416}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6a9a910fd2c3..bedb605c8272 2020-08-20 hta@webrtc.org Transition ICE gathering state to "new" once all transports go away 2020-08-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7a8fca54..4591d36d (800031:800155) 2020-08-20 jasonlon@google.com DTMF Event Sub-API on VoIP API 2020-08-20 minyue@webrtc.org Send estimated capture clock offset when sending Abs-capture-time RTP header extension. 2020-08-20 peah@webrtc.org Removing call to deprecated SetExtraOptions method 2020-08-20 jakobi@webrtc.org Reland "Call OnReceivedOverhead after audio network adaptor is created." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1086942,chromium:1115080 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I83400f9b3e8330520c56322d3a2fa9cd32094ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368433Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800415}
-
Bo Majewski authored
DISALLOW_COPY_AND_ASSIGN macro is deprecated as indicated on the review of CL 2251524. Bug: 1111229 Change-Id: Ib25ce85a8ace16b8eb7b00a0974fec5a73e536fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362364Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Bo Majewski <majewski@chromium.org> Cr-Commit-Position: refs/heads/master@{#800414}
-
Yuke Liao authored
This CL cleans up linux-lacros-compile-rel as it has been replaced by linux-lacros-rel. Bug: 1116180 Change-Id: I617527f1a36250edb506e47952b463e564f73379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368473Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#800413}
-
Dana Fried authored
It feels weird to be able to drag the toolbar down in order to open the tabstrip tray in tablet mode but not drag up to close. This makes it possible to start a drag or fling with either the tray open or closed as long as the initial direction of the motion is correct (otherwise, the event is processed as normal). So for example, dragging or flinging down when the tray is closed, or dragging or flinging upwards when the tray is open will cause the tray to move, but not vice-versa. Bug: 1116651 Change-Id: I815d1ff189c28feb7fd6c81181e85ae37767a7ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361122Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#800412}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/cbfd396756c6..44e1791f100c 2020-08-20 srisser@google.com Add getPhysicalDeviceFeatures2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Id99ecc711a7e5904d1e57a8605d92c11aefba234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367782 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800411}
-
Yuke Liao authored
This CL disables retrying invalid shards in coverage build. Bug: 1119972 Change-Id: If0679948a745f5897835ebd823d3201fcfcb661e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368235Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#800410}
-
Jan Wilken Dörrie authored
This change adds a CreateChangePasswordUrl utility for creating a change password URL depending on the state of the kWellKnownChangePassword feature flag. Furthermore, it updates the Password Check callsites for all platforms to use this method. Bug: 927473 Change-Id: I1019c92e15ee8357751fd0a166df8a830759e3f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367060 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#800409}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2d664c1b3323..b583133590a5 2020-08-20 cjamcl@chromium.org [Lighthouse] Use friendlyMessage for error display. 2020-08-20 jalyn@microsoft.com Sources: Fix "Add property path to watch" bug 2020-08-20 bingler@chromium.org Add link for Schemeful Same-Site issues If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1054036,chromium:977291 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5f359230656d859e307efd0a701cdddee605af9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368432Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800408}
-
Nasko Oskov authored
This CL adds some traces that make understanding the flow of navigation events in the renderer process easier. These traces were very helpful in investigating https://crbug.com/1112815. Bug: 1043616 Change-Id: I97cd807b1c9fa3a35d26ecb33c7d200bba81f3e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353561 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#800407}
-
Dan Sanders authored
This reverts commit 51b274e8. Bug: 1045247 Change-Id: I4f22c1e340d6c2224eaccb29e41b2605efe0d47a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368493 Commit-Queue: Dan Sanders <sandersd@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#800406}
-
Varun Khaneja authored
Fixed: 1119987 Change-Id: I0a6ed16da25a0ae09ad188d21fa1223dc063c007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368413 Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#800405}
-
Claudio M authored
We have found this code as part of Cros-Borders project. Thanks to myy@ for discovering it. Bug: 1097287, b:163002438 Change-Id: I10643a0934677c0dcb43e59b7387155ca2792722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366534 Commit-Queue: Claudio M <claudiomagni@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800404}
-
chromium-internal-autoroll authored
Release_Notes:http://go/media_app-x20/relnotes/Nightly/media_app_202008200800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/dn-tZC1K2hB8pa-D8uCBdQh4U9xdeiQvV7QEmNoyTZQC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/153407132,b/159083441 Tbr: media-app@grotations.appspotmail.com Change-Id: I23699cd4b753bf3a0e8c010e6f20e4e91734c620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367992Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800403}
-
Eric Orth authored
Bug: 1093361 Change-Id: I54f3d2642c41ffebcb584d816eeca36ae0dca702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364082 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#800402}
-
Xinghui Lu authored
Metric added in this CL: SafeBrowsing.RT.AllStoresAvailable Bug: 1096294 Change-Id: I03cc4ea2f884e28e81e9c400a406a25707f8a132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360924 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#800401}
-
Rouslan Solomakhin authored
Before this patch, the secure payment confirmation parameters to PaymentRequest API from Blink would not be passed to the browser process. This patch adds Mojo IPC for secure payment confirmation parameters and new type of payment app for the Web Payment that is based on these parameters. After this patch, Blink passes the secure payment confirmation parameters to the browser over mojo IPC and the browser uses these parameters to construct a payment app (when "SecurePaymentConfirmation" Blink runtime flag is enabled). Design: https://bit.ly/secure-payment-confirmation Explainer: https://github.com/rsolomakhin/secure-payment-confirmation Bug: 1110320 Change-Id: I7b9329d8d6c9724dd05b8d30492677baf2677186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359733 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#800400}
-
Yuheng Huang authored
The TabUpdated() API will be called from from TabStripModelObserver.TabChangedAt() It will send out UpdateTabInfo for the updated tab so no more additional API calls are needed. Related CL: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3217588 Bug: 1099917 Change-Id: Id46b18827a8ef4f3c02d5a992ef4a3cc8ae2f6f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357958Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#800399}
-
Owen Min authored
The following policies can't be finished before M86 branch point. Move them to unreleased state so that they can be done in the upcoming milestone. DevicePrintersBlocklist => DeviceNativePrintersBlacklist DevicePrintersAllowlist => DeviceNativePrintersWhitelist DevicePrintersAccessMode => DeviceNativePrintersAccessMode DevicePrinters => DeviceNativePrinters UsbDetachableAllowlist => UsbDetachableWhitelist DeviceUserAllowlist => DeviceUserWhitelist Also update the references to those policies. Bug: 1098051, 1098048,1105183, 1105185, 1103813, 1103816, 1119961 Tbr: pastarmovj@chromium.org Change-Id: I953cd170423753af7d1064dcdac6e99c59e2732d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367873 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#800398}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/56d9df4fa53f..77419b0f04e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3727e0bd75ff58d10f59f28cbf12ef12ade55891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367447Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800397}
-