- 06 Jul, 2020 40 commits
-
-
Sigurd Schneider authored
Bug: chromium:1011811 Change-Id: Ic95ddf1f4df61f312aa3707c477a69152ef8a386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279191 Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#785301}
-
Nico Weber authored
-Wmax-tokens coverage on mac/intel should be sufficient for now. We just need to remember to switch this when we turn down the intel mac bots in a decade or so. ../../content/public/browser/content_browser_client.cc:12:31: error: the number of preprocessor source tokens (902784) exceeds this token limit (860000) [-Werror,-Wmax-tokens] #pragma clang max_tokens_here 860000 ^ Bug: 1098899 Change-Id: I5ddefd30b39cffb0a9aacd2838847c9c06d3fe93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281319 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#785300}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e2f33ada858c..61570250a193 2020-07-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I11cdd6b36f29741156c1633c2276fbb2bf69a801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282268Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785299}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b24a8db8..e5f1009d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I82ea15218e51377f5e058dd128ed35e438cd220d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282104Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785298}
-
Owen Rodley authored
Follows the current Gatekeeper config - tree closing enabled for all builders, with a handful of builders that close the tree regardless of which step fails. Bug: 1094768 Change-Id: I03ddc4fbd7a02654146b93a9b1387b97a942c238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279267 Commit-Queue: Owen Rodley <orodley@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Owen Rodley <orodley@chromium.org> Cr-Commit-Position: refs/heads/master@{#785297}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1593993254-dbbaa6aa1e1e0b6f79ccb648844aec2deeff08b4.profdata to chrome-mac-master-1594014961-7d45cb9775a1becec1c537c70e86c3de2e101ea0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I42c39694df1fe4145a403abe86a7b68b2d143172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282269Reviewed-by:
-
Jing Wang authored
This list from https://docs.google.com/spreadsheets/d/1VELTWiHrUTEyX4HQI5PL_jDVFreM-lRhThVOurUuOk4/edit#gid=0, which is confirmed by laurentt@ For some google internal website, we are comparing hash instead of plain text to prevent internal url from leaking through binary. For convenience, we are now using package name for arc++ apps, because they are more readable and easy to obatin. However, for system apps, we need to use app id since they don't have package name. Currently allow lists for emoji and personal info are the same, but they may be different in the future. Bug: 1101616 Change-Id: Ied2884b8fadc38dc68f693565d5d20abe07aa906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278910Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#785295}
-
Qijiang Fan authored
For Python3 compatibility. Converting [module.StructField] into set requires StructField to be hashable, but module.StructField has __eq__ defined only not __hash__. $ python3 ./mojo/public/tools/bindings/mojom_bindings_generator.py generate $(pwd)/mojo/public/mojom/base/time.mojom --bytecode_path . -d $(pwd) Traceback (most recent call last): <stacktrace partially trimmed> File "/ssd2/chromium/src/mojo/public/tools/bindings/generators/mojom_cpp_generator.py", line 961, in <genexpr> for param_count in param_counts) File "/ssd2/chromium/src/mojo/public/tools/bindings/generators/mojom_cpp_generator.py", line 205, in __init__ self._params = set(params) TypeError: unhashable type: 'StructField' Bug: 941669 Change-Id: I1ca8f67d86754cbad668a47a6f0ddd513e5ce896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277687 Commit-Queue: Qijiang Fan <fqj@chromium.org> Auto-Submit: Qijiang Fan <fqj@chromium.org> Reviewed-by:Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#785294}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1593993254-590c1c6949804f5c7fc0a1e827a031b5cd1d9e34.profdata to chrome-win32-master-1594004320-2e826e0a02d03f5d95b06057ee6fb0c871fea712.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ied1f7c9a75f288b9189266f5ab66509842e989f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282262Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b19fe438d6bf..fb0275a7e102 2020-07-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from bae95f817a59 to 465a912582bb (12 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: mtklein@google.com Change-Id: I41e64424b15df4a0a15cbf1aa37670fcf95ec01a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282265Reviewed-by:
-
My Nguyen authored
- Press "Enter", open settings when Learn More button is chosen. - Press "Up" from first candidate/ no candidates chosen, highlight Learn More button. - Press "Down" from last candidate, highlight Learn More button. Bug: 1101195 Change-Id: I7900cef2ea361f777b6d6586d396541f10234946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280751Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#785291}
-
Hiroki Nakagawa authored
Bug: 1007635 Change-Id: Ibe143f64d27e93c034125f4d5f7b92cb5ede5318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280973 Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#785290}
-
Jing Wang authored
Now we will suggest a full address including city, state and zip code. Note that although the country field will not be included in the suggestion, it is essential for generating the full address correctly. Test: tested on Chrome on Linux, updated the unit test. Bug: 1101654 Change-Id: I221b0cb81079342129e768eeaba0f3210394292e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278902 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
-
Kent Tamura authored
This CL reduces the estimated pre-processed size of html_element.h by 2.53MB. This CL has no behavior changes. Bug: 242216 Change-Id: Icb9861dcbc28599e8cd6d5bfe657dde4329db70f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281771 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Koji Ishii authored
This patch fixes a case where |DirtyLinesFromNeedsLayout| fails to mark items dirty for reusing cached lines. When searching for |LayoutObject| needing layout, checking |NormalChildNeedsLayout| and |PosChildNeedsLayout| were not enough. In some specific cases, only |NeedsSimplifiedNormalFlowLayout| was set for the parent inline box. This patch changes the condition to check descendants to |NeedsLayout|. Bug: 1101883 Change-Id: Ia73ace058c9ea1ebaaffdaff793b56d68099cd5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281781Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#785287}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/52a4379f03f7..b19fe438d6bf 2020-07-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 5bc7af43 to 2d0c7f09 (290 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: mtklein@google.com Change-Id: I9495df3bfbb8bbc1bd708f78245c0d43e94706e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282261Reviewed-by:
-
Matt Giuca authored
This makes a slight change to error messages: notably, we no longer explicitly check if the URL is same origin with the document URL (which is implied by being within scope), hence same-origin errors are now reported as not-within-scope errors. Bug: 1101909, 1101910, 1101911, 1101912 Change-Id: I492688f667d7cd351bbc1dfe1ce39d5276d9fa93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280961Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#785285}
-
My Nguyen authored
Only show index when users press into emoji suggestion. See bug for mock and implementation view. Bug: 1102210 Change-Id: I3f72d4c00784dc2fb4fe932fb20cdc12ad23440a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279263 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2329308662f7..e2f33ada858c 2020-07-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iaf02fda6c37a6b955150a2078af03b007d875572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282059Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium f0765c37. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I69d78cab8f8b31558028eebc29b2b2d9befc6065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282102Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785282}
-
Jing Wang authored
Bug: 1099498 Change-Id: I7ca8fdfbb145332bdb6cda54dbf59c86f7f86104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279344 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
-
Zufeng Wang authored
Follow the same pattern as cros settings. Bug: b/160103160 Change-Id: Ia07f7c595dae4b8696a91cc1a8a6e0a7e3cb121a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280766 Commit-Queue: Zufeng Wang <zufeng@google.com> Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#785280}
-
Quang Minh Tuan Nguyen authored
This seems not to be used anywhere Bug: 1007686 Change-Id: I760479dc9d150246a8d9cc33fd568fb60dbcd3c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280974Reviewed-by:
Daichi Hirono <hirono@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Quang Minh Tuan Nguyen <nqmtuan@google.com> Cr-Commit-Position: refs/heads/master@{#785279}
-
Nnamdi Theodore Johnson-Kanu authored
- Migrate multidevice page tests to Polymer3 - Add missing chromeos resources - Move constant from multidevice_smartlock_subpage to multidevice_constants file Bug: 1045266 Change-Id: I8e4412e0bd181f97b2f57901e0042aa1e735ce3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232811 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#785278}
-
Hiroki Sato authored
http://ag/12064837 makes more window events being sent to chrome. It became possible to send an event with a window source, so this change makes FromContentChangeTypesToAXEvent correctly handle such an event. AX-Relnotes: N/a. Bug: none Test: unit_tests Change-Id: I064f7fe648a9f864e2c72f4b08354f35b9802c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279265 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#785277}
-
Jia authored
Bug: 1090132 Change-Id: I10a0fc0ad6f7c94a0accd982eb4d1f4f8f0e348c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279264 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
-
Noel Gordon authored
Do not process dragenter events on the directory tree unless they have an event.relatedTarget. If there is no event.relatedTarget, ignore the dragenter event (consider it spurious). This avoids re-styling a directory-tree tab for drag-drop style, based on spurious dragenter events, since that causes the directory-tree tab color to "flicker" in files-ng after crrev.com/781857 (see bug). In avoiding these events, we must still set the drag cursor effect and event.preventDefault, or else the browser will flicker the drag cursor with an equally annoying 'no-drop' cursor effect when starting a drag. Use a 'move' cursor effect to eliminate drag cursor "flicker". Bug: 1099128 Change-Id: I316af660ca6a4811bbe5a92efd812f3162ea5f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269828Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#785275}
-
Jecelyn Yeen authored
Bug: 1101779 Change-Id: I00214f6ff55b260b9cabad80ae9bc5ad93d0886b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280967 Auto-Submit: Jecelyn Yeen <jec@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#785274}
-
Bartek Nowierski authored
Bug: 1092288 Change-Id: Icd10cab67ac970d4569049ccaaf63bcc69b781ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281769Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#785273}
-
My Nguyen authored
Bug: 1099498 Change-Id: Ic162dcb8312657b9b7f59597ca660a6054cf3d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279300 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
-
Yuki Shiino authored
This reverts commit 2c5f2493. Reason for revert: Suspicious about the test failures: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/16356 Original change's description: > Move ownership of SpellCheckClient to TestRunnerBindings > > There is one per frame, and WebFrameTestProxy doesn't actually need > access to it. So simplify the ownership/pointer graph by moving it > entirely inside TestRunnerBindings. > > R=avi@chromium.org > > Bug: 866140 > Change-Id: I091c1aa899c70db0ac1bafabf19707ea3245e88e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281284 > Commit-Queue: Avi Drissman <avi@chromium.org> > Auto-Submit: danakj <danakj@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#785236} TBR=avi@chromium.org,danakj@chromium.org Change-Id: I64bcfec65efea9650d509cffc5f54b75c2bc1d63 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 866140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280975Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#785271}
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: Ic0ac34132e7e9491b4f528b5f2723ed4ebb0dc6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256848 Commit-Queue: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#785270}
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: I1c171d87550c8b3b5a2e4b1b0bfb354a8fad6d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258335Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#785269}
-
Yoshifumi Inoue authored
This patch changes EditingNG runtime enabled feature to imply NGFragmentItem. When we invoke content_shell with --enable-blink-features=EditingNG, NGFragmentItem is also enabled. Change-Id: I66ada34cd5a6c80d1d495dd2a9ea0627d3fd5b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276127 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#785268}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1593979239-b3cdbe0a0e1ab5854749cceb4966c42dca8c5cdb.profdata to chrome-win32-master-1593993254-590c1c6949804f5c7fc0a1e827a031b5cd1d9e34.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I25093851976c57d6260e834ab93595222fc1350b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282044Reviewed-by:
-
My Nguyen authored
Current view: http://screen/CMsrUW1NA6N See mock in bug. Bug: 1101195 Change-Id: I1bfeca082848550b1d48fd20f9c9dd1a08a84f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275159 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: Ie67eeb489bca3a41c9556c66f693c64eff0c79a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257409Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#785265}
-
Kent Tamura authored
ComputeAnnotationOverflow() does - Apply em-height for text fragments - Apply ScrollableOverflow(kEmHeight) for LayoutNGRubyRuns in order to compute annotation space based on em-height. ComputeAnnotationOverflow() kept track of annotation_over/under values. However now ScrollableOverflow(kEmHeight) provides annotation overflow offset too. Now content_over/under values represent over/under limits of annotation overflow too. * Extract some parts of AdjustTextRectForEmHeight() to AdjustTextOverUnderOffsetsForEmHeight() so that ComputeAnnotationOverflow() use it easily. * Fix NGPhysicalBoxFragment::ScrollableOverflowFromChildren(). We didn't merge rectangles over block_offset=0. It can happen for <rt> in ComputeAnnotationOverflow(). Bug: 1082087 Change-Id: Id97ad4ce0bff265c627620c121fc5e33e157bf94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280742Reviewed-by:
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: I4b1b780da04a195eac96041d468117027300d1ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256854Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ad621f799f37..08485d8c2154 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yukishiino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yukishiino@google.com Change-Id: If4ab00b3c83538bf2f5bbf6cac926dd6083889f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282049Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785262}
-
