Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 16 Jul, 2017 6 commits
    • Felix Ekblom's avatar
      Listen to changes to touch input devices · 1b600061
      Felix Ekblom authored 
      In https://codereview.chromium.org/2964823002 the OobeDisplayChooser
started using the DeviceDataManager to look for touchscreen devices when
searching for a good primary display to use during OOBE.

On device cold boot the DeviceDataManager has not yet found any
touchscreen devices at the time OobeUi::ShowOobeUI() is called (likely
due to lower level systems not being fully initialized).

This CL make LoginDisplayHostImpl an observer of changes to connected
touchscreen devices, re-triggering the OobeDisplayChooser when the
DeviceDataManager is notified of the connected touchscreens. This
overcomes the timing issues on cold boot.

Bug: 738885
Change-Id: Iae488ddc9428b7c5e74d36cf18e35ba3d1235bbd
Reviewed-on: https://chromium-review.googlesource.com/569958Reviewed-by: default avatarJacob Dufault <jdufault@chromium.org>
Commit-Queue: Felix Ekblom <felixe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487007}
      1b600061
    • Koji Ishii's avatar
      [LayoutNG] Cleanup NGBaseline · cdd829b1
      Koji Ishii authored 
      This is a follow up and minor cleanups after the initial NGBaseline
patch[1].

1. Addresses cbiesinger reviews.
2. NGBaseline has NGBaselineRequest as a member.
3. Some arguments are changed to use struct, not each member.

[1] https://codereview.chromium.org/2867293002/

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Change-Id: Ib781a08f3b85be6519b70f07413719d0a76db7e7
Reviewed-on: https://chromium-review.googlesource.com/571680
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: default avatarChristian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487006}
      cdd829b1
    • Tomasz Figa's avatar
      Always honor pkg-config command coming from the user · cf2215de
      Tomasz Figa authored 
      When building from within a ChromiumOS chroot (and any other
Gentoo-base system), the right command to call pkg-config is specified
up front and needs to be honored. However currently Chromium build
system always calls 'pkg-config' directly if --sysroot is given to the
build. This ignores any necessary setup done by the board sysroot
pkg-config wrapper used on ChromiumOS and causes host's paths being
pulled into the build. Precisely, PKG_CONFIG_PATH is not being unset and
PKG_CONFIG_SYSROOT_DIR is not being set to the sysroot path.

Fix this by always using the specified pkg-config binary, even if
sysroot is given. Even though, the problem could be fixed up by adding
necessary setup to Chromium's pkg-config wrapper, it is not the right
solution, as the setup is inherently sysroot specific and only the
external build system is aware of necessary configuration to be done.

Bug: 743366
Test: Build chromeos-chrome with host's /usr/lib64/pkgconfig/dbus-1.pc chmodded to a-r.
Change-Id: I6e80dbaa94510e31aa5000c6cc31ca32b5e5cbe4
Reviewed-on: https://chromium-review.googlesource.com/572666Reviewed-by: default avatarDirk Pranke <dpranke@chromium.org>
Commit-Queue: Tomasz Figa <tfiga@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487005}
      cf2215de
    • Takeshi Yoshino's avatar
      Fix broken WATCHLISTS rules · 6b30abd0
      Takeshi Yoshino authored 
      Bug: 
Change-Id: I2226cd621bcd9c85d8ce179f14f768645cf97db3
Reviewed-on: https://chromium-review.googlesource.com/572444
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487004}
      6b30abd0
    • Nicholas Verne's avatar
      Moves WebDevToolsAgentImpl to core. · 35934f34
      Nicholas Verne authored 
      WebDevToolsAgentImpl uses many InspectorAgents that are implemented in modules/.
To enable these agents' use from core/ we now register a callback from
ModulesInitializer::Initialize that can append the modules/ InspectorAgents
to an InspectorSession.

Since WebDevToolsAgentImpl needs to use static methods of WebView and
WebViewBase directly, these need to be availble in core/ as well. We created
WebViewBase.cpp and moved the definitions there. Also, to keep Windows happy
WebViewBase is now a NON_EXPORTED_BASE of WebViewImpl, since there is now
code for WebViewBase static methods in different library and Windows otherwise
fails to link
warning C4275: non dll-interface class 'blink::WebViewBase' used as base for
dll-interface class 'blink::WebViewImpl'

Bug: 712963
Change-Id: I9159327618118b2a2f652ed15a76271040b5bc30
Reviewed-on: https://chromium-review.googlesource.com/544726
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Reviewed-by: default avatarSasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487003}
      35934f34
    • chrome-release-bot's avatar
      Updating trunk VERSION from 3159.0 to 3160.0 · 7c2197a3
      chrome-release-bot authored 
      TBR=dimu@chromium.org

Change-Id: I3ab7d08870b5f5c78af2c2b5bd6ffbce345b4242
Reviewed-on: https://chromium-review.googlesource.com/572396Reviewed-by: default avatarchrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487002}
      7c2197a3
  3. 15 Jul, 2017 34 commits