GitLab

It's because GLES2DecoderImpl::HandleDestroyStreamTextureCHROMIUM can
clear the target of a streamtexture which is not zero.
It occurs when destorying a html5 video on Android platform because it will
create/destroy streamtextures.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/11421148

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170915 0039d316-1c4b-4281-b951-d872f2087c98

This is the Mac version of this CL:
https://chromiumcodereview.appspot.com/11410067
It limits the width of tab titles and window names in the recent tabs menu.

BUG=160844


Review URL: https://chromiumcodereview.appspot.com/11316127

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170914 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160904


Review URL: https://chromiumcodereview.appspot.com/11280140

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170913 0039d316-1c4b-4281-b951-d872f2087c98

This replaces the DirectShow based implementation for Vista,Win7 and Win8.
DirectShow isn't supported in metro mode so once we've landed this,
we can revert the workaround we have in place for Win8.

The CapabilityList class is mostly moved code from the DS implementation.
The difference is that I'm not using a std::map<> since that wasn't
really necessary and instead adding one member (via inheritance) to
the capability struct on Windows that holds the stream id that is needed.

BUG=140545
TEST=All video capture tests in media_unittests now test this new implementation (except on XP).

Review URL: https://codereview.chromium.org/11419200

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170912 0039d316-1c4b-4281-b951-d872f2087c98

BUG=164030


Review URL: https://chromiumcodereview.appspot.com/11421212

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170909 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163060


Review URL: https://chromiumcodereview.appspot.com/11414238

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170908 0039d316-1c4b-4281-b951-d872f2087c98

This refactors the following flash functions to the new resource model.
-GetProxyForURL
-UpdateActivity
-SetCrashData

BUG=


Review URL: https://chromiumcodereview.appspot.com/11415140

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170907 0039d316-1c4b-4281-b951-d872f2087c98

BUG=156041
TEST=manual

Review URL: https://codereview.chromium.org/11421125

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170904 0039d316-1c4b-4281-b951-d872f2087c98

The ConstrainedWindowMacTest.ShowInUninitializedTab was failing on some bots.
http://build.chromium.org/p/tryserver.chromium/builders/mac_rel/builds/78878/steps/browser_tests/logs/stdio

> Fix showing constrained window for uninitialized tabs
> 
> If a tab is added without being shown then the associated tab view for the web content will not be created yet.
> 
> When a constrained window is added to that tab the window never gets shown.
> 
> To fix this I've changed ConstrainedWindowMac2 to reshow the window once the web contents becomes visible.
> 
> BUG=163778
> TEST=Reproduced bug 163778 and verified that my patch fixes it.
> Verified that ConstrainedWindowMacTest.ShowInUninitializedTab fails without my patch and passes with it.
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/11419277

TBR=sail@chromium.org
Review URL: https://codereview.chromium.org/11418304

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170903 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107201
TEST=no visible change


Review URL: https://chromiumcodereview.appspot.com/11414286

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170902 0039d316-1c4b-4281-b951-d872f2087c98

TEST=all existing tests

Review URL: https://codereview.chromium.org/11308340

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170901 0039d316-1c4b-4281-b951-d872f2087c98

This patch includes:
- Adding DriveFileSyncClientObserver to notify OnAuthenticated event
- Invoking SyncFileSystemService::OnRemoteServiceStateUpdate when OnAuthenticated event happens.

BUG=161436
TEST=manual (Launch test app -> Logout -> Login -> Receive notification)

Review URL: https://codereview.chromium.org/11414253

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170900 0039d316-1c4b-4281-b951-d872f2087c98

toolchain option is deprecated.


BUG=


Review URL: https://chromiumcodereview.appspot.com/11316289

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170899 0039d316-1c4b-4281-b951-d872f2087c98

BUG=152389


Review URL: https://chromiumcodereview.appspot.com/11312157

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170898 0039d316-1c4b-4281-b951-d872f2087c98

- Eliminate variadic arguments in favor of C++ templates.
  This makes ASAN and Valgrind much happier, as we are no
  longer accessing more arguments than what has been passed
  into our function (i.e. in the past, we'd always forward
  six arguments to the kernel, even if the system call
  needed fewer; now, we explicitly pass zeros).

- In the past, callers had to be very careful when passing
  NULL, as the C++ compiler was likely to treat this macro
  as a 32bit integer value rather than a 64bit pointer. We
  now always perform sign extension for expanding arguments
  to the full native word width.

- On x86-64, we could clobber up to eight (in some cases 16)
  bytes in the red zone. This would typically only happen
  when high optimization levels were turned on, and in many
  cases it ended up overwriting data that was no longer
  needed. But we have seen at least one case where we ended
  up clobbering a system call parameter. We now explicitly
  avoid the red zone and this problem can no longer happen.

BUG=163904,162925
TEST=sandbox_linux_unittests
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11416326

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170896 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163804
TEST=ran new tests in accelerator_controller_unittest.cc. tested manually too.

Review URL: https://codereview.chromium.org/11419306

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170895 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127536
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11416336

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170894 0039d316-1c4b-4281-b951-d872f2087c98

Previously the test was racy due to when the RecordUnrecoverError method
expectation was set. Now that it's no longer an unrecoverable error, we
can remove the expectation altogether.

BUG=162793,117796


Review URL: https://chromiumcodereview.appspot.com/11308331

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170893 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduces VirtualAudio{Input,Output}Streams to handle redirecting audio output from Chrome into a virtual input stream to be used as "fake" microphone input. That stream could then be used through WebRTC peer connection, essentially playing back audio from the browser remotely.

Limitations:
Currently, only one VirtualAudioInputStream is supported, so we can only capture browser-wide audio once. Subsequent requests for audio through the TabCapture API will result in no audio for that stream.

Overview:
When a VirtualAudioInputStream is created (which is triggered by the Chrome TabCapture API), we trigger a device change event which will cause all currently active output streams to be recreated as VirtualAudioOutputStreams. These will attach to the virtual input stream when they start/resume playback.

When the VirtualAudioInputStream is to be released, it triggers another device change event to revert all the output streams back to output to sound hardware. The VirtualAudioOutputStreams must detach from the VirtualAudioInputStream when they are stopped, thus VirtualAudioInputStream must outlive all VirtualAudioOutputStreams.

BUG=153392

Review URL: https://chromiumcodereview.appspot.com/11298006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170892 0039d316-1c4b-4281-b951-d872f2087c98

This change causes shutdown crashes when chrome menu is used to exit.

> Keep browser process alive while there are platform apps with background pages running. This does not happen on Android or ChromeOS builds: Android does not support browser process keep alive, and ChromeOS does not need or like it.
> 
> This change prevents platform apps getting killed unceremoniously while they have background pages active.
> 
> This also delays the process being shutdown after closing the last platform app window, as background pages are kept alive for 15 seconds after their last activity is completed.
> 
> This change re-lands r165772 which caused problems on Google branded ChromeOS. This version does not add keep alives for ChromeOS and was tested on the ChromeOS try bots.
> 
> TBR=davemoore@chromium.org for the ash launcher test change.
> 
> BUG=155457
> TEST=Make sure platform apps can be used from the launcher without chrome windows open; make sure Chrome shuts down properly in all cases.
> 
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165772
> 
> Review URL: https://chromiumcodereview.appspot.com/11117011

TBR=benwells@chromium.org
Review URL: https://codereview.chromium.org/11299326

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170891 0039d316-1c4b-4281-b951-d872f2087c98

The EventHandler overriddes should mark the event as having been processed
(Event::SetHandled) when the event triggered an action, or stop the propagation
of the event (Event::StopPropagation) as appropriate (when the handler destroyed
the event-target, for example).

BUG=163618

Review URL: https://codereview.chromium.org/11280290

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170890 0039d316-1c4b-4281-b951-d872f2087c98

Safe reference counting for skia objects ahoy!

R=jamesr
BUG=163454
Depends on: https://codereview.chromium.org/11418217/
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11412255

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170889 0039d316-1c4b-4281-b951-d872f2087c98

- This CL changes the directory title for origins, from "chrome-extension://exampleextension" to "exampleextension"
- Also, drops file name escape.

BUG=163554

Review URL: https://codereview.chromium.org/11411280

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170887 0039d316-1c4b-4281-b951-d872f2087c98

- The method takes FileSystemURL and returns a new enum: fileapi::SyncFileStatus, which takes one of either: UNKNOWN, SYNCED, HAS_PENDING_CHANGES or CONFLICTING

BUG=163860
TEST=SyncFileSystemService.GetFileSyncStatus

Review URL: https://codereview.chromium.org/11421197

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170886 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163454
R=sky
Depends on: https://codereview.chromium.org/11280251/
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11414251

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170885 0039d316-1c4b-4281-b951-d872f2087c98

BUG=153703

Review URL: https://codereview.chromium.org/11419274

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170884 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127536
Review URL: https://codereview.chromium.org/11434097

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170883 0039d316-1c4b-4281-b951-d872f2087c98

Move print_preview_test because it's only used in unit_tests, and update as-a-result unneeded dependency on test_shell_test_support.

R=jam@chromium.org
TEST=interactive_ui_tests, unit_tests, and browser_tests link

Review URL: https://codereview.chromium.org/11434098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170882 0039d316-1c4b-4281-b951-d872f2087c98

We only have to run the complete tree synchronization algorithm if the cc::Layer tree's
structure is actually changed, otherwise we can just push properties over since the
cc::LayerImpl tree structure is never changed outside of commit.

Since scroll offset updates are tied into the tree synchronization algorithm, we currently
have to do a full tree sync for scroll updates. Fixing this will speed up scroll operations
but requires a bit more work.

Speeds up cc_perftests tenTenSingleThread by 7.3%

BUG=161166


Review URL: https://chromiumcodereview.appspot.com/11316297

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170881 0039d316-1c4b-4281-b951-d872f2087c98

This is a retry of r169875, hopefully with fewer regressions.

This time, I simply notify the theme service (instantiating it
if necessary) when a theme extension is installed.

This should avoid the theme regression since that path is not
taken on browser startup.

BUG=161203
TBR=pkotwicz@chromium.org

Review URL: https://codereview.chromium.org/11411330

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170880 0039d316-1c4b-4281-b951-d872f2087c98

This covers remaining content/ and webkit/ manual ref-counting.

BUG=163454
R=piman
Depends on: https://codereview.chromium.org/11418217/
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11428099

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170879 0039d316-1c4b-4281-b951-d872f2087c98

R=vandebo@chromium.org
BUG=163454
Depends on: https://codereview.chromium.org/11428099/
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11316263

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170878 0039d316-1c4b-4281-b951-d872f2087c98

Instead of giving const pointers to the renderer, we should provide it with
non-const pointers, and expect it to consume the render passes that we provide
it.

In ubercomp, the delegating renderer will pass ownership of the passes to the
CompositorFrame. 

Covered by existing tests, no change in behaviour.

BUG=152337
R=enne,piman
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11419269

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170877 0039d316-1c4b-4281-b951-d872f2087c98

TEST=existing test, GDataWapiParserTest.*
BUG=


Review URL: https://chromiumcodereview.appspot.com/11428046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170876 0039d316-1c4b-4281-b951-d872f2087c98

This removes the code for sending the user to GView for PDF
and .ppt files.  The --enable-gview flag has been passed
unconditionally on Chrome OS for a long time, but we ignore
it in official builds.  For Chromium OS, I believe that
https://chrome.google.com/webstore/detail/docs-pdfpowerpoint-viewer/nnbmlagghjjcbdhgmkedmbmedengocbn
provides similar functionality.

BUG=161786
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/11411071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170875 0039d316-1c4b-4281-b951-d872f2087c98

rename files to match IDR names.

BUG=152929
TEST=none

Review URL: https://codereview.chromium.org/11348366

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170872 0039d316-1c4b-4281-b951-d872f2087c98

XP seems to be lowering the priority of the thread responding to
audio callbacks when backgrounded, causing glitching.

BUG=161307
TEST=background playback on XP works without issue.

Review URL: https://codereview.chromium.org/11316284

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170870 0039d316-1c4b-4281-b951-d872f2087c98

Tweaks HQP "new scoring" by
(1) By a smooth squash, prevent HQP from scoring above 1400.  This makes sure inlineable, high-quality, prefix matches (whether scored by HUP or by the HUP-like mode in HQP), which has scores in the 1400-1410 range, are not trumped.
(2) Remove any credit for mid-word matches in titles.  I decided spacing in titles should always make sense and allowing mid-word matches here seems wrong.

Also, I changed the name of the "new scoring" field trial as well so we can distinguish the new behavior trial from the old behavior trial.

This trial is set up independent of the "old scoring" ignore-all-mid-word-matches field trial.  I prefer it this way because then I can easily enable or disable one without having to change much code.  Will analyze them in a dependent/correlated fashion--that is, I will only look at this trial when in the control group of the ignore-mid-word-matches trial and will only analyze the mid-word-matches trial when in the control group of this trial.

BUG=161911
TEST=


Review URL: https://chromiumcodereview.appspot.com/11416285

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170869 0039d316-1c4b-4281-b951-d872f2087c98

There's a measurable (2.3-3%) perf improvement from inlining QuadF's dtor and
ctor, even though FindBadConstructs thinks it's too large.

BUG=
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11280279

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170868 0039d316-1c4b-4281-b951-d872f2087c98

> Browser Plugin: Update DOM Node attributes when properties are updated
> 
> BUG=163611
> Test=BrowserPluginHostTest.*, BrowserPluginTest.*, WebViewTest.*
> 
> Review URL: https://codereview.chromium.org/11418261

TBR=fsamuel@chromium.org
Review URL: https://codereview.chromium.org/11415279

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170867 0039d316-1c4b-4281-b951-d872f2087c98