GitLab

Adds a NamesMap class to represent a map of part names to ordered-set of partnames.

Add partmap attribute to HTML attributes.

Adds methods on Element and ElementRareData to set/get the parsed part name map.

Bug: 805271

Change-Id: Ib17a00873cd1598b88f5e120dd96e63580390443
Reviewed-on: https://chromium-review.googlesource.com/994896Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553034}

BUG=722573
R=scottmg@chromium.org

Change-Id: I6bd8d47f7d88947ac779b957a6dd7ab2c913061a
Reviewed-on: https://chromium-review.googlesource.com/1023417Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553033}

The section of .text covered by the orderfile is now located in the
middle of the binary, after the clang roll in r550608. This negatively
impacts startup performance as the prefetcher doesn't start by fetching
the early startup code.

This fixes it by fetching the ordered range first, then all of
.text. Fetching the ordered section twice should add almost no time, as
it is not even a minor page fault the second time.

Bug: 833299
Change-Id: Id71818a90552c85849b20624a4d144098c102a42
Reviewed-on: https://chromium-review.googlesource.com/1024032Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553032}

* Using //build/config/compiler:no_chromium_code.
* Removing global compiler flags (-Wall, etc..).
* Removing extra warnings (-Wcast-qual, etc..).

This CL doesn't remove the -Wno defined by Abseil. It could be done
in a future CL but it requires building all the targets on all the
supported platforms and at the moment it is not something easy to do (
but it is something we should be able to do soon).

Bug: webrtc:8821
Change-Id: I8ebb761af9c93e2829e2bd3d4f595c5312178b7f
Reviewed-on: https://chromium-review.googlesource.com/1024830
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553031}

Show size, path, last modified time and connection count in
chrome://indexeddb-internals page when in incognito mode.

Bug: 392933
Change-Id: I7f593ff66117964044353abc21da8a4b2ab44990
Reviewed-on: https://chromium-review.googlesource.com/956831
Commit-Queue: Xunran Ding <xunran.ding@samsung.com>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553030}

TBR: newt@chromium.org
Bug: 836110
Change-Id: I32e287ae93a48cb62d0d9de69a5fdbc8095ad571
Reviewed-on: https://chromium-review.googlesource.com/1025670
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553029}

Traffic annotation extractor clang tool is updated to return the
expansion path of the macros for returned elements.

Bug: 690323
Change-Id: I2fe33a42bfcbf0e19bcbf798ecb7a9690e53d020
Reviewed-on: https://chromium-review.googlesource.com/1023399Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553028}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=pastarmovj@chromium.org

Bug: 825327
Change-Id: I4c8a61d564fa2c7c87ad95a334267a1715bb7563
Reviewed-on: https://chromium-review.googlesource.com/1024661
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553027}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=pastarmovj@chromium.org

Bug: 825327
Change-Id: Id0fda433bb3e714fb4de1d7d1dfb9d8f429515a7
Reviewed-on: https://chromium-review.googlesource.com/1024313
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553026}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=pmarko@chromium.org

Bug: 825327
Change-Id: I78406e5535645c6a03c283fe2e22a9f801e7efdd
Reviewed-on: https://chromium-review.googlesource.com/1024447
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553025}

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/7aaece4a0870..dea305b1a70d

$ git log 7aaece4a0..dea305b1a --date=short --no-merges --format='%ad %ae %s'
2018-04-12 jkardatzke Add signal for container startup failures for VMs

Created with:
  roll-dep src/third_party/cros_system_api

Bug: None
Change-Id: I26f73eb9784066551c938e34400726f861710137
Reviewed-on: https://chromium-review.googlesource.com/1025530Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553024}

This CL is just for code health.

Change-Id: I5bba4aa0ac3e4daedf8e5cebfc7bbdd1ca64c822
Reviewed-on: https://chromium-review.googlesource.com/1025533Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553023}

BUG=762641
TBR=tbarzic@google.com

Change-Id: Ib376bddba9820d83bfb40acbd45e666d7e3d7455
Reviewed-on: https://chromium-review.googlesource.com/1025631Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553022}

https://chromium.googlesource.com/catapult.git/+log/6fd1dbd39dac..93b7358c3cf0

$ git log 6fd1dbd39..93b7358c3 --date=short --no-merges --format='%ad %ae %s'
2018-04-23 nednguyen Update Telemetry doc to stop referring to Telemetry zip archive

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: Ida69c54ae9d01395505cd75685243c878f1f8083
Reviewed-on: https://chromium-review.googlesource.com/1025276Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553021}

TBR: mgersh@chromium.org
Bug: 836106
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I910a743538a24c6a43eb6e2f3bf591232ffdca86
Reviewed-on: https://chromium-review.googlesource.com/1025534Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553020}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=alemate@chromium.org

Bug: 825327
Change-Id: I94fa0384312871ab8e645ad3174f5e380e32a77d
Reviewed-on: https://chromium-review.googlesource.com/1024287
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553019}

This patch enables display zoom setting by default on chromeos.

TBR=oshima@chromium.org

Bug: 835030
Change-Id: I48c2cfeed6b74bced55d3274414adfd2bdc283e9
Reviewed-on: https://chromium-review.googlesource.com/1025550Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553018}

BUG=827396
TEST=passes the bots

Change-Id: Ic88e877aecdd658c734182eb21f5849f0e2363fe
Reviewed-on: https://chromium-review.googlesource.com/987195Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553017}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=stgao@chromium.org

Bug: 825327
Change-Id: Id0af6c00456644d29aa8553a9bafab0a2d92bb4f
Reviewed-on: https://chromium-review.googlesource.com/1024479
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553016}

The actual call to sampling code was missing. Fix it.

R=fmeawad@chromium.org
BUG=835921

Change-Id: I6ecdfe078f5884d37975174c1ba696dcc7e2bbaf
Reviewed-on: https://chromium-review.googlesource.com/1024412
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553015}

Following bot results are included.
4914 4918 4920 4923 4924 4930 4934 4942 4944 4949

Includes rebaseline for the cursive and fancy font change in
CL:1010412.

1 lines were removed and 14 lines were deflaked by consecutive
results since 4889.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I34729c4f397bb45165747e382200f4e1acd9a5d6
Reviewed-on: https://chromium-review.googlesource.com/1023534
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553014}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cb62e48b5424..2c9a04604fa3

$ git log cb62e48b5..2c9a04604 --date=short --no-merges --format='%ad %ae %s'
2018-04-23 tandrii cq: start using LUCI downstream testers as an experiment.

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:830992


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I1775b9a33cf9eb0c60d88d3373c7a6abec9d9ed9
Reviewed-on: https://chromium-review.googlesource.com/1025407Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553013}

MIDIOutput starts using Performance::timeOrigin() as the time origin of
the delayed send request, which is wrong.
As timeOrigin() is a web-exposed, it's relative to a different timing to
TimeTicks value. We should use Performance::GetTimeOrigin() instread.

Bug: 835664
Change-Id: I413ed6387351d55a72150163d09cfa2eb66bca92
Reviewed-on: https://chromium-review.googlesource.com/1025450Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553012}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://afdo-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I8efc2e32697b5ce27d6df229fe042379b4473543
Reviewed-on: https://chromium-review.googlesource.com/1025275
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553011}

https://webrtc.googlesource.com/src.git/+log/e987f2b76567..b04e5cae08b8

$ git log e987f2b76..b04e5cae0 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:835281


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ibeab77c208c3cd82d21d932a61ae55fc97ea7c4d
Reviewed-on: https://chromium-review.googlesource.com/1025397Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553010}

Bug: 731978
Change-Id: I191bfcec4d626cc7c6174f8916edfedbbd1122dc
Reviewed-on: https://chromium-review.googlesource.com/1025272Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553009}

VisibleUnitsLine uses RenderedPosition instances without using
the bidi-related functionalities.

Since RenderedPosition is a wrapper of InlineBoxPosition with bidi
utility functions added, this patch changes VisibleUnitsLine to
use InlineBoxPosition directly for simplicity.

Bug: 822575
Change-Id: I158ddfb3dec1ead3f8b66e1255f3465f3f0353a2
Reviewed-on: https://chromium-review.googlesource.com/1024645Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553008}

TBR=dcheng@chromium.org
NOTRY=true

Bug: 836090
Change-Id: I156e7f460eed823d2dfeb4fbd5298c62eddbff4d
Reviewed-on: https://chromium-review.googlesource.com/1025591
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553007}

R=cmasso@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib29c988fd4fc82de8d61ece772c98501c9c0905b
Reviewed-on: https://chromium-review.googlesource.com/1025273Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553006}

PluginDocument uses a hard-coded background color; for a brief window
between the plugin document loading and the mime handler loading (and
replacing the background with its own content), that background color
is visible, producing a background color flash during plugin loading.

To avoid this, for plugins with fixed background colors (PDF and QO
[QuickOffice]), use their background color for the plugin document.

Bug: 819761
Change-Id: I38943d900073f7fb150476d9bf159a5e547804d1
Reviewed-on: https://chromium-review.googlesource.com/1023770Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553005}

* Use range-based for loops
* Use auto (sparingly) to replace ugly iterator naming
* using instead of typedef
* Trust RVO for returning temp vectors

Change-Id: Ieb7fc93592624149991364205e933b6612dd8a0d
Reviewed-on: https://chromium-review.googlesource.com/930140Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553004}

TBR=eyaich@chromium.org
NOTRY=true # PRESUBMIT testing

Bug: chromium:835295
Change-Id: I3f9af4e737fc3a9d7aa7f2bd47f84b1d3d5bad11
Reviewed-on: https://chromium-review.googlesource.com/1025263
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#553003}

There's no gaurantee on what thread OnData() is called from and the
way the thread checker is used ends up only checking OnData() instead
of OnData() and OnSetFormat() since it always detaches in OnSetFormat.

BUG=823403
TEST=none

Change-Id: I5665ca4a2b5ffa8472404102d88dcf37604d83d2
Reviewed-on: https://chromium-review.googlesource.com/1022472Reviewed-by: Henrik Grunell <grunell@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553002}

WebContentsImpl now tracks the last time it received an input event that
could be considered user interaction. When the browser process receives
a WebUI message that requires a user gesture, it checks the WebContents
hosting the WebUI to make sure that the user recently interacted with
it.

This also cleans up a few incidental bits of code:
- RenderWidgetHost no longer prefilters events before notifying the
  delegate. This exposed some broken event filtering, tracked at
  https://crbug.com/827659.
- Since the delegate method no longer prefilters input events,
  RenderWidgetHostDelegate::OnUserInteraction() is now named
  RenderWidgetHostDelegate::DidReceiveInputEvent().
- The IPC message used to pass WebUI messages from the renderer to the
  browser sends the source URL. However, this requires trusting the
  untrustworthy renderer to not lie about the URL. Instead, just use
  GetLastCommittedURL().

Bug: 823864
Change-Id: I687776c8c7f7f93f78c968dd432b1674d65629c0
Reviewed-on: https://chromium-review.googlesource.com/1023174
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553001}

ukm::UkmRecorder::GetNewSourceID may return negative ids.

Bug: 833028
Change-Id: If4f8c3668524baa791b9b3895f95f19d135664b3
Reviewed-on: https://chromium-review.googlesource.com/1020669
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553000}

ComputeInlineBoxPosition() handles after-BR positions by looking into
the first leaf child of the next line, which crashes if the next line
has no leaf child.

This patch changes the function to iteratively check the succeeding
lines until we find a line with leaf child, to stop the crash and make
the behavior saner.

Bug: 835779
Change-Id: Iafd04aaf467a8e53c92cb0d36ab291ff3627e67e
Reviewed-on: https://chromium-review.googlesource.com/1024799Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552999}

https://chromium.googlesource.com/chromium/llvm-project/compiler-rt/lib/fuzzer.git/+log/ba2c1cd6f87a..fda403cf93ec

$ git log ba2c1cd6f..fda403cf9 --date=short --no-merges --format='%ad %ae %s'
2018-04-23 morehouse [libFuzzer] Add feature to not use AFL's deferred forkserver.
2018-04-20 delcypher [LibFuzzer] Report when custom counters are available.
2018-04-20 delcypher [LibFuzzer] Try to unbreak the `FuzzerMutate.ShuffleBytes1` unit test.
2018-04-20 delcypher [LibFuzzer] Unbreak the `trace-malloc-unbalanced.test` when using Python 3.
2018-04-20 phosek [Fuzzer] Add a missing header in Fuchsia implementation
2018-04-19 phosek [Fuzzer] Make InterruptHandler non-blocking for Fuchsia
2018-04-13 phosek [Fuzzer] Avoid C++ compiler checks for fuzzer C++ library
2018-04-09 vitalybuka libFuzzer, OpenBSD support
2018-04-06 morehouse [libFuzzer] Print a correct error message when a directory can't be opened.
2018-03-20 mgrang Revert "[compiler-rt] Change std::sort to llvm::sort in response to r327219"
2018-03-20 mgrang [compiler-rt] Change std::sort to llvm::sort in response to r327219
2018-03-16 phosek [Fuzzer] Build the shared memory hooks for Fuchsia
2018-03-13 sylvestre fix some user facing typos / in the comments
2018-03-10 phosek [Fuzzer] When building for Fuchsia, add an explicit libc++ dependency
2018-03-07 phosek [Fuzzer] Avoid the unnecessary rebuild of the custom libc++
2018-02-22 morehouse [libFuzzer] Include TEMP_MAX_LEN in Fuzzer::PrintStats.
2018-02-13 morehouse [libFuzzer] Set -experimental_len_control=1000 as default.
2018-02-07 phosek [Fuzzer] Use Zircon's public API on Fuchsia
2018-02-01 hahnfeld [CMake] Remove -stdlib= which is unused when passing -nostdinc++
2018-01-30 phosek [fuzzer] Update and enable libFuzzer on Fuchsia
2018-01-30 morehouse [libFuzzer] Fix sizeof(ptr) bug.
2018-01-21 phosek Reland "[Fuzzer] Parametrize add_custom_libcxx"
2018-01-20 phosek Revert "[Fuzzer] Parametrize add_custom_libcxx"
2018-01-20 phosek [Fuzzer] Parametrize add_custom_libcxx
2018-01-17 phosek Reland "[libFuzzer] Support using libc++"
2018-01-17 phosek Revert "[libFuzzer] Support using libc++"
2018-01-17 phosek [libFuzzer] Support using libc++
2018-01-12 kamil Switch from Bourne shell to simply base shell to build libfuzzer
2018-01-12 kamil lib Fuzzer FreeBSD support
2017-12-20 dor1s [libfuzzer] Fix UB when calculating Log(0) in StackDepthStepFunction().

Created with:
  roll-dep src/third_party/libFuzzer/src

Change-Id: I91e676e96fe023ea6e6885488d0cd38b9ef8591a
Reviewed-on: https://chromium-review.googlesource.com/1025312Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552998}

This patch removes a DCHECK in CrostiniRegistryService::GetRegistration
that checks the id is a valid extension id. While app list ids are
currently expected to be extension ids, this is incidental and it's
better to not have more checks for this.

Change-Id: I46c252c047780cafd5be7eb8cd4296fe0d01989f
Reviewed-on: https://chromium-review.googlesource.com/1025331Reviewed-by: Nicholas Verne <nverne@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552997}

LayoutObjectFromPosition() is a hacky utility function to set
|RenderedPosition::layout_object_| when |inline_box_| is nullptr.

With previous refactoring, there is no usage of |layout_object_| when
|inline_box_| is nullptr, so we no longer need to set a non-null
|layout_object_| for null |inline_box_|.

Hence, this patch removes the call sites in RenderedPosition.

Note: the function cannot be removed because it is still indirectly
called by AX via LayoutObjectContainsPosition(). A follow-up patch
will move it to AX.

Bug: 822575
Change-Id: I720193c9926212153c56552115b5be9619ea20bc
Reviewed-on: https://chromium-review.googlesource.com/1025034Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552996}

Set the VK Aura Window to be transparent.
Otherwise WindowOcclusionTracker will set the Web Page Aura Window state
to be occluded and user can not see the committed input texts after VK
turns fullscreen. See conditions defined in VisibleWindowIsOpaque.

Bug: 826617
Change-Id: Idd8c525f205e608fe53fb59f85d302175b7a6246
Reviewed-on: https://chromium-review.googlesource.com/1023380
Commit-Queue: Jianzhou Feng <jzfeng@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552995}