- 12 Nov, 2020 1 commit
-
-
Anne Lim authored
This reverts commit cd50c565. Reason for revert: Relanding with tests removed, as discussed offline Original change's description: > Revert "Reland "[AF] Add account indication footer to AutofillSaveCardInfoBar"" > > This reverts commit 6e85e7a4. > > Reason for revert: crbug.com/1147678 > > Original change's description: > > Reland "[AF] Add account indication footer to AutofillSaveCardInfoBar" > > > > This is a reland of ba7d8814. Two changes were made: > > 1) A null pointer check is added to AutofillSaveCardInfoBar.java, and > > 2) In AutofillUpstreamTest.java, startMainActivityWithURL() is replaced with loadUrl(). > > > > Original change's description: > > > [AF] Add account indication footer to AutofillSaveCardInfoBar > > > > > > The footer is shown only to signed-in users have more than one account, and who do not sync. > > > > > > Screenshot with feature enabled in light mode: > > > https://screenshot.googleplex.com/ApVmkMVQakM6ai9 > > > > > > Screenshot with feature enabled in dark mode: > > > https://screenshot.googleplex.com/BJB2jUuGoH3T5jM > > > > > > Bug: 1135847, 1146186 > > > Change-Id: Ia2e031a48920e44e66503fab62f26ed87b8e1d92 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496184 > > > Commit-Queue: Anne Lim <annelim@google.com> > > > Reviewed-by: Marc Treib <treib@chromium.org> > > > Reviewed-by: Matthew Jones <mdjones@chromium.org> > > > Reviewed-by: Jared Saul <jsaul@google.com> > > > Cr-Commit-Position: refs/heads/master@{#823710} > > > > Bug: 1135847 > > Change-Id: Ifd9d514234a3af82330686373578f54ffd3427c8 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522219 > > Commit-Queue: Anne Lim <annelim@google.com> > > Reviewed-by: Matthew Jones <mdjones@chromium.org> > > Reviewed-by: Jared Saul <jsaul@google.com> > > Reviewed-by: Marc Treib <treib@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#825853} > > TBR=treib@chromium.org,mdjones@chromium.org,jsaul@google.com,bsazonov@chromium.org,annelim@google.com > > Change-Id: I09677d00d3c73763eb0c95ba56fee01bedbb149a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1135847, 1147678 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531084 > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826176} TBR=treib@chromium.org,mdjones@chromium.org,wychen@chromium.org,jsaul@google.com,bsazonov@chromium.org,annelim@google.com # Not skipping CQ checks because this is a reland. Bug: 1135847 Bug: 1147678 Change-Id: I0277fa6869b760612b960b47eca7ba6114efeef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533277Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Anne Lim <annelim@google.com> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#826550}
-
- 11 Nov, 2020 39 commits
-
-
Will Harris authored
A CFG performance bug in Windows previously prevented this from being enabled, but now the bots have all been updated to a more recent version that contains a fix, this exclusion can now be removed. BUG=950923,584575 Change-Id: I8e7dcef9135991c0e5daadc4cd99bc5a062ee290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530321Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#826549}
-
Tal Pressman authored
For now the listener map is only used for obtaining a RouteProvider (with a fallback to the process/thread). In the future it will also be used for routing incoming IPCs for the ASG's listeners. Bug: 1111231 Change-Id: I0a82f5681767b48751407ecbe8be7e7b6ecf506d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513958 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#826548}
-
Regan Hsu authored
* Turns strings translatable. * Adds illustrations. * Stylizations to match specs at [1]. Screenshots: * On opening dialog: https://screenshot.googleplex.com/3kHAcMC6HVcq6ZD * Connecting to phone: https://screenshot.googleplex.com/Zioip6YRZAxYVi2 * Success: https://screenshot.googleplex.com/4jasVrDUPLuXd3R * Connection lost: https://screenshot.googleplex.com/An5gNVetbDZas24 * Couldn't connect: https://screenshot.googleplex.com/75oxtiPcfRBtCCF [1] https://www.figma.com/file/HzmUezr2z1D2G63WJD9uwV/Phone-Hub-playbook?node-id=2176%3A15 Fixed: 1142971 Bug: 1106937 Change-Id: Id23fa7eb16d3d5897c244c67214c3b8d5f022503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523364 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#826547}
-
Melissa Zhang authored
This CL adds grey separators to SharesheetBubbleView to align with mocks. Screenshot included in bug. Bug: 1147724 Change-Id: I50e0a2eb058ddfe2c8c1ca1b4df079d4d1aba4ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532536 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#826546}
-
Tommy Li authored
In the new world where we are no longer uniquifying keywords, and instead tolerating multiple engines with the same keyword (we pretty much have to), it's more convenient for us to use an std::multimap to map keywords to engines rather than use std::map. This is to unblock a few ideas I have: - Currently, to detect conflicts between engines, we traverse through the whole list of TemplateURLs during Add() and Update(). During startup and Sync, when we are adding a bunch of these engines, that makes the whole process O(n^2). I'd like to use this multimap to remove those loops (in a future CL). - Although it SEEMS like we may no longer need to detect conflicts in the new world of tolerating conflicts, that's not true. We still want to remove replaceable conflicting engines, and so we still want to detect them. - I also hope the multimap will enable me to unify and simplify the currently complicated logic that does the removal of replaceable conflicting engines. - Finally, I think the multimap won't be expensive to retrieve the "best" engine for any given keyword, since the typical number of values we linearly go through per keyword is going to be one to three... definitely single digits. Multimaps don't sort on value. These things are going to be in followup CLs that are enabled by the multimap. See also: https://chromium-review.googlesource.com/c/chromium/src/+/2519775 Bug: 1022775 Change-Id: I631ea6c3cf442736273e23fcda15f72095dca28a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530801 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#826545}
-
Michael Bai authored
Rename EnabledOnFileMetrics to EnabledOnFileMetrics to match the finch configuration. Bug: 1076549 Change-Id: Icabaaec29c29966416bd405a21d9a8de17221bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529235 Commit-Queue: Michael Bai <michaelbai@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#826544}
-
Zhaoyang Li authored
The APIs were updated to use output path but the calls were not updated and causing folder not found warnings. Update the call to fix. Added a unit test to ensure correct argument is passed in. Bug: None Change-Id: I7e8405bdf4ac61d47e78a968a25587dac28e09e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529239Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#826543}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ff5d8700b3a7..b776a105e531 2020-11-11 jlavrova@google.com Some testing images in Google3 look slightly different with this change. Need to change them, too. 2020-11-11 brianosman@google.com GM to test (almost) all SkSL Angle/Trigonometric intrinsics 2020-11-11 reed@google.com make quickReject treat empty rects and paths the same 2020-11-11 herb@google.com remove unused getAdvance from SkScalerContext If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jlavrova@google.com Change-Id: If7cbfba2f36aba1b5f85fc6f65cd4eb54081e7ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533441Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826542}
-
Jinsuk Kim authored
This CL removes the dependency on ActivityTab{Provider/TabObserver} in toolbar/ package. They are replaced with a new CurrentTabObserver that works as a stop-gap solution. Bug: 1127732 Change-Id: I69e4272d38e26e70e62c31a6400859832dd70a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505297 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#826541}
-
Liquan (Max) Gu authored
Before the CL, the method "updateDetailsOnPaymentRequestUI" took "details", "rawTotal" and "rawLineItems". However, "rawTotal" and "rawLineItems" can be extracted from "details" directly. So this CL changes the method to provide only details. Also, these variables were provided by PaymentRequestSpec#getRawLineItems(), PaymentRequestSpec#getRawTotal(), and PaymentRequestSpec#getPaymentDetails() which are all expensive computation. This CL can help reducing the usage. Change-Id: I742e8493f1a3cb9b746882ff561badc656b4318d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533143 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#826540}
-
Kent Tamura authored
This is a reland of c0d846b5 Differences from the original CL: * The original CL had a wrong expectation file for Win7 because of win7-blink-rel bot outage. This CL removed it because 'Win' expectation is enough. Original change's description: > input[type=file]: Ignore the 'overflow' property > > For a historical reason, some form controls always clip the content, > and should ignore the 'overflow' property. File upload control NG had > a regression that it accepts overflow:visible. This CL disables it > again. The new behavior is compatible with Safari and Firefox. > > Bug: 1139629 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng_disabled > Change-Id: I6b0b5a715a2c859f195bbf2473ead67cd22bd14d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528812 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825813} Bug: 1139629 Change-Id: I9969d7263873ddf08ddcb45b3e1566e75e042924 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng_disabled Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532478 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#826539}
-
Harry Cutts authored
This allows pointing sticks to have different gesture properties than normal mice, though at the moment the same properties are set for both. See go/cros-pointing-stick-settings (Googlers only, sorry) for the design doc. Bug: 1114828 Test: check that pointing sticks and mice behave as normal Cq-Depend: chromium:2465650 Change-Id: If7837f530fbeb0a4029674d4c4c81e66630bbb0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486866 Commit-Queue: Harry Cutts <hcutts@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#826538}
-
ckitagawa authored
Add additional checks to make sure RFH is alive. Change-Id: I83fee50ebb88f342dfca8b8f4bb37f3a4f73901a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533521 Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#826537}
-
Leonard Grey authored
Bug: 1014639 Change-Id: Ifb76ff3ee8f4c31038933e356a62893caf23798c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533158 Commit-Queue: Leonard Grey <lgrey@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#826536}
-
Antonio Gomes authored
EXO tags the associated wayland/ShellSurface as being of AppType::LACROS. void SetLacrosAppType(aura::Window* window) { window->SetProperty(aura::client::kAppType, static_cast<int>(ash::AppType::LACROS)); } BUG=1113900 R=jamescook@chromium.org Change-Id: Id83fb6d851009068b0e080515d27c1a5c9d3038e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533334 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#826535}
-
Rakina Zata Amni authored
When a page is in the back-forward cache, we still want to handle network requests and response body loading. To support this, we need to return an unfreezable task runner for GetTaskRunnerForBodyLoader. Bug: 1137682 Change-Id: I68cdd66fd9f5afa2638fb77435c4cd087e697a8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525801 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#826534}
-
Jordan Taylor authored
This work is the first step in implementing upcoming spec change in: https://github.com/w3c/csswg-drafts/issues/4862 Converted AnimationTimeline::currentTime() to CSSNumberish Added AnimationTimeline::duration Bug: 1140602 Change-Id: I5c9b8b7130b91faae5f172493ba5f55d77b4bdd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476900 Commit-Queue: Jordan Taylor <jortaylo@microsoft.com> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#826533}
-
David Black authored
This feature flag allows previews of holding space items to be shown in the shelf tray. The user is able to enable/disable previews at runtime via context menu. This flag is exposed via chrome://flags and only has effect if the holding space feature is also enabled. Bug: 1142572 Change-Id: I5f93a0c1b2105a50434d30b3a615ebbf581cb41c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533028 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#826532}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dfff133590c2..d3f0d0cc3810 2020-11-11 treehugger-gerrit@google.com Merge "perfetto-ui: Fix selecting incomplete slice" 2020-11-11 fmayer@google.com Be consistent about java_heap_dump parameters. 2020-11-11 taylori@google.com Merge "perfetto-ui: Fix CSP" 2020-11-11 lalitm@google.com Merge "tp: symbolize function field in workqueue events" 2020-11-11 treehugger-gerrit@google.com Merge "processor: Replace FilterInto in ExportJson() for smaller binary size" 2020-11-11 taylori@google.com Merge "Roll trace processor" 2020-11-11 primiano@google.com Merge "ipc: fix crash when OnEnableTracingResponse() is rejected" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I5cdcb4ff93a8d69e451a9ae2f00f40298bd6eee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532982Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826531}
-
Robbie McElrath authored
This CL fixes a missing close() call in VariationsSeedLoader by using ScopedFD instead of a raw int when opening the seed file. Bug: 1138713 Change-Id: I547769c6385507cbe8fc876eb233dd0eacdb2d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519741Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#826530}
-
adoneria authored
This change propagates changes to waterfall created in crrev.com/c/2530896. Bug: 1136981 Change-Id: I69fb6fd9f8c980de9d7373ca02b6a41ce3bd7214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531065Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#826529}
-
Elad Alon authored
Bug: 1136942 Change-Id: Ia21e9ad0b35fb9e552137606801750fab35d6c65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532560Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#826528}
-
Leonid Baraz authored
This change is to match Keystore definition. Also, assigned a symbolic name to it, so further changes (if any) will only need to touch one line in the code. Bug: b:170054326 Change-Id: I8e33afb9252fa17acb527453b0ecc3535ee72318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533175 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#826527}
-
Max Curran authored
trigger decision with TranslateMetricsLogger More details on trigger decision: https://docs.google.com/document/d/11TJqU_YyJoxJE1huEqKECBa_OZ05O4WESXMJ2WeT4F0/edit?usp=sharing Bug: 1114868 Change-Id: Ic04f56bf39771564ecab162e60d1677b068f166f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520316Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Max Curran <curranmax@chromium.org> Cr-Commit-Position: refs/heads/master@{#826526}
-
Sergey Poromov authored
As Clipboard and OnScreen content restrictions are going to be launched in M88 (crbug/1105991, crbug/1105980), we are enabling the policy parsing by default. Bug: 1105991, 1105980 Change-Id: Ibe08f323e392101db320b0103f0a1b43822a84c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529095Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#826525}
-
Joel Hockey authored
In linux-chromeos, $HOME/Downloads rather than profile_path is used as the FilesApp MyFiles directory, and currently these files cannot be opened in a browser since they are not within the allowed paths. https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/chromeos/file_manager/path_util.cc;l=247-249;drc=c2dbbeb2f40590e1696e6c853f9e814404be6471 Since linux-chromeos is a testing-only system, we can allow any paths to be accessed which is helpful for testing such as the current drag and drop work I am doing. Bug: 1144138 Change-Id: I34253192270c982bd54c0d1bba33bd81e3532042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531073Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#826524}
-
Nina Satragno authored
When tapping escape on an authenticator dialog with an "interesting" OnCancel() behaviour (i.e. not immediately terminating the request), the dialog is closed without calling OnCancel(). This can leave requests hanging in the background. This patch handles the press of the escape key on the dialog's contents to call OnCancel() on the model instead. Fixed: 1145724 Change-Id: I019c614cd0b40f7384944c56eab0afe45d76c8b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530795 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#826523}
-
Nate Chapin authored
Bug: 1147612 Change-Id: If2ee105a33a04edca62b3777f93d963b04962d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523495 Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#826522}
-
Chris Sharp authored
Make this a required field for new main/bool policies. Since the item field isn't always copied over from main policies, also add a warning check that the policy descriptions describe the various cases. Add items to MediaRecommendationsEnabled and BlockThirdPartyCookies. BUG: 1139306 Change-Id: I2894cefa52437eddb51b75c58d320b878c8688ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522236Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#826521}
-
Dave Tapuska authored
Move the implementation of this method into the base class. BUG=1097816 Change-Id: I87fefb34168331ea7225fb3a7a6e9b4040e804b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533029Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#826520}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ib22b024d196853341d9e218e7ec999a6115a8386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533294Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826519}
-
Tim Song authored
BUG=1111153 Change-Id: I01bc854f83660cfb9237174673bc20a0f1ee54a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531813Reviewed-by:
Andre Le <leandre@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#826518}
-
Nate Chapin authored
Change-Id: I37961a93296714a9f378b6b963105673deb97dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528166 Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#826517}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3a4b8f58ae03..be42c94ff748 2020-11-11 yiorsi@gmail.com Fix CSS custom properties are blocked by underline If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1147750 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icce07c583d26997a942ddcfe4605957adc07105a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532880Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826516}
-
David Bienvenu authored
Bug: 1007805 Change-Id: I8e0136335d880ce1897d75e70a81dddd2e016d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522397Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#826515}
-
Nate Chapin authored
Change-Id: Ic9adc4348e51e831b6a4eba184a7438512774546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527776 Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#826514}
-
Jarryd authored
This change cleans up the flag, which expired in M85. Bug: 1129119 Change-Id: I964e7b2a44fc7c7386cbf589d83e6b78520b8e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446551Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#826513}
-
Luke Sorenson authored
Bug: 1147978 Test: Not necessary. Only updating two constants. Change-Id: Id2717ec8e56a0b6721798a0de1bfb9a799d4e172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533142Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Luke Sorenson <lasoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#826512}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I35c97e9ef668442cd4a8c1bffdaabd4d527e8c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533673Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826511}
-