1. 12 Nov, 2020 1 commit
    • Anne Lim's avatar
      Reland "Reland "[AF] Add account indication footer to AutofillSaveCardInfoBar"" · 1b70e5c2
      Anne Lim authored
      This reverts commit cd50c565.
      
      Reason for revert: Relanding with tests removed, as discussed offline
      
      Original change's description:
      > Revert "Reland "[AF] Add account indication footer to AutofillSaveCardInfoBar""
      >
      > This reverts commit 6e85e7a4.
      >
      > Reason for revert: crbug.com/1147678
      >
      > Original change's description:
      > > Reland "[AF] Add account indication footer to AutofillSaveCardInfoBar"
      > >
      > > This is a reland of ba7d8814. Two changes were made:
      > > 1) A null pointer check is added to AutofillSaveCardInfoBar.java, and
      > > 2) In AutofillUpstreamTest.java, startMainActivityWithURL() is replaced with loadUrl().
      > >
      > > Original change's description:
      > > > [AF] Add account indication footer to AutofillSaveCardInfoBar
      > > >
      > > > The footer is shown only to signed-in users have more than one account, and who do not sync.
      > > >
      > > > Screenshot with feature enabled in light mode:
      > > > https://screenshot.googleplex.com/ApVmkMVQakM6ai9
      > > >
      > > > Screenshot with feature enabled in dark mode:
      > > > https://screenshot.googleplex.com/BJB2jUuGoH3T5jM
      > > >
      > > > Bug: 1135847, 1146186
      > > > Change-Id: Ia2e031a48920e44e66503fab62f26ed87b8e1d92
      > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496184
      > > > Commit-Queue: Anne Lim <annelim@google.com>
      > > > Reviewed-by: Marc Treib <treib@chromium.org>
      > > > Reviewed-by: Matthew Jones <mdjones@chromium.org>
      > > > Reviewed-by: Jared Saul <jsaul@google.com>
      > > > Cr-Commit-Position: refs/heads/master@{#823710}
      > >
      > > Bug: 1135847
      > > Change-Id: Ifd9d514234a3af82330686373578f54ffd3427c8
      > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522219
      > > Commit-Queue: Anne Lim <annelim@google.com>
      > > Reviewed-by: Matthew Jones <mdjones@chromium.org>
      > > Reviewed-by: Jared Saul <jsaul@google.com>
      > > Reviewed-by: Marc Treib <treib@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#825853}
      >
      > TBR=treib@chromium.org,mdjones@chromium.org,jsaul@google.com,bsazonov@chromium.org,annelim@google.com
      >
      > Change-Id: I09677d00d3c73763eb0c95ba56fee01bedbb149a
      > No-Presubmit: true
      > No-Tree-Checks: true
      > No-Try: true
      > Bug: 1135847, 1147678
      > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531084
      > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
      > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#826176}
      
      TBR=treib@chromium.org,mdjones@chromium.org,wychen@chromium.org,jsaul@google.com,bsazonov@chromium.org,annelim@google.com
      
      # Not skipping CQ checks because this is a reland.
      
      Bug: 1135847
      Bug: 1147678
      Change-Id: I0277fa6869b760612b960b47eca7ba6114efeef0
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533277Reviewed-by: default avatarMarc Treib <treib@chromium.org>
      Reviewed-by: default avatarJared Saul <jsaul@google.com>
      Reviewed-by: default avatarMatthew Jones <mdjones@chromium.org>
      Reviewed-by: default avatarAnne Lim <annelim@google.com>
      Commit-Queue: Anne Lim <annelim@google.com>
      Cr-Commit-Position: refs/heads/master@{#826550}
      1b70e5c2
  2. 11 Nov, 2020 39 commits