- 11 Sep, 2018 6 commits
-
-
Aga Wronska authored
Manuall check that fingerprint UI shows during user sign in. Run wizard_controller_browser_tests. Bug: 882487 Test: Manuall check that fingerprint UI does not show in Demo Mode. Change-Id: I2b3e25f53b66194aca5a76285e8bbd4c6c7c2879 Reviewed-on: https://chromium-review.googlesource.com/1216808Reviewed-by:Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#590125}
-
Ted Choc authored
Uses that drop shadow for the navigation popup used for long press. Fixes a small bug where the "Show all history" item in the navigation popup was showing chrome://history because it was using the wrong constructor param ordering (added a test). BUG=800033 Change-Id: I84f60d0e7d67e86aa473b435ee63ededc5ee09f7 Reviewed-on: https://chromium-review.googlesource.com/1217362 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#590124}
-
Varun Khaneja authored
Corresponding changes in CLs at: - https://crrev.com/i/668738 - https://crrev.com/i/675169 Bug: 747428 Change-Id: I23b5bde4d134c86c26d18d21576bc822d0bc2ffb Reviewed-on: https://chromium-review.googlesource.com/1200410 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#590123}
-
Jialiu Lin authored
Add experiment to fieldtrial_testing_config that enables AdvancedProtectionStatus feature by default in tests. Bug: 866620 Change-Id: Ia8a85921b5cd5ee52ee49af3590ef36770fabe71 Reviewed-on: https://chromium-review.googlesource.com/1217349Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#590122}
-
Pavel Yatsuk authored
Current server doesn't not support this feature. Removing it from about:flags so that clients stop sending traffic to the endpoint. R=pnoland@chromium.org Change-Id: Iaac8ecbb874ba9ed5bf534c0e3726535bb1bca07 Reviewed-on: https://chromium-review.googlesource.com/1205803 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#590121}
-
Wez authored
Bug: 726484, 881333 Change-Id: I9b779a087d20dda8f3f0a58ffb70fbbea1e6e601 Reviewed-on: https://chromium-review.googlesource.com/1210382Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#590120}
-
- 10 Sep, 2018 34 commits
-
-
Yuly Novikov authored
This reverts commit 40a87fcf. Reason for revert: Breaks "compile" in Debug and "compile confirm no-op" in Release Original change's description: > [ozone/wayland] Refactor IME deps for ozone platform > > Refactor base/ime components and dependencies for ozone > plaform integration to avoid cyclic dependencies. > > - Groups ui/base/ime common types into their own GN component > (ime_types) to break a dependency cycle that ozone ime context > integration would cause on ChromeOS. > - Groups some of ui/base/ime/linux interfaces into their own GN > component (ime_linux) to break a dependency cycle that ozone > ime context integration would cause on ChromeOS. > - Move chromeos source files under is_chromeos flag to avoid > depending them when chromeos is not used, but ime is needed > (kudos to msisov@igalia.com). > > Bug: 791920 > Change-Id: I0b1668564dde22c6e2b05ee1323ebbe4a1343475 > Reviewed-on: https://chromium-review.googlesource.com/1193871 > Commit-Queue: Jani Hautakangas <jani.hautakangas@lge.com> > Reviewed-by: Shu Chen <shuchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590072} TBR=shuchen@chromium.org,yhanada@chromium.org,tonikitoo@igalia.com,msisov@igalia.com,jani.hautakangas@lge.com Change-Id: I5b032277b66ff9d5f6daca34425c5464736db77e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 791920 Reviewed-on: https://chromium-review.googlesource.com/1217849Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#590119}
-
Karan Bhatia authored
This fixes an existing TODO in url_pattern_index to implement case-insensitive matching. To do so: - Lower case the stored n grams. These n grams are used to find prospective matches for a particular url. - Modify URLPattern to handle case-insensitive matching. This involves lower-casing the url pattern and the url, before comparing them. BUG=767605 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I1377c216d61392c508280141d0d947a47a3ee494 Reviewed-on: https://chromium-review.googlesource.com/1212183Reviewed-by:Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#590118}
-
Kevin Strohbehn authored
Bug: 882643 Change-Id: I6681f064e8a21ac5557c4c2adb4633af248e0119 Reviewed-on: https://chromium-review.googlesource.com/1217756Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Kevin Strohbehn <ginko@google.com> Cr-Commit-Position: refs/heads/master@{#590117}
-
Jia Meng authored
This reverts commit a609f4ac. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reland "[On-device adaptive brightness] Implement an AlsReader to ambient light." > > > Original change's description: > > Revert "[On-device adaptive brightness] Implement an AlsReader to ambient light." > > > > This reverts commit ea692f36. > > > > Reason for revert: broke the linux-chromeos-dbg (https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/7744) > > > > Original change's description: > > > [On-device adaptive brightness] Implement an AlsReader to ambient light. > > > > > > > > > Bug: 881215 > > > Change-Id: I1cd5bf7ea517e426b54df1f4ebbb5a843b991dbe > > > Reviewed-on: https://chromium-review.googlesource.com/1209000 > > > Reviewed-by: Michael Martis <martis@chromium.org> > > > Reviewed-by: Dan Erat <derat@chromium.org> > > > Commit-Queue: Jia Meng <jiameng@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#589843} > > > > TBR=derat@chromium.org,jiameng@chromium.org,martis@chromium.org > > > > Change-Id: Id12029b7d3b46eaed672525fe0bcf96960ea143c > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 881215 > > Reviewed-on: https://chromium-review.googlesource.com/1215603 > > Reviewed-by: Jia Meng <jiameng@chromium.org> > > Commit-Queue: Jia Meng <jiameng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#589850} > > TBR=derat@chromium.org,jiameng@chromium.org,martis@chromium.org > > Change-Id: I8f170731509b2b23d469519fd45d5876175111d5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 881215 > Reviewed-on: https://chromium-review.googlesource.com/1217962 > Reviewed-by: Jia Meng <jiameng@chromium.org> > Commit-Queue: Jia Meng <jiameng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590115} TBR=derat@chromium.org,jiameng@chromium.org,martis@chromium.org Change-Id: Idc8436b6fcf1140e5c30912d4c0727e867c2cb9b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 881215 Reviewed-on: https://chromium-review.googlesource.com/1217982Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#590116}
-
Jia Meng authored
Original change's description: > Revert "[On-device adaptive brightness] Implement an AlsReader to ambient light." > > This reverts commit ea692f36. > > Reason for revert: broke the linux-chromeos-dbg (https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/7744) > > Original change's description: > > [On-device adaptive brightness] Implement an AlsReader to ambient light. > > > > > > Bug: 881215 > > Change-Id: I1cd5bf7ea517e426b54df1f4ebbb5a843b991dbe > > Reviewed-on: https://chromium-review.googlesource.com/1209000 > > Reviewed-by: Michael Martis <martis@chromium.org> > > Reviewed-by: Dan Erat <derat@chromium.org> > > Commit-Queue: Jia Meng <jiameng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#589843} > > TBR=derat@chromium.org,jiameng@chromium.org,martis@chromium.org > > Change-Id: Id12029b7d3b46eaed672525fe0bcf96960ea143c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 881215 > Reviewed-on: https://chromium-review.googlesource.com/1215603 > Reviewed-by: Jia Meng <jiameng@chromium.org> > Commit-Queue: Jia Meng <jiameng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589850} TBR=derat@chromium.org,jiameng@chromium.org,martis@chromium.org Change-Id: I8f170731509b2b23d469519fd45d5876175111d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 881215 Reviewed-on: https://chromium-review.googlesource.com/1217962Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#590115}
-
Tien-Ren Chen authored
This reverts commit bb7972c1. Reason for revert: crbug.com/882642 Original change's description: > [Blink/SPv175+] Change DCHECK(chunk clip escaped layer clip) to a DLOG > > The PaintChunkToCcLayer algorithm was originally designed for > SPv2 compositor, and it was expected the layerization algorithm should > never assign a chunk to a excessively clipped layer, thus the DCHECK. > > Later this algorithm was adopted in SPv175 to be used with the > SPv1 compositor. There is a known bug that in certain corner case we > can fail to escape clip, and the bug is difficult to fix in the > legacy architecture. The DCHECK is expected to be a "soft" one that > we have a fail-safe path to recover in a sane way. > > This CL converts the DCHECK to a DLOG in SPv1 mode, and it should still > trap in SPv2 mode. In addition, it reverts a workaround to a nullptr > bug in the fail-safe path, and add a test for the fail-safe. > > BUG=881788,853357 > > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I4606acf4885f3344bb45a901bb2e8e46dbcda49a > Reviewed-on: https://chromium-review.googlesource.com/1213952 > Reviewed-by: vmpstr <vmpstr@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Tien-Ren Chen <trchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590052} TBR=vmpstr@chromium.org,trchen@chromium.org,pdr@chromium.org Change-Id: I8f669d48422eb2cc3bb21db2d4866857710c3fbb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 881788, 853357 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1217712Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#590114}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/11bc3991530d..727453b25672 git log 11bc3991530d..727453b25672 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@727453b25672 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I9b4e94b73d0df09893bc6cea5cfb4afe37cb1f80 Reviewed-on: https://chromium-review.googlesource.com/1217805Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590113}
-
Dmitry Gozman authored
This reworks restricted sessions to have granular control over specific permissions: target discovery, browser target, etc. Target handler can now operate in autoAttachOnly mode which is used for extensions. Previously we just banned target handler from extension sessions, which broke OOPIF debugging for them. Bug: 870314 Change-Id: I0c3e8860aca547bb631e2a9615e58ac33465d88e Reviewed-on: https://chromium-review.googlesource.com/1212089Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#590112}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/03c80a36415d..b3b8b5883ce2 git log 03c80a36415d..b3b8b5883ce2 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 bsheedy@chromium.org Refactor quests to support instrumentation and browser tests Created with: gclient setdep -r src/third_party/catapult@b3b8b5883ce2 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:881017 TBR=sullivan@chromium.org Change-Id: Iafff24fea5d1f61b8e9c36f61cd1885cd34ade72 Reviewed-on: https://chromium-review.googlesource.com/1217802Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590111}
-
Varun Khaneja authored
GCL: http://cl/212327439 Bug: 74747428 Change-Id: Ia53e4451e9119bee0efd052c710563239de8ae2b Reviewed-on: https://chromium-review.googlesource.com/1217511Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#590110}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/52fd68762ae4..303e83e6b3c8 git log 52fd68762ae4..303e83e6b3c8 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 egdaniel@google.com Let unbudgeted, unique keyed resources stay in gpu ResourceCache. 2018-09-10 jvanverth@google.com Consolidate more shadow generation code. Created with: gclient setdep -r src/third_party/skia@303e83e6b3c8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I4e5859559b506dcfd52fba9471699079a76eff51 Reviewed-on: https://chromium-review.googlesource.com/1217482Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590109}
-
Dmitry Gozman authored
Bug: 775132 Change-Id: Ib31b7e9e5ef031abd47b4608bec5accb9181311e Reviewed-on: https://chromium-review.googlesource.com/1217592Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#590108}
-
Sky Malice authored
Bug: 866126 Change-Id: I4c300a57b7fbb9041419f9806eb0e656a22f1fbd Reviewed-on: https://chromium-review.googlesource.com/1197791 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#590107}
-
Gang Wu authored
Implement commit Journal operations for Journal storage on C++ side. Bug:879855 Change-Id: I8bf9d38571a4c83f7110be2d0043a8471171ba8c Reviewed-on: https://chromium-review.googlesource.com/1200943 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#590106}
-
liberato@chromium.org authored
When setting the visible rect properly, the coded size was inadvertently also changed to be the visible rect. This CL puts it back. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0b041b495bbc5a12095868ac0e6391826a445f77 Reviewed-on: https://chromium-review.googlesource.com/1217753Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#590105}
-
Dominic Mazzoni authored
This is a follow-up to http://crrev.com/c/1150824 - instead of having Document keep track of its AXContexts, let the garbage collector do the work for us. Each AXContext owns a Persistent<AXObjectCache>, and the associated Document has a WeakPersistent<AXObjectCache>. That way when the last AXContext goes out of scope, the AXObjectCache will be cleaned up automatically. This requires a few changes due to assumptions that AXObjectCache couldn't outlive its corresponding document. Bug: 867324 Change-Id: Id0479f59c9a9652b2cb321ed14369e8996748d8a Reviewed-on: https://chromium-review.googlesource.com/1162743 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#590104}
-
Lei Zhang authored
Also adjust FileEnumerator's build rules. Change-Id: I4a151782f35518f720296c1e5ed3e14910dccfc5 Reviewed-on: https://chromium-review.googlesource.com/1215045Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#590103}
-
Stephen Martinis authored
merge_results.py outputs a log line for every file that it 'merges'. Some of these files are only 'merging' one file. This makes the step log on buildbot be incredibly verbose, since there are thousands of artifacts generated by webkit_layout_tests. This CL changes the behavior to only log something if it's doing a non-trivial merge. 'Merges' which only merge one file aren't logged. Change-Id: I6e5bf7316a2f1ab41f8997582b12368c23456378 Reviewed-on: https://chromium-review.googlesource.com/1217594Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#590102}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d476f83e. With Chromium commits locally applied on WPT: d7762551 "Consistently use single quotes in Background Fetch WPTs." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24517 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: ericwilligers@chromium.org: external/wpt/css/motion meade@chromium.org: external/wpt/web-animations NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I4ad93e94f176e1809a9004d6cd2ebef266c703e2 Reviewed-on: https://chromium-review.googlesource.com/1217508 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#590101}
-
Kenneth Russell authored
This workaround appears to mostly be necessary for compositing and rasterization contexts, and has a performance cost when used with WebGL. Disable it there. Bug: 882317 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7dc89d11b2818f3af029d0dfb62d1a6e6fabfef3 Reviewed-on: https://chromium-review.googlesource.com/1217586Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#590100}
-
Daniel Rubery authored
In some cases, vec->at(i) was used as a more-readable alternative to (*vec)[i]. In others, it was used for const access to maps. at has questionable interactions with exceptions (see https://groups.google.com/a/chromium.org/forum/#!msg/cxx/6TDgM5g-NH4/NJSmyU01BgAJ), so I've added (*vec)[i] where possible, and bounds checked everywhere. Bug: 881604 Change-Id: Ia38ec235a8264a54ddc0dbe570c79e0227fe0f9e Reviewed-on: https://chromium-review.googlesource.com/1217104Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#590099}
-
Tatiana Buldina authored
Change-Id: I30d965d28b5b2713b141899e494b254f67a38df5 Reviewed-on: https://chromium-review.googlesource.com/1217759Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#590098}
-
Zach Stein authored
Enable on the command line by passing "--enable-features=WebRtcHideLocalIpsWithMdns" Check runtime setting with base::FeatureList::IsEnabled(features::kWebRtcHideLocalIpsWithMdns) Bug: chromium:875740 Change-Id: Ic8afd743d1b78da165cacb21ebc10837262af086 Reviewed-on: https://chromium-review.googlesource.com/1214328Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Zach Stein <zstein@google.com> Cr-Commit-Position: refs/heads/master@{#590097}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I559955e313363142b566f71a2a9e412f87ac9aeb Reviewed-on: https://chromium-review.googlesource.com/1217705 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590096}
-
Christian Biesinger authored
The number 8 for the initial capacity was picked at random. This seems to help especially with the float perf tests. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ie4217a459848e7269c791cf864f9aab163d7895d Reviewed-on: https://chromium-review.googlesource.com/1216813Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#590095}
-
Ben Pastene authored
We're planning on adding more types of VM tests, so this flag should come in handy in the future. Bug: 876587 Change-Id: I0db628151ae2016b4fd891fdbd5064ee41b1720f Reviewed-on: https://chromium-review.googlesource.com/1217073 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#590094}
-
Tom Anderson authored
This became necessary to build Chrome after [1] when building without the sysroot. [1] https://chromium.googlesource.com/chromium/src/+/297928530fc400a897f62fa98ccf4a5485990f22 BUG=879147 TBR=dpranke Change-Id: Iff2d59b247cd764f404f0beeaf232cc8dc8188aa Reviewed-on: https://chromium-review.googlesource.com/1214699Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#590093}
-
Artur Khachatryan authored
Test ChromeDriver.testTakeElementScreenshot fails on Android platforms. Disabling test for now. Bug: chromedriver:2579 Change-Id: I5ceb2cf4ba39cbfbeb37c851724e0b7ccd5a9925 Reviewed-on: https://chromium-review.googlesource.com/1217601Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#590092}
-
Scott Chen authored
This CL moves the extension-view-manager to a shared location to be used by other WebUIs. The immediate use case is for a new welcome page; see linked bug for details. Bug: 874146 Change-Id: Ieb168e61cf6ae02e04d624c92a131e9ec38fcdae Reviewed-on: https://chromium-review.googlesource.com/1157241Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#590091}
-
Moe Ahmadi authored
The root cause was that item of type ItemTypeSavedPasswords was not being properly formatter in |-collectionView:cellForItemAtIndexPath:| Also sets the detail text of the item at the time of creation, and not only when the preference changes. Bug: 882583 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I68a3d8660e520a99ec59b3fc48fb2f78dc59b5fe Reviewed-on: https://chromium-review.googlesource.com/1217503Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#590090}
-
Antonio Gomes authored
URLFetcher will stop working with advent of Network Service, and SimpleURLLoader is the replacement API for most clients. This CL migrates chromeos::chromeos::AttestationCAClient and the respective unittests away from URLFetcher. BUG=773295,879782 Change-Id: I9ccdad3a73108ad3e3e7ab4f148b93048433b3bd Reviewed-on: https://chromium-review.googlesource.com/1202223 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#590089}
-
Kai Ninomiya authored
Bug: 881144 Change-Id: Idc5292cecf9a3d4dbc101a9c44c47bd3db62dab6 Reviewed-on: https://chromium-review.googlesource.com/1208941Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#590088}
-
Quan Nguyen authored
Previously we prevented the login bubbles from overlapping into the shelf. This had some annoying side effects like obscuring the password field. This CL removes that part of the widget repositioning logic. A future CL will address the potential case of login bubbles going off screen on the bottom. Need to clarify the correct UX for this case. Bug: 880224, 875787 Change-Id: Iea42cd612e9b0c57516fdc9681843182fa8d268b Reviewed-on: https://chromium-review.googlesource.com/1217742Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#590087}
-
Min Chen authored
changes in this cl, - Do not change the shelf's visibility if drag on the shelf that has been set to always shown. - Gesture drag on the shelf should not change its auto-hide behavior. Since we can only change it through the context menu of shelf now. - Fixed the failed related ShelfLayoutManagerTest*. Bug: 880682, 881154 Change-Id: I2187c4636b1bbb5ca59149e33dbcbb8c664863b1 Reviewed-on: https://chromium-review.googlesource.com/1214049Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#590086}
-