GitLab

Revert of Improve fallback for Burmese with leading punctuation + spacing mark (patchset #3 id:30009 of https://codereview.chromium.org/2530153002/ )

Reason for revert:
This seems to be causing test failures for fast/text/international/text-spliced-font.html on https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/17622

Original issue's description:
> Improve fallback for Burmese with leading punctuation + spacing mark
>
> Issue 618178 describes an example where a Burmese text run starts with a
> leading punctuation character followed by a combining spacing mark. This
> grapheme cannot be shaped with the default font, since Times for example
> cannot display the combination of a left quote with a Burmese combining
> mark. Our fallback code attempts to find a fallback font based on the
> first character at the beginning of an extracted unshaped sub-run, which
> does not lead to finding a font suitable for Myanmar text in this case.
> So in a way it runs into a fallback trap, where no fallback hint helps
> to find the right fallback font and the whole run ends up as notdef
> glyphs.
>
> This CL attempts to resolve this by looking for a better fallback hint
> character, which is not script common or inherited, if such is
> available. This improves the situation for the Burmese text from the
> issue report.
>
> In addition, as a better fix we should give higher importance to the
> locale information in font fallback, filed as issue 668706.
>
> BUG=618178
> R=eae,kojii,behdad
>
> Committed: https://crrev.com/d9280a5e951415e1b2c6c7958adda19b731a99fa
> Cr-Commit-Position: refs/heads/master@{#434665}

TBR=behdad@chromium.org,eae@chromium.org,kojii@chromium.org,drott@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=618178

Review-Url: https://codereview.chromium.org/2532253002
Cr-Commit-Position: refs/heads/master@{#434719}

This patch fixes an issue where the first enumeration of USB devices on
Linux would only return a single device and observers would not be
notified of additional devices. This was because the logic to determine
if enumeration callbacks should be called was checking only that all
previously seen devices (of which there was only one at that point) were
ready and not that the sysfs tree had been completely walked.

BUG=662486

Review-Url: https://codereview.chromium.org/2523403002
Cr-Commit-Position: refs/heads/master@{#434718}

BUG=666450

Review-Url: https://codereview.chromium.org/2535773004
Cr-Commit-Position: refs/heads/master@{#434717}

These are from two recent CLs:
https://codereview.chromium.org/2463953002
https://codereview.chromium.org/2494553002

Note: This CL is a test of the WPT export process. Do not make changes
in LayoutTests/imported/wpt/ without coordination or changes may be
lost.

BUG=657117

Review-Url: https://codereview.chromium.org/2509983007
Cr-Commit-Position: refs/heads/master@{#434716}

StreamTextureHost is always created with a valid |route_id|, and it also
does not handle OnChannelError().

This change removes the useless |route_id| checks, sets |channel_| to
nullptr when OnChannelError() is called, and adds appropriate |channel_|
null checks.

This change also removes raw pointers from StreamTextureProxy, to fix
style conformance and StreamTextureHost ownership clearer.

BUG=667162

Review-Url: https://codereview.chromium.org/2530443002
Cr-Commit-Position: refs/heads/master@{#434715}

Usually custom tabs force-load URLs or redirects to URLs that can be
handled by apps inside custom tabs. For instant-apps enabled clients
override the default behaviour and launch the instant app, if possible.

BUG=659301

Review-Url: https://codereview.chromium.org/2532223002
Cr-Commit-Position: refs/heads/master@{#434714}

Neither dvh@ nor grv@ still work on Chromium.

BUG=None

Review-Url: https://codereview.chromium.org/2533033002
Cr-Commit-Position: refs/heads/master@{#434713}

Currently, when we create the Physical Web data source, we do not
populate it with any initial data, which can lead to onLosts occuring
when there has not even been an onFound.  This change call onFound for
currently known URLs when first creating the data source.

BUG=667754

Review-Url: https://codereview.chromium.org/2521333002
Cr-Commit-Position: refs/heads/master@{#434712}

BUG=666630

Review-Url: https://codereview.chromium.org/2517693002
Cr-Commit-Position: refs/heads/master@{#434711}

This patch fixes spellcheck caching in the following case:
1. paragraph is edited by removing text from the back and
2. paragraph does not contain misspelled words.

Currently this case results in a cache miss and consequently
spellcheck requests being sent to the spellchecking service
while completely unnecessary. This fix applies to all
platforms.

This patch also adds a few unit tests for the relevant
caching specific behavior.

BUG=664247,629609

Review-Url: https://codereview.chromium.org/2494123002
Cr-Commit-Position: refs/heads/master@{#434710}

Also fixed and reenabled the fullscreen test in BrowserWindowControllerBrowserTest

BUG=599119, 643418

Review-Url: https://codereview.chromium.org/2516803002
Cr-Commit-Position: refs/heads/master@{#434709}

Remove superfluous closeUI call from onDismiss, this is
already done in disconnectFromClientWithDebugMessage.

BUG=587995

Review-Url: https://codereview.chromium.org/2536783002
Cr-Commit-Position: refs/heads/master@{#434708}

Move struct VideoFrameInfo from content/common/video_capture.mojom to
media/capture/mojo/video_capture_types.mojom. This will allow us to use the
struct in code that transports frames through the browser-process. This will,
in turn, allow us to (in a later CL) switch between the existing in-process
implementation and the new Mojo service.

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL1.9.6

BUG=584797
TEST=video_capture_unittests, content_unittests, capture_unittests

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing

Review-Url: https://codereview.chromium.org/2524103002
Cr-Commit-Position: refs/heads/master@{#434707}

Remove the restriction that, under certain conditions, we require
the protocol of an auto-created custom search engine be HTTP.  The
condition has no connection with a need for privacy.  There is no
problem with creating custom search engines for secure sites.  In
fact, we should be encouraging more sites to be secure, not penalizing
those that do so by making it more difficult for them to create a
custom search engine.

BUG=642848
TEST=amazon.com now gets a custom search engine created

Review-Url: https://codereview.chromium.org/2505933005
Cr-Commit-Position: refs/heads/master@{#434706}

Revert of ImageCapture: move image_capture.mojom from media/mojo/interfaces/ to media/capture/mojo/ (patchset #2 id:40001 of https://codereview.chromium.org/2526953002/ )

Reason for revert:
imagecapture layout tests started failing in https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/40056

Original issue's description:
> ImageCapture: move image_capture.mojom to media/capture/mojo/
>
> This CL moves image_capture.mojom from media/mojo/interfaces/ to
> media/capture/mojo/ where it belongs logically speaking, and
> updates BUILD.gns and include paths.
>
> image_capture.mojom was in media/mojo/interfaces because
> when it landed, media/capture/mojo was not existing.
>
> BUG=518807
> TEST=No code touched, if compile passes, it works
> (but there's also content_browsertests).
>
> TBR=xhwang@chromium.org for the removal in media/mojo/interfaces/BUILD.gn
>
> Committed: https://crrev.com/d7c801bb7ed0393d1634e547a696ced5040bc93c
> Cr-Commit-Position: refs/heads/master@{#434675}

TBR=mkwst@chromium.org,chfremer@chromium.org,jochen@chromium.org,tsepez@chromium.org,mcasas@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=518807

Review-Url: https://codereview.chromium.org/2537573002
Cr-Commit-Position: refs/heads/master@{#434705}

Revert of Disable dromaeo.jslibmodifyjquery on Windows (patchset #1 id:1 of https://codereview.chromium.org/2529673003/ )

Reason for revert:
Re-enable tests as we fixed a problem with wrapper tracing.

Original issue's description:
> Disable dromaeo.jslibmodifyjquery on Windows
>
> R=sullivan@chromium.org
> BUG=668164
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
>
> Committed: https://crrev.com/98679f8f94d5beb4b7a0715edef85f8ba250f34b
> Cr-Commit-Position: refs/heads/master@{#434268}

TBR=sullivan@chromium.org,fmeawad@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=668164
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2532653002
Cr-Commit-Position: refs/heads/master@{#434704}

https://pdfium.googlesource.com/pdfium.git/+log/0354ccf37f05..e421327725da

$ git log 0354ccf37..e42132772 --date=short --no-merges --format='%ad %ae %s'
2016-11-28 npm Replace ASSERT with error return in bmp_read_header

BUG=659497

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2530373004
Cr-Commit-Position: refs/heads/master@{#434703}

So far, passing a function or function pointer to a check such as DCHECK_EQ
would cause the values to be implicitly converted to bool, resulting in a
confusing message like this

    Check failed: x == y (1 vs. 1)

instead of

    Check failed: x == y (0x779410 vs. 0x778fe0)

Add a specific overload for functions and function pointers that explicitly
cast them to const void* to have them call the right operator<< overload.

This fixes warnings on both new GCC versions (-Waddress complains that passing a function or function pointer to operator<< would always become '1') and clang on Windows (see https://bugs.chromium.org/p/chromium/issues/detail?id=550065#c12).

BUG=550065
R=danakj@chromium.org,thakis@chromium.org,jbroman@chromium.org

Review-Url: https://codereview.chromium.org/2515283002
Cr-Commit-Position: refs/heads/master@{#434702}

BUG=630464

Review-Url: https://codereview.chromium.org/2502153002
Cr-Commit-Position: refs/heads/master@{#434701}

BUG=661676

Review-Url: https://codereview.chromium.org/2528793002
Cr-Commit-Position: refs/heads/master@{#434700}

Because of a missing 's' the generated client API was always considered out of
date.

BUG=669077

Review-Url: https://codereview.chromium.org/2531363002
Cr-Commit-Position: refs/heads/master@{#434699}

Add a watch list definition for Generic Sensor API [1] implementation updates.

[1] ED specification: https://w3c.github.io/sensors/

NOTRY=True

Review-Url: https://codereview.chromium.org/2526253002
Cr-Commit-Position: refs/heads/master@{#434698}

BUG=542537

Review-Url: https://codereview.chromium.org/2536513002
Cr-Commit-Position: refs/heads/master@{#434697}

Chrome currently leaves the alert around which causes subsequent commands to fail.

https://buganizer.corp.google.com/u/0/issues/6507465#comment12
BUG=chromedriver:877

Review-Url: https://codereview.chromium.org/1827003004
Cr-Commit-Position: refs/heads/master@{#434696}

BUG=

Review-Url: https://codereview.chromium.org/2530373003
Cr-Commit-Position: refs/heads/master@{#434695}

The code is unused, will likely not come back in the same form, and
forces needless verbosity in forthcoming CLs.

BUG=631966

Review-Url: https://codereview.chromium.org/2532933002
Cr-Commit-Position: refs/heads/master@{#434694}

Chrome on iOS uses the deprecated User Action "MobileContextMenu..." as part of
the upstreaming, it should use the new histogram "ContextMenuOption".
This CL adds the histograms needed by Chrome on iOS.

BUG=669028

Review-Url: https://codereview.chromium.org/2537453002
Cr-Commit-Position: refs/heads/master@{#434693}

Create a ChromeTestExtensionLoader to load extensions during tests.
This class is designed to be used across browser tests and unit tests,
making it a (mostly) solution to needing to re-code the same
implementation in various different test classes, as well as an
alternative to the double-inheritance we sometimes see in order to get
extension-loading helper methods in addition to some other test
infrastructure.

The main class includes options to modify the behavior according to most
common flags set by existing (unit|browser) tests, such as error
handling, packing, creation flags, permissions, etc.

Additionally, hook the class up to the existing ExtensionBrowserTest
(browser test) and ExtensionServiceTestWithInstall (unit test) as a
proof of concept that it works in both unit and browser tests. Going
forward, we should continue to a) expand the test loader and b) replace
current duplicative code.

BUG=667587

Review-Url: https://codereview.chromium.org/2524553002
Cr-Commit-Position: refs/heads/master@{#434692}

Getting the underlying WebsiteSetting to find whether reading/setting
cookies is allowed is fairly expensive. The current cookie API requires
retrieving these settings twice if we want to know both values.

This patch updates the API to allow for querying reading and setting
policies with one call to GetWebsiteSettings. This is used in
net::NetworkDelegate::CanEnablePrivacyMode, which went from taking 18%
of the CPU time in net::URLRequestHttpJob::Start, to 12% after this
patch (Linux perf results).

BUG=664174

Review-Url: https://codereview.chromium.org/2502743003
Cr-Commit-Position: refs/heads/master@{#434691}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e9b2ab39..bced9de7

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2532983003
Cr-Commit-Position: refs/heads/master@{#434690}

The SHUTDOWN_TIMEBOMB_ARM execution phase was not set on the quick exit path
(SessionEnding).

BUG=668542

Review-Url: https://codereview.chromium.org/2527373003
Cr-Commit-Position: refs/heads/master@{#434689}

ExtensionHostMsg_Request_Params includes a "source_tab_id", but this
shouldn't be necessary. The browser can determine the tab id from which
RFH sent the request. Remove the property.

BUG=667584

Review-Url: https://codereview.chromium.org/2522763005
Cr-Commit-Position: refs/heads/master@{#434688}

* Since all tests use a TokenBindingSSLConfigService, create one in
  SetUp(), instead of creating a TLS10SSLConfigService that is destroyed
  at the beginning of each test.
* Remove unused classes TLS1?SSLConfigService.
* Remove unused GetServerSSLConfig().
* In HttpNetworkTransaction, defriend HttpNetworkTransactionSSLTest and
  test cases that do not access private member.
* git cl format.

Review-Url: https://codereview.chromium.org/2532153002
Cr-Commit-Position: refs/heads/master@{#434687}

BUG=

Review-Url: https://codereview.chromium.org/2526993002
Cr-Commit-Position: refs/heads/master@{#434686}

Layout test expected results are changed for the following reasons:

- Some exception messages are formatted slightly differently
  (e.g. to convey the type of the object which failed to be cloned).

- blink::ScriptValueSerializer emitted frequent "object count validation"
  tags (the most frequently seen is 3f00) which are not required by
  either deserializer, but the new one does not.

- Excessive depth throws a RangeError, like JSON.stringify and other
  functions that internally reach excessive depth (this is consistent
  with Safari, and similar to how Edge also throws the same exception as
  for an ordinary stack overflow in script).

- Certain large numbers are encoded differently; specifically, V8 now
  chooses between signed-int and double representations depending on
  whether the value has a small-integer (SMI) encoding in memory (this
  value range varies by CPU architecture). The old implementation tried
  to fit in a signed-int, then tried to fit in an unsigned-int, and only
  used double representation if that failed. Both implementations can
  read all representations, so this is a compatible change. Tests that
  are sensitive to variation by CPU architecture are commented out; there
  are unit tests that ensure that this serialization works correctly.

BUG=148757

Review-Url: https://codereview.chromium.org/2517813002
Cr-Commit-Position: refs/heads/master@{#434685}

Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived
IPC message. With this series of CLs, it will be dispatched when a resource
loading is completed. This is needed to use mojo data pipe for transferring
the response body.

 - 1/3: https://codereview.chromium.org/2514713002/
 - 2/3: https://codereview.chromium.org/2510333002/
 - 3/3: https://codereview.chromium.org/2506363005/

Design doc: https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaGFQ/edit#

This CL drops encoded_body_length field from ResourceMsg_DataReceived and
ResourceMsg_InlinedDataChunkReceived. This CL doesn't change the behavior.

BUG=666216

Review-Url: https://codereview.chromium.org/2506363005
Cr-Commit-Position: refs/heads/master@{#434684}

To enable OOPIF and Top Document Isolation for Android, we need to track
the text input state from multiple RenderWidgetHosts. To this end, the
TextInputStateChanged updates should be routed through TextInputManager
which keeps a map of all RenderWidgetHost(View) and their corresponding
TextInputState.

This CL will also enable some site-per-process tests on android.

BUG=578168,602723

Review-Url: https://codereview.chromium.org/2354793003
Cr-Commit-Position: refs/heads/master@{#434683}

We defined a set of sub-metrics to measure the latencies inside
Event.Latency.TouchToScrollUpdateSwapBegin to help us better understand
the time spent on each stage during scroll. Now we will add the same set
of sub-metrics to Event.Latency.TouchToFirstScrollUpdateSwapBegin.

The details are in this doc:
https://docs.google.com/document/d/1EPKT652e2PcO1ysA7LQosGyyr1xmxbtiiiivNU3lnpQ/edit#heading=h.r6af7ldx7kcw.

BUG=616482

Review-Url: https://codereview.chromium.org/2268163002
Cr-Commit-Position: refs/heads/master@{#434682}

MusGpuMemoryBufferManager needs to be used by both the window server (to
service gpu memory requests from clients), and the gpu process (for the
display compositor). So move it into a service_common that various server
components can use.

BUG=none

Review-Url: https://codereview.chromium.org/2534663002
Cr-Commit-Position: refs/heads/master@{#434681}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/76180b6b4e6d..6d2cfc95eb2f

$ git log 76180b6b4..6d2cfc95e --date=short --no-merges --format='%ad %ae %s'
2016-11-28 sullivan Update toplevel projects: remove perf_insights and add systrace
2016-11-28 hjd [dashboard] Fix use of () => {}

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2528353003
Cr-Commit-Position: refs/heads/master@{#434680}