- 22 Aug, 2019 40 commits
-
-
Marc Treib authored
This reverts commit 99e62c7f. Reason for reland: Not actually the culprit for PrintBrowserTests flakiness Original change's description: > Revert "Remove print document race condition using synchonous message" > > This reverts commit 2ff72648. > > Reason for revert: Suspected of making various PrintBrowserTests flaky, see crbug.com/996185 > > Original change's description: > > Remove print document race condition using synchonous message > > > > JavaScript window.print() requests have been returning back to the > > renderer process before the print has actually completed. When the > > print preview is disabled it is easier to expose a race condition > > between serving the print logic and whatever comes next in the > > JavaScript. > > > > If the script has a popup window to be printed, which has > > window.close() immediately after the window.print(), then the document > > to be printed has its destruction racing against being printed - and > > will typically lose that race, resulting in a lost or empty print job. > > > > Resolve by ensuring that the renderer process does not proceed past > > window.print() until the DidPrintDocument message is sufficiently > > completed. Making this message synchonous achieves this effect. > > > > This means that the renderer process will be blocked for all sites > > which it serves for slightly longer than it already does. [1] > > > > [1] https://www.chromium.org/developers/design-documents/printing > > > > Bug: 974480 > > Change-Id: I3ef08899e1792cc291aa8dd3d740da095e2c73bc > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700275 > > Reviewed-by: Shimi Zhang <ctzsm@chromium.org> > > Reviewed-by: Tao Bai <michaelbai@chromium.org> > > Reviewed-by: Tom Sepez <tsepez@chromium.org> > > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > > Reviewed-by: Lei Zhang <thestig@chromium.org> > > Commit-Queue: Alan Screen <awscreen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#688096} > > TBR=michaelbai@chromium.org,thestig@chromium.org,caseq@chromium.org,tsepez@chromium.org,ctzsm@chromium.org,awscreen@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 974480, 996185 > Change-Id: I3ae34235d1bbdb98619a157a451e94e6b0e1cf48 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760795 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689415} TBR=michaelbai@chromium.org,thestig@chromium.org,caseq@chromium.org,tsepez@chromium.org,treib@chromium.org,ctzsm@chromium.org,awscreen@chromium.org Change-Id: Ifc9ba8829440672fa83fdd1aa2ed45d4ede71e4f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 974480, 996185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764196Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#689441}
-
Fred Mello authored
Related to: https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/1685369 https://chromium-review.googlesource.com/c/chromium/src/+/1762699 Bug: 995940 Change-Id: I3cc34fad155fbe96fcedc1ca7166d5b3adceb90b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764800Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Fred Mello <fredmello@chromium.org> Cr-Commit-Position: refs/heads/master@{#689440}
-
Tanmoy Mollik authored
DriveServiceInterface and its subclasses should use CoreAccountId instead of std::string to denote account_id because they get this account_id from identity_manager. This should not be a std::string as that could lead to confusion in using this as gaia_id or email. Bug: 959157 Change-Id: I6cb20917504f4aeca6fae095df1f018811b17e09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736668Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
-
Ben Kirchman authored
Fake cronet needs to keep the FakeCronetProvider class name so it can be specified in the test resource files. Bug: 669707 Change-Id: I3137bbb1eb78a7c56f4b0865b2a107b34cd43fda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763230Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Benjamin Kirchman <kirchman@google.com> Cr-Commit-Position: refs/heads/master@{#689438}
-
Marc Treib authored
TBR=khushalsagar@chromium.org Bug: 995142, 900706 Change-Id: Ibd84ef39365710816ec301b8865de83816805e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760797Reviewed-by:
-
Antonio Gomes authored
Now that UserMediaClient is GC'ed (see [1]), this CL moves UserMediaProcessor to be managed by Oilpan. [1] crrev.com/c/1757492 BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: Icfe0579b32c98283f1a340cb86dd7c95f8de3b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758604 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#689436}
-
Rafał Godlewski authored
Leak dialog has a cancel button with label "Close", but functions should have "Cancel" in the names since it is really a cancel button in dialog delegate. Change-Id: I77f43a4833582f83cc017d91c402bd93164bf958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758241Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Rafał Godlewski <rgod@google.com> Cr-Commit-Position: refs/heads/master@{#689435}
-
Mike West authored
This isn't a security bug but a race condition. The `data:` frame is inaccessable from the `javascript:` frame (as the former has an opaque origin). The test passes if the second frame loads first (as the first frame will still be at the initial `about:blank`), and fails if the first frame loads first. This patch loads `about:blank` in the first frame. Problem solved. Bug: 993238 Change-Id: Ibd10bcf3756816fc967f64c1c78d2290cc0898b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765469 Commit-Queue: Mike West <mkwst@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Mike West <mkwst@chromium.org> Reviewed-by:
-
Antonio Gomes authored
This is CL changes the ownership model of UserMediaClient, making it GC-able by Oilpan It also: - Removes the associated WeakPtrFactory declaration in user_media_client.h changing the uses of WTF::Unretained by WrapWeakPersistent. - Removes the body of ~UserMediaClient, since the object is now GC-ed. - Rework the callbacks passed to LocalFrame and UserMediaProcessor, to overcome the limitation that Callbacks can not be bound to a weak reference, if they return non-value. BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I2cc51660b6007fdc929d50f5508659aac83e3697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757492 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Dave Tapuska authored
The mojo interface will be used to communicate the new lifecycle state of the worker. This will be useful for filtering out frozen state for dedicated workers in the client matching APIs. BUG=968417,907125 Change-Id: Ic9f32a83ea6fd8e88dd59c63b8e2966d86ca6bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756623Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#689432}
-
Hiroki Nakagawa authored
This CL merges blink::features::kOffMainThreadDedicatedWorkerScriptFetch to blink::features::kPlzDedicatedWorker. PlzDedicatedWorker depends on OffMainThreadDedicatedWorkerScriptFetch. Initially, we planned to enable OffMainThreadDedicatedWorkerScriptFetch first and then PlzDedicatedWorker. However, it turned out that OffMainThreadDedicatedWorkerScriptFetch breaks some tests and PlzDedicatedWorker fixes them. Therefore, we decided to enable both of them at once. As a result, we no longer have to keep both the flags. Bug: 835717, 906991 Change-Id: I9821abd350d88949279456499376406002a28840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763525 Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d65c05cb1aa9..d20e6d40df1f Created with: gclient setdep -r src-internal@d20e6d40df1f The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ic6248aaa448b186343dc53ec92e98ae5755d9813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764359Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689430}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 812bd585. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I420d3478f3ec40b7ee8688753d7e8a54717e3ae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765330Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689429}
-
Mike West authored
After [1], we're stripping `Sec-Fetch-*` headers from non-secure transport. This is lovely! Except insofar as it also strips the headers from secure redirect targets. Which is a problem, as it gives attackers the option of laundering their requests through HTTP to strip the headers. This patch removes the secure transport restriction while we figure out a cleaner way of removing the headers on a per-hop basis. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1647354 Bug: 995745, 971938, 964053 Change-Id: Icec4e685902b7be2983bb81b7289ac9b45467782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762079 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Eric Lawrence [MSFT] <ericlaw@microsoft.com> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/224c69d52748..a2dae38ee772 git log 224c69d52748..a2dae38ee772 --date=short --no-merges --format='%ad %ae %s' 2019-08-22 nisse@webrtc.org Revert "Reland "Delete mac_utils.h and mac_utils.cc"" 2019-08-22 chxg@google.com Add helper classes to send and receive abs-capture-time extensions. 2019-08-22 jonasolsson@webrtc.org Remove unused framerate parameter from simulcast bitrate allocator. 2019-08-22 nisse@webrtc.org Reland "Delete mac_utils.h and mac_utils.cc" Created with: gclient setdep -r src/third_party/webrtc@a2dae38ee772 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None Change-Id: Id66c3da8c217369c5cc2d4fc0a8f8afacb4e2c3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764939Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689427}
-
Lowell Manners authored
If a subframe does audio capture, it should be handled the same as if audo capture was done from the top level frame. Bug: 989379 Change-Id: I31f751c7c96aa202ced4d78d8f396f3e36bd3425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760295 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#689426}
-
Rafał Godlewski authored
Bug: 986317 Change-Id: I9476047656d127450faecbb0e927999d61c2ad0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764138Reviewed-by:
-
Jérôme Lebel authored
+ Adding comments. + Removing ColdStateTabSwitcher test (exactly the same than ColdStateConfigureSigninPromoView). + Renaming WarmStateConfigureSigninPromoViewWithoutImage into WarmStateConfigureSigninPromoView. + Adding ColdStateConfigureSigninPromoViewFromSettings (to test the close button). + Cleaning up the code. Related to: + crrev.com/c/1764151 + crrev.com/c/1718370 Change-Id: I4581537ad8bbad38c83faba8cbaa977faa6dea36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760793 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#689424}
-
W. James MacLean authored
In order to continue with the launch process for this feature, we need it to be enabled by default on tip-of-tree. Bug: 659750 Change-Id: Ia55037944bde87793a6f1eb4fd6b83a5b2b362d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764433 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#689423}
-
Javier Ernesto Flores Robles authored
Moving away from Apple's default colors to Chrome's specific ones. Bug: 976671 Change-Id: Iba1e410f8453d3abd26851febc17f56ed4122baa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763757 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#689422}
-
Yutaka Hirano authored
Tracing suggests WTF::Partitions::FastFree is slow. On my workstation deallocating 260 segments takes more than 100us. This CL stops using SharedBuffer and introduces WebSocketMessageChunkAccumulator which pools segments. A WebSocketMessageChunkAccumulator will free segments which were not used in the last 100ms. This improves [1] in my environment. Without the change: 390MB/s With the change : 416MB/s With --websocket-renderer-receive-quota-max=128000 --websocket-read-buffer-size=32000, the result is Without the change: 494MB/s With the change : 563MB/s 1: third_party/blink/perf_tests/websocket/receive-arraybuffer-1MBx100.html Bug: 865001 Change-Id: Id87134e766b662816249b4a08e24cf844bb4a88f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725351 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#689421}
-
Andy Paicu authored
It's been over a year since modal permission prompts have been enabled by default. The usage is now very low so it's time to removed them. https://uma.googleplex.com/histograms?sid=19aaae5bcd78f725505eebc7e91172ce Usage in stable less than 0.0003% Bug: 935900 Change-Id: Ifecfacec485fc1a18fccbf7d219209d3727946b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757939Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#689420}
-
Marc Treib authored
http/tests/devtools/elements/styles-3/styles-computed-trace.js http/tests/devtools/elements/styles-3/styles-add-new-rule-colon.js http/tests/devtools/elements/styles-2/force-pseudo-state.js TBR=luoe@chromium.org Bug: 994008, 994034, 994027 Change-Id: I47a3cb1c8c6d3355d28e54a56b05a2eca6207f6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760796Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ccbb1967..152e05a4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I65d5f4cd6a8c638f6156ba89068eb0d910549a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765329Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689418}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/60d1f774d1f3..d65c05cb1aa9 Created with: gclient setdep -r src-internal@d65c05cb1aa9 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I9597cb99247abe3362cf18c31285fd663cde351f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764937Reviewed-by:
-
Miyoung Shin authored
This CL converts ServiceWorkerHostAssociatedPtr, ServiceWorkerHostAssociatedPtrInfo, ServiceWorkerPtr and ServiceWorkerRequest in content and blink to new Mojo types, and uses pending_receiver<ServiceWorker> in embedded_worker.mojom and pending_associated_remote<ServiceWorkerHost> in service_worker.mojom. Bug: 955171, 978694 Change-Id: If912d112250d3bb4786f5545d3039179abb26654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757954 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#689416}
-
Marc Treib authored
This reverts commit 2ff72648. Reason for revert: Suspected of making various PrintBrowserTests flaky, see crbug.com/996185 Original change's description: > Remove print document race condition using synchonous message > > JavaScript window.print() requests have been returning back to the > renderer process before the print has actually completed. When the > print preview is disabled it is easier to expose a race condition > between serving the print logic and whatever comes next in the > JavaScript. > > If the script has a popup window to be printed, which has > window.close() immediately after the window.print(), then the document > to be printed has its destruction racing against being printed - and > will typically lose that race, resulting in a lost or empty print job. > > Resolve by ensuring that the renderer process does not proceed past > window.print() until the DidPrintDocument message is sufficiently > completed. Making this message synchonous achieves this effect. > > This means that the renderer process will be blocked for all sites > which it serves for slightly longer than it already does. [1] > > [1] https://www.chromium.org/developers/design-documents/printing > > Bug: 974480 > Change-Id: I3ef08899e1792cc291aa8dd3d740da095e2c73bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700275 > Reviewed-by: Shimi Zhang <ctzsm@chromium.org> > Reviewed-by: Tao Bai <michaelbai@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Alan Screen <awscreen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#688096} TBR=michaelbai@chromium.org,thestig@chromium.org,caseq@chromium.org,tsepez@chromium.org,ctzsm@chromium.org,awscreen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 974480, 996185 Change-Id: I3ae34235d1bbdb98619a157a451e94e6b0e1cf48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760795Reviewed-by:
-
Marc Treib authored
This reverts commit e525e385. Reason for revert: DumpAccessibilityTreeTest.AccessibilityArticle/uia fails on Win7, see crbug.com/995723 Original change's description: > Fix <article> ControlType and <figure> LocalizedControlType > > Change ControlType of <article> from "Document" to "Group" per > https://w3c.github.io/html-aam/#el-article > > Change LocalizedControlType of <figure> from "group" to "figure" per > https://thepaciellogroup.github.io/AT-browser-tests/test-files/figure.html > > > Bug: 994380 > Change-Id: I36e59265650b1655b2811ccb3baac8b67e8552a3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757145 > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Commit-Queue: Dan Clark <daniec@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#688255} TBR=aleventhal@chromium.org,kbabbitt@microsoft.com,daniec@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 994380, 995723 Change-Id: I72844052b3ecf808fb77e383611168ee926174ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763680Reviewed-by:
-
Michael Lippautz authored
These metrics are either important for day to day operation or ongoing projects. Bump expiration of metrics to M84. Bug: 988635, 988652, 988675, 995507, 995509 Change-Id: Ib4dfd873ee1edd6203392e85ee6b4060250ccfe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760961Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#689413}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ddd16494fd70..49980fb4f214 git log ddd16494fd70..49980fb4f214 --date=short --no-merges --format='%ad %ae %s' 2019-08-22 kcwu@chromium.org auto-updater: fix exception message Created with: gclient setdep -r src/third_party/chromite@49980fb4f214 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I1cc94217c402cd6d6de30c7937d70d401940266d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764658Reviewed-by:
-
Matthias Körber authored
Adds the capability to retrieve all login credentials stored in the database using a specific password. Change-Id: I05cc22bc67213cd5166322341ff458c4a0c93675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757931 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
-
Marc Treib authored
After https://crrev.com/c/1752826, it has no effect. Bug: 990745 Change-Id: Ibfc35e2e2eed5f10732ec43bf12ac9cbd5343f75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762085 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#689410}
-
David Jean authored
Removed deps and (un-needed) sources that include part of ui/events/ (ui/events is main includer of ui/latency) Bug: 824384 Change-Id: I55e14b04b88b48bda077688f1f1e69fd7a93a20b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760737 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#689409}
-
Canon Mukai authored
RawResource is now cancelled asynchronously, so this logic is no longer needed. Bug: 683000 Change-Id: Ie7f4888727aa10b58b6a0b07c3453fec5e4d6029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763566Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 43a861d9. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I5e5233cf20d4fe809fbdd433b91bfe37d4b55481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763884Reviewed-by:
-
Tanisha Mandre authored
A change, cropping the QR Scanner preview layer was uploaded by mistake in CL: https://chromium-review.googlesource.com/c/chromium/src/+/1730906 This CL reverts this change. Bug:996638 Change-Id: I4a9c462aa4fe6de81951dbf3473ac663b2e5cde1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758240 Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Reviewed-by:
-
Marc Treib authored
Bug: 996170 Change-Id: I46b322cc58635a6509a53ad4fb14a58067491e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757933Reviewed-by:
-
Mohamed Amir Yosef authored
The feature has fully launched and has been enabled be default for at least one milestone. Change-Id: I2aa60b4e9ff986b82536b291e15b7b045c430af1 Bug: 801985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763755 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I63e0c5b2c40820836ce9e3e49d49c87e3ec6bb11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764860Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/af5edffa..ccbb1967 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If338826520d5680bbe34c2834067ba1f35b3b305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763883Reviewed-by:
-
