- 15 Oct, 2020 40 commits
-
-
Hidehiko Abe authored
Currently OS_LINUX is defined for Chrome OS Build, but it is being unset. This is the preparation for the change to keep the current behavior. Bug: 1110266 Test: built locally. Change-Id: Ie6409ec3398cc32602e6c88224532e392eeb6cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474834 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#817435}
-
Nico Weber authored
It's been unused since #816267 (we now automatically pick a good value), and no bots should set it anymore. Bug: 1132930 Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Change-Id: Id56b440f9b9ed859611b495cf8fa76b045112aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472959 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#817434}
-
Hidehiko Abe authored
Currently OS_LINUX macro is defined on Chrome OS build, but it will be unset. This is the preparation of the change to keep the current behavior. Bug: 1110266 Test: Built locally. Change-Id: I4b9c9cee9f811f31ac56c8ba28b6ee913a033d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474953 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#817433}
-
Omer Katz authored
This CL updates the TraceEphemeron method to deduce the right trace callback via the relevant TraceTrait. Drive-by: TraceMaybeDeleted is no longer needed for Members and replaced with TraceStrongly for WeakMembers. Bug: 1056170 Change-Id: I01b7ec0cec261e195d92e0e8125236a82ff07f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471358Reviewed-by:Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#817432}
-
Marc Treib authored
In various places around sync/engine_impl (like ServerConnectionManager and HttpPostProviderInterface and their subclasses) passed around URLs in various split-up forms (host, port, path) and did manual string manipulation on them. Additionally, some methods had a "path" parameter that in fact also included a query part. This was all particularly silly, since we do start out with a GURL (in SyncManagerImpl) and eventually need a GURL again. So now, we pass around a (base) GURL instead, plus (where appropriate) the path and query to add to that. Bug: 951350 Change-Id: If69a834500d88c285545c3d3703d81be3480e8c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470562 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#817431}
-
Danil Chapovalov authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/4b4f9aae75..f3f785ab59 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/4b4f9aae75..f3f785ab59 No .def file changes. Bug: None Change-Id: I257c47c54566b2fb08cfe1318fc3460b97beb4c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472398 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Auto-Submit: Danil Chapovalov <danilchap@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#817430}
-
Sylvain Defresne authored
With the soon-to-be release Apple Silicon mac devices, using the target_cpu to determine whether the build is targeting a device or a simulator is no longer a good heuristic. Introduce a new gn variable "target_environment" to explicitly control the environment in which the build is going to be used (simulator, device or catalyst). Bug: 1138425 Change-Id: I99fc84bdc88b1ed630d11e2fef73cffa82466f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471497Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#817429}
-
Nico Weber authored
The bots currently take around 24h or longer to cycle (they time after 24h; we've seen one build in 23h xx min on the 64-bit bot). We need to consistently come in under the timeout so that we can measure if speedup attempts have an effect. So for now, reduce the number of targets we build. Hopefully we can undo this at some point. Bug: 1132930 Change-Id: Icb2d4bc7f7ee14d5f3c758cd0b296afb0740f30b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472520 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
Leo Zhang authored
This will launch IME service with 'ime' sandbox instead of 'utility'. So that IME service will be able to load IME decoder from image. TEST=local betty VM. BUG=b/161491092 Change-Id: Id44963ce3fa4e94d9f577b8fda75db33b908fc0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465347 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#817427}
-
Sylvain Defresne authored
Instead of using -target for swift and -arch/-mios-*-version-min for clang, consolidate everything to use -target. This converts the command-line from (for a x64 simulator build of Chrome on iOS): clang ... -arch x86_64 ... -mios-simulator-version-min=12.2 ... to: clang ... -target x86_64-apple-ios12.2-simulator ... Bug: 1136055 Change-Id: I92668bfd23d25937eb8038b5b6dcf88e14f55f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471377 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
No code changes required. Bug: 294205 Change-Id: Ib6fe8aeb7e8c65bcf2ee57a6f2024a3a15ce83c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472003Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#817425}
-
Daoming Qiu authored
This CL is part1 of converting base::Bind to Once/Repeating in //chrome/browser/download/. Bug: 1007635 Change-Id: I771350334ee6c07deab1c224cb186e53ab5466b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465095 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#817424}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4d3dc7daedbd..e6f2d01f0096 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC msramek@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: msramek@google.com Change-Id: If79ed30202bb897279a5f0f86adc903bd530d0df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474333Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817423}
-
Alexey Baskakov authored
This reverts commit 6757c99a. Reason for revert: It was wrong culprit. Still failing here: https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/59863 Original change's description: > Revert "Enable vaapi decoding on linux x86/64 by default." > > This reverts commit 7bc2776d. > > Reason for revert: A culprit that breaks > WebRtcCaptureFromElementBrowserTest.CaptureFromMediaElement > test on Linux TSAN: > https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/59853 > > Original change's description: > > Enable vaapi decoding on linux x86/64 by default. > > > > Bug: 1097029 > > > > Change-Id: Ib3105a11e5ad76f7ef22930246014a702e39d0dd > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436704 > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#817228} > > TBR=dalecurtis@chromium.org,tmathmeyer@chromium.org,andrescj@chromium.org > > Change-Id: I73a5d50738122ef5c81a0c7a92ec9016ac1420eb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1097029 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474233 > Reviewed-by: Alexey Baskakov <loyso@chromium.org> > Commit-Queue: Alexey Baskakov <loyso@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817384} TBR=dalecurtis@chromium.org,loyso@chromium.org,tmathmeyer@chromium.org,andrescj@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1097029 Change-Id: I99ac6f3950373f1c0786c26795186787bff8b8bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473865Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#817422}
-
Noam Rosenthal authored
Extended StylePath to contain windRule. Extended path CSS property parser to account for wind-rule, e.g. path(oddeven, '...'). Pass through a zoom parameter when requesting a path for a ShapeClipPath. Allow PathInterpolationFunction to try to handle clip-path animations, when the shape is a path. Patched the necessary bits to allow CSSPathValue in clip-path. Unskipped relevant WPT tests, and added 3 new ones to handle page zoom. Those tests use zoom css property, in lieu of page-zoom support in WPT Bug: 880983 Change-Id: I0bf8d7a4ec746f656c33c0f99c37e0af1e3ff7e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442797 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#817421}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602719900-429a2df71c95e6dc087ec01302b187e7e9fb6918.profdata to chrome-linux-master-1602741093-4d55155af2d57fc162c54eb0d019ea99dc26a80f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1f03a2508a799e61c26fd141afb8148a5e571434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474007Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817420}
-
Peter Kotwicz authored
BUG=1138737 TBR: dcheng@chromium.org Change-Id: I7c31b95b48be172e3305f02e7e71951aa3aa455d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473760 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#817419}
-
Michael van Ouwerkerk authored
Sadly this removes the settings shortcut feature from WebAPKs, but I intend to reland this without the androidx dependency. Revert "Add site settings to WebApks" This reverts commit 8d9ec21b. Revert "Remove hashes of site settings images" This reverts commit b9122c79. Revert "Check category before adding site settings shortcut" This reverts commit 2c8911bf. Revert "Add webapk site settings category" This reverts commit abbc3f13. Revert "Fix flaky webapk site settings test" This reverts commit 77442252. Change-Id: I37f6c7bc2e3b4a5f52ed8bdabd5ddd6a3e4c5d47 Bug: 1138210 Change-Id: I37f6c7bc2e3b4a5f52ed8bdabd5ddd6a3e4c5d47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470631Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#817418}
-
Mariam Ali authored
This CL: 1. Adds a browser test for GetGuestBrowserCount method (calculates the number of open guest windows). 2. Merges Incognito and Guest window count tests with a parameterized fixture. Bug: 1105763 Change-Id: I8af67507962d71c5665a6026f8bc45c16a99d4ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463579Reviewed-by:David Roger <droger@chromium.org> Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Commit-Queue: Mariam Ali <alimariam@google.com> Cr-Commit-Position: refs/heads/master@{#817417}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602719900-0adf1708ffdf07a3257db3881b100b59132f390a.profdata to chrome-mac-master-1602741093-813b9f30d38756007f17b964e7014a850d40bedc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4704c7bc4c3bcec58fb6bf9f50c56fdbc2e93905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474005Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/40217a30c5c6..c4de62d51fff 2020-10-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 914c0473..37c343f0 (817219:817356) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I463a951b11d6f3f15bdd0cd4ba1192894f6498f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473832Reviewed-by:
-
Viktor Semeniuk authored
This change adds possibility to edit username on the Password details screen. Bug: 1137475 Change-Id: I8464c07ea24538c1ba48d4d8cea30837cad45017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461373 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#817414}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/324abbd44f95..e07f2b21917d 2020-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e72c6099f946 to 52c1a859d9eb (3 revisions) 2020-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from bd0d3f9c4ff8 to a2ef814426ee (22 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Test: Test: Test: Manual verificationTest: Test: dEQP-GLES31.functional.fbo.color.texcubearray.* Change-Id: Iec6279ef70b91517d682ee111c94d839990ee516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473830Reviewed-by:
-
Satoshi Niwa authored
This allows the calling Android app to specify initial search query to run on the file selector. go/arc-r-documents-ui Bug: 1126742 Test: trybot Change-Id: I65b149d0a25914d1fda269d32cb74a1a6eb445b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400789Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#817412}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/046d0bf2b6a4..09d2653233eb 2020-10-15 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I813d312e5a9333469e191d1585241e6540a46d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473829Reviewed-by:
-
Asami Doi authored
ServiceWorker: Start the event immediately if its type is same as the type of the currently running events This CL makes an event start immediately after its creation if its type is the same as the events currently running. The behavior slightly changes by this change. Previously, if the events come like [online1, offline1, online2], the order of execution is 1) online1 2) offline1 3) online2. Now, if the events come like [online1, offline1, online2], the order of execution is 1) online1 2) online2 3) offline1 if online1 is running when online2 comes to the queue. Also, this CL renames `id_event_map_` to `all_events_`. Bug: 965802 Change-Id: Ibb82efc509a5c7ea0364a3e31127728ce8b8de1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438074 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#817410}
-
Austin Eng authored
Change-Id: Iada015382d0a5c66ea0f09935703bc18054181f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473759 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#817409}
-
Paula Vidas authored
This CL adds a test that checks the following: - On signout, the FCM registration token should be cleared. - On signin, it should be requested again. Bug: 1135167 Change-Id: Ie1b1967b9ed317c0a36d4b751aef0dfeb81c45d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467979 Commit-Queue: Paula Vidas <paulavidas@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#817408}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/95e0f2a77656..4d3dc7daedbd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC loyso@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099982 Tbr: loyso@google.com Change-Id: I2a939a9098aac8fbbbcadc0429bf8c6cc002cd4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474003Reviewed-by:
-
Noel Gordon authored
The DevtoolsListener sends CDP commands to devtools to control it, and uses host->DispatchProtocolMessage to do that via a SendCommandMessage helper see CL:2473621. The signature of DevToolsListener::DispatchProtocolMessage causes some confusion when compared to host->DispatchProtocolMessage: has the same name, is defined by the base class content::DevToolsAgentHostClient so we can't change it, but the TL:DR; is it handles the reverse direction of the devtools interaction - where the devtools host wants to tell us about something (eg., Debugger.scriptParsed) or provide the "response" to a DevtoolsListener CDP command. Call whatever devtools emits a |value|, rather than a response. Values in DevToolsListener::DispatchProtocolMessage are 1) a "message", which always have a "method" in their value or else 2) a command "response", which have an "id" in their value. The "id" is uniquely defined by the associated DevtoolsListener CDP command. Name change only response => value, no change in behavior. And this to add some git blame details about DispatchProtocolMessage. Tbr: benreich Bug: 1113941 Change-Id: I4835eddf1bb3435ad82cdbdf786d9450b08e29ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474214Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#817406}
-
Yoichi Osato authored
This CL introduces mojo_base.mojom.BigBuffer instead of array<uint> so that fetch can send big ArrayBuffer. Originally this CL added a test uploading 150MB(see Patchset#1). However it caused many ci bot slowness failure (see crbug.com/1136750 and crbug.com/1138121). Thus this CL removed the test. I will add another test. TBR=kinuko@chromium.org,yhirano@chromium.org Bug: 919361 Change-Id: I758fbe20ddd794776e6b4467d1066c83a5c3125a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474213Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#817405}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b7c1c3f1140b..c57737e35b47 2020-10-15 dberris@chromium.org pinpoint: Manage Pinpoint label exclusivity If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1138091 Tbr: wenbinzhang@google.com Change-Id: I52ccf63074c9dc969fa813d99680e7e266b37574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473825Reviewed-by:
-
Jesse Schettler authored
Bug: 1059779 Change-Id: I5626df525bd7f4f5fd5da38a40ec4d1c9f25fd4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463554 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#817403}
-
Alex Gough authored
These are opened with FLAG_READ here and should never be writable by renderers: https://source.chromium.org/chromium/chromium/src/+/master:content/browser/renderer_host/dwrite_font_proxy_impl_win.cc;drc=da8e399b1f509d29565224190204860b22c9062b;l=272 Bug: 1130762 Change-Id: I4e071c5daff9697198823cd9a41ea1730d855327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462710Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#817402}
-
Nate Fischer authored
No change to logic. This exposes blink/common/features.cc to Java using java_cpp_features. As part of this, this changes the declaration of one feature (does not change the semantics of the feature though). This is so WebView DevTools can depend on autogenerated constants for two features it already exposes (WebComponentsV0 and AppCache). Bug: 1132092 Test: autoninja -C out/Default system_webview_apk Change-Id: If3a5a77de665de1375a6e52ec16a3a9babc40214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429252Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#817401}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6e970e597b25..8e567c5cf507 2020-10-15 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: If924d299ff2903cfbecf65418aa35cbcbbb10913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474000Reviewed-by:
-
Koji Ishii authored
NOTRY=True Change-Id: Ib088a06a2f6e85ac5cb23c6c8deb0b6b9eeae7e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470038Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#817399}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0c83e15c6b61..40217a30c5c6 2020-10-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d18ea8bb..914c0473 (817098:817219) 2020-10-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision cc4512db..d18ea8bb (816967:817098) 2020-10-14 danilchap@webrtc.org Refactor ScalableVideoController::OnEncodeDone signature 2020-10-14 danilchap@webrtc.org Distinguish id for GFD and DD rtp header extensions when both are advertised 2020-10-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 51f6153d..cc4512db (816858:816967) 2020-10-14 alessiob@webrtc.org AGC2 config change detection fixed 2020-10-14 danilchap@webrtc.org Advertise dependency descriptor rtp header extension behind a field trial If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9e4c2e0d092473e220ecef7acbfd10cdf86ef142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473998Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a58a676ab96a..055495dfbb24 2020-10-15 tsepez@chromium.org Split IPWL_FillerNotify off into its own .h file. 2020-10-14 tsepez@chromium.org Replace class CFWL_List_Notify with a virtual interface. 2020-10-14 tsepez@chromium.org Reverse order of CPWL_ListCtrl and CPWL_List_Notify cleanup If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1137630 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I6e712a2220f4569d1a354a44064a434d35253e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473826Reviewed-by:
-
Alexander Dunaev authored
Bug: 1138740 Change-Id: I444b8d297c920f0b4cf00352bfdb21da6c8ff21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474114 Auto-Submit: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#817396}
-
