- 15 Jan, 2021 40 commits
-
-
Sunny Sachanandani authored
GL_RG8_EXT is part of GL_EXT_texture_rg which is an ES2 extension, so we must follow ES2 semantics like GL_R8_EXT i.e. internal format must match data format. Just something I noticed while doing some related work, probably doesn't matter in practice if we're not creating RG8 textures with glTexImage2D, etc. Bug: 1116101 Change-Id: If6042f2432eec13df6b2d27602d87674e19cc78d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629665Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#843860}
-
Leonid Baraz authored
Change-Id: I8283cdbb148fe05335d82fae80485fe443be7e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631448 Auto-Submit: Leonid Baraz <lbaraz@chromium.org> Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#843859}
-
Xiaodan Zhu authored
This CL implements desks reordering with drag & drop. The main changes are listed as below: - Added response methods for mouse pressed, drag and released events in desk preview to trigger drag and drop. - Added *DragDesk methods in desks bar view to handle drag and drop. - Added a new class DeskDragProxy to create a proxy of desk being dragged. - Added a method PerformMiniViewReorderAnimation to animate the movement of desks while reordering. Bug: 1154038 Change-Id: I7633970a94d69e1326cf09eaede3929ca0acb811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602859 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#843858}
-
John Delaney authored
What: Adds new chrome/ layer embedder controls for the Conversion Measurement API which proxy to privacy sandbox settings. Why: The existing integration only checks for 3P cookie blocking, whereas the privacy sandbox settings check whether 3Ps are allowed for a given context. This also fixes a privacy sandbox settings bug in which the wrong origin was supplied when checking if a report can be sent for a given set of origins. Note: This was previously https://ccrev.com/c/2613686, but that change was accidentally deleted. Bug: 1163721 Change-Id: I10aba286ad7c641fe8f19f8ad327cf6eabdc3c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627093 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#843857}
-
tby authored
This CL does two things. 1. The previous CL only checked the value of the content toggle at initialization, meaning a user wouldn't immediately stop seeing suggestions after disabling, or start seeing them after reenabling. This CL moves the check to just before display time instead. 2. This also adds a content toggle check to the local file provider, rather than just Drive in the previous CL. The UX of having one but not the other wasn't very good. Bug: 1034842 Change-Id: I4f408d8d1e40ef44e4a80906aa10ad7333a49eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628709Reviewed-by:
Rachel Wong <wrong@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#843856}
-
chromium-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/4c6cbd7a1be7..676d3c095a28 2021-01-14 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 586c46b96b62 to fb2ab876edcd (1 revision) 2021-01-14 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from 820179bf4689 to a5eaf2f44a5d (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com,dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: radial-bots+chrome-roll@google.com,timvp@google.com,dsinclair@google.com Change-Id: I952a9b110b63f41e9c88b428b01ccb0dc8ad15e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629473Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843855}
-
Ted Meyer authored
Just in case it ever gets called twice, we don't want to move the error out. Change-Id: I6d091b2c56fa7e07ce0b1ca08f079d87621d592e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631188Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#843854}
-
Dominic Mazzoni authored
THe box-shadow property isn't shown in forced colors mode, so give the realbox a real border instead. Bug: 1166383 Change-Id: I8a1aa58d965a0fed1a69b0210273a984c8478a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628077Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#843853}
-
Keishi Hattori authored
Make rewrite_raw_ptr_fields/rewrite.sh auto detect when we want to rewrite for the windows platform. Bug: 1069567 Change-Id: I18044284186555a07f63cdad5a0604e5749df94c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626866Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#843852}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610647094-91dde28e2f09f28a39a8ebc52cc90535738b2c08.profdata to chrome-win64-master-1610657917-28dde97bcaff353b91ba180b51342313b1d23453.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I11ab61b630e99c80bd819888f2dc9daaed0745fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630985Reviewed-by:
-
Xiaocheng Hu authored
Bug: 687225 Change-Id: Ic90fcd65d9e932f3a9916938af7595e121247280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629967 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#843850}
-
John Palmer authored
This means that words with accents get the correct length of underlining. Before this fix autocorrect "francais " to "français " would have an underline on the space after the word which this fixes. Bug: b/176562554 Change-Id: Ic05a46ee351bbd9159b6c197cd3f02f3b3d3a7e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612290 Commit-Queue: John Palmer <jopalmer@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#843849}
-
Alexey Knyazev authored
Bug: angleproject:5543 Change-Id: Ibe3385f636b067ca5629845a059b0b1d7b09b886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627370 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#843848}
-
David Bertoni authored
This is a reland of crrev.com/50ba4848. The original CL was reverted because a test that runs only on Mac was broken, but the mac-rel trybot didn't run the browser_tests target during the original submit. The failing test was temporary re-enabled to run on all platforms to verify the fix works. It was also run on an additional Mac trybot where the browser_tests target was executed. It was then re-disabled. The only differences between the original CL and this one can be viewed by diffing patchsets 2 and 3. Original CL description: Prior to this CL, the default was that test extensions were loaded with file access enabled. This is not necessary, and doesn't reflect the real world, where most APIs work without needing file access. With this CL, the default is that a test must explicitly request file access for the extension. To reflect this, some member functions have been renamed and their behavior modified so that it's clear that the test is requesting file access. This also fixes the PermissionsApiTest.OptionalPermissionsFileAccess test, which had incorrect embedded extension IDs. Bug: 1163548 Change-Id: Ida61f22504e12a5bef1b70e9f01b0750f8008f76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629468Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#843847}
-
Salvador Guerrero authored
This CL removes the option of setting up migrations for each database individually, now if the migration experiment is on all databases will be migrated (except by those in a blocklist). This makes it simpler to launch the experiment to stable, as we will no longer need to specify each database name on the experiment params. Bug: 870813 Change-Id: I00259f5ceeae14790a40546d9fab064eac1aea29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630734Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Salvador Guerrero <salg@google.com> Cr-Commit-Position: refs/heads/master@{#843846}
-
Daniel Cheng authored
When a class uses BrowserAssociatedInterface<T>, it should implement the mojo interface T. Force that to be the case by making T a suclass of BrowserAssociatedInterface<T>. Change-Id: Ide8ecd46c298ec86de57b229593ec7d6c4b6a3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629670Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#843845}
-
Gayane Petrosyan authored
Bug: 1157981 Change-Id: I94587222da279a93c61136670807423c420ef386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627760 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#843844}
-
Ionel Popescu authored
This CL updates the text selection colors for Android to: - background: #99C8FF - foreground: #3B3B3B Bug: 1160107 Change-Id: I2836c040cb3a9ce497acc8a91db9379f7ac108ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623652 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#843843}
-
Tom Sepez authored
There are a few more spots similar to https://chromium-review.googlesource.com/c/chromium/src/+/2628044 Either check the return code, or pre-initialize the out parameters so that uninitialized reads are avoided should false someday be returned. -- tidy one multiple-assignment encountered while looking for other occurences. Bug: 1166478,1166462 Change-Id: I2aef090f87aac0cd393e977809c8a24eb8d36de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630735Reviewed-by:
K. Moon <kmoon@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#843842}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d392af02b749..c07ef602741b 2021-01-14 syoussefi@chromium.org Vulkan: Move xfb buffer decl to translator in emulation path 2021-01-14 timvp@google.com Capture/Replay: Only get source for linked programs 2021-01-14 jmadill@chromium.org Revert "Vulkan: Prefer host cached memory for Buffers" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I83e79dcce84dade9ed6e735789c7b896009829d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630489Reviewed-by:
-
Jeff Cyr authored
The allowlist state is received per extension in a custom omaha attribute during an update check and stored as an |AllowlistState| in the extension prefs. When the 'EnforceSafeBrowsingExtensionAllowlist' feature is enabled and Safe Browsing Enhanced Protection is enabled, the extensions in state |ALLOWLIST_NOT_ALLOWLISTED| will be disabled with |DISABLE_NOT_ALLOWLISTED|. Other supporting changes: - Moved the 'DisableMalwareExtensionsRemotely' feature check from update_service to extension_service to fill the omaha custom attributes even if the remotely disable feature is not enabled. - Added string |IDS_EXTENSIONS_BLOCKLISTED_NOT_ALLOWLISTED| to show appropriate warning in 'chrome://extensions'. Bug: 1153873 Change-Id: Icde8bbe7fa968fc22b28129b236cd574de5aae85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565592 Commit-Queue: Jeff Cyr <jeffcyr@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#843840}
-
Koji Ishii authored
This patch has no behavior changes. Bug: 1154531 Change-Id: I107087381641c9ea2eb896adf3719f839caec447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596756 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#843839}
-
Erik Chen authored
This CL is a refactor with no intended behavior change. The goal is to reduce redundant strings across different ash consumers of the platform_keys api. Bug: 1164523 Change-Id: I4b34cf98ac7303b7dab4e7a799b045972b61ba6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630430 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#843838}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I4876b7140955281df26390017bccb5a409af90fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630988Reviewed-by:
-
Shane Fitzpatrick authored
Fixed: 1132432 Change-Id: If6ffc4bfb115d4076bfebfd1a58395200a8cc5c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629912Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Shane Fitzpatrick <shanefitz@google.com> Cr-Commit-Position: refs/heads/master@{#843836}
-
Ben Joyce authored
Bug: 1161286 Change-Id: Ieadca6a052085daaf5ef4a4099fc46e70363f5a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630737 Auto-Submit: benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#843835}
-
Gordon Seto authored
This button is being renamed as it will be modularized to have a dynamic label in a follow-up CL. Bug: 1093185 Change-Id: I70f49ffaa35d73b25ea1d5f23521cf93a8c4cf8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629661 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#843834}
-
Minoru Chikamune authored
Before this CL, `out/Default/blink_unittests --single-process-tests` was failing. This is because even though WebViewHelper creates AgentGroupScheduler, the tests created another AgentGroupScheduler. This CL fixes this problem. Bug: 1166542, 1105403 Change-Id: I96cf2e43896d0c6ac706d3bdd354647b12d4c8db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629149Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#843833}
-
Liviu Tinta authored
MouseEvent::screenX, MouseEvent::screenY, MouseEvent::clientX, MouseEvent::clientY, MouseEvent::pageX, MouseEvent::pageY we expose as double in mouse_event.idl [1]. Because of this is safe to use std::trunc instead of static_cast<int> in order to avoid float-cast-overflow. [1] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/events/mouse_event.idl Bug: 1164520, 1162288 Change-Id: I9aef2eea97090fb61aa28c3bbc03209e1401ee39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621675 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#843832}
-
Luciano Pacheco authored
Remove the call to Polymer.updateStyles() because this isn't necessary anymore and Polymer 3 doesn't expose this function in the Polymer object. It was added for crbug.com/740836. I've tested manually without this function call and checked the value of --files-ripple-bg-color in the #view-button, this variable changed value from white to black when selecting a file like described in the bug. Bug: 1133186 Change-Id: Ia955545a60bef11a823b181589a4acaad2e39c06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628712 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#843831}
-
David Van Cleve authored
It looks like this and a number of related tests had been failing and were recently reenabled; after the reenable, this one specifically is still flaking. Bug: 1166906 Change-Id: I0aca084860ad37976fdc736b7a1e64ed62c0134d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630829 Commit-Queue: David Van Cleve <davidvc@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#843830}
-
Lambros Lambrou authored
This adds a missing AddEventObserver() call in ClipboardX11. Bug: 1165520 Change-Id: I20335ab29d4b88b0fff70450074e8fcf951a55d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631327 Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Erik Jensen <rkjnsn@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#843829}
-
Miyoung Shin authored
This CL update the codes so that all tests from JavaBridgeArrayCoercionTest pass with MojoTestParams. Bug: 1148997 Change-Id: Iaf3fce7ef63e5e7732296ce3775fa6be0d04f108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571031Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#843828}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b7ddc5a0091b..2241db8a1f6c 2021-01-14 brucedawson@chromium.org Avoid capture_output to support Python 3.6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:868590 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I4636236a9c0f9db1cd3d9624b9f4222eadc3ea49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630987Reviewed-by:
-
Austin Tankiang authored
This will be plumbed to Files App UI where a dialog can be displayed. Bug: 1166058 Change-Id: I4f271a0b4eb3002e430f5dbd127ebb8a8e844503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626813Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#843826}
-
Jeroen Dhollander authored
Previously the Libassistant bootup config was created on the browser thread and passed to the mojom service, but that just adds unnecessary dependencies of the browser thread on Libassistant internal stuff (i.e. the structure of the bootup config). Bug: b/176851446 Test: chromeos_unittests && deployed Change-Id: I3617943bc1dff483a1745d03194b9565cd1ad653 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618546 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#843825}
-
Esmael El-Moslimany authored
Screenshots https://crbug.com/1138011#c13. Bug: 1138011 Change-Id: I93f594e4d78c717b0dee05d2ad5ade219e8b956d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628448Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#843824}
-
Stephen McGruer authored
As part of mandatory code review, we are moving from the copy of tools in third_party/blink/web_tests/external/wpt/tools to the manually rolled copy in third_party/blink/tools/blinkpy/third_party/wpt/wpt. WPT itself has some third-party libraries that violate checkperms that we cannot easily fix, so make those an exception. Once the migration is completed, we will remove the previous external/wpt/tools entry here as well. Bug: 1165950 Change-Id: I7145b8bf4e82c8fd99ad5f42330b68e2f29aac45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626420 Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#843823}
-
Garrett Beaty authored
Bug: 1165826 Change-Id: Ia76cb00dfbc488094563df41b25736f22ea128d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625392 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#843822}
-
Sammie Quon authored
Add support for the snip key in accelerators and KSV. For the time being, both accelerators and KSV will backwards support the old screenshot code, resulting in some extra logics in both that will get removed when capture mode can no longer be disabled. Fixed: 1163936 Test: manual Change-Id: I05c32fdf1391397128b5dd2859d38d7508ceedd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628019 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
