GitLab

This CL moves ownership of payments::PaymentsClient and FormDataImporter to
implementations of AutofillClient in order for these objects to live beyond
the lifespan of AutofillManager. AutofillDriver and thus AutofillManager's
lifespan is tied to the renderer frame which gets destroyed with
cross-domain navigations on form submission and therefore creidt card save
isn't offered. With this change these objects' lifespan will be tied to the
tab.

Bug: 892299
Change-Id: I1651e92ba032d04d047221d91bafbdfcc511296a
Reviewed-on: https://chromium-review.googlesource.com/c/1320215
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606100}

Previously we skipped to create non-network factories for subresource loading
from a service worker as a performance optimization. It works on
S13nServiceWorker because extensions are handled by a resource dispatcher host.
However, NetworkService doesn't work well because those requests need to be
routed to extensions before going to the NetworkService. This CL fixes by always
creating non-network factories for subresource loads.

Bug: 901443
Change-Id: Ia932dc11352c14be9f33c9e3448891cf66d699e0
Reviewed-on: https://chromium-review.googlesource.com/c/1322258Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606099}

Rather than having content call blink code to call back into content
in order to set visibility on the compositor, have content code do so
directly.

Historically, this would be an artifact of the compositor being an
optional thing, and being a wrapper around different code for each port
of WebKit.

Now we can remove the method. RenderWidget already does SetVisible() to
true during its creation/init phase when appropriate, so blink doesn't
need to repeat that. Then, we change visibility on response to IPCs
received in content, so it can control the compositor directly.

This gives us more clarity around when the compositor will be visible
or not, and thus more confidence that it will stay non-visible for a
swapped out RenderWidget.

LayoutTests demand the ability to set the page's visibility state
directly from the TestRunner, with more options than just hidden or
visible. So we expose the ability to set that on RenderViewImpl to
the TestRunner, and share that code internally in RenderViewImpl to
unify the two paths again, since they'd diverge otherwise with
moving code up to RenderViewImpl from WebViewImpl.

R=dcheng@chromium.org, piman@chromium.org

Change-Id: I366e0f36923f8a690e4e1562e46e6d94e76f3e61
Bug: 896836, 419087
Reviewed-on: https://chromium-review.googlesource.com/c/1320191
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606098}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aced3af1656c..39f97da7dc62


Created with:
  gclient setdep -r src-internal@39f97da7dc62

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I3e93246903f053b57dcc91642617b2a7cf96a362
Reviewed-on: https://chromium-review.googlesource.com/c/1323611Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606097}

Remove all trace of SigninManager from SyncEngine, which also
required some changes in clients and unit tests due to the removal
of one parameter from the SyncEngine's constructor.

Bug: 890798
Change-Id: I10596e61c46f7b86b8afb37c2dbfc401f5f651a8
Reviewed-on: https://chromium-review.googlesource.com/c/1297981
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606096}

This reverts commit 31bcf8aa.

Reason for revert: Canary crasher, Bug:902832

Original change's description:
> Reland^3 "[blink] Control ScriptStreamer with ScriptResource"
> 
> This is a reland of 5528336d, which
> was a reland of dd9df78c, which was
> a reland of 7bd91635.
> 
> VR tests have been properly deflaked in https://crrev.com/c/1319715, this
> is otherwise unchanged.
> 
> Original change's description:
> > Reland "Reland "[blink] Control ScriptStreamer with ScriptResource""
> >
> > This reverts commit c564235f.
> >
> > No changes from the original, VR flakes are caused by issues with
> > loadUrl and have been deflaked (see 894796 for details)
> >
> > Original change's description:
> > > Revert "Reland "[blink] Control ScriptStreamer with ScriptResource""
> > >
> > > This reverts commit dd9df78c.
> > >
> > > Reason for revert: Makes VR tests flaky (https://crbug.com/894796)
> > >
> > > Original change's description:
> > > > Reland "[blink] Control ScriptStreamer with ScriptResource"
> > > >
> > > > This is a reland of 7bd91635
> > > >
> > > > No changes from the original, revert reason is fixed with
> > > > https://chromium-review.googlesource.com/c/1283037
> > > >
> > > > Original change's description:
> > > > > [blink] Control ScriptStreamer with ScriptResource
> > > > >
> > > > > Move the ScriptStreamer control logic from ClassicPendingScript to
> > > > > ScriptResource. In the future, this will allow us to start streaming
> > > > > a ScriptResource before the ClassicPendingScript is available, e.g on
> > > > > preload.
> > > > >
> > > > > The ClassicPendingScript now only sends one "finished" callback, from
> > > > > ScriptResource. This callback is either when the streaming completes,
> > > > > or when there is no streaming and the ClassicPendingScript has told
> > > > > the ScriptResource that it doesn't intend to start streaming. In the
> > > > > long run, we want all scripts to go through the streaming interface,
> > > > > and we want ScriptResource to control when streaming starts, so the
> > > > > "no more streaming" call will disappear -- however it is necessary to
> > > > > maintain the current behaviour, and be able to control it with a
> > > > > runtime flag.
> > > > >
> > > > > Bug: chromium:865098
> > > > > Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e
> > > > > Reviewed-on: https://chromium-review.googlesource.com/c/1181430
> > > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > > > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> > > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> > > > > Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> > > > > Cr-Commit-Position: refs/heads/master@{#599148}
> > > >
> > > > TBR=kouhei@chromium.org,kinuko@chromium.org
> > > >
> > > > Bug: chromium:865098
> > > > Change-Id: I0df324ef8e284f4d3d55a1721d71be5a66a3285c
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/1286450
> > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#601143}
> > >
> > > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
> > >
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > >
> > > Bug: chromium:865098
> > > Change-Id: Ibdbd7e80d0fcfacc84a73e83d165581c7f1d02d2
> > > Reviewed-on: https://chromium-review.googlesource.com/c/1297138
> > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#602310}
> >
> > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: chromium:865098
> > Change-Id: I9794fe5366aa8cfc9291d53271ed680465b29a76
> > Reviewed-on: https://chromium-review.googlesource.com/c/1317566
> > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#605295}
> 
> TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org
> 
> Bug: chromium:865098
> Change-Id: I8d6101f51eb33b19ec332a06a310172b371b7fa4
> Reviewed-on: https://chromium-review.googlesource.com/c/1318923
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605815}

TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org

Change-Id: I9a9337344d5a11fcc6b16aab1d8ad600ffef4e10
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:865098
Reviewed-on: https://chromium-review.googlesource.com/c/1323655Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606095}

This reverts commit 14754da5.

Reason for revert: causing some crashes on Cross

Bug: 902834

Original change's description:
> RC: Encapsulate most of the singletons into ResourceCoordinatorParts
> 
> There's several singletons / global instances in c/b/rc that are leaked
> at shutdown, this is causing some issues in runs of unit_tests because
> we end up re-using them between different test runs that should be
> independent. This is currently preventing some feature to be enabled.
> 
> This CL add a new ResourceCoordinatorParts class that encapsulate all
> these objects that should be created only once, an instance of this
> class is owned by the browser process.
> 
> Change-Id: Ia64618b6f47052815d861ff6820d994f8a65cc64
> Reviewed-on: https://chromium-review.googlesource.com/c/1290775
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606061}

TBR=sky@chromium.org,chrisha@chromium.org,fdoray@chromium.org,sebmarchand@chromium.org

Change-Id: I37bbcac05cceac6291874ad94d517cbdd4eeab2c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1323623Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606094}

The bot is broken at the moment.

NOTRY=true

Bug: 902806
Change-Id: I1ee551c95617444e5ec4edbdb3d8d4fde6d7dc5f
Reviewed-on: https://chromium-review.googlesource.com/c/1324090
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606093}

(With partial resource being a 206, not a truncated one).

Previously we would happily use a first chunk from cache, then fail in panic when validation
of the second chunk failed; this was especially bad for servers whose validation fails to
match for resources for which headers suggest it should.

After this change, in this case, we force a validation of the first chunk, and if it fails
re-fetch the entire resource. This is far from ideal, but we have limitations when it comes
to converting a pre-existing 206 entry to a 200 one that make using somewhat-better-in-this-case
If-Range really painful (and there is no multi-range support, that would be useful for these
sorts of reconstructions, either).

(Heavily affects the lazyload experiment)

Bug: 888742
Change-Id: I7f3f3b40dc1e2a98dd093ac09c98fe43eee5f3bd
Reviewed-on: https://chromium-review.googlesource.com/c/1291595Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606092}

+ Use sentence case for buttons
+ Chanage filled button side padding to 24dp
+ Change text button side padding to 8dp
+ Change clear browsing data setting button to filled button

Bug: 900760
Change-Id: Id9c01960464319c5b3ad974564b4637c8d9d0217
Reviewed-on: https://chromium-review.googlesource.com/c/1315214
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606091}

To speed up build time on windows component build, I will enable newly added /Zc:dllexportInlines- flag. The flag is similar to -fvisibility-inlines-hidden in gcc/clang.

This flag makes inline member function is not exported if it does not have static local variables. But in few classes of chromium, we need to add additional EXPORT specifier to prevent link failure.

This is a part of effort adding EXPORT speicifer to enable the flag.

Master CL is
https://chromium-review.googlesource.com/c/chromium/src/+/1317069

This CL was uploaded by git cl split.

R=erik.corry@gmail.com

Bug: 901709
Change-Id: I942c126cf68df4b242c7e49f05c2d7696e9d1b9e
Reviewed-on: https://chromium-review.googlesource.com/c/1322175
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606090}

https://webrtc.googlesource.com/src.git/+log/a7f77a7c05b5..50f60cb4b3a6


git log a7f77a7c05b5..50f60cb4b3a6 --date=short --no-merges --format='%ad %ae %s'
2018-11-07 yujo@chromium.org Rename software codec classes and move them into api/
2018-11-07 sprang@webrtc.org Remove non-default VideoEncoder::EncoderInfo() ctor
2018-11-07 sprang@webrtc.org Update MockVideoEncoder with correct methods.
2018-11-07 alessiob@webrtc.org Revert "Isolating APM API build target: making :api an actual target."


Created with:
  gclient setdep -r src/third_party/webrtc@50f60cb4b3a6

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I2de05a4174f28cab6d6c5076cd250348776a8534
Reviewed-on: https://chromium-review.googlesource.com/c/1323229Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606089}

Active cancellation of dns requests may lead to creation of too many background
threads performing getaddrinfo. It happens because we can't cancel getaddrinfo,
and the task runner will allocate a new thread even though a thread with the
cancelled getaddrinfo is still alive.

This reverts commit 512b3dda and applies new
patches on top of this revert.

Bug: 883806
Change-Id: Ie731783b86300a312de56b3e281a640fb23829fb
Reviewed-on: https://chromium-review.googlesource.com/c/1307445Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606088}

Bug: 884817
Change-Id: Iab61ac0b51d4541313f48263cadbfe2110fac543
Reviewed-on: https://chromium-review.googlesource.com/c/1321255Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#606087}

This disables the QUIC protocol in WebView for the NetworkService path.
This protocol is not currently supported.

R=jam@chromium.org

Bug: 887538
Test: Manual - nothing seems drastically broken
Change-Id: I0f88c257b3fd2928492888ecb09793aa3e3c45b1
Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo
Reviewed-on: https://chromium-review.googlesource.com/c/1322357Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606086}

This clears a few AdaptCallbackForRepeating instances in CrOS code.

Change-Id: If9dcfdfca2eb571d4f2f8b93c27f913b41058aa6
Reviewed-on: https://chromium-review.googlesource.com/c/1316437Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606085}

https://boringssl.googlesource.com/boringssl/+log/dd412c428ad7c2a60ae4709dfbad6301e499dcb8..384d0eaf1930af1ebc47eda751f0c78dfcba1c03

Bug: none
Change-Id: I68987a17316901349adf2d2da45b7e89f63d5d62
Reviewed-on: https://chromium-review.googlesource.com/c/1320969Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606084}

This got fixed in http://crrev/c/1314133 and http://crrev/c/1319334.

R=jam@chromium.org

Bug: 893577
Bug: 887538
Test: N/A
Change-Id: Ib012ff2f18e5e2b92ad6167d3de48154b4cd1b04
Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo
Reviewed-on: https://chromium-review.googlesource.com/c/1322354Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606083}

Notify the feature engagement system when a suggestion is clicked,
opened in a new tab or downloaded using a single
'contextual_suggestion_taken' event.

BUG=901915

Change-Id: Iaf5ed83f8a7e36b044541cfe96d3cc4a9fd34d4b
Reviewed-on: https://chromium-review.googlesource.com/c/1321864Reviewed-by: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606082}

https://skia.googlesource.com/skia.git/+log/273fa2f3bd0b..d282860c9472


git log 273fa2f3bd0b..d282860c9472 --date=short --no-merges --format='%ad %ae %s'
2018-11-07 mtklein@google.com get rid of SkScalarDiv
2018-11-07 mtklein@google.com move third_party/gif deps to codec_srcs


Created with:
  gclient setdep -r src/third_party/skia@d282860c9472

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=allanmac@chromium.org

Change-Id: Id4bbf7969da8b7fb1a4a85a7e5cad51f4df5cf6f
Reviewed-on: https://chromium-review.googlesource.com/c/1323230Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606081}

This fix does not fix the root cause, but it will prevent the bug from
reproing on M-71.

Root cause fix can be tracked in the same bug.

Bug: 881886
Change-Id: I83882f9d0a5725aad660ea8a6926dd3b689ad306
Reviewed-on: https://chromium-review.googlesource.com/c/1321729Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606080}

Bug: 880863
Change-Id: I90983adf6d7ebd3ead1652c85b7c65a04b142a99
Reviewed-on: https://chromium-review.googlesource.com/c/1313510
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606079}

For MobileSessionShutdownType histogram, there is a
FIRST_LAUNCH_AFTER_UPGRADE. The comment the code that logs this status
is improved to better explain why ignoring First Launch After Upgrade is
the right thing to do.

Change-Id: If09af3fa46155c269a97e05253eedc4febc37d68
Reviewed-on: https://chromium-review.googlesource.com/c/1320129Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606078}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8eba77ea..273fe31d

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I02a918d5aafbf3934e8bf94eeb910da3aafeb4e4
Reviewed-on: https://chromium-review.googlesource.com/c/1322971Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606077}

[Autofill Assistant] Changed overlay color to be consistent with the default modal dialog overlay color, which currently is black @ 0.5 opacity.

Bug: 806868
Change-Id: I2725d8df984810ac5f39dfc62f0a326614a79bb0
Reviewed-on: https://chromium-review.googlesource.com/c/1317890Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#606076}

For XCTests there will be more than 2 arguments, therefore
we need to take second argument, not the last one.

Change-Id: Ie3bcac032d49e5e75812dcf7bd248e550c73a244
Reviewed-on: https://chromium-review.googlesource.com/c/1317856Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Artem Titarenko <artit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606075}

Since PDFs don't contain webassembly.

Once this lands, we should consider doing the same thing for
the proxy_resolver_v8.cc file as well.

Change-Id: If9e33defb4ea4124eefd6555a5331cfe3f0e22b4
Reviewed-on: https://chromium-review.googlesource.com/c/1321050Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606074}

Removes some potential attack surface since wasm isn't expected
as part of proxy resolution.

Change-Id: I82b6519a3d60a5577796fe0627f5750234032849
Reviewed-on: https://chromium-review.googlesource.com/c/1321578Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606073}

Change-Id: I5e204e091809a1640856aacfc3126cd63a40a75f
Reviewed-on: https://chromium-review.googlesource.com/c/1323074
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606072}

This patch is related to crrev.com/i/707588

Bug: 900522
Change-Id: Ib0ba6bcebe7fa88b4ebc7e3c52a20eb0fb8e5276
Reviewed-on: https://chromium-review.googlesource.com/c/1310814
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606071}

Change-Id: I753bd193538544cfec8883b37d87f74d8a44d581
Reviewed-on: https://chromium-review.googlesource.com/c/1300075Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606070}

This also enables NetworkServiceRestartBrowserTests on Android, since
OOP NS is supported now.

Bug: 901026
Change-Id: If66c1fcd7d0286fd2bf545dc406e541c69fd77a8
Reviewed-on: https://chromium-review.googlesource.com/c/1313111Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606069}

bug: skia:8527
Change-Id: I44de70acf82680d1a446c1c1a811c34322e047d9
Reviewed-on: https://chromium-review.googlesource.com/c/1320514
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606068}

Previous to this CL, any value could be passed to this function,
which caused problems if very large values were used. See
https://crbug.com/899482 for an example. Per the discussion there,
100X seems like a reasonable limit.

Bug: 899482
Change-Id: I0ed9b68510bf9462c76dcf85e6954df416c0df2f
Reviewed-on: https://chromium-review.googlesource.com/c/1320015Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606067}

This will prevent packages that have been installed but not yet
explicitly launched by the user, as well those that have been force-
stopped, from being the target of an Intent from the web.

Bug: 607966
Change-Id: I17e1168a7ee8a73e1b42175f7bd0b6f2e61aed04
Reviewed-on: https://chromium-review.googlesource.com/c/1316112Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606066}

Before: autofill assistant would trigger automatically.
After: Autofill assistant shows the init screen first, and the "ok"
button must be clicked for autofill to proceed. The init screen can be
deactivated by checking the dont_show_init_screen checkbox.

https://screenshot.googleplex.com/8sRtJSAqVjG

Binary-Size: Increase is due to adding new images for the background of the onboarding screen.
Bug: 806868
Change-Id: I9b2aa8a537698cdc2d36dd5a1b0fa37aa87091b9
Reviewed-on: https://chromium-review.googlesource.com/c/1296501
Commit-Queue: Ernest Galbrun <galbrun@google.com>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606065}

This is not used in views lock screen. The implementation is also complicated
and possibly crashy if UnlockOnLoginSuccess is called twice.

One side-effect of this cleanup is that views lock screen now dismisses 400ms
faster, because it was never calling UnlockOnLoginSuccess and instead relied on
the fallback handler.

Bug: 902451
Change-Id: I16c02dab2b263ee7fa304490e3df0bc002252a41
Reviewed-on: https://chromium-review.googlesource.com/c/1320794Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606064}

instead of defining a custom MockSyncService that isn't used as a mock.

Bug: 859874
Change-Id: If1458426ff77a666a2be0dc08513a87b26ad76b0
Reviewed-on: https://chromium-review.googlesource.com/c/1322710Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606063}

This prevents us from recording canvas size multiple times for the same
canvas. Also confirmed that we are recording the correct numbers and
move `isOffscreen` to an enum.

Bug: 902000
Change-Id: Ic6e66ec960ae0166699280303a61b574c9320294
Reviewed-on: https://chromium-review.googlesource.com/c/1319180
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606062}

There's several singletons / global instances in c/b/rc that are leaked
at shutdown, this is causing some issues in runs of unit_tests because
we end up re-using them between different test runs that should be
independent. This is currently preventing some feature to be enabled.

This CL add a new ResourceCoordinatorParts class that encapsulate all
these objects that should be created only once, an instance of this
class is owned by the browser process.

Change-Id: Ia64618b6f47052815d861ff6820d994f8a65cc64
Reviewed-on: https://chromium-review.googlesource.com/c/1290775Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606061}