GitLab

Test: Upload to gerrit > open file > click "gitiles"
Change-Id: I57a31e628e7aca2f73031603765b84ab88bcc4f9
Bug: 918221
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894102
Commit-Queue: Andrew Luo <aluo@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712623}

TBR=afakhry@chromium.org

Bug: 1021553
Change-Id: I6d6170beb77d08da192d24e7ebb7246a83926a7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899334Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712622}

This is a reland of 08aba315

Original change's description:
> Register the updater app id in registry (Windows).
> 
> Send both the updater and Chrome app ids in the "update apps" use case.
> With this change, --install and --ua commands work as expected, meaning
> the app ids and the versions are sent during update checks.
> 
> There is a edge case, not handled currently, where the app id for
> the updater is not available until the first update check has happened.
> This is going to be resolved in a future CL which lands as part of
> fixing this CR bug.
> 
> R=waffles
> 
> Bug: 1020285
> Change-Id: I2856a795ed61f590f85d792e4d5e1493bd23b84f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894833
> Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
> Commit-Queue: Sorin Jianu <sorin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#712315}

Bug: 1020285
Change-Id: I697899571376170de6b70b547a04b56fbd4a7647
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898810Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712621}

This reverts commit b0985684.

Reason for revert: Speculative revert. Suspect this is causing renderer crashes for

webaudio/AudioBuffer/huge-buffer.html
webaudio/dom-exceptions.html

https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Win10/58083

Original change's description:
> [arraybuffer] Switch backing store from DataHandle to v8::BackingStore
> 
> With this CL we finally use v8::BackingStore as the backing store
> implementation of blink::ArrayBuffer.
> 
> Changes:
> * Use v8::BackingStore as the backing store for ArrayBufferContents.
> * Remove ArraybufferContents::DataHolder and
>   ArrayBufferContents::DataHandle.
> * Replace all uses of DataHolder in ArraybufferContents with uses of
>   v8::BackingStore.
> * Replace the use of DataHandle in the V8 bindings.
> * Add an exception to the presubmit check to allow std::shared_ptr in
>   ArrayBufferContents. It is contained there and does not escape.
> 
> R=​haraken@chromium.org, ulan@chromium.org
> 
> Bug: chromium:1008840
> Change-Id: Iffa31e889daf4ae54de96f55b4612833d096a884
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886858
> Commit-Queue: Andreas Haas <ahaas@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#712571}

TBR=ulan@chromium.org,haraken@chromium.org,agrieve@chromium.org,ahaas@chromium.org

Change-Id: I88668a9d2d582ef38ccb82f1c87139da4c74db62
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1008840
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899413Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712620}

Change-Id: I252546eaea91551d7a2d08f0f8290a2cb62f8278
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893065
Commit-Queue: Mark Cogan <marq@chromium.org>
Auto-Submit: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712619}

As we introduced paddings of the buttons inside oobe dialog - external overlay
is not displayed properly (see bug for screenshots).

Also use the overlay on the enrollment screen

Fixed: 1013337, b/143346960
Test: manual on the device
Change-Id: I22a1cf67c39221c378b0a5a6f0c7d5ab978287af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892963Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712618}

Add the text of the open alert when returning UnexpectedAlertOpen.

Bug: chromedriver:3184
Change-Id: Ifcd0e59c0d5d32089fca20b01b6f626ea5b4e741
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898385Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tricia Crichton <triciac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712617}

https://webrtc.googlesource.com/src.git/+log/198345898168..4c04d8e10c3c

git log 198345898168..4c04d8e10c3c --date=short --no-merges --format='%ad %ae %s'
2019-11-05 mbonadei@webrtc.org Fixing autoroller/roll_deps.py.
2019-11-05 sprang@webrtc.org Reland "Refactors BitrateProber with unit types and absolute probe time."

Created with:
  gclient setdep -r src/third_party/webrtc@4c04d8e10c3c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None
Change-Id: Ie50f27e666748794a698b6972133d42f7658ae22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899331Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712616}

Bug: 925323
Change-Id: I02b3d2cf43b30f4fb3a8cb6f5f23fd7387439826
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894706
Auto-Submit: Avi Drissman <avi@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712615}

https://chromium.googlesource.com/catapult.git/+log/a05f421623d7..6e71a5063590

git log a05f421623d7..6e71a5063590 --date=short --no-merges --format='%ad %ae %s'
2019-11-05 perezju@chromium.org [tracing] Rename 'tir_label' to 'grouping_label'.

Created with:
  gclient setdep -r src/third_party/catapult@6e71a5063590

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC skyostil@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=skyostil@google.com

Bug: chromium:974237
Change-Id: I8866579b93d14f47b951deb340ed6fcabaaeabf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899330Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712614}

Bug: 1014583
Change-Id: I687791397584b780d46b7674abe337a0fb72d5b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899780Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712613}

Not sure if something has changed, but it seems to work fine now even
with Annotation Processors.

Change-Id: I3c803c0170e883b5266726418d0980d5e23fa1e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898277
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712612}

FakeServer state isn't restored after pre-test, so commit error isn't
set in the beginning of main test. It means that we can't assert server
Nigori to have implicit passphrase type after SetupClients() call.

Bug: 1021539
Change-Id: If1cae01f3c66c8f569023bd5055e3dbd2a76d3f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899776Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#712611}

Get NotificationDisplayService lazily so that browser
tests can use NotificationDisplayServiceTester.

Bug: 1020582
Change-Id: Ifc85c2e63e6ca1c17eb29fdbfa91624802220ecd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899847Reviewed-by: Richard Knoll <knollr@chromium.org>
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712610}

A block that has zero block-size fits within zero space, so if we have
exactly zero space left in a fragmentainer, the block shouldn't be
pushed to the next fragmentainer.

Discovered this while working on column-rule support;
fast/multicol/span/triply-nested-multiocol-zero-height-inner-with-spanner.html
started to fail, because we had one column more than expected.

fast/multicol/transform-inside-opacity.html will regress with this
change, because we're really bad at fragmenting floats, and now the poor
float ended up exactly at the end of the first column (instead of
(incorrectly but oh so helpfully) being pushed to the beginning of the
next by its parent).

Bug: 829028
Change-Id: I66d44699c44cf7e7371f196babd424a971bfd65d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899769
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712609}

This removes the constraint for all bypassed RenderPasses to have
an opacity of 1 and src-over blending. As long as the inner content's
blend mode is a coefficient blend mode, we can reason about how it
would have combined with the implicit transparent black of the
RenderPass's initial clear color.

Bug: 1013735
Change-Id: I8d1849db254c4eff3f33b57f32204d6d439f0b83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862662
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712608}

Pass |true| for |delay_initialization_until_set_client| when creating the NetworkService in-proc so that the |NetworkServiceParams| passed in |SetClient| are honored.

Change-Id: I4869ec227b2a7ed9d9fa07d74b2e45a2e962ef66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897490Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Scott Sheehan <ssheehan@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#712607}

Using wpt-import in Chromium dab93995.
With Chromium commits locally applied on WPT:
1d5b803f "Add WebVTT support for inline styling - Web Platform Tests"
1b0a991d "Force error page to be classified as cross-document."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I68a95b2f4e679efe44e1076aea1086a94e49a159
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898184Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712606}

https://skia.googlesource.com/skia.git/+log/fb9146ffc7fc..cfa4f60270cf

git log fb9146ffc7fc..cfa4f60270cf --date=short --no-merges --format='%ad %ae %s'
2019-11-05 mtklein@google.com simpler uniforms() api

Created with:
  gclient setdep -r src/third_party/skia@cfa4f60270cf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ethannicholas@google.com

Bug: None
Change-Id: I545414e608b963bade2f8f94e271032227b1373a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899329Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712605}

This CL whitelists the strings needed to show SSL error interstitials
for non-overridable SSL errors (i.e., errors where the user is not
allowed to proceed).

To test: Visit badssl.com in weblayer_shell on Android, tap on
"mitm-software", and test that an SSL error interstitial shows wherein
the buttons are "Reload" and "Advanced", and clicking on "Advanced"
does not present an option to proceed. In particular, the app should
not crash :).

Change-Id: I4cb8b4aa2289bc0830eaa7e035779e64e3498fb8
Binary-Size: Increase is due to translations and so cannot be avoided.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899608
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Pavel Shmakov <pshmakov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712604}

The CacheStorageAddAllRejectsDuplicates feature was fully launched in
M72 and the backing code was removed in M75.  The runtime feature
entry was missed in the removal of the feature code.

Bug: 720919
Change-Id: Ie6d2fe0d044fe1216fb2724a6c5fdc78f9376529
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895396Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712603}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3b1f341d0028..b48a39e6e2c8


Created with:
  gclient setdep -r src-internal@b48a39e6e2c8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I25aa349f1eebec2ed621aef0eecf83d328406c51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899328Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712602}

BUG=546640
R=tmartino@chromium.org


Change-Id: I0b1e57d40e2885e11c43d177a2a41e7354380eae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899449
Auto-Submit: Greg Thompson <grt@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712601}

Bug: 1020493
Change-Id: Ia8b943288ea32f7deaa1349854807e101b37ebfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899493
Commit-Queue: Monica Basta <msalama@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712600}

The datatype is no longer relevant.

Bug: 965503
Change-Id: Ifd4a429c79551a0e9ea231b3a1648f096647fec0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894008
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712599}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9ab48dcc..63c55152

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I001b04c2f39412c188d8201cb00648d605e0886c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898185Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712598}

TBR=rsorokin@chromium.org

Bug: 1021191
Change-Id: I995b941df37064ace4808b7ba04d7c415011270a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899503Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712597}

https://chromium.googlesource.com/devtools/devtools-frontend/+log/2cf0518ef4..879d97b05d

TBR=tvanderlippe@chromium.org

Change-Id: I11df43bcd455377735bb270f916551e7714ffb47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899766Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712596}

Convert usage of GTMStringEncoding that were used to convert
to/from base64 (possibly the web safe variant) to use //base
instead (which provides an encoder/decoder).

Remove dependencies on //third_party/google_toolbox_for_mac
from //ios/chrome that are no longer used (i.e. the code do
not use GTM and the include are stale).

Removing those dependencies may enable Chrome on iOS to drop
the dependency on //third_party/google_toolbox_for_mac.

Bug: none
Tbr: rsesek@chromium.org
Change-Id: I82939c005c762a9914ece809ec3e7767ed8db729
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899458
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: David Jean <djean@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712595}

This reverts commit 549944d5.

Reason for revert: Suspected culprit of WebMediaPlayerImplTest.Encrypted test failures

The failure appears deterministic on windows: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/42005

but also will flake often on other platforms:
https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVySgsSBUZsYWtlIj9jaHJvbWl1bUBtZWRpYV9ibGlua191bml0dGVzdHNAV2ViTWVkaWFQbGF5ZXJJbXBsVGVzdC5FbmNyeXB0ZWQM

Original change's description:
> media: Move Renderer creation to PipelineImpl
> 
> Instead of creating the Renderer in PipelineController before pipeline
> start which includes Demuxer initialization, this CL moves Renderer
> creation to PipelineImpl as a step in PipelineImpl::Start() so that the
> Renderer is only created after the Demuxer has been initialized. This
> makes it possible to have more flexible Renderer creation, e.g. create
> different Renderers based on different stream or CDM.
> 
> Bug: 1018372, 827990
> Test: No functionality change.
> Change-Id: I7398d90915df7905bd627f4e4cf82fae40252ee1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895747
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#712397}

TBR=dalecurtis@chromium.org,xhwang@chromium.org

Change-Id: Iac06fd02de8b4e436ecb16638994cd1b9fb1f7e7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1018372, 827990
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899873Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712594}

Change-Id: I1721c0cb2360bacc87599cb8e0a88d9ee95d1893
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899463
Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712593}

https://android.googlesource.com/platform/external/perfetto.git/+log/d66586f24210..0da64443b6c7

git log d66586f24210..0da64443b6c7 --date=short --no-merges --format='%ad %ae %s'
2019-11-05 taylori@google.com Merge "Fix parsing of systrace events"

Created with:
  gclient setdep -r src/third_party/perfetto@0da64443b6c7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I3d98c0175c8961c46fa5af5f036b4d3b2e90a409
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899182Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712592}

Add pasko@, lizeb@, mthiesse@ as owners of all MADV_FREE DiscardableMemory
primitives under base/memory.

Bug: 1014513
Change-Id: I44e42fdd9ab10745c8ddf04736402dad71566aad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896767Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Gordon Guan <gordonguan@google.com>
Cr-Commit-Position: refs/heads/master@{#712591}

TBR=dtapuska@chromium.org

Bug: 1021541
Change-Id: I5632a07aa96ed1d99bd4ed2b2a2a63f6f32c8a6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899866Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712590}

The fix to protect against login database downgrade has been included
in version Chrome 78. However, users running Chrome 77 still suffer
from this issue and could potentially download the login database
from version 25 to 24 without changing the schema.
Chrome 25 however introduce a new column in the login database.
Therefore, trying to migrate again from version 25 to 24 would actually
fail and results in password manager to stop working.

Before this patch:
If users enter this broken stay, they will stay there indefinitely.

After this patch:
The code would auto-correct the version for such broken state.

The issue has been reported in the public support forums.
Details are in the linked bug.

This CL in addition adds the proper testing for this user flow.

Bug: 1020320
Change-Id: Ib97e26a21ba4840f599e599edc75835292584873
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899462Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712589}

Previously, the frame's RenderFrameHost (RFH) was selected
based on its name / url. This only works if the site actively
sets the name attribute on the iframe it uses, which was not
done everywhere. Resolving with id seems more stable.
Fallback to name / url is kept in place for the time being.

This fixes the resolution (and thus the autofill) for both local
iframes and OOPIF.

Note: This is a copy of crrev/c/1893876
Refer to that for discussions. The original change could not be
submitted because an unintended somehow irreversible checkin blocked
the submit.

Bug: b/143318024
Change-Id: I6fc3ea0d210b500e06769c5129e00766d933eb65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899775Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Commit-Queue: Sandro Maggi <sandromaggi@google.com>
Cr-Commit-Position: refs/heads/master@{#712588}

The popErrorScope() was changed to reject with an OperationError if the
GPUDevice is lost[1]. So, this patch matches up with the spec. Also,
although the spec doesn't mention it yet, we should make it throw an
OperationError for all cases where the device is lost.

[1] https://github.com/gpuweb/gpuweb/pull/433

Bug: 852089
Change-Id: I3a80b5e741e1ea831fd92aa2eb3dcdafd6bc740e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898891Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712587}

Evidenced by issue 1014385, extensions may be using the names of
GuestViews for other purposes when a GuestView element is not available.
In order to avoid name collisions with user code, we no longer define
the error-providing elements in contexts where it is not possible to
declare the necessary permission.

Bug: 1014385
Change-Id: Icdf764c2bb19165cc173226e74e6f71eb7c99e1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869399Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712586}

R=dgozman@chromium.org

Change-Id: I4d298d596f9761cad1a19f4c0c69905df74322b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898649Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712585}

And pass the NIK to TransportConnectJob through its parameters, except
when connecting to proxies.

The SOCKS4 path does not yet pass in NIKs for resolving destination
server hostnames, which I'll do in a followup.


Bug: 997049
Change-Id: I13dae896cfbb4286c6e8107637a1b624dc800eb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894469Reviewed-by: Eric Orth <ericorth@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712584}