Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 21 Aug, 2018 25 commits
  3. 20 Aug, 2018 15 commits
    • Christopher Cameron's avatar
      RemoteMacViews: Ensure window and view updates are synchronized · f2bae22e
      Christopher Cameron authored 
      When updating the views::View size, ensure that the NSWindow size be
updated first (otherwise we end up with strange mismatches). Add a
TODO about merging methods here.

This requires access to the BridgedNativeWidget from
BridgedContentView, so make BridgedNativeWidget store a pointer to
BridgedContentView (from which it can access BridgedContentViewHost),
rather than storing a pointer to BridgedContentViewHost. Also change
one instance where we pulled the BridgedContentView from the NSWindow
to use the pointer directly.

Bug: 875776, 875731
Change-Id: Ia9c3d4238f6824e5595baa5d4e856c34ead0fb75
Reviewed-on: https://chromium-review.googlesource.com/1181926
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584582}
      f2bae22e
    • gogerald's avatar
      [Autofill Assistant] Enable jumbo build · af838104
      gogerald authored 
      Bug: 806868
Change-Id: I60b3d97e7418a7b5eccc5c9f4ee96be8e6e0b187
Reviewed-on: https://chromium-review.googlesource.com/1182198Reviewed-by: default avatarRouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584581}
      af838104
    • Martin Kreichgauer's avatar
      fido: populate TransportAvailabilityInfo.has_recognized_mac_touch_id_credential · e122308b
      Martin Kreichgauer authored 
      This introduces PlatformAuthenticatorInfo as a parameter object to
FidoRequestHandlerBase::SetPlatformAuthenticatorOrMarkUnavailable. The
struct holds the existing std::unique_ptr<FidoAuthenticator>, which is
the platform authenticator itself, and an additional bool indicating
whether the authenticator has a matching credential for
GetAssertionRequest. The bool is plumbed through to
TransportAvailabilityInfo for consideration by the UI.

Bug: 847985
Change-Id: Ice46685eef31eb29cb8fdcb0d471e4b40bfb97b3
Reviewed-on: https://chromium-review.googlesource.com/1179088
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: default avatarBalazs Engedy <engedy@chromium.org>
Reviewed-by: default avatarJun Choi <hongjunchoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584580}
      e122308b
    • Tibor Goldschwendt's avatar
      [android] Forward uncompress_shared_libraries flag to bundle modules · ae5bd514
      Tibor Goldschwendt authored 
      This fixes a startup crash of the Chrome modern bundle where
uncompress_shared_libraries was erroneously set to false for the Chrome
modern base module.

Bug: 875872
Change-Id: Ie9817ea350f4703950608eff35e5b6129cb9e508
Reviewed-on: https://chromium-review.googlesource.com/1181936
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: default avataragrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584579}
      ae5bd514
    • Ned Nguyen's avatar
      Disable failing v8.browsing_destop stories on win 10 · 37874bdb
      Ned Nguyen authored 
      TBR=mythria@chromium.org, ulan@chromium.org
NOTRY=true

Bug: 875159
Change-Id: I3e8df16078427553a28a7df8daf7a798453e0dcf
Reviewed-on: https://chromium-review.googlesource.com/1182481Reviewed-by: default avatarNed Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#584578}
      37874bdb
    • Jacob Dufault's avatar
      cros: Do not enable login-screen shortcuts on lock. · cc16d704
      Jacob Dufault authored 
      Calling the shortcut may cause chrome to crash, as the chrome-side handler
assumes the login screen is active.

Bug: 875778
Change-Id: Ib297d5239c9198d0cd047bd2b5e240dbc1d49ca8
Reviewed-on: https://chromium-review.googlesource.com/1182184Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584577}
      cc16d704
    • Anders Hartvoll Ruud's avatar
      Don't re-resolve custom properties. · bc90fa26
      Anders Hartvoll Ruud authored 
      When we inherit a set of custom properties, without modifying that set,
we don't need to resolve those properties again. Also, we only need to
resolve at all if any values with var()-references have been observed.

This CL simply stores a flag which indicates whether the
Style[Non]InheritedVariables instance contains unresolved var()-
references or not. This fixes a performance issue where variables
specified on :root would be re-resolved for all elements in the tree.

Bug: 875123
Change-Id: I1f68b4c78465c1c09a2b4951207f8bf4eb855e45
Reviewed-on: https://chromium-review.googlesource.com/1180209
Commit-Queue: Anders Ruud <andruud@chromium.org>
Reviewed-by: default avatarRune Lillesveen <futhark@chromium.org>
Reviewed-by: default avatarEmil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584576}
      bc90fa26
    • Tommy Steimel's avatar
      Revert "[Media Controls] Prevent ComputedStyleRef crash in overlay play button" · 9b8d5f40
      Tommy Steimel authored 
      This reverts commit 0c629790.

Reason for revert: The crashes are still occurring and I realized I misinterpreted the initial crash reports. Going to land a different CL which fixes the actual problem.

Original change's description:
> [Media Controls] Prevent ComputedStyleRef crash in overlay play button
> 
> This CL adds a check in MediaControlOverlayPlayButtonElement that
> prevents a call to ComputedStyleRef is ComputedStyle is null. This
> prevents a crash we're seeing in certain cases on Windows and Mac.
> 
> Bug: 870490
> Change-Id: Ia45a7239084b267ce8a352fc0a825b5c992c5eea
> Reviewed-on: https://chromium-review.googlesource.com/1173471
> Reviewed-by: Hayato Ito <hayato@chromium.org>
> Reviewed-by: Becca Hughes <beccahughes@chromium.org>
> Commit-Queue: Tommy Steimel <steimel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#583523}

TBR=hayato@chromium.org,beccahughes@chromium.org,steimel@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 870490
Change-Id: Ied6ea0c564c478ade8f670f72c5369785bb4cacf
Reviewed-on: https://chromium-review.googlesource.com/1181681Reviewed-by: default avatarTommy Steimel <steimel@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584575}
      9b8d5f40
    • Miguel Casas's avatar
      GMBVFPool: bail if VideoFrame format forces change of OutputFormat · ecd725db
      Miguel Casas authored 
      ClusterFuzz encountered an issue if a given VideoFrame comes and
causes a change of OutputFormat: in the bug below, an I420 VF
was received after a series of I420A ones, and caused a crash
when the alpha channel was accessed. This might happen more
generally if the received VideoFrames cause a change of
OutputFormat and we access what we don't have.

This CL addresses that by comparing the current |output_format_|
with what is derived out of the incoming VideoFrame. If they
differ, we just bail.

Bug: 875158, 875670
Change-Id: I961b5bf95651a3888482957ee0b7acd48149d467
Reviewed-on: https://chromium-review.googlesource.com/1180543
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: default avatarDale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584574}
      ecd725db
    • Xianzhu Wang's avatar
      Reland "[CI] Cleanup paint invalidation flags" · 7eddbaab
      Xianzhu Wang authored 
      This relands commit 8a53cc3a with
the following change compared to the original CL:

- SetShouldCheckForPaintInvalidationWithoutGeometryChange() no
  longer unconditionally calls GetFrameView()
  ->ScheduleVisualUpdateForPaintInvalidationIfNeeded()
  but SetShouldDoFullPaintInvalidationWithoutGeometryChange()
  does. This logic is the same as the current ToT before this CL,
  and the same as before the reverted CL. This fixes the
  performance issue that is caused by too frequent calls to
  ScheduleVisualUpdateForPaintInvalidationIfNeeded() from
  SetShouldCheckForPaintInvalidation().

Original change's description:
> Revert "[CI] Cleanup paint invalidation flags"
>
> This reverts commit 8a53cc3a.
>
> Reason for revert: Performance regressions crbug.com/875321.
>
> BUG=875321
>
> Original change's description:
> > [CI] Cleanup paint invalidation flags
> >
> > - Use separate flags HasDelayedFullPaintInvalidation and
> >   SubtreeShouldDoFullPaintInvalidation in LayoutObject instead of using
> >   paint invalidation reasons kSubtree and kDelayedFull to simplify logic
> >   handling them.
> >
> > - Other cleanup and simplications
> >
> > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> > Change-Id: I0946c042c80195dd6cf1d4a9e8c3554dbad1871d
> > Reviewed-on: https://chromium-review.googlesource.com/1123018
> > Reviewed-by: Philip Rogers <pdr@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#583772}
>
> TBR=wangxianzhu@chromium.org,pdr@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Change-Id: I6f12dd7fe621f88e5a0fe1b96637b2ecc813e78e
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Reviewed-on: https://chromium-review.googlesource.com/1180305
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#584248}

Change-Id: I22ff44656c7994e7814565330042e08832f30f91
Bug: 875321
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1180309Reviewed-by: default avatarPhilip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584573}
      7eddbaab
    • Tommy Martino's avatar
      [Autofill Views] Adding Layout Experiment · 3fa3df5c
      Tommy Martino authored 
      This CL adds the flag, feature, and parameters for an upcoming
experiment which will modify the layout of the Autofill dropdown on
Desktop. It also adds the capability to display the icon on the left,
rather than the default right, of each row of the dropdown, which is
the expected behavior under certain experiment groups.

Change-Id: I90ceb546887a76eb836e4aac19ae96ba1a9d107e
Bug: 870342
Reviewed-on: https://chromium-review.googlesource.com/1152217
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Reviewed-by: default avatarVasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: default avatarFabio Tirelo <ftirelo@chromium.org>
Reviewed-by: default avatarSebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584572}
      3fa3df5c
    • Devlin Cronin's avatar
      [Extensions] Introduce an ExtensionsAPIProvider · df96db57
      Devlin Cronin authored 
      Introduce an ExtensionsAPIProvider that contains knowledge of
generated APIs and extension features. The ExtensionsClient
contains multiple ExtensionsAPIProviders, and queries these
providers for features and generated API schemas. This allows the
registration of APIs from outside the extensions system, which will
be necessary for moving Chrome Apps API registration outside of
extensions code. This also more effectively wraps the logic relating
to the generated features within a single location, minimizing the
burden for consumers to add/check multiple generated sets.

Create an API Provider for each set of code that generates unique
features and APIs:
- Core Extension APIs (defined in //extensions)
- Chrome Extension APIs (defined in //chrome)
- Shell Extension APIs (defined in //extensions/shell)
- Cast Extension APIs (defined in //chromecast)

When the corresponding ExtensionsClient type is constructed, it
registers the appropriate providers.

Bug: 873937
Change-Id: I198e5e5cbd6ab53bff9e335ea1551bdcfe59f521
Reviewed-on: https://chromium-review.googlesource.com/1172000Reviewed-by: default avatarDominick Ng <dominickn@chromium.org>
Reviewed-by: default avatarLuke Halliwell <halliwell@chromium.org>
Reviewed-by: default avatarIstiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584571}
      df96db57
    • Amirhossein Simjour's avatar
      VR: fix Bluetooth indicator · 4c8444fe
      Amirhossein Simjour authored 
      Fixed the typo in the code that was showing screen_capture_indicator
instead of the bluetooth_in_use indicator.
This was introduced here:
https://chromium-review.googlesource.com/1151711

Change-Id: I7e541b835f37489b78b901e53df91967fa78e434
Reviewed-on: https://chromium-review.googlesource.com/1182004Reviewed-by: default avatarIan Vollick <vollick@chromium.org>
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584570}
      4c8444fe
    • Joe Downing's avatar
      Fixing a NMH crash on Windows · d8f828e3
      Joe Downing authored 
      A recent CL added a Mojo dependency to our host binaries.  This caused a
crash on Linux/MacOS (crbug.com/875462) which was recently fixed. I then
saw a crash in the NMH on Windows when starting the CRD App.  This is due
to the same root problem but in our Me2Me NMH binary this time.  I've
fixed the init problem and verified I can set up a host again.

I've also tested It2Me on Windows and it works fine.

BUG=875953

Change-Id: Ia22e45aa2d9ed0b1e27595e1cee1038676278b70
Reviewed-on: https://chromium-review.googlesource.com/1181928Reviewed-by: default avatarGary Kacmarcik <garykac@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584569}
      d8f828e3
    • Eric Karl's avatar
      Revert "Use texture manager and mailbox manager helper functions" · 0c5e2932
      Eric Karl authored 
      This reverts commit 8d5f940b.

Reason for revert: Causing crashes as the new helper functions don't
check for a null |group_| before using it.

Original change's description:
> Use texture manager and mailbox manager helper functions
>
> Bug: None
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: Ic817611158f48229c031161e4c8a6e7ac949b918
> Reviewed-on: https://chromium-review.googlesource.com/1161601
> Commit-Queue: Xing Xu <xing.xu@intel.com>
> Reviewed-by: Eric Karl <ericrk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#583170}

TBR=xing.xu@intel.com,ericrk@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 874788
Change-Id: I0118144f2fa5c186bbabd7f61b7377d2e201631b
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1181585
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: default avatarEric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584568}
      0c5e2932