GitLab

Bug: 716490
Change-Id: I08c9bc35d1e9f8f86adc6c88fb7ab8069bcf7e8f
Reviewed-on: https://chromium-review.googlesource.com/1072918Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563169}

Add pause/resume on focus changes in ARCoreDevice to correctly
pause/resume ARCore.

Bug: 838513, 837550

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I40f11c48c6a9f15b3a558546e017545f0ab66a1d
Reviewed-on: https://chromium-review.googlesource.com/1046112Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Iker Jamardo <ijamardo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563168}

Previously, TrayPopupItemStyle colors are just switched by the flag
--enable-features=SystemTrayUnified. However, we had some other tray
bubbles (PaletteTray and ImeMenuTray) that use TrayPopupItemStyle,
and in these places we don't want the colors to be changed.

To prevent this, we add |use_unified_theme| flag to TrayPopupItemStyle,
and explicitly set false in PaletteTray and ImeMenuTray.

TEST=manual
BUG=847319

Change-Id: I183f9b9ddaca1adf2063b7e40bef9438c451ae48
Reviewed-on: https://chromium-review.googlesource.com/1075844Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563167}

After forcing the old layout for ruby, many of the failures
turned out to be text dump differences. The text dupm shows
that there is 15px difference in the width of the container,
but it is not noticeable visually nor from inspector.

This patch rebaselines all such failures.

Also removes fullscreen/full-screen-line-boxes-crash
-expected.txt as it now matches to the base expectation.

TBR=atotic@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I321f324a269b036733aeb029c2a0331fc8ce10ce
Reviewed-on: https://chromium-review.googlesource.com/1080470
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563166}

They work correctly now according to the result of
MathExtrasTest.infinityMath without the workaround.

Change-Id: Ifbf1a0a3f4f717d70b06095ae814919b45fb7677
Reviewed-on: https://chromium-review.googlesource.com/1078187Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563165}

Legacy vertical-rl coordinates ignore scrollbars. This is wrong,
but we have to be Legacy compatible.

1 additional test passes, but it is a good one,
tests all writing modes.

css3/flexbox/scrollbars.html

Bug: 841587
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ie3093ceda3b6a1f1855f9e2353df69583e3c8f43
Reviewed-on: https://chromium-review.googlesource.com/1080233
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563164}

https://chromium.googlesource.com/angle/angle.git/+log/95fb2a1..86ce210


git log 95fb2a1..86ce210 --date=short --no-merges --format='%ad %ae %s'
2018-05-22 jmadill@chromium.org Vulkan: Clean up onResourceChanged.
2018-05-30 jmadill@chromium.org Vulkan: Clean up object releasing APIs.
2018-05-18 jmadill@chromium.org Vulkan: Mark some Resource APIs are protected.
2018-05-30 jmadill@chromium.org Vulkan: Make Resource's updateSerial private.
2018-05-29 ynovikov@chromium.org Add Android Vulkan trybots to ANGLE CQ

Created with:
  gclient setdep -r src/third_party/angle@86ce210

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:839893

TBR=jmadill@chromium.org

Change-Id: Id023a4548840073e574cc861f27f6c0a249092fa
Reviewed-on: https://chromium-review.googlesource.com/1079642Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#563163}

BUG=chromium:848017
TEST=run unit tests, manual test on kevin, autotest on kevin

Change-Id: I713940fc7e0f76e09385cf0691c536a0ff9227ea
Reviewed-on: https://chromium-review.googlesource.com/1079800
Commit-Queue: May Lippert <maybelle@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563162}

Change-Id: I86106fe1d67f9365633d3bfdc8da3bdb19f60816
Bug: 845780
Reviewed-on: https://chromium-review.googlesource.com/1077871Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563161}

This way, DEPS files can also know whether they're building with chromium
or not.

Bug: 782846
Change-Id: I43885e2b9aa1e72b612c17569a23d47e74835273
Reviewed-on: https://chromium-review.googlesource.com/1077619Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563160}

When the currently focused editable element is nested in an uneditable
element (see the new layout test in this CL as an example), cold mode
spellchecker may create invalid checking ranges:
- the range starts at the end position of the last sentence
- the range ends at the last position in the focused editable element
- when the editable element is nested in uneditable element, a reversed
  range is created

This patch fixes the issue by using the highest root editable as the
element to check, so that all sentences are within the element.

To ensure that uneditable nodes in the highest root are not marked, this
patch also modifies SpellChecker::IsSpellCheckingEnabledAt() to return
false on uneditable nodes.

Bug: 848026
Change-Id: I26d9852ffc66aad150cf3856fd402fc31e3ad3a0
Reviewed-on: https://chromium-review.googlesource.com/1080215Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563159}

https://skia.googlesource.com/skia.git/+log/51623cc..a9d3dae


git log 51623cc..a9d3dae --date=short --no-merges --format='%ad %ae %s'
2018-05-30 egdaniel@google.com Revert "Use GrVkMemoryAllocator for vulkan memory allocations in ganesh."
2018-05-30 egdaniel@google.com Revert "Move include into head to fix build breakage."

Created with:
  gclient setdep -r src/third_party/skia@a9d3dae

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

TBR=rmistry@chromium.org

Change-Id: I59bd09bd3c3360812244f892ba175c8a989343d1
Reviewed-on: https://chromium-review.googlesource.com/1080367Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#563158}

Bug: 781461
Change-Id: I464ad57e04ad5047dc034f42dc9befd30696f940
Reviewed-on: https://chromium-review.googlesource.com/1080363Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563157}

ServiceWorker needs the information.

Bug: 845408
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I138d02f7bf3cf69b1949be785fb0e57c596d8c06
Reviewed-on: https://chromium-review.googlesource.com/1077880Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563156}

Allow managed users logging into their own device to use their
login password for automatically authenticating to networks.

BUG=chromium:386606
TEST=run unit tests, manual test on kevin

Change-Id: I023472e12abaa39a03ea445358f68a7c1afa9391
Reviewed-on: https://chromium-review.googlesource.com/1058598Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: May Lippert <maybelle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563155}

So:
Include chromeos_switches.h instead of chromeos_switches.cc
Include base_event_utils.h instead of base_event_utils.cc

Typo made a test include a cc file instead of the more commonly
included header file. This patch changes to include the header file.

There are no known bad side effects of this, but it was found
when looking for similar instances of a piece of code that did
cause problems.


Change-Id: I33105752517ba4e423dcae7c1ea0186fc7613127
Reviewed-on: https://chromium-review.googlesource.com/1005065Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#563154}

Additional test for fileManagerPrivate.mountCrostiniContainer
will be added to these files next.

Bug: 845075, 822130
Change-Id: I8e4fbb840764e975b5d670556905f3b4b411f2da
Reviewed-on: https://chromium-review.googlesource.com/1075878
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563153}

Bug: 824130, 847842
Change-Id: I40015be2f20ffb10ea0b95d5dc670a40002d9afc
Reviewed-on: https://chromium-review.googlesource.com/1078917
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563152}

Change-Id: If6df3e805891d319fb48c51fed9652c0020d8cd6
Reviewed-on: https://chromium-review.googlesource.com/1079957Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563151}

Add missing argument to mutateStruct/Union calls.

Bug: 607649
Change-Id: Ie2a3732e3295ac513a9c0ca6f4a3d5742a58cc63
Reviewed-on: https://chromium-review.googlesource.com/1077874Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Oliver Chang <ochang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563150}

This is change #1 of 3 reducing context switching during WebGL
rendering. On tiled rendering GPUs context switches are slow and can
even cause multisampling artifacts. Every time the command buffer is
flushed, a context switch is possible.

Before, the command buffer helper would always autoflush eventually if
no explicit flush was received. Commands would accumulate across
multiple frames until the autoflush threshold was reached. Implicit
flushes caused by ordering barriers were not taken into account.

Now the autoflush decision is based on the last ordering barrier instead
of the last explicit flush. Since there's an ordering barrier at least
once a frame, autoflush will only happen if the threshold is reached
within a single frame.

Bug: 828363,835353
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I168be6892620b1813c598a912e59147f9c45896f
Reviewed-on: https://chromium-review.googlesource.com/1077435Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563149}

Bug: 847738
Change-Id: I49a8cbcaad484f8044a0196901b8cf6140b39388
Reviewed-on: https://chromium-review.googlesource.com/1080357
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563148}

snake_case() and enum_type_name() are not used. Remove them and their
dependent.

Bug: 843927
Change-Id: If93fcb25e1cf26299ed06dc65a9de387c528b15b
Reviewed-on: https://chromium-review.googlesource.com/1080351Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563147}

Bug: None
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia9b7794733fef726c08e40cafed69e1672b071ab
Reviewed-on: https://chromium-review.googlesource.com/1079811Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Shenghua Zhang <shenghuazhang@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Menglu Huang <huangml@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563146}

Bug: None
Change-Id: I04d5fb2959d5e0eb59dfede19c2b9037ae7f8b3f
Reviewed-on: https://chromium-review.googlesource.com/1080355Reviewed-by: Keigo Oka <oka@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Keigo Oka <oka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563145}

Apply PageZoomFactor to image div width for use-zoom-for-dsf
When use-zoom-for-dsf enabled, the visual viewport doesn't have
the device scale factor (DSF) applied, so we need to apply
PageZoomFactor when decide image container size.

This change doesn't need to be under the flag, because when the flag
is disabled, PageZoomFactor is 1.

Bug: 844461
Change-Id: I1e23cafdef387b97f2c446438668a500225c0deb
Reviewed-on: https://chromium-review.googlesource.com/1065145
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563144}

container. Just move items to the end of the range.

std: :remove_if does not actually remove the selected element from the
Change-Id: I3868f83b027e85b36f9097e1325c69cb1a067875
Reviewed-on: https://chromium-review.googlesource.com/1078028Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563143}

The REVOKED status can trigger some of the difference-ignorers that
will be added in followups.

Bug: 649026
Change-Id: I099402d188a7819aaee229a52327187620146434
Reviewed-on: https://chromium-review.googlesource.com/1079705Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563142}

This is the final CL implementing the DNR page whitelisting API. This does the
following:

- The set of whitelisted pages for an extension are passed to the RulesetManager
  which lives on the IO thread. This happens whenever an extension is loaded
  (through RulesMonitorService) or when the set of whitelisted pages is updated
  (through a call to chrome.declarativeNetRequest.[add/remove]WhitelistedPages).
- For each pair of (network request, extension ruleset), RulesetManager checks
  if the request is whitelisted as per the page whitelisting API. This happens
  if the top level frame url corresponding to the request has been whitelisted
  by the extension using the page whitelisting API.

BUG=811460, 696822
Doc=https://docs.google.com/document/d/1Fhm-t0JCc3dcmwyBX_i7TGyuJ2QjqDechv1-VCRBo5o/edit?usp=sharing

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I910c5b481dc8f0b3283374a37c1351a7d7574372
Reviewed-on: https://chromium-review.googlesource.com/1041279
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563141}

 - Add ExecuteWrite to device to commit or abort changes
   in different characteristic
 - Add PrepareWriteValue() in remote characteristic API

A relevant patch is crrev.com/c/1065067

BUG=b:78650442
CQ-DEPEND=CL:1079668
TEST=Pass CtsVerifier test for reliable write on client side. Unittest.

Change-Id: Ibd1a68b9a3a1973c5287b46d41ec652f9d9f8352
Reviewed-on: https://chromium-review.googlesource.com/1065080
Commit-Queue: Qiyu Hu <qiyuh@google.com>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563140}

- Combine ApplyPaintOffsetTranslation into the method. This avoids
  the ambiguous function name.

- Remove unrelated context_.absolute_position.paint_offset and
  context_.fixed_position.paint_offset updates for LayoutView from
  the function. They will be done by existing code in
  UpdateOutOfFlowContext().

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I3cd103cf5d7614f144ebfcf30c3aaa7a75db76f6
Reviewed-on: https://chromium-review.googlesource.com/1080014Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563139}

- create fragments for repeating table sections instead of the old
  SPv1 repeating painting path. The old path changes paint offset
  which didn't work for descendants with paint offset translations.

- Let SVG find the proper fragment to paint.

Bug: 847307
Change-Id: Iae4509885885a784afeed2c34fb932201549d630
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/1079454Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563138}

This CL adds a couple of missing null checks in permissions code to
handle the case where a RenderFrameHost has already been destroyed.

Bug: 754585
Change-Id: I1d009b8ec5776421462cba05ecfb499a51034b10
Reviewed-on: https://chromium-review.googlesource.com/1077878Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563137}

This is always set to false nowdays.

Bug: 789577
Change-Id: Ic52082fe3c0f4a82e9e602a028a2f0c042f559fe
Reviewed-on: https://chromium-review.googlesource.com/1069799
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563136}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=amineer@chromium.org

Change-Id: I61efbd5d0e3670efc8d998f69fd29012d2feec76
Reviewed-on: https://chromium-review.googlesource.com/1080251Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563135}

This change is necessary because GcmDeviceInfoProviderImpl::GetInstance()
returns a const pointer.

Bug: 824568, 752273
Change-Id: I92b84b071e1cd3c782e6b5b0d1e7e25d539da1bf
Reviewed-on: https://chromium-review.googlesource.com/1079645Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563134}

Following a proposed spec change[1], this CL changes the number of entries
buffered by default before the Resource Timing buffer is full.

[1] https://github.com/w3c/resource-timing/pull/155

Bug: 847689
Change-Id: Id93bfea902b0cf049abdac12a98cc4fba7ff1dd3
Reviewed-on: https://chromium-review.googlesource.com/1078107Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Yoav Weiss <yoav@yoav.ws>
Cr-Commit-Position: refs/heads/master@{#563133}

BUG=848092

Change-Id: Icd1ff5e9929f6bed9c7ff657dbcc8a75b39feb35
Reviewed-on: https://chromium-review.googlesource.com/1079806Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563132}

In some cases, the pipeline will not be ready when trying to enter
Picture-in-Picture. It will happen if the video has preloaded its
metadata and has a poster. In this case, the Picture-in-Picture request
will be delayed until the pipeline has started and there is a surface.

Bug: 847671
Change-Id: I56b0560db37ac2e6466abbd3f089973777c49f0f
Reviewed-on: https://chromium-review.googlesource.com/1077453Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563131}

This patch adds histogram logging to the text services context menus,
based on how the simple menu model does histogram logging.

Bug: 838710
Change-Id: I090a02860ea64972386042b3e656fd8534b28d9e
Reviewed-on: https://chromium-review.googlesource.com/1067519Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563130}